Re: [Wireshark-dev] First experience with Visual Studio 2019

2019-12-06 Thread Maynard, Chris via Wireshark-dev
> -Original Message- > From: Gerald Combs [mailto:ger...@wireshark.org] > Sent: Friday, December 6, 2019 6:49 PM > To: Developer support list for Wireshark > Cc: Maynard, Chris > Subject: Re: [Wireshark-dev] First experience with Visual Studio 2019 > > On 12/6/19 1:44 PM, Maynard, Chris

Re: [Wireshark-dev] Adding a new packet to Wireshark

2019-12-06 Thread João Valverde
On 06/12/19 21:29, Dario Lombardo wrote: On Fri, Dec 6, 2019 at 9:58 PM Richard Sharpe mailto:realrichardsha...@gmail.com>> wrote: As Dario has already said, there should not be any problems. You will have to release the changes under the GPL, though. Or any compatible licence.

Re: [Wireshark-dev] First experience with Visual Studio 2019

2019-12-06 Thread Gerald Combs
On 12/6/19 1:44 PM, Maynard, Chris via Wireshark-dev wrote: > * The buildbot is running Cmake 3.14.6 while I’m running 3.15.3.  Should > the buildbot be upgraded? I upgraded it via Chocolatey, which installed 3.16.0. The copy_cli_dlls target failed with that version, so I installed 3.15.5

[Wireshark-dev] First experience with Visual Studio 2019

2019-12-06 Thread Maynard, Chris via Wireshark-dev
In preparation for Wireshark 3.2.0, I installed Visual Studio 2019 today and tried to build Wireshark (yes, from the "x64 Native Tools Command Prompt for VS 2019"). The 64-bit build itself succeeded and I was able to run the compiled Wireshark.exe with "Help -> About Wireshark" details as

[Wireshark-dev] Adding a new packet to Wireshark

2019-12-06 Thread Bruni, Michelle
Hello, I am Michelle and I work at Spirent Communications. We have been building Wireshark for many years because we had a proprietary signature field that we needed to decode and give to our customers. We are looking to open source our signature field and would like to put our packet

Re: [Wireshark-dev] Adding a new packet to Wireshark

2019-12-06 Thread Dario Lombardo
I can't see any blocker in what you're proposing. Feel free to push your proposals and follow the review process. Thanks for the contribution. On Fri, Dec 6, 2019 at 9:50 PM Bruni, Michelle wrote: > Hello, > > I am Michelle and I work at Spirent Communications. We have been building > Wireshark

Re: [Wireshark-dev] Adding a new packet to Wireshark

2019-12-06 Thread Richard Sharpe
On Fri, Dec 6, 2019 at 12:50 PM Bruni, Michelle wrote: > > Hello, > > I am Michelle and I work at Spirent Communications. We have been building > Wireshark for many years because we had a proprietary signature field that we > needed to decode and give to our customers. We are looking to open

Re: [Wireshark-dev] Adding a new packet to Wireshark

2019-12-06 Thread Dario Lombardo
On Fri, Dec 6, 2019 at 9:58 PM Richard Sharpe wrote: > > As Dario has already said, there should not be any problems. You will > have to release the changes under the GPL, though. Or any compatible licence. We have BSD licensed dissectors as well as GPL.