Re: [Wireshark-dev] ZBEE ZCL last modifies

2013-12-09 Thread Alexis La Goutte
Hi Fabio, On Sun, Dec 8, 2013 at 8:16 PM, Fabio Tarabelloni fabio.tarabell...@reloc.it wrote: Hi, today I updated the wireshark trunk folder, and I saw that file packet-zbee-zcl.c is improved adding OTA UPGRADE dissector and others. This file structure was changed in order to simply the

Re: [Wireshark-dev] Build instability

2013-12-09 Thread Kaul
Opened https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9529 on the issue. On Sun, Dec 8, 2013 at 9:52 PM, Jakub Zawadzki darkjames...@darkjames.plwrote: On Sun, Dec 08, 2013 at 09:23:23PM +0200, Kaul wrote: Thanks for the automated build links - I guess I'll watch them more closely

Re: [Wireshark-dev] To display reserved fields or not display reserved fields, that is the question...

2013-12-09 Thread Kaul
Makes sense, done. On Mon, Dec 9, 2013 at 2:34 AM, Edwin Groothuis edwin.grooth...@riverbed.com wrote: Hello, Display it. You are writing a dissector which describes the data seen on the wire, not one which goes “You are not interested in this”. Also, if there is something on the

[Wireshark-dev] How about we change Filter button to say Diisplay Filter on the main Wireshark GUI page ?

2013-12-09 Thread Bill Meier
Maybe this would help to make things a bit more clear. I'd also like to add text to the tooltip: Something like: (To enter a capture filter see Capture/Options) Opinions ? ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] How about we change Filter button to say Diisplay Filter on the main Wireshark GUI page ?

2013-12-09 Thread Graham Bloice
On 9 December 2013 14:34, Bill Meier wme...@newsguy.com wrote: Maybe this would help to make things a bit more clear. I'd also like to add text to the tooltip: Something like: (To enter a capture filter see Capture/Options) Opinions ? As I'm sure others will also point out, I'd prefer

Re: [Wireshark-dev] Add -Wdocumentation

2013-12-09 Thread Alexis La Goutte
Any comment ? no problem ? it is good for you ? On Fri, Dec 6, 2013 at 3:38 PM, Alexis La Goutte alexis.lagou...@gmail.comwrote: Hi, I plan to add -Wdocumentation [1] by default to Wireshark (when build with Clang). I have already fix in trunk the documentation. The major issue to add

Re: [Wireshark-dev] Windows version info

2013-12-09 Thread Graham Bloice
On 8 December 2013 22:32, Pascal Quantin pascal.quan...@gmail.com wrote: Hi Graham, Le 8 déc. 2013 à 22:56, Graham Bloice graham.blo...@trihedral.com a écrit : Compiling with VS2013, the GetVersionEx function is now reported as deprecated: E:\Wireshark\trunk\version_info.c(368): warning

Re: [Wireshark-dev] Windows version info

2013-12-09 Thread Pascal Quantin
2013/12/9 Graham Bloice graham.blo...@trihedral.com On 8 December 2013 22:32, Pascal Quantin pascal.quan...@gmail.com wrote: Hi Graham, Le 8 déc. 2013 à 22:56, Graham Bloice graham.blo...@trihedral.com a écrit : Compiling with VS2013, the GetVersionEx function is now reported as

Re: [Wireshark-dev] [Wireshark-commits] rev 53827: /trunk/epan/ /trunk/epan/dissectors/: packet-ip.c packet-ipv6.c packet-json.c /trunk/epan/: proto.c

2013-12-09 Thread Joerg Mayer
Just trying to understand what is going on here: Isn't UNICODE a bit to broad a name here? Wouldn't STR_UTF8 be a better name as there are different unicode encodings around? Thanks Jörg On Sat, Dec 07, 2013 at 03:48:36PM +, darkja...@wireshark.org wrote:

Re: [Wireshark-dev] Windows version info

2013-12-09 Thread Graham Bloice
On 9 December 2013 15:12, Pascal Quantin pascal.quan...@gmail.com wrote: 2013/12/9 Graham Bloice graham.blo...@trihedral.com On 8 December 2013 22:32, Pascal Quantin pascal.quan...@gmail.comwrote: Hi Graham, Le 8 déc. 2013 à 22:56, Graham Bloice graham.blo...@trihedral.com a écrit :

Re: [Wireshark-dev] Windows version info

2013-12-09 Thread Graham Bloice
On 9 December 2013 15:29, Graham Bloice graham.blo...@trihedral.com wrote: On 9 December 2013 15:12, Pascal Quantin pascal.quan...@gmail.com wrote: 2013/12/9 Graham Bloice graham.blo...@trihedral.com On 8 December 2013 22:32, Pascal Quantin pascal.quan...@gmail.comwrote: Hi Graham, Le 8

Re: [Wireshark-dev] Add -Wdocumentation

2013-12-09 Thread Bálint Réczey
2013/12/9 Joerg Mayer jma...@loplof.de: On Fri, Dec 06, 2013 at 03:38:08PM +0100, Alexis La Goutte wrote: I plan to add -Wdocumentation [1] by default to Wireshark (when build with Clang). I have already fix in trunk the documentation. The major issue to add -Wdocumentation is other library

Re: [Wireshark-dev] [Wireshark-commits] rev 53827: /trunk/epan/ /trunk/epan/dissectors/: packet-ip.c packet-ipv6.c packet-json.c /trunk/epan/: proto.c

2013-12-09 Thread Jakub Zawadzki
On Mon, Dec 09, 2013 at 04:20:58PM +0100, Joerg Mayer wrote: Isn't UNICODE a bit to broad a name here? Wouldn't STR_UTF8 be a better name as there are different unicode encodings around? Well I'd rather avoid using any unicode encoding name here, because some people can think: Hey, I'm

Re: [Wireshark-dev] ZBEE ZCL last modifies

2013-12-09 Thread Fabio Tarabelloni
Hi Alexis, I'd like to discuss to last modifies to the owner in order to illustrate/discuss how zcl file struct is made and the best way to add other/new cluster dissectors. Yes of course, I can patch the files, but I'm not sure I have the captures to test it. Fabio.

Re: [Wireshark-dev] [Wireshark-commits] rev 53895: /trunk/ /trunk/asn1/disp/: packet-disp-template.c /trunk/epan/dissectors/: packet-disp.c packet-dop.c packet-dsp.c packet-hci_usb.c packet-p1.c packe

2013-12-09 Thread Evan Huus
Should all of these null checks be handled in one place (like call_dissector_through_handle or something)? Are there specific dissectors where it's valid for data to be NULL? Even if there are, is it simply less work at this point to pass them a pointer to an empty struct or some such thing?

Re: [Wireshark-dev] [Wireshark-commits] rev 53895: /trunk/ /trunk/asn1/disp/: packet-disp-template.c /trunk/epan/dissectors/: packet-disp.c packet-dop.c packet-dsp.c packet-hci_usb.c packet-p1.c packe

2013-12-09 Thread Maynard, Chris
I don't think it can be handled in one place (but I could be wrong). A significant number of dissectors don't use the data parameter at all, so it's perfectly acceptable for it to be NULL. And while most dissectors that do expect data either can't deal with a NULL parameter or don't make any

Re: [Wireshark-dev] [Wireshark-commits] rev 53895: /trunk/ /trunk/asn1/disp/: packet-disp-template.c /trunk/epan/dissectors/: packet-disp.c packet-dop.c packet-dsp.c packet-hci_usb.c packet-p1.c packe

2013-12-09 Thread Evan Huus
Fair enough, just wasn't sure what the intended scope was. Thanks for clarifying. Evan On Mon, Dec 9, 2013 at 8:44 PM, Maynard, Chris christopher.mayn...@gtech.com wrote: I don't think it can be handled in one place (but I could be wrong). A significant number of dissectors don't use the

Re: [Wireshark-dev] Build instability

2013-12-09 Thread Kaul
Above compilation failure has been fixed. Regretfully, only to be replaced by another compilation failure: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9538 On Mon, Dec 9, 2013 at 2:49 PM, Kaul myk...@gmail.com wrote: Opened https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9529 on