[Wireshark-dev] Petri-dish Ubuntu build failing

2014-08-18 Thread Graham Bloice
Anyone able to take a look at this? a2x: WARNING: --destination-dir option is only applicable to HTML based outputs a2x: ERROR: /usr/bin/asciidoc --backend docbook -a a2x-format=docbook

[Wireshark-dev] Defining global filters?

2014-08-18 Thread Anders Broman
Hi, How to define filters and display the data of fields that may occur in multiple protocols? One example is IMSI ( International Mobile Subscriber identity) that exists in multiple 3GPP and 3GPP2 protocols, following a call flow through the system it could be interesting to filter on IMSI

Re: [Wireshark-dev] Defining global filters?

2014-08-18 Thread Michal Orynicz
Maybe better provide a mechanism to display a {wildcard}.field, where the field just has to have the same name? If I understand correctly, You want to get some fixed filters, which will have to be manually expanded if someone finds a couple of identical fields in different types of frames, which

Re: [Wireshark-dev] Defining global filters?

2014-08-18 Thread mmann78
Is the list of protocols that IMSI goes across finite? Don't you really just want a Conversation filter that would be generated to include all the necessary protocols? The registering dissector has control over how the filter is constructed. Perhaps modify Conversation filter menu item to

Re: [Wireshark-dev] Defining global filters?

2014-08-18 Thread Jeff Morriss
On 08/18/14 09:46, Anders Broman wrote: Hi, How to define filters and display the data of fields that may occur in multiple protocols? One example is IMSI ( International Mobile Subscriber identity) that exists in multiple 3GPP and 3GPP2 protocols, following a call flow through the system it

Re: [Wireshark-dev] [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer.

2014-08-18 Thread Evan Huus
Guy, how are you finding these last four or five API abuses? Do you have some sort of super-checkAPIs or are you just doing a lot of manual code review? On Mon, Aug 18, 2014 at 3:44 PM, Wireshark code review code-review-do-not-re...@wireshark.org wrote: URL:

Re: [Wireshark-dev] [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer.

2014-08-18 Thread Guy Harris
On Aug 18, 2014, at 12:46 PM, Evan Huus eapa...@gmail.com wrote: Guy, how are you finding these last four or five API abuses? Do you have some sort of super-checkAPIs or are you just doing a lot of manual code review? No, and not exactly. I have my regression script, which I was using to

Re: [Wireshark-dev] [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer.

2014-08-18 Thread Evan Huus
On Mon, Aug 18, 2014 at 4:31 PM, Guy Harris g...@alum.mit.edu wrote: On Aug 18, 2014, at 12:46 PM, Evan Huus eapa...@gmail.com wrote: Guy, how are you finding these last four or five API abuses? Do you have some sort of super-checkAPIs or are you just doing a lot of manual code review? No,

Re: [Wireshark-dev] [Wireshark-commits] master 31f3187: Fix warning: no previous prototype for ... [-Wmissing-prototypes]

2014-08-18 Thread Jeff Morriss
On 08/18/14 09:14, Wireshark code review wrote: Fix warning: no previous prototype for ... [-Wmissing-prototypes] [...] Actions performed: from 3adbd93 Fix warning: no previous prototype for ... [-Wmissing-prototypes] adds 31f3187 Fix warning: no previous prototype for

Re: [Wireshark-dev] [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer.

2014-08-18 Thread Jeff Morriss
On 08/18/14 16:45, Evan Huus wrote: On Mon, Aug 18, 2014 at 4:31 PM, Guy Harris g...@alum.mit.edu wrote: On Aug 18, 2014, at 12:46 PM, Evan Huus eapa...@gmail.com wrote: Guy, how are you finding these last four or five API abuses? Do you have some sort of super-checkAPIs or are you just

Re: [Wireshark-dev] [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer.

2014-08-18 Thread Evan Huus
On Mon, Aug 18, 2014 at 5:06 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: On 08/18/14 16:45, Evan Huus wrote: On Mon, Aug 18, 2014 at 4:31 PM, Guy Harris g...@alum.mit.edu wrote: On Aug 18, 2014, at 12:46 PM, Evan Huus eapa...@gmail.com wrote: Guy, how are you finding these last four

Re: [Wireshark-dev] [Wireshark-commits] master 31f3187: Fix warning: no previous prototype for ... [-Wmissing-prototypes]

2014-08-18 Thread Bill Meier
On 8/18/2014 5:11 PM, Jeff Morriss wrote: On 08/18/14 09:14, Wireshark code review wrote: Fix warning: no previous prototype for ... [-Wmissing-prototypes] [...] Actions performed: from 3adbd93 Fix warning: no previous prototype for ... [-Wmissing-prototypes] adds 31f3187