Re: [Wireshark-dev] Wireshark code review

2015-03-25 Thread Alexis La Goutte
On Wed, Mar 25, 2015 at 7:10 AM, Anil anilkumar...@gmail.com wrote: Hi All -- I have done a mistake with submitting code for review. My initial review is https://code.wireshark.org/review/#/c/7751 https://code.wireshark.org/review/#/c/7751/1/epan/dissectors/packet-nstrace.c I fixed the

[Wireshark-dev] Wireshark code review

2015-03-25 Thread Anil
Hi All -- I have done a mistake with submitting code for review. My initial review is https://code.wireshark.org/review/#/c/7751 https://code.wireshark.org/review/#/c/7751/1/epan/dissectors/packet-nstrace.c I fixed the issues reported there and have checked in the new changes. The problem is

Re: [Wireshark-dev] Wireshark code review

2015-03-25 Thread Dario Lombardo
Since you now have 2 changes submitted, you should abandon one of them (do it from the web interface), then follow Alexis' suggestion about sqashing and amending, then push the final revision into the survived change (do it using the correct change-id, read it from the web interface again). I

Re: [Wireshark-dev] Wireshark code review

2015-03-25 Thread Niels de Vos
On Wed, Mar 25, 2015 at 09:15:52AM +0100, Dario Lombardo wrote: Since you now have 2 changes submitted, you should abandon one of them (do it from the web interface), then follow Alexis' suggestion about sqashing and amending, then push the final revision into the survived change (do it using

Re: [Wireshark-dev] Wireshark code review

2015-03-25 Thread Alexis La Goutte
On Wed, Mar 25, 2015 at 9:15 AM, Dario Lombardo dario.lombardo...@gmail.com wrote: Since you now have 2 changes submitted, you should abandon one of them (do it from the web interface), then follow Alexis' suggestion about sqashing and amending, then push the final revision into the survived

[Wireshark-dev] CMake on Windows - Can build, but not run executable

2015-03-25 Thread Roland Knall
Hi I can build wireshark successfully (gtk and qt interfaces) on Windows, but If I want to execute it, he complains that the side-by-side configuration is not correct. If I trace the launch with sxstrace, he complains, that the ProcessorArchitecture is wrong for the target (amd64). The build is

Re: [Wireshark-dev] Wireshark code review

2015-03-25 Thread Dario Lombardo
On Wed, Mar 25, 2015 at 10:03 AM, Alexis La Goutte alexis.lagou...@gmail.com wrote: From local branch ? or remote branch ? (master / master-1.12...) From local. ___ Sent via:Wireshark-dev mailing list

[Wireshark-dev] dpkg-buildpackage -rfakeroot picking wrong version and dissectors

2015-03-25 Thread Juan Jose Martin Carrascosa
Hi all, I am building a package for Ubuntu, and the debian packages I get as result are not picking the proper customized version (set in configure.ac), but what is worse, a custom dissector I wrote is not in the packages. I did make before doing the packaging and ./wireshark-gtk is as I expect.

Re: [Wireshark-dev] dpkg-buildpackage -rfakeroot picking wrong version and dissectors

2015-03-25 Thread Bálint Réczey
Hi Juanjo, 2015-03-25 15:26 GMT+01:00 Juan Jose Martin Carrascosa jua...@rti.com: Hi all, I am building a package for Ubuntu, and the debian packages I get as result are not picking the proper customized version (set in configure.ac), but what is worse, a custom dissector I wrote is not in

Re: [Wireshark-dev] dpkg-buildpackage -rfakeroot picking wrong version and dissectors

2015-03-25 Thread Juan Jose Martin Carrascosa
Thanks for the prompt reply Bálint. So, I assume that what I did for the make build doesn't apply here. Does anyone know how to modify the cmake build for: 1) add a dissector 2) add files to the package (for instance, a pdf in the root directory) 3) change the version Any

Re: [Wireshark-dev] dpkg-buildpackage -rfakeroot picking wrong version and dissectors

2015-03-25 Thread Juan Jose Martin Carrascosa
Well, after doing some awful research... 1) To add the dissector, I edited epan/CMakeLists.txt. 2) To add files to the package, I added my custom files to the same list that colorfilters is, and it seems it work. 3) It seems the version is controlled in CMakeLists.txt using

Re: [Wireshark-dev] dpkg-buildpackage -rfakeroot picking wrong version and dissectors

2015-03-25 Thread Anders Broman
Hi, You could also add it to a CMakeListCustom.txt file see CMakelistCustom.txt.example you also need a Cmake file in your custom dissectors file. Regards Anders From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Juan Jose Martin Carrascosa

Re: [Wireshark-dev] CMake on Windows - Can build, but not run executable

2015-03-25 Thread Graham Bloice
On 25 March 2015 at 08:17, Roland Knall rkn...@gmail.com wrote: Hi I can build wireshark successfully (gtk and qt interfaces) on Windows, but If I want to execute it, he complains that the side-by-side configuration is not correct. If I trace the launch with sxstrace, he complains, that

Re: [Wireshark-dev] Supported Python versions?

2015-03-25 Thread Luke Mewburn
On Sun, Mar 22, 2015 at 04:48:38PM +0100, Peter Wu wrote: | Triggered by a build error due to html2text.py, I have recently started | with adding Python 3 support to various Python scripts[1][2]. The change | to html2text.py[1] was tested with Python 2.6, 2.7, 3.2 and 3.4. | | The