Re: [Wireshark-dev] Compiling with or without extcap

[Guy Harris]

On Jan 7, 2018, at 3:19 PM, Roland Knall  wrote:

> We had this discussion a bung of times. I have nothing against having a 
> preference, but I am very much against making not-loading extcap the default. 
> New users should not face a hassle to enable a capture interface, but 
> existing users, who wish to improve the performance in any way, can profit 
> from an option doing exactly that.
> 
> So +1 on making this option available

+1

> big -1 on making it default to not-loading

+1 on the -1 :-)
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Roland Knall]

We had this discussion a bung of times. I have nothing against having a
preference, but I am very much against making not-loading extcap the
default. New users should not face a hassle to enable a capture interface,
but existing users, who wish to improve the performance in any way, can
profit from an option doing exactly that.

So +1 on making this option available big -1 on making it default to
not-loading

cheers

On Sun, Jan 7, 2018 at 10:21 PM, Dario Lombardo  wrote:

>
>
> On Sun, Jan 7, 2018 at 12:02 AM, Stig Bjørlykke 
> wrote:
>
>> On Sat, Jan 6, 2018 at 7:15 PM, Dario Lombardo <
>> dario.lombardo...@gmail.com> wrote:
>>
>>> What about an environment variable that disable extcap interfaces
>>> loading?
>>>
>>
>> Or even better; a UI configurable preference to enable/disable extcap
>> interfaces.
>>
>> This should be default on.  When turned on or off it will automatically
>> run a "Refresh Interfaces" to load/unload extcap interfaces without having
>> to manually restart or "Refresh Interfaces".
>>
>> Sounds good!
> I'm working on 3 separate patches:
> 1) remove extcap ifdefs
> 2) prevent extcap loading based on env variable (during the review process
> we can decide whether to keep this or not)
> 3) prevent extcap loading based on pref.
>
> For the last one I'm just missing how to properly refresh the interface
> list. I've called wsApp->refreshLocalInterfaces() but the list doesn't
> get refreshed. Can you give it a look?
> Thanks.
> Dario.
>
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Question about git style

[Dario Lombardo]

On Tue, Jan 2, 2018 at 11:21 AM, Jaap Keuter  wrote:

> Hi,
>
> It seems that you’re no stranger to version control systems (VCS), but new
> to git. I think it's important in this case to recognise that git is a
> distributed VCS. That means that you have (a clone of) a repository on your
> own, and gerrit is an online tool on the origin repository. You can commit
> to your own repository as much as you want, and decide to push to gerrit
> when you’re done.
> Being done thus means having your changes completed, or wanting to share
> it with, or reviewed by others. Gerrit provides the infrastructure for
> that. The first case is assumed when a commit appears in gerrit, if it’s a
> Work In Progress a marker ‘[WIP]’ is requested to be prefixed on the commit
> summary line.
>

If I'm not mistaken, that is not requested. A draft change in gerrit is a
change sent to the special branch refs/drafts/master. This is a real draft,
that differs from a regular change for the fact that it's not visible to
others, until it gets promoted to refs/for/master. A draft change can be
reviewed, but this requires the author to manually add reviewers. A [WIP]
change it's just a regular change, where the author is informing others
that the change is not ready to merge. This is a common practice across
projects and VCSes, but it's not enforced by anything on git/gerrit.
Nothing prevents a [WIP] change to be merged. From my experience Wireshark
developers do that to make the review process easier (for instance because
petri dish can't be triggered on a draft change), allowing anyone
interested in reviewing it on board.
Dario.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Dario Lombardo]

On Sun, Jan 7, 2018 at 12:02 AM, Stig Bjørlykke  wrote:

> On Sat, Jan 6, 2018 at 7:15 PM, Dario Lombardo <
> dario.lombardo...@gmail.com> wrote:
>
>> What about an environment variable that disable extcap interfaces loading?
>>
>
> Or even better; a UI configurable preference to enable/disable extcap
> interfaces.
>
> This should be default on.  When turned on or off it will automatically
> run a "Refresh Interfaces" to load/unload extcap interfaces without having
> to manually restart or "Refresh Interfaces".
>
> Sounds good!
I'm working on 3 separate patches:
1) remove extcap ifdefs
2) prevent extcap loading based on env variable (during the review process
we can decide whether to keep this or not)
3) prevent extcap loading based on pref.

For the last one I'm just missing how to properly refresh the interface
list. I've called wsApp->refreshLocalInterfaces() but the list doesn't get
refreshed. Can you give it a look?
Thanks.
Dario.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe