Re: [Wireshark-dev] GSoC | USB Audio/Video stream export

[Tomasz Moń]

On Fri, Mar 6, 2020 at 7:29 PM zubin choudhary  wrote:
> I am interested in working with Wireshark on USB Audio/Video stream export.
> but I'm not sure where to start is there any docs or links I should look up ?

The best pages to look up regarding this project are probably:
  * https://usb.org/documents
  * https://www.wireshark.org/docs/wsdg_html_chunked/
  * https://bugs.wireshark.org/bugzilla/

You should get familiar with how USB Audio class transfers audio data
and how Wireshark dissectors work. Ideally before the application
period ends you would have submitted to Wireshark gerrit a patch
fixing some issue.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] GSoC | USB Audio/Video stream export

[zubin choudhary]

Hello,

I am interested in working with Wireshark on USB Audio/Video stream export.
but I'm not sure where to start is there any docs or links I should look up ?

Thanks
Zubin Choudhary
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

Looks like I made it.

https://github.com/crondaemon/wireshark/runs/490547471?check_suite_focus=true

The artifact can be found in the upper right area of the screen.

On Fri, Mar 6, 2020 at 3:29 PM Dario Lombardo  wrote:

>
>
> On Fri, Mar 6, 2020 at 3:21 PM João Valverde <
> joao.valve...@tecnico.ulisboa.pt> wrote:
>
>> If you want to spare some CPU cycles I believe only the user_guide_chm
>> target is mandatory for NSIS.
>>
>> Seems you are missing some dependencies too, asciidoctor and maybe others
>> as well.
>>
>>
> Yes to both. I'm working on it.
>


-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

On Fri, Mar 6, 2020 at 3:21 PM João Valverde <
joao.valve...@tecnico.ulisboa.pt> wrote:

> If you want to spare some CPU cycles I believe only the user_guide_chm
> target is mandatory for NSIS.
>
> Seems you are missing some dependencies too, asciidoctor and maybe others
> as well.
>
>
Yes to both. I'm working on it.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[João Valverde]

On 06/03/20 13:55, Dario Lombardo wrote:


Si it seems like it is not running the MSVC 2019 command prompt
that takes care of setting the various environment variables.


Well... this is a point. I added the proper action and it made it a 
bit further.


https://github.com/crondaemon/wireshark/runs/490228280?check_suite_focus=true

However it failed because of:
File: "D:\a\wireshark\wireshark\build\docbook\user-guide.chm" -> no 
files found.


Then I guess I need to build the "all_guides" target.


If you want to spare some CPU cycles I believe only the user_guide_chm 
target is mandatory for NSIS.


Seems you are missing some dependencies too, asciidoctor and maybe 
others as well.



--
Naima is online.

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

>
> Si it seems like it is not running the MSVC 2019 command prompt that takes
> care of setting the various environment variables.
>

Well... this is a point. I added the proper action and it made it a bit
further.

https://github.com/crondaemon/wireshark/runs/490228280?check_suite_focus=true

However it failed because of:
File: "D:\a\wireshark\wireshark\build\docbook\user-guide.chm" -> no files
found.

Then I guess I need to build the "all_guides" target.
-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Pascal Quantin]

Le ven. 6 mars 2020 à 14:02, Dario Lombardo  a écrit :

>
>
> On Fri, Mar 6, 2020 at 12:44 PM Pascal Quantin 
> wrote:
>
>>
>>
>> Le ven. 6 mars 2020 à 12:28, Dario Lombardo  a écrit :
>>
>>> I am sorry, I still don't understand, I beg your pardon.
>>> You said
>>>
>>> > your machine does not have the MSVC redistributable copied in the
>>> wireshark-libs folder (as explained in the developer guide) while it is
>>> required for the NSIS installer.
>>>
>>> But I cannot find any point in the developer guide where it is explained
>>> that the MSVC redistributable has to be copied somewhere, nor I know how to
>>> do it myself without a more detailed explanation.
>>>
>>
>> This is why I said it used to be more visible in the documentation .
>> We used to have to download vcredist_x86.exe or vcredist_x64.exe from
>> Microsoft website and copy it in the Wireshark-win32-libs or
>> Wireshark-win64-libs folder. It is no more required because the
>> redistributables are bundled in the MSVC 2019 community edition (for
>> example mine is located by CMake in C:/Program Files (x86)/Microsoft Visual
>> Studio/2019/Community/VC/Redist/MSVC/14.24.28127).
>>
>> I now realize that you have 2 errors: one about the VCINSTALLDIR (root
>> cause of your NSIS issue) and one about MERGE_MODULE_DIR (for WiX). Sorry
>> for not seeing this earlier.
>>
>> As found in our CMakeLists.txt file:
>>
>> # Try to find the Redist folder in VCINSTALLDIR which is set by
>> vcvarsall.bat.
>> # If it is not set, query it within the registry. VS2015 looks for the
>> "VC7" key
>> # in two locations (four if you count HKCU instead of HKLM). However,
>> VS2017
>> # does not use "VC7" (it sets a directory relative to
>> vsdevcmd_start.bat). As
>> # both versions do set "VS7", use that instead.
>> find_path(VCINSTALLDIR Redist PATHS
>> "$ENV{VCINSTALLDIR}"
>>
>> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
>>
>> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
>> NO_DEFAULT_PATH
>> )
>> file(TO_NATIVE_PATH "${VCINSTALLDIR}" VCINSTALLDIR_NATIVE)
>> message(STATUS "Using VCINSTALLDIR: ${VCINSTALLDIR_NATIVE}")
>>
>> That's what Gerald indicated in his message.
>>
>> When I open the MSVC 2019 command prompt, and type 'set VCINSTALLDIR', I
>> get as expected:
>> VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Community\VC\
>>
>> What do you get?
>>
>>
> Unfortunately the builder doesn't print anything with that command
>
>
> https://github.com/crondaemon/wireshark/runs/490180639?check_suite_focus=true
>
> see the "set" step.
>

Si it seems like it is not running the MSVC 2019 command prompt that takes
care of setting the various environment variables.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Graham Bloice]

For the WiX installer merge module, IIRC CMake will print the "not found"
path if WiX isn't installed.  That's been on my cleanup list for some time.

On Fri, 6 Mar 2020 at 06:44, Pascal Quantin  wrote:

>
>
> Le ven. 6 mars 2020 à 12:28, Dario Lombardo  a écrit :
>
>> I am sorry, I still don't understand, I beg your pardon.
>> You said
>>
>> > your machine does not have the MSVC redistributable copied in the
>> wireshark-libs folder (as explained in the developer guide) while it is
>> required for the NSIS installer.
>>
>> But I cannot find any point in the developer guide where it is explained
>> that the MSVC redistributable has to be copied somewhere, nor I know how to
>> do it myself without a more detailed explanation.
>>
>
> This is why I said it used to be more visible in the documentation .
> We used to have to download vcredist_x86.exe or vcredist_x64.exe from
> Microsoft website and copy it in the Wireshark-win32-libs or
> Wireshark-win64-libs folder. It is no more required because the
> redistributables are bundled in the MSVC 2019 community edition (for
> example mine is located by CMake in C:/Program Files (x86)/Microsoft Visual
> Studio/2019/Community/VC/Redist/MSVC/14.24.28127).
>
> I now realize that you have 2 errors: one about the VCINSTALLDIR (root
> cause of your NSIS issue) and one about MERGE_MODULE_DIR (for WiX). Sorry
> for not seeing this earlier.
>
> As found in our CMakeLists.txt file:
>
> # Try to find the Redist folder in VCINSTALLDIR which is set by
> vcvarsall.bat.
> # If it is not set, query it within the registry. VS2015 looks for the
> "VC7" key
> # in two locations (four if you count HKCU instead of HKLM). However,
> VS2017
> # does not use "VC7" (it sets a directory relative to vsdevcmd_start.bat).
> As
> # both versions do set "VS7", use that instead.
> find_path(VCINSTALLDIR Redist PATHS
> "$ENV{VCINSTALLDIR}"
>
> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
>
> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
> NO_DEFAULT_PATH
> )
> file(TO_NATIVE_PATH "${VCINSTALLDIR}" VCINSTALLDIR_NATIVE)
> message(STATUS "Using VCINSTALLDIR: ${VCINSTALLDIR_NATIVE}")
>
> That's what Gerald indicated in his message.
>
> When I open the MSVC 2019 command prompt, and type 'set VCINSTALLDIR', I
> get as expected:
> VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Community\VC\
>
> What do you get?
>
>
>> On Fri, Mar 6, 2020 at 12:20 PM Pascal Quantin 
>> wrote:
>>
>>> Hi Dario,
>>>
>>> Le ven. 6 mars 2020 à 12:16, Dario Lombardo  a écrit :
>>>
 Hi Pascal
 I'm not sure I got the point. I try to explain what I understand. I
 have one single build, that may have multiple problems, some trivial, some
 not. The error I see in cmake could be ignored, while the one that counts
 is the fact I need the MSVC redistributable in the wireshark-lib folder.
 Am I correct?

>>>
>>> Yes if you do not have a step building the WiX installer (which seems to
>>> be the case).
>>>
>>>

>> Joao is correct: on one side you have a non fatal error in CMake that
> only impacts the WiX installer, and in the other side your machine does 
> not
> have the MSVC redistributable copied in the wireshark-libs folder (as
> explained in the developer guide) while it is required for the NSIS
> installer.
>
> Can you link the devel guide where it's explained? I just found


 https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS

>>>
>>> https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html
>>>
>>> In the past it used to be more visible if I remember correctly.
>>>
>>> BR,
>>> Pascal.
>>>
>>> ___
>>> Sent via:Wireshark-dev mailing list 
>>> Archives:https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>  mailto:wireshark-dev-requ...@wireshark.org
>>> ?subject=unsubscribe
>>
>>
>>
>> --
>>
>> Naima is online.
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 
Graham Bloice
Software Developer
Trihedral UK Limited
___
Sent via:Wireshark-dev 

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

On Fri, Mar 6, 2020 at 12:44 PM Pascal Quantin  wrote:

>
>
> Le ven. 6 mars 2020 à 12:28, Dario Lombardo  a écrit :
>
>> I am sorry, I still don't understand, I beg your pardon.
>> You said
>>
>> > your machine does not have the MSVC redistributable copied in the
>> wireshark-libs folder (as explained in the developer guide) while it is
>> required for the NSIS installer.
>>
>> But I cannot find any point in the developer guide where it is explained
>> that the MSVC redistributable has to be copied somewhere, nor I know how to
>> do it myself without a more detailed explanation.
>>
>
> This is why I said it used to be more visible in the documentation .
> We used to have to download vcredist_x86.exe or vcredist_x64.exe from
> Microsoft website and copy it in the Wireshark-win32-libs or
> Wireshark-win64-libs folder. It is no more required because the
> redistributables are bundled in the MSVC 2019 community edition (for
> example mine is located by CMake in C:/Program Files (x86)/Microsoft Visual
> Studio/2019/Community/VC/Redist/MSVC/14.24.28127).
>
> I now realize that you have 2 errors: one about the VCINSTALLDIR (root
> cause of your NSIS issue) and one about MERGE_MODULE_DIR (for WiX). Sorry
> for not seeing this earlier.
>
> As found in our CMakeLists.txt file:
>
> # Try to find the Redist folder in VCINSTALLDIR which is set by
> vcvarsall.bat.
> # If it is not set, query it within the registry. VS2015 looks for the
> "VC7" key
> # in two locations (four if you count HKCU instead of HKLM). However,
> VS2017
> # does not use "VC7" (it sets a directory relative to vsdevcmd_start.bat).
> As
> # both versions do set "VS7", use that instead.
> find_path(VCINSTALLDIR Redist PATHS
> "$ENV{VCINSTALLDIR}"
>
> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
>
> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
> NO_DEFAULT_PATH
> )
> file(TO_NATIVE_PATH "${VCINSTALLDIR}" VCINSTALLDIR_NATIVE)
> message(STATUS "Using VCINSTALLDIR: ${VCINSTALLDIR_NATIVE}")
>
> That's what Gerald indicated in his message.
>
> When I open the MSVC 2019 command prompt, and type 'set VCINSTALLDIR', I
> get as expected:
> VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Community\VC\
>
> What do you get?
>
>
Unfortunately the builder doesn't print anything with that command

https://github.com/crondaemon/wireshark/runs/490180639?check_suite_focus=true

see the "set" step.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Wireshark 3.2.2 Windows Installer 64-bit - Invalid Signature

[Graham Bloice]

On Thu, 5 Mar 2020 at 15:34, Gerald Combs  wrote:

> On 3/4/20 1:21 PM, jbugrep...@outlook.com wrote:
> > Hello,
> >
> > Problem: When I attempt to verify the signature of the Wireshark 3.2.2
> Windows installer (64-bit), I receive a message that the signature is
> invalid. I expected a good signature. Is this a known issue?
> >
> > Windows 10 Pro Version 1903 Build 18362.657 64 bit
> > Gpg4win 3.1.11
> > Attempting to install Wireshark 3.2.2 (Windows 64-bit)
> >
> > Details and Steps to Reproduce:
> > 1) Went to https://www.wireshark.org/download.html and downloaded the
> Windows Installer (64-bit) for Wireshark version 3.2.2; saved the .exe to
> my desktop with the name Wireshark-win64-3.2.2
> > 2) Went to
> https://www.wireshark.org/download/gerald_at_wireshark_dot_org.gpg ,
> selected all of the text, copied it, pasted it into a notepad file, and
> saved it as an .asc file to my desktop with the name
> Wireshark-Code-Signing-Key
> > 3) Successfully imported the key from step 2 into Kleopatra by using
> File>Import
>
> > 4) Went to https://www.wireshark.org/download/SIGNATURES-3.2.2.txt ,
> selected all of the text beginning with and including “-BEGIN PGP
> SIGNATURE-“ and ending with and including “-END PGP
> SIGNATURE-“, copied it, pasted it into a notepad file, and saved it as
> an .asc file to my desktop with the name Wireshark-win64-3.2.2.exe
>
> This signature is for the text that immediately precedes it, not for any
> of the distribution files. That is, SIGNATURES-3.2.2.txt is a
> self-contained PGP/GPG clearsigned text document as described at
> https://tools.ietf.org/html/rfc4880#section-7. I've never used Kleopatra,
> but it looks like you can verify SIGNATURES-3.2.2.txt by opening it via
> "File → Decrypt/Verify Files...". From there you can compare the
> Wireshark-win64-3.2.2.exe hash values with the file you downloaded. You can
> also check to make sure various packaging systems are using official
> installers, e.g.
>
> https://github.com/Homebrew/homebrew-cask/blob/master/Casks/wireshark.rb
> https://chocolatey.org/packages/wireshark#files
>
>
> However, there's an easier way to verify Wireshark on Windows. Right-click
> on the installer, select "Properties", and make sure it's signed by
> "Wireshark Foundation, Inc.". You can also do this on the command line
> using `signtool verify` if it's available.
>
>
Or use the PowerShell cmdlet "Get-AuthenticodeSignature", passing the path
to the file as an argument.

-- 
Graham Bloice
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Pascal Quantin]

Le ven. 6 mars 2020 à 12:28, Dario Lombardo  a écrit :

> I am sorry, I still don't understand, I beg your pardon.
> You said
>
> > your machine does not have the MSVC redistributable copied in the
> wireshark-libs folder (as explained in the developer guide) while it is
> required for the NSIS installer.
>
> But I cannot find any point in the developer guide where it is explained
> that the MSVC redistributable has to be copied somewhere, nor I know how to
> do it myself without a more detailed explanation.
>

This is why I said it used to be more visible in the documentation .
We used to have to download vcredist_x86.exe or vcredist_x64.exe from
Microsoft website and copy it in the Wireshark-win32-libs or
Wireshark-win64-libs folder. It is no more required because the
redistributables are bundled in the MSVC 2019 community edition (for
example mine is located by CMake in C:/Program Files (x86)/Microsoft Visual
Studio/2019/Community/VC/Redist/MSVC/14.24.28127).

I now realize that you have 2 errors: one about the VCINSTALLDIR (root
cause of your NSIS issue) and one about MERGE_MODULE_DIR (for WiX). Sorry
for not seeing this earlier.

As found in our CMakeLists.txt file:

# Try to find the Redist folder in VCINSTALLDIR which is set by
vcvarsall.bat.
# If it is not set, query it within the registry. VS2015 looks for the
"VC7" key
# in two locations (four if you count HKCU instead of HKLM). However, VS2017
# does not use "VC7" (it sets a directory relative to vsdevcmd_start.bat).
As
# both versions do set "VS7", use that instead.
find_path(VCINSTALLDIR Redist PATHS
"$ENV{VCINSTALLDIR}"
"[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
"[HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
NO_DEFAULT_PATH
)
file(TO_NATIVE_PATH "${VCINSTALLDIR}" VCINSTALLDIR_NATIVE)
message(STATUS "Using VCINSTALLDIR: ${VCINSTALLDIR_NATIVE}")

That's what Gerald indicated in his message.

When I open the MSVC 2019 command prompt, and type 'set VCINSTALLDIR', I
get as expected:
VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual
Studio\2019\Community\VC\

What do you get?


> On Fri, Mar 6, 2020 at 12:20 PM Pascal Quantin 
> wrote:
>
>> Hi Dario,
>>
>> Le ven. 6 mars 2020 à 12:16, Dario Lombardo  a écrit :
>>
>>> Hi Pascal
>>> I'm not sure I got the point. I try to explain what I understand. I have
>>> one single build, that may have multiple problems, some trivial, some not.
>>> The error I see in cmake could be ignored, while the one that counts is the
>>> fact I need the MSVC redistributable in the wireshark-lib folder.
>>> Am I correct?
>>>
>>
>> Yes if you do not have a step building the WiX installer (which seems to
>> be the case).
>>
>>
>>>
> Joao is correct: on one side you have a non fatal error in CMake that
 only impacts the WiX installer, and in the other side your machine does not
 have the MSVC redistributable copied in the wireshark-libs folder (as
 explained in the developer guide) while it is required for the NSIS
 installer.

 Can you link the devel guide where it's explained? I just found
>>>
>>>
>>> https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS
>>>
>>
>> https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html
>>
>> In the past it used to be more visible if I remember correctly.
>>
>> BR,
>> Pascal.
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
>
>
> --
>
> Naima is online.
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

I am sorry, I still don't understand, I beg your pardon.
You said

> your machine does not have the MSVC redistributable copied in the
wireshark-libs folder (as explained in the developer guide) while it is
required for the NSIS installer.

But I cannot find any point in the developer guide where it is explained
that the MSVC redistributable has to be copied somewhere, nor I know how to
do it myself without a more detailed explanation.

On Fri, Mar 6, 2020 at 12:20 PM Pascal Quantin  wrote:

> Hi Dario,
>
> Le ven. 6 mars 2020 à 12:16, Dario Lombardo  a écrit :
>
>> Hi Pascal
>> I'm not sure I got the point. I try to explain what I understand. I have
>> one single build, that may have multiple problems, some trivial, some not.
>> The error I see in cmake could be ignored, while the one that counts is the
>> fact I need the MSVC redistributable in the wireshark-lib folder.
>> Am I correct?
>>
>
> Yes if you do not have a step building the WiX installer (which seems to
> be the case).
>
>
>>
 Joao is correct: on one side you have a non fatal error in CMake that
>>> only impacts the WiX installer, and in the other side your machine does not
>>> have the MSVC redistributable copied in the wireshark-libs folder (as
>>> explained in the developer guide) while it is required for the NSIS
>>> installer.
>>>
>>> Can you link the devel guide where it's explained? I just found
>>
>>
>> https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS
>>
>
> https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html
>
> In the past it used to be more visible if I remember correctly.
>
> BR,
> Pascal.
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Pascal Quantin]

Hi Dario,

Le ven. 6 mars 2020 à 12:16, Dario Lombardo  a écrit :

> Hi Pascal
> I'm not sure I got the point. I try to explain what I understand. I have
> one single build, that may have multiple problems, some trivial, some not.
> The error I see in cmake could be ignored, while the one that counts is the
> fact I need the MSVC redistributable in the wireshark-lib folder.
> Am I correct?
>

Yes if you do not have a step building the WiX installer (which seems to be
the case).


>
>>> Joao is correct: on one side you have a non fatal error in CMake that
>> only impacts the WiX installer, and in the other side your machine does not
>> have the MSVC redistributable copied in the wireshark-libs folder (as
>> explained in the developer guide) while it is required for the NSIS
>> installer.
>>
>> Can you link the devel guide where it's explained? I just found
>
> https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS
>

https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html

In the past it used to be more visible if I remember correctly.

BR,
Pascal.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

Hi Pascal
I'm not sure I got the point. I try to explain what I understand. I have
one single build, that may have multiple problems, some trivial, some not.
The error I see in cmake could be ignored, while the one that counts is the
fact I need the MSVC redistributable in the wireshark-lib folder.
Am I correct?


>> Joao is correct: on one side you have a non fatal error in CMake that
> only impacts the WiX installer, and in the other side your machine does not
> have the MSVC redistributable copied in the wireshark-libs folder (as
> explained in the developer guide) while it is required for the NSIS
> installer.
>
> Can you link the devel guide where it's explained? I just found

https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS

Thanks.
Dario.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Pascal Quantin]

Hi Dario,

Le ven. 6 mars 2020 à 11:30, Dario Lombardo  a écrit :

> No, it's the same. Have a look at the cmake section and you will see the
> error messages below.
>

Joao is correct: on one side you have a non fatal error in CMake that only
impacts the WiX installer, and in the other side your machine does not have
the MSVC redistributable copied in the wireshark-libs folder (as explained
in the developer guide) while it is required for the NSIS installer.


> On Fri, Mar 6, 2020 at 10:54 AM João Valverde <
> joao.valve...@tecnico.ulisboa.pt> wrote:
>
>>
>>
>> On 06/03/20 08:23, Dario Lombardo wrote:
>>
>> Example of failing build
>>
>>
>> https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true
>>
>>
>> A quick look suggests this is a different build than you indicated
>> before, for an NSIS package, and the problem seems to be that the VC_REDIST
>> exe is missing.
>>
>>
>> On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo  wrote:
>>
>>> Are you saying "set v"? It doesn't print anything.
>>> The installation of VS is pre-made by the github builder itself, not by
>>> me, hence I don't have any control over the installation options. However I
>>> guess every component is in place, and maybe I just need to add the proper
>>> dir to the PATH. What do you think?
>>>
>>> On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs 
>>> wrote:
>>>
 On 3/5/20 7:27 AM, Dario Lombardo wrote:
 > Hi,
 > I'm getting this output from a windows build
 >
 > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
 > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for
 the WiX installer
 > -- Configuring done
 > -- Generating done
 > -- Build files have been written to: D:/a/wireshark/wireshark/build
 >
 > What's going wrong? The rest of the output looks good.

 VCINSTALLDIR should have been set by Visual Studio, e.g. by
 vcvarsall.bat. What does `set v` show?

 ___
 Sent via:Wireshark-dev mailing list 
 Archives:https://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe
>>>
>>>
>>>
>>> --
>>>
>>> Naima is online.
>>>
>>>
>>
>> --
>>
>> Naima is online.
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list  
>> 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe 
>> 
>>
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
>
>
> --
>
> Naima is online.
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

No, it's the same. Have a look at the cmake section and you will see the
error messages below.

On Fri, Mar 6, 2020 at 10:54 AM João Valverde <
joao.valve...@tecnico.ulisboa.pt> wrote:

>
>
> On 06/03/20 08:23, Dario Lombardo wrote:
>
> Example of failing build
>
>
> https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true
>
>
> A quick look suggests this is a different build than you indicated before,
> for an NSIS package, and the problem seems to be that the VC_REDIST exe is
> missing.
>
>
> On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo  wrote:
>
>> Are you saying "set v"? It doesn't print anything.
>> The installation of VS is pre-made by the github builder itself, not by
>> me, hence I don't have any control over the installation options. However I
>> guess every component is in place, and maybe I just need to add the proper
>> dir to the PATH. What do you think?
>>
>> On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs  wrote:
>>
>>> On 3/5/20 7:27 AM, Dario Lombardo wrote:
>>> > Hi,
>>> > I'm getting this output from a windows build
>>> >
>>> > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
>>> > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the
>>> WiX installer
>>> > -- Configuring done
>>> > -- Generating done
>>> > -- Build files have been written to: D:/a/wireshark/wireshark/build
>>> >
>>> > What's going wrong? The rest of the output looks good.
>>>
>>> VCINSTALLDIR should have been set by Visual Studio, e.g. by
>>> vcvarsall.bat. What does `set v` show?
>>>
>>> ___
>>> Sent via:Wireshark-dev mailing list 
>>> Archives:https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>  mailto:wireshark-dev-requ...@wireshark.org
>>> ?subject=unsubscribe
>>
>>
>>
>> --
>>
>> Naima is online.
>>
>>
>
> --
>
> Naima is online.
>
>
> ___
> Sent via:Wireshark-dev mailing list  
> 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe 
> 
>
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[João Valverde]

On 06/03/20 08:23, Dario Lombardo wrote:

Example of failing build

https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true


A quick look suggests this is a different build than you indicated 
before, for an NSIS package, and the problem seems to be that the 
VC_REDIST exe is missing.




On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo > wrote:


Are you saying "set v"? It doesn't print anything.
The installation of VS is pre-made by the github builder itself,
not by me, hence I don't have any control over the installation
options. However I guess every component is in place, and maybe I
just need to add the proper dir to the PATH. What do you think?

On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs mailto:ger...@wireshark.org>> wrote:

On 3/5/20 7:27 AM, Dario Lombardo wrote:
> Hi,
> I'm getting this output from a windows build
>
> -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
> -- Using
MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the
WiX installer
> -- Configuring done
> -- Generating done
> -- Build files have been written to:
D:/a/wireshark/wireshark/build
>
> What's going wrong? The rest of the output looks good.

VCINSTALLDIR should have been set by Visual Studio, e.g. by
vcvarsall.bat. What does `set v` show?

___
Sent via:    Wireshark-dev mailing list
mailto:wireshark-dev@wireshark.org>>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe:
https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-requ...@wireshark.org
?subject=unsubscribe



-- 


Naima is online.



--
Naima is online.

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[João Valverde]

Maybe this helps?

https://github.com/actions/virtual-environments/issues/195

On 06/03/20 08:07, Dario Lombardo wrote:

Are you saying "set v"? It doesn't print anything.
The installation of VS is pre-made by the github builder itself, not 
by me, hence I don't have any control over the installation options. 
However I guess every component is in place, and maybe I just need to 
add the proper dir to the PATH. What do you think?


On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs > wrote:


On 3/5/20 7:27 AM, Dario Lombardo wrote:
> Hi,
> I'm getting this output from a windows build
>
> -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
> -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm
for the WiX installer
> -- Configuring done
> -- Generating done
> -- Build files have been written to: D:/a/wireshark/wireshark/build
>
> What's going wrong? The rest of the output looks good.

VCINSTALLDIR should have been set by Visual Studio, e.g. by
vcvarsall.bat. What does `set v` show?
___
Sent via:    Wireshark-dev mailing list
mailto:wireshark-dev@wireshark.org>>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-requ...@wireshark.org
?subject=unsubscribe



--
Naima is online.

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

Example of failing build

https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true

On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo  wrote:

> Are you saying "set v"? It doesn't print anything.
> The installation of VS is pre-made by the github builder itself, not by
> me, hence I don't have any control over the installation options. However I
> guess every component is in place, and maybe I just need to add the proper
> dir to the PATH. What do you think?
>
> On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs  wrote:
>
>> On 3/5/20 7:27 AM, Dario Lombardo wrote:
>> > Hi,
>> > I'm getting this output from a windows build
>> >
>> > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
>> > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the
>> WiX installer
>> > -- Configuring done
>> > -- Generating done
>> > -- Build files have been written to: D:/a/wireshark/wireshark/build
>> >
>> > What's going wrong? The rest of the output looks good.
>>
>> VCINSTALLDIR should have been set by Visual Studio, e.g. by
>> vcvarsall.bat. What does `set v` show?
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
>
>
> --
>
> Naima is online.
>
>

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

Are you saying "set v"? It doesn't print anything.
The installation of VS is pre-made by the github builder itself, not by me,
hence I don't have any control over the installation options. However I
guess every component is in place, and maybe I just need to add the proper
dir to the PATH. What do you think?

On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs  wrote:

> On 3/5/20 7:27 AM, Dario Lombardo wrote:
> > Hi,
> > I'm getting this output from a windows build
> >
> > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
> > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the
> WiX installer
> > -- Configuring done
> > -- Generating done
> > -- Build files have been written to: D:/a/wireshark/wireshark/build
> >
> > What's going wrong? The rest of the output looks good.
>
> VCINSTALLDIR should have been set by Visual Studio, e.g. by vcvarsall.bat.
> What does `set v` show?
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe