Re: [Wireshark-dev] What does [WIP] really mean?

2014-04-15 Thread Bálint Réczey
2014-04-14 21:09 GMT+02:00 Guy Harris g...@alum.mit.edu: On Apr 14, 2014, at 11:49 AM, Gerald Combs ger...@wireshark.org wrote: On 4/11/14 7:35 PM, mman...@netscape.net wrote: If a reviewer thinks the current patch is a good start for a feature (and worthy of current inclusion), is it okay

Re: [Wireshark-dev] What about backporting fixes to older releases with the new workflow?

2014-04-02 Thread Bálint Réczey
Hi Gerald All, 2014-04-01 2:41 GMT+02:00 Pascal Quantin pascal.quan...@gmail.com: 2014-03-31 23:17 GMT+02:00 Gerald Combs ger...@wireshark.org: On 3/27/14 10:13 PM, Anders Broman wrote: Hi, How do we handle backports in the new work flow with git? The submitter of a patch could help

Re: [Wireshark-dev] Structures change in versions

2014-03-29 Thread Bálint Réczey
Hi Eshed, 2014-03-29 20:30 GMT+01:00 Guy Harris g...@alum.mit.edu: On Mar 29, 2014, at 6:10 AM, Eshed Shaham ashdn...@gmail.com wrote: Hello, I recently found out that the frame_data structure had a minor change in the 1.8 branch between 1.8.8 and 1.8.9:

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Bálint Réczey
+1 The Debian packages use Lua since 1.10.2-2 without any problem. Cheers, Balint 2014-03-28 15:45 GMT+01:00 Nakayama Kenjiro nakayamakenj...@gmail.com: +1 On Fri, Mar 28, 2014 at 11:29 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: Howdy, Is there any reason not to make wireshark

Re: [Wireshark-dev] Gerrit versus Buildbot

2014-03-26 Thread Bálint Réczey
2014-03-21 22:24 GMT+01:00 Bálint Réczey bal...@balintreczey.hu: Hi, 2014-03-20 23:11 GMT-01:00 Guy Harris g...@alum.mit.edu: On Mar 20, 2014, at 2:24 PM, Chris Kilgour tec...@whiterocker.com wrote: On 03/20/2014 01:07 PM, Gerald Combs wrote: If the build system had open access what would

Re: [Wireshark-dev] unusual button text

2014-03-26 Thread Bálint Réczey
2014-03-22 21:03 GMT+01:00 Bálint Réczey bal...@balintreczey.hu: Hi, 2014-03-22 18:29 GMT-01:00 Anders Broman a.broma...@gmail.com: Balint's stock icon changes? Den 22 mar 2014 19:35 skrev Guy Harris g...@alum.mit.edu: On Mar 22, 2014, at 9:09 AM, Toralf Förster toralf.foers...@gmx.de

Re: [Wireshark-dev] new warning :/usr/include/gtk-3.0/gtk/gtkwidget.h:787:58: error: identifier and is a special operator name in C++ [-Werror=c++-compat]

2014-03-26 Thread Bálint Réczey
2014-03-09 15:43 GMT+01:00 Bálint Réczey bal...@balintreczey.hu: 2014-03-09 10:43 GMT+01:00 Alexis La Goutte alexis.lagou...@gmail.com: On Sat, Mar 8, 2014 at 4:21 PM, Toralf Förster toralf.foers...@gmx.de wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Switching from gtk-3.8.7

Re: [Wireshark-dev] unusual button text

2014-03-22 Thread Bálint Réczey
Hi, 2014-03-22 18:29 GMT-01:00 Anders Broman a.broma...@gmail.com: Balint's stock icon changes? Den 22 mar 2014 19:35 skrev Guy Harris g...@alum.mit.edu: On Mar 22, 2014, at 9:09 AM, Toralf Förster toralf.foers...@gmx.de wrote: Got this with latest git tree while quitting w/o saving

Re: [Wireshark-dev] Gerrit versus Buildbot

2014-03-21 Thread Bálint Réczey
Hi, 2014-03-20 23:11 GMT-01:00 Guy Harris g...@alum.mit.edu: On Mar 20, 2014, at 2:24 PM, Chris Kilgour tec...@whiterocker.com wrote: On 03/20/2014 01:07 PM, Gerald Combs wrote: If the build system had open access what would keep someone from uploading a shell script containing a box full

Re: [Wireshark-dev] Build bot failure

2014-03-11 Thread Bálint Réczey
2014-03-11 7:29 GMT+01:00 Anders Broman a.bro...@bredband.net: Hi, stock_icons.c:176: error: 'GTK_STOCK_CAPS_LOCK_WARNING' undeclared here (not in a function) stock_icons.c:242: error: 'GTK_STOCK_PAGE_SETUP' undeclared here (not in a function) stock_icons.c:246: error: 'GTK_STOCK_PRINT_ERROR'

Re: [Wireshark-dev] Fix bug in GSM MAP, have problems with GIT

2014-03-11 Thread Bálint Réczey
2014-03-11 15:00 GMT+01:00 Martin Mathieson martin.r.mathie...@googlemail.com: I too am looking forward to seeing this. On Tue, Mar 11, 2014 at 1:08 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: On 03/08/14 04:46, Anders Broman wrote: Pascal Quantin skrev 2014-03-08 09:56: Le

Re: [Wireshark-dev] new warning :/usr/include/gtk-3.0/gtk/gtkwidget.h:787:58: error: identifier and is a special operator name in C++ [-Werror=c++-compat]

2014-03-09 Thread Bálint Réczey
2014-03-09 10:43 GMT+01:00 Alexis La Goutte alexis.lagou...@gmail.com: On Sat, Mar 8, 2014 at 4:21 PM, Toralf Förster toralf.foers...@gmx.de wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Switching from gtk-3.8.7 to gtp-3.10.7 I do get with current wireshark git tree at a stable 32

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-26 Thread Bálint Réczey
2014-02-26 10:30 GMT+01:00 Joerg Mayer jma...@loplof.de: On Wed, Feb 26, 2014 at 09:51:13AM +0100, Joerg Mayer wrote: I sent the sample workflow for two reasons: 1) Receive feedback whether I did something stupid (aka newbie error) 2) Start creating a little bit of help for newbies Attached

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-26 Thread Bálint Réczey
2014-02-26 18:19 GMT+01:00 Hadriel Kaplan hadriel.kap...@oracle.com: On Feb 26, 2014, at 3:51 AM, Joerg Mayer jma...@loplof.de wrote: On Tue, Feb 25, 2014 at 08:39:37PM -0500, Hadriel Kaplan wrote: - avoiding merging local branches because a merge commit won't have the change-id and

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-26 Thread Bálint Réczey
-Basics-Undoing-Things Cheers, Balint On Wed, Feb 26, 2014 at 2:31 PM, Bálint Réczey bal...@balintreczey.hu wrote: 2014-02-26 10:30 GMT+01:00 Joerg Mayer jma...@loplof.de: On Wed, Feb 26, 2014 at 09:51:13AM +0100, Joerg Mayer wrote: I sent the sample workflow for two reasons: 1) Receive

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-26 Thread Bálint Réczey
2014-02-26 9:22 GMT+01:00 Joerg Mayer jma...@loplof.de: On Tue, Feb 25, 2014 at 08:57:36PM -0500, Hadriel Kaplan wrote: On Feb 25, 2014, at 8:44 PM, Evan Huus eapa...@gmail.com wrote: I'm all for consolidating the above information - we just need to decide which of the many places to

Re: [Wireshark-dev] right git clone address

2014-02-21 Thread Bálint Réczey
Hi Gerald, 2014-02-21 1:20 GMT+01:00 Gerald Combs ger...@wireshark.org: ... For the time being I've redirected the following URL prefixes to Gerrit: http://anongit.wireshark.org/git http://code.wireshark.org/git https://code.wireshark.org/git I'm able to fetch using a couple of old test

Re: [Wireshark-dev] right git clone address

2014-02-20 Thread Bálint Réczey
Hi All Gerald, 2014-02-01 23:04 GMT+01:00 Evan Huus eapa...@gmail.com: On Sat, Feb 1, 2014 at 4:58 PM, Toralf Förster toralf.foers...@gmx.de wrote: As a follower of the wireshark code I'm wondering if https://code.wireshark.org/review/wireshark or https://code.wireshark.org/git/wireshark is

Re: [Wireshark-dev] right git clone address

2014-02-20 Thread Bálint Réczey
2014-02-20 14:36 GMT+01:00 Evan Huus eapa...@gmail.com: On Thu, Feb 20, 2014 at 6:52 AM, Bálint Réczey bal...@balintreczey.hu wrote: Hi All Gerald, 2014-02-01 23:04 GMT+01:00 Evan Huus eapa...@gmail.com: On Sat, Feb 1, 2014 at 4:58 PM, Toralf Förster toralf.foers...@gmx.de wrote

Re: [Wireshark-dev] Git and line endings

2014-02-04 Thread Bálint Réczey
Hi, 2014-02-04 Pascal Quantin pascal.quan...@gmail.com: 2014-02-04 Graham Bloice graham.blo...@trihedral.com: On 4 February 2014 11:18, Pascal Quantin pascal.quan...@gmail.com wrote: 2014-02-04 Graham Bloice graham.blo...@trihedral.com: On 3 February 2014 22:50, Pascal Quantin

Re: [Wireshark-dev] Git and line endings

2014-02-04 Thread Bálint Réczey
Hi, 2014-02-04 Pascal Quantin pascal.quan...@gmail.com: 2014-02-04 Bálint Réczey bal...@balintreczey.hu: Hi, 2014-02-04 Pascal Quantin pascal.quan...@gmail.com: 2014-02-04 Graham Bloice graham.blo...@trihedral.com: On 4 February 2014 11:18, Pascal Quantin pascal.quan

Re: [Wireshark-dev] Gerrit Merge gerrit topic commits

2014-01-31 Thread Bálint Réczey
Hi Evan, 2014-01-30 Evan Huus eapa...@gmail.com: On Thu, Jan 30, 2014 at 2:35 PM, Gerald Combs ger...@wireshark.org wrote: On 1/30/14 6:17 AM, Bálint Réczey wrote: Hi, 2014-01-30 Evan Huus eapa...@gmail.com: I believe the simpler answer is that the submit type has been set to Merge

Re: [Wireshark-dev] do we continue to reference revision numbers?

2014-01-31 Thread Bálint Réczey
Hi Hadriel, 2014-01-31 Hadriel Kaplan hadriel.kap...@oracle.com: In the past with svn, when we found a bug caused by a previous code change, we used the revision number in bugzilla comments with a leading ‘r’, like ‘r12345’. This would auto-create a very convenient url link in bugzilla to

Re: [Wireshark-dev] Gerrit Merge gerrit topic commits

2014-01-30 Thread Bálint Réczey
Hi, 2014-01-30 Evan Huus eapa...@gmail.com: I believe the simpler answer is that the submit type has been set to Merge If Necessary which means if changes are not submitted exactly on top of the change they were authored on, Gerrit will produce a merge automatically. I suggested using Cherry

Re: [Wireshark-dev] Gerrit Topic Names

2014-01-30 Thread Bálint Réczey
Please don't list bugs in topic names, reserve the fist line for the short summary. Listing bugs at the end of the commit message like below is a better practice and also helps processing the commit messages with standard tools. https://wiki.openstack.org/wiki/GitCommitMessages : The 'bug' line

Re: [Wireshark-dev] Gerrit Topic Names

2014-01-30 Thread Bálint Réczey
2014-01-30 Alexis La Goutte alexis.lagou...@gmail.com: On Thu, Jan 30, 2014 at 3:31 PM, Bálint Réczey bal...@balintreczey.hu wrote: Please don't list bugs in topic names, reserve the fist line for the short summary. Listing bugs at the end of the commit message like below is a better

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-30 Thread Bálint Réczey
2014-01-30 Gerald Combs ger...@wireshark.org: On 1/28/14 5:57 AM, Bálint Réczey wrote: Hi, 2014-01-28 Joerg Mayer jma...@loplof.de: On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: It is in the upper right corner. The links are pretty small. You are not the first who missed

Re: [Wireshark-dev] Git tags

2014-01-29 Thread Bálint Réczey
Hi Gerald, 2014-01-24 Gerald Combs ger...@wireshark.org: After Tuesday's migration I plan on adding the following tags. This should make it easier to use 'git describe' to generate version numbers and provide a consistent tag history in our current branches. Most of those git commits are

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-28 Thread Bálint Réczey
Hi Jörg, It is in the upper right corner. The links are pretty small. You are not the first who missed them. :-) Cheers, Balint 2014-01-28 Joerg Mayer jma...@loplof.de: Looks like I'm blind. Where do I create the account? Thanks Jörg On Tue, Jan 14, 2014 at 09:28:08PM -0500, Evan Huus

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-28 Thread Bálint Réczey
Hi, 2014-01-28 Joerg Mayer jma...@loplof.de: On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: It is in the upper right corner. The links are pretty small. You are not the first who missed them. :-) Can you please provide the URL? If the URL is https://code.wireshark.org/review

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-15 Thread Bálint Réczey
Hi Evan, 2014/1/15 Evan Huus eapa...@gmail.com: I have created an account and added an SSH key, but I am getting Permission denied (publickey) when trying to clone. Is it working for anyone else? After I set my username, it worked fine. Maybe you missed it like me for the first time. :-) On

Re: [Wireshark-dev] setcap for CMake install under Linux

2014-01-13 Thread Bálint Réczey
2014/1/13 Guy Harris g...@alum.mit.edu: On Jan 12, 2014, at 5:10 PM, Bálint Réczey bal...@balintreczey.hu wrote: IMO it does not have to support Debian packages. The best practice (and Debian's policy) is calling CMake from debian/rules, not the other way around. As long as switching from

Re: [Wireshark-dev] setcap for CMake install under Linux

2014-01-13 Thread Bálint Réczey
2014/1/13 Guy Harris g...@alum.mit.edu: On Jan 13, 2014, at 1:05 PM, Alexis La Goutte alexis.lagou...@gmail.com wrote: Missing also make dist-* (gzip, bzip...) family in CMake Yes - we need a way of releasing the source to a particular version, for the benefit of third parties making

Re: [Wireshark-dev] setcap for CMake install under Linux

2014-01-12 Thread Bálint Réczey
2014/1/13 Guy Harris g...@alum.mit.edu: On Jan 12, 2014, at 2:23 PM, Joerg Mayer jma...@loplof.de wrote: It allows the compilation with capabilities (that's what I use), but right now the installation process has neither suid nor setcap support. Does it really make sense to add this? If

Re: [Wireshark-dev] Add -Wdocumentation

2013-12-13 Thread Bálint Réczey
Hi, 2013/12/13 Alexis La Goutte alexis.lagou...@gmail.com: Hi, On Mon, Dec 9, 2013 at 5:58 PM, Bálint Réczey bal...@balintreczey.hu wrote: 2013/12/9 Joerg Mayer jma...@loplof.de: On Fri, Dec 06, 2013 at 03:38:08PM +0100, Alexis La Goutte wrote: I plan to add -Wdocumentation [1

Re: [Wireshark-dev] Where is packet-isdn-sup-table31.c?

2013-12-13 Thread Bálint Réczey
cmake ... make -C asn1/isdn-sup/ generated it for me in asn1/isdn-sup/ Cheers, Balint 2013/12/13 Christopher Maynard christopher.mayn...@gtech.com: In asn1/isdn-sup/packet-isdn-sup-template.c at line 110, there is: #include packet-isdn-sup-table31.c I'm unable to locate this file. Can

Re: [Wireshark-dev] Add -Wdocumentation

2013-12-09 Thread Bálint Réczey
2013/12/9 Joerg Mayer jma...@loplof.de: On Fri, Dec 06, 2013 at 03:38:08PM +0100, Alexis La Goutte wrote: I plan to add -Wdocumentation [1] by default to Wireshark (when build with Clang). I have already fix in trunk the documentation. The major issue to add -Wdocumentation is other library

Re: [Wireshark-dev] GTK+3 Win32/64 state

2013-12-04 Thread Bálint Réczey
on any other sides. 2013/6/13 Bálint Réczey bal...@balintreczey.hu: Hi All, Tarnyko kindly sent me an update on the progress of providing an official GTK+3 bundle on Windows. I'm not working on Windows nowadays, but I provide Wireshark packages in Debian unstable built with GTK+3 which work

Re: [Wireshark-dev] Lemon crashing on Solaris? (was Re: [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris-10-SPARC)

2013-11-28 Thread Bálint Réczey
2013/11/25 Guy Harris g...@alum.mit.edu: On Nov 25, 2013, at 12:00 PM, Bálint Réczey bal...@balintreczey.hu wrote: At least we (you) found a real problem by temporarily enabling the broken -ftrapv. :-) ...with a compiler that actually does something with it. Hopefully the GCC folks

Re: [Wireshark-dev] Lemon crashing on Solaris? (was Re: [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris-10-SPARC)

2013-11-25 Thread Bálint Réczey
2013/11/25 Guy Harris g...@alum.mit.edu: On Nov 24, 2013, at 5:37 PM, Bálint Réczey bal...@balintreczey.hu wrote: I tried to trigger a crash using GCC and -ftrapv without success while the clang-compiled binary crashed as expected: Reproduced with clang on (x86-64) OS X. The problem

Re: [Wireshark-dev] Lemon crashing on Solaris? (was Re: [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris-10-SPARC)

2013-11-24 Thread Bálint Réczey
2013/11/25 Guy Harris g...@alum.mit.edu: On Nov 24, 2013, at 2:59 PM, Guy Harris g...@alum.mit.edu wrote: I've removed -ftrapv; we'll see what that does. That fixed it. Either Lemon is explicitly depending on wrap-around on signed integer overflow, or implicitly depending on a lack of

Re: [Wireshark-dev] Licensing of tools/html2text.py

2013-11-03 Thread Bálint Réczey
2013/11/3 Evan Huus eapa...@gmail.com: It appears to be licensed under GPLv3 only, which makes it incompatible for us to include. It seems to be included only because links/lynx didn't appear to work a while ago when building under WIndows. If that is no longer true then I think we can just

Re: [Wireshark-dev] Status Cmake Win32 support

2013-10-12 Thread Bálint Réczey
Hi Graham, 2013/10/12 Graham Bloice graham.blo...@trihedral.com: On 11 October 2013 16:09, Joerg Mayer jma...@loplof.de wrote: ... There are the dumpabi projects that I'm not sure are needed for win32; dumpabi, dumpabi-libwireshark, dumpabi-libwiretap, dumpabi-libwsutil. I think those targets

Re: [Wireshark-dev] Status Cmake Win32 support

2013-10-12 Thread Bálint Réczey
Hi Jörg, 2013/10/11 Joerg Mayer jma...@loplof.de: Another milestone hit: - Win 32bit: The following executables build and run from the build directory (as well as capture if they should be able to). *: Acutally tested $ ls *exe capinfos.exe* dumpcap.exe mergecap.exe randpkt.exe

Re: [Wireshark-dev] [Wireshark-commits] rev 52484: /trunk/ /trunk/docbook/: CMakeLists.txt /trunk/cmake/modules/: FindXSLTPROC.cmake

2013-10-10 Thread Bálint Réczey
Hi, 2013/10/10 Joerg Mayer jma...@loplof.de: On Thu, Oct 10, 2013 at 05:02:51AM +, rbal...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=52484 User: rbalint Date: 2013/10/10 05:02 AM Log: Fix using fop from CMake Last time I tried (~1 week

Re: [Wireshark-dev] 1.11.0 release

2013-10-09 Thread Bálint Réczey
Hi Gerald, 2013/10/8 Gerald Combs ger...@wireshark.org: I've scheduled the release of 1.11.0 for next Tuesday, October 15. Corrections and additions for the release notes are welcome. Unfortunately the transitional state of our UI will be reflected in the release packages: Windows 32-bit:

Re: [Wireshark-dev] 1.11.0 release

2013-10-09 Thread Bálint Réczey
Hi Guy, 2013/10/9 Guy Harris g...@alum.mit.edu: On Oct 9, 2013, at 3:21 AM, Bálint Réczey bal...@balintreczey.hu wrote: Building Wireshark already needs way more tools than just make and a C compiler. Perhaps we should fix that, so that the release tarball includes all generated source

Re: [Wireshark-dev] Handling of generated dissectors

2013-10-07 Thread Bálint Réczey
2013/10/7 Joerg Mayer jma...@loplof.de: On Sun, Oct 06, 2013 at 04:27:50PM -0400, Evan Huus wrote: On Sun, Oct 6, 2013 at 4:25 PM, Joerg Mayer jma...@loplof.de wrote: Hello, Matthieu raised an issue that I've seen with asn2wrs generated dissectors too, just not to the extent of the pidl

Re: [Wireshark-dev] Trunk issues with GTK-3.10?

2013-10-03 Thread Bálint Réczey
Hi David, 2013/10/3 David Arnold dav...@pobox.com: Hi all, I'm seeing some issues compiling trunk against Gtk-3.10. Specifically, the GTK_STOCK_* icon macros and GtkAction type have now been deprecated, and their headers moved to the deprecated subdirectory. Should I be moving to Qt?

Re: [Wireshark-dev] Motivation for wmem [was: rev 52264]

2013-09-30 Thread Bálint Réczey
Hi All, 2013/9/30 Evan Huus eapa...@gmail.com: On Sun, Sep 29, 2013 at 6:38 PM, Jakub Zawadzki darkjames...@darkjames.pl wrote: On Sun, Sep 29, 2013 at 05:35:59PM -0400, Evan Huus wrote: On Sun, Sep 29, 2013 at 3:56 PM, Jakub Zawadzki darkjames...@darkjames.pl wrote: But back to topic

Re: [Wireshark-dev] [Wireshark-commits] rev 52129: /trunk/asn1/ /trunk/asn1/p22/: CMakeLists.txt Makefile.common /trunk/asn1/p7/: CMakeLists.txt Makefile.common /trunk/asn1/x509ce/: CMakeLists.txt Mak

2013-09-17 Thread Bálint Réczey
2013/9/17 Evan Huus eapa...@gmail.com: On 2013-09-17, at 8:45 PM, jma...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=52129 User: jmayer Date: 2013/09/17 01:45 PM Log: Fix remaining dependencides for -exp.cnf files. Does this mean it might finally

Re: [Wireshark-dev] Performance degradation in trunk

2013-09-12 Thread Bálint Réczey
Could they analyze perf results or run git bisect to find the point when the degradation started? Cheers, Balint 2013/9/12 Anders Broman anders.bro...@ericsson.com: Hi, I recently supplied some people with an internal build from recent trunk and got complaints on performance. Switching back

Re: [Wireshark-dev] Enabling linux kernel jit compiler from dumpcap?

2013-08-23 Thread Bálint Réczey
Hi, 2013/8/23 Anders Broman a.bro...@bredband.net: Bálint Réczey skrev 2013-08-22 23:02: ... Regarding Wireshark I would prefer suggesting echo 1 /proc/sys/net/core/bpf_jit_enable in the documentation instead of adding code to enable JIT. There may be good reasons for not enabling

Re: [Wireshark-dev] Enabling linux kernel jit compiler from dumpcap?

2013-08-23 Thread Bálint Réczey
(a.bro...@bredband.net): Bálint Réczey skrev 2013-08-22 23:02: Hi, I would be happier if the applications I run did not change kernel configuration without my consent. I see your point... Regarding Wireshark I would prefer suggesting echo 1 /proc/sys/net/core/bpf_jit_enable

Re: [Wireshark-dev] Enabling linux kernel jit compiler from dumpcap?

2013-08-23 Thread Bálint Réczey
2013/8/23 Anders Broman anders.bro...@ericsson.com: -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Bálint Réczey Sent: den 23 augusti 2013 12:59 To: Developer support list for Wireshark Subject: Re: [Wireshark

Re: [Wireshark-dev] Enabling linux kernel jit compiler from dumpcap?

2013-08-23 Thread Bálint Réczey
2013/8/23 Anders Broman anders.bro...@ericsson.com: -Original Message- From: rbal...@gmail.com [mailto:rbal...@gmail.com] On Behalf Of Bálint Réczey Sent: den 23 augusti 2013 14:23 To: Anders Broman Cc: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Enabling

Re: [Wireshark-dev] Enabling linux kernel jit compiler from dumpcap?

2013-08-22 Thread Bálint Réczey
Hi, I would be happier if the applications I run did not change kernel configuration without my consent. Regarding Wireshark I would prefer suggesting echo 1 /proc/sys/net/core/bpf_jit_enable in the documentation instead of adding code to enable JIT. There may be good reasons for not enabling

Re: [Wireshark-dev] Clang build with ASAN

2013-08-13 Thread Bálint Réczey
Hi, 2013/8/12 Alexis La Goutte alexis.lagou...@gmail.com: Hi, it is now possible to build wireshark with clang (CC=clang ./configure make) (i fix last issue last week end). Great news! I will try the ASAN feature ( http://clang.llvm.org/docs/AddressSanitizer.html ) ASAN is also ported

Re: [Wireshark-dev] Clang build with ASAN

2013-08-13 Thread Bálint Réczey
Hi Evan, 2013/8/13 Evan Huus eapa...@gmail.com: On Mon, Aug 12, 2013 at 11:17 AM, Alexis La Goutte alexis.lagou...@gmail.com wrote: Hi, it is now possible to build wireshark with clang (CC=clang ./configure make) (i fix last issue last week end). I will try the ASAN feature (

Re: [Wireshark-dev] Clang build with ASAN

2013-08-13 Thread Bálint Réczey
Hi Evan, 2013/8/13 Evan Huus eapa...@gmail.com: On Tue, Aug 13, 2013 at 10:07 AM, Alexis La Goutte alexis.lagou...@gmail.com wrote: On Tue, Aug 13, 2013 at 3:44 PM, Evan Huus eapa...@gmail.com wrote: On Tue, Aug 13, 2013 at 6:29 AM, Bálint Réczey bal...@balintreczey.hu wrote: Hi

Re: [Wireshark-dev] Remove hf_ variables

2013-08-06 Thread Bálint Réczey
2013/7/30 Joerg Mayer jma...@loplof.de: On Mon, Jul 29, 2013 at 10:42:02PM +0200, Jakub Zawadzki wrote: On Mon, Jul 29, 2013 at 01:25:41PM -0700, Guy Harris wrote: On Jul 29, 2013, at 1:12 PM, Jakub Zawadzki darkjames...@darkjames.pl wrote: Is anyone attached to hf_ variables? ;)

Re: [Wireshark-dev] Recent changes in composite TVB (extra changes beside move)

2013-08-01 Thread Bálint Réczey
2013/8/1 Graham Bloice graham.blo...@trihedral.com: On 31 July 2013 22:42, Jakub Zawadzki darkjames...@darkjames.pl wrote: SNIP --- 9d519b5659aa8c0c4aa984bc6169909eb31be7d6_2.c2013-07-31 22:50:46.144101741 +0200 +++ 9d519b5659aa8c0c4aa984bc6169909eb31be7d6_1.c2013-07-31

Re: [Wireshark-dev] Make gtk3 default (over gtk2)?

2013-07-23 Thread Bálint Réczey
Hi, 2013/7/23 Joerg Mayer jma...@loplof.de: Hello, how about making gtk3 the default over gtk2 when building Wireshark? Just to be clear: I only want to reverse the build defaults between gtk2 and 3. Hopefully it will get much more testing that way, so it is up to prime time for the next

Re: [Wireshark-dev] [Wireshark-core] Ubuntu buildbot failing when building the Debian package?

2013-07-15 Thread Bálint Réczey
Hi Guy, 2013/7/15 Guy Harris g...@alum.mit.edu: On Jul 15, 2013, at 6:57 AM, Bálint Réczey bal...@balintreczey.hu wrote: I think there is no clear preference. sensible-pager and sensible-editor are mentioned [1] in Debian Policy which gives direction to maintainers, but sensible browser

Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

2013-06-28 Thread Bálint Réczey
Hi Marc, 2013/6/28 Marc Petit-Huguenin m...@petit-huguenin.org: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/28/2013 07:21 AM, Jeff Morriss wrote: On 06/22/13 06:47, Bálint Réczey wrote: Hi All, 2013/6/21 Marc Petit-Huguenin m...@petit-huguenin.org: -BEGIN PGP SIGNED MESSAGE

Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

2013-06-27 Thread Bálint Réczey
Hi Michael, 2013/6/25 Bálint Réczey bal...@balintreczey.hu: Hi Michael, 2013/6/24 Michael Tuexen michael.tue...@lurchi.franken.de: ... The current process puts responsibility on the core developer who commits a change. Personally, I don't think it is bad if this breaks the build on some

Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

2013-06-25 Thread Bálint Réczey
Hi Michael, 2013/6/24 Michael Tuexen michael.tue...@lurchi.franken.de: ... The current process puts responsibility on the core developer who commits a change. Personally, I don't think it is bad if this breaks the build on some buildbot, I only this it is bad if the committer doesn't care.

Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

2013-06-24 Thread Bálint Réczey
Hi Michael, 2013/6/24 Michael Tuexen michael.tue...@lurchi.franken.de: On Jun 23, 2013, at 8:58 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi, 2013/6/22 Marc Petit-Huguenin m...@petit-huguenin.org: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/22/2013 09:43 AM, Bálint Réczey

Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

2013-06-23 Thread Bálint Réczey
Hi, 2013/6/22 Marc Petit-Huguenin m...@petit-huguenin.org: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/22/2013 09:43 AM, Bálint Réczey wrote: Hi Marc, 2013/6/22 Marc Petit-Huguenin m...@petit-huguenin.org: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/22/2013 03:47 AM

[Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

2013-06-22 Thread Bálint Réczey
Hi All, 2013/6/21 Marc Petit-Huguenin m...@petit-huguenin.org: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/20/2013 04:52 PM, Guy Harris wrote: On Jun 20, 2013, at 2:58 PM, Marc Petit-Huguenin m...@petit-huguenin.org wrote: On 06/20/2013 02:17 PM, Gerald Combs wrote:

Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

2013-06-22 Thread Bálint Réczey
Hi Martin, 2013/6/22 Martin Kaiser li...@kaiser.cx: Thus wrote Bálint Réczey (bal...@balintreczey.hu): I have started describing a Gerrit based workflow which IMO would fit to the project at http://wiki.wireshark.org/Development/Workflow . Please check it and share your opinion. would

Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

2013-06-22 Thread Bálint Réczey
Hi Marc, 2013/6/22 Marc Petit-Huguenin m...@petit-huguenin.org: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/22/2013 03:47 AM, Bálint Réczey wrote: Hi All, 2013/6/21 Marc Petit-Huguenin m...@petit-huguenin.org: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/20/2013 04:52

[Wireshark-dev] Fwd: GTK+3 Win32/64 state

2013-06-12 Thread Bálint Réczey
Hi All, Tarnyko kindly sent me an update on the progress of providing an official GTK+3 bundle on Windows. I'm not working on Windows nowadays, but I provide Wireshark packages in Debian unstable built with GTK+3 which work almost perfectly. If you are interested in running Wireshark with GTK+3

Re: [Wireshark-dev] [Wireshark-commits] rev 47393: /trunk/ui/qt/ /trunk/ui/qt/: QtShark.pro

2013-04-22 Thread Bálint Réczey
2013/4/22 Gerald Combs ger...@wireshark.org: On 4/22/13 12:21 PM, Joerg Mayer wrote: On Thu, Jan 31, 2013 at 06:54:14PM +, ger...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=47393 User: gerald Date: 2013/01/31 10:54 AM Log: Use the name

Re: [Wireshark-dev] Problems building easy_codec.dll

2013-03-15 Thread Bálint Réczey
Thanks Gisle, I'll commit this soon. Cheers, Balint 2013/3/15 Gisle Vanem gva...@broadpark.no: I'm having a problem compiling the *non* generated easy_codec_plugin.c. The message from MSVC is: error C2491: 'version' : definition of dllimport data not allowed for the line:

Re: [Wireshark-dev] qtshark - wireshark-qt ?

2013-03-15 Thread Bálint Réczey
-gtk2, wireshark-gtk3 or wireshark-qt as appropriate. I the first round (at least for 1.10.x) I think we could keep the name of the GTK version 'wireshark' since the Qt version is far from feature-complete. Cheers, Balint Evan On Tue, Mar 12, 2013 at 10:45 PM, Bálint Réczey bal

[Wireshark-dev] qtshark - wireshark-qt ?

2013-03-12 Thread Bálint Réczey
Hi, I would like to suggest renaming the relatively new qtshark binary to wireshark-qt. I believe wireshark-qt would align better with the practice of providing the very same software for different UI toolkits with the same name postfixed by the UI toolkit name. Cheers, Balint

Re: [Wireshark-dev] qtshark - wireshark-qt ?

2013-03-12 Thread Bálint Réczey
-gtk2, wireshark-gtk3 or wireshark-qt as appropriate. With CMake we can build both together and the qt version is called qtshark. I plan converting the Debian package to use CMake to ship both and simplify the build process. Cheers, Balint Evan On Tue, Mar 12, 2013 at 10:45 PM, Bálint Réczey

Re: [Wireshark-dev] Editcap link warnings

2013-03-08 Thread Bálint Réczey
in the export behavior. I checked in your changes in r48170 along with a workaround to reset the export definitions. It's clunkier than I would like but Visual C++ is happier now. On 3/7/13 8:23 AM, Bálint Réczey wrote: If no one objects I commit those tomorrow. Cheers, Balint 2013/3/7 Bálint

Re: [Wireshark-dev] Editcap link warnings

2013-03-07 Thread Bálint Réczey
I think the attached patches would make it be a bit less hack-ish. Cheers, Balint 2013/3/7 Gerald Combs ger...@wireshark.org: -DENABLE_STATIC instead of -DWS_BUILD_DLL worked on my machine. Checked in in r48158. On 3/6/13 8:52 AM, Christopher Maynard wrote: Pascal Quantin pascal.quantin@...

Re: [Wireshark-dev] Editcap link warnings

2013-03-07 Thread Bálint Réczey
If no one objects I commit those tomorrow. Cheers, Balint 2013/3/7 Bálint Réczey bal...@balintreczey.hu: I think the attached patches would make it be a bit less hack-ish. Cheers, Balint 2013/3/7 Gerald Combs ger...@wireshark.org: -DENABLE_STATIC instead of -DWS_BUILD_DLL worked on my

Re: [Wireshark-dev] Simpifying exporting DLL symbols

2013-03-03 Thread Bálint Réczey
are exported in builds using cc and Solaris Studio. I tried to fix that using but did not succeed. If someone works with those tools please try to fix that properly. Cheers, Balint 2013/2/27 Bálint Réczey bal...@balintreczey.hu: Hi Guy, 2013/2/27 Guy Harris g...@alum.mit.edu: On Feb 26, 2013

Re: [Wireshark-dev] FW: [Wireshark-commits] rev 47938: /trunk/ /trunk/debian/: wireshark-dev.header-files /trunk/: CMakeLists.txt configure.ac ws_symbol_export.h /trunk/wsutil/: CMakeLists.txt Makefil

2013-02-28 Thread Bálint Réczey
Hi Anders, I have fixed it now, I just wanted to run a full build to test fixing distcheck. Cheers, Balint 2013/2/28 Anders Broman anders.bro...@ericsson.com: Hi, Shouldn't ws_symbol_export.h be added to makefile.common ? Regards Anders -Original Message- From:

[Wireshark-dev] Windows buildbot breakage

2013-02-28 Thread Bálint Réczey
The commit converting libwiretap broke the Windows builds. I'm fixing the symbol exporting related build problems right now, but it seems my change also triggered additional compile-time checks which revealed existing errors. Cheers, Balint 2013/2/28 Bálint Réczey bal...@balintreczey.hu: Hi

Re: [Wireshark-dev] Simpifying exporting DLL symbols

2013-02-27 Thread Bálint Réczey
Hi Gisle, 2013/2/27 Gisle Vanem gva...@broadpark.no: Bálint Réczey bal...@balintreczey.hu wrote: I have created the attached patch to control symbol visibility using C defines instead of .def and .sym files. It is expected to work on every platform and every build system we support, but I

Re: [Wireshark-dev] Simpifying exporting DLL symbols

2013-02-27 Thread Bálint Réczey
2013/2/27 Dirk Jagdmann d...@cubic.org: I have tested it using autotools and CMake, but I could not give it a try on Windows or OS X. If you have some time and access to those platform please test the patch. I tested on OsX and it seems to work. I could compile Wireshark and run it. Thanks!

Re: [Wireshark-dev] Simpifying exporting DLL symbols

2013-02-27 Thread Bálint Réczey
Hi Guy, 2013/2/27 Guy Harris g...@alum.mit.edu: On Feb 26, 2013, at 2:08 PM, Bálint Réczey bal...@balintreczey.hu wrote: Exporting all symbols when using more exotic compilers should not be and issue, because plugins used on such exotic systems are probably compiled with GCC = 4.0, LLVM

Re: [Wireshark-dev] finishing Cmake (Was: Simpifying exporting DLL symbols)

2013-02-27 Thread Bálint Réczey
Hi, 2013/2/27 Jeff Morriss jeff.morriss...@gmail.com: Bálint Réczey wrote: 2013/2/26 Bill Meier wme...@newsguy.com: On 2/26/2013 5:11 PM, Bálint Réczey wrote: 2013/2/26 Pascal Quantin pascal.quan...@gmail.com: ... Thank you! If no one opposes I'll commit the patch on Thursday

[Wireshark-dev] Simpifying exporting DLL symbols

2013-02-26 Thread Bálint Réczey
Hi, I have created the attached patch to control symbol visibility using C defines instead of .def and .sym files. It is expected to work on every platform and every build system we support, but I did not want to commit it without discussing the direction. I have tested it using autotools and

Re: [Wireshark-dev] Simpifying exporting DLL symbols

2013-02-26 Thread Bálint Réczey
Hi Guy, 2013/2/26 Guy Harris g...@alum.mit.edu: On Feb 26, 2013, at 11:46 AM, Bálint Réczey bal...@balintreczey.hu wrote: I have created the attached patch to control symbol visibility using C defines instead of .def and .sym files. You might want to use comments on #else and #endif

Re: [Wireshark-dev] Simpifying exporting DLL symbols

2013-02-26 Thread Bálint Réczey
2013/2/26 Pascal Quantin pascal.quan...@gmail.com: ... Hi Balint, I just tried your patch on my Win32 box (MSVC2010) and it seems to be working fine: symbols exported by libwsutil.dll are the same before and after the patch. Regards, Pascal. Hi Pascal, Thank you! If no one opposes I'll

Re: [Wireshark-dev] Simpifying exporting DLL symbols

2013-02-26 Thread Bálint Réczey
2013/2/26 Jakub Zawadzki darkjames...@darkjames.pl: On Tue, Feb 26, 2013 at 08:46:28PM +0100, Bálint Réczey wrote: If you have concerns or comments, please share them. :-) Some (older) compilers don't support -fvisibility=hidden can you add test if this option is accepted by compiler? Sure

Re: [Wireshark-dev] Simpifying exporting DLL symbols

2013-02-26 Thread Bálint Réczey
2013/2/26 Bill Meier wme...@newsguy.com: On 2/26/2013 5:11 PM, Bálint Réczey wrote: 2013/2/26 Pascal Quantin pascal.quan...@gmail.com: ... Thank you! If no one opposes I'll commit the patch on Thursday and then start converting the remaining libs. It sounds like the change

Re: [Wireshark-dev] EXTERNAL: Windows Installer for Gtk+3.6.2 and gtkmm-3.6.0

2013-02-17 Thread Bálint Réczey
Hi Paul, 2013/2/17 Paul Davis p...@linuxaudiosystems.com: On Sat, Feb 16, 2013 at 7:27 AM, Bálint Réczey bal...@balintreczey.hu wrote: Unfortunately our efforts are severely impacted by the lack of official GTK+ installers for Windows and OS X and this uncertainty was a major reason

Re: [Wireshark-dev] EXTERNAL: Windows Installer for Gtk+3.6.2 and gtkmm-3.6.0

2013-02-17 Thread Bálint Réczey
2013/2/17 Paul Davis p...@linuxaudiosystems.com: On Sun, Feb 17, 2013 at 1:44 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi Paul, 2013/2/17 Paul Davis p...@linuxaudiosystems.com: On Sat, Feb 16, 2013 at 7:27 AM, Bálint Réczey bal...@balintreczey.hu wrote: Unfortunately

Re: [Wireshark-dev] EXTERNAL: Windows Installer for Gtk+3.6.2 and gtkmm-3.6.0

2013-02-16 Thread Bálint Réczey
On 12/30/2012 10:40 AM, Niklas Gürtler wrote: because i wasn't really able to find a nice Installation package for Gtk+3 on Windows, i have made one. Thanks for putting in the effort on that. I will have to try it. Damon Register Dear GTK+ Developers, Thank you for all the hard

Re: [Wireshark-dev] Google Summer of Code 2013

2013-02-15 Thread Bálint Réczey
2013/2/15 Guy Harris g...@alum.mit.edu: On Feb 14, 2013, at 9:09 PM, Hadriel Kaplan hkap...@acmepacket.com wrote: Provide a way for Wireshark to automatically check-for and optionally auto-retrieve the most recent version from wireshark's site/mirrors, For which operating systems? The

Re: [Wireshark-dev] Get_cpu_info on platforms other than Windows?

2013-02-06 Thread Bálint Réczey
Why do we need to show system information in Wireshark which is available in system specific tools which are better suited for this task? Cheers, Balint 2013/2/6 Anders Broman anders.bro...@ericsson.com: Hi, The included patch works on Ubuntu 64 bits but I guess it needs to be protected with

Re: [Wireshark-dev] [Wireshark-commits] rev 47460: / /trunk/: Makefile.am debian-setup.sh

2013-02-04 Thread Bálint Réczey
Hi All, 2013/2/4 Evan Huus eapa...@gmail.com: On Sun, Feb 3, 2013 at 7:53 PM, Guy Harris g...@alum.mit.edu wrote: On Feb 3, 2013, at 4:32 PM, Evan Huus eapa...@gmail.com wrote: Isn't apt-get build-dep wireshark a much easier way of doing the same thing? Would that install tools needed to

Re: [Wireshark-dev] [Wireshark-commits] rev 47460: / /trunk/: Makefile.am debian-setup.sh

2013-02-04 Thread Bálint Réczey
2013/2/4 Guy Harris g...@alum.mit.edu: On Feb 3, 2013, at 4:29 PM, g...@wireshark.org wrote: Try creating a script for Debian and derivatives that will grab the packages necessary for Wireshark development, using apt-get. Maybe it should parse the Build-Depends: line in debian/control and

<    1   2   3   >