[Wireshark-dev] Next release (plus SVN and roadmap changes)

2006-06-30 Thread Gerald Combs
We're overdue for an official Wireshark release. A couple of people have pointed out that the code in /trunk is in better shape than /trunk-1.0, and that we might be better off using it for future releases. I agree. I'd like to make the following changes in the repository, which would address

Re: [Wireshark-dev] Repository updates

2006-07-13 Thread Gerald Combs
when 1.0 is released. This issue has bubbled around a bit, so I'm slightly hesitant even to raise it again, but I'm not convinced any answers were clearly communicated when the now-defunct trunk-1.0 was created, but its demise certainly reopens it IMHO. Regards, Neil Gerald Combs wrote

Re: [Wireshark-dev] wireshark_0.99.2-1_i386.changes REJECTED

2006-07-19 Thread Gerald Combs
The Debian package approval process turned up several source files in the Wireshark distribution that don't have explicit licenses. With the exception of in_cksum.h, is there any reason these shouldn't be GPLed? epan/in_cksum.h: no license info (but most probably BSD, like in_cksum.c)

Re: [Wireshark-dev] wireshark_0.99.2-1_i386.changes REJECTED

2006-07-24 Thread Gerald Combs
Guy Harris wrote: gtk/win32-file-dlg.h Gerald? That one's yours, I think Fixed. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] TSU NOTIFICATION - encryption

2006-07-27 Thread Gerald Combs
SUBMISSION TYPE: TSU SUBMITTED BY: Gerald Combs SUBMITTED FOR: Wireshark development team POINT OF CONTACT: Gerald Combs PHONE and/or FAX: 530.758.2790 (phone) PRODUCT NAME/MODEL #: Wireshark ECCN: 5D002 NOTIFICATION: This email serves as as a notice that we are providing open source software

Re: [Wireshark-dev] TSU NOTIFICATION - encryption

2006-07-27 Thread Gerald Combs
In case anyone is wondering, this was cc'ed to wireshark-dev in order to provide a public archive of our Export Administration Regulations (EAR) notification: http://www.bis.doc.gov/Encryption/PubAvailEncSourceCodeNofify.html Gerald Combs wrote: SUBMISSION TYPE: TSU SUBMITTED BY: Gerald

[Wireshark-dev] GnuTLS for Windows added

2006-08-07 Thread Gerald Combs
I managed to build a GnuTLS package for Windows from the sources at http://www.josefsson.org/gnutls4win/ . It works using the snakeoil sample on the Wiki, but I haven't tested it against anything else. To use it you'll have to run nmake -f makefile.nmake setup against a recent SVN checkout.

Re: [Wireshark-dev] Protocol Decode broken link

2006-08-15 Thread Gerald Combs
Joerg Mayer wrote: I just had a look at this and couldn't decide on the proper way to fix this: On Thu, Jul 06, 2006 at 02:32:32PM -0400, [EMAIL PROTECTED] wrote: Just an FYI the link in Appendix B to: [He's referring to the users-guide] http://www.wireshark.org/docs/dfref/ is to a

Re: [Wireshark-dev] [Wireshark-announce] Wireshark 0.99.3 is now available

2006-08-24 Thread Gerald Combs
They were missing from Makefile.am. They've been added, and I'm building a 0.99.3a source package right now. BTW, shouldn't this have been caught by the distcheck buildbot step? Kukosa, Tomas wrote: Hi, following files are missing in the source package:

Re: [Wireshark-dev] wireshark 0.99.3 and images/toolbar/capture_ethernet_16.xpm

2006-08-24 Thread Gerald Combs
Jonathan Smith wrote: images/toolbar/capture_ethernet_16.xpm is missing from the wireshark-0.99.3 tarball, and compilation of gtk/capture_if_dlg.c fails trying to find this file. In rPath Linux's build, I have included this file from http://tinyurl.com/k6ug3, but I would very much like

[Wireshark-dev] Ubuntu and Solaris builder outage

2006-08-30 Thread Gerald Combs
The Ubunutu and Solaris builders will be unavailable for the next 10 days or so while they make their way to the west coast. The Windows and OS X builders should still be up and running during that period. ___ Wireshark-dev mailing list

[Wireshark-dev] Ubuntu and Solaris builder outage

2006-08-30 Thread Gerald Combs
The Ubunutu and Solaris builders will be unavailable for the next 10 days or so while they make their way to the west coast. The Windows and OS X builders should still be up and running during that period. ___ Wireshark-dev mailing list

Re: [Wireshark-dev] Official tag for 0.99.3?

2006-09-01 Thread Gerald Combs
Joerg Mayer wrote: Joerg Mayer wrote: On Thu, Aug 31, 2006 at 01:19:58PM -0600, Bryant Eastham wrote: Is someone going to copy the appropriate trunk-0.99.3 version to releases, or is it really not an official release? It seems you will have to wait again - Gerald is mostly offline for a

Re: [Wireshark-dev] Need info of recently added: GNUTLS, KFW, NETTLE, LUA and PortAudio for the Devel Guide and elsewhere

2006-09-11 Thread Gerald Combs
Ulf Lamping wrote: Hi List! The recently added libs are not mentioned in the documentation and in the About box. To add it, I need the following infos of the libs: - what is it (e.g. PortAudio - portable cross-platform Audio API) - what is it used for in Wireshark (e.g. enables audio

Re: [Wireshark-dev] svn checkout failing

2006-09-19 Thread Gerald Combs
Joerg Mayer wrote: I currently have problems accessing the read/write svn repo: [EMAIL PROTECTED]:~/work/wireshark/trunk svn up /usr/libexec/ld-elf.so.1: /usr/local/lib/libapr-1.so.2: Undefined symbol pthread_mutex_init svn: Connection closed unexpectedly It looks to me that this is a

Re: [Wireshark-dev] Fwd: ethereal hangs.

2006-09-26 Thread Gerald Combs
prashanth joshi wrote: Hi I wrote and then tried to run the following code. But the ethereal is hanging. Please any one me tell what may be wrong with it. Obviously my intention here is to parse the CDR's Regards, Prashanth. [...] int my_decode_cdr (tvbuff_t * tvb, int offset,

Re: [Wireshark-dev] What's this??

2006-10-04 Thread Gerald Combs
It snuck in when we were trying to fix a problem for someone who contacted us (CACE) directly. Sorry about the confusion. :) LEGO wrote: it got in there in 19401... I've always liked version codenames... but why Freightliner? Maybe he got the idea while moving from coast to coast? On

[Wireshark-dev] Release (0.99.4) next week

2006-10-09 Thread Gerald Combs
I'd like to release 0.99.4 next Wednesday (the 18th). If you're planning on checking in any major changes, please hold off until the release branch is created (probably Friday or Monday). ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org

Re: [Wireshark-dev] Chances to include the test scripts I've written into the buildbot?

2006-10-10 Thread Gerald Combs
Ulf Lamping wrote: Hi List! Some time ago I've written some command line option test scripts for WS, Tshark and dumpcap. I've recently run these scripts to check the changes from Richard van der Hoff - they take about a minute to complete. I've noticed, that some of the tests

Re: [Wireshark-dev] Release (0.99.4) next week

2006-10-10 Thread Gerald Combs
Ulf Lamping wrote: P.S: The changes I've done to the Preferences and alike dialogs needs to be mentioned at least in the release notes. Gerald, did you started the new notes already? I updated the version and cleared out the information from the last release; that's been checked in.

Re: [Wireshark-dev] Wireshark Build Errors: airpcap.h, sync_pipe_write.c, #defines, and ints

2006-10-12 Thread Gerald Combs
Turner, Jay wrote: In my email after the error I indicated that I was building Wireshark 0.99.3a. I did a Google Search and found this posting: http://www.mail-archive.com/wireshark-dev@wireshark.org/msg01025.html which had an airpcap.h file attached. With that file I was able to build

Re: [Wireshark-dev] [Wireshark-commits] rev 19552: /trunk/ /trunk/docbook/: release-notes.xml /trunk/: ChangeLog

2006-10-16 Thread Gerald Combs
What are the minimum kernel and libpcap versions required for this to work? ronnie sahlberg wrote: For the usb support. Wireshark now supports USB as a mediatype and ALSO supports live capturing from USB interfaces (on recent linux kernels) On 10/16/06, [EMAIL PROTECTED] [EMAIL

Re: [Wireshark-dev] Release (0.99.4) next week

2006-10-18 Thread Gerald Combs
On 10/10/06, Gerald Combs [EMAIL PROTECTED] wrote: I'd like to release 0.99.4 next Wednesday (the 18th). If you're planning on checking in any major changes, please hold off until the release branch is created (probably Friday or Monday

Re: [Wireshark-dev] Adding a license tab to About Wireshark

2006-10-18 Thread Gerald Combs
Jaap Keuter wrote: Hi list, In view of recent discussions we could attribute to the presentation of the GPL by providing a license tab on the About Wireshark dialog, presenting the GPL as read from the COPYING file. The method will be the same as for authors-short file so GTK2 only, but

Re: [Wireshark-dev] Pending stuff for 0.99.4

2006-10-24 Thread Gerald Combs
The following revisions have been copied over: 19646 19651 19653 19654 19662 19666 19667 19669 19670 19673 If any more need to be copied, let me know. ronnie sahlberg wrote: please pull 19669 across as well. it does appear there are a few people that

Re: [Wireshark-dev] Do we need a 0.99.4pre2?

2006-10-24 Thread Gerald Combs
Ulf Lamping wrote: Hi List! There were a lot of bugs fixed in the pre1. Do we need a pre2 before the release or is it sure that all proposed fixes are included and they don't interact in a bad way? It might be a lot easier to fix remaining things in the pre2 than to get all the

Re: [Wireshark-dev] Lua breaks Windows build

2006-10-24 Thread Gerald Combs
Anders Broman wrote: Hi, Windows build is broken: register_wslua.c taps_wslua.c wslua_dumper.c wslua_field.c wslua_field.c(179) : error C2065: 'FieldInfo_get_data_source' : undeclared identifier wslua_field.c(179) : error C2099: initializer is not a constant wslua_field.c(181) : error

Re: [Wireshark-dev] Pending stuff for 0.99.4

2006-10-26 Thread Gerald Combs
Gilbert Ramirez wrote: I'd like to see revision 19680 in the 0.99.4pre2 release. It's a fix to bug 1085. I just checked it in, but the submitter and I have been working on it and testing it for the past 2 weeks. I've done fuzz testing, too. Done (along with several others).

Re: [Wireshark-dev] 0.99.4 packaging fails on Windows

2006-11-03 Thread Gerald Combs
Ulf Lamping wrote: The automated buildbot does the following to ensure all files are in the source tarball for a *unix* build (see the Ubuntu buildbot at http://buildbot.wireshark.org/trunk/): - dist creates a tarball (the same way as the one that you'll get at the release) - using all the

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1179] cmake build integration + dbus + bunch of memleak fixes

2006-11-07 Thread Gerald Combs
Joerg Mayer wrote: On Tue, Nov 07, 2006 at 09:26:50AM +, ronnie sahlberg wrote: As someone that has actually studied the feasibility of making wireshark multithreaded and what would be required ... Written with tons of globals variables, non thread safe, ... [Good reasons about the

[Wireshark-dev] Enabling threads

2006-11-07 Thread Gerald Combs
Is there any reason threads shouldn't be enabled by default? It would make implementing the version checking and windows update features in the roadmap a bit easier and cleaner. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org

Re: [Wireshark-dev] Enabling threads

2006-11-08 Thread Gerald Combs
seconds. this did cause a quite significant degradation in performance/speed of ethereal which is why it was removed :-( On 11/8/06, Ulf Lamping [EMAIL PROTECTED] wrote: Gerald Combs wrote: Is there any reason threads shouldn't be enabled by default? It would make implementing the version

Re: [Wireshark-dev] [Wireshark-commits] rev 19930: /trunk/ /trunk/gtk/: main.c /trunk/docbook/wsug_src/: WSUG_chapter_use.xml

2006-11-19 Thread Gerald Combs
Stephen Fisher wrote: On Sat, Nov 18, 2006 at 05:17:29PM +, [EMAIL PROTECTED] wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=19930 User: gerald Date: 2006/11/18 05:17 PM Log: If the user starts typing ([a-zA-Z0-9]) anywhere in the main window, start filling

Re: [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars

2006-11-24 Thread Gerald Combs
Guy Harris wrote: Stefan (metze) Metzmacher wrote: if isprint() is used, we should make sure the value isn't larger than 0xFF, as currently GDK_Up and GDK_Down trigger a focus switch to the filter. Should it be if (isascii(event-keyval) isprint(event-keyval)) so that control

Re: [Wireshark-dev] Wireshark crash on Windows (latest SVN)

2006-11-24 Thread Gerald Combs
Ulf Lamping wrote: isprint() doesn't have a limited input range so it shouldn't crash on this call - and on my machine it doesn't do so even with the value 65513. Feeding it anything outside an unsigned char or EOF is undefined, and can crash on systems that use glibc:

Re: [Wireshark-dev] Generic dissector generator

2006-12-05 Thread Gerald Combs
Marcelo Jedi wrote: Hi everybody, After I learned how to write simple dissectors (without conversation or any advanced feature) I started to look for some dissector generators. I tested idl2wrs, asn2wrs and Pidl. They work fine, but generate code related to specific protocols, not for a

Re: [Wireshark-dev] HAVE_AIRPDCAP

2006-12-06 Thread Gerald Combs
I've checked in a slightly different fix in r20053. Tomas, can you verify that it works on your system? Giorgio Tino wrote: Hi Tomas, HAVE_AIRPDCAP is a define, used to compile Wireshark with the support of WPA and WPA2. It is defined in 3 makefiles: \Makefile.nmake,

Re: [Wireshark-dev] [Wireshark-commits] rev 20049: /trunk/ /trunk/epan/dissectors/: Makefile.nmake packet-ieee80211.c /trunk/epan/: libwireshark.def /trunk/gtk/: Makefile.nmake airpcap_dlg.c airpcap_d

2006-12-06 Thread Gerald Combs
Joerg Mayer wrote: Gerald, On Tue, Dec 05, 2006 at 07:24:27PM +, [EMAIL PROTECTED] wrote: Log: From Davide Schiera and Giorgio Tino: Add initial WPA/WPA2 decryption support. WEP key preferences have been overloaded to allow WPA keys. The decryption code currently uses

Re: [Wireshark-dev] Buildbot fail of the capture tests - how to solve this?

2006-12-11 Thread Gerald Combs
Ulf Lamping wrote: Hi! The Win32 buildbot currently fails to run the command line tests I've written. This is due to the fact that the capture interface (number 3 in this case) doesn't capture enough traffic in a reasonable amount of time (I think the timeout is set to 10s) so it

Re: [Wireshark-dev] [PATCH] ieee80211 integer overflow

2006-12-11 Thread Gerald Combs
Neil Kettle wrote: (on another note, my mail address has changed from [EMAIL PROTECTED] (AUTHORS)) Fixed. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [PATCH] ieee80211 integer overflow

2006-12-12 Thread Gerald Combs
Neil Kettle wrote: Hi all - the following is caused by an integer overflow in buggy pointer arithmetic in the calculation of the length parameter for the g_snprintf call... This is likely unexploitable due to a combination of the restrictions of the bytes we may write ('0'-'9', 'A'-'F')

Re: [Wireshark-dev] Microsoft Visual C Version 6 support is a bit outdated ...

2006-12-18 Thread Gerald Combs
Ulf Lamping wrote: Hi List! We currently only support MSVC Version 6 for the Windows builds. As Version 6 is pretty much outdated and it's possible that I won't have access to such an installation in the near future, it seems to become time to make WS buildable on a newer MSVC version.

Re: [Wireshark-dev] Microsoft Visual C Version 6 support is a bit outdated ...

2006-12-18 Thread Gerald Combs
Ulf Lamping wrote: Gerald Combs wrote: No complaints here. Are there any issues with the supporting libraries that need to be addressed, e.g. msvcrt.dll vs msvcr7.dll? Do you mean legal issues, or something else? I mean having Wireshark linked against a newer CRT DLL and glib linked

Re: [Wireshark-dev] Microsoft Visual C Version 6 support is a bitoutdated ...

2006-12-19 Thread Gerald Combs
Ulf Lamping wrote: The biggest hurdle seems to be the different msvcrt.dll (C runtime library) versions for the libs we use, as Gerald already mentioned - I'm still thinking about the possibilities to solve this. If we need to we can split the packages subdirectory in wireshark-win32-libs

Re: [Wireshark-dev] Problems encountered on Windows building from a source tarball

2006-12-27 Thread Gerald Combs
Bill Meier wrote: While testing building Wireshark on Windows from a 'source tarball' (from today) I encountered the following problems: 1. The airpdcap directory is accessed as part of the make (even if AIRPCAP_DIR is not defined in config.nmake) but is not in the source tarball; I'm in

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1287] Problem with capturing on an Accton EN1207D ethernet card

2007-01-01 Thread Gerald Combs
Ulf Lamping wrote: Stephen Fisher wrote: Should we modify the installer so it won't install on Win98 (or will at least warn people that it's unsupported)? Since SVN 19776, the installer denies installation on Win95/98/ME - and notes that Ethereal 0.99.0 was the last known version to

Re: [Wireshark-dev] Airpcap patches

2007-01-02 Thread Gerald Combs
Checked in. Thanks! Gisle Vanem wrote: Here are some patches needed to build using HAVE_AIRPCAP on MingW: * airpcap.h needs 'WEP_KEY_MAX_SIZE' from epan/crypt/wep-wpadefs.h. * airpcap_loader.h needs epan/crypt/airpdcap_user.h and definition of 'decryption_key_t'. *

Re: [Wireshark-dev] [Wireshark-commits] rev 20318: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ieee80211.c

2007-01-07 Thread Gerald Combs
Joerg Mayer wrote: On Thu, Jan 04, 2007 at 11:21:37PM +, [EMAIL PROTECTED] wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=20318 User: gerald Date: 2007/01/04 11:21 PM Log: Don't lower-case our SSID and passphrase, otherwise we'll create an incorrect PSK hash.

Re: [Wireshark-dev] [Wireshark-commits] rev 20318: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ieee80211.c

2007-01-08 Thread Gerald Combs
Joerg Mayer wrote: On Sun, Jan 07, 2007 at 10:28:46PM -0800, Gerald Combs wrote: Don't lower-case our SSID and passphrase, otherwise we'll create an incorrect PSK hash. The code still makes another mistake: The SSID is not a string - it's a binary object which may even contain 0x00

Re: [Wireshark-dev] R: [Wireshark-commits] rev 20318: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ieee80211.c

2007-01-08 Thread Gerald Combs
Davide Schiera wrote: What about wpa-phx:MyPassword:SSID WITH\x00INSIDE? And for the : - \x3A or \:? That would work too. Along with C-style encoding there's RFC 3986-style percent encoding, e.g. SSID WITH%00INSIDE and My%3aPassword. Does anyone strongly prefer one over the other?

Re: [Wireshark-dev] Slow startup delay caused by uninitialized variable...

2007-01-09 Thread Gerald Combs
[EMAIL PROTECTED] wrote: I cannot find the source code for gcry_rndw32_gather_random. In the patched version of libgcrypt used with Wireshark 0.99.4 there is an uninitialized variable being checked and since it is not consistently set will cause the slow random bit generation code to be used

Re: [Wireshark-dev] How far from branching next release?

2007-01-09 Thread Gerald Combs
LEGO wrote: Gerald, How far in time are we from branching the next release? I'm almost there with SNMPv3 USM authentication and decryption, and I would like to know whether if to start checking it in now or to wait for the branching. It depends how long we have to wait for the

[Wireshark-dev] Add U3 package to the release process?

2007-01-10 Thread Gerald Combs
I just modified the U3 package build to add the version number to the package file name. (Hopefully this doesn't break anything Graeme is doing). Is there any reason the Windows U3 package shouldn't be added as one of the official release packages (and to Buildbot)?

Re: [Wireshark-dev] win32 buildbot fails in airpcap_gui_utils.c

2007-01-11 Thread Gerald Combs
Ulf Lamping wrote: Hi! The Win32 buildbot fails with: airpcap_gui_utils.c airpcap_gui_utils.c(338) : error C2039: 'str' : is not a member of '_GByteArray' C:\wireshark-win32-libs\glib\include\glib-2.0\glib/garray.h(45) : see declaration of '_GByteArray'

Re: [Wireshark-dev] [The Wireshark Wiki] Update of FrontPage by nickvlas

2007-01-12 Thread Gerald Combs
Ulf Lamping wrote: Wireshark Wiki - Do not reply wrote: Dear Wiki user, You have subscribed to a wiki page or wiki category on The Wireshark Wiki for change notification. The following page has been changed by nickvlas: http://wiki.wireshark.org/FrontPage

Re: [Wireshark-dev] Increasing buildbot trigger delay

2007-01-13 Thread Gerald Combs
Jaap Keuter wrote: Hi Gerald, I've noticed a trend in which commits are grouped together within a short timespan, eg. people committing a change in multiple steps. Currently the buildbot takes a one minute delay before starting a build. This is usually too short resulting in a two

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1287] Problem with capturing on an Accton EN1207D ethernet card

2007-01-13 Thread Gerald Combs
Ulf Lamping wrote: the built docs as the last step. Obviously, the docs must be generated at least before the created package step (maybe even before the compiling step). Gerald, could you please change this sequence in the Win32 buildbot? Then we can simply enable the setting in

Re: [Wireshark-dev] Add U3 package to the release process?

2007-01-13 Thread Gerald Combs
Graeme Lunt wrote: On 1/10/07, Gerald Combs [EMAIL PROTECTED] wrote: I just modified the U3 package build to add the version number to the package file name. (Hopefully this doesn't break anything Graeme is doing). Shouldn't break anything. Is there any reason the Windows U3 package

Re: [Wireshark-dev] airpdcap.c with gtk1.2 does not compile anymore

2007-01-14 Thread Gerald Combs
This should be fixed in r20438. Sebastien Tandel wrote: Hi, in rev20388 some functions have been defined in strutil.c (only for gtk = 2). These functions are used by airpdcap.c/airpcap_loader.c in code for any version of gtk. epan/.libs/libwireshark.so: undefined reference to

Re: [Wireshark-dev] Add U3 package to the release process?

2007-01-15 Thread Gerald Combs
Graeme Lunt wrote: Gerald, It's now part of the build process. Buildbot-generated U3 packages are now deposited in http://www.wireshark.org/download/automated/win32/, just like the executable installers. Thanks. If I write something that verifies the integrity of the generated U3

Re: [Wireshark-dev] [Patch] packet-kerberos.c

2007-01-17 Thread Gerald Combs
Gisle Vanem wrote: Sebastien Tandel [EMAIL PROTECTED] wrote: PS. What's up with the mailing-list software? Every message looks like crap; all line-endings are missing. Is the ML-software running on a Mac? Everything's fine here ... maybe a new feature of Outlook Express? :-p It's not

[Wireshark-dev] Wireshark 0.99.5pre1 is now available

2007-01-19 Thread Gerald Combs
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Wireshark 0.99.5pre1 is now available for testing. Source code and a Windows installer can be downloaded immediately from http://www.wireshark.org/download/prerelease/wireshark-0.99.5pre1.tar.gz

Re: [Wireshark-dev] How do I initialise a boolean preference

2007-01-22 Thread Gerald Combs
You might try checking Help-About Wireshark-Folders. Specific locations vary by platform and compile-time options. Hal Lander wrote: I did not realise there was a preference file. Now looking at http://www.wireshark.org/docs/man-pages/tshark.html I can see there should be a global and a

Re: [Wireshark-dev] [Patch] airpcap_loader.h

2007-01-23 Thread Gerald Combs
Checked in with r20535. Thanks! Gisle Vanem wrote: A case of conflict in definition and implementation: --- SVN-Latest\airpcap_loader.h Mon Jan 22 22:20:27 2007 +++ airpcap_loader.hMon Jan 22 22:37:08 2007 @@ -309,7 +309,7 @@ * Will return null if no device is found. */ GList*

[Wireshark-dev] Include WinPcap 4.0 with the next release?

2007-01-24 Thread Gerald Combs
WinPcap 4.0 final is due out in a few days. It adds support for Vista, is synced with libpcap 0.9.5, and has many other fixes and updates. Would it make sense to ship it with the 0.99.5 release instead of WinPcap 3.1? ___ Wireshark-dev mailing list

Re: [Wireshark-dev] [Wireshark-commits] rev 20546: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ieee80211.c

2007-01-25 Thread Gerald Combs
Joerg Mayer wrote: Gerald, On Wed, Jan 24, 2007 at 07:22:15PM +, [EMAIL PROTECTED] wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=20546 Directory: /trunk/epan/dissectors/ ChangesPath Action +104 -104 packet-ieee80211.cModified

[Wireshark-dev] 802.11 whdrs array needed?

2007-01-25 Thread Gerald Combs
The 802.11 dissector has the following code: wlan_hdr *volatile whdr; static wlan_hdr whdrs[4]; whdr= whdrs[0]; It looks like whdrs[1] through whdrs[3] are never used. Should the code be modified to rotate through each member of whdrs, similar to the fmtbuf arrays in strutil.c?

Re: [Wireshark-dev] address_to_str_buf not checking available buffer length

2007-01-29 Thread Gerald Combs
Andrej Mikus wrote: In file to_str.c I notice function address_to_str_buf that takes buf_len as argument, but does not use it for IPv4 and IPv6 addresses: void address_to_str_buf(const address *addr, gchar *buf, int buf_len) { switch(addr-type){ case AT_IPv4:

Re: [Wireshark-dev] wireshark-setup-0.99.5pre2-20620.exe large icon missing

2007-01-30 Thread Gerald Combs
Jaap Keuter wrote: Hi list, When downloading the Win32 installer on WinXP SP2 and looking at the properties of it, there's no icon. I see that the icon used if the bevelled one, I don't know what the firefox download window and the properties tab uses. Can you check the properties for the

Re: [Wireshark-dev] [Wireshark-commits] rev 20608: /trunk/gtk/ /trunk/gtk/: sctp_assoc_analyse.c sctp_stat.c sctp_stat.h sctp_stat_dlg.c

2007-01-30 Thread Gerald Combs
Done. Michael Tuexen wrote: Gerald, could you please copy this over to 0.99.5 tree? These are bugfixes which improves the handling of some SCTP trace captured in real life traces. Best regards Michael On Jan 29, 2007, at 8:45 PM, [EMAIL PROTECTED] wrote:

Re: [Wireshark-dev] [patch] address_to_str_buf not checking available buffer length

2007-01-31 Thread Gerald Combs
: On Mon, 29.Jan.07 12:49:00 -0800, Gerald Combs wrote: Andrej Mikus wrote: In file to_str.c I notice function address_to_str_buf that takes buf_len as argument, but does not use it for IPv4 and IPv6 addresses: Unfortunately, there wasn't a mechanism to ensure that the buffer was big enough. I've

Re: [Wireshark-dev] Win32 buildbot should switch over to use Makefile.nmake

2007-02-01 Thread Gerald Combs
Ulf Lamping wrote: Hi! The Win32 buildbot currently fails to generate the docbook docs. This is due to problems with generating the svn_version.xml, and that is due to the known bash CR/NL problems. Instead of trying to fix this, the buildbot should use the new Makefile.nmake (I've

Re: [Wireshark-dev] Display Filter References

2007-02-01 Thread Gerald Combs
Graeme Lunt wrote: When/how do the display filter pages get updated? Some of the new protocols (e.g. DMP, PKCS12) do not have corresponding pages. They get updated as a part of the release process, so that version information can be added. ___

[Wireshark-dev] Wireshark 0.99.5 is now available

2007-02-02 Thread Gerald Combs
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Wireshark 0.99.5 has been released. What is Wireshark? Wireshark is the world's most popular network protocol analyzer. It is used for troubleshooting, analysis, development, and education. What's New Bug Fixes The following

Re: [Wireshark-dev] U3 questions/remarks

2007-02-02 Thread Gerald Combs
Guy Harris wrote: Graeme Lunt wrote: Well, I've just had a quick look at this and it appears to be because the Wireshark icon I put into the manifest has more than 256 colours. This is not a problem for the main launchpad window but it apparently a problem for the More Programs sub menu. To

[Wireshark-dev] Add BPF filtering to Wiretap?

2007-02-05 Thread Gerald Combs
Would it make sense to add BPF filtering to Wiretap via pcap_offline_filter()? This would let you pre-filter capture files in Wireshark and TShark (and possibly editcap) without having to build a protocol tree. The main disadvantage is that it's only available in WinPcap.

Re: [Wireshark-dev] Patch - Decode for 802.11n Beacon/Probe/Association Information Elements

2007-02-05 Thread Gerald Combs
Clay Jones wrote: This patch adds decodes for 802.11n information elements. Since 802.11n isn't a formal standard yet they are not using the final packet structures or ie type numbers. But there are already 802.11n pre release devices out there and these decodes do seem to correctly decode

Re: [Wireshark-dev] Controlling Tshark output format

2007-02-07 Thread Gerald Combs
Would it make more sense to extend the current -T flag e.g. -Tfields,ip,udp,tcp.srcport instead? This would tie the output spec directly to the fields format. It might be useful to be able to restrict the fields in the pdml, ps, and text formats as well. Ian Schorr wrote: This would be

[Wireshark-dev] Windows named pipe support

2007-02-09 Thread Gerald Combs
I just enabled code in capture_loop.c which allows capturing from named pipes under Windows, e.g. tshark -i \\.\pipe\capture Can someone else test the change and verify that it works on their system? ___ Wireshark-dev mailing list

Re: [Wireshark-dev] Win32 buildbot unhappy while building docs

2007-02-12 Thread Gerald Combs
It looks like the builder hung at some point. I've restarted it. Douglas Pratley wrote: For what it's worth, wsug.validated builds fine on my machine, both using nmake and cygwin make. Unless I've not noticed a commit that fixes this, perhaps this is a problem with the build machine

Re: [Wireshark-dev] The Win32 buildbot is still very unhappy ...

2007-02-13 Thread Gerald Combs
Ulf Lamping wrote: Hi Gerald! Looking at the logs, I don't have a clue what the problem is. Any ideas to solve it? Rebooting seems to have worked. :) ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org

Re: [Wireshark-dev] crypt-sha1

2007-03-16 Thread Gerald Combs
The wiki page has been updated. Maybe we should have a svn diff | gzip | send-the-patch-to-bugzilla pipeline. :) Sebastien Tandel wrote: I've never said there was a lot of changes ;) Concerning the compressed patches, I will keep in mind for the next time. However, if you want to

Re: [Wireshark-dev] Buildbot compile flags

2007-03-25 Thread Gerald Combs
Joerg Mayer wrote: On Thu, Mar 22, 2007 at 08:01:50PM -0700, Stephen Fisher wrote: On Thu, Mar 22, 2007 at 07:47:35PM -0700, Guy Harris wrote: The alternative is to compile with -std=c99 for the long long case, but do we really want to do that? I agree that -pedantic is a bit too much to

Re: [Wireshark-dev] Broken Record - Release tag

2007-03-28 Thread Gerald Combs
Bryant Eastham wrote: Gerald Combs wrote: /trunk-0.99.2 was copied from /trunk last week. Once the 0.99.2 release is made it will be moved to /releases/wireshark-0.99.2. Some time in the future we'll start over again by copying /trunk to /trunk-0.99.3. Sorry to sound like a broken

Re: [Wireshark-dev] Update official Windows build?

2007-04-02 Thread Gerald Combs
://nsis.sourceforge.net/Main_Page Bitrock installer: http://bitrock.com/products_installbuilder_overview.html (Platform independent installer) Gerald Combs schrieb: The official Windows installers are still built using Visual Studio 6.0. I'd like to switch over to Visual C++ 2005 Express Edition

Re: [Wireshark-dev] The war against warnings - mission accomplished!

2007-04-03 Thread Gerald Combs
Richard van der Hoff wrote: Stephen Fisher wrote: On Tue, Apr 03, 2007 at 03:11:38PM +0100, Richard van der Hoff wrote: I guess I'm not quite up to speed with the state of this project... Am I right in thinking that warnings have only been purged successfully so far for the win32 build? I

[Wireshark-dev] Changes to make-dissector-reg.py

2007-04-06 Thread Gerald Combs
In order to speed up compile time, I've added a cache to make-dissector-reg.py (the script used to generate register.c). When you update a dissector and recompile, it _should_ pull the registration data for unchanged dissectors from its cache, thereby speeding up compilation time. On my home

Re: [Wireshark-dev] [PATCH] Adding option to IEEE 802.11 to ignore wep bit with IV

2007-04-11 Thread Gerald Combs
Checked in. Thanks! Stig Bjørlykke wrote: Hi. This patch adds an option to IEEE 802.11 to ignore the wep bit with IV, as mentioned in http://www.wireshark.org/lists/wireshark-dev/200704/msg00021.html I also fixed a bug where the packet is dissected different in the Packet List with and

Re: [Wireshark-dev] Bug in register.c generation

2007-04-13 Thread Gerald Combs
Joerg Mayer wrote: Hello, I've got a problem with the generation of the register.c file: [EMAIL PROTECTED]:~/work/wireshark/trunk/epan/dissectors sort register.c | uniq -c | grep -v 1 2 2 { 2 } 2 {extern void proto_register_cisco_oui (void);

Re: [Wireshark-dev] lex on ubuntu buildbot

2007-04-14 Thread Gerald Combs
Sebastien Tandel wrote: Hi, does anyone know what's the lexer (and version) used on the ubuntu buildbot machine? Lex says: $ lex --version lex 2.5.33 ___ Wireshark-dev mailing list [EMAIL PROTECTED]

[Wireshark-dev] OS X builder down

2007-04-16 Thread Gerald Combs
The OS X builder (an aging Power Mac G4) went down early this morning and now refuses to boot. I haven't had time to look at the problem in detail, but we may be without fuzz testing for a while. ___ Wireshark-dev mailing list

Re: [Wireshark-dev] no more Python 2.1.1

2007-04-17 Thread Gerald Combs
Jeff Morriss wrote: My Solaris builds now fail with: Making register.c with python Traceback (most recent call last): File ../../tools/make-dissector-reg.py, line 98, in ? cur_mtime = os.fstat(file.fileno()).st_mtime AttributeError: 'tuple' object has no attribute 'st_mtime' with

Re: [Wireshark-dev] [PATCH] Fix break placement for control frame in packet-ieee80211.c

2007-04-25 Thread Gerald Combs
Checked in. Thanks! Stig Bjørlykke wrote: Hi. Fix break placement for control frames in dissect_ieee80211_common() ___ Wireshark-dev mailing list

Re: [Wireshark-dev] OpcUa update

2007-05-07 Thread Gerald Combs
Gerhard Gappmeier wrote: Hi, A fuzzed Sample.cap file (attached) crashed TShark and took a *very* long time (2 mins) to load in WS. it loads the file imediately on my computer without any delay. I tried the fuzzy file also with tshark. I called tshark -r sample.cap, is this right?

Re: [Wireshark-dev] Win32 buildslave failure

2007-05-10 Thread Gerald Combs
Bill Meier wrote: My belief is that this is not a bug in GTK/GDK but rather an attempt by wireshark to output an error message (pop up window ?) during one of the unit tests. Wireshark is being run from a shell command line for the unit tests and maybe this test setup doesn't quite work

Re: [Wireshark-dev] Win32 buildslave failure

2007-05-10 Thread Gerald Combs
Bill Meier wrote: What's also interesting is that the last build took much less time than the previous builds. (The compile step took just 30 mins or so instead of hours!). Are there other things running on that node or is this a case of Windows strikes again !! :) It's a VM sharing

Re: [Wireshark-dev] GTK 2.10.12

2007-05-14 Thread Gerald Combs
The gimp.org page hasn't been updated yet, but updated binaries are available at http://ftp.gnome.org/pub/GNOME/binaries/win32/ . I've updated the wireshark-win32-libs repository, so you'll need to run 'nmake -f makefile.nmake setup' if you've updated SVN recently. Anders Broman wrote: Hi, We

Re: [Wireshark-dev] Improve wireshark to fault injection tool

2007-05-15 Thread Gerald Combs
[EMAIL PROTECTED] wrote: Hello everybody, I need to improve wireshark to a fault injection tool. It's a fault communication injector that i need to create from the wireshark source. To do this, i want to use the libnet librairie in order to make fault like : - delay time fault -

Re: [Wireshark-dev] Please test fix Critical bug 1360

2007-05-16 Thread Gerald Combs
Jaap Keuter wrote: Hi list, Can someone test the current Windows build against the capture in bug 1360? It's a critical bug we need to get closed, like the other 13 criticals. It appears to be fixed, so I closed the bug. Since we've almost 200 bugs open, 14 critical, we need to get

Re: [Wireshark-dev] Update to the COPYING file

2007-05-16 Thread Gerald Combs
Ulf Lamping wrote: Gerald Combs wrote: Back in October there was a discussion about the fact that we have a click-through agreement in the Windows installer requiring that users accept the GPL. After reading through the thread again, I've updated the summary in the COPYING file to read

  1   2   3   4   5   6   7   8   9   10   >