Re: [Wireshark-dev] Cannot get external capture (extcap) interface to work with my new plugin.

2018-12-30 Thread Roland Knall
Hi Have you properly closed the pipe after sending the packets? It looks more like an issue in flushing the pipe, then a code error. tshark handles this a little bit different then wireshark, so that might be the reason, why it did work on the CLI. Try flushing the pipe immediately after every

Re: [Wireshark-dev] How do you tell cmake to look in /usr/local/lib for libpcap?

2018-12-03 Thread Roland Knall
Have you recreated the CMakeCache.txt? Could you try running the command in a completely new environment, but with PCAP_HINTS set to /usr/local for the first run? It seems that cmake/modules/FindPCAP.cmake just does not take PCAP_HINTS and most likely with cmake that's because it has already

Re: [Wireshark-dev] macOS dark mode in 3.0.0

2019-03-21 Thread Roland Knall
Ok, upon further investigation, my comment may not be entirely accurate, it appears that you need to build also with the macOs 10.14+ SDK to enable the dark mode (see

Re: [Wireshark-dev] macOS dark mode in 3.0.0

2019-03-21 Thread Roland Knall
Dark mode is still something that does not work very well together with Qt. As there is still a lot to do for us, it has been deactivated and cannot be activated by an user setting. Probably something that should be implemented for 3.1 at least. Sorry for the inconvenience. kind regards Roland

Re: [Wireshark-dev] Wireshark hosts file location

2019-03-21 Thread Roland Knall
No, currently Wireshark does not switch hosts files with the profiles (to be quite honest, wasn't even aware, that we support something like using non-system hosts files at all). Currently I am in the middle of rewriting the profile system and can put this on the todo list. Could you describe the

Re: [Wireshark-dev] Release lifetime and version number changes?

2019-04-12 Thread Roland Knall
Just my two cents, I like a clear indication, that I am working with a development version beyond the obvious changes of text. SO the versioning is usually the first thing I look at. That being said, I could imagine adopting the Python versioning scheme as an alternative to the current even/odd

Re: [Wireshark-dev] Release lifetime and version number changes?

2019-04-12 Thread Roland Knall
minor correction, it should not read "sullify" but pacify. It has been a long week Am Fr., 12. Apr. 2019 um 15:01 Uhr schrieb Roland Knall : > Just my two cents, I like a clear indication, that I am working with a > development version beyond the obvious changes of text. S

Re: [Wireshark-dev] Script extcap on macOS

2019-04-18 Thread Roland Knall
in itself faces an issue. Shell scripts should work fine btw in any case. cheers Roland Am Do., 18. Apr. 2019 um 12:20 Uhr schrieb Dario Lombardo : > > > On Fri, Apr 12, 2019 at 10:32 PM Guy Harris wrote: > >> On Apr 12, 2019, at 1:22 PM, Roland Knall wrote: >> >

Re: [Wireshark-dev] CMake Error [CMAKE_MAKE_PROGRAM is not set] while building wireshark from source

2019-04-18 Thread Roland Knall
You should not need to install make. This is most likely one of two things: 1. you have not installed ninja at all. Please see if it is installed and accessible via our path, by executing "ninja " in a commandline window. If it is not installed, the package for Debian/Ubuntu/Mint is called

Re: [Wireshark-dev] Script extcap on macOS

2019-04-12 Thread Roland Knall
There seems to be an issue on mac, depending how the original Wireshark binary has been called. It seems to be, that by clicking on the icon, the system python interpreter get's loaded, which most certainly will let your script fail. If you call Wireshark from a console context (by either

Re: [Wireshark-dev] IDE for C development on Linux

2019-06-03 Thread Roland Knall
Also, for development Qt Creator works very well with Wireshark, if you open he CMakeFile.txt as a project Cheers > Am 03.06.2019 um 17:44 schrieb Pascal Quantin : > > Hi Paul, > >> Le lun. 3 juin 2019 à 17:41, Paul Offord a écrit : >> Hi, >> >> >> >> I want to learn a bit more about

[Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

2019-06-14 Thread Roland Knall
Hi There is a patch currently waiting for inclusion. It would allow for dissectors to easily make credentials (username/password) available and present them in a tool window in Wireshark. The main concern here is, that this could lead companies, evaluating Wireshark to be used within the

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

2019-06-16 Thread Roland Knall
You can separate both. The dissectors tap can stay in there, and the UI can be implemented using the plugin_if interface, which allows for graphical UI plugins, that can receive tap data as well as any other data. It would work exactly as Guy had suggested it. cheers Am So., 16. Juni 2019 um

[Wireshark-dev] Question about zip support

2019-07-10 Thread Roland Knall
I am currently implementing import/export of profiles. As easy as the collection of the required information is, it becomes harder when it comes to zipping it. My initial intention was to just create a .zip container and use that. But it turns out zlib does not support .zip, as it only supports

Re: [Wireshark-dev] Glitches in UI when using recent buildbot development versions

2019-06-29 Thread Roland Knall
Could you post your Qt version? You will find it in the about dialog. > Am 29.06.2019 um 17:44 schrieb Ivan Nardi : > > Hi > >> On Fri, 28 Jun 2019 at 18:12, Jim Young wrote: >> >> The first glitch has to do with "Apply as filter". With this glitch I had >> right-mouse selected the

Re: [Wireshark-dev] Disabling idle sleep while a capture is in progress?

2019-07-02 Thread Roland Knall
Is there a possibility on Windows to avoid sleep and restarts altogether? Must be, otherwise video apps would have issues, but that could be connected to the drivers right? Roland > Am 02.07.2019 um 08:21 schrieb Tomasz Moń : > >> On Mon, Jul 1, 2019 at 11:44 PM Guy Harris wrote: >> If

Re: [Wireshark-dev] Glitches in UI when using recent buildbot development versions

2019-06-29 Thread Roland Knall
Hi I cannot confirm those glitches on macOS. Especially the second one seems very strange to me. At this point I think it would be best if you add a bug report. If you are running the most recent macOS (Mojave), you could also create a video very easily (cmd+shift+5 for the builtin screen

Re: [Wireshark-dev] German translation issues

2019-08-10 Thread Roland Knall
Hi The backport will happen on Sunday in an automated fashion. I will have to take a look why it may not include some items. There are two reasons why translations are not effective. The first being text entries, which are declared either by dissectors or inside epan. The main reason why the

Re: [Wireshark-dev] Add a "diagnostic information" menu item and command-line option?

2019-08-11 Thread Roland Knall
We currently dump the help info, for the bug reports. Do you mean a button on that page or an extra option in a similar context? Regards Roland > Am 11.08.2019 um 03:34 schrieb Guy Harris : > > Sometimes we get "why can't I see my {LAN,Ethernet,Wi-Fi}?" questions on > ask.wireshark.com. > >

Re: [Wireshark-dev] Add a "diagnostic information" menu item and command-line option?

2019-08-11 Thread Roland Knall
See https://code.wireshark.org/review/c/34231/ for a quick draft Am So., 11. Aug. 2019 um 08:05 Uhr schrieb Roland Knall : > We currently dump the help info, for the bug reports. Do you mean a button > on that page or an extra option in a similar context? > > Regards Roland > &g

[Wireshark-dev] Usability question for Wireshark 3.x

2019-08-27 Thread Roland Knall
Hi I have a short question. While refactoring the Apply/Prepare menu (due to quite a few issues with enabling/disabling), I stumbled across the items "Copy as Filter", "Expand subtree", "Collapse subtree", and similar items. I am wondering, if it makes sense to have those in the main menubar.

Re: [Wireshark-dev] Usability question for Wireshark 3.x

2019-08-27 Thread Roland Knall
That I would actually prefer. Those items could be hidden, but especially activated when the context makes sense for it. The current situation is unsatisfactory for new users Am Di., 27. Aug. 2019 um 22:45 Uhr schrieb Guy Harris : > On Aug 27, 2019, at 1:14 PM, Roland Knall wrote: > >

[Wireshark-dev] Qt issue with first section not movable

2019-09-03 Thread Roland Knall
Hi Those of you build Wireshark yourself or using a pre-distributed version of Wireshark with Qt >= 5.11 might run into this issue: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15879 In short, Qt changed the default behavior for the first column, and it therefore cannot be moved anymore,

Re: [Wireshark-dev] Qt issue with first section not movable

2019-09-03 Thread Roland Knall
After some research, I've added the simple patchset: https://code.wireshark.org/review/c/34445/ Sideeffects should not occur, the changes since then in qtbase have been minimal in that area. Am Di., 3. Sept. 2019 um 21:00 Uhr schrieb Roland Knall : > Then I will try to figure out how to

Re: [Wireshark-dev] Qt issue with first section not movable

2019-09-03 Thread Roland Knall
< pas...@wireshark.org>: > Hi Roland, > > Le mar. 3 sept. 2019 à 17:39, Roland Knall a écrit : > >> Hi >> >> Those of you build Wireshark yourself or using a pre-distributed version >> of Wireshark with Qt >= 5.11 might run into this issue: >>

Re: [Wireshark-dev] Qt issue with first section not movable

2019-09-03 Thread Roland Knall
Then I will try to figure out how to do it properly. cheers Roland Am Di., 3. Sept. 2019 um 20:37 Uhr schrieb Stig Bjørlykke < s...@bjorlykke.org>: > Hi, > > If we don’t enforce the first column to always be a Number column then I >> would consider this as a bug. >> > > It’s possible to change

[Wireshark-dev] Building with VStudio 2019 not possible

2019-08-21 Thread Roland Knall
Hi Building with the community edition gives you currently: cl : Befehlszeile error D8016 : Die Befehlszeilenoptionen /ZI und /guard:cf sind inkompatibel. C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(429 ,5): error MSB6006:

Re: [Wireshark-dev] Building with VStudio 2019 not possible

2019-08-21 Thread Roland Knall
s > > > > *From:* Wireshark-dev *On Behalf Of > *Roland Knall > *Sent:* den 21 augusti 2019 12:54 > *To:* Developer support list for Wireshark > *Subject:* Re: [Wireshark-dev] Building with VStudio 2019 not possible > > > > Yes to both. CMake was installed using ch

Re: [Wireshark-dev] Building with VStudio 2019 not possible

2019-08-21 Thread Roland Knall
> > Anders > > > > *From:* Wireshark-dev *On Behalf Of > *Roland Knall > *Sent:* den 21 augusti 2019 10:37 > *To:* Developer support list for Wireshark > *Subject:* [Wireshark-dev] Building with VStudio 2019 not possible > > > > Hi > > > > Bu

Re: [Wireshark-dev] Wireshark Windows libraries

2019-09-05 Thread Roland Knall
I would second waiting for 5.12.5. Waiting for 13th is a little bit too much superstition for me though ;-) 5.12.5 fixes some issues we have with the UI Regards Roland > Am 06.09.2019 um 07:43 schrieb Pascal Quantin : > > Hi Jaap, > >> Le ven. 6 sept. 2019 à 07:36, Jaap Keuter a écrit : >>

[Wireshark-dev] Unittesting the Qt UI

2019-08-05 Thread Roland Knall
Hi I am currently building unittests to ensure, that the ProfileModel implementation does not change functionality. Also, in the future, I want to implement coverage to help further sanitize code. I am at loss though on how to integrate my tests in our test framework. Currently I've created a

[Wireshark-dev] German translation issues

2019-08-08 Thread Roland Knall
Hi There are some german translation issues with the git version. As Transifex does not allow me to be added to the german language I hope this is the right place to forward this to. Namely I found two issues so far: ", %Ln profile(s) skipped" has been translated with "%1" instead of "%Ln"

Re: [Wireshark-dev] Where is the AirPcap channel button?

2019-07-26 Thread Roland Knall
Could you please create a bug report on https://bugs.wireshark.org/bugzilla/ In which version does it still work? kind regards Roland Am Fr., 26. Juli 2019 um 11:46 Uhr schrieb Gisle Vanem < gisle.va...@gmail.com>: > Hi list. > > I remember wireshark-qt in the old days had a button > to change

Re: [Wireshark-dev] Wireshark review to release

2019-09-20 Thread Roland Knall
Hi Changes to master (which would happen the past months) will result in the code being in 3.2 (about to be released beginning next year). 3.0.x will just receive bugfix release kind regards Roland Am Fr., 20. Sept. 2019 um 21:56 Uhr schrieb Crawford, Anthony R <

Re: [Wireshark-dev] Warnings from Qt

2019-11-04 Thread Roland Knall
There is already work being done to address this Am Mo., 4. Nov. 2019 um 15:32 Uhr schrieb Pascal Quantin < pas...@wireshark.org>: > > > Le lun. 4 nov. 2019 à 16:27, Joakim Karlsson a écrit : > >> And I getting some other warnings: >> >> 16:21:36.990 Main Warn CaptureEvent [ 2 ]: 1 >>

Re: [Wireshark-dev] Wireshark 3.1.0 No filter available, try another column

2019-11-07 Thread Roland Knall
Running latest master or dev-build, this error can no longer be reproduced, as that part of the code has been extensively rewritten. Therefore, please either wait for the next 3.1.x RC or upgrade to a nightly build. kind regards Roland Am Do., 7. Nov. 2019 um 08:17 Uhr schrieb Richard Sharpe <

Re: [Wireshark-dev] Problems building under Windows 10

2019-11-12 Thread Roland Knall
Do you execute canoe from a Visual Studio Commandprompt? I recently tried it and it works fine. Cheers > Am 13.11.2019 um 02:52 schrieb Richard Sharpe : > > Hi folks, > > I think I have followed the instructions at > https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html > > I

Re: [Wireshark-dev] Problems building under Windows 10

2019-11-13 Thread Roland Knall
Oh, autospell is such a nice feature ;-) I just tested it on a VM, it works as it should Am Mi., 13. Nov. 2019 um 08:43 Uhr schrieb Graham Bloice < graham.blo...@trihedral.com>: > > > On Wed, 13 Nov 2019 at 07:01, Roland Knall wrote: > >> Do you execute canoe from a Vis

Re: [Wireshark-dev] Wireshark for Mac 10.14.5

2019-12-13 Thread Roland Knall
You can also install the release candidate for 3.2, which has a dmg > Am 14.12.2019 um 01:44 schrieb Guy Harris : > > On Dec 13, 2019, at 9:10 AM, Pooja Vijay via Wireshark-dev > wrote: > >> I am trying to install Wireshark for Mac OS version 10.14.5 but I don’t see >> .dmg file anywhere.

Re: [Wireshark-dev] 3.1.1 and 3.2.0 release schedule

2019-11-19 Thread Roland Knall
In this case, the change has to happen in docbook/release_notes.adoc. I will update them accordingly, so it appears amended for 3.2. Am Di., 19. Nov. 2019 um 18:40 Uhr schrieb Tomasz Moń : > On Tue, Nov 19, 2019 at 4:53 PM chuck c wrote: > > And in the still learning to crawl before walk/run,

Re: [Wireshark-dev] Visual studio 2019 from choco

2019-11-26 Thread Roland Knall
@Dario - I am currently rewriting that section anyway, I'll drop you the patchset as soon as it is uploaded. Am Di., 26. Nov. 2019 um 15:29 Uhr schrieb Dario Lombardo : > I'm chatting with choco maintainers right now. They say it sounds like a > fresh win10 install will fail with dotnetfx

Re: [Wireshark-dev] Missing dumpcap when building 3.1.1

2019-11-29 Thread Roland Knall
Please take a look at https://wiki.wireshark.org/CaptureSetup/CapturePrivileges to resolve the issue Am Fr., 29. Nov. 2019 um 15:56 Uhr schrieb Tom Bentley < t.j.bent...@gmail.com>: > Great, that worked and I can now capture, but only when running wireshark > under sudo. I tried things like

Re: [Wireshark-dev] Any solutions to problems running QT-Based Wireshark on CentOS 7.5

2019-09-20 Thread Roland Knall
Which version of Qt are you running? > Am 20.09.2019 um 17:36 schrieb Richard Sharpe : > > Hi folks, > > I can build Wireshark fine on CentOS 7.5 using cmake3 (from EPEL) > however, I suspect I have the wrong set of libraries installed because > it does not respond the way I expect. > >

Re: [Wireshark-dev] QtCustomPlot: New Defects reported by Coverity Scan for Wireshark

2019-09-25 Thread Roland Knall
Hi Jaap I was in contact with the original developer of QCustomPlot. According to his statement, this warning is a false-positive, as it cannot occur with real numbers. FYI, he will create a version 2.0.2 or 2.2.x depending on the changes, sometime by the end of this year, beginning of next. We

Re: [Wireshark-dev] Migrate to GitLab?

2019-10-08 Thread Roland Knall
TL;DR - yes - no - somewhat Long version: 1. If you push to GitLab and do it the right way, you create a merge request, which allows you to ammend the change as many times as you want, similar to the method with patchsets in Gerrit. 2. This will not cause merge commits if done properly. 3. Here

Re: [Wireshark-dev] Migrate to GitLab?

2019-10-08 Thread Roland Knall
Am Di., 8. Okt. 2019 um 10:47 Uhr schrieb Guy Harris : > > And can I then do a "git commit --amend" and another "git push origin > HEAD:feature-number-1" to fix issues found in the review/Petri dish/going > back and looking at what I did process? > > And I'm still on the master branch there, so a

Re: [Wireshark-dev] Migrate to GitLab?

2019-10-12 Thread Roland Knall
tl;dr - I am also -2 on merge commits, not entirely sure about ff either, they tend to be work, cherry-pick would be preferable. Long version: Currently we do have a strategy in place, that is called "Cherry-Pick". Basically it means, that Gerrit resolves any branch conflicts (the patch had been

Re: [Wireshark-dev] Migrate to GitLab?

2019-10-12 Thread Roland Knall
Addendum - my initial tl;dr is misleading - I don't like FF because it is extra work, but I definitely prefer it if cherry-picking (as it is applied now) is not an option with gitlab (never looked that up properly). merge is a -2 in any case Am Sa., 12. Okt. 2019 um 12:48 Uhr schrieb Roland Knall

Re: [Wireshark-dev] Extcap binaries on OSX

2019-12-20 Thread Roland Knall
run/Wireshark.app/Contents/MacOS/extcap cheers Roland Am Fr., 20. Dez. 2019 um 10:31 Uhr schrieb Dario Lombardo : > Hi, > I'm trying to debug some CI jobs on OSX but I don't have a OSX machine. > I'm trying to find where the extcap binaries are put on OSX using cmake. > > Linux: run\extcap >

Re: [Wireshark-dev] Remote fieldbus capture "protocol"

2020-01-26 Thread Roland Knall
I’ve implemented similar using either udp or serial, using extcap in both cases. You can take a look at udpdump but in my case I wrote it myself using a python extcap on the receiving end. The idea is, that you put all information (including the timing of your original protocol) into a frame,

Re: [Wireshark-dev] Qt availability changes

2020-01-27 Thread Roland Knall
Well it took me a while to read through all the comments. First of all, I understand their - Qt's - reasoning. It makes sense from a business side of things, and they are getting rather big. Developing that framework is not the easiest task and they need money (sounds too familiar). This sucks,

Re: [Wireshark-dev] Qt availability changes

2020-01-30 Thread Roland Knall
> Am 30.01.2020 um 15:56 schrieb João Valverde > : > >  > >> On 28/01/20 13:30, Roland Knall wrote: >> A good overview by one of the KDE developers, focussing - obviously - on the >> Linux side: >> >> https://tsdgeos.blogspot.com/2020/01/the-qt

Re: [Wireshark-dev] Qt availability changes

2020-01-28 Thread Roland Knall
Am Di., 28. Jan. 2020 um 01:43 Uhr schrieb Peter Wu : > > > I think it is worth emphasizing that it only affects users who build or > develop Wireshark from source. The final Wireshark installer will still > bundle the Qt bits. > We need to get those bundles from somewhere, meaning we either

Re: [Wireshark-dev] Qt availability changes

2020-01-28 Thread Roland Knall
A good overview by one of the KDE developers, focussing - obviously - on the Linux side: https://tsdgeos.blogspot.com/2020/01/the-qt-company-is-stopping-qt-lts.html Long story short - we may have to host our own version at some point. Am Di., 28. Jan. 2020 um 12:44 Uhr schrieb Roland Knall

Re: [Wireshark-dev] Support Opus in WireShark

2020-01-20 Thread Roland Knall
I can provide some examples if needed, of exactly that. Either multiple OPUS streams, or traces which contain opus and G.711 in the same conversation. Just tell me, if you need a new bug-entry created or have an existing one to attach to. kind regards Roland Am Mo., 20. Jan. 2020 um 12:30 Uhr

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread Roland Knall
The way here would be to push your patch to gerrit. iLBC seems to be distributed (at least the codec as part of the WebRTC project) with a BSD-Style license, so integration should be doable. Please also check, beside tools/debian-setup.sh there are scripts in there for other Linux distributions as

Re: [Wireshark-dev] Regenerating moc files

2020-03-27 Thread Roland Knall
moc Files are run, if their accompanying .cpp File changed. I am not aware of a cmake command to run it forcefully, but you can always run “touch” on the wronged file. Cheers > Am 27.03.2020 um 19:17 schrieb Dario Lombardo : > >  > Hi, > is there a cmake target to unconditionally

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Roland Knall
Feel free to give it a go > Am 24.04.2020 um 15:29 schrieb Lori Jakab : > >  > Hi, > > I'm have been building on macOS Mojave for a while without issues, but for > the last few days the build has been broken. I didn't try a git dissect yet > to see which commit broke it, but the issue seems

[Wireshark-dev] Display Filter Folders - a question to vote

2020-04-21 Thread Roland Knall
Hi We have a new feature in Wireshark, where you can sort display filters into subfolders. See https://twitter.com/bubbasnmp/status/1252627399201742848 for an example use case. The current implementation requires the name of the folder to be part of the filter name, so in the case of the picture

Re: [Wireshark-dev] Apple VM for Gui testing

2020-10-08 Thread Roland Knall
Hi It is against Apples EULA, to run Apple operating systems on non-apple hardware. An exemption had been made for running it on virtualized environments, if they themselve run on Apple hardware. So legally it is not allowed to do so. cheers Roland Am Do., 8. Okt. 2020 um 04:34 Uhr schrieb

Re: [Wireshark-dev] GitLab migration update

2020-08-26 Thread Roland Knall
Peter posted the instructions somewhere for that (either on the main wiki, or the main project). Have to look it up. Basically you have to remove the association of your fork with the "old" version, and then reset it. cheers Am Di., 25. Aug. 2020 um 23:01 Uhr schrieb Dario Lombardo : > > > On

Re: [Wireshark-dev] The QT-5.15 disaster and an issue with multi-monitor setups, Windows and Wireshark

2020-08-28 Thread Roland Knall
Can’t skip, it is the base for Qt 6. Btw, cannot reproduce this on my system, Ubuntu 20 LTS. Have to investigate if this is KDE related though, running Cinnamon over here Cheers > Am 28.08.2020 um 21:03 schrieb Richard Sharpe : > > Hi folks, > > I just came across this article: > >

Re: [Wireshark-dev] [Wireshark-users] GitLab migration update

2020-08-24 Thread Roland Knall
> Am 24.08.2020 um 08:50 schrieb Guy Harris : > > On Aug 23, 2020, at 10:42 PM, Gerald Combs wrote: > >>> On 8/23/20 9:59 PM, Guy Harris wrote: On Aug 23, 2020, at 9:33 PM, Gerald Combs wrote: >>> You can still comment on Gerrit changes, but it should otherwise be

Re: [Wireshark-dev] Plugin GUI menu and selected packet

2020-07-19 Thread Roland Knall
It's tricky. Due to the plugin being in a different execution context from the main application, a direct connection cannot be made. It would have to be a callback, similar then the ones from the plugin to select a certain packet. Those have not yet been implemented. Even if they were, you would

Re: [Wireshark-dev] Why tvb_get_bits() assumes Big Endian?

2020-07-30 Thread Roland Knall
Putting the complexity in the common code will increase the complexity for a lot of other stuff which relies on this functionality. Also you run the risk of increasing dissection time for more protocols, then if you handle it specifically. That would be my reasoning against it cheers Am Do.,

Re: [Wireshark-dev] [Wireshark-users] The Wireshark wiki has a new home

2020-08-12 Thread Roland Knall
I agree that this is not ideal. I would opt for a second project. MoinMoin is really not good anymore from an op-sec point of view Cheers Roland > Am 12.08.2020 um 21:18 schrieb Gerald Combs : > > On 8/12/20 7:51 AM, Maynard, Chris via Wireshark-users wrote: >>> -Original Message- >>>

Re: [Wireshark-dev] Tie code change to release version

2020-06-18 Thread Roland Knall
What you can do on the command-line is the following: git log origin/master-2.4 | grep 'extcap: set help' this will give you an indication, if the patch was in 2.4 (for instance here). Coincidentally this is actually the version this patch was first released in. kind regards Roland Am Do.,

Re: [Wireshark-dev] QT installation

2020-12-03 Thread Roland Knall
There are two licenses available for Qt. A commercial one and an open-source one. If your company already has registered for commercial licenses, you will not be able to register for the open-source licence with your company email address. In that case you still have the option to register your

Re: [Wireshark-dev] Apple M1 transition for Wireshark build process

2020-11-28 Thread Roland Knall
There are a few issues with M1 still: A. Not all supporting libraries can be compiled, especially brew supplied libraries vary deeply. B. Rosetta and native are nearly par performance wise. C. Universal binaries would require a real hassle, so I actually would prefer target-specific ones In

Re: [Wireshark-dev] About i18n Translation

2020-11-19 Thread Roland Knall
We currently have no system in place that would allow you to translate any texts coming from dissectors or anywhere out of epan for that matter Kind regards > Am 19.11.2020 um 14:54 schrieb qiangxiong.huang : > > HI, I have two questions about wireshark i18n: > > 1. Are the files *.po in

Re: [Wireshark-dev] New Protocol encapsulation as plugin

2021-01-27 Thread Roland Knall
i need to > dissect a first level protocol and couldn't open the file to dissect. But i > think, as mentioned by John Thacker, to use the USER_DLT will take function. > > Best regards, > > Björn > > > > Am 27.01.21 um 12:30 schrieb Roland Knall: >> Hi B

Re: [Wireshark-dev] Having trouble cloning repo in a new VM

2021-05-19 Thread Roland Knall
You can try to just capture a single depth (--depth 1) and see if this works regards Roland Am Mi., 19. Mai 2021 um 15:54 Uhr schrieb Martin Mathieson via Wireshark-dev : > I did take a capture. All I see is a FIN,ACK from the server, after which > it sent another couple of ACKs. > There are

Re: [Wireshark-dev] Custom item not related to the packet

2021-05-26 Thread Roland Knall
The data displayed in the subitem is the one from pt, your data variable which you used to create the new tvb. The hf_item seems to point to a different data structure. How is pt being generated? Are you using the same length and start offset as for the hf item? regards Roland Am Mi., 26. Mai

Re: [Wireshark-dev] Custom item not related to the packet

2021-05-26 Thread Roland Knall
no mer 26 mag 2021 alle ore 14:32 Roland Knall > ha scritto: > >> The data displayed in the subitem is the one from pt, your data variable >> which you used to create the new tvb. The hf_item seems to point to a >> different data structure. How is pt being generated? Are yo

Re: [Wireshark-dev] Getting captured interface name inside plugin

2021-06-07 Thread Roland Knall
Also are you running the same protocol on all the different buses, or has each bus its own distinctive protocol? cheers Roland Am Mo., 7. Juni 2021 um 02:58 Uhr schrieb Guy Harris : > On Jun 6, 2021, at 5:41 PM, Jan Mall wrote: > > > The ultimate goal is an automotive dissector, which takes

Re: [Wireshark-dev] Status label for issues

2021-04-26 Thread Roland Knall
I somewhat feel a little bit more sceptical of increasing the numbers of labels. They would require discipline before being enforceable. Also, we would need some form of documentation to allow a lookup what each label is supposed to be and what eventual escalation procedures would be. I suggest

Re: [Wireshark-dev] Status label for issues

2021-04-26 Thread Roland Knall
on the list cheers Roladn Am Mo., 26. Apr. 2021 um 21:17 Uhr schrieb Uli Heilmeier : > > > Am 26.04.21 um 11:49 schrieb Roland Knall: > > > > I suggest we create a wiki page for that discussion first, and if we can > figure that out create the labels. > > > &g

Re: [Wireshark-dev] Status label for issues

2021-04-27 Thread Roland Knall
about the os::* labels. We can reduce them to > os::mac, os::windows, os::linux, os::unix. > > > Am 26.04.21 um 23:13 schrieb Roland Knall: > > The list seems to be duplicated with the lists from above. Anyhow, it > seems we just have too many labels already, and I > > am still

Re: [Wireshark-dev] How to disable QT_MULTIMEDIA_LIB during cmake

2021-04-28 Thread Roland Knall
I have created a change which handles the CMAKE stuff correctly (analog to extcap & pcap, ...) I would need some help from you Jirka for the RTP specifics. kind regards Roland Am Mi., 28. Apr. 2021 um 14:01 Uhr schrieb John Thacker < johnthac...@gmail.com>: > In general some features can be

Re: [Wireshark-dev] How to disable QT_MULTIMEDIA_LIB during cmake

2021-04-28 Thread Roland Knall
A merge request has been generated for this: https://gitlab.com/wireshark/wireshark/-/merge_requests/2849 cheers Am Mi., 28. Apr. 2021 um 14:33 Uhr schrieb Roland Knall : > I have created a change which handles the CMAKE stuff correctly (analog to > extcap & pcap, ...) > > I

Re: [Wireshark-dev] Wireshark 3.4.5 is now available

2021-04-25 Thread Roland Knall
Normally it is a cut-off date. Exceptions are only made for bigger bug-fixes and security fixes > Am 25.04.2021 um 09:37 schrieb Constantine Gavrilov : > > A quick question. I have been working on nvme dissector and I see that some > changes from dev tree are in and some are left out. > >

Re: [Wireshark-dev] New Protocol encapsulation as plugin

2021-01-27 Thread Roland Knall
Hi Björn I realized something similar by implementing a tap interface in the original protocol and a UI using a similar code as in the plugin “pluginifdemo” Would it be possible to go that route? Regards, Roland > Am 27.01.2021 um 12:17 schrieb Björn > : > >  > Hi, > > we use a custom

Re: [Wireshark-dev] File formats that extcap programs can write

2021-03-21 Thread Roland Knall
While correct as an answer, the main Limitation here is dumpcap. You would have to implement a mechanism to let dumpcap know which format to use for the internal pipe to the extcap interrace. DLT could be that. Pcapng has been on the wishlist for a very long time as a format Kind regards

Re: [Wireshark-dev] remote interfaces issues

2021-09-02 Thread Roland Knall
I‘ll take a look at it. From a first glance it could be better suited to change the model instead of the browser window Cheers > Am 02.09.2021 um 10:14 schrieb Ramin Moussavi : > >  > hello > > i made a merge request to fix the remote interface settings window > >

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Roland Knall
Hi Ivan We have a limited number of machines for our build-jobs. Therefore only when we set the merge-request to a semi-done level, buildjobs are triggered. What you can do though, is run your own pipeline, and use our .gitlab-ci.yml file as a template. At this point we do not plan on making the

Re: [Wireshark-dev] Byte view mouse hover behaviour

2021-09-13 Thread Roland Knall
Looks to me that we actually have an inconsistency in behavior. If you click on a byte, the underlying field gets selected in the byteview as well as packetdetail pane and stays selected, until you click someplace else. If you do the same the other way around, it does not work, as the selection is

Re: [Wireshark-dev] Byte view mouse hover behaviour

2021-09-13 Thread Roland Knall
See https://gitlab.com/wireshark/wireshark/-/merge_requests/4178 for the functionality change Am Mo., 13. Sept. 2021 um 11:37 Uhr schrieb Roland Knall : > Looks to me that we actually have an inconsistency in behavior. If you > click on a byte, the underlying field gets selected in the by

Re: [Wireshark-dev] Insecure.Com LLC -> Nmap Software LLC

2021-12-19 Thread Roland Knall
Personally, I would keep it as it is, unless they explicitly ask for it Am So., 19. Dez. 2021 um 19:39 Uhr schrieb chuck c : > Is it ok to update the name where it appears in the docs and AUTHORS or is > the agreement with the old entity? > > >

Re: [Wireshark-dev] How to stop extcap gracefully

2021-11-27 Thread Roland Knall
Due to the nature of extcaps, they are not explicitly closed. Instead, you should monitor the created pipes. Dumpcap closes those pipes when the capture has finished. We do send them a kill signal, but due to the nature of the signal handling, this signal may be missed. The sure fire way is, if

Re: [Wireshark-dev] How to stop extcap gracefully

2021-11-27 Thread Roland Knall
In the case of ciscodump, there is no closing on the extcap side. Basically it reads packets indefinitely in ssh_loop_read, until you either have a read error on the channel, or you got the end packet. You would need to add another exit condition to the do..while loop there. extcap programs work

Re: [Wireshark-dev] How to troubleshoot extcap applications?

2021-12-01 Thread Roland Knall
Could we additionally add a note to README.extcap? Just in case, some external extcap tools sumble across this as well? Also, one more thing, have you tested with tshark only or also using qt? Qt in general redirects all std... pipes, which should not matter as we are started through dumpcap.

Re: [Wireshark-dev] Parameters for extcap

2021-11-30 Thread Roland Knall
Both issues where done so by design. For the password, there was a reasonable concern, that passwords may be read-out. Now, you could argue, that monitoring the cumpcap call gives you the password anyway, which is correct. The intended usecase originally was to use the password together with ssh,

Re: [Wireshark-dev] Extcap Rust library

2021-11-30 Thread Roland Knall
That is great. Would you mind sending a pull request mentioning the library in README.extcap? Currently we only provide the python example, and this is by design. But we should at least mention other implementations in the documentation. regards Roland Am Di., 30. Nov. 2021 um 07:28 Uhr schrieb

Re: [Wireshark-dev] Visual Studio 2022

2022-01-15 Thread Roland Knall
One of the main features I would be looking at was better arm64 support. Right now compiling a native Wireshark version for Windows arm64 is a nightmare The compilers can do it, the tool chain can’t really > Am 15.01.2022 um 12:09 schrieb Gisle Vanem : > > Anders Broman wrote: > >> Hi, >>

Re: [Wireshark-dev] Visual Studio 2022

2022-01-15 Thread Roland Knall
Its the later. Am Sa., 15. Jan. 2022 um 13:38 Uhr schrieb Guy Harris : > On Jan 15, 2022, at 3:09 AM, Gisle Vanem wrote: > > > Anders Broman wrote: > > > >> Hi, > >> Yes sounds like a good idea. Have been contemplating testing it too. > > > > I just installed the "Build Tools for Visual Studio

Re: [Wireshark-dev] Editor config and code formatting

2022-03-01 Thread Roland Knall
Policy always was and has been, that we try to achieve consistent guidelines for new files and in general the guidelines for each file should be reflecting that files style. Although I do appreciate applying consistent styles, I acknowledge the fact that we have a really old code base in some

Re: [Wireshark-dev] PCAP-over-IP in Wireshark?

2022-01-31 Thread Roland Knall
olarProxy to > STDOUT and piped that into Wireshark with "-i -". This integration works, > but it's not how I prefer to read packets with Wireshark and it's not a > viable option if PolarProxy and Wireshark are running on different machines. > > /erik > > > Den mån 31 j

Re: [Wireshark-dev] PCAP-over-IP in Wireshark?

2022-01-31 Thread Roland Knall
If udpdump is nothing for you, and you are able to run a capture tool like tshark or tcpdump on the remote machine, you can take a look at sshdump. A sibling of udpdump, it executes the remote capture program via ssh, and then transports the data as-is through a ssh-connection. It can be seen as a

Re: [Wireshark-dev] PCAP-over-IP in Wireshark?

2022-02-01 Thread Roland Knall
Guy already has updated the documentation yesterday and today a bit on the commandline. But the online manuals could be updated Am Di., 1. Feb. 2022 um 13:15 Uhr schrieb Jaap Keuter : > Hi, > > Cool that this works as intended / expected. > All that is left now, as Guy indicated, is to document

Re: [Wireshark-dev] MSVC gives warnings "qt_ui_utils.cpp(208, 25): warning C4996: 'QProcess::startDetached'"

2022-02-11 Thread Roland Knall
Which Qt version are you on? Am Fr., 11. Feb. 2022 um 11:06 Uhr schrieb Anders Broman via Wireshark-dev < wireshark-dev@wireshark.org>: > Hi, > > Just built and got the following warning: > > > > ..\ui\qt\utils\qt_ui_utils.cpp(208,25): warning C4996: > 'QProcess::startDetached': Use

<    1   2   3   4   5   >