Hi,
I think these two assertions, in packet_list_compare_records()
g_assert(a-fdata-col_text[sort_id]);
g_assert(b-fdata-col_text[sort_id]);
are not quite correct.
If you click abort while constructing columns, it'll lead to:
Anders Broman wrote:
I don't think we can/should turn off canaries in se_ allocations.
Instead we should create a new canary-less allocator. (Not sure what
such a thing should
be named, of course...)
Well as I see it EP memory is not a problem we only use one chunk (10M)
During the life
-Ursprungligt meddelande-
Från: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] För Jeff Morriss
Skickat: den 9 oktober 2009 22:06
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list - out of memory?
Anders Broman wrote
Le mercredi 07 octobre 2009 à 17:01 +0200, Anders Broman a écrit :
Hi,
If some one's interested here's the emem statistics for the file:
#define EMEM_ALLOCS_PER_CHUNK (EMEM_PACKET_CHUNK_SIZE / 64)
PWS Commit
43 49264 512
332 052 471 116
oktober 2009 09:34
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] New packet list - out of memory?
Le mercredi 07 octobre 2009 à 17:01 +0200, Anders Broman a écrit :
Hi,
If some one's interested here's the emem statistics for the file:
#define EMEM_ALLOCS_PER_CHUNK
didier wrote:
But are canaries used at all? In my understanding without
DEBUG_INTENSE_CANARY_CHECKS they are never checked and it's unset by
default.
Erm, emem_free_all() checks that the canaries haven't been corrupted:
if (memcmp(npc-canary_info-canary[i], canary,
-Original Message-
From: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Jeff Morriss
Sent: den 8 oktober 2009 15:58
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] New packet list - out of memory?
didier wrote
Anders Broman wrote:
Well as I see it EP memory is not a problem we only use one chunk (10M)
During the life time of a packet so memory efficency isn't a big issue.
But when dealing with large files waisting +30% of the memory is not an
option I think.
A way to still test se_alloc() could
Hi,
Le jeudi 08 octobre 2009 à 09:58 -0400, Jeff Morriss a écrit :
didier wrote:
But are canaries used at all? In my understanding without
DEBUG_INTENSE_CANARY_CHECKS they are never checked and it's unset by
default.
Erm, emem_free_all() checks that the canaries haven't been corrupted:
Gerald Combs wrote:
We could add a preference item which lets the user disable SE
canaries.
Maybe a slider with fast on one end and safe on the other, just to
let them know what they're getting into. :)
Not knowing the extent of the :) above, it is worth pointing out that
users are not
Hi,
Le mercredi 07 octobre 2009 à 13:59 +0200, Anders Broman a écrit :
Didier
More or less vanilla Wireshark, no colors. Enclosed proto Hierarchy. I can't
share this file unfortunatly. The reason why I chose it is just that it
caused 'Out of memmory' with the new packet list.
Thanks, Are you
-Ursprungligt meddelande-
Från: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] För didier
Skickat: den 9 oktober 2009 03:45
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list - out of memory?
Hi,
Le mercredi 07 octobre
-Original Message-
From: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Bill Meier
Sent: den 6 oktober 2009 00:49
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] New packet list - out of memory?
Bill Meier wrote
Anders Broman wrote:
Should we have a new allocator without the canaries?
I think either the current se_ allocations implementation need to be changed
Or the function removed. The result where WIRESHARK_DEBUG_SE_NO_CHUNKS=T
And loading is faster is puzzling.
Trying that on Linux (64-bit) with
Le mardi 06 octobre 2009 à 12:05 +0200, Anders Broman a écrit :
146 MB 661417 pkts (TCP reassembly)
Version 1.2.2 (SVN Rev 29910)
PWS Commit
42 01661 876
704 656 1 639 256
Loading time ~57s
Old packet list SVN 30353
PWS
Le mardi 06 octobre 2009 à 12:21 -0400, Jeff Morriss a écrit :
Another question: do we really need to use se_ allocations here? Do we
need the canaries or are we just using se_ allocations because they get
cleaned up for us automatically?
PacketListRecord size is 20 bytes (could be 16) and
Hi,
I got a 146 Mbyte trace file, loading it with the new
packet list WS blows up Out of memory i in emem.c (~line 353)
Looking in the task manager 279 216K s allcated. Using my second
build without the new packet list The file loads fine using 492 304K.
Changing se_alloc to g_slice_alloc0
From: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Anders Broman
Sent: den 5 oktober 2009 12:32
To: Developer support list for Wireshark
Subject: [Wireshark-dev] New packet list - out of memory?
Hi,
I got a 146 Mbyte trace file, loading
Anders Broman wrote:
Hi,
Experimenting loading the file there is 163 calls to VirtualAlloc()
~1.630 GB memory used
Changing
#define EMEM_ALLOCS_PER_CHUNK (EMEM_PACKET_CHUNK_SIZE / 512)
to:
#define EMEM_ALLOCS_PER_CHUNK (EMEM_PACKET_CHUNK_SIZE / 64)
Gives only 26 VirtualAlloc() so it
Bill Meier wrote:
A data point: A few days ago while working on bug #2375 I noticed that
on Windows that if I defined the env logicals to not use se_alloc etc
that *much* less memory was required to load a capture. (20% of that
used with se_alloc etc ? I don't quite remember).
Details:
Anders Broman wrote:
Hmm, use the page + a mail to the list? Or use bugzilla?
Now it's a bit of a pain to frequently check the page for updates and
Not knowing if comments has been observed.
Regards
Anders
OK: It seems that there haven't been a lot of reported problems
(good work !).
-Ursprungligt meddelande-
Från: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] För Bill Meier
Skickat: den 18 september 2009 00:38
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list is now the default.
Anders Broman
Hi,
I've made the new packet list the default build choice. I think it's in
a reasonable state and making it the default will help in fixing any
remaining issues.
Regards
Anders
___
Sent via:Wireshark-dev mailing list
Anders Broman wrote:
Hi,
I've made the new packet list the default build choice. I think it's in
a reasonable state and making it the default will help in fixing any
remaining issues.
Regards
Anders
One behavioral difference (between 1.2.2 and a current (SVN #29971)
Windows Wireshark.
Bill Meier wrote:
Anders Broman wrote:
Hi,
I've made the new packet list the default build choice. I think it's in
a reasonable state and making it the default will help in fixing any
remaining issues.
Regards
Anders
One behavioral difference (between 1.2.2 and a current (SVN #29971)
Anders Broman schrieb:
Hi,
I've made the new packet list the default build choice. I think it's in
a reasonable state and making it the default will help in fixing any
remaining issues.
Hi!
I guess I've started the first coding experiments on this topic some
years ago, so I'm very pleased
Anders Broman wrote:
Hi,
I've made the new packet list the default build choice. I think it's in
a reasonable state and making it the default will help in fixing any
remaining issues.
Regards
Anders
I've started putting my comments re the new packet list on
Hi,
On Fri, Sep 11, 2009 at 08:56:20AM -0400, Jeff Morriss wrote:
Not sure if it's just me or not, but when using the new packet list,
if I use Decode-As (I tried decoding TCP and UDP as just about
anything), I get a crash every time.
I debug it today, in file.c:rescan_packets() we do:
/*
Hi,
Could you try revision 29920?
Regards
Anders
-Original Message-
From: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Jeff Morriss
Sent: den 11 september 2009 14:56
To: wireshark-dev@wireshark.org
Subject: [Wireshark-dev] new packet list
Hi,
On Tue, Sep 15, 2009 at 03:19:03PM +0200, Anders Broman wrote:
Could you try revision 29920?
It's working for me, but I really don't like the solution.
(I don't have a better one, so I think it's better than nothing)
Anyway, can you apply this patch?
It makes some cleanup, and fix
Jakub Zawadzki wrote:
Hi,
On Tue, Sep 15, 2009 at 03:19:03PM +0200, Anders Broman wrote:
Could you try revision 29920?
It's working for me, but I really don't like the solution.
(I don't have a better one, so I think it's better than nothing)
Anyway, can you apply this patch?
It makes
[Resending this because it doesn't show up in the list
archives--though I didn't get a bounce or error, either.]
Hi folks,
Not sure if it's just me or not, but when using the new packet list,
if I use Decode-As (I tried decoding TCP and UDP as just about
anything), I get a crash every time.
On Sep 5, 2009, at 9:47 AM, Kovarththanan Rajaratnam wrote:
I've added a section (Finalizing the prototype) to the existing
wiki page:
http://wiki.wireshark.org/Development/OptimizePacketList
The page jumps from 1st Prototype: GTKTreeView, which says here's a
prototype, but it has some
-Ursprungligt meddelande-
Från: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] För Guy Harris
Skickat: den 7 september 2009 04:10
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list
On Sep 5, 2009, at 9:47 AM
Hey,
Stig Bjørlykke wrote:
I also have some small issues:
- When starting a capture or adding a filter the old packet list
selects the first package, but the new one does not.
- I'm unable to make the columns smaller.
- It's not possible to sort the columns.
- The number columns
Hi,
Sorting of columns in the new packet list may be a bit more complicated
than anticipated.
The filter model looks like it does not implement sorting
http://www.daa.com.au/pipermail/pygtk/2009-February/016609.html
but requires an additional TreeModelSort it then looks like
TreeModelSort requires
Hi,
Browsing the elements in the Packet Details (using up and down arrows)
while capturing changes packet displayed in the Packet Details. I
suppose this bug is related to the new packet list.
--
Stig Bjørlykke
___
Sent
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Anders Broman
Sent: den 3 september 2009 07:39
To: 'Developer support list for Wireshark'
Subject: Re: [Wireshark-dev] New packet list
-Ursprungligt meddelande-
Från: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun
Hi,
I intend to make the new packet list the build choice for Windows in the
next day or so
To get more feedback on remaining issues missing functions etc any
objections?
Regards
Anders
___
Sent via:Wireshark-dev
On Sep 2, 2009, at 9:14 AM, Anders Broman wrote:
I intend to make the new packet list the build choice for Windows in
the next day or so
To get more feedback on remaining issues missing functions etc any
objections?
That sounds like a good idea. Thanks to you and others for your help
Anders Broman wrote:
Hi,
I intend to make the new packet list the build choice for Windows in the
next day or so
To get more feedback on remaining issues missing functions etc any
objections?
I'm going release 1.3.0 (and 1.2.2 and 1.0.9) soon. Is the new packet
list in good enough shape
On Wed, Sep 02, 2009 at 05:14:50PM +0200, Anders Broman wrote:
I intend to make the new packet list the build choice for Windows in the
next day or so
To get more feedback on remaining issues missing functions etc any
objections?
I'm running on openSUSE and have been building (and using)
On Sep 2, 2009, at 5:14 PM, Anders Broman wrote:
Hi,
I intend to make the new packet list the build choice for Windows in
the next day or so
Why only on Windows? Any reason why not switch to it on all platforms?
Best regards
Michael
To get more feedback on remaining issues missing
Hi,
Le mercredi 02 septembre 2009 à 09:11 -0700, Gerald Combs a écrit :
Anders Broman wrote:
Hi,
I intend to make the new packet list the build choice for Windows in the
next day or so
To get more feedback on remaining issues missing functions etc any
objections?
I'm going
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list
On Sep 2, 2009, at 5:14 PM, Anders Broman wrote:
Hi,
I intend to make the new packet list the build choice for Windows in
the next day or so
Why only on Windows? Any reason why not switch to it on all
-Ursprungligt meddelande-
Från: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] För Gerald Combs
Skickat: den 2 september 2009 18:12
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list
Anders Broman wrote:
Hi,
I
Hey Steve,
Stephen Fisher wrote:
On Sep 2, 2009, at 9:14 AM, Anders Broman wrote:
I intend to make the new packet list the build choice for Windows in
the next day or so
To get more feedback on remaining issues missing functions etc any
objections?
That sounds like a good idea.
-dev-boun...@wireshark.org] För Michael Tüxen
Skickat: den 2 september 2009 19:15
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list
On Sep 2, 2009, at 6:58 PM, Anders Broman wrote:
Why only on Windows? Any reason why not switch to it on all
platforms?
I'm
support list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list
Hi,
Le mercredi 02 septembre 2009 à 09:11 -0700, Gerald Combs a écrit :
Anders Broman wrote:
Hi,
I intend to make the new packet list the build choice for Windows in the
next day or so
To get more feedback
-dev-boun...@wireshark.org] För Michael Tüxen
Skickat: den 2 september 2009 19:15
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list
On Sep 2, 2009, at 6:58 PM, Anders Broman wrote:
Why only on Windows? Any reason why not switch to it on all
platforms?
I'm
-Ursprungligt meddelande-
Från: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] För didier
Skickat: den 2 september 2009 18:41
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list
Hi,
Le mercredi 02 septembre 2009 à 09:11
Hey,
Anders Broman wrote:
-Ursprungligt meddelande-
Från: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] För didier
Skickat: den 2 september 2009 18:41
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list
I get
To: 'Developer support list for Wireshark'
Subject: Re: [Wireshark-dev] New packet list
-Ursprungligt meddelande-
Från: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] För didier
Skickat: den 2 september 2009 18:41
Till: Developer support list
I also have some small issues:
- When starting a capture or adding a filter the old packet list
selects the first package, but the new one does not.
- I'm unable to make the columns smaller.
- It's not possible to sort the columns.
- The number columns are not right justified.
Should we
Hi,
Le mercredi 02 septembre 2009 à 20:01 +0200, Anders Broman a écrit :
Coould you try revision 29673 to see if packets without color are randomly
colorized
Are fixed ?
Yes it works for me now.
Regards
Didier
___
Sent
Hey,
Stig Bjørlykke wrote:
I also have some small issues:
- When starting a capture or adding a filter the old packet list
selects the first package, but the new one does not.
- I'm unable to make the columns smaller.
- It's not possible to sort the columns.
- The number columns
-Ursprungligt meddelande-
Från: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] För Kovarththanan Rajaratnam
Skickat: den 3 september 2009 06:12
Till: wireshark-dev@wireshark.org
Ämne: Re: [Wireshark-dev] New packet list
Hey,
Stig Bjørlykke wrote:
I
Hi,
Le dimanche 12 juillet 2009 à 13:43 -0700, Guy Harris a écrit :
On Jul 12, 2009, at 12:48 PM, Jakub Zawadzki wrote:
This patch (Proof of Concept) removes allocating memory for columns
data,
and makes them 'dynamic' (packets redissected when column data needed)
That should make
On Sun, Jul 12, 2009 at 09:52:49PM -0600, Stephen Fisher wrote:
I experimented with re-dissecting a while back when I first started one
of my versions of the new packet list and saw significant CPU utilization
because whenever you even drag the mouse arrow up/down along the displayed
Le dimanche 12 juillet 2009 à 21:48 +0200, Jakub Zawadzki a écrit :
Hi,
This patch (Proof of Concept) removes allocating memory for columns data,
and makes them 'dynamic' (packets redissected when column data needed)
Getting column data is done in packet_list_record_get_column()
I'd be
[mailto:wireshark-dev-boun...@wireshark.org] För Jakub Zawadzki
Skickat: den 11 juli 2009 23:56
Till: wireshark-dev@wireshark.org
Ämne: [Wireshark-dev] New packet list - small fixes
Hi,
This patch fix off-by-one error in packet_list_init()
and makes new_packet_list_append() to use stack for row_data_t
On Sun, Jul 12, 2009 at 11:08:59AM +0200, Anders Broman wrote:
Checked in
Thanks :)
together with some changes towards only storing the actually
used columns.
It crash at startup (newrecord-col_text[] not allocated),
in attachment fix to restore old newrecord-col_text.
Cheers.
diff --git
On Sun, Jul 12, 2009 at 11:08:59AM +0200, Anders Broman wrote:
I haven't figured out where packet_list_get_value():s column
value comes from yet.
It's set by gtk_tree_view_column_add_attribute(..., text, X) call
Doc:
list for Wireshark
Ämne: Re: [Wireshark-dev] New packet list - small fixes
On Sun, Jul 12, 2009 at 11:08:59AM +0200, Anders Broman wrote:
I haven't figured out where packet_list_get_value():s column
value comes from yet.
It's set by gtk_tree_view_column_add_attribute(..., text, X) call
Doc:
http
Hi,
This patch (Proof of Concept) removes allocating memory for columns data,
and makes them 'dynamic' (packets redissected when column data needed)
Getting column data is done in packet_list_record_get_column()
I'd be grateful if someone could give some hints how it could be optimized.
(Anyway
Once again, against r29075 :)
diff --git file.c file.c
index 71ac4d1..181c32f 100644
--- file.c
+++ file.c
@@ -1046,7 +1046,7 @@ add_packet_to_packet_list(frame_data *fdata, capture_file
*cf,
evaluated. */
if ((dfcode != NULL refilter) || color_filters_used() ||
On Jul 12, 2009, at 12:48 PM, Jakub Zawadzki wrote:
This patch (Proof of Concept) removes allocating memory for columns
data,
and makes them 'dynamic' (packets redissected when column data needed)
That should make changing the time format, for example, *extremely*
fast - it should just
On Jul 12, 2009, at 12:48 PM, Jakub Zawadzki wrote:
This patch (Proof of Concept) removes allocating memory for columns
data,
and makes them 'dynamic' (packets redissected when column data needed)
That should make changing the time format, for example, *extremely*
fast - it should just
On Jul 12, 2009, at 3:15 PM, Anders Broman wrote:
(That doesn't say this is the wrong thing to do - I've been
advocating
this for a while, and made a version of the GTK 1.2[.x] GtkCList with
dynamic column data and prototyped the same thing - it says we need
to make random access to
On Jul 12, 2009, at 3:46 PM, Guy Harris wrote:
In bzip2 format, the stream is a sequence of blocks, and, at least as
I understand it, each block can be decompressed independently, so
seeking to a particular offset in the decompressed version of a
bzip2'ed stream involves seeking to the
On Sun, Jul 12, 2009 at 09:48:14PM +0200, Jakub Zawadzki wrote:
This patch (Proof of Concept) removes allocating memory for columns
data, and makes them 'dynamic' (packets redissected when column data
needed)
I haven't seen any visible lags while scrolling, CPU usage is higher
but for
Hi,
This patch fix off-by-one error in packet_list_init()
and makes new_packet_list_append() to use stack for row_data_t.
Btw. There's new issue, when I load some capture into wireshark, and don't
click any packet. I got SIGSEGV on closing capture (^W) on quiting (^Q)
(gdb) bt
#0
72 matches
Mail list logo
