[Wireshark-dev] Thoughts on disabling an old dissector

2013-12-18 Thread Evan Huus
This was originally filed as bug 9569. The situation is sufficiently unusual that I really don't know what the best solution is, so I figured I'd ask for general comments from the list. The company who created and used the TPNCP protocol (and submitted the packet-tpncp.c dissector) wants to reuse

Re: [Wireshark-dev] Thoughts on disabling an old dissector

2013-12-18 Thread Joerg Mayer
On Wed, Dec 18, 2013 at 01:33:00PM -0500, Evan Huus wrote: This was originally filed as bug 9569. The situation is sufficiently unusual that I really don't know what the best solution is, so I figured I'd ask for general comments from the list. The company who created and used the TPNCP

Re: [Wireshark-dev] Thoughts on disabling an old dissector

2013-12-18 Thread Tyson Key
Hi Evan, Hmm, now that's an interesting dilemma. Couldn't we rename the old dissector to something like tpncp_old, tpncpv1, or tpncp_legacy? That said, it'd probably be a disservice to completely remove a dissector that folks are probably using to dissect legacy TPNCP packets in old trace files.

Re: [Wireshark-dev] Thoughts on disabling an old dissector

2013-12-18 Thread Michael Lum
-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Joerg Mayer Sent: December 18, 2013 10:48 AM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Thoughts on disabling an old dissector On Wed, Dec 18, 2013 at 01:33:00PM -0500, Evan Huus wrote

Re: [Wireshark-dev] Thoughts on disabling an old dissector

2013-12-18 Thread Christopher Maynard
Evan Huus eapache@... writes: This was originally filed as bug 9569. The situation is sufficiently unusual that I really don't know what the best solution is, so I figured I'd ask for general comments from the list. The company who created and used the TPNCP protocol (and submitted the

Re: [Wireshark-dev] Thoughts on disabling an old dissector

2013-12-18 Thread ronnie sahlberg
I think we should keep the dissector but either rename it to *_legacy or something like someone suggested or control it via a preference. We have similar situations for other protocols already that can be used to highlught some of the options : In iSCSI we already have a preference (that