Re: [Wireshark-dev] signedness of comparison functions in ftype-integer.c

2007-01-18 Thread Martin Mathieson
On 1/8/07, Martin Mathieson <[EMAIL PROTECTED]> wrote: > On 1/4/07, Martin Mathieson <[EMAIL PROTECTED]> wrote: > > On 1/3/07, Guy Harris <[EMAIL PROTECTED]> wrote: > > > Martin Mathieson wrote: > > > > > > > For the more general problem, I see 2 possible solutions: > > > > (1) have both signed and

Re: [Wireshark-dev] signedness of comparison functions in ftype-integer.c

2007-01-08 Thread Martin Mathieson
On 1/4/07, Martin Mathieson <[EMAIL PROTECTED]> wrote: On 1/3/07, Guy Harris <[EMAIL PROTECTED]> wrote: > Martin Mathieson wrote: > > > For the more general problem, I see 2 possible solutions: > > (1) have both signed and values in the union, and use the appropriate > > signed or unsigned parts

Re: [Wireshark-dev] signedness of comparison functions in ftype-integer.c

2007-01-04 Thread Martin Mathieson
On 1/3/07, Guy Harris <[EMAIL PROTECTED]> wrote: Martin Mathieson wrote: > For the more general problem, I see 2 possible solutions: > (1) have both signed and values in the union, and use the appropriate > signed or unsigned parts of the union in the comparison functions > (2) leave the union a

Re: [Wireshark-dev] signedness of comparison functions in ftype-integer.c

2007-01-03 Thread Guy Harris
Martin Mathieson wrote: > For the more general problem, I see 2 possible solutions: > (1) have both signed and values in the union, and use the appropriate > signed or unsigned parts of the union in the comparison functions > (2) leave the union as it is with unsigned members, cast values in all >

[Wireshark-dev] signedness of comparison functions in ftype-integer.c

2007-01-03 Thread Martin Mathieson
Hi, While looking at bug 1279 (Negative values for RTCP round trip delay cannot be stored in guint32) I noticed that I couldn't use filter expressions using < and negative numbers with an FT_INT32 field. The problem seems to be that: - fvalue_t.value.integer is a guint32 - the current less-than f