Re: [Wireshark-dev] How to get calling dissector

2018-01-30 Thread Shai Shapira
I believe there's another possible approach here: Register the dissector once with proto_register_protocol (as usual), which assumed caller is TCP register another dissection function (for SMP) using create_dissector_handle_with_name called something like "smp.tds" than look for this name when

[Wireshark-dev] PAD file contents

2018-01-30 Thread Jaap Keuter
Hi, The published PAD file lists: Linux,Linux Console,Linux Gnome,Linux GPL,Linux Open Source,Mac OS X,Unix,Win7 x32,Win7 x64,WinServer,WinVista,WinVista x64,WinXP,Other I think "WinVista,WinVista x64,WinXP” should be dropped from this list. Also the screenshot is due for an overhaul:

[Wireshark-dev] Philosophy question - avoiding g_alloc in dissectors?

2018-01-30 Thread Craig Jackson
I have a place in my dissector where g_strjoin would fit my needs exactly, and make clean code. However, it calls g_alloc, which I am assuming is heavier than the allocator used for wmem_packet_scope. I see there's a wmem_strconcat, but that doesn't quite fit my needs. It could but not as well.

Re: [Wireshark-dev] How to get calling dissector

2018-01-30 Thread Uli Heilmeier
Thanks for your idea. It's exactly the way Michael did it with his improvement for my patch: https://code.wireshark.org/review/#/c/25509/ Am 29.01.18 um 21:01 schrieb Shai Shapira: > I believe there's another possible approach here: > Register the dissector once with proto_register_protocol (as