Re: [Wireshark-dev] RFC: Internally Generated "Records"

2015-08-18 Thread Roland Knall
Hi Evan Did this approach got implemented? If not, I would like to give it a try. regards, Roland On Tue, Aug 5, 2014 at 12:14 AM, Roland Knall wrote: > Yes, that it what I was saying. > > Cool, you can look forward to the openSAFETY patch, the minute the change > hit the o

Re: [Wireshark-dev] RFC: Internally Generated "Records"

2015-08-18 Thread Roland Knall
Good, have some vacation days coming up and will give it a try. regards, Roland On Tue, Aug 18, 2015 at 4:53 PM, Evan Huus wrote: > On Tue, Aug 18, 2015 at 10:49 AM, Roland Knall wrote: > > Hi Evan > > > > Did this approach got implemented? If not, I would like to give it

[Wireshark-dev] Petri-Dish circumvention breaks daily-build

2015-09-09 Thread Roland Knall
Hi In our company we have our own Wireshark tools and plugins, which use the main wireshark repository. To ensure that those do not break (and if they break we can fix them in due time), we synchronize with the Wireshark repo every night and build it with our own tools on Windows and Linux. And n

Re: [Wireshark-dev] Petri-Dish circumvention breaks daily-build

2015-09-09 Thread Roland Knall
tone in the last e-mail. Just want to raise awareness on the issue. regards, Roland On Thu, Sep 10, 2015 at 8:30 AM, Pascal Quantin wrote: > > Le 10 sept. 2015 8:00 AM, "Roland Knall" a écrit : > > > > Hi > > > > In our company we have our own Wireshark

Re: [Wireshark-dev] Add support for remote capture in linux

2015-10-02 Thread Roland Knall
Hi Would it not be easier to achieve this using an extcap interface? You can see the extcap_example in /doc as well as androiddump for examples. Such interfaces can be configured with a separate options dialog and are quite versatile, and most of all, it does not need you to change dumpcap in a wa

Re: [Wireshark-dev] Extcap

2015-10-19 Thread Roland Knall
Hi 2 suggestions for you. First, is you initiate extcap via console, do you run it as root? And is wireshark running as non-root? If yo, you might need capture privileges as suggested by the wireshark wiki page. Second, yes the directories are not very intuitive. Usually if you run it from a build

Re: [Wireshark-dev] CAN over Ethernet

2015-11-07 Thread Roland Knall
Hi It depends how the CAN messages are being transported within Ethernet. Then you could write a dissector for the method, which in turn calls the CAN dissector. The same thing happens with a lot of other dissectors,the openSAFETY disssector for instance. regards, Roland On Sat, Nov 7, 2015 at

Re: [Wireshark-dev] Extcap DLTs

2015-11-24 Thread Roland Knall
You could try USER0. The problem here is, that I have to register the extcap interface with the other interfaces at some point, and usually this happens way before the capture starts (at which point an extcap utility might know which DLT it could produce). Therefore I first ask the utility for all

Re: [Wireshark-dev] Extcap DLTs

2015-11-24 Thread Roland Knall
On Tue, Nov 24, 2015 at 2:00 PM, Dario Lombardo wrote: > > Where is it defined? I can't compile something like > > g_print("dlt {number=%u}{name=%s}{display=%s}\n", USER0, > RANDPKT_EXTCAP_INTERFACE, wtap_encap_string(USER0)); > >From the python example in doc: print ("dlt {number=147}{name=USER

Re: [Wireshark-dev] plugin_if menu problems

2015-11-27 Thread Roland Knall
Hi I do not have anything standing in front of my callbacks, therefore I would remove WS_DLL_PUBLIC_DEF completely. It is not necessary in your case. Secondly, if you are using the latest git source of Wireshark or the 2.0 source, the correct prototype for the callback would be: void menu_cb(ext_

Re: [Wireshark-dev] plugin_if_goto_frame causes protection exception

2015-11-27 Thread Roland Knall
You should commit this change via gerrit. I think it is ok but you should also check in your code if a call is valid or not by checking for a loaded trace. Regards, Roland > Am 27.11.2015 um 23:52 schrieb Paul Offord : > > Hi, > > If you call plugin_if_goto_frame when there is no capture f

Re: [Wireshark-dev] overriding built-in dissector

2015-11-30 Thread Roland Knall
As far as I know, overriding a default dissector is not possible, or more precise not necessarily very easy. But what you could do is, to implement a generic heuristic entry point in the dis dissector, which then in turn you could use to let your custom plugin take over the dissection from the dis

Re: [Wireshark-dev] Add plugin_if_get_framenr()

2016-01-04 Thread Roland Knall
Hi The plugin_if functionality exists, because methods called by plugins run in a different thread context than the gui. Therefore, if you want to gui to act in a certain way, you have to somehow cross the context to achieve whatever you want to do. Your proposed idea goes in the other direction.

Re: [Wireshark-dev] Mac Build Error

2016-01-21 Thread Roland Knall
On Fri, Jan 22, 2016 at 1:40 AM, Guy Harris wrote: > > > This means we can't use CMAKE_REQUIRED_FLAGS, and have to find some > *other* way to specify the flag to be tested. FYI, the only sure-fire way in CMAKE to set specific only linker flags is using the target properties. The following code m

Re: [Wireshark-dev] Mac Build Error

2016-01-21 Thread Roland Knall
On Fri, Jan 22, 2016 at 8:26 AM, Guy Harris wrote: > On Jan 21, 2016, at 9:36 PM, Roland Knall wrote: > > > FYI, the only sure-fire way in CMAKE to set specific only linker flags > is using the target properties. > > So what's the best way to, within a .cmake file, c

Re: [Wireshark-dev] Mac Build Error

2016-01-22 Thread Roland Knall
On Fri, Jan 22, 2016 at 9:06 AM, Guy Harris wrote: > On Jan 21, 2016, at 11:42 PM, Roland Knall wrote: > > > Sorry to disappoint ;-), but it can be done, just not in a convenient > way. And the 9oo10 mostly is fixed by using a newer version then 2.8.12 for > CMake. There are s

Re: [Wireshark-dev] Highlight fields

2016-02-10 Thread Roland Knall
Hi No, currently there is no direct way to do this. And any new way would require a change to the dissectors handling the messages regards On Wed, Feb 10, 2016 at 11:44 AM, Juan Jose Martin Carrascosa < jua...@rti.com> wrote: > Hi all, > > Let's say I have several submessages in a packet (RTPS)

Re: [Wireshark-dev] linking errors on Windows

2016-02-23 Thread Roland Knall
Hi Could you provide some form of linker output so that we could see, which functions you are talking about? regards Roland On Wed, Feb 24, 2016 at 6:25 AM, Edwin Groothuis < edwin.grooth...@riverbed.com> wrote: > Greetings, > > > > I’m in the process of upgrading an 1.10 environment into the 2

Re: [Wireshark-dev] Bug Report Wireshark 2.0.2 - File Merge

2016-03-26 Thread Roland Knall
Hi Could you please file a bug report with https://bugs.wireshark.org/bugzilla/ kind regards Roland > Am 25.03.2016 um 17:58 schrieb Francis Chartier : > > Hello, > > I am using Wireshark 2.0.2 to debug videoconference. > > I joined the 2 traces of the Firewall (Lan Side – called capturein

Re: [Wireshark-dev] Building with CMake on Win10 and VS2013 (win64)

2016-03-29 Thread Roland Knall
Take a look in your build directory, there must be a folder called CMakeFiles. In it, you'll find CMakeError.log. This file should contain, at it's bottom, the call which lead to the error and a more detailed error information in regard to the missing utility. regards Roland On Tue, Mar 29, 2016

Re: [Wireshark-dev] Building with CMake on Win10 and VS2013 (win64)

2016-03-29 Thread Roland Knall
attached it). When it > does, the output (like that below) would include a note about "See also > CMakeError.log)" at the last line (right after line about CMakeOutput.log) > > > -----Original Message- > From: Roland Knall > To: Developer support list for Wires

Re: [Wireshark-dev] Deprecating nmake

2016-04-02 Thread Roland Knall
Try to set the path to the Python Executable in cmake. Seems he catches the Cygwin version by mistake. Regards > Am 02.04.2016 um 16:07 schrieb RobiOneKenobi : > > Hi, > > I'm trying to migrate to CMake, but i'm facing 2 problems > > In Win64, it stops after a few lines with: > > CMake Erro

Re: [Wireshark-dev] Embedding external program into wireshark menu

2016-07-14 Thread Roland Knall
Hi In principal there exists an interface called extcap, which allows it to implement separate utilities as capture interfaces. See sshdump or androiddump for example. Those interfaces then will create the pcap trace and wireshark can utilize them, as if they where a network card or similar. For

Re: [Wireshark-dev] Question on payload reassembly

2016-07-28 Thread Roland Knall
Hi Just a short question, does your sequence counter repeat? If so, this can be an issue. Also, for the openSAFETY dissector it only worked properly, after I implemented fragment_add_seq_offset, so it will allways count internally beginning with 0. You can see that in line 1272 of packet-opensafet

Re: [Wireshark-dev] Small bug in Modbus dissector exception information

2016-07-29 Thread Roland Knall
Hi Please report this in a bug-report on https://bugs.wireshark.org/bugzilla/ and attach a sample trace detailing the issue. regards Roland On Sat, Jul 30, 2016 at 8:27 AM, Dennis Luehring wrote: > i use a "Live on the Bleeding Edge" Version > > https://www.wireshark.org/download/automated/win

Re: [Wireshark-dev] extcap.c does not build on SUSE 11.3. g_spawn_check_exit_status requires glib 2.34

2016-08-01 Thread Roland Knall
Hi No, I've uploaded a new patch to gerrit ( https://code.wireshark.org/review/16827), which removes the need for this function. Just fyi, the min glib version to be supported is 2.14.0, and although I'd appreciate a discussion to change that in the future, this patch is a pretty simple fix. rega

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Roland Knall
Paul, could you give an example, why you chose Qt libraries over Gtk? Was it not possible, or is it a personal choice? I do have plugins for WS, which use Qt, but not for dissectors, so I am just curious, what was missing. regards Roland On Fri, Aug 5, 2016 at 11:20 AM, Graham Bloice wrote: >

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Roland Knall
any of the GUI stuff from Qt, just the TCP > server functionality, multi-threading functions and Signals & Slots to > communicate between threads. > > > > Best regards…Paul > > > > *From:* wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-bounces@ > wir

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Roland Knall
anning to submit this to be incorporated into the main stream code. > > > > You can see Syncro in action here http://www.youtube.com/watch? > v=anEZGfF4P10&t=5m5s if you are interested. > > > > Best regards…Paul > > > > *From:* wireshark-dev-boun...@wireshar

Re: [Wireshark-dev] Wireshark 2.2.0rc1 is now available

2016-08-23 Thread Roland Knall
Hi Gerald Could you mention the fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11892 in the release notes - "extcap utilities keep running, after capture shut down". regards Roland On Tue, Aug 23, 2016 at 12:49 AM, Gerald Combs wrote: > I'm proud to announce the release of Wiresha

[Wireshark-dev] Remove of GTK interface

2016-09-05 Thread Roland Knall
Hi As I understand correctly, the gtk interface is being phased out to a point, where it will not be included in 2.4 anymore. I am currently one the brink of adding new features to extcap, and doing so would need me to change some internal interfaces, some of which are used only by the gtk interfa

[Wireshark-dev] Enable extcap by default or not

2016-09-08 Thread Roland Knall
Hello List There is currently a discussion going on in https://code.wireshark.org/review/#/c/17498 in regard to enabling extcap features by default or not. There are basically two sides to the argument: Cons - extcap interfaces are advanced features, which will not be used by a majority of users

Re: [Wireshark-dev] Enable extcap by default or not

2016-09-09 Thread Roland Knall
On Fri, Sep 9, 2016 at 8:16 AM, Graham Bloice wrote: > > >> > I vote for disable by default, I feel that the extcap interfaces are > superfluous and confusing to most of the users I support as they are for > "niche" purposes. > > I don't follow the argument that a user actually needing an extcap

Re: [Wireshark-dev] Enable extcap by default or not

2016-09-09 Thread Roland Knall
No, it just means, that extcap interfaces are either available by default or not. They do not run permanently. regards On Fri, Sep 9, 2016 at 8:02 PM, Bill Meier wrote: > On 9/9/2016 1:42 AM, Roland Knall wrote: > >> Hello List >> >> There is currently a discuss

Re: [Wireshark-dev] Ethernet header below MPLS...

2016-09-16 Thread Roland Knall
On how he did that, Wireshark dissectors can attach each other to dissect payloads if they apply for them. So in this case, the MPLS dissector has a hook, to which either the ETH dissector has attached or was called by the MPLS dissector. - Roland On Fri, Sep 16, 2016 at 3:03 AM, Guy Harris wrot

[Wireshark-dev] Docker image for WS Build

2016-10-06 Thread Roland Knall
Hello I've created a docker image, to build Wireshark for a Linux build. You can find it on https://hub.docker.com/r/rknall/wsbuilder/ It contains Qt5, Lua and libssh, and can be used for building docker in a Jenkins environment (that is, what I am using it for) with the Jenkins user "jenkins" a

Re: [Wireshark-dev] Docker image for WS Build

2016-10-06 Thread Roland Knall
I will do that in the coming days. Thanks, Roland On Thu, Oct 6, 2016 at 2:47 PM, Jaap Keuter wrote: > > > On 06 Oct 2016, at 09:53, Roland Knall wrote: > > > > Hello > > > > I've created a docker image, to build Wireshark for a Linux build. You > can

Re: [Wireshark-dev] Docker image for WS Build

2016-10-07 Thread Roland Knall
> Am 07.10.2016 um 17:08 schrieb Alexis La Goutte : > > > >> On Thu, Oct 6, 2016 at 9:53 AM, Roland Knall wrote: >> Hello >> >> I've created a docker image, to build Wireshark for a Linux build. You can >> find it on >> >> htt

Re: [Wireshark-dev] Linking on OSX Sierra

2016-10-08 Thread Roland Knall
Just a quick info, I am running on Sierra as well, and had to update Xcode as well as the command-line utilities. Wireshark build s and runs fine here. Fyi, I am using Qt5.7 and ports regards Roland On Sat, Oct 8, 2016 at 1:14 AM, Guy Harris wrote: > On Oct 7, 2016, at 4:03 PM, Gerald Combs w

[Wireshark-dev] Change of minimum supported Qt version in master

2016-10-19 Thread Roland Knall
Hi all Due to new features in master and due to the fact, that 4.7 (our old minimum version) is no longer supported by the current major distributions, we switched the minimum version of Qt to Qt 4.8 (LTS) Please see https://wiki.wireshark.org/Development/Support_library_version_tracking for the

[Wireshark-dev] GUI Change for Wireshark Remote Interfaces

2016-10-27 Thread Roland Knall
Hi I am currently rewriting the ManageInterfacesDialog, and so far I am nearly done. The last thing open are the Remote Capture Interfaces. But to do this the right way, I am also going to get rid of the two popup dialogs and change the layout of the tab a little bit. So I wanted to get some feed

Re: [Wireshark-dev] GUI Change for Wireshark Remote Interfaces

2016-10-27 Thread Roland Knall
; > > On 27 October 2016 at 10:36, Roland Knall wrote: > >> Hi >> >> I am currently rewriting the ManageInterfacesDialog, and so far I am >> nearly done. The last thing open are the Remote Capture Interfaces. >> >> But to do this the right way, I am

Re: [Wireshark-dev] GUI Change for Wireshark Remote Interfaces

2016-10-27 Thread Roland Knall
On Thu, Oct 27, 2016 at 1:14 PM, Peter Wu wrote: > Not being able to store remote interface is probably a bug / missing > feature. See for example user responses at > https://ask.wireshark.org/questions/47141/remote-capture-on-startup > > Kind regards, > Peter > This raises difficult questions i

Re: [Wireshark-dev] GUI Change for Wireshark Remote Interfaces

2016-10-27 Thread Roland Knall
Guy, is the version on github for libpcap already equipped with pcap_open on Mac? I don't need it to function, just for the cmake script to work and run, as it would make development of the new version so much easier. I'll change the title accordingly, but the interface changes should be ok so far

Re: [Wireshark-dev] GUI Change for Wireshark Remote Interfaces

2016-10-28 Thread Roland Knall
I've changed the pcap by hand using cmake-gui. Works but have not tried running it against anything or capturing. regards On Fri, Oct 28, 2016 at 11:14 AM, Joerg Mayer wrote: > On Thu, Oct 27, 2016 at 09:36:47PM -0700, Guy Harris wrote: > > On Oct 27, 2016, at 8:54 PM, Guy Harris wrote: > > >

Re: [Wireshark-dev] IP src/dst from Qt

2016-10-31 Thread Roland Knall
Hi What ip src/dest do you mean? If you mean the ones from a packet trace, a tap interface might be the easiest to get the information. I do a similar thing with a 3rd-party plugin of mine. regards Roland On Mon, Oct 31, 2016 at 2:44 PM, Dario Lombardo wrote: > Hi > I'd like to read the ip src

Re: [Wireshark-dev] IP src/dst from Qt

2016-10-31 Thread Roland Knall
, Dario Lombardo wrote: > As a starting point I'd like to have the ones in packet_info. > > On Mon, Oct 31, 2016 at 2:50 PM, Roland Knall wrote: > >> Hi >> >> What ip src/dest do you mean? If you mean the ones from a packet trace, a >> tap interface might

Re: [Wireshark-dev] IP src/dst from Qt

2016-10-31 Thread Roland Knall
the dissectors to find all regards, Roland On Mon, Oct 31, 2016 at 3:23 PM, Dario Lombardo wrote: > > > On Mon, Oct 31, 2016 at 3:16 PM, Roland Knall wrote: > >> I would implement a listener for the tap interface of the ip dissector.

Re: [Wireshark-dev] New statistics panel for RTPS

2016-11-03 Thread Roland Knall
Hi This depends on how sophisticated you want the final panel to be. If you just want to add new statistics for one dissector, this likely could be done in a week. Take a look at README.stats_tree for details in the doc subdirectory of the source-code. If you want a more sophisticated analysis do

Re: [Wireshark-dev] Live wireshark capture packets from my windows filter driver

2016-11-12 Thread Roland Knall
Hi One possibility would be an extcap device. See README.extcap in the doc subdirectory for more details. regards On Sat, Nov 12, 2016 at 3:35 AM, Ashok Nandoori wrote: > Hi, > > Can you send me some pointers on how to write plug-in to wireshark to > capture live packets from my windows filter

Re: [Wireshark-dev] Extcap limitations?

2016-12-23 Thread Roland Knall
Hello extcap is a frontend for WS pipes. Therefore it strongly relies on the moment on the formates dumpcap supports on pipes, and that is only pcap atm. There was talk and some movement in the direction of pcapng, and it is on my list of items to be implemented in the next free timeslot (and for

Re: [Wireshark-dev] Building latest Wireshark using VS2013

2016-12-23 Thread Roland Knall
Hi The solution should rather be if (tvb_get_ntohl(tvb, offset) != 0x2001) { return; } This follows the coding rules within the file. I can't even begin to imagine, what msbuild is complaining about, but who really knows, what that build-system is thinking in it's core..

Re: [Wireshark-dev] Build with VS 2013 on Windows 7

2016-12-26 Thread Roland Knall
It could be, that the version of Powershell required is not the correct one. Some versions of Windows Server use a version out-of-the-box which is too old for the script to work. Not sure, which version to use, but I'd try to update to the latest one. Another thing could be an improperly cleaned b

Re: [Wireshark-dev] QT DLLs missing from build environment

2016-12-27 Thread Roland Knall
@Paul - I would also recommend to update to the latest version, but at least 5.6. I am currently building with 5.6.1 on all three plattforms. regards Roland On Tue, Dec 27, 2016 at 3:03 PM, Anders Broman wrote: > Hi, > > At some point I think there was a fault in Qt causing it to not copy all >

[Wireshark-dev] Inclusion of KDE code in WS

2016-12-28 Thread Roland Knall
Hi Short question: Would it be ok, to include 3 KDE classes (from git:// anongit.kde.org/kitemmodels.git) with the WS sourcecode, after asking the author (single author in this case) if this is ok? The code is licensed with GPL 2.1 Long question: I am running into a rather difficult issue with th

Re: [Wireshark-dev] Inclusion of KDE code in WS

2016-12-28 Thread Roland Knall
On Wed, Dec 28, 2016 at 10:14 AM, Michal Labedzki wrote: > > On 28 December 2016 at 09:37, Roland Knall wrote: > >> git://anongit.kde.org/kitemmodels.git >> > > Online: > https://cgit.kde.org/kitemmodels.git/tree/src > > I am ok with that (but I am not la

Re: [Wireshark-dev] extcap slowing down start of WS

2017-01-04 Thread Roland Knall
@Stiq - this is the plan going forward. But first, I need to fix the initial call to the interfaces on Windows, because there is an issue with stdin buffers on Windows and a large number of interfaces. The register preferences call is a necessity, but the one in fill_in_local_interfaces could be a

Re: [Wireshark-dev] How do I set the epan/dissectors/Makefile.am CUSTOM_DISSECTOR_SRC variable from a script when I run configure?

2017-01-06 Thread Roland Knall
Just my two cents here. If you would change your build-system to CMake, you could use the CMakeListsCustom.txt files to achieve the same thing. You would not need to script anything, and could directly just copy the necessary file into the build. The plugins and additional dissectors do not need to

Re: [Wireshark-dev] Remote Control Plugin - Can I submit to the Wireshark project

2017-01-06 Thread Roland Knall
upled application. Is this code suitable for submission to the project? > > > > Thanks and regards…Paul > > > > *From:* wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-bounces@ > wireshark.org] *On Behalf Of *Roland Knall > *Sent:* 05 August 2016 11:57 > *To:

Re: [Wireshark-dev] VS 2015 or not

2017-01-06 Thread Roland Knall
VS2015 is safe for now, although I'd not got any further up. Basically, when a new VS version is being released it might take some time, to get special IDE shenanigans back-ported, same goes with new Xcode versions on Mac. If you want to build plugins against official versions of WS, or just want t

[Wireshark-dev] Bugzilla SSL Issue?

2017-01-20 Thread Roland Knall
I am getting SSL issues while contacting https://bugzilla.wireshark.org Anyone else does as well? My Google Chrome (Version 55 on Linux) does not accept the certificate. Moreove, the certificate seems to have been issued on Jan 02 2017 and expires on April 02 2017, which is weird by itself Anyon

Re: [Wireshark-dev] Bugzilla SSL Issue?

2017-01-20 Thread Roland Knall
On Fri, Jan 20, 2017 at 3:59 PM, João Valverde < joao.valve...@tecnico.ulisboa.pt> wrote: > I think the correct (?) URL is: https://bugs.wireshark.org/ Of course it is. For that URL it is working Thanks ___ Sent via:

Re: [Wireshark-dev] Conditional compiles

2017-02-14 Thread Roland Knall
There is some misconception about the general approach with this idea. Whilst I applaud any attempt to reduce the number of defines, as it eases the implementation of new features (due to not stumbling over undetected #define issues), I strongly suggest taking a different route here. HAVE_LIBPCAP

Re: [Wireshark-dev] Wireshark no longer builds on SuSE 11.3

2017-02-14 Thread Roland Knall
I was hoping to say, let's drop SuSE 11.3, as SuSE 11.4 has glib version 2.28, which includes the function. Also ReadHat 5 drops support by the end of next month. But SLES still supports it until 2019. As for the convenience method, I would not provide a compatibility header, as this would require

Re: [Wireshark-dev] Conditional compiles

2017-02-14 Thread Roland Knall
One specific future scenario would be an iOS or Android version of Wireshark purely for analyzing traffic captures and not capturing in itself. Usually on such systems providing a binary which can capture system traffic is frowned upon if not outright forbidden by the developer licenses. Therefore

Re: [Wireshark-dev] Wireshark no longer builds on SuSE 11.3

2017-02-14 Thread Roland Knall
On Tue, Feb 14, 2017 at 4:28 PM, Peter Wu wrote: > Where did you find SLES 11.4 support for GLib 2.28? I only see 2.22.5 > for SLES 11.3 and the release notes do not mention newer versions: > https://www.suse.com/releasenotes/x86_64/SUSE-SLES/11-SP4/ > SLED (for desktop) 11.4 was unsupported sinc

Re: [Wireshark-dev] Extcap version

2017-02-27 Thread Roland Knall
That is an early design flaw - still going strong to that very day. It stems from the fact, that the version query was introduced later on, and the interface list query basically covered that as well. Additionally, parsed extcap interfaces where not parsed on a tool (meaning executable) level, but

Re: [Wireshark-dev] Extcap version

2017-02-27 Thread Roland Knall
tion: lives in extcap_info and in > extcap_interface at the same time. I don't think we need both: I hardly > figure out how we'd need to different help pages/files for 2 different > intefaces of the same extcap. What about removing the help in the interface? > > On Mon, Feb 27, 2017 at 1

Re: [Wireshark-dev] small vs large patch sets ?

2017-04-19 Thread Roland Knall
> > >> Is there a better way of doing thing? >> > You can push all patches with the same topic, and they will be reviewed > one after each other. > > Gerrit also allows an easy rebase of patchsets, so one patchset can be rebased while others stay the same. Take a look at "git review" which also e

Re: [Wireshark-dev] Specifying dissectors declaratively

2017-04-19 Thread Roland Knall
Generally speaking we can divide new protocol languages in two different classes: - interpreting ones - compiled ones The interpreting class has LUA and wsgd as representative. They have their benefits, but I do not really like the approach of interpreting at runtime. CSjark seems interesting, b

Re: [Wireshark-dev] Omnipeek vs. Wireshark videos

2017-04-25 Thread Roland Knall
Well, I might be biased a little bit, but the videos, although they show some interesting ideas (e.g. Highlight the TCP flow instead of filtering it), in my point of view it strongly favors Omnipeek, because the author seems familiar with it (from taking a look at Savvius's videos that seems to be

Re: [Wireshark-dev] Bugzilla is unreachable

2017-04-26 Thread Roland Knall
There is a known issue with the server atm, and we ware trying to fix it, please check back a little bit later cheers, Roland On Wed, Apr 26, 2017 at 3:44 PM, Maynard, Chris wrote: > It seems that Bugzilla is unreachable for me. Am I only the one seeing > this? > > Error 525 Ray ID: 3559f7453b

Re: [Wireshark-dev] Switch master and master-2.4 to Visual Studio 2015?

2017-06-07 Thread Roland Knall
Jumping to 2017 would bring some advantages in building, as well as build-system integration, native cmake integration for instance. But I would only jump for the master. We also would have to consider, a lot of people building on company PCs may not have the option to switch to 2017, as they are

Re: [Wireshark-dev] Does it take a while before a public key becomes available on Gerrit?

2017-06-13 Thread Roland Knall
Usually adding the key should take immediately. Try on a console window together with your user-name and don't forget the port 29418. Usually the following command should print you the version on a console: ssh -p 29418 @code.wireshark.org gerrit version cheers On Mon, Jun 12, 2017 at 11:33

Re: [Wireshark-dev] Go to Qt 5.9 on Windows build bots?

2017-06-14 Thread Roland Knall
+1 Linux and Mac build fine already with 5.9 Regards > Am 14.06.2017 um 14:09 schrieb Graham Bloice : > > > >> On 14 June 2017 at 12:55, Pascal Quantin wrote: >> Hi Anders, >> >> Le 14 juin 2017 13:49, "Anders Broman" a écrit : >> Hi, >> >> Should we go to Qt 5.9 on the build bots before S

Re: [Wireshark-dev] git problem

2017-06-25 Thread Roland Knall
un 25, 2017 at 1:12 PM, Pascal Quantin wrote: > Hi Paul, > > > > Le 25 juin 2017 12:59, "Paul Offord" a écrit : > > I am trying to upload some patches to Gerrit. The start of my commit > message looks like this: > > > > [WIP] First stage of updates t

Re: [Wireshark-dev] git problem

2017-06-25 Thread Roland Knall
more work to do to cover all of the changes you requested. I > have a couple of questions regarding your comments but I’ll cover those in > another email. > > > > Best regards…Paul > > > > *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On > Behalf

Re: [Wireshark-dev] Waiting for something to happen on a pipe/socket on Windows

2017-06-27 Thread Roland Knall
This is one of the best and most comprehensive explanations for Windows sockets I read so far. @Stig - You could take a look at extcap_spawn.c, there you will find code, also in extcap.c for implementing waiting on that thing, Windows likes to call a "Named Pipe" cheers, Roland On Tue, Jun 27, 2

Re: [Wireshark-dev] New file show up once compilation is over in master

2017-06-29 Thread Roland Knall
Yeap. I'll do that, with the next iteration of the patchset for the Mac Drag/Drop crash. While you're add it, that allows the display filter buttons to be moved via drag and drop ;-) On Thu, Jun 29, 2017 at 10:33 AM, Remy Leone wrote: > Hello, > > I got this file showing up once master is done

Re: [Wireshark-dev] Using /var/tmp instead of /tmp

2017-06-29 Thread Roland Knall
Not sure why, because the two temp directories are different. Judging by https://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard /tmp is usually purged during a reboot (at least you cannot expect to survive it) /var/tmp is not purged during a reboot The Qt::Dir() related stuff is actually a

Re: [Wireshark-dev] Checking for Qt in a dissector

2017-07-03 Thread Roland Knall
If you just need it for the code showing some toolkit function or plugin functionality, there is an example code in the pluginifdemo for that. As the guys said, it cannot be done from the dissector itself, as this will need some sort of reference from libwireshark, and that is a very bad idea. Ro

Re: [Wireshark-dev] Checking for Qt in a dissector

2017-07-04 Thread Roland Knall
Hi Paul I know what you want to achieve, but I really think this way around it is a very bad idea (as I mentioned in the past). The plugin-dissector code still runs in the epan context, and there it does not have a Qt reference it can apply for. The GUI part of the plugin is another question, but

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

2017-07-05 Thread Roland Knall
Hi Paul You have a merge branch in between two syncro branches. That happens, when you are not working cleanly of branches, but instead pull changes into the master branch. Take a look at git log You should see your Syncro at the top, then a merge-branch and then again a syncro at the bottom. T

Re: [Wireshark-dev] Alternatives to atoi and tolower

2017-07-07 Thread Roland Knall
More generic answer, please always take a look in wsutil and glib documentation for things like that. Those functions are usually accepted (with a few exceptions in glib I think). cheers Roland On Fri, Jul 7, 2017 at 10:08 AM, Pascal Quantin wrote: > Hi Paul, > > 2017-07-07 10:03 GMT+02:00 Paul

Re: [Wireshark-dev] Using Google Protobuf to Export Full Packet Dissection Data via Named Pipe

2017-07-11 Thread Roland Knall
Did you take a look at tshark's -T parameter? "tshark -T jsonraw" for instance, delivers full dissection in Json format. What would be needed is only to shove that into a pipe to capture from some other place. Cheers Roland On Tue, Jul 11, 2017 at 2:48 PM, Mark Landriscina wrote: > > Apologies

Re: [Wireshark-dev] Dissector for link layer to run before ethernet one

2017-07-20 Thread Roland Knall
If the header is always identifiable easily, you could write a heuristic dissector for "frame" and work from there. cheers Roland On Thu, Jul 20, 2017 at 1:47 PM, Mihai Cîrîc via Wireshark-dev < wireshark-dev@wireshark.org> wrote: > Hello all, > > I have some capture files with packets encapsula

Re: [Wireshark-dev] Problem while compiling wireshark master

2017-07-24 Thread Roland Knall
Hi This is not an issue with wireshark code, but rather with the version of flex used by the compiler. See https://github.com/westes/flex/commit/8c098febc9a599397921e9b6938b7fb85e38cc7e for a commit fixing this issue, but so far Ubuntu does not ship the right version of flex to fix the warning. c

Re: [Wireshark-dev] Problem while compiling wireshark master

2017-07-24 Thread Roland Knall
Ah, sorry, overlooked that cheers On Mon, Jul 24, 2017 at 10:01 AM, Alexis La Goutte < alexis.lagou...@gmail.com> wrote: > > > On Mon, Jul 24, 2017 at 9:48 AM, Roland Knall wrote: > >> Hi >> >> This is not an issue with wireshark code, but rather wit

[Wireshark-dev] Qt Polution of PacketList, PacketTree and ByteView

2017-07-24 Thread Roland Knall
Hi One of the most often requested features is the possibility to load more then one trace at the same time aka. make Wireshark multi-document enabled. One of the biggest hassles UI-wise with that is, that at the moment we rely to strongly on the tight integration of MainWindow, PacketList, Packe

Re: [Wireshark-dev] MacOS 10.13 Beta (17A306f)

2017-07-24 Thread Roland Knall
Hi Simon New Mac (and more specifically XCode) versions are always tricky. If you havn't already, could you add the crash report? Which Qt versions and XCode versions are you using? So far I cannot find this issue in the Qt bugs list, and the crash report would help loads. cheers Roland On Mo

[Wireshark-dev] Wireshark support for Qt4.8

2017-07-24 Thread Roland Knall
Hi Wireshark master currently does not build with Qt 4.8. The reason for that, can be seen in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13909 These issues should be fixed in the near future. But it raises the bigger topic, if Qt 4.8 should be supported in whatever version comes after 2

Re: [Wireshark-dev] Conditional compilation (debug)

2017-07-28 Thread Roland Knall
I would not distinguish between self-builds and buildbot builds. There are extcap developers out there, who use the released Wireshark version to develop extcap interfaces and also would benefit greatly from using such debug scenarios. And I would not want to tell them to explicitly build a develop

Re: [Wireshark-dev] Master build fails without pcap

2017-07-28 Thread Roland Knall
I am currently on it. Apparently I invoked a hidden bug in HAVE_PCAP availability. Cheers > Am 28.07.2017 um 00:15 schrieb Gisle Vanem : > > Dario Lombardo wrote: > > > The current master can't build if we disable PCAP in cmake. > > I can't be build if HAVE_EXTCAP is not defined either > >

Re: [Wireshark-dev] Making oui_base_custom available more generally

2017-08-19 Thread Roland Knall
Which OUI are we talking about? Generally speaking, a wsutil/oui_handler.? could be useful, as for instance, openSAFETY uses OUI-24 as well. So it could be made the case, to move the OUI handling outside of the dissector and into a generic wsutil or epan structure. cheers, Roland On Sat, Aug 19,

Re: [Wireshark-dev] Plugin installation path

2017-09-08 Thread Roland Knall
+1 But we might need a build step in the PD to enforce that fact. And have a closer eye on API changes to ensure no incompatibility may occur. Regards Roland > Am 09.09.2017 um 00:44 schrieb João Valverde > : > > Hi, > > If I'm not mistaken we have a policy of binary compatibility betwee

Re: [Wireshark-dev] XXXX: avoid appending xxxx multiple times to frame.protocols field

2017-10-05 Thread Roland Knall
Personally I think moving to a set would reduce functionality for some applications. Industrial ethernet applications for instance heavily rely on multiple protocols being transported in single frames multiple times (one UDP packet contains a lot of openSAFETY frames, which themselve could contain

Re: [Wireshark-dev] XXXX: avoid appending xxxx multiple times to frame.protocols field

2017-10-06 Thread Roland Knall
protocols can be seen on the overlying fieldbus in a single packet. cheers On Fri, Oct 6, 2017 at 8:55 AM, Guy Harris wrote: > On Oct 5, 2017, at 11:23 PM, Roland Knall wrote: > > > Personally I think moving to a set would reduce functionality for some > applications. Indu

Re: [Wireshark-dev] XXXX: avoid appending xxxx multiple times to frame.protocols field

2017-10-06 Thread Roland Knall
AM, Roland Knall wrote: > > > Yeap, that is exactly the case with for instance openSAFETY. Usually a > list would be eth:epl:opensafety|opensafety|opensafety (using | to better > define the parrallel behavior). > > And there's code tha

Re: [Wireshark-dev] Tips regarding measuring function execution times

2017-10-15 Thread Roland Knall
Keep in mind, that printf is by far one of the slowest functions. Additionally it slows also down the output as well. I'd recommend writing the times into a buffer and dumping them in intervalls, very much like the tap's work, otherwise what you see might not be what is happening on the network. c

Re: [Wireshark-dev] Tips regarding measuring function execution times

2017-10-15 Thread Roland Knall
imers but I’ll have to > use C++ to get access to those. > > > > Best regards….Paul > > > > *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On > Behalf Of *Roland Knall > *Sent:* 16 October 2017 05:38 > > *To:* Developer support list for

  1   2   3   4   5   >