Re: [Wireshark-dev] [Wireshark-commits] master d347091: Qt: Fix MacOSX menu entries

2018-04-09 Thread Roland Knall
There is general support for dropping autotools on master (after fixing the rpm build). But I'll rewrite the patches for 2.4 and 2.6 to add a compile switch, so that the patch only applies if it is build with cmake. Adding Objective-C builds to auto tools seems pointless at this point, to me at

Re: [Wireshark-dev] [Wireshark-commits] master d347091: Qt: Fix MacOSX menu entries

2018-04-09 Thread Anders Broman
Den tis 10 apr. 2018 03:50Guy Harris skrev: > On Apr 9, 2018, at 8:44 AM, Wireshark code review < > code-review-do-not-re...@wireshark.org> wrote: > > > URL: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d347091da962a3bb095c62339fc6faa07d189a9f > >

Re: [Wireshark-dev] [Wireshark-commits] master d347091: Qt: Fix MacOSX menu entries

2018-04-09 Thread Guy Harris
On Apr 9, 2018, at 8:44 AM, Wireshark code review wrote: > URL: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d347091da962a3bb095c62339fc6faa07d189a9f > Submitter: Roland Knall (rkn...@gmail.com) > Changed: branch: master >