On Sat, 05 Oct 2013, SJS escribió:
begin quoting Iain Patterson as of Sat, Oct 05, 2013 at 11:36:00AM +0100:
Quoth Carlos R. Mafra,
switchpanel.c: In function 'wSwitchPanelSelectFirst':
switchpanel.c:673:18: warning: variable 'tmpwin' set but not used
[-Wunused-but-set-variable]
On Sun, 6 Oct 2013 at 10:42:06 +0200, Rodolfo García Peñas wrote:
On Sat, 05 Oct 2013, SJS escribió:
begin quoting Iain Patterson as of Sat, Oct 05, 2013 at 11:36:00AM +0100:
Quoth Carlos R. Mafra,
switchpanel.c: In function 'wSwitchPanelSelectFirst':
switchpanel.c:673:18:
The variable keymove_tick is set, but is never used after, so can
be removed.
kix@osaka:~/src/wmaker/git/wmaker-crm/src$ grep keymove_tick *[ch]
moveres.c: scr-keymove_tick = 0;
screen.h:int keymove_tick;
kix@osaka:~/src/wmaker/git/wmaker-crm/src$
Signed-off-by: Rodolfo
The argument WScreen is removed in the functions
wSessionClearState() and getWindowState()
Signed-off-by: Rodolfo García Peñas (kix) k...@kix.es
---
src/rootmenu.c | 4 ++--
src/session.c | 6 +++---
src/session.h | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git
The application icon list is moved to w_global.
Signed-off-by: Rodolfo García Peñas (kix) k...@kix.es
---
src/WindowMaker.h | 3 +++
src/actions.c | 3 +--
src/appicon.c | 13 ++---
src/defaults.c| 3 +--
src/dock.c| 3 +--
src/main.c| 3 ---
6 files
The variable wapp_list is never set, then the comparison with
wapp is only true if wapp is NULL. wapp can not be NULL in the
function wApplicationDestroy() because is tested previously.
Signed-off-by: Rodolfo García Peñas (kix) k...@kix.es
---
src/application.c | 19 +--
The variable shortcutWindows is moved to w_global. Now, the shortcuts
are used in whole Window Maker, not only in the current screen.
Signed-off-by: Rodolfo García Peñas (kix) k...@kix.es
---
src/WindowMaker.h | 3 +++
src/event.c | 27 ---
src/screen.h | 4
The variable session_state, defined in screen.h (WScreen), is moved to
the global variable w_global.
Signed-off-by: Rodolfo García Peñas (kix) k...@kix.es
---
src/WindowMaker.h | 3 +++
src/dock.c| 12 +---
src/menu.c| 7 +++
src/screen.c | 31
On Mon, 30 Sep 2013 09:01:10 +0200
Carlos R. Mafra crma...@gmail.com wrote:
In my case I also undock things without using Alt, so this is not
really about being consistent.
Right, appicons are non-running apps are easy to remove. Running
ones require pressing Alt to undock them.
We need the