On Mon, 30 Sep 2013 09:01:10 +0200 "Carlos R. Mafra" <[email protected]> wrote:
> In my case I also undock things without using Alt, so this is not > really about being consistent. Right, appicons are non-running apps are "easy to remove". Running ones require pressing Alt to undock them. > We need the old behavior back because people depend on it. I agree with the principle and I must confess I totally forgot the case of running applets (cf. Rodolfo's email). It is true that it can be hard to click on an non-active area of some applet. Pressing alt when clicking is a great way to ensure the click is not passed to the applet but used for moving it. > Was this Mod1 handling a fundamental part of the drawers design or > can you simply revert this part without much hassle? The change in behavior is not geared towards drawers and I believe it is easy to reproduce the old behavior. Currently, moving while (ev.xmotion.state & MOD_MASK) prevents any docking. That boolean could be ignored if originalDock is NULL (i.e., moving an undocked app with Alt still allows docking). I'll refrain from proposing a patch at that late hour. Perhaps tomorrow evening? In the meantime, note that you can still dock an undocked applet after you initiated the move by pressing Alt: just _release_ Alt while dragging. > In hindsight, that huge patch probably should have been split. It > would make things easier now. Gradually make the two functions identical, and merge them only when they are? Granted, that would have been best. FWIW, the commit message lists two known differences and the first one meant to describe what we are discussing here (no, it is not very clear). -- Daniel, who is semi-seriously considering inserting a line reading "sorry for the delay in my answers" in his signature :) -- To unsubscribe, send mail to [email protected].
