One question inline
Diff comments:
> diff --git a/src/charm.py b/src/charm.py
> index a7234e0..c8958f1 100755
> --- a/src/charm.py
> +++ b/src/charm.py
> @@ -242,6 +242,8 @@ class WordpressCharm(CharmBase):
> "ingressResources": [
> {
>
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/426107
Your team Wordpress Charmers is subscribed to branch
charm-k8s-wordpress:container-hardening.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to
A few comments inline, but also just wondering why you're merging this into a
different branch than the current master?
Diff comments:
> diff --git a/Dockerfile b/Dockerfile
> index a338c56..e2451e0 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -35,85 +46,141 @@ RUN apt-get update &&
The proposal to merge ~jsimpso/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~jsimpso/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/420141
--
Your team Wordpress Charmers
Review: Approve
LGTM
--
https://code.launchpad.net/~jsimpso/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/420141
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
The proposal to merge ~jsimpso/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~jsimpso/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/419738
--
Your team Wordpress Charmers
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~jsimpso/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/419738
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
John Meinel has confirmed we seem to be doing it right. I suspect we should
just comment out the portion that's trying to call the config-changed hook for
now and rely on update-status to apply this within 5 minutes (or an operator
can trigger an update-status hook to apply immediately). A
I've tested this locally and this is missing the following to actually trigger
the code when we run the action: https://pastebin.ubuntu.com/p/jrFcZj8Ds4/
However, with that added and running the action I get the following
https://pastebin.ubuntu.com/p/RVxnJM6p6D/. However, the next time the
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:charmcraft into
charm-k8s-wordpress:master.
Commit message:
Create a charmcraft.yaml file so we can pack the charm using charmcraft
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~sajoupa/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/414465
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Also alpha sorting of annotation keys in tests pls.
Diff comments:
> diff --git a/tests/unit/test_charm.py b/tests/unit/test_charm.py
> index 7606877..e4af690 100644
> --- a/tests/unit/test_charm.py
> +++ b/tests/unit/test_charm.py
> @@ -133,6 +133,11 @@ class
Review: Approve
LGTM, but could you update the commit message to say you're optionally adding
this module, since it requires the MODSEC build argument to be set?
--
https://code.launchpad.net/~sajoupa/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/414357
Your team Wordpress Charmers is
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/408724
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Some comments inline. Looks like there's a text conflict in the Dockerfile,
fwiw.
Diff comments:
> diff --git a/README.md b/README.md
> index d6e4fa4..b2b4d3f 100644
> --- a/README.md
> +++ b/README.md
> @@ -19,11 +19,13 @@ details on using Juju with MicroK8s for easy local
> testing [see
The proposal to merge ~tcuthbert/charm-k8s-wordpress:sidecar into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/404135
--
Your team
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/403642
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
I think I'm still a bit confused as to what the long term plan for this branch
is. How will this be possible via charm config? fetcher.py is a script run to
build the OCI image, so I don't see how we can use charm config here, or are
you saying that we'll eventually also call it at run time
The proposal to merge ~tcuthbert/charm-k8s-wordpress:sidecar into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/403361
--
Your team
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:rename-charm into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:rename-charm into
charm-k8s-wordpress:master.
Commit message:
Rename the charm to wordpress-k8s to avoid collision with machine charm
Requested reviews:
Canonical IS Reviewers (canonical-is-reviewers
The proposal to merge ~tcuthbert/charm-k8s-wordpress:ss-backends into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/401225
--
Your team
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/401225
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:maridb-charmhub into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:maridb-charmhub into
charm-k8s-wordpress:master.
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:test-coverage into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:use-leadership-interface
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:end-user into
charm-k8s-wordpress:master.
Commit message:
Update docs to be more end-user focused, refer to discourse-based docs, and use
correct casing of WordPress
Requested reviews:
Canonical
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:maintenance-status into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Added some comments inline.
Diff comments:
> diff --git a/src/charm.py b/src/charm.py
> index f1a2252..5d9f4e9 100755
> --- a/src/charm.py
> +++ b/src/charm.py
> @@ -85,6 +86,10 @@ def gather_wordpress_secrets():
> return rv
>
>
> +def split_additional_hostnames(hostnames):
> +
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:maintenance-status into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-not-tls into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Thx for the comment. Leaving as is for consistency with other tests, but will
possibly revisit those all in a follow up.
--
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396185
Your team Wordpress Charmers is subscribed to branch
Review: Approve
Looks good, with one comment about alphabetising requirements.txt.
Diff comments:
> diff --git a/requirements.txt b/requirements.txt
> index 875fb9a..52d0cf0 100644
> --- a/requirements.txt
> +++ b/requirements.txt
> @@ -1,3 +1,4 @@
> # Include python requirements here
> ops
>
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-not-tls into
charm-k8s-wordpress:master has been updated.
Description changed to:
Don't force TLS on the admin site if we don't have a tls_secret_name
configured, to avoid one step in local set up
For more
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-not-tls into
charm-k8s-wordpress:master has been updated.
Commit message changed to:
Don't force TLS on the admin site if we don't have a tls_secret_name
configured, to avoid one step in local set up
For more
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-not-tls into
charm-k8s-wordpress:master.
Commit message:
Don't force TLS on the admin site if don't have a tls_secret_name configured,
to avoid one step in local set up
Requested reviews:
Canonical
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:focal-image into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396179
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:focal-image into
charm-k8s-wordpress:master.
Commit message:
Fix docker entrypoint to work for bionic or focal
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge ~stub/charm-k8s-wordpress:mysql-relation into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~stub/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395826
--
Your team Wordpress
The proposal to merge ~stub/charm-k8s-wordpress:mysql-relation into
charm-k8s-wordpress:master has been updated.
Status: Merged => Needs review
For more details, see:
https://code.launchpad.net/~stub/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395826
--
Your team Wordpress Charmers
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:end-user into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Work in progress
For more details, see:
Review: Approve
Looks great, thanks, and have tested locally.
--
https://code.launchpad.net/~stub/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395826
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list:
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:optional-tls into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Some inline comments, and you have a test failure in test_is_config_valid.
Haven't tested yet, but will do so shortly.
Diff comments:
> diff --git a/src/charm.py b/src/charm.py
> index edade47..efe9026 100755
> --- a/src/charm.py
> +++ b/src/charm.py
> @@ -115,20 +117,20 @@ class
Tom Haddon has proposed merging ~stub/charm-k8s-wordpress:mysql-relation into
charm-k8s-wordpress:master.
Commit message:
Implement a MySQL database relation
The database connection details from the relation will
override any provided in the charm configuration.
Requested reviews:
Wordpress
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
into charm-k8s-wordpress:master.
Commit message:
Add an action to retrieve initial password
Requested reviews:
Canonical IS Reviewers (canonical-is-reviewers)
Wordpress Charmers
This action can now be run from any unit.
--
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395982
Your team Wordpress Charmers is requested to review the proposed merge of
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Work in progress
For more details, see:
There's actually a problem with this. We need to use leadership data (or a peer
relation) since StoredState is per unit.
--
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395982
Your team Wordpress Charmers is requested to review the proposed merge of
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:maintenance-status into
charm-k8s-wordpress:master.
Commit message:
Fix unit status to stay in 'active' once configured
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:optional-tls into
charm-k8s-wordpress:master.
Commit message:
Make tls_secret_name optional to avoid one step in local dev setup
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:end-user into
charm-k8s-wordpress:master.
Commit message:
Update docs to be more end-user focused, refer to discourse-based docs, and use
correct casing of WordPress
Requested reviews:
Wordpress Charmers
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
into charm-k8s-wordpress:master.
Commit message:
Add an action to retrieve initial password
Requested reviews:
Wordpress Charmers (wordpress-charmers)
Related bugs:
Bug #1907063
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395944
--
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into
charm-k8s-wordpress:master.
Commit message:
Switch to version 5.6 as the default image, make the deployment process easier
by setting some config defaults
Requested reviews:
Canonical
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Work in progress
For more details, see:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into
charm-k8s-wordpress:master.
Commit message:
Switch to version 5.6 as the default image, make the deployment process easier
by setting some config defaults
Requested reviews:
Wordpress
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-version into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Thanks for the comments. I think those can be addressed in a separate MP so
I'll merge this for now and address those separately.
--
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395494
Your team Wordpress Charmers is subscribed to branch
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-version into
charm-k8s-wordpress:master.
Commit message:
Download a specific version rather than just 'latest' - this will make it more
obvious when to upgrade. Will also update OCI Recipe to if/once
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/394940
--
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme into
charm-k8s-wordpress:master.
Commit message:
Update README to be more end-user focused, showing initial deployment steps up
front
Requested reviews:
Wordpress Charmers (wordpress-charmers
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-builder-tests into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-builder-tests into
charm-k8s-wordpress:master.
Commit message:
Updates tests to pass since merging image-building branch
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394793
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:icon into
charm-k8s-wordpress:master.
Commit message:
Add icon
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress
The proposal to merge ~tcuthbert/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394731
--
Your team Wordpress
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394731
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/394385
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
The proposal to merge ~tcuthbert/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394229
--
Your team Wordpress
Review: Approve
LGTM
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394229
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/393590
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/393537
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Two small comments inline, otherwise looks good.
Diff comments:
> diff --git a/requirements.txt b/requirements.txt
> index 888e37a..addda44 100644
> --- a/requirements.txt
> +++ b/requirements.txt
> @@ -1,2 +1,3 @@
> # Include python requirements here
> requests
> +ops
This should be before
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:tox into
charm-k8s-wordpress:master.
Commit message:
Move flake8 hints from lint tox target to flake8 so editors will pick up on them
Requested reviews:
Canonical IS Reviewers (canonical-is-reviewers
Review: Approve
LGTM, thx. We'll want to come back and figure out how to use a temporary
directory rather than hard coding a path in /tmp, but this is fine for now.
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/386800
Your team Wordpress Charmers
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:wordpress_plugin_integration
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Let's update it from /tmp/.tox to minimise possible collisions
Diff comments:
> diff --git a/Makefile b/Makefile
> index cf18918..a4853e1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,16 +1,24 @@
> -lint:
> +format:
> @echo "Normalising python layout with black."
> @tox -e black
>
Looks good, one small typo inline (akismit vs. akismet). I think we'll just
need to document how you run these tests (against an already deployed
environment and with some files in a folder that's exported as WORKSPACE env
dir?).
Diff comments:
> diff --git
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Commit message changed to:
WP_HTTP_BLOCK_EXTERNAL is blocking akismet from contacting the anti
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
LGTM
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/386370
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
Review: Needs Fixing
Let's add a test for this, ideally for the make_pod_resources method as a whole.
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/386302
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing
Review: Approve
LGTM
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385482
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385482
--
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
LGTM
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/385089
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384611
--
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384611
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Review: Needs Fixing
We should block if tls_secret_name isn't set.
Diff comments:
> diff --git a/src/charm.py b/src/charm.py
> index 46ad990..947dd6a 100755
> --- a/src/charm.py
> +++ b/src/charm.py
> @@ -156,6 +158,39 @@ class WordpressK8sCharm(CharmBase):
> else:
>
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/384526
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384527
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Review: Needs Fixing
This seems to be using a config option that doesn't exist yet (probe_regex).
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384516
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383718
--
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383718
--
1 - 100 of 146 matches
Mail list logo
