Re: [wsjt-devel] Bug in qra64.c

2019-01-09 Thread Nico Palermo
> We could enable -Werror by default :) > That would be great indeed, Richard. I must remind myself to do it always ;-) 73 Nico / IV3NWV ___ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net

Re: [wsjt-devel] Bug in qra64.c

2019-01-09 Thread Richard Shaw
On Tue, Jan 8, 2019 at 10:45 PM Nico Palermo wrote: > if ((x[9]&0x80)==1) >> return; >> warning: bitwise comparison always evaluates to false > > > Nothing really important but I would have appreciated more a warning like > this: > > warning: bitwise comparison always evaluates to false,

Re: [wsjt-devel] Bug in qra64.c

2019-01-08 Thread Nico Palermo
> > if ((x[9]&0x80)==1) > return; > warning: bitwise comparison always evaluates to false Nothing really important but I would have appreciated more a warning like this: warning: bitwise comparison always evaluates to false, therefore I will refuse to compile this source code until you

Re: [wsjt-devel] Bug in qra64.c

2019-01-08 Thread Joe Taylor
Thanks, Ashley! I guess that error has been in qra64.c for a long time, without anyone noticing. ;-) -- Joe, K1JT On 1/8/2019 2:55 AM, Ashley Brighthope wrote: Hi, i noticed during compiling the source of 784f75 master

[wsjt-devel] Bug in qra64.c

2019-01-08 Thread Ashley Brighthope
Hi, i noticed during compiling the source of 784f75 master https://sourceforge.net/p/wsjt/wsjtx/ci/master/tree/lib/qra/qra64/qra64.c:245 if ((x[9]&0x80)==1) return; warning: bitwise comparison always evaluates to false guessing it should be if (x[9]&0x80) return;