Re: [wsjt-devel] Omnirig 1.19 & WSJT-X 2.0.1 55 Hz artifact

2019-05-18 Thread Alex, VE3NEA

Hello,

I emailed BillG4WJS yesterday and explained why this happens. I have not heard 
from him yet, so here is a copy of my message.

73 Alex VE3NEA


Hi Bill,

I released OmniRig 1.19 about a month ago, this version solves a few problems that I faced when I started to use WSJT-X with my 
new IC-7610 radio.


One problem was a slow T/R switching. WSJT-X sends multiple redundant commands to OmniRig that set the properties to the same 
value that is already set. These commands have no effect, but they take time, especially if a CAT timeout occurs. I had 
intermittent T/R delays of up to 2-3 seconds. I changed the code in OmniRig so that a CAT command is not sent to the radio if it 
does not change the current value, and this dramatically improved the response time.


Another problem was the mode change, WSJT-X changed the mode of one VFO but not 
of the other. This happened because of this code:

  if (writable_params_ & OmniRig::PM_VFOEQUAL)
{
  // nothing to do here because OmniRig will use VFO
  // equalize to set the mode of the Tx VFO for us
}

This assumption does not hold for all radios. To solve this, I have added an option that sets the mode for both VFO's when the 
Mode property is assigned a value. This option is controlled by a setting in the configuration file.


These changes solved the problems that I had with WSJT-X and my radio, but there is still a small glitch that was recently 
reported by a user. The code that adds 55 Hz to the frequency reads the frequency back immediately instead of waiting for a 
param change event, as a result it determines the resolution incorrectly, and with the new OmniRig it does not even undo the 
frequency change because it tries to set the frequency to the same value that it already has.


Let us work together to fix the remaining problems, and perhaps simplify the WSJT-X code using the new features of OmniRig. You 
can see my changes to the OmniRig code here:


https://github.com/VE3NEA/OmniRig/commits/master

73 Alex VE3NEA






On 2019-05-18 08:22, Black Michael via wsjt-devel wrote:

If it works in 1.16 and doesn't in 1.19 then it would seem to be OmniRig and 
not WSJT-X.  Alex must've broken it.

That frequency test has been in there for quite a while (a couple years perhaps?) and nobody else has this problem.  It would 
indicate OmniRig is dropping the frequency change request to return to the requested frequency.



de Mike W9MDB




On Saturday, May 18, 2019, 6:55:01 AM CDT, Mike  wrote:


I am forwarding this conversation to amke sure you all know about this ...

I was running Omnirig 1.16 for years. I saw there was a new version (1.19) so installed it. Have two rigs in use in Omnirig: 
FT-450D & IC-7300. Were no problems before with Omnirig or the communications to/from the radios.


Now with the new 1.19, suppose the FT-450D is turned on and it's freq. display reads 50.313.00. When I start WSJT-X using the 
new Omnirig it changes the frequency to 50.313.05 on the radio display, and WSJT-X shows it's 50.313 055. If I use WSJT-X to 
change bands the "55" Hz never shows up again no mater what band I go to. But shut it all down and start over, same thing 
happens.  55 Hz is added to the freq, of the FT-450D.


On the IC-7300, same thing happens at first BUT - I can see the display briefly flash an extra 55 Hz on the display, then it 
goes to the correct frequency in an instant most of the time. However, this morning it kept the extra 55 Hz on the display of 
the IC-7300. Changing bands causes the 55 Hz to go away from then on (for that operating session) like the FT-450D.


If I go back to the .exe for Omnirig 1.16 - the problems all go away and all radios act perfectly fine just as they always did 
for years. I did not change any settings when I switched to the new version to cause this. However; after I observed it happen 
with 1.19 I tried to change various settings such as baud rate (also for the radios), time out and other items to no avail. In 
any case it does NOT happen when I go back to Omnirig 1.16. Even with different settings. Omnirig 1.16 causes no problems at all.


I wrote the developer of Omnirig and got this response -

Hi Mike,

Thank you for reporting the problem. The frequency change by 55 Hz is not a 
bug, WSJTX makes this change on startup to determine
the frequency change step of the radio. The program is supposed to undo the 
change, but for some reason this does not happen. I
will contact the WSJTX developers to see how we can fix this.

Please note that I released OmniRig 1.19 in order to fix some serious problems 
that WSJTX had with the old version. These
problems are now fixed, but the glitch you have reported still requires 
correction.

73 Alex VE3NEA
___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net 

Re: [wsjt-devel] Omnirig 1.19 & WSJT-X 2.0.1 55 Hz artifact

2019-05-18 Thread Bill Somerville

On 18/05/2019 14:04, Black Michael via wsjt-devel wrote:


If Alex sets the frequency or mode on the rig then either change the 
internal state to reflect that or re-read the rig immediately.


Mike,

that's not how Omni-Rig works.

73
Bill
G4WJS.



___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel


Re: [wsjt-devel] Omnirig 1.19 & WSJT-X 2.0.1 55 Hz artifact

2019-05-18 Thread Black Michael via wsjt-devel
I ran into a similar race condition in FLRig with set_mode and Dave fixed FLRig.
If Alex sets the frequency or mode on the rig then either change the internal 
state to reflect that or re-read the rig immediately.
de Mike W9MDB


 

On Saturday, May 18, 2019, 7:59:43 AM CDT, Bill Somerville 
 wrote:  
 
 On 18/05/2019 12:47, Mike wrote:
> Now with the new 1.19, suppose the FT-450D is turned on and it's freq. 
> display reads 50.313.00. When I start WSJT-X using the new Omnirig it 
> changes the frequency to 50.313.05 on the radio display, and WSJT-X 
> shows it's 50.313 055. If I use WSJT-X to change bands the "55" Hz 
> never shows up again no mater what band I go to. But shut it all down 
> and start over, same thing happens.  55 Hz is added to the freq, of 
> the FT-450D.

Hi Mike,

Alex has contacted me explaining the issues, I am investigating a fix. 
For now when you start up WSJT-X, switch configurations, or do anything 
that resets the CAT interface; then make sure the VFO dial frequency is 
correct.

The problem is that WSJT-X makes a small frequency change to determine 
the rig's VFO frequency resolution, via Omni-Rig it is reading back the 
frequency set too quickly and Omni-Rig has not yet re-read the rig's 
changed state. It should not affect normal operation.

73
Bill
G4WJS.



___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
  ___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel


Re: [wsjt-devel] Omnirig 1.19 & WSJT-X 2.0.1 55 Hz artifact

2019-05-18 Thread Black Michael via wsjt-devel
I never got OmniRig to behave for me.  I just tested 1.18 on my system and it 
works just fine.  Installed 1.19 and can't get it to behave at all.
I now use FLRig and have WSJT-X, Log4OM, FLDigi, a custom tuner utility, and 
another project under development all talking to FLRig at the same time without 
any problems.
Any particular reason you're using OmniRig?
de Mike W9MDB

 

On Saturday, May 18, 2019, 7:29:23 AM CDT, Mike  
wrote:  
 
 Well, that's not what he says and I have no idea, I'm just reporting the 
issue. He said he'd be in touch with your developers. I just want to make sure 
it's been seen. Thanks.

On Sat, May 18, 2019 at 7:27 AM Black Michael via wsjt-devel 
 wrote:

If it works in 1.16 and doesn't in 1.19 then it would seem to be OmniRig and 
not WSJT-X.  Alex must've broken it.
That frequency test has been in there for quite a while (a couple years 
perhaps?) and nobody else has this problem.  It would indicate OmniRig is 
dropping the frequency change request to return to the requested frequency.

de Mike W9MDB

 

On Saturday, May 18, 2019, 6:55:01 AM CDT, Mike  
wrote:  
 
 I am forwarding this conversation to amke sure you all know about this ...

I was running Omnirig 1.16 for years. I saw there was a new version (1.19) so 
installed it. Have two rigs in use in Omnirig: FT-450D & IC-7300. Were no 
problems before with Omnirig or the communications to/from the radios.

Now with the new 1.19, suppose the FT-450D is turned on and it's freq. display 
reads 50.313.00. When I start WSJT-X using the new Omnirig it changes the 
frequency to 50.313.05 on the radio display, and WSJT-X shows it's 50.313 055. 
If I use WSJT-X to change bands the "55" Hz never shows up again no mater what 
band I go to. But shut it all down and start over, same thing happens.  55 Hz 
is added to the freq, of the FT-450D.

On the IC-7300, same thing happens at first BUT - I can see the display briefly 
flash an extra 55 Hz on the display, then it goes to the correct frequency in 
an instant most of the time. However, this morning it kept the extra 55 Hz on 
the display of the IC-7300. Changing bands causes the 55 Hz to go away from 
then on (for that operating session) like the FT-450D.

If I go back to the .exe for Omnirig 1.16 - the problems all go away and all 
radios act perfectly fine just as they always did for years. I did not change 
any settings when I switched to the new version to cause this. However; after I 
observed it happen with 1.19 I tried to change various settings such as baud 
rate (also for the radios), time out and other items to no avail. In any case 
it does NOT happen when I go back to Omnirig 1.16. Even with different 
settings. Omnirig 1.16 causes no problems at all.

I wrote the developer of Omnirig and got this response -

Hi Mike,

Thank you for reporting the problem. The frequency change by 55 Hz is not a 
bug, WSJTX makes this change on startup to determine
the frequency change step of the radio. The program is supposed to undo the 
change, but for some reason this does not happen. I
will contact the WSJTX developers to see how we can fix this.

Please note that I released OmniRig 1.19 in order to fix some serious problems 
that WSJTX had with the old version. These
problems are now fixed, but the glitch you have reported still requires 
correction.

73 Alex VE3NEA
___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
  ___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel

  ___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel


Re: [wsjt-devel] Omnirig 1.19 & WSJT-X 2.0.1 55 Hz artifact

2019-05-18 Thread Bill Somerville

On 18/05/2019 12:47, Mike wrote:
Now with the new 1.19, suppose the FT-450D is turned on and it's freq. 
display reads 50.313.00. When I start WSJT-X using the new Omnirig it 
changes the frequency to 50.313.05 on the radio display, and WSJT-X 
shows it's 50.313 055. If I use WSJT-X to change bands the "55" Hz 
never shows up again no mater what band I go to. But shut it all down 
and start over, same thing happens.  55 Hz is added to the freq, of 
the FT-450D.


Hi Mike,

Alex has contacted me explaining the issues, I am investigating a fix. 
For now when you start up WSJT-X, switch configurations, or do anything 
that resets the CAT interface; then make sure the VFO dial frequency is 
correct.


The problem is that WSJT-X makes a small frequency change to determine 
the rig's VFO frequency resolution, via Omni-Rig it is reading back the 
frequency set too quickly and Omni-Rig has not yet re-read the rig's 
changed state. It should not affect normal operation.


73
Bill
G4WJS.



___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel


Re: [wsjt-devel] Omnirig 1.19 & WSJT-X 2.0.1 55 Hz artifact

2019-05-18 Thread Mike
Well, that's not what he says and I have no idea, I'm just reporting the
issue. He said he'd be in touch with your developers. I just want to make
sure it's been seen. Thanks.

On Sat, May 18, 2019 at 7:27 AM Black Michael via wsjt-devel <
wsjt-devel@lists.sourceforge.net> wrote:

> If it works in 1.16 and doesn't in 1.19 then it would seem to be OmniRig
> and not WSJT-X.  Alex must've broken it.
>
> That frequency test has been in there for quite a while (a couple years
> perhaps?) and nobody else has this problem.  It would indicate OmniRig is
> dropping the frequency change request to return to the requested frequency.
>
>
> de Mike W9MDB
>
>
>
>
> On Saturday, May 18, 2019, 6:55:01 AM CDT, Mike 
> wrote:
>
>
> I am forwarding this conversation to amke sure you all know about this ...
>
> I was running Omnirig 1.16 for years. I saw there was a new version (1.19)
> so installed it. Have two rigs in use in Omnirig: FT-450D & IC-7300. Were
> no problems before with Omnirig or the communications to/from the radios.
>
> Now with the new 1.19, suppose the FT-450D is turned on and it's freq.
> display reads 50.313.00. When I start WSJT-X using the new Omnirig it
> changes the frequency to 50.313.05 on the radio display, and WSJT-X shows
> it's 50.313 055. If I use WSJT-X to change bands the "55" Hz never shows up
> again no mater what band I go to. But shut it all down and start over, same
> thing happens.  55 Hz is added to the freq, of the FT-450D.
>
> On the IC-7300, same thing happens at first BUT - I can see the display
> briefly flash an extra 55 Hz on the display, then it goes to the correct
> frequency in an instant most of the time. However, this morning it kept the
> extra 55 Hz on the display of the IC-7300. Changing bands causes the 55 Hz
> to go away from then on (for that operating session) like the FT-450D.
>
> If I go back to the .exe for Omnirig 1.16 - the problems all go away and
> all radios act perfectly fine just as they always did for years. I did not
> change any settings when I switched to the new version to cause this.
> However; after I observed it happen with 1.19 I tried to change various
> settings such as baud rate (also for the radios), time out and other items
> to no avail. In any case it does NOT happen when I go back to Omnirig 1.16.
> Even with different settings. Omnirig 1.16 causes no problems at all.
>
> I wrote the developer of Omnirig and got this response -
>
> Hi Mike,
>
> Thank you for reporting the problem. The frequency change by 55 Hz is not
> a bug, WSJTX makes this change on startup to determine
> the frequency change step of the radio. The program is supposed to undo
> the change, but for some reason this does not happen. I
> will contact the WSJTX developers to see how we can fix this.
>
> Please note that I released OmniRig 1.19 in order to fix some serious
> problems that WSJTX had with the old version. These
> problems are now fixed, but the glitch you have reported still requires
> correction.
>
> 73 Alex VE3NEA
> ___
> wsjt-devel mailing list
> wsjt-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wsjt-devel
> ___
> wsjt-devel mailing list
> wsjt-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wsjt-devel
>
___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel


Re: [wsjt-devel] Omnirig 1.19 & WSJT-X 2.0.1 55 Hz artifact

2019-05-18 Thread Black Michael via wsjt-devel
If it works in 1.16 and doesn't in 1.19 then it would seem to be OmniRig and 
not WSJT-X.  Alex must've broken it.
That frequency test has been in there for quite a while (a couple years 
perhaps?) and nobody else has this problem.  It would indicate OmniRig is 
dropping the frequency change request to return to the requested frequency.

de Mike W9MDB

 

On Saturday, May 18, 2019, 6:55:01 AM CDT, Mike  
wrote:  
 
 I am forwarding this conversation to amke sure you all know about this ...

I was running Omnirig 1.16 for years. I saw there was a new version (1.19) so 
installed it. Have two rigs in use in Omnirig: FT-450D & IC-7300. Were no 
problems before with Omnirig or the communications to/from the radios.

Now with the new 1.19, suppose the FT-450D is turned on and it's freq. display 
reads 50.313.00. When I start WSJT-X using the new Omnirig it changes the 
frequency to 50.313.05 on the radio display, and WSJT-X shows it's 50.313 055. 
If I use WSJT-X to change bands the "55" Hz never shows up again no mater what 
band I go to. But shut it all down and start over, same thing happens.  55 Hz 
is added to the freq, of the FT-450D.

On the IC-7300, same thing happens at first BUT - I can see the display briefly 
flash an extra 55 Hz on the display, then it goes to the correct frequency in 
an instant most of the time. However, this morning it kept the extra 55 Hz on 
the display of the IC-7300. Changing bands causes the 55 Hz to go away from 
then on (for that operating session) like the FT-450D.

If I go back to the .exe for Omnirig 1.16 - the problems all go away and all 
radios act perfectly fine just as they always did for years. I did not change 
any settings when I switched to the new version to cause this. However; after I 
observed it happen with 1.19 I tried to change various settings such as baud 
rate (also for the radios), time out and other items to no avail. In any case 
it does NOT happen when I go back to Omnirig 1.16. Even with different 
settings. Omnirig 1.16 causes no problems at all.

I wrote the developer of Omnirig and got this response -

Hi Mike,

Thank you for reporting the problem. The frequency change by 55 Hz is not a 
bug, WSJTX makes this change on startup to determine
the frequency change step of the radio. The program is supposed to undo the 
change, but for some reason this does not happen. I
will contact the WSJTX developers to see how we can fix this.

Please note that I released OmniRig 1.19 in order to fix some serious problems 
that WSJTX had with the old version. These
problems are now fixed, but the glitch you have reported still requires 
correction.

73 Alex VE3NEA
___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
  ___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel