Re: [Xen-devel] [PATCH 3/4] docs: add pvscsi.txt

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Juergen Gross wrote: On 03/02/2015 04:14 PM, Olaf Hering wrote: In this case the code which checks pdev usage in libxl_device_vscsi_get_host can just be removed. Hmm, maybe issuing a warning would be a sensible thing to do? This gets us back to square #1 with the question how

[Xen-devel] how to assign resources exclusive to a single domU

2015-02-26 Thread Olaf Hering
While working on pvscsi support for libxl I noticed that assigning a resource exclusivly to just a single domU via libxl will be a major effort. Up to now libxl could rely on the fact that a resource can be either shared or the backend deals with the attempt to share. There are two cases in

Re: [Xen-devel] [PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-02-16 Thread Olaf Hering
On Fri, Feb 13, Ian Jackson wrote: Olaf Hering writes ([PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.): It is already used in the runlevel script and the service file. It is supposed to replace XENSTORED_TRACE= boolean, which cant be easily supported

Re: [Xen-devel] [PATCH 3/3] mini-os: sort objects in binary archives

2015-02-16 Thread Olaf Hering
On Thu, Feb 05, Ian Campbell wrote: On Tue, 2015-02-03 at 12:45 +0100, Olaf Hering wrote: When building stubdom the mini-os objects are also linked into the binary. Unfortunately the linker will place them in the order found in the archive. Since this order is random the resulting stubdom

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-02-11 Thread Olaf Hering
On Wed, Jan 28, Xu, Quan wrote: Thanks, I will check and fix it tomorrow. It is 23:12 PM Pacific time now. Any progress? These typedefs are duplicated in stubdom/vtpmmgr/tcg.h and supported compilers do not cope with current staging: # for i in `grep -w typedef stubdom/vtpmmgr/tcg.h | sed -n

[Xen-devel] [PATCH] tools: require at least pixman 0.21.8 for qemu-xen

2015-02-11 Thread Olaf Hering
] (2) Fetch the pixman submodule, using: [ 211s] git submodule update --init pixman Please run autogen.sh after applying this patch. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com

Re: [Xen-devel] [PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-02-10 Thread Olaf Hering
Ping? On Tue, Feb 03, Olaf Hering wrote: It is already used in the runlevel script and the service file. It is supposed to replace XENSTORED_TRACE= boolean, which cant be easily supported in the xenstored.service file. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack

Re: [Xen-devel] [PATCH v2] Fix building error

2015-02-04 Thread Olaf Hering
On Wed, Feb 04, Jan Beulich wrote: I also checked Python, and they also seem to have been enabling _FORTIFY_SOURCE forever. Consequently, with the previously suggested patches not having found acceptance, how about I'm sure python just carries the CFLAGS used for its build, so that other

Re: [Xen-devel] [PATCH 1/2] hvmloader: remove timestamp from smbios

2015-02-04 Thread Olaf Hering
On Wed, Feb 04, Jan Beulich wrote: http://dmtf.org/sites/default/files/standards/documents/DSP0134_2.8.0.pdf (in particular section 7.1 and table 5) The date string, if supplied, is in either mm/dd/yy or mm/dd/ format. To me it sounds like an optional thing. An empty string is as

[Xen-devel] [PATCH 1/3] docs: create reproducible html

2015-02-03 Thread Olaf Hering
The Makefile uses wildcard to collect a list of files. The resulting list of files is in directory order, which is random. As a result the generated html files will differ when build on different hosts. Use the built-in sort function to get a stable list of files. Signed-off-by: Olaf Hering o

[Xen-devel] [PATCH 2/3] etherboot: [build] sort objects in blib.a

2015-02-03 Thread Olaf Hering
hosts. To help with creating a reproducible binary the elements in blib.a must simply be sorted before passing them to $(AR). Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb

[Xen-devel] [PATCH 0/3] sort various input files for reproducible build

2015-02-03 Thread Olaf Hering
The need for these changes was caught by build-compare, a tool used in openSUSE buildservice which prevents needless rebuilds and needless republish of a package. Olaf Olaf Hering (3): docs: create reproducible html etherboot: [build] sort objects in blib.a mini-os: sort objects in binary

[Xen-devel] [PATCH 1/2] hvmloader: remove timestamp from smbios

2015-02-03 Thread Olaf Hering
Including a timestamp into the binary makes it impossible to get reproducible binaries. Remove the timestamp because it carries no valuable info. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Keir Fraser k...@xen.org Cc: Jan Beulich jbeul...@suse.com Cc: Andrew Cooper andrew.coop...@citrix.com Cc

[Xen-devel] [PATCH 0/2] remove timestamp from hvmloader for reproducible build

2015-02-03 Thread Olaf Hering
Somehow these timestamps got into the tree a long time ago. Now they prevent reproducible hvmloader binaries. Olaf Olaf Hering (2): hvmloader: remove timestamp from smbios hvmloader: remove timestamp from vgabios tools/firmware/hvmloader/Makefile | 1 - tools/firmware/hvmloader/smbios.c

Re: [Xen-devel] [PATCH] docs: create reproducible html

2015-02-03 Thread Olaf Hering
On Tue, Feb 03, Ian Campbell wrote: Would a helper macro so we can just write $(call wildcard,arg arg arg) instead of $(sort $(wildcard arg arg arg)) be possible and/or useful? Just for the or three two places its likely overkill. Olaf

Re: [Xen-devel] [PATCH 3/3] mini-os: sort objects in binary archives

2015-02-03 Thread Olaf Hering
On Tue, Feb 03, Olaf Hering wrote: +++ b/extras/mini-os/Makefile -LWO := $(patsubst %.c,%.o,$(LWC)) +LWO := $(patsubst %.c,%.o,$(LWC) Somehow this brace disappeared. Should I resend or can this be adjusted when the patch gets merged? Olaf

Re: [Xen-devel] [PATCH 1/2] hvmloader: remove timestamp from smbios

2015-02-03 Thread Olaf Hering
On Tue, Feb 03, Andrew Cooper wrote: A release date is part of the SMBIOS spec, and the change below results in a malformed smbios table (stale p-release_date_str = 3; pointer) Good point. Thanks for review. Do you have a pointer to that spec? A better approach would be to derive the date

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Olaf Hering
On Tue, Feb 03, Ian Campbell wrote: Olof, you just removed the nul terminator used there AFAICT. At best this means that the vgabios_copyright is printed twice. My bad. Will resend. Thanks for the review. Olaf ___ Xen-devel mailing list

[Xen-devel] [PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-02-03 Thread Olaf Hering
It is already used in the runlevel script and the service file. It is supposed to replace XENSTORED_TRACE= boolean, which cant be easily supported in the xenstored.service file. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini

[Xen-devel] [PATCH] docs: create reproducible html

2015-02-02 Thread Olaf Hering
The Makefile uses wildcard to collect a list of files. The resulting list of files is in directory order, which is random. As a result the generated html files will differ when build on different hosts. Use the built-in sort function to get a stable list of files. Signed-off-by: Olaf Hering o

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-01-30 Thread Olaf Hering
On Thu, Jan 29, Ian Campbell wrote: This compiles for me on Debian with gcc 4.7.2-5. Same here. I'm honestly not sure what the C standard says about duplicate but identical typedefs -- Ian? How would that matter now? ;-) Old gcc can not deal with it, the commits cause a regression for

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-01-29 Thread Olaf Hering
On Thu, Jan 29, Xu, Quan wrote: Maybe the root cause is the old GCC version in SLE_11_SP3/ openSUSE_11.4, or a CFLAG issue as Ian mentioned to. I can also build a SLE_11_SP3 virtual machine to check it in next week. The CFLAGS are identical, except two -W flags: --- 11.42015-01-29

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-01-29 Thread Olaf Hering
On Thu, Jan 29, Olaf Hering wrote: Looks like old gcc can not handle two typedefs? Yes, this fails already: typedef unsigned char BYTE; typedef unsigned char BYTE; void f(int *v) { *v *= *v; } t.c:2:23: error: redefinition of typedef 'BYTE' t.c:1:23: note: previous declaration of 'BYTE

[Xen-devel] stubdom vtpm build failure in staging

2015-01-28 Thread Olaf Hering
Current staging fails in the install-stubdom target: ... [ 488s] tpm2_types.h:86: error: redefinition of typedef 'BYTE' [ 488s] tcg.h:404: error: previous declaration of 'BYTE' was here [ 488s] tpm2_types.h:87: error: redefinition of typedef 'BOOL' [ 488s] tcg.h:405: error: previous

Re: [Xen-devel] [PATCH] tools/Makefile: fix qemu-xen-traditional build

2015-01-26 Thread Olaf Hering
On Sun, Jan 25, Wei Liu wrote: In d9740237a (tools: unhook blktap1 from the build and remove all references to it), one spot was left unchanged, which leads to failure in building qemu-xen-traditional. Another one. I suspect there is more like that in qemu-xen-traditional. Should I

Re: [Xen-devel] [PATCH v2] Fix building error

2015-01-20 Thread Olaf Hering
On Mon, Jan 19, Ian Campbell wrote: The original patch in 54b73658.6030...@cn.fujitsu.com (correctly IMHO) applied the workaround only to the Python parts of the build (tools/{python,pygrub}) whereas this v2 and your suggestion would affect all of tools/*. That seems like a reasonable

Re: [Xen-devel] [PATCH] Fix building error

2015-01-15 Thread Olaf Hering
On Thu, Jan 15, Wen Congyang wrote: Xen doesn't use the macro _FORTIFY_SOURCE, so it only affects python modules now. It does if it is passed via global CFLAGS, like the RPM_OPT_FLAGS from a rpm package build. Olaf ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH] Fix building error

2015-01-14 Thread Olaf Hering
On Thu, Jan 15, Wen Congyang wrote: Commit 1166ecf7 disables optimization. But python's build process may use CFLAGS -Wp,-D_FORTIFY_SOURCE=2, and suppose the 3rd party python modules to use. The macro _FORTIFY_SOURCE requires compiling with optimization (-O). Disable _FORTIFY_SOURCE by

Re: [Xen-devel] [Xen-users] [TestDay] minor bug + possible configuration bug 4.5rc4 archlinux

2015-01-13 Thread Olaf Hering
On Tue, Jan 13, Doug McMillan wrote: Also quick question if I am understanding my remaining issue [tmpfs: Bad mount option context] as described by a previous thread. Until the code that generates it changes I need to manually change var-lib-xenstored.mount from ... Or am I misunderstanding

Re: [Xen-devel] [Xen-users] [TestDay] minor bug + possible configuration bug 4.5rc4 archlinux

2015-01-13 Thread Olaf Hering
On Mon, Jan 12, Ian Campbell wrote: @devs -- we obviously need to do something about this (too late for 4.5, but for 4.6 + backport). Perhaps there is some alternative systemd construction which disassociates the actual path from the abstract service xenstored dir mounted? I dont think we

Re: [Xen-devel] [PATCH] libxl: provide xenlight.pc

2015-01-13 Thread Olaf Hering
On Tue, Jan 13, Ian Campbell wrote: On Fri, 2015-01-09 at 14:32 +, Wei Liu wrote: A pkg-config file for libxl. It also contains two variables (xenfirmwaredir and libexec_bin) so that tools that are very keen on knowing the locations of Xen binaries (say, libvirt) can use them to

Re: [Xen-devel] preparing for 4.4.2 / 4.3.4

2015-01-12 Thread Olaf Hering
On Thu, Jan 08, Jan Beulich wrote: now that 4.5 is almost out the door, I'd like to get stable releases prepared on the other two active branches. 4.3.4 is expected to be the last xen.org managed release on the 4.3 branch. Aiming at RC1s some time next week, please indicate commits you

Re: [Xen-devel] [Xen-users] [TestDay] minor bug + possible configuration bug 4.5rc4 archlinux

2015-01-12 Thread Olaf Hering
On Mon, Jan 12, Ian Campbell wrote: Adding some CC's, including the devel list. On Fri, 2015-01-09 at 19:49 -0600, Doug McMillan wrote: configuration(?) I compiled booted straight from bios with xen.efi during boot I received several errors. xl info works (see attachment). XL list

Re: [Xen-devel] [Xen-users] [TestDay] minor bug + possible configuration bug 4.5rc4 archlinux

2015-01-12 Thread Olaf Hering
On Mon, Jan 12, Doug McMillan wrote: ./configure \ --localstatedir=/run \ This is wrong for every setup one can think of. It has to be /var. Olaf ___ Xen-devel mailing

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-01-07 Thread Olaf Hering
On Tue, Jan 06, Ian Jackson wrote: Olaf Hering writes ([PATCH 7/7] tools/hotplug: add wrapper to start xenstored): The shell wrapper in xenstored.service does not handle XENSTORE_TRACE. ... +XENSTORED_LIBEXEC = xenstored.sh Should be in /etc as previously discussed. Previously I wrote

Re: [Xen-devel] [PATCH 0/7 v3] tools/hotplug: systemd changes for 4.5

2015-01-07 Thread Olaf Hering
On Mon, Jan 05, Konrad Rzeszutek Wilk wrote: +Release Issues +== + +While we did the utmost to get a release out, there are certain +fixes which were not complete on time. As such please reference this +section if you are running into trouble. + +* systemd not working with

Re: [Xen-devel] [PATCH v5 0/9] toolstack-based approach to pvhvm guest kexec

2015-01-07 Thread Olaf Hering
On Mon, Jan 05, Vitaly Kuznetsov wrote: Wei Liu wei.l...@citrix.com writes: Olaf mentioned his concern about handling ballooned pages in 20141211153029.ga1...@aepfle.de. Is that point moot now? Well, the limitation is real and some guest-side handling will be required in case we want

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-01-07 Thread Olaf Hering
On Tue, Jan 06, Ian Campbell wrote: On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: ... Acked-by: Ian Campbell ian.campb...@citrix.com (on commit s/Appearently/Apparently/; s/non-existant/non-existent/ in the commit log) I made typos also in other commit messages. Should I resend

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-01-07 Thread Olaf Hering
On Tue, Jan 06, Ian Campbell wrote: On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: The shell wrapper in xenstored.service does not handle XENSTORE_TRACE. Create a separate wrapper script which is used in the sysv runlevel script and in systemd xenstored.service. It preserves

Re: [Xen-devel] [PATCH v5 0/9] toolstack-based approach to pvhvm guest kexec

2015-01-07 Thread Olaf Hering
On Wed, Jan 07, David Vrabel wrote: 2. Reducing the balloon prior to kexec. We carry a patch for kexec(1) which does balloon up before doing the actual kexec call. I propose to get such change into the upstream kexec tools if that is indeed the way to go. The benefit is that the guest waits

Re: [Xen-devel] Xen 4.5 Development Update (GA slip by a week)

2015-01-07 Thread Olaf Hering
On Tue, Jan 06, Konrad Rzeszutek Wilk wrote: There is only one outstanding patch and that is #7 tools/hotplug: add wrapper to start xenstored. Olaf is back tomorrow so it might make it .. or not. See my other replies. I think once we know how to deal with SELinux and systemd this change may

[Xen-devel] check-headers error in staging

2015-01-07 Thread Olaf Hering
After upgrade to current staging, my test packages fail to build: [ 289s] + make -j4 -k -C tools/include/xen-foreign [ 289s] make: Entering directory `/usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign' [ 289s] python mkheader.py arm32 arm32.h

Re: [Xen-devel] [PATCH 1/2] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-01-07 Thread Olaf Hering
On Wed, Jan 07, Ian Campbell wrote: On Wed, 2015-01-07 at 16:49 +, Ian Jackson wrote: Certainly removing this feature this late in the 4.5 release cycle is not appropriate. I agree that faffing around with the initscripts/systemd units at the eleventh hour seem liable to leave us

[Xen-devel] [PATCH 2/2] tools/hotplug: remove usage of XENSTORED_TRACE boolean

2015-01-07 Thread Olaf Hering
The existing XENSTORED_TRACE= boolean cant be easily implemented in the xenstored.service file. All additional options should be added to the XENSTORED_ARGS= variable. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell

[Xen-devel] [PATCH 0/2] tools/hotplug/Linux changes

2015-01-07 Thread Olaf Hering
-4.5. Olaf Olaf Hering (2): tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file. tools/hotplug: remove usage of XENSTORED_TRACE boolean tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 8 +--- tools/hotplug/Linux/init.d/xencommons.in | 1 - 2 files changed, 5

Re: [Xen-devel] [PATCH 0/7 v3] tools/hotplug: systemd changes for 4.5

2015-01-07 Thread Olaf Hering
On Wed, Jan 07, Konrad Rzeszutek Wilk wrote: On Wed, Jan 07, 2015 at 10:53:06AM +0100, Olaf Hering wrote: Its my understanding that the reported SELinux failure is not only related to the context= mount option, but also to the socket passing from systemd. I couldn't spot any errors

[Xen-devel] [PATCH 6/7] tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend.service

2014-12-19 Thread Olaf Hering
The references Environment file does not exist, and the service file does not make use of variables anyway. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei

[Xen-devel] [PATCH 5/7] tools/hotplug: use XENCONSOLED_TRACE in xenconsoled.service

2014-12-19 Thread Olaf Hering
Instead of inventing a new XENCONSOLED_LOG= variable reuse the existing XENCONSOLED_TRACE= variable in xenconsoled.service. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb

[Xen-devel] [PATCH 4/7] tools/hotplug: use xencommons as EnvironmentFile in xenconsoled.service

2014-12-19 Thread Olaf Hering
The referenced sysconfig/xenconsoled does not exist. If anything needs to be specified it has to go into the existing sysconfig/xencommons file. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian

[Xen-devel] [PATCH 0/7 v3] tools/hotplug: systemd changes for 4.5

2014-12-19 Thread Olaf Hering
: - $XENSTORED can be set in sysconfig file con: - may have the same socket issue as starting via shell - XENSTORED_TRACE boolean is not handled I will be offline until 2015-01-07, so any further adjustments to this series has to be done by someone else. Good luck! Olaf Olaf Hering (7

[Xen-devel] [PATCH 3/7] tools/hotplug: xendomains.service depends on network

2014-12-19 Thread Olaf Hering
Starting domains during boot will most likely require network for the local bridge and it may need access to remote filesystems. Add ordering tags to systemd service file. Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc

[Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2014-12-19 Thread Olaf Hering
/archives/html/xen-devel/2014-03/msg02462.html Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com Cc: Anthony PERARD anthony.per...@citrix.com

[Xen-devel] [PATCH 2/7] tools/hotplug: remove XENSTORED_ROOTDIR from xenstored.service

2014-12-19 Thread Olaf Hering
There is no need to export XENSTORED_ROOTDIR. This variable can be enabled in sysconfig/xencommons. If the variable is unset xenstored will automatically use @XEN_LIB_STORED@. Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: Ian Jackson ian.jack...@eu.citrix.com Cc: Ian Jackson ian.jack

[Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2014-12-19 Thread Olaf Hering
--no-fork, which causes xenstored to fork internally to return to the caller of the wrapper script. The place of the wrapper is currently LIBEXEC_BIN, it has to be decided what the final location is supposed to be. IanJ wants it in /etc. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack

Re: [Xen-devel] [PATCH] libxc: check return values on mmap() and madvise() on xc_alloc_hypercall_buffer()

2014-12-19 Thread Olaf Hering
Please backport this patch to 4.4. Other branches may need the mmap() check as well. The callers expect either NULL or a valid pointer. It is upstream commit e86539a388314cd3dca88f5e69d7873343197cd8 Thanks, Olaf On Wed, May 21, Ian Campbell wrote: On Tue, 2014-05-20 at 05:37 -0700, Luis R.

Re: [Xen-devel] [Testday] Arch Linux Test report

2014-12-18 Thread Olaf Hering
On Thu, Dec 18, Julian Sivertsen wrote: == Issues === Brief: Invalid FETCHER by ./configure Importance: nuisance Location: xen Workaround: Install wget and reconfigure The m4/fetcher.m4 script checks for the precence of wget before falling back to ftp -o. On Arch Linux curl is shipped and

Re: [Xen-devel] Packaging xen 4.5.0 RC4 on Arch Linux

2014-12-17 Thread Olaf Hering
On Tue, Dec 16, Julian Sivertsen wrote: The default Arch Linux kernel does not have SELinux, causing the var-lib-xenstored.mount unit to fail due to an invalid context. This can be worked around by removing the context option from the mount options in that unit file. Mine does not have

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-12 Thread Olaf Hering
On Fri, Dec 12, Ian Campbell wrote: Seems ok. I wonder if the wrapper ought to source @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons to obtain XENSTORED_* itself rather than relying on the initscript and unit file to do so. Especially in the initscript case it looks a bit ugly to have to manually

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-12 Thread Olaf Hering
On Fri, Dec 12, Olaf Hering wrote: This works: ExecStart=@XENSTORED@ --no-fork $XENSTORED_ARGS This fails: ExecStart=$XENSTORED --no-fork $XENSTORED_ARGS But this will likely work: ExecStart=/usr/bin/env $XENSTORED --no-fork $XENSTORED_ARGS Let me know how to proceed... Olaf

Re: [Xen-devel] [PATCH 0/4 v2] tools/hotplug: systemd changes for 4.5

2014-12-11 Thread Olaf Hering
On Wed, Dec 10, Konrad Rzeszutek Wilk wrote: On Mon, Dec 08, 2014 at 11:18:05AM +0100, Olaf Hering wrote: This is a resend of this series, with just the low hanging fruits: http://lists.xenproject.org/archives/html/xen-devel/2014-12/msg00669.html This looks like it would fix some

Re: [Xen-devel] [PATCH 0/4 v2] tools/hotplug: systemd changes for 4.5

2014-12-11 Thread Olaf Hering
On Thu, Dec 11, M A Young wrote: Yes, you do need to set explicit selinux permissions when mounting /var/lib/xenstored as otherwise it gets a tmpfs selinux context which xenstored can't use in enforcing mode. Is that enforcing mode the default? And would it be too cumbersome to have these

Re: [Xen-devel] [PATCH 0/4 v2] tools/hotplug: systemd changes for 4.5

2014-12-11 Thread Olaf Hering
On Thu, Dec 11, Olaf Hering wrote: This sounds like xenstored has to parse the possible environment variables found in sysconfig.xencommons all by itself? Is there perhaps a way out of the SELinux jail? Does all that work with the sysv runlevel scripts? Olaf

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-10 Thread Olaf Hering
On Tue, Dec 09, Ian Jackson wrote: Bottom line: as relevant maintainer, I'm afraid I'm going to insist that this script be in /etc. I dont agree with the reasoning, but to get this done: Which place would that be, XEN_SCRIPT_DIR? I don't think this script wants to contain an option parser!

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-10 Thread Olaf Hering
On Wed, Dec 10, Ian Campbell wrote: Separately from the above I wonder if it might be worth moving the xenstore readiness check into the xen-init-dom0 helper and having most things which currently depend on xenstore actually depend on the dom0-is-ready unit, which itself depends on xenstored,

Re: [Xen-devel] [Xen-users] 4.5 git: regression in xen systemd shutdown hangs the OS

2014-12-09 Thread Olaf Hering
On Mon, Dec 08, Wei Liu wrote: However I think the problem you're seeing is due to xenstored exits too early, which should be fixable by rearranging the shutdown order? I.e. xenstored shuts down after xendomains. True, and this is addressed by 268b8f1. Perhaps a crashed or otherwise

[Xen-devel] [PATCH] tools/hotplug: xendomains.service depends on network

2014-12-09 Thread Olaf Hering
Starting domains during boot will most likely require network for the local bridge and it may need access to remote filesystems. Add ordering tags to systemd service file. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-09 Thread Olaf Hering
On Tue, Dec 09, Ian Jackson wrote: Olaf Hering writes (Re: [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd): On Fri, Dec 05, Ian Jackson wrote: I think the only way to make this work properly is to factor the necessary parts out of init.d/xencommons into a new script

[Xen-devel] [PATCH 3/4] tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend.service

2014-12-08 Thread Olaf Hering
The references Environment file does not exist, and the service file does not make use of variables anyway. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei

[Xen-devel] [PATCH 4/4] tools/hotplug: use xencommons as EnvironmentFile

2014-12-08 Thread Olaf Hering
The referenced sysconfig/xenconsoled does not exist. If anything needs to be specified it has to go into the existing sysconfig/xencommons file. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian

[Xen-devel] [PATCH 0/4 v2] tools/hotplug: systemd changes for 4.5

2014-12-08 Thread Olaf Hering
it is ready. Olaf Olaf Hering (4): tools/hotplug: remove SELinux options from var-lib-xenstored.mount tools/hotplug: remove XENSTORED_ROOTDIR from service file tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend.service tools/hotplug: use xencommons as EnvironmentFile

[Xen-devel] [PATCH 1/4] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2014-12-08 Thread Olaf Hering
-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com Cc: Anthony PERARD anthony.per...@citrix.com Cc: M A Young m.a.yo...@durham.ac.uk Cc: Luis R

[Xen-devel] [PATCH 2/4] tools/hotplug: remove XENSTORED_ROOTDIR from service file

2014-12-08 Thread Olaf Hering
There is no need to export XENSTORED_ROOTDIR. This variable can be enabled in sysconfig/xencommons. If the variable is unset xenstored will automatically use @XEN_LIB_STORED@. Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: Ian Jackson ian.jack...@eu.citrix.com Cc: Ian Jackson ian.jack

Re: [Xen-devel] [Xen-users] 4.5 git: regression in xen systemd shutdown hangs the OS

2014-12-08 Thread Olaf Hering
On Fri, Dec 05, Olaf Hering wrote: But even with that change xendomains is hanging if it cant talk to xenstored for whatever reason. The result is that the sytem hangs forever at shutdown. This looks like a bug in the tools. xl or xenstore-ls hang forever if xenstored disappears. Looks like

Re: [Xen-devel] [Xen-users] 4.5 git: regression in xen systemd shutdown hangs the OS

2014-12-08 Thread Olaf Hering
On Mon, Dec 08, Wei Liu wrote: I think we have xenstored stubdom in tree, don't we? If we do, isnt that a special setup which does not appear all by its own? If so, shouldnt there be some config file knob to let xs_open use socket only unless told otherwise by the to-be-created knob? Olaf

Re: [Xen-devel] [PATCH V5] Update pvSCSI protocol description / libxl

2014-12-07 Thread Olaf Hering
On Sun, Dec 07, Pasi Kärkkäinen wrote: Hello, Juergen/Olaf: Now that Xen PVSCSI drivers are in upstream Linux 3.18 kernel I was wondering if you guys also have plans to work on adding xl / libxl support for PVSCSI ? Its still on the TODO list. Will most likely make into 4.6. Olaf

Re: [Xen-devel] [PATCH] tools/hotplug: update systemd dependency to use service instead of socket

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Olaf Hering wrote: On Thu, Dec 04, Konrad Rzeszutek Wilk wrote: On Thu, Dec 04, 2014 at 08:47:56AM +0100, Olaf Hering wrote: Is that something the sysadmin has to adjust, or should the xen source provide proper values? It would be rather cumbersome if the sysadmin had

Re: [Xen-devel] [PATCH] tools/hotplug: update systemd dependency to use service instead of socket

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Olaf Hering wrote: So looking again at tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in it seems that it happens to work for me because XENSTORED_MOUNT_CTX is set within that file. So if something happens to need a different value for XENSTORED_MOUNT_CTX it has

Re: [Xen-devel] [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability

2014-12-05 Thread Olaf Hering
On Tue, Dec 02, Wei Liu wrote: AC_CHECK_LIB fails on Debian Jessie since the ld flag it generates is incorrect, even in the event systemd library is available. Use PKG_CHECK_MODULES instead. Tested on Debian Jessie and Arch Linux. I just tested this and got this failure. The reason is

Re: [Xen-devel] [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Ian Campbell wrote: On Fri, 2014-12-05 at 10:51 +0100, Olaf Hering wrote: On Tue, Dec 02, Wei Liu wrote: AC_CHECK_LIB fails on Debian Jessie since the ld flag it generates is incorrect, even in the event systemd library is available. Use PKG_CHECK_MODULES instead

[Xen-devel] [PATCH 0/5] tools/hotplug: systemd changes for 4.5

2014-12-05 Thread Olaf Hering
-existant sysconfig files. We should fix this before the release of 4.5 to avoid stale sysconfig files if someone wants to adjust the values. I have tested this series on openSUSE 13.1. Please review and apply for 4.5. Olaf Olaf Hering (5): tools/hotplug: move XENSTORED_MOUNT_CTX

[Xen-devel] [PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to sysconfig.xencommons

2014-12-05 Thread Olaf Hering
, just reuse the existing /etc/sysconfig/xencommons file. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com --- tools/hotplug/Linux

[Xen-devel] [PATCH 2/5] tools/hotplug: use existing sysconfig file for xenconsoled

2014-12-05 Thread Olaf Hering
and XENCONSOLED_LOG_DIR - Adjust the runlevel script to handle XENCONSOLED_TRACE properly. If an old sysconfig file exist the XENCONSOLED_TRACE will remain empty. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc

[Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-05 Thread Olaf Hering
The sysv runlevel script handles the boolean variable XENSTORED_TRACE from sysconfig.xencommons to enable tracing. Recognize this also to the systemd service file. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell

[Xen-devel] [PATCH 3/5] tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend.service

2014-12-05 Thread Olaf Hering
The references Environment file does not exist, and the service file does not make use of variables anyway. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei

Re: [Xen-devel] [PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to sysconfig.xencommons

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Ian Jackson wrote: Olaf Hering writes ([PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to sysconfig.xencommons): On a non-SELinux system the mount option context=none works fine. But with SELinux enabled a proper value has to be defined. To simplify the required

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Ian Jackson wrote: I think the only way to make this work properly is to factor the necessary parts out of init.d/xencommons into a new script which can be used by both xencommons and systemd. I'm not sure such a patch would be appropriate for 4.5 at this stage. Yes, a

Re: [Xen-devel] [PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to sysconfig.xencommons

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Ian Jackson wrote: Olaf Hering writes (Re: [PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to sysconfig.xencommons): On Fri, Dec 05, Ian Jackson wrote: This patch looks like just the hook. It seems to be missing the part where the actual selinux context is defined

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Ian Jackson wrote: Can systemd not launch these daemons by running the existing xencommons et al init scripts ? Obviously that won't give you all of systemd's shiny features but IMO it ought to work. I think the point was to let systemd pass the file descriptors. Thats why

Re: [Xen-devel] [Xen-users] 4.5 git: regression in xen systemd shutdown hangs the OS

2014-12-05 Thread Olaf Hering
On Tue, Dec 02, Olaf Hering wrote: On Tue, Dec 02, Ian Campbell wrote: On Mon, 2014-12-01 at 23:41 +, Mark Pryor wrote: list, Thanks. If you've identified a buggy changeset then it is fine to post to the devel lists. I've added a CC. I've also CCd everyone listed

Re: [Xen-devel] [PATCH v4 0/9] toolstack-based approach to pvhvm guest kexec

2014-12-04 Thread Olaf Hering
On Wed, Dec 03, Vitaly Kuznetsov wrote: Original description: When a PVHVM linux guest performs kexec there are lots of things which require taking care of: - shared info, vcpu_info - grants - event channels - ... Instead of taking care of all these things we can rebuild the domain

Re: [Xen-devel] xl pci-attach silently fails the first time

2014-12-03 Thread Olaf Hering
On Tue, Dec 02, Konrad Rzeszutek Wilk wrote: On Tue, Dec 02, 2014 at 04:46:52PM +0100, Olaf Hering wrote: On Mon, Dec 01, Konrad Rzeszutek Wilk wrote: That is odd - I see any device 'hot-plugged' being added at 00:05 and further. Does this by any chance depend on the guest?! I

[Xen-devel] [PATCH] INSTALL: fix typo in xendomains.service name

2014-12-03 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com --- INSTALL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALL b/INSTALL index 0bc67ea..71dd0eb 100644 --- a/INSTALL +++ b/INSTALL @@ -284,7 +284,7

Re: [Xen-devel] [PATCH] tools/hotplug: update systemd dependency to use service instead of socket

2014-12-03 Thread Olaf Hering
On Tue, Dec 02, Olaf Hering wrote: Since commit 4542ae340d75bd6319e3fcd94e6c9336e210aeef (tools/hotplug: systemd xenstored dependencies) all service files use the .socket unit as startup dependency. While this happens to work for boot it fails for shutdown because a .socket does not seem

Re: [Xen-devel] [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability

2014-12-03 Thread Olaf Hering
On Wed, Dec 03, Ian Campbell wrote: Ah I didn't know about the sd_listen_fds thing, so I think that what we need then is to use pkg-config first to determine if systemd-daemon is present at all, and then check for specific symbols we require using the pkg-config supplied CFLAGS and LDFLAGS

Re: [Xen-devel] [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability

2014-12-03 Thread Olaf Hering
On Wed, Dec 03, Ian Campbell wrote: On Wed, 2014-12-03 at 11:49 +0100, Olaf Hering wrote: On Wed, Dec 03, Ian Campbell wrote: Ah I didn't know about the sd_listen_fds thing, so I think that what we need then is to use pkg-config first to determine if systemd-daemon is present

Re: [Xen-devel] xl pci-attach silently fails the first time

2014-12-03 Thread Olaf Hering
On Wed, Dec 03, Olaf Hering wrote: On Tue, Dec 02, Konrad Rzeszutek Wilk wrote: On Tue, Dec 02, 2014 at 04:46:52PM +0100, Olaf Hering wrote: On Mon, Dec 01, Konrad Rzeszutek Wilk wrote: ACPI hotplug. And it does work after PCI discovery. In a pvops kernel, is the emulated but unplugged

Re: [Xen-devel] [PATCH] tools/hotplug: update systemd dependency to use service instead of socket

2014-12-03 Thread Olaf Hering
On Wed, Dec 03, M A Young wrote: On Wed, 3 Dec 2014, Konrad Rzeszutek Wilk wrote: Options=mode=755,context=$XENSTORED_MOUNT_CTX Yes, that was on my probable bug list, as context=none isn't a valid mount option (on Fedora at least), presumably because context has to be followed by a valid

Re: [Xen-devel] [Xen-users] 4.5 git: regression in xen systemd shutdown hangs the OS

2014-12-02 Thread Olaf Hering
On Tue, Dec 02, Ian Campbell wrote: On Mon, 2014-12-01 at 23:41 +, Mark Pryor wrote: list, Thanks. If you've identified a buggy changeset then it is fine to post to the devel lists. I've added a CC. I've also CCd everyone listed in the commit which you've fingered. Olaf, does this

Re: [Xen-devel] xl pci-attach silently fails the first time

2014-12-02 Thread Olaf Hering
On Mon, Dec 01, Sander Eikelenboom wrote: Monday, December 1, 2014, 3:34:09 PM, you wrote: actually be a workaround for the double pci-attach bug. Don't know about that bug. You just replied to it. ;-) Olaf ___ Xen-devel mailing list

Re: [Xen-devel] xl pci-attach silently fails the first time

2014-12-02 Thread Olaf Hering
On Mon, Dec 01, Konrad Rzeszutek Wilk wrote: That is odd - I see any device 'hot-plugged' being added at 00:05 and further. Does this by any chance depend on the guest?! I mean, how is the guest notified that a PCI device is gone (by unplug)? Maybe the pvops case just happens to work because

<    3   4   5   6   7   8   9   >