Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-21 Thread Jan Beulich
On 21.07.15 at 02:53, tiejun.c...@intel.com wrote: Okay, I regenerate this patch online. And I just hope its good to be acked here: Provided it also works, Reviewed-by: Jan Beulich jbeul...@suse.com Why is this marked as Acked-by this time? The same question is raised to another

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-21 Thread George Dunlap
On 07/21/2015 01:53 AM, Chen, Tiejun wrote: Okay, I regenerate this patch online. And I just hope its good to be acked here: Provided it also works, Reviewed-by: Jan Beulich jbeul...@suse.com Why is this marked as Acked-by this time? The same question is raised to another hvmloader patch

[Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-20 Thread Tiejun Chen
Try to avoid placing PCI BARs over RMRRs: - If mmio_hole_size is not specified, and the existing MMIO range has RMRRs in it, and there is space to expand the hole in lowmem without moving more memory, then make the MMIO hole as large as possible. - When placing RMRRs, find the next RMRR

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-20 Thread George Dunlap
On Mon, Jul 20, 2015 at 7:16 AM, Tiejun Chen tiejun.c...@intel.com wrote: Try to avoid placing PCI BARs over RMRRs: - If mmio_hole_size is not specified, and the existing MMIO range has RMRRs in it, and there is space to expand the hole in lowmem without moving more memory, then make the

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-20 Thread Jan Beulich
On 20.07.15 at 08:16, tiejun.c...@intel.com wrote: --- a/tools/firmware/hvmloader/pci.c +++ b/tools/firmware/hvmloader/pci.c @@ -38,6 +38,43 @@ uint64_t pci_hi_mem_start = 0, pci_hi_mem_end = 0; enum virtual_vga virtual_vga = VGA_none; unsigned long igd_opregion_pgbase = 0; +/* Check

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-20 Thread George Dunlap
On 07/20/2015 12:30 PM, Jan Beulich wrote: On 20.07.15 at 08:16, tiejun.c...@intel.com wrote: --- a/tools/firmware/hvmloader/pci.c +++ b/tools/firmware/hvmloader/pci.c @@ -38,6 +38,43 @@ uint64_t pci_hi_mem_start = 0, pci_hi_mem_end = 0; enum virtual_vga virtual_vga = VGA_none; unsigned

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-20 Thread Chen, Tiejun
On 2015/7/20 22:16, Jan Beulich wrote: On 20.07.15 at 16:10, george.dun...@citrix.com wrote: Hmm... although I suppose that doesn't catch the possibility of a memory range crossing the 4G boundary. I think we can safely ignore that - both real and virtual hardware have special regions right

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-20 Thread Chen, Tiejun
+/* Find the lowest RMRR higher than base. */ +static int find_next_rmrr(uint32_t base) +{ +unsigned int i; +int next_rmrr = -1; +uint64_t min_base = (1ull 32); + +for ( i = 0; i memory_map.nr_map ; i++ ) +{ +if ( memory_map.map[i].type == E820_RESERVED +

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-20 Thread George Dunlap
On 07/20/2015 03:06 PM, Chen, Tiejun wrote: +/* Find the lowest RMRR higher than base. */ +static int find_next_rmrr(uint32_t base) +{ +unsigned int i; +int next_rmrr = -1; +uint64_t min_base = (1ull 32); + +for ( i = 0; i memory_map.nr_map ; i++ ) +{ +if (

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-20 Thread Jan Beulich
On 20.07.15 at 16:10, george.dun...@citrix.com wrote: Hmm... although I suppose that doesn't catch the possibility of a memory range crossing the 4G boundary. I think we can safely ignore that - both real and virtual hardware have special regions right below 4Gb, so neither RAM not RMRRs can

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-20 Thread Jan Beulich
On 20.07.15 at 16:32, tiejun.c...@intel.com wrote: On 2015/7/20 22:16, Jan Beulich wrote: On 20.07.15 at 16:10, george.dun...@citrix.com wrote: Hmm... although I suppose that doesn't catch the possibility of a memory range crossing the 4G boundary. I think we can safely ignore that - both

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-20 Thread Chen, Tiejun
Okay, I regenerate this patch online. And I just hope its good to be acked here: Provided it also works, Reviewed-by: Jan Beulich jbeul...@suse.com Why is this marked as Acked-by this time? The same question is raised to another hvmloader patch as well. This really makes me confused since