[Xen-devel] [qemu-mainline test] 100512: tolerable FAIL - PUSHED

2016-08-17 Thread osstest service owner
flight 100512 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/100512/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 9 debian-install fail blocked in 100454 test-amd64-amd64-xl-qemuu-

[Xen-devel] [ovmf test] 100524: all pass - PUSHED

2016-08-17 Thread osstest service owner
flight 100524 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/100524/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fd4d9c6495109979eb17779e07666c7c11c79c6a baseline version: ovmf d35ec1e0507dc612ed648

Re: [Xen-devel] [PATCH 3/4] x86emul: drop SrcInvalid

2016-08-17 Thread George Dunlap
On Tue, Aug 16, 2016 at 2:34 PM, Andrew Cooper wrote: > On 16/08/16 12:27, Jan Beulich wrote: > On 16.08.16 at 12:12, wrote: >>> On 15/08/16 09:35, Jan Beulich wrote: As of commit a800e4f611 ("x86emul: drop pointless and add useful default cases") we no longer need the early bailing

Re: [Xen-devel] [PATCH 1/2] xen/x86: Convert to hotplug state machine

2016-08-17 Thread Sebastian Andrzej Siewior
On 2016-08-15 10:46:46 [-0400], Boris Ostrovsky wrote: > Switch to new CPU hotplug infrastructure. > > Signed-off-by: Boris Ostrovsky > Suggested-by: Sebastian Andrzej Siewior > --- > arch/x86/xen/enlighten.c | 115 > +--- > include/linux/cpuhotplug.h

Re: [Xen-devel] [PATCH v1 6/9] livepatch: Initial ARM64 support.

2016-08-17 Thread Andrew Cooper
>> The only reason apply_alternatives() is named thusly is to match Linux. >> I am not fussed if it changes. > Would this be OK with folks? > > There is a bit of disreprancy - ARM has 'const struct alt_instr *' > where the 'const' gets dropped later on. That can't be done x86 > as 'apply_alternati

[Xen-devel] [libvirt test] 100525: tolerable FAIL - PUSHED

2016-08-17 Thread osstest service owner
flight 100525 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/100525/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-amd64-amd64-libvirt-xsm 12 migrate-s

Re: [Xen-devel] [PATCH] x86/PV: don't hide CPUID.OSXSAVE from user mode

2016-08-17 Thread Jan Beulich
>>> On 16.08.16 at 18:13, wrote: > On 16/08/16 17:00, Jan Beulich wrote: > On 16.08.16 at 17:41, wrote: >>> On 16/08/16 16:20, Jan Beulich wrote: User mode code generally cannot be expected to invoke the PV-enabled CPUID Xen supports, and prior to the CPUID levelling changes for 4.7

Re: [Xen-devel] [PATCH v3 31/38] altp2m: Introduce altp2m_switch_vcpu_altp2m_by_id

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 00:17, wrote: > xen/arch/arm/altp2m.c| 32 > xen/arch/x86/mm/altp2m.c | 6 ++ > xen/arch/x86/mm/p2m.c| 6 -- > xen/common/vm_event.c| 3 ++- > xen/include/asm-arm/altp2m.h | 7 --- > xen/include/asm-ar

Re: [Xen-devel] [PATCH v3 36/38] altp2m: Allow specifying external-only use-case

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 00:17, wrote: > From: Tamas K Lengyel > > Currently setting altp2mhvm=1 in the domain configuration allows access to the > altp2m interface for both in-guest and external privileged tools. This poses > a problem for use-cases where only external access should be allowed, > re

[Xen-devel] [PATCH biosdevname]: handle dom0 on AMD systems

2016-08-17 Thread Olaf Hering
Starting with xen-4.7 cpuid() will return with the hypervisor bit set in a dom0 when running on an AMD system. As a result biosdevname thinks it runs in a guest and does nothing. Detect a dom0 by looking into xenfs. This works with classic xenlinux based kernels and with pvops based kernels. Signe

[Xen-devel] [ovmf test] 100529: all pass - PUSHED

2016-08-17 Thread osstest service owner
flight 100529 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/100529/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 490b048b5afec06b1c78e6723530dcebd8b21612 baseline version: ovmf fd4d9c6495109979eb177

Re: [Xen-devel] [PATCH v2 5/6] xen/arm: traps: Avoid unnecessary VA -> IPA translation in abort handlers

2016-08-17 Thread Julien Grall
On 17/08/16 03:19, Shanker Donthineni wrote: Hi Julien, Hello Shanker, On 07/27/2016 12:09 PM, Julien Grall wrote: Translating a VA to a IPA is expensive. Currently, Xen is assuming that HPFAR_EL2 is only valid when the stage-2 data/instruction abort happened during a translation table walk

[Xen-devel] [xen-unstable-coverity test] 100530: all pass - PUSHED

2016-08-17 Thread osstest service owner
flight 100530 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/100530/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen c4e7a67e3a109a3d507d2617b77017e40d59f04a baseline version: xen 7f5c

[Xen-devel] [xen-4.6-testing baseline-only test] 67544: regressions - FAIL

2016-08-17 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 67544 xen-4.6-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/67544/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-xsm 11 guest-start

Re: [Xen-devel] [PATCH v3 37/38] arm/p2m: Extend xen-access for altp2m on ARM

2016-08-17 Thread Razvan Cojocaru
On 08/17/2016 01:17 AM, Sergej Proskurin wrote: > Signed-off-by: Sergej Proskurin > Acked-by: Razvan Cojocaru > --- > Cc: Razvan Cojocaru > Cc: Tamas K Lengyel > Cc: Ian Jackson > Cc: Wei Liu > --- > tools/tests/xen-access/xen-access.c | 27 +-- > 1 file changed, 17 i

Re: [Xen-devel] [PATCH biosdevname]: handle dom0 on AMD systems

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 12:30, wrote: > @@ -144,7 +171,11 @@ running_in_virtual_machine (void) > > ecx = cpuid (eax, ecx); > if (ecx & 0x8000U) > +{ > + if (running_in_dom0()) > + return 0; > return 1; > +} > return 0; > } Isn't this backwards? Dom

Re: [Xen-devel] [PATCH biosdevname]: handle dom0 on AMD systems

2016-08-17 Thread Andrew Cooper
On 17/08/16 12:51, Jan Beulich wrote: On 17.08.16 at 12:30, wrote: >> @@ -144,7 +171,11 @@ running_in_virtual_machine (void) >> >> ecx = cpuid (eax, ecx); >> if (ecx & 0x8000U) >> +{ >> + if (running_in_dom0()) >> + return 0; >> return 1; >> +}

Re: [Xen-devel] [PATCH v1 1/9] livepatch: Bubble up sanity checks on Elf relocs

2016-08-17 Thread Jan Beulich
>>> On 15.08.16 at 01:07, wrote: > --- a/xen/common/livepatch_elf.c > +++ b/xen/common/livepatch_elf.c > @@ -365,7 +365,22 @@ int livepatch_elf_perform_relocs(struct livepatch_elf > *elf) > } > > if ( r->sec->sh_type == SHT_RELA ) > -rc = arch_livepatch_perform_rel

Re: [Xen-devel] [PATCH v1 2/9] x86/arm: Make 'make debug' work properly.

2016-08-17 Thread Jan Beulich
>>> On 15.08.16 at 01:07, wrote: > On x86 it works great but on ARM 32,64 not so much. Considering the nature of the change ... > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -101,7 +101,7 @@ _uninstall: > > .PHONY: _debug > _debug: > - objdump -D -S $(TARGET)-syms > $(TARGET).s > +

Re: [Xen-devel] [PATCH] gnttab: Add gntdev device mappings for FreeBSD

2016-08-17 Thread Akshay Jaggi
On 11 August 2016 at 21:34, Wei Liu wrote: > > Please send a separate patch for linux.c as we probably want to backport > that. > > It needs changes to "private.h" and other files too, so I will have to send another patch anyway. If you see in gntshr_core.c, you will notice we are passing -1 to a

Re: [Xen-devel] [PATCH v3 38/38] arm/p2m: Add test of xc_altp2m_change_gfn

2016-08-17 Thread Razvan Cojocaru
On 08/17/2016 01:17 AM, Sergej Proskurin wrote: > This commit extends xen-access by a simple test of the functionality > provided by "xc_altp2m_change_gfn". The idea is to dynamically remap a > trapping gfn to another mfn, which holds the same content as the > original mfn. On success, the guest wi

[Xen-devel] Xen virtual IOMMU high level design doc

2016-08-17 Thread Lan, Tianyu
Hi All: The following is our Xen vIOMMU high level design for detail discussion. Please have a look. Very appreciate for your comments. This design doesn't cover changes when root port is moved to hypervisor. We may design it later. Content: =

Re: [Xen-devel] [PATCH v3 31/38] altp2m: Introduce altp2m_switch_vcpu_altp2m_by_id

2016-08-17 Thread Razvan Cojocaru
On 08/17/2016 01:17 AM, Sergej Proskurin wrote: > This commit adds the function "altp2m_switch_vcpu_altp2m_by_id" that is > executed after checking whether the vcpu should be switched to a > different altp2m within the function "altp2m_check". > > Please note that in this commit, the function "p2m

[Xen-devel] [PATCH v2] gnttab: Add gntdev device mappings for FreeBSD

2016-08-17 Thread Akshay Jaggi
Add grant table userspace device mappings for FreeBSD (enables support for qdisk backend on FreeBSD Dom0). Signed-off-by: Akshay Jaggi --- Changed since v1: * fix coding style * remove O_CLOEXEC * remove SET_MAX_GRANTS ioctl * update freebsd/gntdev.h to latest version * replace alloca with

Re: [Xen-devel] [PATCH v1 3/9] x86/arm64: Move the ALT_[ORIG|REPL]_PTR macros to header files.

2016-08-17 Thread Jan Beulich
>>> On 15.08.16 at 01:07, wrote: > That way common code can use the same macro to access > the most common attributes without much #ifdef. > > Take advantage of it right away in the livepatch code. > > Signed-off-by: Konrad Rzeszutek Wilk x86 part Acked-by: Jan Beulich with one adjustment: >

Re: [Xen-devel] [PATCH v1 7/9] livepatch: ARM64: Ignore mapping symbols: $[a, d, x, p]

2016-08-17 Thread Jan Beulich
>>> On 15.08.16 at 01:07, wrote: According to the code you mean $t instead of $p in the subject. > --- a/xen/arch/arm/livepatch.c > +++ b/xen/arch/arm/livepatch.c > @@ -90,6 +90,35 @@ void arch_livepatch_unmask(void) > local_abort_enable(); > } > > +int arch_is_payload_symbol(const struc

Re: [Xen-devel] [PATCH v1 8/9] livepatch: Move test-cases to common

2016-08-17 Thread Jan Beulich
>>> On 15.08.16 at 01:07, wrote: > xen/common/test/Makefile | 85 > ++ > xen/common/test/xen_bye_world.c| 34 > xen/common/test/xen_bye_world_func.c | 22 > xen/common/test/xen_hello_world.c | 68 +

[Xen-devel] [MINIOS PATCH 4/4] x86: use unified linker script

2016-08-17 Thread Wei Liu
There are only a few differences between i386 and x86-64 linker scripts. Unify them into one. Re-indent the file at the same time. Construct a special rule in top-level directory to cope with the change. Ideally the build system should also be made more elegant, but overhauling the build system is

[Xen-devel] [MINIOS PATCH 3/4] x86: switch to use elfnote

2016-08-17 Thread Wei Liu
Use the newer ELF note interface. The generated ELF notes results in equivalent configuration. Also need to modify linker script to provide a note section. Signed-off-by: Wei Liu --- arch/x86/minios-x86_32.lds | 4 arch/x86/minios-x86_64.lds | 4 arch/x86/x86_32.S | 17

[Xen-devel] [MINIOS PATCH 2/4] Introduce asm_macros.h

2016-08-17 Thread Wei Liu
Ported from xtf.git. Signed-off-by: Wei Liu --- include/asm_macros.h | 36 include/x86/asm_macros.h | 28 2 files changed, 64 insertions(+) create mode 100644 include/asm_macros.h create mode 100644 include/x86/asm_macros.h

[Xen-devel] [MINIOS PATCH 1/4] gitignore: ignore vim swap file

2016-08-17 Thread Wei Liu
Signed-off-by: Wei Liu --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 1c655a0..f21cc46 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,7 @@ *~ *.o *.a +*.swp include/list.h mini-os mini-os.gz -- 2.1.4 _

Re: [Xen-devel] [PATCH 1/9] x86/mtrr: prefix fns with mtrr and drop static

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 01:28, wrote: > For the functions that make up the interface to the MTRR code, drop the > static keyword and prefix them all with mtrr for improved clarity when > they're called outside this file. This also required adjusting or > providing function prototypes to make them calla

[Xen-devel] [MINIOS PATCH 0/4] x86: Use ELF notes and unfied linker script

2016-08-17 Thread Wei Liu
Wei Liu (4): gitignore: ignore vim swap file Introduce asm_macros.h x86: switch to use elfnote x86: use unified linker script .gitignore | 2 + Makefile | 6 +- arch/x86/Makefile | 1 + arch/x86/minios-x86.lds.S | 133 +

Re: [Xen-devel] [PATCH v3 31/38] altp2m: Introduce altp2m_switch_vcpu_altp2m_by_id

2016-08-17 Thread Sergej Proskurin
Hi Jan, On 08/17/2016 12:05 PM, Jan Beulich wrote: On 17.08.16 at 00:17, wrote: >> xen/arch/arm/altp2m.c| 32 >> xen/arch/x86/mm/altp2m.c | 6 ++ >> xen/arch/x86/mm/p2m.c| 6 -- >> xen/common/vm_event.c| 3 ++- >> xen/

Re: [Xen-devel] Xen virtual IOMMU high level design doc

2016-08-17 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Lan, Tianyu > Sent: 17 August 2016 13:06 > To: Jan Beulich; Kevin Tian; Andrew Cooper; yang.zhang...@gmail.com; Jun > Nakajima; Stefano Stabellini > Cc: Anthony Perard; xuqu...@huawei.com; xen- >

Re: [Xen-devel] [MINIOS PATCH 4/4] x86: use unified linker script

2016-08-17 Thread Wei Liu
On Wed, Aug 17, 2016 at 01:35:14PM +0100, Wei Liu wrote: > There are only a few differences between i386 and x86-64 linker scripts. > Unify them into one. Re-indent the file at the same time. > > Construct a special rule in top-level directory to cope with the change. > Ideally the build system sh

Re: [Xen-devel] [PATCH v3 31/38] altp2m: Introduce altp2m_switch_vcpu_altp2m_by_id

2016-08-17 Thread Julien Grall
On 17/08/16 13:37, Sergej Proskurin wrote: On 08/17/2016 12:05 PM, Jan Beulich wrote: On 17.08.16 at 00:17, wrote: xen/arch/arm/altp2m.c| 32 xen/arch/x86/mm/altp2m.c | 6 ++ xen/arch/x86/mm/p2m.c| 6 -- xen/common/vm_event.c

Re: [Xen-devel] [PATCH 2/9] x86/mtrr: drop mtrr_if indirection

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 01:28, wrote: > There can only ever be one mtrr_if now and that is the generic > implementation This is only true when taking into consideration that cpu_has_mtrr is #define-d to 1 right now. I'm not sure that's actually a good assumption (especially when think about running Xe

Re: [Xen-devel] [MINIOS PATCH 1/4] gitignore: ignore vim swap file

2016-08-17 Thread Samuel Thibault
Wei Liu, on Wed 17 Aug 2016 13:35:11 +0100, wrote: > Signed-off-by: Wei Liu Reviewed-by: Samuel Thibault > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 1c655a0..f21cc46 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -1,6 +1,7 @@

Re: [Xen-devel] [PATCH 3/9] x86/mtrr: drop have_wrcomb() wrapper

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 01:28, wrote: > The only call was always to the generic implementation. > > Signed-off-by: Doug Goldstein Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [MINIOS PATCH 4/4] x86: use unified linker script

2016-08-17 Thread Andrew Cooper
On 17/08/16 13:35, Wei Liu wrote: > diff --git a/arch/x86/minios-x86.lds.S b/arch/x86/minios-x86.lds.S > new file mode 100644 > index 000..65650ab > --- /dev/null > +++ b/arch/x86/minios-x86.lds.S > @@ -0,0 +1,133 @@ > +#if defined(__x86_64__) > + > +OUTPUT_FORMAT("elf64-x86-64", "elf64-x86-64"

Re: [Xen-devel] [PATCH 4/9] x86/mtrr: drop unnecessary use_intel() macro

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 01:28, wrote: > The use_intel() macro always evaluates to true so don't bother using it. Ah, here we go. But there are indentation issues again here. Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-

[Xen-devel] [xen-unstable test] 100518: regressions - FAIL

2016-08-17 Thread osstest service owner
flight 100518 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/100518/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-winxpsp3 17 guest-start/win.repeat fail REGR. vs. 100488 Regressions w

Re: [Xen-devel] [PATCH 5/9] x86/mtrr: drop unused is_cpu() macro

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 01:28, wrote: > --- a/xen/arch/x86/cpu/mtrr/generic.c > +++ b/xen/arch/x86/cpu/mtrr/generic.c > @@ -520,7 +520,7 @@ int mtrr_generic_validate_add_page(unsigned long base, > unsigned long size, unsig > > /* For Intel PPro stepping <= 7, must be 4 MiB aligned >

Re: [Xen-devel] [PATCH 6/9] x86/mtrr: drop unused mtrr_ops struct

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 01:28, wrote: > There are no users of the mtrr_ops struct or any of the callers on it so > drop those. > > Signed-off-by: Doug Goldstein Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.o

Re: [Xen-devel] [PATCH 7/9] x86/mtrr: drop unused positive_have_wrcomb()

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 01:28, wrote: > Unused function, gone. > > Signed-off-by: Doug Goldstein Acked-by: Jan Beulich But perhaps worth getting folded into the one dropping have_wrcomb() (the acks for both patches can be retained for the merged result). Jan

Re: [Xen-devel] [PATCH 8/9] x86/mtrr: drop unused func prototypes and struct

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 01:28, wrote: > These weren't used so drop them. > > Signed-off-by: Doug Goldstein Reviewed-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [ovmf test] 100531: all pass - PUSHED

2016-08-17 Thread osstest service owner
flight 100531 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/100531/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 584fcb7de28b710dfcd4fbe8fe1d574c593f3009 baseline version: ovmf 490b048b5afec06b1c78e

Re: [Xen-devel] [PATCH 9/9] x86/mtrr: use stdbool instead of int + define

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 01:28, wrote: > --- a/xen/arch/x86/cpu/mtrr/generic.c > +++ b/xen/arch/x86/cpu/mtrr/generic.c > @@ -3,6 +3,7 @@ > #include > #include > #include > +#include Is this really needed, with xen/types.h already including it? > @@ -237,7 +238,7 @@ static void mtrr_wrmsr(unsign

Re: [Xen-devel] [MINIOS PATCH 2/4] Introduce asm_macros.h

2016-08-17 Thread Samuel Thibault
Hello, Wei Liu, on Wed 17 Aug 2016 13:35:12 +0100, wrote: > Ported from xtf.git. What is xtf.git? Does it use the same BSD licencing? To my knowledge this is coming from the linux kernel source. > Signed-off-by: Wei Liu > --- > include/asm_macros.h | 36

[Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

2016-08-17 Thread Juergen Gross
Fix two issues discovered by coverity. Signed-off-by: Juergen Gross --- lib/printf.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/lib/printf.c b/lib/printf.c index ad6a304..f9e9d68 100644 --- a/lib/printf.c +++ b/lib/printf.c @@ -379,6 +379,7 @@

[Xen-devel] Ping: Re: [PATCH] replace bogus -ENOSYS uses

2016-08-17 Thread Jan Beulich
>>> On 12.08.16 at 13:02, wrote: Ping: On 12.08.16 at 12:34, wrote: >> On 11/08/16 19:10, Andrew Cooper wrote: >>> On 09/08/16 11:40, Jan Beulich wrote: --- a/xen/arch/x86/cpu/mtrr/main.c +++ b/xen/arch/x86/cpu/mtrr/main.c @@ -332,7 +332,7 @@ int mtrr_add_page(unsigned long

Re: [Xen-devel] [MINIOS PATCH 2/4] Introduce asm_macros.h

2016-08-17 Thread Wei Liu
On Wed, Aug 17, 2016 at 02:56:00PM +0200, Samuel Thibault wrote: > Hello, > > Wei Liu, on Wed 17 Aug 2016 13:35:12 +0100, wrote: > > Ported from xtf.git. > > What is xtf.git? Does it use the same BSD licencing? > To my knowledge this is coming from the linux kernel source. This: http://xenbits.x

[Xen-devel] Ping: [PATCH v2 2/6] x86/time: correctly honor late clearing of TSC related feature flags

2016-08-17 Thread Jan Beulich
Ping? >>> On 03.08.16 at 15:00, wrote: > As such clearing of flags may have an impact on the selected rendezvous > function, handle such in a central place. > > But don't allow such feature flags to be cleared during CPU hotplug: > Platform and local system times may have diverged significantly

Re: [Xen-devel] [MINIOS PATCH 2/4] Introduce asm_macros.h

2016-08-17 Thread Wei Liu
On Wed, Aug 17, 2016 at 02:40:09PM +0100, Wei Liu wrote: > On Wed, Aug 17, 2016 at 02:56:00PM +0200, Samuel Thibault wrote: > > Hello, > > > > Wei Liu, on Wed 17 Aug 2016 13:35:12 +0100, wrote: > > > Ported from xtf.git. > > > > What is xtf.git? Does it use the same BSD licencing? > > To my knowl

Re: [Xen-devel] [MINIOS PATCH 2/4] Introduce asm_macros.h

2016-08-17 Thread Andrew Cooper
On 17/08/16 14:40, Wei Liu wrote: > On Wed, Aug 17, 2016 at 02:56:00PM +0200, Samuel Thibault wrote: >> Hello, >> >> Wei Liu, on Wed 17 Aug 2016 13:35:12 +0100, wrote: >>> Ported from xtf.git. >> What is xtf.git? Does it use the same BSD licencing? >> To my knowledge this is coming from the linux k

[Xen-devel] [qemu-mainline test] 100528: tolerable FAIL - PUSHED

2016-08-17 Thread osstest service owner
flight 100528 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/100528/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stopfail like 100512 test-amd64-i386-xl-qemuu-w

Re: [Xen-devel] [Minios-devel] [MINIOS PATCH 3/4] x86: switch to use elfnote

2016-08-17 Thread Juergen Gross
On 17/08/16 14:35, Wei Liu wrote: > Use the newer ELF note interface. The generated ELF notes results in > equivalent configuration. > > Also need to modify linker script to provide a note section. > > Signed-off-by: Wei Liu Reviewed-by: Juergen Gross _

Re: [Xen-devel] [MINIOS PATCH 2/4] Introduce asm_macros.h

2016-08-17 Thread Andrew Cooper
On 17/08/16 13:35, Wei Liu wrote: > diff --git a/include/asm_macros.h b/include/asm_macros.h > new file mode 100644 > index 000..15dd377 > --- /dev/null > +++ b/include/asm_macros.h > @@ -0,0 +1,36 @@ > +/* > + * Macros for assembly files. > + */ > + > +#ifndef _ASM_MACRO_H_ > +#define _ASM_MAC

Re: [Xen-devel] [MINIOS PATCH 2/4] Introduce asm_macros.h

2016-08-17 Thread Wei Liu
On Wed, Aug 17, 2016 at 03:01:07PM +0100, Andrew Cooper wrote: > On 17/08/16 13:35, Wei Liu wrote: > > diff --git a/include/asm_macros.h b/include/asm_macros.h > > new file mode 100644 > > index 000..15dd377 > > --- /dev/null > > +++ b/include/asm_macros.h > > @@ -0,0 +1,36 @@ > > +/* > > + * M

Re: [Xen-devel] [MINIOS PATCH 2/4] Introduce asm_macros.h

2016-08-17 Thread Wei Liu
On Wed, Aug 17, 2016 at 03:03:44PM +0100, Wei Liu wrote: > On Wed, Aug 17, 2016 at 03:01:07PM +0100, Andrew Cooper wrote: > > On 17/08/16 13:35, Wei Liu wrote: > > > diff --git a/include/asm_macros.h b/include/asm_macros.h > > > new file mode 100644 > > > index 000..15dd377 > > > --- /dev/null

[Xen-devel] [PATCH] ns16550: mask transmit holding register empty interrupt when tx is stopped

2016-08-17 Thread Chris Patterson
From: Chris Patterson The uart generates an interrupt whenever the transmit holding register is empty and UART_IER_ETHREI is set in UART_IER. Currently, Xen's ns16550 driver does not currently mask this interrupt when transmit is stopped, unlike other platforms such as Linux [1]. Toggle UART_IE

Re: [Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

2016-08-17 Thread Wei Liu
On Wed, Aug 17, 2016 at 03:39:59PM +0200, Juergen Gross wrote: > Fix two issues discovered by coverity. I would update the commit message to make it contain more information. Fix two issues discovered by Coverity: 1. properl mark one switch case as fall-through 2. unroll a loop that only execute

Re: [Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

2016-08-17 Thread Juergen Gross
On 17/08/16 16:13, Wei Liu wrote: > On Wed, Aug 17, 2016 at 03:39:59PM +0200, Juergen Gross wrote: >> Fix two issues discovered by coverity. > > I would update the commit message to make it contain more information. > > Fix two issues discovered by Coverity: > > 1. properl mark one switch case a

Re: [Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

2016-08-17 Thread Wei Liu
On Wed, Aug 17, 2016 at 04:25:44PM +0200, Juergen Gross wrote: > On 17/08/16 16:13, Wei Liu wrote: > > On Wed, Aug 17, 2016 at 03:39:59PM +0200, Juergen Gross wrote: > >> Fix two issues discovered by coverity. > > > > I would update the commit message to make it contain more information. > > > >

Re: [Xen-devel] [PATCH] ns16550: mask transmit holding register empty interrupt when tx is stopped

2016-08-17 Thread Jan Beulich
>>> On 17.08.16 at 16:02, wrote: > From: Chris Patterson > > The uart generates an interrupt whenever the transmit holding register is > empty and UART_IER_ETHREI is set in UART_IER. Currently, Xen's ns16550 > driver does not currently mask this interrupt when transmit is stopped, > unlike othe

[Xen-devel] [PATCH 1/2] libs/gnttab: do not use alloca(3)

2016-08-17 Thread Wei Liu
The semantics of alloca(3) is not very nice. If the stack overflows, program behaviour is undefined. Remove the use of alloca(3) and always use mmap. Signed-off-by: Wei Liu --- tools/libs/gnttab/linux.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/too

[Xen-devel] [PATCH 2/2] libs/foreignmemory: do not use alloca(3)

2016-08-17 Thread Wei Liu
The semantics of alloca(3) is not very nice. If the stack overflows, program behaviour is undefined. Remove the use of alloca(3) and always use mmap. Signed-off-by: Wei Liu --- tools/libs/foreignmemory/linux.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --

[Xen-devel] [PATCH 0/2] tools/libs: don't use alloca(3)

2016-08-17 Thread Wei Liu
Wei Liu (2): libs/gnttab: do not use alloca(3) libs/foreignmemory: do not use alloca(3) tools/libs/foreignmemory/linux.c | 21 +++-- tools/libs/gnttab/linux.c| 19 ++- 2 files changed, 13 insertions(+), 27 deletions(-) -- 2.1.4 _

Re: [Xen-devel] [PATCH v3 36/38] altp2m: Allow specifying external-only use-case

2016-08-17 Thread Daniel De Graaf
On 08/16/2016 06:17 PM, Sergej Proskurin wrote: From: Tamas K Lengyel Currently setting altp2mhvm=1 in the domain configuration allows access to the altp2m interface for both in-guest and external privileged tools. This poses a problem for use-cases where only external access should be allowed,

[Xen-devel] [PATCH net-next] xen-netback: create a debugfs node for hash information

2016-08-17 Thread Paul Durrant
It is useful to be able to see the hash configuration when running tests. This patch adds a debugfs node for that purpose. Signed-off-by: Paul Durrant Cc: Wei Liu --- drivers/net/xen-netback/common.h | 4 +++ drivers/net/xen-netback/hash.c | 68 drive

[Xen-devel] [xen-4.5-testing baseline-only test] 67545: regressions - FAIL

2016-08-17 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 67545 xen-4.5-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/67545/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-amd 14 leak-c

Re: [Xen-devel] [PATCH v4 09/19] x86: add multiboot2 protocol support

2016-08-17 Thread Jan Beulich
>>> On 06.08.16 at 01:04, wrote: > @@ -106,3 +121,119 @@ multiboot_info_t __stdcall *reloc(u32 mbi_in, u32 > trampoline) > > return mbi_out; > } > + > +static multiboot_info_t *mbi2_mbi(u32 mbi_in) > +{ > +const multiboot2_memory_map_t *mmap_src; > +const multiboot2_tag_t *tag; >

Re: [Xen-devel] [PATCH v4 10/19] efi: move efi struct initialization to xen/common/lib.c

2016-08-17 Thread Jan Beulich
>>> On 06.08.16 at 01:04, wrote: > A subsequent patch adds efi struct flags member which is used > during runtime to differentiate between legacy BIOS and EFI > platforms and multiboot2 and EFI native loader. So, efi symbol > have to proper representation in ELF and PE Xen image. Hence, > move efi

Re: [Xen-devel] [PATCH v4 11/19] efi: create efi_enabled()

2016-08-17 Thread Jan Beulich
>>> On 06.08.16 at 01:04, wrote: > --- a/xen/arch/x86/domain_page.c > +++ b/xen/arch/x86/domain_page.c > @@ -36,7 +36,7 @@ static inline struct vcpu *mapcache_current_vcpu(void) > * domain's page tables but current may point at another domain's VCPU. > * Return NULL as though current i

[Xen-devel] [xen-unstable-smoke test] 100535: tolerable all pass - PUSHED

2016-08-17 Thread osstest service owner
flight 100535 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/100535/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH v4 12/19] efi: introduce EFI_RS to ease control on runtime services usage

2016-08-17 Thread Jan Beulich
>>> On 06.08.16 at 01:04, wrote: Apart from the question of this probably better getting merged with the previous patch ... > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -936,6 +936,10 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE > *SystemTable) > > __set_bit(

Re: [Xen-devel] [PATCH v1 3/9] x86/arm64: Move the ALT_[ORIG|REPL]_PTR macros to header files.

2016-08-17 Thread Julien Grall
Hi Konrad, On 15/08/16 00:07, Konrad Rzeszutek Wilk wrote: That way common code can use the same macro to access the most common attributes without much #ifdef. Take advantage of it right away in the livepatch code. Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Stefano Stabellini Cc: Julien

Re: [Xen-devel] [PATCH v1 4/9] arm/mm: Introduce modify_xen_mappings

2016-08-17 Thread Julien Grall
Hi Konrad, On 15/08/16 00:07, Konrad Rzeszutek Wilk wrote: Which is only used by Livepatch code. The purpose behind this call is to modify the page table entries flags. Specifically the .ro and .nx flags. The current mechanism puts cache attributes in the flags and the .ro and .nx are locked do

Re: [Xen-devel] [PATCH] ns16550: mask transmit holding register empty interrupt when tx is stopped

2016-08-17 Thread Chris Patterson
On Wed, Aug 17, 2016 at 10:29 AM, Jan Beulich wrote: On 17.08.16 at 16:02, wrote: >> From: Chris Patterson >> >> The uart generates an interrupt whenever the transmit holding register is >> empty and UART_IER_ETHREI is set in UART_IER. Currently, Xen's ns16550 >> driver does not currently

Re: [Xen-devel] [PATCH v1 6/9] livepatch: Initial ARM64 support.

2016-08-17 Thread Julien Grall
Hi Konrad, On 15/08/16 16:17, Julien Grall wrote: On 15/08/2016 01:07, Konrad Rzeszutek Wilk wrote: +case R_AARCH64_ADR_PREL_PG_HI21: +val = (val & ~0xfff) - ((u64)dest & ~0xfff); +err = reloc_insn_imm(dest, val, 12, 21, AARCH64_INSN_IMM_ADR); +break;

[Xen-devel] [PATCH 00/24] sched: Credit1 and Credit2 improvements... and soft-affinity for Credit2!

2016-08-17 Thread Dario Faggioli
Hi everyone, Here's another rather big scheduler-related series. The most of the content (as usual, lately) is about Credit2, but there are other things, about tracing and also about Credit1. In fact, this patch series introduces soft-affinity support for Credit2. The first 3 patches are indeed b

[Xen-devel] [PATCH 02/24] xen: credit1: fix mask to be used for tickling in Credit1

2016-08-17 Thread Dario Faggioli
If there are idle pcpus inside the waking vcpu's soft-affinity mask, we should really tickle one of them (this is one of the purposes of the __runq_tickle() function itself!), not just any idle pcpu. The issue has been introduced in 02ea5031825d ("credit1: properly deal with pCPUs not in any cpupo

[Xen-devel] [PATCH 03/24] xen: credit1: return the 'time remaining to the limit' as next timeslice.

2016-08-17 Thread Dario Faggioli
If vcpu x has run for 200us, and sched_ratelimit_us is 1000us, continue running x _but_ return 1000us-200us as the next time slice. This way, next scheduling point will happen in 800us, i.e., exactly at the point when x crosses the threshold, and can be descheduled (if appropriate). Right now (wit

[Xen-devel] [PATCH 04/24] xen: credit2: properly schedule migration of a running vcpu.

2016-08-17 Thread Dario Faggioli
If wanting to migrate a vcpu that is actually running, we need to ask the scheduler to chime in as soon as possible, to have the vcpu itself stopped and actually moved. Make sure this happens by, after setting all the relevant flags, raising the scheduler softirq. Signed-off-by: Dario Faggioli -

[Xen-devel] [PATCH 05/24] xen: credit2: make tickling more deterministic

2016-08-17 Thread Dario Faggioli
Right now, the following scenario can occurr: - upon vcpu v wakeup, v itself is put in the runqueue, and pcpu X is tickled; - pcpu Y schedules (for whatever reason), sees v in the runqueue and picks it up. This may seem ok (or even a good thing), but it's not. In fact, if runq_tickle() dec

[Xen-devel] [PATCH 01/24] xen: credit1: small optimization in Credit1's tickling logic.

2016-08-17 Thread Dario Faggioli
If, when vcpu x wakes up, there are no idle pcpus in x's soft-affinity, we just go ahead and look at its hard affinity. This basically means that, if, in __runq_tickle(), new_idlers_empty is true, balance_step is equal to CSCHED_BALANCE_HARD_AFFINITY, and that calling csched_balance_cpumask() for w

[Xen-devel] [PATCH 07/24] xen: sched: don't rate limit context switches in case of yields

2016-08-17 Thread Dario Faggioli
In both Credit1 and Credit2, if a vcpu yields, let it... well... yield! In fact, context switch rate limiting has been primarily introduced to avoid too heavy context switch rate due to interrupts, and, in general, asynchronous events. In a vcpu "voluntarily" yields, we really should let it give

[Xen-devel] [PATCH 06/24] xen: credit2: implement yield()

2016-08-17 Thread Dario Faggioli
When a vcpu explicitly yields it is usually giving us an advice of "let someone else run and come back to me in a bit." Credit2 isn't, so far, doing anything when a vcpu yields, which means an yield is basically a NOP (well, actually, it's pure overhead, as it causes the scheduler kick in, but the

[Xen-devel] [PATCH 08/24] xen: tracing: add trace records for schedule and rate-limiting.

2016-08-17 Thread Dario Faggioli
As far as {csched, csched2, rt}_schedule() are concerned, an "empty" event, would already make it easier to read and understand a trace. But while there, add a few useful information, like if the cpu that is going through the scheduler has been tickled or not, if it is currently idle, etc (they va

[Xen-devel] [PATCH 09/24] xen/tools: tracing: improve tracing of context switches.

2016-08-17 Thread Dario Faggioli
Right now, two out of the three events related to context switch (that is TRC_SCHED_SWITCH_INFPREV and TRC_SCHED_SWITCH_INFNEXT) only report the domain id, and not the vcpu id. That's omitting a useful piece of information, and even if we be figured that out by looking at other records, that's unn

[Xen-devel] [PATCH 10/24] xen: tracing: improve Credit2's tickle_check and burn_credits records

2016-08-17 Thread Dario Faggioli
In both Credit2's trace records relative to checking whether we want to preempt a vcpu (in runq_tickle()), and to credits being burn, make it explicit on which pcpu the vcpu being considered is running. Such information isn't currently available, not even by looking at on which pcpu the events hap

[Xen-devel] [PATCH 11/24] tools: tracing: handle more scheduling related events.

2016-08-17 Thread Dario Faggioli
There are some scheduling related trace records that are not being taken care of (and hence only dumped as raw records). Some of them are being introduced in this series, while other were just neglected by previous patches. Add support for them. Signed-off-by: Dario Faggioli --- Cc: George Dunl

[Xen-devel] [PATCH 13/24] libxc: improve error handling of xc Credit1 and Credit2 helpers

2016-08-17 Thread Dario Faggioli
In fact, libxc wrappers should, on error, set errno and return -1. Signed-off-by: Dario Faggioli --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu --- tools/libxc/xc_csched.c | 27 +++ tools/libxc/xc_csched2.c | 15 +-- 2 files changed, 24 insertions(+

[Xen-devel] [PATCH 14/24] libxl: allow to set the ratelimit value online for Credit2

2016-08-17 Thread Dario Faggioli
This is the remaining part of the plumbing (the libxl one) necessary to be able to change the value of the ratelimit_us parameter online, for Credit2 (like it is already for Credit1). Note that, so far, we were rejecting (for Credit1) a new value of zero, despite it is a pretty nice way to ask for

[Xen-devel] [PATCH 12/24] xen: libxc: allow to set the ratelimit value online

2016-08-17 Thread Dario Faggioli
The main purpose of the patch is to provide the xen-libxc plumbing necessary to be able to change the value of the ratelimit_us parameter online, for Credit2 (like it is already for Credit1). While there: - mention in the Xen logs when rate limiting was enables and is being disabled (and vice-

[Xen-devel] [PATCH 16/24] xen: sched: factor affinity helpers out of sched_credit.c

2016-08-17 Thread Dario Faggioli
make it possible to use the various helpers from other schedulers, e.g., for implementing soft affinity within them. Since we are touching the code, also make it start using variables called v for struct_vcpu*, as it is preferrable. No functional change intended. Signed-off-by: Dario Faggioli S

[Xen-devel] [PATCH 17/24] xen: credit2: soft-affinity awareness in runq_tickle()

2016-08-17 Thread Dario Faggioli
This is done by means of the "usual" two steps loop: - soft affinity balance step; - hard affinity balance step. The entire logic implemented in runq_tickle() is applied, during the first step, considering only the CPUs in the vcpu's soft affinity. In the second step, we fall back to use all the

[Xen-devel] [PATCH 15/24] xl: allow to set the ratelimit value online for Credit2

2016-08-17 Thread Dario Faggioli
Last part of the wiring necessary for allowing to change the value of the ratelimit_us parameter online, for Credit2 (like it is already for Credit1). Signed-off-by: Dario Faggioli --- Cc: Ian Jackson Cc: Wei Liu Cc: George Dunlap --- docs/man/xl.pod.1.in |9 tools/libxl/xl_cmdi

[Xen-devel] [PATCH 18/24] xen: credit2: soft-affinity awareness fallback_cpu() and cpu_pick()

2016-08-17 Thread Dario Faggioli
For get_fallback_cpu(), by putting in place the "usual" two steps (soft affinity step and hard affinity step) loop. We just move the core logic of the function inside the body of the loop itself. For csched2_cpu_pick(), what is important is to find the runqueue with the least average load. Current

  1   2   >