Re: [Xen-devel] [PATCH v9 07/25] x86: refactor psr: L3 CAT: implement get hw info flow.

>>> On 27.03.17 at 14:24, wrote: > On 17-03-27 03:07:37, Jan Beulich wrote: >> >>> On 16.03.17 at 12:07, wrote: >> > +static enum psr_feat_type psr_cbm_type_to_feat_type(enum cbm_type type) >> > +{ >> > +enum psr_feat_type feat_type; >> > +

Re: [Xen-devel] [PATCH 09/10] tools/x86emul: Advertise more CPUID features for testing purposes

On 27/03/17 13:13, Jan Beulich wrote: On 27.03.17 at 13:20, wrote: >> On 27/03/17 10:56, Andrew Cooper wrote: >>> Signed-off-by: Andrew Cooper >>> --- >>> CC: Jan Beulich >>> CC: George Dunlap

Re: [Xen-devel] [PATCH 0/5] x86/dpci: bind legacy PCI interrupts to PVHv2 Dom0

On Mon, Mar 27, 2017 at 06:19:19AM -0600, Jan Beulich wrote: > >>> On 27.03.17 at 12:44, wrote: > > The series has been tested with a PVHv2 Dom0 on a box with 3 IO APICs, > > although all devices are wired up into the first IO APIC sadly. > > Did you try with something

Re: [Xen-devel] [PATCH 09/10] tools/x86emul: Advertise more CPUID features for testing purposes

On 27/03/17 13:56, George Dunlap wrote: > On 27/03/17 13:13, Jan Beulich wrote: > On 27.03.17 at 13:20, wrote: >>> On 27/03/17 10:56, Andrew Cooper wrote: Signed-off-by: Andrew Cooper --- CC: Jan Beulich

[Xen-devel] [ovmf test] 106934: all pass - PUSHED

flight 106934 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/106934/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0b36d8fa73072382a4ad36e6c64d26f43cb81bc6 baseline version: ovmf

Re: [Xen-devel] [PATCH v2] x86: clarify shadow paging Dom0 support

On Mon, Mar 27, 2017 at 02:20:17PM +0100, Andrew Cooper wrote: > On 27/03/17 14:11, Wei Liu wrote: > > @@ -456,6 +455,9 @@ int __init construct_dom0(struct domain *d, const > > module_t *image, > > > > process_pending_softirqs(); > > > > +if ( opt_dom0_shadow && !dom0_pvh ) > > +

Re: [Xen-devel] [PATCH v2 2/2] xen: sched: improve robustness (and rename) DOM2OP()

On 17/03/17 18:19, Dario Faggioli wrote: > Clarify and enforce (with ASSERTs) when the function > is called on the idle domain, and explain in comments > what it means and when it is ok to do so. > > While there, change the name of the function to a more > self-explanatory one, and do the same to

Re: [Xen-devel] [PATCH 09/10] tools/x86emul: Advertise more CPUID features for testing purposes

On 27/03/17 13:13, Jan Beulich wrote: On 27.03.17 at 13:20, wrote: >> On 27/03/17 10:56, Andrew Cooper wrote: >>> Signed-off-by: Andrew Cooper >>> --- >>> CC: Jan Beulich >>> CC: George Dunlap

Re: [Xen-devel] [PATCH 09/10] tools/x86emul: Advertise more CPUID features for testing purposes

>>> On 27.03.17 at 15:03, wrote: > On 27/03/17 13:56, George Dunlap wrote: >> On 27/03/17 13:13, Jan Beulich wrote: >> On 27.03.17 at 13:20, wrote: On 27/03/17 10:56, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper

Re: [Xen-devel] [PATCH v4 1/8] xen: import ring.h from xen

On 24/03/17 18:37, Stefano Stabellini wrote: > On Fri, 24 Mar 2017, Juergen Gross wrote: >> On 23/03/17 19:22, Stefano Stabellini wrote: >>> On Thu, 23 Mar 2017, Paolo Bonzini wrote: On 23/03/2017 14:55, Juergen Gross wrote: > On 23/03/17 14:00, Greg Kurz wrote: >> On Mon, 20 Mar 2017

Re: [Xen-devel] [PATCH v9 08/25] x86: refactor psr: L3 CAT: implement get value flow.

On 17-03-27 03:23:08, Jan Beulich wrote: > >>> On 16.03.17 at 12:07, wrote: > > --- a/xen/arch/x86/domctl.c > > +++ b/xen/arch/x86/domctl.c > > @@ -1455,23 +1455,26 @@ long arch_do_domctl( > > break; > > > > case XEN_DOMCTL_PSR_CAT_OP_GET_L3_CBM:

Re: [Xen-devel] [PATCH 09/10] tools/x86emul: Advertise more CPUID features for testing purposes

On 27/03/17 14:03, Andrew Cooper wrote: > On 27/03/17 13:56, George Dunlap wrote: >> On 27/03/17 13:13, Jan Beulich wrote: >> On 27.03.17 at 13:20, wrote: On 27/03/17 10:56, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper

[Xen-devel] [xen-unstable-smoke test] 106935: tolerable trouble: broken/fail/pass - PUSHED

flight 106935 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/106935/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 12

Re: [Xen-devel] [PATCH 07/10] tools/insn-fuzz: Provide IA32_DEBUGCTL consistently to the emulator

On 27/03/17 12:53, Jan Beulich wrote: On 27.03.17 at 11:56, wrote: >> x86_emulates()'s is_branch_step() performs a speculative read of >> IA32_DEBUGCTL, but doesn't squash exceptions should they arise. In reality, >> this MSR is always available. >> >>

Re: [Xen-devel] [PATCH 09/10] tools/x86emul: Advertise more CPUID features for testing purposes

On 27/03/17 13:09, Jan Beulich wrote: On 27.03.17 at 11:56, wrote: >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: George Dunlap >> CC: Ian Jackson

Re: [Xen-devel] [PATCH v3] boot allocator: Use arch helper for virt_to_mfn on DIRECTMAP

Hello Vijay, I agree with Jan's comments. On 27/03/17 08:10, vijay.kil...@gmail.com wrote: diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h [...] diff --git a/xen/include/asm-x86/page.h b/xen/include/asm-x86/page.h I am not sure to understand why the helper is added in

[Xen-devel] [PATCH v2] x86: clarify shadow paging Dom0 support

Classic PV shadow paging Dom0 has been broken for years, and can't possibly be configured after 4045953. PVH shadow paging Dom0 should still be possible. Change the code and documentation to clarify that. Signed-off-by: Wei Liu --- v2: 1. simplify need_paging 2. move panic

Re: [Xen-devel] [PATCH v3] xen/arm: alternative: Register re-mapped Xen area as a temporary virtual region

On Mon, Mar 27, 2017 at 04:40:50PM +0800, Wei Chen wrote: > While I was using the alternative patching in the SErrors patch series [1]. > I used a branch instruction as alternative instruction. > > ALTERNATIVE("nop", > "b skip_check", >

Re: [Xen-devel] [PATCH v9 07/25] x86: refactor psr: L3 CAT: implement get hw info flow.

On 17-03-27 06:51:07, Jan Beulich wrote: > >>> On 27.03.17 at 14:24, wrote: > > On 17-03-27 03:07:37, Jan Beulich wrote: > >> >>> On 16.03.17 at 12:07, wrote: > >> > +static enum psr_feat_type psr_cbm_type_to_feat_type(enum cbm_type type) > >>

Re: [Xen-devel] [PATCH v2] x86: clarify shadow paging Dom0 support

On 27/03/17 14:11, Wei Liu wrote: > @@ -456,6 +455,9 @@ int __init construct_dom0(struct domain *d, const > module_t *image, > > process_pending_softirqs(); > > +if ( opt_dom0_shadow && !dom0_pvh ) > +panic("Shadow paging Dom0 only works in PVH mode"); Is there any way to do

Re: [Xen-devel] [PATCH v9 07/25] x86: refactor psr: L3 CAT: implement get hw info flow.

>>> On 27.03.17 at 15:19, wrote: > On 17-03-27 06:51:07, Jan Beulich wrote: >> >>> On 27.03.17 at 14:24, wrote: >> > Please check above comments. Maybe below definitions are better? >> > PSR_INFO_IDX_CAT_CBM_LEN >> > PSR_INFO_IDX_COS_MAX >> >

Re: [Xen-devel] [PATCH v9 08/25] x86: refactor psr: L3 CAT: implement get value flow.

>>> On 27.03.17 at 14:59, wrote: > On 17-03-27 03:23:08, Jan Beulich wrote: >> >>> On 16.03.17 at 12:07, wrote: >> > --- a/xen/arch/x86/domctl.c >> > +++ b/xen/arch/x86/domctl.c >> > @@ -1455,23 +1455,26 @@ long arch_do_domctl( >> >

[Xen-devel] [PATCH v3] x86: clarify shadow paging Dom0 support

Classic PV shadow paging Dom0 has been broken for years, and can't possibly be configured after 4045953. PVH shadow paging Dom0 should still be possible. Change the code and documentation to clarify that. Signed-off-by: Wei Liu --- v3: 1. don't panic v2: 1. simplify

Re: [Xen-devel] [PATCH v3] x86: clarify shadow paging Dom0 support

On Mon, Mar 27, 2017 at 02:34:01PM +0100, Wei Liu wrote: > > +if ( opt_dom0_shadow && !dom0_pvh ) > +{ > +opt_dom0_shadow = false; > +printk("Shadow Dom0 requires PVH. Option ignored."); There should be a '\n' at the end. Wei.

Re: [Xen-devel] [PATCH 09/10] tools/x86emul: Advertise more CPUID features for testing purposes

>>> On 27.03.17 at 15:01, wrote: > On 27/03/17 13:09, Jan Beulich wrote: > On 27.03.17 at 11:56, wrote: >>> --- a/tools/tests/x86_emulator/x86_emulate.c >>> +++ b/tools/tests/x86_emulator/x86_emulate.c >>> @@ -73,20 +73,37 @@ int

Re: [Xen-devel] [PATCH v9 11/25] x86: refactor psr: L3 CAT: set value: implement cos finding flow.

On 17-03-27 04:28:23, Jan Beulich wrote: > >>> On 16.03.17 at 12:08, wrote: > > --- a/xen/arch/x86/psr.c > > +++ b/xen/arch/x86/psr.c [...] > > +static int cat_compare_val(const uint32_t val[], > > + const struct feat_node *feat, > > +

[Xen-devel] [qemu-mainline baseline-only test] 71103: trouble: blocked/broken

This run is configured for baseline tests only. flight 71103 qemu-mainline real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71103/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-xsm

Re: [Xen-devel] [PATCH v9 19/25] x86: L2 CAT: implement get hw info flow.

On 17-03-27 08:38:39, Jan Beulich wrote: > >>> On 16.03.17 at 12:08, wrote: > > --- a/xen/include/public/sysctl.h > > +++ b/xen/include/public/sysctl.h > > @@ -744,6 +744,7 @@ typedef struct xen_sysctl_pcitopoinfo > > xen_sysctl_pcitopoinfo_t; > >

Re: [Xen-devel] [PATCH v9 10/25] x86: refactor psr: L3 CAT: set value: assemble features value array.

On 17-03-27 04:17:28, Jan Beulich wrote: > >>> On 16.03.17 at 12:08, wrote: > > --- a/xen/arch/x86/psr.c > > +++ b/xen/arch/x86/psr.c > > @@ -101,6 +101,28 @@ struct feat_node { > > /* get_val is used to get feature COS register value. */ > > void

[Xen-devel] [xen-unstable baseline-only test] 71104: trouble: blocked/broken

This run is configured for baseline tests only. flight 71104 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71104/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xtf

Re: [Xen-devel] [PATCH v9 12/25] x86: refactor psr: L3 CAT: set value: implement cos id picking flow.

On 17-03-27 04:37:37, Jan Beulich wrote: > >>> On 16.03.17 at 12:08, wrote: > > +static bool cat_fits_cos_max(const uint32_t val[], > > + const struct feat_node *feat, > > + unsigned int cos) > > +{ > > +if (

Re: [Xen-devel] ARM: SMMUv3 support

On Mon, Mar 27, 2017 at 10:00 PM, Goel, Sameer wrote: > Hi, > I am working on adding this support. The work is in initial stages and will > target ACPI systems to start with. Do you have a specific requirement? Or > even better: want to help with DT testing ? :) Thanks

[Xen-devel] [ovmf test] 106947: all pass - PUSHED

flight 106947 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/106947/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 98eb009563691bd940f3d31cc8a2c1c8478cd605 baseline version: ovmf

Re: [Xen-devel] [PATCH v9 13/25] x86: refactor psr: L3 CAT: set value: implement write msr flow.

On 17-03-27 04:46:01, Jan Beulich wrote: > >>> On 16.03.17 at 12:08, wrote: > > @@ -421,6 +425,18 @@ static bool cat_fits_cos_max(const uint32_t val[], > > } > > > > /* L3 CAT ops */ > > +static void l3_cat_write_msr(unsigned int cos, uint32_t val, > > +

Re: [Xen-devel] [PATCH v9 17/25] x86: refactor psr: CDP: implement set value callback functions.

On 17-03-27 08:17:04, Jan Beulich wrote: > >>> On 16.03.17 at 12:08, wrote: > > +static bool l3_cdp_fits_cos_max(const uint32_t val[], > > +const struct feat_node *feat, > > +unsigned int cos) > > +{ > > +

Re: [Xen-devel] [PATCH v9 15/25] x86: refactor psr: CDP: implement get hw info flow.

On 17-03-27 08:08:13, Jan Beulich wrote: > >>> On 16.03.17 at 12:08, wrote: > > --- a/xen/arch/x86/sysctl.c > > +++ b/xen/arch/x86/sysctl.c > > @@ -180,10 +180,36 @@ long arch_do_sysctl( > > > > ret = psr_get_info(sysctl->u.psr_cat_op.target, > >

[Xen-devel] [linux-linus test] 106939: regressions - FAIL

flight 106939 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/106939/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 11 guest-start fail REGR. vs. 59254

[Xen-devel] [xen-4.8-testing baseline-only test] 71102: trouble: blocked/broken

This run is configured for baseline tests only. flight 71102 xen-4.8-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71102/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xtf

[Xen-devel] [xen-4.5-testing baseline-only test] 71100: regressions - trouble: blocked/broken/fail/pass

This run is configured for baseline tests only. flight 71100 xen-4.5-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71100/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 3

Re: [Xen-devel] [PATCH v9 09/25] x86: refactor psr: L3 CAT: set value: implement framework.

On 17-03-27 03:59:32, Jan Beulich wrote: > >>> On 16.03.17 at 12:07, wrote: > > --- a/xen/arch/x86/domctl.c > > +++ b/xen/arch/x86/domctl.c > > @@ -1437,21 +1437,21 @@ long arch_do_domctl( > > switch ( domctl->u.psr_cat_op.cmd ) > > { > > case

Re: [Xen-devel] [PATCH 02/10] x86/emul: Add feature check for clzero

On 27/03/17 13:31, Jan Beulich wrote: On 27.03.17 at 14:13, wrote: >> On 27/03/17 12:28, Jan Beulich wrote: >> On 27.03.17 at 11:56, wrote: @@ -5183,6 +5184,8 @@ x86_emulate( { unsigned long zero

Re: [Xen-devel] [PATCH v3] x86: clarify shadow paging Dom0 support

>>> On 27.03.17 at 15:36, wrote: > On Mon, Mar 27, 2017 at 02:34:01PM +0100, Wei Liu wrote: >> >> +if ( opt_dom0_shadow && !dom0_pvh ) >> +{ >> +opt_dom0_shadow = false; >> +printk("Shadow Dom0 requires PVH. Option ignored."); > > There should be a

Re: [Xen-devel] [PATCH v3] x86: clarify shadow paging Dom0 support

On 27/03/17 14:34, Wei Liu wrote: > Classic PV shadow paging Dom0 has been broken for years, and can't > possibly be configured after 4045953. > > PVH shadow paging Dom0 should still be possible. > > Change the code and documentation to clarify that. > > Signed-off-by: Wei Liu

Re: [Xen-devel] [PATCH v2 09/27] ARM: GICv3: introduce separate pending_irq structs for LPIs

Hi, On 27/03/17 10:02, Andre Przywara wrote: On 24/03/17 17:26, Stefano Stabellini wrote: On Fri, 24 Mar 2017, Andre Przywara wrote: I am afraid that this would lead to situations where we needlessly allocate and deallocate pending_irqs. Under normal load I'd expect to have something like

[Xen-devel] [PATCH] x86/setup: enclose opt_dom0_shadow in CONFIG_SHADOW_PAGING

Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/setup.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index

[Xen-devel] [linux-linus test] 106930: regressions - FAIL

flight 106930 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/106930/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 11 guest-start fail REGR. vs. 59254

Re: [Xen-devel] [PATCH v3] x86: clarify shadow paging Dom0 support

On Mon, Mar 27, 2017 at 02:58:15PM +0100, Andrew Cooper wrote: > > This needs to be inside a #ifdef CONFIG_SHADOW_PAGING to avoid breaking > the build. > I just found out there is a similar issue in x86/setup.c and I sent a separate patch to fix that. Wei.

Re: [Xen-devel] [PATCH 09/10] tools/x86emul: Advertise more CPUID features for testing purposes

On 27/03/17 14:42, Jan Beulich wrote: On 27.03.17 at 15:03, wrote: >> On 27/03/17 13:56, George Dunlap wrote: >>> On 27/03/17 13:13, Jan Beulich wrote: >>> On 27.03.17 at 13:20, wrote: > On 27/03/17 10:56, Andrew Cooper wrote:

Re: [Xen-devel] [PATCH 09/10] tools/x86emul: Advertise more CPUID features for testing purposes

>>> On 27.03.17 at 15:37, wrote: > On 27/03/17 13:13, Jan Beulich wrote: > On 27.03.17 at 13:20, wrote: >>> On 27/03/17 10:56, Andrew Cooper wrote: Signed-off-by: Andrew Cooper --- CC: Jan Beulich

Re: [Xen-devel] [PATCH v9 14/25] x86: refactor psr: CDP: implement CPU init and free flow.

>>> On 16.03.17 at 12:08, wrote: > @@ -209,12 +212,29 @@ static DEFINE_PER_CPU(struct psr_assoc, psr_assoc); > * array creation. It is used to transiently store a spare node. > */ > static struct feat_node *feat_l3_cat; > +static struct feat_node *feat_l3_cdp; > >

Re: [Xen-devel] [PATCH v9 15/25] x86: refactor psr: CDP: implement get hw info flow.

>>> On 16.03.17 at 12:08, wrote: > --- a/xen/arch/x86/sysctl.c > +++ b/xen/arch/x86/sysctl.c > @@ -180,10 +180,36 @@ long arch_do_sysctl( > > ret = psr_get_info(sysctl->u.psr_cat_op.target, > PSR_CBM_TYPE_L3, data,

Re: [Xen-devel] [PATCH v2 16/27] ARM: vITS: handle CLEAR command

Hi Andre, On 27/03/17 09:44, Andre Przywara wrote: Hi, On 24/03/17 17:17, Stefano Stabellini wrote: On Fri, 24 Mar 2017, Andre Przywara wrote: Hi, On 24/03/17 14:27, Julien Grall wrote: Hi Andre, On 03/16/2017 11:20 AM, Andre Przywara wrote: This introduces the ITS command handler for

Re: [Xen-devel] [PATCH v9 17/25] x86: refactor psr: CDP: implement set value callback functions.

>>> On 16.03.17 at 12:08, wrote: > +static bool l3_cdp_fits_cos_max(const uint32_t val[], > +const struct feat_node *feat, > +unsigned int cos) > +{ > +if ( cos > feat->info.cat_info.cos_max && > +

Re: [Xen-devel] [PATCH v5] altp2m: Allow specifying external-only use-case

On Wed, Mar 22, 2017 at 12:07:33PM -0600, Tamas K Lengyel wrote: > Currently setting altp2mhvm=1 in the domain configuration allows access to the > altp2m interface for both in-guest and external privileged tools. This poses > a problem for use-cases where only external access should be allowed,

<    1   2   3