Re: [Xen-devel] [PATCH v3 4/5] tools/libxc: error handling for the postcopy() callback

2016-01-25 Thread Wen Congyang
On 01/26/2016 02:45 PM, Yang Hongyang wrote: > ditto > > Reviewed-by: Yang Hongyang The newest version is v5, and this series is in the staging now. Thanks for your review. Wen Congyang > > On 01/08/2016 02:38 PM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang

Re: [Xen-devel] [PATCH v6 11/18] tools/libxl: Add back channel to allow migration target send data back

2016-01-25 Thread Wen Congyang
On 01/26/2016 03:17 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Dec 30, 2015 at 10:29:01AM +0800, Wen Congyang wrote: >> In colo mode, slave needs to send data to master, but the io_fd > > > > In previous patches you used COLO in all caps, can that be uniform > across the patches? OK, I will

[Xen-devel] [PATCH] xen vtd : set msi guest_masked 0 by default

2016-01-25 Thread Jianzhong,Chang
There are some problems when msi guest_masked is set to 1 by default. When guest os is windows 2008 r2 server, the device(eg X540-AT2 vf) is not initialized correctly. Host will always receive message like this :"VF Reset msg received from vf". Guest has network connectivity issues, and can not

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-25 Thread Chun Yan Liu
>>> On 1/20/2016 at 12:56 PM, in message <569f83f502660009e...@relay2.provo.novell.com>, "Chun Yan Liu" wrote: > On 1/19/2016 at 11:48 PM, in message > <22174.23240.402164.635...@mariner.uk.xensource.com>, Ian Jackson > wrote: > >

Re: [Xen-devel] [PATCH v6 09/18] tools/libxl: introduce libxl__domain_common_switch_qemu_logdirty()

2016-01-25 Thread Wen Congyang
On 01/26/2016 02:59 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Dec 30, 2015 at 10:28:59AM +0800, Wen Congyang wrote: >> Secondary vm is running in colo mode, we need to send >> secondary vm's dirty page information to master at checkpoint, > > In previous patch you called it primary, so perhaps:

Re: [Xen-devel] [PATCH v3 4/5] tools/libxc: error handling for the postcopy() callback

2016-01-25 Thread Yang Hongyang
On 01/26/2016 02:48 PM, Wen Congyang wrote: On 01/26/2016 02:45 PM, Yang Hongyang wrote: ditto Reviewed-by: Yang Hongyang The newest version is v5, and this series is in the staging now. Sorry for the noise...I saw the series too late, please ignore my

Re: [Xen-devel] [PATCH v5 COLOPre 08/18] tools/libxl: introduce libxl__domain_restore_device_model to load qemu state

2016-01-25 Thread Wen Congyang
On 01/26/2016 02:41 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Dec 17, 2015 at 03:48:12PM +0800, Wen Congyang wrote: >> From: Yang Hongyang >> >> In normal migration, the qemu state was passed to qemu as a parameter. > > /was/is/ > >> With COLO, Secondary vm is

Re: [Xen-devel] [PATCH v2 3/3] tools: introduce parameter max_wp_ram_ranges.

2016-01-25 Thread Yu, Zhang
Thank you, Jan. On 1/22/2016 4:01 PM, Jan Beulich wrote: On 22.01.16 at 04:20, wrote: --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -940,6 +940,10 @@ static int hvm_ioreq_server_alloc_rangesets(struct hvm_ioreq_server *s, { unsigned int i;

[Xen-devel] [linux-3.10 test] 78980: tolerable FAIL - PUSHED

2016-01-25 Thread osstest service owner
flight 78980 linux-3.10 real [real] http://logs.test-lab.xenproject.org/osstest/logs/78980/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-rumpuserxen-amd64 15 rumpuserxen-demo-xenstorels/xenstorels.repeat fail like 65778

Re: [Xen-devel] [v3,11/41] mips: reuse asm-generic/barrier.h

2016-01-25 Thread Paul E. McKenney
On Mon, Jan 25, 2016 at 06:02:34PM +, Will Deacon wrote: > Hi Paul, > > On Fri, Jan 15, 2016 at 09:39:12AM -0800, Paul E. McKenney wrote: > > On Fri, Jan 15, 2016 at 09:55:54AM +0100, Peter Zijlstra wrote: > > > On Thu, Jan 14, 2016 at 01:29:13PM -0800, Paul E. McKenney wrote: > > > > So

Re: [Xen-devel] [PATCH v3 1/5] remus: don't call stream_continue() when doing failover

2016-01-25 Thread Yang Hongyang
On 01/08/2016 02:38 PM, Wen Congyang wrote: stream_continue() is used for migration to read emulator xenstore data and emulator context. For remus, if we do failover, we have read it in the checkpoint cycle, and we only need to complete the stream. Reviewed-by: Yang Hongyang

Re: [Xen-devel] [PATCH v3 4/5] tools/libxc: error handling for the postcopy() callback

2016-01-25 Thread Yang Hongyang
ditto Reviewed-by: Yang Hongyang On 01/08/2016 02:38 PM, Wen Congyang wrote: Signed-off-by: Wen Congyang Reviewed-by: Andrew Cooper --- tools/libxc/xc_sr_save.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [Xen-devel] [PATCH v3 3/5] tools/libxc: don't send end record if remus fails

2016-01-25 Thread Yang Hongyang
some commit message would be better. Reviewed-by: Yang Hongyang On 01/08/2016 02:38 PM, Wen Congyang wrote: Signed-off-by: Wen Congyang Reviewed-by: Andrew Cooper --- tools/libxc/xc_sr_save.c | 2 +- 1 file

Re: [Xen-devel] [PATCH v5 COLOPre 07/18] migration/save: pass checkpointed_stream from libxl to libxc

2016-01-25 Thread Wen Congyang
On 01/26/2016 03:14 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 25, 2016 at 01:38:36PM -0500, Konrad Rzeszutek Wilk wrote: >> On Thu, Dec 17, 2015 at 03:48:11PM +0800, Wen Congyang wrote: >>> From: Yang Hongyang >>> >>> Pass checkpointed_stream from libxl to libxc.

Re: [Xen-devel] [v3,11/41] mips: reuse asm-generic/barrier.h

2016-01-25 Thread Paul E. McKenney
On Mon, Jan 25, 2016 at 04:42:43PM +, Will Deacon wrote: > On Fri, Jan 15, 2016 at 01:58:53PM -0800, Paul E. McKenney wrote: > > On Fri, Jan 15, 2016 at 10:27:14PM +0100, Peter Zijlstra wrote: > > > On Fri, Jan 15, 2016 at 09:46:12AM -0800, Paul E. McKenney wrote: > > > > On Fri, Jan 15, 2016

Re: [Xen-devel] [PATCH v3 2/5] remus: resume immediately if libxl__xc_domain_save_done() completes

2016-01-25 Thread Yang Hongyang
On 01/08/2016 02:38 PM, Wen Congyang wrote: For example: if the secondary host is down, and we fail to send the data to the secondary host. xc_domain_save() returns 0. So in the function libxl__xc_domain_save_done(), rc is 0(the helper program exits normally), and retval is 0(it is

[Xen-devel] [linux-3.14 test] 78986: tolerable FAIL - PUSHED

2016-01-25 Thread osstest service owner
flight 78986 linux-3.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/78986/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-rumpuserxen-i386 10 guest-startfail like 65787

Re: [Xen-devel] [v3,11/41] mips: reuse asm-generic/barrier.h

2016-01-25 Thread Paul E. McKenney
On Mon, Jan 25, 2016 at 02:41:34PM +, Will Deacon wrote: > On Fri, Jan 15, 2016 at 11:28:45AM -0800, Paul E. McKenney wrote: > > On Fri, Jan 15, 2016 at 09:54:01AM -0800, Paul E. McKenney wrote: > > > On Fri, Jan 15, 2016 at 10:24:32AM +, Will Deacon wrote: > > > > See my earlier reply [1]

Re: [Xen-devel] [PATCH 0/4] xl: consolidate adhoc parsers

2016-01-25 Thread Ian Campbell
On Fri, 2016-01-22 at 11:50 +, Wei Liu wrote: > This patch series consolidates adhoc parsers in xl. > > There are currently 4 types of devices: > > 1. block > 2. netowrk > 3. vtpm > 4. pci > > that support hotplug as well as being specified in config file. > > Block and pci devices are

Re: [Xen-devel] [PATCH XEN v8 11/29] tools: Refactor foreign memory mapping into libxenforeignmemory

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 13:01 +0100, Olaf Hering wrote: > On Fri, Jan 15, Ian Campbell wrote: > > > libxenforeignmemory will provide a stable API and ABI for mapping > > foreign domain memory (subject to appropriate privileges). > > I think this will break my Xen pkg build: > > [  333s]

[Xen-devel] [PATCH] tools/libs/*: freebsd remove unused code

2016-01-25 Thread Ian Campbell
"tools/libs/*: Use O_CLOEXEC on Linux and FreeBSD" left some dead code in the FreeBSD case, which breaks the build on that platform. Also fix a typo "uint_32". Signed-off-by: Ian Campbell --- tools/libs/call/freebsd.c | 8 tools/libs/evtchn/freebsd.c

Re: [Xen-devel] Error booting Xen

2016-01-25 Thread Jan Beulich
>>> On 21.01.16 at 16:14, wrote: > On Wed, 2016-01-20 at 03:06 -0700, Jan Beulich wrote: >> > > > On 19.01.16 at 20:55, wrote: >> > >> > $ 'addr2line -e xen-syms 82d0801c1cce' returns >> > 'xen/xen/arch/x86/xstate.c:387' which again

[Xen-devel] [PATCH] kdd: Opt in to libxc compat xc_map_foreign_* intefaces.

2016-01-25 Thread Ian Campbell
This: kdd-xen.c: In function 'kdd_access_physical_page': kdd-xen.c:508:9: warning: implicit declaration of function 'xc_map_foreign_range' [-Wimplicit-function-declaration] map = xc_map_foreign_range(g->xc_handle, ^ kdd-xen.c:508:13: warning: assignment makes pointer from

Re: [Xen-devel] [PATCH XEN v8 11/29] tools: Refactor foreign memory mapping into libxenforeignmemory

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 12:31 +, Ian Campbell wrote: > On Mon, 2016-01-25 at 13:01 +0100, Olaf Hering wrote: > > On Fri, Jan 15, Ian Campbell wrote: > > > > > libxenforeignmemory will provide a stable API and ABI for mapping > > > foreign domain memory (subject to appropriate privileges). > >

Re: [Xen-devel] [PATCH] kdd: build using Werror

2016-01-25 Thread Tim Deegan
At 13:18 + on 25 Jan (1453727891), Ian Campbell wrote: > We build most of tools using Werror and there seems to be know > deliberate reason for this to be an exception. > > Signed-off-by: Ian Campbell Acked-by: Tim Deegan

Re: [Xen-devel] [PATCH] kdd: Opt in to libxc compat xc_map_foreign_* intefaces.

2016-01-25 Thread Tim Deegan
At 12:45 + on 25 Jan (1453725932), Ian Campbell wrote: > This: > > kdd-xen.c: In function 'kdd_access_physical_page': > kdd-xen.c:508:9: warning: implicit declaration of function > 'xc_map_foreign_range' [-Wimplicit-function-declaration] > map = xc_map_foreign_range(g->xc_handle, >

Re: [Xen-devel] [PATCH] kdd: build using Werror

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 14:20 +0100, Olaf Hering wrote: > On Mon, Jan 25, Ian Campbell wrote: > > > We build most of tools using Werror and there seems to be know > > deliberate reason for this to be an exception. > > s/know/no/ ? Yes, thanks! I think I was going to write "I don't know of" and

Re: [Xen-devel] [PATCH v4] x86/p2m: use large pages for MMIO mappings

2016-01-25 Thread Jan Beulich
>>> On 25.01.16 at 13:16, wrote: > On Fri, 2016-01-22 at 08:42 -0700, Jan Beulich wrote: >> +#define MAP_MMIO_MAX_ITER 64 /* pretty arbitrary */ >> + > > I suppose no existing in-tree code exceeds that (or there'd be more patch > here). There simply is no in-tree user

Re: [Xen-devel] [PATCH] kdd: build using Werror

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > We build most of tools using Werror and there seems to be know > deliberate reason for this to be an exception. > > Signed-off-by: Ian Campbell This would have caught the kdd error. Tested-by: Olaf Hering Olaf

Re: [Xen-devel] [PATCH XEN v8 02/29] tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn.

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 14:35 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [Xen-devel] [PATCH XEN v8 02/29] tools: > Refactor /dev/xen/evtchn wrappers into libxenevtchn."): > > Various of the tools/libs/*/include/*.h have a > > > > /* Callers who don't care don't need to #include */ >

Re: [Xen-devel] [PATCH v4 19/21] arm/acpi: Initialize serial port from ACPI SPCR table

2016-01-25 Thread Jan Beulich
>>> On 23.01.16 at 10:20, wrote: > --- a/xen/include/acpi/actbl2.h > +++ b/xen/include/acpi/actbl2.h > @@ -815,6 +815,15 @@ struct acpi_table_spcr { > > #define ACPI_SPCR_DO_NOT_DISABLE(1) > > +/* SPCR Interface type */ > +#define ACPI_SPCR_TYPE_16550 0

Re: [Xen-devel] [PATCH v3 2/3] XENVER_build_id: Provide ld-embedded build-ids (v8)

2016-01-25 Thread Konrad Rzeszutek Wilk
> > > Or are you suggesting that perhaps the kernel should at boot time > > print the build-id (like it does the changset)? > > Perhaps, albeit to me that's a bit orthogonal to being able to find out > the build ID for a given binary. I looked in the mkelf32 and it looks quite easy to make the

[Xen-devel] [PATCH] tools: avoid redefinition of typedefs

2016-01-25 Thread Ian Campbell
When splitting out various functionality from libxc into tools/libs/* I attempted to make it possible to avoid callers being unnecessarily exposed to the xentoollog interface by providing a typedef of the xentoollog_logger handle in each of the headers. However such typedefs are not allowed in C,

Re: [Xen-devel] [PATCH XEN v8 02/29] tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn.

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 14:49 +, Andrew Cooper wrote: > On 25/01/16 14:47, Ian Campbell wrote: > > On Mon, 2016-01-25 at 14:35 +, Ian Jackson wrote: > > > Ian Campbell writes ("Re: [Xen-devel] [PATCH XEN v8 02/29] tools: > > > Refactor /dev/xen/evtchn wrappers into libxenevtchn."): > > > >

[Xen-devel] libxl refactoring, call for discussion

2016-01-25 Thread Pavlo Suikov
Hi everyone, I want to bring domain restart question for a discussion. It originates from DomD restart, but the solution I am about to offer can be quite generic. Problem is, domain specification currently holds only frontend info, which is used to generate both frontend and backend entries for

Re: [Xen-devel] [PATCH v3 03/17] Xen: xlate: Use page_to_xen_pfn instead of page_to_pfn

2016-01-25 Thread Stefano Stabellini
On Sat, 23 Jan 2016, Shannon Zhao wrote: > From: Shannon Zhao > > Use page_to_xen_pfn in case of 64KB page. > > Signed-off-by: Shannon Zhao Please update the commit message, something like: "Make xen_xlate_map_ballooned_pages work with 64K

Re: [Xen-devel] [PATCH v4] x86/p2m: use large pages for MMIO mappings

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 06:54 -0700, Jan Beulich wrote: > > > > On 25.01.16 at 13:16, wrote: > > On Fri, 2016-01-22 at 08:42 -0700, Jan Beulich wrote: > > > +#define MAP_MMIO_MAX_ITER 64 /* pretty arbitrary */ > > > + > > > > I suppose no existing in-tree code exceeds that

Re: [Xen-devel] [PATCH v4] x86/p2m: use large pages for MMIO mappings

2016-01-25 Thread Jan Beulich
>>> On 25.01.16 at 15:05, wrote: > On Mon, 2016-01-25 at 06:54 -0700, Jan Beulich wrote: >> > > > On 25.01.16 at 13:16, wrote: >> > On Fri, 2016-01-22 at 08:42 -0700, Jan Beulich wrote: >> > > +#define MAP_MMIO_MAX_ITER 64 /* pretty arbitrary */

Re: [Xen-devel] [PATCH v4] x86/p2m: use large pages for MMIO mappings

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 07:16 -0700, Jan Beulich wrote: > > > > On 25.01.16 at 15:05, wrote: > > On Mon, 2016-01-25 at 06:54 -0700, Jan Beulich wrote: > > > > > > On 25.01.16 at 13:16, wrote: > > > > On Fri, 2016-01-22 at 08:42 -0700, Jan Beulich

Re: [Xen-devel] [PATCH] tools/libs/*: freebsd remove unused code

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 13:27 +, Wei Liu wrote: > On Mon, Jan 25, 2016 at 01:14:34PM +, Ian Campbell wrote: > > "tools/libs/*: Use O_CLOEXEC on Linux and FreeBSD" left some dead code > > in the FreeBSD case, which breaks the build on that platform. > > > > Also fix a typo "uint_32". > > >

Re: [Xen-devel] pre Sandy bridge IOMMU support (gm45)

2016-01-25 Thread Jan Beulich
>>> On 23.01.16 at 08:38, wrote: > Thinkpad x200 p8600 laptops have vt-d, vt-x and tpm. They also have intel > integrated graphics 4 Series (gm45 chipset), supported through i915 driver. > > In December, a fix got introduced to Xen 4.6 through iommu=no-igfx switch. >

Re: [Xen-devel] [PATCH v5 2/8] ACPI: add config for BIOS table scan

2016-01-25 Thread Jan Beulich
>>> On 23.01.16 at 18:25, wrote: > Shannon Zhao writes: >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -5,6 +5,7 @@ config X86 >> def_bool y >> select COMPAT >> select HAS_ACPI >> +select ACPI_LEGACY_TABLES_LOOKUP if HAS_ACPI >

Re: [Xen-devel] [PATCH v4 10/21] acpi/table: Introduce acpi_table_get_entry_madt to get specified entry

2016-01-25 Thread Jan Beulich
>>> On 23.01.16 at 10:20, wrote: > From: Shannon Zhao > > This function could get the specified index entry of MADT table. This > would be useful when it needs to get the contens of the entry. > > Cc: Jan Beulich >

Re: [Xen-devel] [PATCH v3 09/17] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ

2016-01-25 Thread Stefano Stabellini
On Sat, 23 Jan 2016, Shannon Zhao wrote: > From: Shannon Zhao > > Add a new delivery type: > val[63:56] == 3: val[15:8] is flag: val[7:0] is a PPI. > To the flag, bit 0 stands the interrupt mode is edge(1) or level(0) and > bit 1 stands the interrupt polarity is active

Re: [Xen-devel] [PATCH v3 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI

2016-01-25 Thread Stefano Stabellini
On Sat, 23 Jan 2016, Shannon Zhao wrote: > From: Shannon Zhao > > When booting with ACPI, it could get the event-channel irq through > HVM_PARAM_CALLBACK_IRQ. > > Signed-off-by: Shannon Zhao > --- > arch/arm/xen/enlighten.c | 36

Re: [Xen-devel] [PATCH v4 3/3] VT-d: Fix vt-d Device-TLB flush timeout issue.

2016-01-25 Thread Jan Beulich
>>> On 22.01.16 at 16:57, wrote: >> On January 22, 2016 at 12:31am, wrote: >> >>> On 21.01.16 at 17:16, wrote: >> >> On January 20, 2016 at 7:29 pm, wrote: >> >> >>> On 20.01.16 at 11:26, wrote:

Re: [Xen-devel] [PATCH] kdd: Opt in to libxc compat xc_map_foreign_* intefaces.

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 13:25 +, Tim Deegan wrote: > At 12:45 + on 25 Jan (1453725932), Ian Campbell wrote: > > This: > > > > kdd-xen.c: In function 'kdd_access_physical_page': > > kdd-xen.c:508:9: warning: implicit declaration of function > > 'xc_map_foreign_range'

Re: [Xen-devel] [PATCH] kdd: build using Werror

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 13:25 +, Tim Deegan wrote: > At 13:18 + on 25 Jan (1453727891), Ian Campbell wrote: > > We build most of tools using Werror and there seems to be know > > deliberate reason for this to be an exception. > > > > Signed-off-by: Ian Campbell >

Re: [Xen-devel] [PATCH v4 07/21] arm/acpi: Print GIC information when MADT is parsed

2016-01-25 Thread Jan Beulich
>>> On 23.01.16 at 10:19, wrote: > From: Shannon Zhao > > When MADT is parsed, print GIC information to make the boot log look > pretty. > > Signed-off-by: Hanjun Guo > Signed-off-by: Tomasz Nowicki

Re: [Xen-devel] [PATCH XEN v8 02/29] tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn.

2016-01-25 Thread Andrew Cooper
On 25/01/16 14:47, Ian Campbell wrote: > On Mon, 2016-01-25 at 14:35 +, Ian Jackson wrote: >> Ian Campbell writes ("Re: [Xen-devel] [PATCH XEN v8 02/29] tools: >> Refactor /dev/xen/evtchn wrappers into libxenevtchn."): >>> Various of the tools/libs/*/include/*.h have a >>> >>> /* Callers

Re: [Xen-devel] [PATCH v10 6/7] vmx: VT-d posted-interrupt core logic handling

2016-01-25 Thread Jan Beulich
>>> On 25.01.16 at 06:26, wrote: > >> -Original Message- >> From: Dario Faggioli [mailto:dario.faggi...@citrix.com] >> Sent: Wednesday, January 20, 2016 9:31 PM >> To: Jan Beulich ; Wu, Feng >> Cc: Andrew Cooper

Re: [Xen-devel] [PATCH] kdd: Opt in to libxc compat xc_map_foreign_* intefaces.

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > Reported by: Olaf Hering Tested-by: Olaf Hering Thanks, Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH] kdd: build using Werror

2016-01-25 Thread Ian Campbell
We build most of tools using Werror and there seems to be know deliberate reason for this to be an exception. Signed-off-by: Ian Campbell --- tools/debugger/kdd/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/debugger/kdd/Makefile

Re: [Xen-devel] [PATCH v5 1/8] Kconfig: import kconfig.h from Linux 4.3

2016-01-25 Thread Jan Beulich
>>> On 23.01.16 at 09:00, wrote: > --- a/xen/include/xen/config.h > +++ b/xen/include/xen/config.h > @@ -7,7 +7,7 @@ > #ifndef __XEN_CONFIG_H__ > #define __XEN_CONFIG_H__ > > -#include > +#include Why? I don't see why all source files need to include this new

Re: [Xen-devel] [PATCH XEN v8 02/29] tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn.

2016-01-25 Thread Ian Jackson
Ian Campbell writes ("Re: [Xen-devel] [PATCH XEN v8 02/29] tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn."): > Various of the tools/libs/*/include/*.h have a > > /* Callers who don't care don't need to #include */ > typedef struct xentoollog_logger xentoollog_logger; > >

Re: [Xen-devel] [PATCH v4 18/21] arm/acpi: Add a new ACPI initialized function for UART

2016-01-25 Thread Jan Beulich
>>> On 23.01.16 at 10:20, wrote: > --- a/xen/include/xen/serial.h > +++ b/xen/include/xen/serial.h > @@ -170,7 +170,7 @@ struct ns16550_defaults { > void ns16550_init(int index, struct ns16550_defaults *defaults); > void ehci_dbgp_init(void); > > -void __init

Re: [Xen-devel] [PATCH v3 11/17] ARM: XEN: Move xen_early_init() before efi_init()

2016-01-25 Thread Stefano Stabellini
On Sat, 23 Jan 2016, Shannon Zhao wrote: > From: Shannon Zhao > > Move xen_early_init() before efi_init(), then when calling efi_init() > could initialize Xen specific UEFI. > > Check if it runs on Xen hypervisor through the flat dts. > > Signed-off-by: Shannon Zhao

Re: [Xen-devel] [PATCH V6 0/5] x86/hvm: pkeys, add memory protection-key support

2016-01-25 Thread Jan Beulich
>>> On 19.01.16 at 08:30, wrote: > Changes in v6: > *2 patches merged are not included. > *Don't write XSTATE_PKRU to PV's xcr0. > *Use "if()" instead of "?:" in cpuid handling patch. > *Update read_pkru function. > *Use value 4 instead of CONFIG_PAGING_LEVELS. > *Add

Re: [Xen-devel] [PATCH v1 00/12] HVMlite domU support

2016-01-25 Thread Boris Ostrovsky
On 01/25/2016 05:51 AM, David Vrabel wrote: On 22/01/16 21:35, Boris Ostrovsky wrote: This series introduces HVMlite support for unprivileged guests. It has been tested on Intel/AMD, both 32- and 64-bit, including CPU on- and offlining and save/restore. (Restore will result in APIC write

[Xen-devel] [PATCH] libxl: update comment to no longer mention Xen 4.3

2016-01-25 Thread Roger Pau Monne
From: Roger Pau Monne Signed-off-by: Roger Pau Monné Reported by: Konrad Rzeszutek Wilk --- Cc: Ian Jackson Cc: Ian Campbell Cc: Wei Liu ---

Re: [Xen-devel] [PATCH] kdd: build using Werror

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > We build most of tools using Werror and there seems to be know > deliberate reason for this to be an exception. s/know/no/ ? Acked-by: Olaf Hering Olaf ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH] tools/libs/*: freebsd remove unused code

2016-01-25 Thread Wei Liu
On Mon, Jan 25, 2016 at 01:14:34PM +, Ian Campbell wrote: > "tools/libs/*: Use O_CLOEXEC on Linux and FreeBSD" left some dead code > in the FreeBSD case, which breaks the build on that platform. > > Also fix a typo "uint_32". > > Signed-off-by: Ian Campbell

Re: [Xen-devel] [PATCH v1 04/12] xen/hvmlite: Bootstrap HVMlite guest

2016-01-25 Thread Boris Ostrovsky
On 01/22/2016 07:30 PM, Andrew Cooper wrote: On 22/01/2016 23:32, Luis R. Rodriguez wrote: On Fri, Jan 22, 2016 at 04:35:50PM -0500, Boris Ostrovsky wrote: + /* +* See Documentation/x86/boot.txt. +* +* Version 2.12 supports Xen entry point but we will use default

Re: [Xen-devel] [PATCH v4 08/21] arm/acpi: Parse MADT to map logical cpu to MPIDR and get cpu_possible_map

2016-01-25 Thread Jan Beulich
>>> On 23.01.16 at 10:20, wrote: > --- a/xen/include/xen/acpi.h > +++ b/xen/include/xen/acpi.h > @@ -39,6 +39,10 @@ > #define ACPI_MADT_GET_POLARITY(inti) ACPI_MADT_GET_(POLARITY, inti) > #define ACPI_MADT_GET_TRIGGER(inti) ACPI_MADT_GET_(TRIGGER, inti) > > +#define

Re: [Xen-devel] [PATCH v3 08/17] Xen: public/hvm: sync changes of HVM_PARAM_CALLBACK_VIA ABI from Xen

2016-01-25 Thread Stefano Stabellini
On Sat, 23 Jan 2016, Shannon Zhao wrote: > From: Shannon Zhao > > Sync the changes of HVM_PARAM_CALLBACK_VIA ABI introduced by > Xen commit (public/hvm: export the HVM_PARAM_CALLBACK_VIA > ABI in the API). > > Signed-off-by: Shannon Zhao

Re: [Xen-devel] [PATCH v6 15/18] tools/libxl: adjust the indentation

2016-01-25 Thread Konrad Rzeszutek Wilk
On Wed, Dec 30, 2015 at 10:29:05AM +0800, Wen Congyang wrote: > This is just tidying up after the previous automatic renaming. s/previous/ tools/libxl: rename remus device to checkpoint device patch/ > > Signed-off-by: Yang Hongyang > Signed-off-by: Wen Congyang

[Xen-devel] [linux-mingo-tip-master test] 78976: regressions - FAIL

2016-01-25 Thread osstest service owner
flight 78976 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/78976/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 5 kernel-build fail REGR. vs. 60684

Re: [Xen-devel] [PATCH RFC 3/6] x86/time: streamline platform time init on plt_init()

2016-01-25 Thread Konrad Rzeszutek Wilk
> +if ( clocksource_is_tsc ) > +{ > +plt_init(); > +} > +else > +{ > +plt_overflow_period = scale_delta( > +1ull << (pts->counter_bits-1), _scale); > +init_timer(_overflow_timer, plt_overflow, NULL, 0); > +plt_overflow(NULL); > + > +

Re: [Xen-devel] [PATCH v6 10/18] tools/libxl: export logdirty_init

2016-01-25 Thread Konrad Rzeszutek Wilk
On Wed, Dec 30, 2015 at 10:29:00AM +0800, Wen Congyang wrote: > We need to enable logdirty on secondary, so we export logdirty_init > for internal use. Rename it to libxl__logdirty_init. > > Signed-off-by: Yang Hongyang > Signed-off-by: Wen Congyang

[Xen-devel] [qemu-mainline test] 78928: trouble: broken/fail/pass

2016-01-25 Thread osstest service owner
flight 78928 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/78928/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 3 host-install(3) broken REGR.

Re: [Xen-devel] [PATCH v6 00/18] Prerequisite patches for COLO

2016-01-25 Thread Konrad Rzeszutek Wilk
On Mon, Jan 25, 2016 at 12:12:48PM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Dec 30, 2015 at 10:28:50AM +0800, Wen Congyang wrote: > > This patchset is Prerequisite for COLO feature. Refer to: > > http://wiki.xen.org/wiki/COLO_-_Coarse_Grain_Lock_Stepping > > > > It was based on the following

Re: [Xen-devel] [PATCH V6 3/5] x86/hvm: pkeys, add xstate support for pkeys

2016-01-25 Thread Jan Beulich
>>> On 19.01.16 at 08:30, wrote: > --- a/xen/arch/x86/xstate.c > +++ b/xen/arch/x86/xstate.c > @@ -579,6 +579,10 @@ int handle_xsetbv(u32 index, u64 new_bv) > if ( (new_bv & ~xfeature_mask) || !valid_xcr0(new_bv) ) > return -EINVAL; > > +/* XCR0.PKRU is

Re: [Xen-devel] [PATCH] tools: avoid redefinition of typedefs

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > When splitting out various functionality from libxc into tools/libs/* > I attempted to make it possible to avoid callers being unnecessarily > exposed to the xentoollog interface by providing a typedef of the > xentoollog_logger handle in each of the headers.

[Xen-devel] [xen-unstable-smoke test] 79021: tolerable all pass - PUSHED

2016-01-25 Thread osstest service owner
flight 79021 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/79021/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

[Xen-devel] [xen-unstable-smoke test] 79031: tolerable all pass - PUSHED

2016-01-25 Thread osstest service owner
flight 79031 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/79031/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH v5 COLOPre 07/18] migration/save: pass checkpointed_stream from libxl to libxc

2016-01-25 Thread Konrad Rzeszutek Wilk
On Mon, Jan 25, 2016 at 01:38:36PM -0500, Konrad Rzeszutek Wilk wrote: > On Thu, Dec 17, 2015 at 03:48:11PM +0800, Wen Congyang wrote: > > From: Yang Hongyang > > > > Pass checkpointed_stream from libxl to libxc. > > It won't affact legacy migration because legacy

Re: [Xen-devel] [PATCH v6 13/18] tools/libxl: rename remus device to checkpoint device

2016-01-25 Thread Konrad Rzeszutek Wilk
On Wed, Dec 30, 2015 at 10:29:03AM +0800, Wen Congyang wrote: > This patch is auto generated by the following commands: > 1. git mv tools/libxl/libxl_remus_device.c > tools/libxl/libxl_checkpoint_device.c > 2. perl -pi -e 's/libxl_remus_device/libxl_checkpoint_device/g' > tools/libxl/Makefile

Re: [Xen-devel] [PATCH v6 12/18] tools/libx{l, c}: add back channel to libxc

2016-01-25 Thread Konrad Rzeszutek Wilk
On Wed, Dec 30, 2015 at 10:29:02AM +0800, Wen Congyang wrote: > In COLO mode, both VMs are running, and are considered in sync if the > visible network traffic is identical. After some time, they fall out of > sync. > > At this point, the two VMs have definitely diverged. Lets call the >

Re: [Xen-devel] [PATCH v6 18/18] tools/libxl: seperate device init/cleanup from checkpoint device layer

2016-01-25 Thread Konrad Rzeszutek Wilk
On Wed, Dec 30, 2015 at 10:29:08AM +0800, Wen Congyang wrote: > we call (init|cleanup)_subkind_nic and (init|cleanup)_subkind_drbd_disk > directly in checkpoint device. Move them to libxl_remus.c, Call them before > calling libxl__checkpoint_devices_setup() or after calling >

Re: [Xen-devel] [PATCH 5/5] Allow all user to create a file under the directory /var/lib/xen

2016-01-25 Thread Konrad Rzeszutek Wilk
On Wed, Dec 30, 2015 at 11:00:52AM +, Andrew Cooper wrote: > On 30/12/2015 05:25, Wen Congyang wrote: > >On 12/30/2015 12:11 PM, Doug Goldstein wrote: > >>On 12/29/15 8:39 PM, Wen Congyang wrote: > >>>We may use non-root user to run qemu, and the qemu needs to write > >>>save file to

Re: [Xen-devel] [PATCH v3 13/17] ARM: Xen: Document UEFI support on Xen ARM virtual platforms

2016-01-25 Thread Stefano Stabellini
On Mon, 25 Jan 2016, Mark Rutland wrote: > On Mon, Jan 25, 2016 at 03:50:52PM +, Stefano Stabellini wrote: > > On Sat, 23 Jan 2016, Shannon Zhao wrote: > > > From: Shannon Zhao > > > > > > Add a "uefi" node under /hypervisor node in FDT, then Linux kernel could > > >

Re: [Xen-devel] [PATCH v1 04/12] xen/hvmlite: Bootstrap HVMlite guest

2016-01-25 Thread Boris Ostrovsky
On 01/22/2016 06:32 PM, Luis R. Rodriguez wrote: On Fri, Jan 22, 2016 at 04:35:50PM -0500, Boris Ostrovsky wrote: +/* + * This routine (and those that it might call) should not use + * anything that lives in .bss since that segment will be cleared later + */ +void __init

Re: [Xen-devel] [PATCH v3 2/3] XENVER_build_id: Provide ld-embedded build-ids (v8)

2016-01-25 Thread Jan Beulich
>>> On 25.01.16 at 16:16, wrote: >> >> > Or are you suggesting that perhaps the kernel should at boot time >> > print the build-id (like it does the changset)? >> >> Perhaps, albeit to me that's a bit orthogonal to being able to find out >> the build ID for a given

Re: [Xen-devel] [PATCH] tools: avoid redefinition of typedefs

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 17:24 +0100, Olaf Hering wrote: > On Mon, Jan 25, Ian Campbell wrote: > > > When splitting out various functionality from libxc into tools/libs/* > > I attempted to make it possible to avoid callers being unnecessarily > > exposed to the xentoollog interface by providing a

[Xen-devel] [PATCH 1/2] tools: rename libxc's evtchn_port_or_error_t with an xc_ prefix

2016-01-25 Thread Ian Campbell
This is used only for xc_evtchn_alloc_unbound and the legacy/compat versions of the old interfaces and avoids redefining the typedef. The evtchn_port_or_error_t name is now used only be libxenevtchn. None of the callers of xc_evtchn_alloc_unbound use the type themselves. NB

Re: [Xen-devel] [PATCH v6 16/18] tools/libxl: store remus_ops in checkpoint device state

2016-01-25 Thread Konrad Rzeszutek Wilk
On Wed, Dec 30, 2015 at 10:29:06AM +0800, Wen Congyang wrote: > Checkpoint device is an abstract layer to do checkpoint. > COLO can also use it to do checkpoint. But there are > still some codes in checkpoint device which touch remus. > > This patch and the following 2 will seperate remus from

Re: [Xen-devel] [PATCH RFC 1/6] public/xen.h: add flags field to vcpu_time_info

2016-01-25 Thread Konrad Rzeszutek Wilk
On Mon, Dec 28, 2015 at 04:59:40PM +, Joao Martins wrote: > This field has two possible flags (as of latest pvclock ABI > shared with KVM). Wish they had CC-ed xen-devel instead of just doing their change > > flags: bits in this field indicate extended capabilities > coordinated between

Re: [Xen-devel] [PATCH v3 12/17] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI

2016-01-25 Thread Stefano Stabellini
On Sat, 23 Jan 2016, Shannon Zhao wrote: > From: Shannon Zhao > > When it's a Xen domain0 booting with ACPI, it will supply a /chosen and > a /hypervisor node in DT. So check if it needs to enable ACPI. > > Signed-off-by: Shannon Zhao

Re: [Xen-devel] [PATCH V6 2/5] x86/hvm: pkeys, add pkeys support for guest_walk_tables

2016-01-25 Thread Jan Beulich
>>> On 19.01.16 at 08:30, wrote: > Signed-off-by: Huaitong Han > --- Please get used to put here per-patch info on what changed from the previous revision. > --- a/xen/arch/x86/mm/guest_walk.c > +++ b/xen/arch/x86/mm/guest_walk.c > @@ -90,6

Re: [Xen-devel] [PATCH v3 13/17] ARM: Xen: Document UEFI support on Xen ARM virtual platforms

2016-01-25 Thread Mark Rutland
On Mon, Jan 25, 2016 at 03:50:52PM +, Stefano Stabellini wrote: > On Sat, 23 Jan 2016, Shannon Zhao wrote: > > From: Shannon Zhao > > > > Add a "uefi" node under /hypervisor node in FDT, then Linux kernel could > > scan this to get the UEFI information. > > > >

Re: [Xen-devel] [PATCH v3 13/17] ARM: Xen: Document UEFI support on Xen ARM virtual platforms

2016-01-25 Thread Stefano Stabellini
On Sat, 23 Jan 2016, Shannon Zhao wrote: > From: Shannon Zhao > > Add a "uefi" node under /hypervisor node in FDT, then Linux kernel could > scan this to get the UEFI information. > > Signed-off-by: Shannon Zhao > Acked-by: Rob Herring

Re: [Xen-devel] [PATCH v3 15/17] ARM64: XEN: Add a function to initialize Xen specific UEFI runtime services

2016-01-25 Thread Stefano Stabellini
On Sat, 23 Jan 2016, Shannon Zhao wrote: > From: Shannon Zhao > > When running on Xen hypervisor, runtime services are supported through > hypercall. Add a Xen specific function to initialize runtime services. > > Signed-off-by: Shannon Zhao >

Re: [Xen-devel] [PATCH v3 14/17] XEN: EFI: Move x86 specific codes to architecture directory

2016-01-25 Thread Stefano Stabellini
On Sat, 23 Jan 2016, Shannon Zhao wrote: > From: Shannon Zhao > > Move x86 specific codes to architecture directory and export those EFI > runtime service functions. This will be useful for initializing runtime > service on ARM later. > > Signed-off-by: Shannon Zhao

Re: [Xen-devel] [PATCH V6 4/5] xen/mm: Clean up pfec handling in gva_to_gfn

2016-01-25 Thread Jan Beulich
>>> On 19.01.16 at 08:30, wrote: > At the moment, the pfec argument to gva_to_gfn has two functions: > > * To inform guest_walk what kind of access is happenind > > * As a value to pass back into the guest in the event of a fault. > > Unfortunately this is not quite

[Xen-devel] [xen-unstable test] 78926: regressions - trouble: blocked/broken/fail/pass

2016-01-25 Thread osstest service owner
flight 78926 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/78926/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 3 host-install(3) broken REGR. vs. 78610

[Xen-devel] [PATCH v5] x86/p2m: use large pages for MMIO mappings

2016-01-25 Thread Jan Beulich
When mapping large BARs (e.g. the frame buffer of a graphics card) the overhead of establishing such mappings using only 4k pages has, particularly after the XSA-125 fix, become unacceptable. Alter the XEN_DOMCTL_memory_mapping semantics once again, so that there's no longer a fixed amount of

Re: [Xen-devel] [PATCH] tools: avoid redefinition of typedefs

2016-01-25 Thread Ian Jackson
Ian Campbell writes ("[PATCH] tools: avoid redefinition of typedefs"): > When splitting out various functionality from libxc into tools/libs/* > I attempted to make it possible to avoid callers being unnecessarily > exposed to the xentoollog interface by providing a typedef of the >

Re: [Xen-devel] [PATCH] tools: avoid redefinition of typedefs

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 16:37 +, Ian Campbell wrote: > On Mon, 2016-01-25 at 17:24 +0100, Olaf Hering wrote: > > On Mon, Jan 25, Ian Campbell wrote: > > > > > When splitting out various functionality from libxc into tools/libs/* > > > I attempted to make it possible to avoid callers being

Re: [Xen-devel] [PATCH 2/2] tools: avoid redefinining xenevtchn_handle typedef for xc_suspend_*

2016-01-25 Thread Ian Jackson
Ian Campbell writes ("[PATCH 2/2] tools: avoid redefinining xenevtchn_handle typedef for xc_suspend_*"): > Similar to the previous xentoollog case this is not allowed. Switch to > a forward decl of the struct and use of it in the APIs. Both of these Acked-by: Ian Jackson

Re: [Xen-devel] [PATCH v1 02/12] xen/hvmlite: Factor out common kernel init code

2016-01-25 Thread Boris Ostrovsky
On 01/25/2016 06:04 AM, David Vrabel wrote: On 22/01/16 21:35, Boris Ostrovsky wrote: HVMlite guests (to be introduced in subsequent patches) share most of the kernel initialization code with PV(H). Where possible, HVMlite should share initialization with bare metal/HVM and not PV(H). This

  1   2   >