Re: [Xen-devel] [PATCH v2 3/3] x86: Make the GDT remapping read-only on 64 bit

* Andy Lutomirski wrote: > On Wed, Feb 1, 2017 at 1:15 AM, Ingo Molnar wrote: > > > > * Thomas Garnier wrote: > > > >> This patch makes the GDT remapped pages read-only to prevent corruption. > >> This change is done only on 64 bit. > >

Re: [Xen-devel] [PATCH v2 3/3] x86: Make the GDT remapping read-only on 64 bit

On Thu, Jan 26, 2017 at 8:59 AM, Thomas Garnier wrote: > This patch makes the GDT remapped pages read-only to prevent corruption. > This change is done only on 64 bit. > > The native_load_tr_desc function was adapted to correctly handle a > read-only GDT. The LTR instruction

Re: [Xen-devel] [PATCH v2 3/3] x86: Make the GDT remapping read-only on 64 bit

On Wed, Feb 1, 2017 at 1:15 AM, Ingo Molnar wrote: > > * Thomas Garnier wrote: > >> This patch makes the GDT remapped pages read-only to prevent corruption. >> This change is done only on 64 bit. > >> >> - table_base = gdt->address; >> +

[Xen-devel] [xen-unstable test] 105224: tolerable FAIL - PUSHED

flight 105224 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/105224/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail like 104681

Re: [Xen-devel] [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

On Wed, 2017-02-01 at 18:29 -0500, Boris Ostrovsky wrote: > > I could not convince myself that napi_synchronize() is sufficient here > (mostly because I am not familiar with napi flow). At the same time I > would rather not make changes in anticipation of possible disappearance > of

[Xen-devel] [linux-linus test] 105211: regressions - FAIL

flight 105211 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/105211/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 17 guest-localmigrate/x10fail REGR. vs. 59254 test-amd64-i386-xl

Re: [Xen-devel] [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

On 01/31/2017 12:47 PM, Boris Ostrovsky wrote: > On 01/30/2017 02:31 PM, Boris Ostrovsky wrote: >> On 01/30/2017 02:06 PM, Eric Dumazet wrote: >>> On Mon, 2017-01-30 at 13:23 -0500, Boris Ostrovsky wrote: >>> We do netif_carrier_off() first thing in xennet_disconnect_backend() and the

Re: [Xen-devel] [PATCH v3] xen/arm: fix rank/vgic lock inversion bug

On Wed, 1 Feb 2017, Julien Grall wrote: > Hi Stefano, > > CC Andre to get more feedback. > > On 31/01/2017 23:49, Stefano Stabellini wrote: > > On Fri, 27 Jan 2017, Julien Grall wrote: > > > On 03/01/17 23:29, Stefano Stabellini wrote: > > > > Always set the new physical irq affinity at the

Re: [Xen-devel] [PATCH] libxl: fix dom0 autoballooning with Xen 4.8

Jim Fehlig wrote: > xen.git commit 57f8b13c changed several of the libxl memory > get/set functions to take 64 bit parameters. The libvirt > libxl driver still uses uint32_t variables for these various > parameters, which is particularly problematic for the > libxl_set_memory_target() function. >

Re: [Xen-devel] [early RFC] ARM PCI Passthrough design document

Hi Stefano, On 01/02/2017 19:31, Stefano Stabellini wrote: On Wed, 1 Feb 2017, Julien Grall wrote: On 31/01/2017 19:06, Edgar E. Iglesias wrote: On Tue, Jan 31, 2017 at 05:09:53PM +, Julien Grall wrote: On 31/01/17 16:53, Edgar E. Iglesias wrote: On Wed, Jan 25, 2017 at 06:53:20PM

Re: [Xen-devel] Xen Security Advisory 154 (CVE-2016-2270) - x86: inconsistent cachability flags on guest mappings

On Wed, 2017-01-25 at 07:21 -0700, Jan Beulich wrote: > > Well, in the context of this XSA we've asked both of them, and iirc > we've got a vague reply from Intel and none from AMD. In fact we > did defer the XSA for quite a bit waiting for any useful feedback. > To AMD's advantage I'd like to

Re: [Xen-devel] [PATCH v2] xen: use qdev_unplug() instead of g_free() in xen_pv_find_xendev()

On 1 February 2017 at 19:37, Stefano Stabellini wrote: > Hi Peter, > > do you think this is acceptable? The set of operations here is basically what I suggested in review of v1, so I think it is the right thing. OTOH this is a bit of an odd corner of the QOM model so it

Re: [Xen-devel] [early RFC] ARM PCI Passthrough design document

Hi Stefano, On 31/01/2017 21:58, Stefano Stabellini wrote: On Wed, 25 Jan 2017, Julien Grall wrote: whilst for Device Tree the segment number is not available. So Xen needs to rely on DOM0 to discover the host bridges and notify Xen with all the relevant informations. This will be done via a

Re: [Xen-devel] [PATCH v4 14/16] kprobes: move kprobe declarations to asm-generic/kprobes.h

On Mon, Aug 29, 2016 at 11:04:18PM +0900, Masami Hiramatsu wrote: > On Tue, 23 Aug 2016 18:31:05 +0200 > "Luis R. Rodriguez" wrote: > > > On Tue, Aug 23, 2016 at 12:11:40AM +0900, Masami Hiramatsu wrote: > > > On Fri, 19 Aug 2016 14:34:12 -0700 > > > mcg...@kernel.org wrote: >

Re: [Xen-devel] [PATCH v2] xen: use qdev_unplug() instead of g_free() in xen_pv_find_xendev()

Hi Peter, do you think this is acceptable? Thanks, Stefano On Wed, 1 Feb 2017, Juergen Gross wrote: > The error exits of xen_pv_find_xendev() free the new xen-device via > g_free() which is wrong. > > As the xen-device has been initialized as qdev it must be removed > via qdev_unplug(). > >

Re: [Xen-devel] [early RFC] ARM PCI Passthrough design document

On Wed, 1 Feb 2017, Julien Grall wrote: > Hi Edgar, > > On 31/01/2017 19:06, Edgar E. Iglesias wrote: > > On Tue, Jan 31, 2017 at 05:09:53PM +, Julien Grall wrote: > > > On 31/01/17 16:53, Edgar E. Iglesias wrote: > > > > On Wed, Jan 25, 2017 at 06:53:20PM +, Julien Grall wrote: > > > > >

[Xen-devel] [xen-unstable test] 105201: regressions - FAIL

flight 105201 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/105201/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 15 guest-start/debian.repeat fail REGR. vs. 104654

[Xen-devel] [xtf test] 105216: all pass - PUSHED

flight 105216 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/105216/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf c92015f8ab00026f85d187d0090fc02e8ab4cfaf baseline version: xtf

Re: [Xen-devel] [early RFC] ARM PCI Passthrough design document

Hi Edgar, On 31/01/2017 19:06, Edgar E. Iglesias wrote: On Tue, Jan 31, 2017 at 05:09:53PM +, Julien Grall wrote: On 31/01/17 16:53, Edgar E. Iglesias wrote: On Wed, Jan 25, 2017 at 06:53:20PM +, Julien Grall wrote: On 24/01/17 20:07, Stefano Stabellini wrote: On Tue, 24 Jan 2017,

[Xen-devel] [xen-unstable-smoke test] 105218: tolerable trouble: broken/fail/pass - PUSHED

flight 105218 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/105218/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 12

Re: [Xen-devel] [PATCH] xen-netfront: Improve error handling during initialization

On 02/01/2017 10:50 AM, Ross Lagerwall wrote: > Improve error handling during initialization. This fixes a crash when > running out of grant refs when creating many queues across many netdevs. > > * Delay timer creation so that if initializing a queue fails, the timer > has not been setup yet. > *

Re: [Xen-devel] [early RFC] ARM PCI Passthrough design document

On Wed, 1 Feb 2017, Roger Pau Monné wrote: > On Wed, Jan 25, 2017 at 06:53:20PM +, Julien Grall wrote: > > Hi Stefano, > > > > On 24/01/17 20:07, Stefano Stabellini wrote: > > > On Tue, 24 Jan 2017, Julien Grall wrote: > > > > > > whilst for Device Tree the segment number is not available. >

Re: [Xen-devel] [PATCH] x86/dmop: Fix compat_dm_op() ABI

On Wed, 1 Feb 2017, Jan Beulich wrote: > >>> On 31.01.17 at 20:59, wrote: > > The parameter to compat_dm_op() is a pointer to an array of > > compat_dm_op_buf_t's in guest RAM. > > > > Signed-off-by: Andrew Cooper > > Reviewed-by: Jan

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

On Tue, Jan 31, 2017 at 04:30:50PM +, Julien Grall wrote: > Hi Dario, > > On 25/01/17 16:00, Dario Faggioli wrote: > > On Wed, 2017-01-25 at 12:38 +, Julien Grall wrote: > > > On 25/01/17 11:10, Dario Faggioli wrote: > > And a good one. I may be wrong (I certainly wasn't around at the

Re: [Xen-devel] [PATCH v2] libs/gnttab: add FreeBSD handlers for the grant-table user-space device

On Wed, Feb 01, 2017 at 05:44:55PM +, Roger Pau Monne wrote: > This patch adds the headers and helpers for the FreeBSD gntdev, used in order > to map grants from remote domains and to allocate grants on behalf of the > current domain. > > Current code has been tested with the QEMU/Qdisk

Re: [Xen-devel] [PATCH RFC 7/8] golang/xenlight: Implement libxl_scheduler enumeration

On 23/01/17 16:43, Ronald Rojas wrote: > Include both constants and a Stringification for libxl_scheduler. > > Signed-off-by: George Dunlap > Signed-off-by: Ronald Rojas > --- > tools/golang/xenlight/xenlight.go | 62 >

Re: [Xen-devel] [PATCH RFC 6/8] golang/xenlight: Implement libxl_bitmap and helper operations

On 23/01/17 16:43, Ronald Rojas wrote: > Implement Bitmap type, along with helper functions. > > The Bitmap type is implemented interllay in a way which makes it > easy to copy into and out of the C libxl_bitmap type. > > Signed-off-by: George Dunlap > Signed-off-by:

[Xen-devel] [PATCH] VT-d/RMRR: Adjust the return values of register_one_rmrr()

Adjust/manage the return values of register_one_rmrr() such that new callers log errors for non-debug builds too, while not affecting the behavior of original callers. Signed-off-by: Venu Busireddy --- xen/drivers/passthrough/vtd/dmar.c | 7 --- 1 file changed, 4

[Xen-devel] [PATCH v2] libs/gnttab: add FreeBSD handlers for the grant-table user-space device

This patch adds the headers and helpers for the FreeBSD gntdev, used in order to map grants from remote domains and to allocate grants on behalf of the current domain. Current code has been tested with the QEMU/Qdisk backend. Signed-off-by: Akshay Jaggi [ added dummy

Re: [Xen-devel] [PATCH RFC 5/8] golang/xenlight: Add tests host related functinality functions

On 23/01/17 16:43, Ronald Rojas wrote: > Create tests for the following functions: > - GetVersionInfo > - GetPhysinfo > - GetDominfo > - GetMaxCpus > - GetOnlineCpus > - GetMaxNodes > - GetFreeMemory > > Signed-off-by: Ronald Rojas Hey Ronald, Sorry this has taken a long

Re: [Xen-devel] [PATCH v3 09/11] fuzz/x86emul: update fuzzer

This patch will be squashed in. From 4990d760f900223e32cb800e7374ee45d357081b Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Wed, 1 Feb 2017 16:54:58 + Subject: [PATCH] fixup! fuzz/x86emul: update fuzzer --- .../x86-insn-emulator-fuzzer.c | 18

[Xen-devel] [xen-unstable-smoke test] 105212: tolerable trouble: broken/fail/pass - PUSHED

flight 105212 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/105212/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 12

Re: [Xen-devel] [PATCH v3] xen/arm: fix rank/vgic lock inversion bug

Hi Stefano, CC Andre to get more feedback. On 31/01/2017 23:49, Stefano Stabellini wrote: On Fri, 27 Jan 2017, Julien Grall wrote: On 03/01/17 23:29, Stefano Stabellini wrote: Always set the new physical irq affinity at the beginning of vgic_migrate_irq, in all cases. No need to set

Re: [Xen-devel] [XTF PATCH] build: disable PIE during linking if necessary

On 01/02/17 16:27, Jan Beulich wrote: On 01.02.17 at 17:21, wrote: >> --- a/build/common.mk >> +++ b/build/common.mk >> @@ -50,6 +50,15 @@ obj-perarch := >> obj-perenv := >> include $(ROOT)/build/files.mk >> >> + >> +cc-option = $(shell if [ -z "`echo 'int p=1;' |

Re: [Xen-devel] [XTF PATCH] build: disable PIE during linking if necessary

>>> On 01.02.17 at 17:21, wrote: > --- a/build/common.mk > +++ b/build/common.mk > @@ -50,6 +50,15 @@ obj-perarch := > obj-perenv := > include $(ROOT)/build/files.mk > > + > +cc-option = $(shell if [ -z "`echo 'int p=1;' | $(CC) $(1) -S -o /dev/null > -x c - 2>&1`" ]; \

Re: [Xen-devel] [XTF PATCH] build: disable PIE during linking if necessary

On Wed, Feb 01, 2017 at 04:23:53PM +, Andrew Cooper wrote: > On 01/02/17 16:21, Wei Liu wrote: > > Starting from ee3e265688, $(CC) is used for linking. That means all > > default $(CC) flags coming from distro takes effect. > > > > On Debian Stretch, gcc contains -pie by default, which makes

Re: [Xen-devel] [XTF PATCH] build: disable PIE during linking if necessary

On 01/02/17 16:21, Wei Liu wrote: > Starting from ee3e265688, $(CC) is used for linking. That means all > default $(CC) flags coming from distro takes effect. > > On Debian Stretch, gcc contains -pie by default, which makes the final > object fail to link. We need to explicitly disable PIE when

[Xen-devel] [XTF PATCH] build: disable PIE during linking if necessary

Starting from ee3e265688, $(CC) is used for linking. That means all default $(CC) flags coming from distro takes effect. On Debian Stretch, gcc contains -pie by default, which makes the final object fail to link. We need to explicitly disable PIE when linking. Since not all versions of gcc

Re: [Xen-devel] [PATCH RFC 4/8] golang/xenlight: Implement libxl_domain_info and libxl_domain_unpause

On 23/01/17 16:43, Ronald Rojas wrote: > Add calls for the following host-related functionality: > - libxl_domain_info > - libxl_domain_unpause > > Include Golang version for the libxl_domain_info as > DomainInfo. > > Signed-off-by: George Dunlap > Signed-off-by:

Re: [Xen-devel] [PATCH RFC 3/8] golang/xenlight: Add host-related functionality

On 23/01/17 16:43, Ronald Rojas wrote: > Add calls for the following host-related functionality: > - libxl_get_max_cpus > - libxl_get_online_cpus > - libxl_get_max_nodes > - libxl_get_free_memory > - libxl_get_physinfo > - libxl_get_version_info > > Include Golang versions of the following

Re: [Xen-devel] [PATCH RFC 3/8] golang/xenlight: Add host-related functionality

On 23/01/17 16:43, Ronald Rojas wrote: > Add calls for the following host-related functionality: > - libxl_get_max_cpus > - libxl_get_online_cpus > - libxl_get_max_nodes > - libxl_get_free_memory > - libxl_get_physinfo > - libxl_get_version_info > > Include Golang versions of the following

Re: [Xen-devel] [PATCH RFC 3/8] golang/xenlight: Add host-related functionality

On 23/01/17 16:43, Ronald Rojas wrote: > Add calls for the following host-related functionality: > - libxl_get_max_cpus > - libxl_get_online_cpus > - libxl_get_max_nodes > - libxl_get_free_memory > - libxl_get_physinfo > - libxl_get_version_info > > Include Golang versions of the following

[Xen-devel] [PATCH] xen-netfront: Improve error handling during initialization

Improve error handling during initialization. This fixes a crash when running out of grant refs when creating many queues across many netdevs. * Delay timer creation so that if initializing a queue fails, the timer has not been setup yet. * If creating queues fails (i.e. there are no grant refs

Re: [Xen-devel] [PATCH v2] acpi: Switch to dynamic mapping at SYS_STATE_boot

>>> On 01.02.17 at 15:31, wrote: > We can switch ACPI from using fixmap to dynamic mapping as soon as > the system enters SYS_STATE_boot. This will allow us, for example, > to map MADT on systems with large number of processors where the > table might not fit into

Re: [Xen-devel] [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback

On Wed, Feb 01, 2017 at 02:30:53PM +, Julien Grall wrote: > Hi Konrad, > > On 01/02/2017 14:25, Konrad Rzeszutek Wilk wrote: > > On Wed, Feb 01, 2017 at 12:46:32PM +0200, Andrii Anisov wrote: > > > Yup, > > > > > > Following is wrong: > > > > DEBUG macro could be globally across drivers

Re: [Xen-devel] [PATCH] xen: credit2: clear bit instead of skip step in runq_tickle()

On 26/01/17 01:00, Dario Faggioli wrote: > On Wed, 2017-01-18 at 03:30 -0700, Jan Beulich wrote: > On 18.01.17 at 11:21, wrote: >>> On 18/01/17 00:30, Dario Faggioli wrote: index ef8e0d8..d086264 100644 --- a/xen/common/sched_credit2.c +++

Re: [Xen-devel] [PATCH] xen: sched: improve debug dump output.

On 26/01/17 16:52, Dario Faggioli wrote: > Scheduling information debug dump for Credit2 is hard > to read as it contains the same information repeated > multiple time in different ways. > > In fact, in Credit2, CPUs are grouped in runqueus. > Here's the current debug output: > > CPU[00]

Re: [Xen-devel] [PATCH v3] xenstore: remove XS_RESTRICT support

On 27/01/17 12:47, Juergen Gross wrote: > XS_RESTRICT and the xenstore library function xs_restrict() have never > been usable in all configurations and there are no known users. > > This functionality was thought to limit access rights of device models > to xenstore in order to avoid affecting

Re: [Xen-devel] [PATCH] xen: credit2: non Credit2 pCPUs are ok during shutdown/suspend.

On 28/01/17 01:42, Dario Faggioli wrote: > Commit 7478ebe1602e6 ("xen: credit2: fix shutdown/suspend > when playing with cpupools"), while doing the right thing > for actual code, forgot to update the ASSERT()s accordingly, > in csched2_vcpu_migrate(). > > In fact, as stated there already, during

Re: [Xen-devel] [PATCH] xen/tools: tracing: credits can go negative, so use int.

On 18/01/17 11:32, Dario Faggioli wrote: > For Credit2, in both the trace records, inside Xen, > and in their parsing, in xenalyze. > > In fact, as it is quite a bit better, in order to > understand how much negative credits have gone for > a certain vCPU, to see an actual negative number, > as

[Xen-devel] [PATCH v2] acpi: Switch to dynamic mapping at SYS_STATE_boot

We can switch ACPI from using fixmap to dynamic mapping as soon as the system enters SYS_STATE_boot. This will allow us, for example, to map MADT on systems with large number of processors where the table might not fit into NUM_FIXMAP_ACPI_PAGES (currently set to 4). To avoid having a window

Re: [Xen-devel] [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback

Hi Konrad, On 01/02/2017 14:25, Konrad Rzeszutek Wilk wrote: On Wed, Feb 01, 2017 at 12:46:32PM +0200, Andrii Anisov wrote: Yup, Following is wrong: DEBUG macro could be globally across drivers defined by CONFIG_DEBUG_DRIVERS. See drivers/base/Makefile. DEBUG is not defined globally. And

Re: [Xen-devel] [PATCH] xen: credit2: improve debug dump output.

On 18/01/17 01:10, Dario Faggioli wrote: > Scheduling information debug dump for Credit2 is hard > to read as it contains the same information repeated > multiple time in different ways. > > In fact, in Credit2, CPUs are grouped in runqueus. Before > this change, for each CPU, we were printing

Re: [Xen-devel] [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback

On Wed, Feb 01, 2017 at 12:46:32PM +0200, Andrii Anisov wrote: > Yup, > > Following is wrong: > > DEBUG macro could be globally across drivers defined by > > CONFIG_DEBUG_DRIVERS. See drivers/base/Makefile. > DEBUG is not defined globally. And there is no debug option to enable > DEBUG in

Re: [Xen-devel] [PATCH v3 1/2] swiotlb-xen: implement xen_swiotlb_dma_mmap callback

On Wed, Feb 01, 2017 at 01:46:48PM +0200, Andrii Anisov wrote: > Konrad, Stefano, > > >> What does 'local pages' mean? > > > > A page that belongs to this domain, rather than a foreign page that has > > been mapped. > I guess it should be clarified, but not sure in the commit message or > comment

Re: [Xen-devel] [PATCH] xen: Kconfig: Add DEBUG_XEN config option

On Wed, Feb 01, 2017 at 02:12:13PM +0100, Juergen Gross wrote: > On 01/02/17 13:55, Julien Grall wrote: > > Hi Juergen, > > > > On 01/02/2017 12:17, Juergen Gross wrote: > >> On 01/02/17 12:19, Andrii Anisov wrote: > >>> From: Andrii Anisov > >>> > >>> Add a debug option

[Xen-devel] [xen-unstable-smoke test] 105207: tolerable trouble: broken/fail/pass - PUSHED

flight 105207 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/105207/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 12

Re: [Xen-devel] [PATCH v3 04/11] x86emul/test: use x86-vendors.h

On Wed, Feb 01, 2017 at 01:13:44PM +, Andrew Cooper wrote: > On 01/02/17 13:09, Jan Beulich wrote: > On 01.02.17 at 13:02, wrote: > >> --- a/tools/fuzz/x86_instruction_emulator/Makefile > >> +++ b/tools/fuzz/x86_instruction_emulator/Makefile > >> @@ -11,10 +11,15 @@

Re: [Xen-devel] [PATCH v3 04/11] x86emul/test: use x86-vendors.h

>>> On 01.02.17 at 14:13, wrote: > On 01/02/17 13:09, Jan Beulich wrote: > On 01.02.17 at 13:02, wrote: >>> --- a/tools/fuzz/x86_instruction_emulator/Makefile >>> +++ b/tools/fuzz/x86_instruction_emulator/Makefile >>> @@ -11,10 +11,15 @@ endif

[Xen-devel] [linux-linus test] 105176: regressions - FAIL

flight 105176 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/105176/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 17 guest-localmigrate/x10fail REGR. vs. 59254

Re: [Xen-devel] [PATCH v3 04/11] x86emul/test: use x86-vendors.h

On 01/02/17 13:09, Jan Beulich wrote: On 01.02.17 at 13:02, wrote: >> --- a/tools/fuzz/x86_instruction_emulator/Makefile >> +++ b/tools/fuzz/x86_instruction_emulator/Makefile >> @@ -11,10 +11,15 @@ endif >> x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h: >> [

Re: [Xen-devel] [PATCH] xen: Kconfig: Add DEBUG_XEN config option

On 01/02/17 13:55, Julien Grall wrote: > Hi Juergen, > > On 01/02/2017 12:17, Juergen Gross wrote: >> On 01/02/17 12:19, Andrii Anisov wrote: >>> From: Andrii Anisov >>> >>> Add a debug option to enable xen drivers debug code. >>> >>> Signed-off-by: Andrii Anisov

Re: [Xen-devel] [PATCH v3 02/11] x86: extract macros to x86-defns.h

>>> On 01.02.17 at 13:02, wrote: > --- a/xen/include/asm-x86/processor.h > +++ b/xen/include/asm-x86/processor.h > @@ -16,6 +16,8 @@ > #include > #endif > > +#include "x86-defns.h" This should be . With that adjusted, Reviewed-by: Jan Beulich Jan

Re: [Xen-devel] [PATCH v3 01/11] x86emul/test: add missing dependency for x86_emulate.o

>>> On 01.02.17 at 13:02, wrote: > --- a/tools/tests/x86_emulator/Makefile > +++ b/tools/tests/x86_emulator/Makefile > @@ -45,7 +45,7 @@ x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h: > > HOSTCFLAGS += $(CFLAGS_xeninclude) > > -x86_emulate.o: x86_emulate.c

Re: [Xen-devel] [PATCH] xen: Kconfig: Add DEBUG_XEN config option

Dear Juergen, > In future you might want to add the maintainers to the recipient list. Yep, I would take care to not miss this point. And +1 to Julien's comment. Sincerely, Andrii Anisov. ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH] xen: Kconfig: Add DEBUG_XEN config option

Hi Juergen, On 01/02/2017 12:17, Juergen Gross wrote: On 01/02/17 12:19, Andrii Anisov wrote: From: Andrii Anisov Add a debug option to enable xen drivers debug code. Signed-off-by: Andrii Anisov In future you might want to add the

[Xen-devel] [PATCH v3 10/11] fuzz/x86emul: print out minimal input size

... so that users can know how big the initial input should be. Signed-off-by: Wei Liu Reviewed-by: Jan Beulich --- .../fuzz/x86_instruction_emulator/afl-x86-insn-emulator-fuzzer.c | 8

[Xen-devel] [PATCH v3 11/11] fuzz: update README.afl example

Signed-off-by: Wei Liu Acked-by: Jan Beulich --- tools/fuzz/README.afl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/fuzz/README.afl b/tools/fuzz/README.afl index 431b4a8cbf..68e0fa396f 100644 --- a/tools/fuzz/README.afl

Re: [Xen-devel] [PATCH] xen: Kconfig: Add DEBUG_XEN config option

On 01/02/17 12:19, Andrii Anisov wrote: > From: Andrii Anisov > > Add a debug option to enable xen drivers debug code. > > Signed-off-by: Andrii Anisov In future you might want to add the maintainers to the recipient list. > --- >

[Xen-devel] [PATCH v3 00/11] fuzz: update x86emul fuzzer

The first few patches refactor x86emul code so that more code can be shared between xen and userspace tools. I have run XTF suite (tests subject to availability on the testbox I use, and xsa-195 was skipped because qemu segfault -- a known issue) against this series, no issue is found. Please

[Xen-devel] [PATCH v3 04/11] x86emul/test: use x86-vendors.h

No functional change. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper V3: link asm-x86 to working directory --- tools/fuzz/x86_instruction_emulator/Makefile | 9 +++-- tools/tests/x86_emulator/Makefile

[Xen-devel] [PATCH v3 08/11] x86emul: use CR definitions in x86-defns.h

And remove the duplicates. No functional change. Signed-off-by: Wei Liu Reviewed-by: Jan Beulich --- xen/arch/x86/x86_emulate/x86_emulate.c | 45 -- 1 file changed, 15 insertions(+), 30 deletions(-) diff --git

[Xen-devel] [PATCH v3 05/11] x86emul: use eflags definitions in x86-defns.h

Basically this patch does 's/EFLG_/X86_EFLAGS_/g' and with indentation fixed up. And remove the duplicates in x86_emualte.c. This in turn requires userspace test harness to include x86-defns.h. Also remove a few duplicates in userspace harness program. No functional change. Signed-off-by: Wei

[Xen-devel] [PATCH v3 06/11] x86emul: use msr definitions in msr-index.h

Change the names used in code according to numeric values. Remove the now unused macros in x86_emualte.c and fix indentation. This in turns requires including msr-index.h and removing duplicates in userspace x86_emulate.c in userspace harness program. No functional change. Signed-off-by: Wei

[Xen-devel] [PATCH v3 02/11] x86: extract macros to x86-defns.h

... so that they can be used by userspace x86 instruction emulator test program and fuzzer as well. No functional change. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper v3: Don't move TRAP_* ---

[Xen-devel] [PATCH v3 07/11] x86: add UMIP CR4 bit

It will be used later to remove duplicates in x86emul. Signed-off-by: Wei Liu Reviewed-by: Jan Beulich --- xen/include/asm-x86/x86-defns.h | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/include/asm-x86/x86-defns.h

[Xen-devel] [PATCH v3 03/11] x86: extract vendor numeric id to x86-vendors.h

They will be shared between xen and userspace programs. This is not strictly necessary, but it helps reduce overall code size. No functional change. Signed-off-by: Wei Liu Acked-by: Jan Beulich --- xen/include/asm-x86/processor.h | 10 +-

[Xen-devel] [PATCH v3 09/11] fuzz/x86emul: update fuzzer

Provide the fuzzer with more ops, and more sophisticated input structure. Based on a patch originally written by Andrew and George. Signed-off-by: Andrew Cooper Signed-off-by: George Dunlap Signed-off-by: Wei Liu ---

[Xen-devel] [PATCH v3 01/11] x86emul/test: add missing dependency for x86_emulate.o

f4497d6b74 added x86_emulate.h private header but didn't add dependency for it. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper --- tools/tests/x86_emulator/Makefile | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Xen-devel] [PATCH] x86/dmop: Fix compat_dm_op() ABI

On 01/02/17 10:46, Jan Beulich wrote: On 31.01.17 at 20:59, wrote: >> What is the pupose of COMPAT_HANDLE_PARAM()? It is a packed structure of one >> and a half pointers, so isn't safe at all for use in the hypercall function >> APIs (depsite its naming making it

Re: [Xen-devel] [PATCH v3 1/2] swiotlb-xen: implement xen_swiotlb_dma_mmap callback

Konrad, Stefano, >> What does 'local pages' mean? > > A page that belongs to this domain, rather than a foreign page that has > been mapped. I guess it should be clarified, but not sure in the commit message or comment to the code? Sincerely, Andrii Anisov.

Re: [Xen-devel] [PATCH] x86/HVM: make hvm_find_io_handler() static

> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 01 February 2017 11:24 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > > Subject: [PATCH] x86/HVM: make

[Xen-devel] [xen-unstable-coverity test] 105200: all pass - PUSHED

flight 105200 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/105200/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 5a44ff111d2e1ba9f375936294117ff4e263c4ac baseline version: xen

[Xen-devel] [PATCH] x86/HVM: make hvm_find_io_handler() static

This reduces the chance of misuse - calling it must in particular always be accompanied by calling the corresponding ->complete() hook. Constify its parameter at once. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/intercept.c +++ b/xen/arch/x86/hvm/intercept.c @@ -210,7

[Xen-devel] [PATCH v2 11/11] x86emul: test coverage for SSE/SSE2 insns

... and their AVX equivalents. Note that a few instructions aren't covered (yet), but those all fall into common pattern groups, so I would hope that for now we can do with what is there. MMX insns aren't being covered at all, as they're not easy to deal with: The compiler refuses to emit such

[Xen-devel] [PATCH] xen: Kconfig: Add DEBUG_XEN config option

From: Andrii Anisov Add a debug option to enable xen drivers debug code. Signed-off-by: Andrii Anisov --- drivers/xen/Kconfig | 8 drivers/xen/Makefile | 2 ++ 2 files changed, 10 insertions(+) diff --git a/drivers/xen/Kconfig

[Xen-devel] [PATCH v2 10/11] x86emul/test: split generic and testcase specific parts

Both the build logic and the invocation have their blowfish specific aspects abstracted out here. Additionally - run native execution (if suitable) first (as that one failing suggests a problem with the to be tested code itself, in which case having the emulator have a go over it is kind of

[Xen-devel] [PATCH v2 09/11] x86emul: support {,V}MOVNTDQA

... as the only post-SSE2 move insn. Signed-off-by: Jan Beulich --- v2: Re-base. --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -2389,6 +2389,74 @@ int main(int argc, char **argv) else

[Xen-devel] [PATCH v2 08/11] x86emul: support {,V}{LD,ST}MXCSR

Signed-off-by: Jan Beulich --- a/tools/fuzz/x86_instruction_emulator/x86-insn-emulator-fuzzer.c +++ b/tools/fuzz/x86_instruction_emulator/x86-insn-emulator-fuzzer.c @@ -119,7 +119,7 @@ int LLVMFuzzerTestOneInput(const uint8_t unsigned int x; const uint8_t *p =

[Xen-devel] [PATCH v2 07/11] x86emul: support MMX/SSE/SSE2 insns with only register operands

This involves fixing a decode bug: VEX encoded insns aren't necessarily followed by a ModR/M byte. Signed-off-by: Jan Beulich --- v2: Correct {,v}pextrw operand descriptor. --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -269,10

[Xen-devel] [PATCH v2 04/11] x86emul: support MMX/SSE/SSE2 moves

Previously supported insns are being converted to the new model, and several new ones are being added. To keep the stub handling reasonably simple, integrate SET_SSE_PREFIX() into copy_REX_VEX(), at once switching the stubs to use an empty REX prefix instead of a double DS: one (no byte registers

[Xen-devel] [PATCH v2 03/11] x86emul: support most memory accessing MMX/SSE/SSE2 insns

This aims at covering most MMX/SSEn/AVX instructions in the 0x0f-escape space with memory operands. Not covered here are irregular moves, converts, and {,U}COMIS{S,D} (modifying EFLAGS). Note that the distinction between simd_*_fp isn't strictly needed, but I've kept them as separate entries

[Xen-devel] [PATCH v2 01/11] x86emul: catch exceptions occurring in stubs

Before adding more use of stubs cloned from decoded guest insns, guard ourselves against mistakes there: Should an exception (with the noteworthy exception of #PF) occur inside the stub, forward it to the guest. Since the exception fixup table entry can't encode the address of the faulting insn

[Xen-devel] [PATCH v2 02/11] x86emul: flatten twobyte_table[]

... in the hope of making it more readable, and in preparation of adding a second field to the structure. Signed-off-by: Jan Beulich --- v2: Split off from subsequent patch, to (hopefully) aid review. --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++

Re: [Xen-devel] [PATCH] x86emul: correct behavior for single iteration REP INS/OUTS

On Wed, Feb 01, 2017 at 03:59:16AM -0700, Jan Beulich wrote: > The initial operation done on these paths may raise an exception (for > ->read_io() that's possible only on the PV path, when the I/O port > access check has been deferred). We have to suppress put_rep_prefix() > updating rCX in that

[Xen-devel] [PATCH v2 00/11] x86emul: MMX/SSE/SSE2 support

This includes support for AVX counterparts of them as well as a few later SSE additions (basically covering the entire 0f-prefixed opcode space, but not the 0f38 and 0f3a ones, nor 3dnow). 1: catch exceptions occurring in stubs 2: flatten twobyte_table[] 3: support most memory accessing

Re: [Xen-devel] Xen and user requests.

Any idea? On Mon, 1/30/17, Jason Long wrote: Subject: Xen and user requests. To: "Xen-users" , "Xen-devel" Date: Monday, January 30, 2017, 4:01 AM Hello.Xen Project

[Xen-devel] [PATCH] x86emul: correct behavior for single iteration REP INS/OUTS

The initial operation done on these paths may raise an exception (for ->read_io() that's possible only on the PV path, when the I/O port access check has been deferred). We have to suppress put_rep_prefix() updating rCX in that case. From an abstract perspective this also applies to RETRY being

Re: [Xen-devel] [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback

On 01/02/2017 10:57, Julien Grall wrote: Hi, On 01/02/2017 10:42, Andrii Anisov wrote: Ah! Ops :-) DEBUG_KERNEL? You said DEBUG_DRIVER last time. Both DEBUG_KERNEL and DEBUG_DRIVER are not used in code. DEBUG_KERNEL is used through Kconfigs to make available debug options to other

Re: [Xen-devel] [PATCH 1/2] x86/VMX: introduce vmx_find_guest_msr()

>>> On 01.02.17 at 11:43, wrote: > On Wed, 2017-02-01 at 03:19 -0700, Jan Beulich wrote: >> > >> > > >> > > > >> > > > On 01.02.17 at 10:38, wrote: >> > On Tue, 2017-01-31 at 05:43 -0700, Jan Beulich wrote: >> > > >> > > > >> > > > >> > >

  1   2   >