Re: [Xen-devel] [PATCH 0/2] libxl: add PV display device driver interface

2017-03-27 Thread Wei Liu
On Fri, Mar 24, 2017 at 12:35:22PM +0200, Oleksandr Grytsov wrote: > To summarize: > > There are two ways to rework the patches: > > 1. Keep interface between xl an libxl as is and put duplicated code into > libxl_device_type specific functions. > > 2. Change interface to call libxl_device_type

Re: [Xen-devel] [PATCH 0/2] libxl: add PV display device driver interface

2017-03-24 Thread Oleksandr Grytsov
On 23.03.17 17:55, al1img . wrote: On Thu, Mar 23, 2017 at 4:58 PM, Juergen Gross wrote: On 23/03/17 15:23, al1img . wrote: This example is clear. But still wrapper macro is required to make it visible for libxen client (xl): #define LIBXL_DEFINE_DEVICE_LIST_FREE(type)

Re: [Xen-devel] [PATCH 0/2] libxl: add PV display device driver interface

2017-03-23 Thread al1img .
On Thu, Mar 23, 2017 at 4:58 PM, Juergen Gross wrote: > On 23/03/17 15:23, al1img . wrote: >> This example is clear. But still wrapper macro is required to make it >> visible for libxen client (xl): >> >> #define LIBXL_DEFINE_DEVICE_LIST_FREE(type) >> void

Re: [Xen-devel] [PATCH 0/2] libxl: add PV display device driver interface

2017-03-23 Thread Juergen Gross
On 23/03/17 15:23, al1img . wrote: > This example is clear. But still wrapper macro is required to make it > visible for libxen client (xl): > > #define LIBXL_DEFINE_DEVICE_LIST_FREE(type) > void libxl_device_##type##_list_free(libxl_device_##type* list, int nr) > { >

Re: [Xen-devel] [PATCH 0/2] libxl: add PV display device driver interface

2017-03-23 Thread al1img .
This example is clear. But still wrapper macro is required to make it visible for libxen client (xl): #define LIBXL_DEFINE_DEVICE_LIST_FREE(type) void libxl_device_##type##_list_free(libxl_device_##type* list, int nr) { libxl__device_list_free(libxl__##type##_devtype, list, nr);

Re: [Xen-devel] [PATCH 0/2] libxl: add PV display device driver interface

2017-03-23 Thread Juergen Gross
On 23/03/17 12:32, al1img . wrote: > Hi Juergen, > > I've checked the mentioned commits. And I don't see how it can be done. > The duplication I see it is in libxl_device_type.add and > libxl_device_type.list functions > for different PV devices. These functions have a lot of common code > which

Re: [Xen-devel] [PATCH 0/2] libxl: add PV display device driver interface

2017-03-23 Thread al1img .
Hi Juergen, I've checked the mentioned commits. And I don't see how it can be done. The duplication I see it is in libxl_device_type.add and libxl_device_type.list functions for different PV devices. These functions have a lot of common code which I've tried to move to macros in my patches.

Re: [Xen-devel] [PATCH 0/2] libxl: add PV display device driver interface

2017-03-23 Thread Juergen Gross
On 23/03/17 11:10, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Hi all, > > We are working on series of PV drivers (display, sound, input etc.) and > would like to add their support to libxl and xl. These patches add PV display > device. PV display is

[Xen-devel] [PATCH 0/2] libxl: add PV display device driver interface

2017-03-23 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Hi all, We are working on series of PV drivers (display, sound, input etc.) and would like to add their support to libxl and xl. These patches add PV display device. PV display is based on [1] protocol. During implementation I see a lot of