[Xen-devel] [seabios test] 118275: regressions - FAIL

flight 118275 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/118275/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which did not

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

On 23/01/18 07:34, Juergen Gross wrote: > On 22/01/18 19:39, Andrew Cooper wrote: >> On 22/01/18 16:51, Jan Beulich wrote: >> On 22.01.18 at 16:00, wrote: On 22/01/18 15:48, Jan Beulich wrote: On 22.01.18 at 15:38, wrote: >> On 22/01/18

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

On 22/01/18 22:45, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 22, 2018 at 01:32:44PM +0100, Juergen Gross wrote: >> As a preparation for doing page table isolation in the Xen hypervisor >> in order to mitigate "Meltdown" use dedicated stacks, GDT and TSS for >> 64 bit PV domains mapped to the

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

On 22/01/18 19:39, Andrew Cooper wrote: > On 22/01/18 16:51, Jan Beulich wrote: > On 22.01.18 at 16:00, wrote: >>> On 22/01/18 15:48, Jan Beulich wrote: >>> On 22.01.18 at 15:38, wrote: > On 22/01/18 15:22, Jan Beulich wrote: > On 22.01.18 at

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

On 22/01/18 17:51, Jan Beulich wrote: On 22.01.18 at 16:00, wrote: >> On 22/01/18 15:48, Jan Beulich wrote: >> On 22.01.18 at 15:38, wrote: On 22/01/18 15:22, Jan Beulich wrote: On 22.01.18 at 15:18, wrote: >> On

Re: [Xen-devel] PVH backports to 4.9 and 4.8

George Dunlap: > Part of our solution to XSA-254 SP3 (aka "Meltdown") is to backport > the PVH mode from 4.10 to 4.9 and 4.8. This will first allow people > able to run PVH kernels to switch their PV guests directly to PVH > guests; and second, eventually enable the backport of patches which >

[Xen-devel] [linux-next test] 118267: regressions - trouble: broken/fail/pass

flight 118267 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/118267/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair broken test-amd64-i386-libvirt-xsm

[Xen-devel] [qemu-mainline test] 118270: tolerable FAIL - PUSHED

flight 118270 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/118270/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 118253 test-armhf-armhf-libvirt 14

Re: [Xen-devel] [PATCH v9 06/11] x86/entry: Organise the use of MSR_SPEC_CTRL at each entry/exit point

On 01/22/2018 07:17 PM, Andrew Cooper wrote: On 22/01/2018 22:27, Boris Ostrovsky wrote: On 01/19/2018 08:36 AM, Andrew Cooper wrote: On 19/01/18 11:43, Jan Beulich wrote: @@ -99,6 +106,10 @@ UNLIKELY_END(realmode) .Lvmx_vmentry_fail: sti SAVE_ALL + +

[Xen-devel] [linux-linus test] 118268: trouble: blocked/broken/fail/pass

flight 118268 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/118268/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-raw broken

Re: [Xen-devel] Xen fails to boot inside QEMU on x86, no VMX

On 23/01/2018 00:38, Stefano Stabellini wrote: > On Tue, 23 Jan 2018, Andrew Cooper wrote: >> On 22/01/2018 23:48, Stefano Stabellini wrote: >>> Hi all, >>> >>> Running Xen inside QEMU x86 without KVM acceleartion and without VMX >>> emulation leads to the failure appended below. >>> >>> This

Re: [Xen-devel] Xen fails to boot inside QEMU on x86, no VMX

On Tue, 23 Jan 2018, Andrew Cooper wrote: > On 22/01/2018 23:48, Stefano Stabellini wrote: > > Hi all, > > > > Running Xen inside QEMU x86 without KVM acceleartion and without VMX > > emulation leads to the failure appended below. > > > > This trivial workaround "fixes" the problem: > > > > diff

[Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

When booting Xen via UEFI the Xen config file can contain multiple sections each describing different boot options. It is currently only possible to choose which section to boot with if the buffer contains a string. UEFI provides a different standard to pass optional arguments to an application,

Re: [Xen-devel] [PATCH v9 06/11] x86/entry: Organise the use of MSR_SPEC_CTRL at each entry/exit point

On 22/01/2018 22:27, Boris Ostrovsky wrote: > On 01/19/2018 08:36 AM, Andrew Cooper wrote: >> On 19/01/18 11:43, Jan Beulich wrote: >> @@ -99,6 +106,10 @@ UNLIKELY_END(realmode) .Lvmx_vmentry_fail: sti SAVE_ALL + +SPEC_CTRL_ENTRY_FROM_PV /*

Re: [Xen-devel] Xen fails to boot inside QEMU on x86, no VMX

On 22/01/2018 23:48, Stefano Stabellini wrote: > Hi all, > > Running Xen inside QEMU x86 without KVM acceleartion and without VMX > emulation leads to the failure appended below. > > This trivial workaround "fixes" the problem: > > diff --git a/xen/arch/x86/extable.c b/xen/arch/x86/extable.c >

[Xen-devel] Xen fails to boot inside QEMU on x86, no VMX

Hi all, Running Xen inside QEMU x86 without KVM acceleartion and without VMX emulation leads to the failure appended below. This trivial workaround "fixes" the problem: diff --git a/xen/arch/x86/extable.c b/xen/arch/x86/extable.c index 72f30d9..a67d6c1 100644 --- a/xen/arch/x86/extable.c +++

[Xen-devel] [seabios test] 118269: regressions - FAIL

flight 118269 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/118269/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-amdbroken in 118264

Re: [Xen-devel] [PATCH v9 06/11] x86/entry: Organise the use of MSR_SPEC_CTRL at each entry/exit point

On 01/19/2018 08:36 AM, Andrew Cooper wrote: > On 19/01/18 11:43, Jan Beulich wrote: > >>> @@ -99,6 +106,10 @@ UNLIKELY_END(realmode) >>> .Lvmx_vmentry_fail: >>> sti >>> SAVE_ALL >>> + >>> +SPEC_CTRL_ENTRY_FROM_PV /* Req: %rsp=regs/cpuinfo Clob: acd */ >> I think the use

Re: [Xen-devel] [Makefile] asm: handle comments when creating header file

Jan, All, > On 10 Jan 2018, at 16:02, Jan Beulich wrote: > On 10.01.18 at 16:14, wrote: >> In the early steps of compilation, the asm header files are created, such >> as include/asm-$(TARGET_ARCH)/asm-offsets.h. These files depend on the >>

[Xen-devel] [xen-unstable-smoke test] 118274: tolerable all pass - PUSHED

flight 118274 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/118274/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

On 22/01/18 18:48, George Dunlap wrote: > On 01/22/2018 06:39 PM, Andrew Cooper wrote: >> On 22/01/18 16:51, Jan Beulich wrote: >> On 22.01.18 at 16:00, wrote: On 22/01/18 15:48, Jan Beulich wrote: On 22.01.18 at 15:38, wrote: >> On

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

On 01/22/2018 06:39 PM, Andrew Cooper wrote: > On 22/01/18 16:51, Jan Beulich wrote: > On 22.01.18 at 16:00, wrote: >>> On 22/01/18 15:48, Jan Beulich wrote: >>> On 22.01.18 at 15:38, wrote: > On 22/01/18 15:22, Jan Beulich wrote: > On

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

On 22/01/18 16:51, Jan Beulich wrote: On 22.01.18 at 16:00, wrote: >> On 22/01/18 15:48, Jan Beulich wrote: >> On 22.01.18 at 15:38, wrote: On 22/01/18 15:22, Jan Beulich wrote: On 22.01.18 at 15:18, wrote: >> On

Re: [Xen-devel] [PATCH v4] x86: relocate pvh_info

On Mon, Jan 22, 2018 at 06:19:43PM +, Andrew Cooper wrote: > On 22/01/18 18:17, Wei Liu wrote: > > On Mon, Jan 22, 2018 at 06:09:14PM +, Andrew Cooper wrote: > >> On 22/01/18 16:13, Wei Liu wrote: > >>> Modify early boot code to relocate pvh info as well, so that we can be > >>> sure __va

Re: [Xen-devel] [PATCH v4] x86: relocate pvh_info

On 22/01/18 18:17, Wei Liu wrote: > On Mon, Jan 22, 2018 at 06:09:14PM +, Andrew Cooper wrote: >> On 22/01/18 16:13, Wei Liu wrote: >>> Modify early boot code to relocate pvh info as well, so that we can be >>> sure __va in __start_xen works. >>> >>> Signed-off-by: Wei Liu

[Xen-devel] [PATCH 2/2] xen/arm: GICv3: Only initialize ITS when the distributor supports LPIs.

There are firmware tables out describing the ITS but does not support LPIs. This will result to a data abort when trying to initialize ITS. While this can be consider a bug in the Device-Tree, same configuration boots on Linux. So gate the ITS initialization with the support of LPIs in the

[Xen-devel] [PATCH 0/2] xen/arm: GICv3: Only initialize ITS when LPIs are available

Hi all, This small patch series fix an issue I discovered when using the Foundation model and the DT provided by Linux upstream. Indeed the Device-Tree is exposing an ITS but LPIs are not available. Resulting to an early crash on Xen. Whilst this looks a DT issue, Linux is able to cope with it.

Re: [Xen-devel] [PATCH v4] x86: relocate pvh_info

On 22/01/18 16:13, Wei Liu wrote: > Modify early boot code to relocate pvh info as well, so that we can be > sure __va in __start_xen works. > > Signed-off-by: Wei Liu > --- > Cc: Jan Beulich > Cc: Andrew Cooper > Cc: Roger Pau

Re: [Xen-devel] [PATCH v4] x86: relocate pvh_info

On Mon, Jan 22, 2018 at 06:09:14PM +, Andrew Cooper wrote: > On 22/01/18 16:13, Wei Liu wrote: > > Modify early boot code to relocate pvh info as well, so that we can be > > sure __va in __start_xen works. > > > > Signed-off-by: Wei Liu > > --- > > Cc: Jan Beulich

[Xen-devel] [xen-unstable-smoke test] 118271: tolerable all pass - PUSHED

flight 118271 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/118271/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] I only see one CPU core on Xen when booted via grub

On Mon, Jan 22, 2018 at 06:28:17PM +0100, msd+xen-de...@msd.im wrote: > Hi, > > I only see 1 CPU core on Xen 4.9 when booted via grub instead of 8. > > It's may be related to : > - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=820807 > - https://xenproject.atlassian.net/browse/XEN-42 > > It

Re: [Xen-devel] further post-Meltdown-bad-aid performance thoughts

On Fri, Jan 19, 2018 at 03:43:26PM +, George Dunlap wrote: [...] > But there will surely be more attacks like this (in fact, there may > already be some in the works[2]). [...] > -George > > [1] https://lwn.net/SubscriberLink/744287/02dd9bc503409ca3/ > [2] skyfallattack.com In case

[Xen-devel] I only see one CPU core on Xen when booted via grub

Hi, I only see 1 CPU core on Xen 4.9 when booted via grub instead of 8. It's may be related to : - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=820807 - https://xenproject.atlassian.net/browse/XEN-42 It is the first server on which I have this problem. I can confirm that : - if I boot

Re: [Xen-devel] further post-Meltdown-bad-aid performance thoughts

On 01/22/2018 05:04 PM, Jan Beulich wrote: On 22.01.18 at 16:15, wrote: >> On 01/22/2018 01:30 PM, Jan Beulich wrote: >> On 22.01.18 at 13:33, wrote: What I'm proposing is something like this: * We have a "global" region

Re: [Xen-devel] [PATCH v9 08/11] x86/entry: Clobber the Return Stack Buffer/Return Address Stack on entry to Xen

On 22/01/18 16:49, Jan Beulich wrote: On 22.01.18 at 16:51, wrote: >> On 19/01/18 15:02, Jan Beulich wrote: >> On 19.01.18 at 15:24, wrote: On 19/01/18 12:47, Jan Beulich wrote: On 18.01.18 at 16:46,

Re: [Xen-devel] [PATCH v4] x86: relocate pvh_info

>>> On 22.01.18 at 17:13, wrote: > Modify early boot code to relocate pvh info as well, so that we can be > sure __va in __start_xen works. > > Signed-off-by: Wei Liu As before Reviewed-by: Jan Beulich with the caveat that this

Re: [Xen-devel] [PATCH v3] xen/shim: stash RSDP address for ACPI driver

>>> On 22.01.18 at 17:33, wrote: > On Mon, Jan 22, 2018 at 04:28:30PM +, Wei Liu wrote: >> It used to the case that we placed RSDP under 1MB and let Xen search >> for it. We moved the placement to under 4GB in 4a5733771, so the >> search wouldn't work. >> >> Introduce

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

>>> On 22.01.18 at 16:00, wrote: > On 22/01/18 15:48, Jan Beulich wrote: > On 22.01.18 at 15:38, wrote: >>> On 22/01/18 15:22, Jan Beulich wrote: >>> On 22.01.18 at 15:18, wrote: > On 22/01/18 13:50, Jan Beulich wrote: > On

Re: [Xen-devel] [PATCH v9 08/11] x86/entry: Clobber the Return Stack Buffer/Return Address Stack on entry to Xen

>>> On 22.01.18 at 16:51, wrote: > On 19/01/18 15:02, Jan Beulich wrote: > On 19.01.18 at 15:24, wrote: >>> On 19/01/18 12:47, Jan Beulich wrote: >>> On 18.01.18 at 16:46, wrote: > + * %rsp is preserved

Re: [Xen-devel] [PATCH v3] xen/shim: stash RSDP address for ACPI driver

On Mon, Jan 22, 2018 at 04:28:30PM +, Wei Liu wrote: > It used to the case that we placed RSDP under 1MB and let Xen search > for it. We moved the placement to under 4GB in 4a5733771, so the > search wouldn't work. > > Introduce rsdp_hint to ACPI code and set that variable in >

Re: [Xen-devel] [xen-unstable test] 118266: regressions - trouble: broken/fail/pass

osstest service owner writes ("[xen-unstable test] 118266: regressions - trouble: broken/fail/pass"): > flight 118266 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/118266/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which

[Xen-devel] [PATCH v3] xen/shim: stash RSDP address for ACPI driver

It used to the case that we placed RSDP under 1MB and let Xen search for it. We moved the placement to under 4GB in 4a5733771, so the search wouldn't work. Introduce rsdp_hint to ACPI code and set that variable in convert_pvh_info. Signed-off-by: Wei Liu --- Cc: Jan Beulich

[Xen-devel] [PATCH v4] x86: relocate pvh_info

Modify early boot code to relocate pvh info as well, so that we can be sure __va in __start_xen works. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Roger Pau Monné Cc: Doug Goldstein

Re: [Xen-devel] [PATCH v2] xen/shim: stash RSDP address for ACPI driver

>>> On 22.01.18 at 16:34, wrote: > On Mon, Jan 22, 2018 at 03:02:52PM +, Wei Liu wrote: >> --- a/xen/drivers/acpi/osl.c >> +++ b/xen/drivers/acpi/osl.c >> @@ -62,8 +62,13 @@ void __init acpi_os_vprintf(const char *fmt, va_list args) >> printk("%s", buffer); >> } >>

Re: [Xen-devel] [PATCH v9 08/11] x86/entry: Clobber the Return Stack Buffer/Return Address Stack on entry to Xen

On 19/01/18 15:02, Jan Beulich wrote: On 19.01.18 at 15:24, wrote: >> On 19/01/18 12:47, Jan Beulich wrote: >> On 18.01.18 at 16:46, wrote: @@ -265,6 +265,10 @@ On hardware supporting IBRS, the `ibrs=` option can be

Re: [Xen-devel] [PATCH v2] xen/shim: stash RSDP address for ACPI driver

On Mon, Jan 22, 2018 at 03:02:52PM +, Wei Liu wrote: > diff --git a/xen/arch/x86/guest/pvh-boot.c b/xen/arch/x86/guest/pvh-boot.c > index be3122b16c..2903b392bc 100644 > --- a/xen/arch/x86/guest/pvh-boot.c > +++ b/xen/arch/x86/guest/pvh-boot.c > @@ -69,6 +69,8 @@ static void __init

Re: [Xen-devel] [PATCH v2 4/7] x86/shim: use credit scheduler

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH v2 4/7] x86/shim: use credit scheduler"): > On Fri, Jan 19, 2018 at 03:34:55PM +, Wei Liu wrote: > > Remove sched=null from shim cmdline and doc > > > > We use the default scheduler (credit1 as of writing). The NULL > > scheduler still has bugs

Re: [Xen-devel] further post-Meltdown-bad-aid performance thoughts

On 01/22/2018 01:30 PM, Jan Beulich wrote: On 22.01.18 at 13:33, wrote: >> On 01/22/2018 09:25 AM, Jan Beulich wrote: >> On 19.01.18 at 18:00, wrote: On 01/19/2018 04:36 PM, Jan Beulich wrote: On 19.01.18 at 16:43,

[Xen-devel] [PATCH v2] xen/shim: stash RSDP address for ACPI driver

It used to the case that we placed RSDP under 1MB and let Xen search for it. We moved the placement to under 4GB in 4a5733771, so the search wouldn't work. Introduce rsdp_hint to ACPI code and set that variable in convert_pvh_info. Signed-off-by: Wei Liu --- Cc: Jan Beulich

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

On 22/01/18 15:48, Jan Beulich wrote: On 22.01.18 at 15:38, wrote: >> On 22/01/18 15:22, Jan Beulich wrote: >> On 22.01.18 at 15:18, wrote: On 22/01/18 13:50, Jan Beulich wrote: On 22.01.18 at 13:32, wrote: >> As a

Re: [Xen-devel] [PATCH v9 03/11] x86/msr: Emulation of MSR_{SPEC_CTRL, PRED_CMD} for guests

On 19/01/18 10:45, Jan Beulich wrote: On 18.01.18 at 16:46, wrote: >> @@ -153,14 +168,44 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t >> val) >> { >> const struct vcpu *curr = current; >> struct domain *d = v->domain; >> +const struct

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

>>> On 22.01.18 at 15:38, wrote: > On 22/01/18 15:22, Jan Beulich wrote: > On 22.01.18 at 15:18, wrote: >>> On 22/01/18 13:50, Jan Beulich wrote: >>> On 22.01.18 at 13:32, wrote: > As a preparation for doing page table isolation in

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

On 22/01/18 15:22, Jan Beulich wrote: On 22.01.18 at 15:18, wrote: >> On 22/01/18 13:50, Jan Beulich wrote: >> On 22.01.18 at 13:32, wrote: As a preparation for doing page table isolation in the Xen hypervisor in order to mitigate "Meltdown"

[Xen-devel] [PATCH] xen/arm: cpuerrata: Remove percpu.h include

The include percpu.h was added by mistake in cpuerrata.h (see commit 4c4fddc166 "xen/arm64: Add skeleton to harden the branch aliasing attacks"). So remove it. Signed-off-by: Julien Grall --- xen/include/asm-arm/cpuerrata.h | 1 - 1 file changed, 1 deletion(-) diff

Re: [Xen-devel] [PATCH RFC v2 01/12] x86: cleanup processor.h

>>> On 22.01.18 at 15:25, wrote: > On 22/01/18 14:10, Juergen Gross wrote: >> On 22/01/18 13:52, Jan Beulich wrote: >> On 22.01.18 at 13:32, wrote: Remove NSC/Cyrix CPU macros and current_text_addr() which are used nowhere. >>> I agree

Re: [Xen-devel] [PATCH RFC v2 01/12] x86: cleanup processor.h

On 22/01/18 14:10, Juergen Gross wrote: > On 22/01/18 13:52, Jan Beulich wrote: > On 22.01.18 at 13:32, wrote: >>> Remove NSC/Cyrix CPU macros and current_text_addr() which are used >>> nowhere. >> I agree doing the former, but I have a vague recollection that we've >> left

Re: [Xen-devel] [PATCH] xen/shim: stash RSDP address for ACPI driver

On Mon, Jan 22, 2018 at 06:35:14AM -0700, Jan Beulich wrote: > >>> On 22.01.18 at 14:21, wrote: > > On Mon, Jan 22, 2018 at 01:03:14PM +, Roger Pau Monné wrote: > >> On Mon, Jan 22, 2018 at 12:47:10PM +, Wei Liu wrote: > >> > --- a/xen/drivers/acpi/osl.c > >> > +++

Re: [Xen-devel] [RFC 02/11] acpi: arm: API to query estimated size of hardware domain's IORT

Hi, On 19/01/18 06:10, Manish Jaggi wrote: On 01/17/2018 12:22 AM, Julien Grall wrote:   IORT for hardware domain is generated using the requesterId and deviceId map.   Signed-off-by: Manish Jaggi ---   xen/arch/arm/domain_build.c |  12 -  

Re: [Xen-devel] [PATCH 2/2] xen: Drop DOMCTL_getmemlist and xc_get_pfn_list()

>>> On 22.01.18 at 14:29, wrote: > On 22/01/18 13:01, Jan Beulich wrote: > On 22.01.18 at 13:52, wrote: >>> On 22/01/18 12:41, Jan Beulich wrote: >>> On 19.01.18 at 20:19, wrote: > ---

Re: [Xen-devel] [PATCH] xen/shim: stash RSDP address for ACPI driver

>>> On 22.01.18 at 14:21, wrote: > On Mon, Jan 22, 2018 at 01:03:14PM +, Roger Pau Monné wrote: >> On Mon, Jan 22, 2018 at 12:47:10PM +, Wei Liu wrote: >> > --- a/xen/drivers/acpi/osl.c >> > +++ b/xen/drivers/acpi/osl.c >> > @@ -38,6 +38,10 @@ >> > #include >> >

Re: [Xen-devel] further post-Meltdown-bad-aid performance thoughts

>>> On 22.01.18 at 13:33, wrote: > On 01/22/2018 09:25 AM, Jan Beulich wrote: > On 19.01.18 at 18:00, wrote: >>> On 01/19/2018 04:36 PM, Jan Beulich wrote: >>> On 19.01.18 at 16:43, wrote: > So what if

Re: [Xen-devel] [PATCH 2/2] xen: Drop DOMCTL_getmemlist and xc_get_pfn_list()

On 22/01/18 13:01, Jan Beulich wrote: On 22.01.18 at 13:52, wrote: >> On 22/01/18 12:41, Jan Beulich wrote: >> On 19.01.18 at 20:19, wrote: --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -1117,7

Re: [Xen-devel] [PATCH] xen/shim: stash RSDP address for ACPI driver

On Mon, Jan 22, 2018 at 01:03:14PM +, Roger Pau Monné wrote: > On Mon, Jan 22, 2018 at 12:47:10PM +, Wei Liu wrote: > > It used to the case that we placed RSDP under 1MB and let Xen search > > for it. We moved the placement to under 4GB in 4a5733771, so the > > search wouldn't work. > > >

Re: [Xen-devel] [PATCH] xen/shim: stash RSDP address for ACPI driver

On Mon, Jan 22, 2018 at 12:47:10PM +, Wei Liu wrote: > It used to the case that we placed RSDP under 1MB and let Xen search > for it. We moved the placement to under 4GB in 4a5733771, so the > search wouldn't work. > > Stash the RSDP address to solve this problem. > > Suggested-by: Roger Pau

Re: [Xen-devel] [PATCH 2/2] xen: Drop DOMCTL_getmemlist and xc_get_pfn_list()

>>> On 22.01.18 at 13:52, wrote: > On 22/01/18 12:41, Jan Beulich wrote: > On 19.01.18 at 20:19, wrote: >>> --- a/xen/include/public/domctl.h >>> +++ b/xen/include/public/domctl.h >>> @@ -1117,7 +1117,7 @@ struct xen_domctl { >>> #define

Re: [Xen-devel] [PATCH v7 for-next 10/12] vpci/msi: add MSI handlers

>>> On 22.01.18 at 13:48, wrote: > I think the proper way to solve this is to reset the mask bits to > masked when the vector is unbound, so that at bind time the state of > the mask is consistent regardless of whether the vector has been > previously bound or not. The

Re: [Xen-devel] [PATCH v2 5/7] x86: relocate pvh_info

>>> On 22.01.18 at 13:35, wrote: > To avoid spamming the list with all the other acked patches, here is the > updated patch. Feel free to re-instate my R-b, but please commit only if Andrew withdraws his earlier voiced more general objection. Jan

Re: [Xen-devel] [PATCH RFC v2 01/12] x86: cleanup processor.h

>>> On 22.01.18 at 13:32, wrote: > Remove NSC/Cyrix CPU macros and current_text_addr() which are used > nowhere. I agree doing the former, but I have a vague recollection that we've left the latter in place despite there not being any callers at present. Jan

Re: [Xen-devel] [PATCH 2/2] xen: Drop DOMCTL_getmemlist and xc_get_pfn_list()

On 22/01/18 12:41, Jan Beulich wrote: On 19.01.18 at 20:19, wrote: >> --- a/xen/include/public/domctl.h >> +++ b/xen/include/public/domctl.h >> @@ -1117,7 +1117,7 @@ struct xen_domctl { >> #define XEN_DOMCTL_pausedomain3 >> #define

Re: [Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

>>> On 22.01.18 at 13:32, wrote: > As a preparation for doing page table isolation in the Xen hypervisor > in order to mitigate "Meltdown" use dedicated stacks, GDT and TSS for > 64 bit PV domains mapped to the per-domain virtual area. > > The per-vcpu stacks are used for early

Re: [Xen-devel] [PATCH v7 for-next 10/12] vpci/msi: add MSI handlers

On Fri, Dec 15, 2017 at 05:07:06AM -0700, Jan Beulich wrote: > >>> On 18.10.17 at 13:40, wrote: > > +static void control_write(const struct pci_dev *pdev, unsigned int reg, > > + uint32_t val, void *data) > > +{ > > +struct vpci_msi *msi = data;

[Xen-devel] [PATCH] xen/shim: stash RSDP address for ACPI driver

It used to the case that we placed RSDP under 1MB and let Xen search for it. We moved the placement to under 4GB in 4a5733771, so the search wouldn't work. Stash the RSDP address to solve this problem. Suggested-by: Roger Pau Monné Signed-off-by: Wei Liu

Re: [Xen-devel] [PATCH v2 5/7] x86: relocate pvh_info

On Mon, Jan 22, 2018 at 12:44:41PM +, Roger Pau Monné wrote: > On Mon, Jan 22, 2018 at 12:35:21PM +, Wei Liu wrote: > > To avoid spamming the list with all the other acked patches, here is the > > updated patch. > > > > ---8<--- > > From 1ac0afbbc0ecd620c5fba3a03bb084bc4dafc78e Mon Sep 17

Re: [Xen-devel] [PATCH v2 5/7] x86: relocate pvh_info

On Mon, Jan 22, 2018 at 12:35:21PM +, Wei Liu wrote: > To avoid spamming the list with all the other acked patches, here is the > updated patch. > > ---8<--- > From 1ac0afbbc0ecd620c5fba3a03bb084bc4dafc78e Mon Sep 17 00:00:00 2001 > From: Wei Liu > Date: Wed, 17 Jan 2018

Re: [Xen-devel] [PATCH 2/2] xen: Drop DOMCTL_getmemlist and xc_get_pfn_list()

>>> On 19.01.18 at 20:19, wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -1117,7 +1117,7 @@ struct xen_domctl { > #define XEN_DOMCTL_pausedomain3 > #define XEN_DOMCTL_unpausedomain 4 > #define

[Xen-devel] [PATCH RFC v2 06/12] x86: add a xpti command line parameter

Add a command line parameter for controlling Xen page table isolation (XPTI): per default it is on for non-AMD systems in 64 bit pv domains. Possible settings are: - true: switched on even on AMD systems - false: switched off for all - nodom0: switched off for dom0 Signed-off-by: Juergen Gross

[Xen-devel] [PATCH 1/7] xen/arm32: entry: Consolidate DEFINE_TRAP_ENTRY_* macros

The only difference between all the DEFINE_TRAP_ENTRY_* macros are the interrupts (Asynchronous Abort, IRQ, FIQ) unmasked. Rather than duplicating the code, introduce __DEFINE_TRAP_ENTRY macro that will take the list of interrupts to unmask. This is part of XSA-254. Signed-off-by: Julien Grall

[Xen-devel] [PATCH RFC v2 10/12] x86: allocate per-vcpu stacks for interrupt entries

In case of XPTI being active for a pv-domain allocate and initialize per-vcpu stacks. The stacks are added to the per-domain mappings of the pv-domain. Signed-off-by: Juergen Gross --- xen/arch/x86/pv/domain.c | 72 +++

Re: [Xen-devel] [PATCH v2 5/7] x86: relocate pvh_info

On Mon, Jan 22, 2018 at 03:31:22AM -0700, Jan Beulich wrote: > >>> On 19.01.18 at 17:39, wrote: > > On Fri, Jan 19, 2018 at 04:29:31PM +, Roger Pau Monné wrote: > >> On Fri, Jan 19, 2018 at 03:34:56PM +, Wei Liu wrote: > >> > diff --git a/xen/arch/x86/boot/build32.mk

[Xen-devel] [PATCH RFC v2 11/12] x86: modify interrupt handlers to support stack switching

Modify the interrupt handlers to switch stacks on interrupt entry in case they are running on a per-vcpu stack. Same applies to returning to the guest: in case the to be loaded context is located on a per-vcpu stack switch to this one before returning to the guest. Signed-off-by: Juergen Gross

[Xen-devel] [PATCH RFC v2 04/12] x86: revert 5784de3e2067ed73efc2fe42e62831e8ae7f46c4

Revert patch "x86: Meltdown band-aid against malicious 64-bit PV guests" in order to prepare for a final Meltdown mitigation. Signed-off-by: Juergen Gross --- xen/arch/x86/domain.c | 5 - xen/arch/x86/mm.c | 21 xen/arch/x86/smpboot.c

[Xen-devel] [PATCH RFC v2 05/12] x86: don't access saved user regs via rsp in trap handlers

In order to support switching stacks when entering the hypervisor for support of page table isolation, don't use %rsp for accessing the saved user registers, but do that via %rdi. Signed-off-by: Juergen Gross --- xen/arch/x86/x86_64/compat/entry.S | 82 +--

Re: [Xen-devel] further post-Meltdown-bad-aid performance thoughts

On 01/22/2018 09:25 AM, Jan Beulich wrote: On 19.01.18 at 18:00, wrote: >> On 01/19/2018 04:36 PM, Jan Beulich wrote: >> On 19.01.18 at 16:43, wrote: So what if instead of trying to close the "windows", we made it so that

[Xen-devel] [PATCH RFC v2 12/12] x86: activate per-vcpu stacks in case of xpti

When scheduling a vcpu subject to xpti activate the per-vcpu stacks by loading the vcpu specific gdt and tss. When de-scheduling such a vcpu switch back to the per physical cpu gdt and tss. Accessing the user registers on the stack is done via helpers as depending on XPTI active or not the

[Xen-devel] [PATCH RFC v2 01/12] x86: cleanup processor.h

Remove NSC/Cyrix CPU macros and current_text_addr() which are used nowhere. Signed-off-by: Juergen Gross --- xen/include/asm-x86/processor.h | 41 - 1 file changed, 41 deletions(-) diff --git a/xen/include/asm-x86/processor.h

[Xen-devel] [PATCH RFC v2 02/12] x86: don't use hypervisor stack size for dumping guest stacks

show_guest_stack() and compat_show_guest_stack() stop dumping the stack of the guest whenever its virtual address reaches the same alignment which is used for the hypervisor stacks. Remove this arbitrary limit and try to dump a fixed number of lines instead. Signed-off-by: Juergen Gross

[Xen-devel] [PATCH RFC v2 07/12] x86: allow per-domain mappings without NX bit or with specific mfn

For support of per-vcpu stacks we need per-vcpu trampolines. To be able to put those into the per-domain mappings the upper levels page tables must not have NX set for per-domain mappings. In order to be able to reset the NX bit for a per-domain mapping add a helper flipflags_perdomain_mapping()

[Xen-devel] [PATCH RFC v2 08/12] xen/x86: use dedicated function for tss initialization

Carve out the TSS initialization from load_system_tables(). Signed-off-by: Juergen Gross --- xen/arch/x86/cpu/common.c| 56 xen/include/asm-x86/system.h | 1 + 2 files changed, 32 insertions(+), 25 deletions(-) diff --git

[Xen-devel] [PATCH RFC v2 00/12] xen/x86: use per-vcpu stacks for 64 bit pv domains

As a preparation for doing page table isolation in the Xen hypervisor in order to mitigate "Meltdown" use dedicated stacks, GDT and TSS for 64 bit PV domains mapped to the per-domain virtual area. The per-vcpu stacks are used for early interrupt handling only. After saving the domain's registers

[Xen-devel] [PATCH RFC v2 09/12] x86: enhance syscall stub to work in per-domain mapping

Use indirect jump via register in case the target address isn't reachable via a 32 bit relative jump. Add macros for stub size and use those instead of returning the size when writing the stub trampoline in order to support easy switching between different sized stubs. Signed-off-by: Juergen

Re: [Xen-devel] [PATCH] x86/shutdown: Use ACPI reboot method for Dell PowerEdge R740

>>> On 19.01.18 at 17:57, wrote: > --- a/xen/arch/x86/shutdown.c > +++ b/xen/arch/x86/shutdown.c > @@ -511,6 +511,15 @@ static struct dmi_system_id __initdata > reboot_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6520"), > }, > },

Re: [Xen-devel] [PATCH v2 5/7] x86: relocate pvh_info

On Fri, Jan 19, 2018 at 04:29:31PM +, Roger Pau Monné wrote: > On Fri, Jan 19, 2018 at 03:34:56PM +, Wei Liu wrote: > > diff --git a/xen/arch/x86/boot/build32.mk b/xen/arch/x86/boot/build32.mk > > index 48c7407c00..028ac19b96 100644 > > --- a/xen/arch/x86/boot/build32.mk > > +++

Re: [Xen-devel] [PATCH v9 06/11] x86/entry: Organise the use of MSR_SPEC_CTRL at each entry/exit point

>>> On 22.01.18 at 12:42, wrote: > On 19/01/18 13:51, Jan Beulich wrote: > On 19.01.18 at 14:36, wrote: >>> On 19/01/18 11:43, Jan Beulich wrote: >>> On 18.01.18 at 16:46, wrote: > @@ -729,6 +760,9 @@

Re: [Xen-devel] [PATCH v9 06/11] x86/entry: Organise the use of MSR_SPEC_CTRL at each entry/exit point

On 19/01/18 13:51, Jan Beulich wrote: On 19.01.18 at 14:36, wrote: >> On 19/01/18 11:43, Jan Beulich wrote: >> On 18.01.18 at 16:46, wrote: @@ -729,6 +760,9 @@ ENTRY(nmi) handle_ist_exception: SAVE_ALL CLAC

[Xen-devel] [PATCH 3/7] xen/arm32: entry: Add missing trap_reset entry

At the moment, the reset vector is defined as .word 0 (e.g andeq r0, r0, r0). This is rather unintuitive and will result to execute the trap undefined. Instead introduce trap helpers for reset and will generate an error message in the unlikely case that reset will be called. This is part of

Re: [Xen-devel] [RFC] ARM PCI Passthrough design document

On 05/26/2017 10:44 PM, Julien Grall wrote: Hi all, Hi Julien, General consolidated comments first: Review Comments: a. The document talks about high level design and does not go into the implementation details  and detailed code flows. So this is missing if adding such detail is

[Xen-devel] [seabios test] 118264: regressions - trouble: broken/fail/pass

flight 118264 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/118264/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 broken test-amd64-i386-qemuu-rhel6hvm-amd

Re: [Xen-devel] [PATCH v2 5/7] x86: relocate pvh_info

>>> On 19.01.18 at 17:39, wrote: > On Fri, Jan 19, 2018 at 04:29:31PM +, Roger Pau Monné wrote: >> On Fri, Jan 19, 2018 at 03:34:56PM +, Wei Liu wrote: >> > diff --git a/xen/arch/x86/boot/build32.mk b/xen/arch/x86/boot/build32.mk >> > index 48c7407c00..028ac19b96

Re: [Xen-devel] [PATCH v6.5 08/26] x86/entry: Erase guest GPR state on entry to Xen

On Mon, 2018-01-22 at 10:18 +, Andrew Cooper wrote: > On 22/01/2018 10:04, David Woodhouse wrote: > > > > On Thu, 2018-01-04 at 00:15 +, Andrew Cooper wrote: > > > > > > --- a/xen/include/asm-x86/asm_defns.h > > > +++ b/xen/include/asm-x86/asm_defns.h > > > @@ -217,22 +217,34 @@ static

Re: [Xen-devel] [PATCH v6.5 08/26] x86/entry: Erase guest GPR state on entry to Xen

On 22/01/2018 10:04, David Woodhouse wrote: > On Thu, 2018-01-04 at 00:15 +, Andrew Cooper wrote: >> --- a/xen/include/asm-x86/asm_defns.h >> +++ b/xen/include/asm-x86/asm_defns.h >> @@ -217,22 +217,34 @@ static always_inline void stac(void) >> addq  $-(UREGS_error_code-UREGS_r15),

  1   2   >