[Xen-devel] [ovmf test] 142274: all pass - PUSHED

2019-10-04 Thread osstest service owner
flight 142274 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/142274/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d19040804afb2bdd60f18e8aef7da78028575fe6 baseline version: ovmf

[Xen-devel] [linux-next test] 142263: tolerable FAIL

2019-10-04 Thread osstest service owner
flight 142263 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/142263/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-raw7 xen-boot fail like 142223 test-amd64-i386-examine 8

[Xen-devel] [linux-4.4 test] 142265: regressions - FAIL

2019-10-04 Thread osstest service owner
flight 142265 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/142265/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail in 142019 REGR. vs. 139698 Tests

[Xen-devel] [linux-linus test] 142258: regressions - FAIL

2019-10-04 Thread osstest service owner
flight 142258 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/142258/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 133580

[Xen-devel] [qemu-mainline bisection] complete test-amd64-i386-qemuu-rhel6hvm-amd

2019-10-04 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-qemuu-rhel6hvm-amd testid redhat-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-04 Thread Chao Gao
On Wed, Oct 02, 2019 at 12:49:35PM +0200, Roger Pau Monne wrote: >The current implementation of host_maskall makes it sticky across >assign and deassign calls, which means that once a guest forces Xen to >set host_maskall the maskall bit is not going to be cleared until a >call to

[Xen-devel] [PATCH for-4.13] xen/arm: fix duplicate memory node in DT

2019-10-04 Thread Stefano Stabellini
When reserved-memory regions are present in the host device tree, dom0 is started with multiple memory nodes. Each memory node should have a unique name, but today they are all called "memory" leading to Linux printing the following warning at boot: OF: Duplicate name in base, renamed to

[Xen-devel] [xen-unstable-smoke test] 142284: tolerable all pass - PUSHED

2019-10-04 Thread osstest service owner
flight 142284 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/142284/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] I want to participate in Outreachy with CONFIG_PDX related project

2019-10-04 Thread Kateryna Razumova
Thank you Wei, I just didn't realize that. I thought that an applicant should know what bugs already existed and tried to fix them. I was trying to find some on the github page but haven't succeeded. But now I can try to do my best. At least, I will try to help with typo extermination. On Thu,

[Xen-devel] [xen-unstable test] 142249: regressions - FAIL

2019-10-04 Thread osstest service owner
flight 142249 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/142249/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair 22 guest-migrate/src_host/dst_host fail REGR. vs. 141822

Re: [Xen-devel] [GIT PULL] xen: fixes and cleanups for 5.4-rc2

2019-10-04 Thread pr-tracker-bot
The pull request you sent on Fri, 4 Oct 2019 07:05:20 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-5.4-rc2-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/50dfd03d9579cde9150679e90f8f244c626b7a09 Thank you! -- Deet-doot-dot, I

[Xen-devel] [xen-unstable-smoke test] 142276: tolerable all pass - PUSHED

2019-10-04 Thread osstest service owner
flight 142276 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/142276/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH for-4.13] xen/xsm: flask: Prevent NULL deference in flask_assign_{, dt}device()

2019-10-04 Thread Daniel De Graaf
On 10/4/19 12:42 PM, Julien Grall wrote: flask_assign_{, dt}device() may be used to check whether you can test if a device is assigned. In this case, the domain will be NULL. However, flask_iommu_resource_use_perm() will be called and may end up to deference a NULL pointer. This can be

Re: [Xen-devel] [PATCH for-4.13] xen/xsm: flask: Check xmalloc_array() return in security_sid_to_context()

2019-10-04 Thread Daniel De Graaf
On 10/4/19 12:56 PM, Julien Grall wrote: xmalloc_array() may return NULL if there are memory. Rather than trying to deference it directly, we should check the return value first. Coverity-ID: 1381852 Signed-off-by: Julien Grall Acked-by: Daniel De Graaf

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-04 Thread Andrew Cooper
On 04/10/2019 14:30, Jan Beulich wrote: > On 04.10.2019 15:18, Andrew Cooper wrote: >> On 26/09/2019 15:28, Jan Beulich wrote: >>> @@ -1068,8 +1067,29 @@ static void * __init allocate_ppr_log(st >>> IOMMU_PPR_LOG_DEFAULT_ENTRIES, "PPR Log"); >>> } >>> >>> +/*

Re: [Xen-devel] [XEN PATCH for-4.13 3/6] libxl: libxl__domain_config_setdefault: New function

2019-10-04 Thread Anthony PERARD
On Fri, Oct 04, 2019 at 05:04:27PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("Re: [XEN PATCH for-4.13 3/6] libxl: > libxl__domain_config_setdefault: New function"): > > On Fri, Oct 04, 2019 at 04:17:04PM +0100, Ian Jackson wrote: > > > +

Re: [Xen-devel] [XEN PATCH for-4.13 2/6] xl: Pass libxl_domain_config to freemem(), instead of b_info

2019-10-04 Thread Anthony PERARD
On Fri, Oct 04, 2019 at 04:17:03PM +0100, Ian Jackson wrote: > We are going to change the libxl API in a moment and this change will > make it simpler. > > Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD -- Anthony PERARD ___ Xen-devel

Re: [Xen-devel] [XEN PATCH for-4.13 6/6] libxl: Remove/deprecate libxl_get_required_*_memory from the API

2019-10-04 Thread Anthony PERARD
On Fri, Oct 04, 2019 at 04:17:07PM +0100, Ian Jackson wrote: > These are now redundant because shadow_memkb and iommu_memkb are now > defaulted automatically by libxl_domain_need_memory and > libxl_domain_create etc. Callers should not now call these; instead, > they should just let libxl take

Re: [Xen-devel] [XEN PATCH for-4.13 5/6] libxl: Move shadow_memkb and iommu_memkb defaulting into libxl

2019-10-04 Thread Ian Jackson
Anthony PERARD writes ("Re: [XEN PATCH for-4.13 5/6] libxl: Move shadow_memkb and iommu_memkb defaulting into libxl"): > On Fri, Oct 04, 2019 at 04:17:06PM +0100, Ian Jackson wrote: > > @@ -862,6 +864,30 @@ static void domcreate_destruction_cb(libxl__egc *egc, > >

Re: [Xen-devel] [XEN PATCH for-4.13 5/6] libxl: Move shadow_memkb and iommu_memkb defaulting into libxl

2019-10-04 Thread Anthony PERARD
On Fri, Oct 04, 2019 at 04:17:06PM +0100, Ian Jackson wrote: > @@ -862,6 +864,30 @@ static void domcreate_destruction_cb(libxl__egc *egc, > libxl__domain_destroy_state *dds, > int rc); > > +static _Bool

Re: [Xen-devel] [PATCH] xen/typesafe: Force helpers to be always_inline

2019-10-04 Thread George Dunlap
On 10/2/19 9:11 AM, Jan Beulich wrote: > On 01.10.2019 22:59, Andrew Cooper wrote: >> On 01/10/2019 09:38, Jan Beulich wrote: >>> On 30.09.2019 21:16, Andrew Cooper wrote: Clang in particular has a habit of out-of-lining these and creating multiple local copies of _mfn() and

[Xen-devel] [PATCH for-4.13] xen/xsm: flask: Check xmalloc_array() return in security_sid_to_context()

2019-10-04 Thread Julien Grall
xmalloc_array() may return NULL if there are memory. Rather than trying to deference it directly, we should check the return value first. Coverity-ID: 1381852 Signed-off-by: Julien Grall --- xen/xsm/flask/ss/services.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-04 Thread George Dunlap
On 10/2/19 10:10 AM, Andrew Cooper wrote: > On 02/10/2019 09:40, Jan Beulich wrote: >> On 01.10.2019 17:11, Paul Durrant wrote: >>> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a >>> domain, migration may be needlessly vetoed due to the check of >>> is_iommu_enabled() in

[Xen-devel] [PATCH for-4.13] xen/xsm: flask: Prevent NULL deference in flask_assign_{, dt}device()

2019-10-04 Thread Julien Grall
flask_assign_{, dt}device() may be used to check whether you can test if a device is assigned. In this case, the domain will be NULL. However, flask_iommu_resource_use_perm() will be called and may end up to deference a NULL pointer. This can be prevented by moving the call after we check the

[Xen-devel] [freebsd-master test] 142264: regressions - trouble: blocked/fail

2019-10-04 Thread osstest service owner
flight 142264 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/142264/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-freebsd 7 freebsd-buildfail REGR. vs. 141501 Tests which did

Re: [Xen-devel] [XEN PATCH for-4.13 4/6] libxl: libxl_domain_need_memory: Make it take a domain_config

2019-10-04 Thread Anthony PERARD
On Fri, Oct 04, 2019 at 04:17:05PM +0100, Ian Jackson wrote: > diff --git a/tools/libxl/libxl_mem.c b/tools/libxl/libxl_mem.c > index fd6f33312e..26cf136ac2 100644 > --- a/tools/libxl/libxl_mem.c > +++ b/tools/libxl/libxl_mem.c > @@ -446,20 +446,12 @@ int libxl_get_memory_target_0x040700( >

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread George Dunlap
On 10/4/19 4:40 PM, Jürgen Groß wrote: > On 04.10.19 17:37, George Dunlap wrote: >> On 10/4/19 4:03 PM, Jürgen Groß wrote: >>> On 04.10.19 16:56, George Dunlap wrote: On 10/4/19 3:43 PM, Jürgen Groß wrote: > On 04.10.19 16:34, George Dunlap wrote: >> On 10/4/19 3:24 PM, Jürgen Groß

Re: [Xen-devel] [XEN PATCH for-4.13 1/6] libxl: Offer API versions 0x040700 and 0x040800

2019-10-04 Thread Ian Jackson
Anthony PERARD writes ("Re: [XEN PATCH for-4.13 1/6] libxl: Offer API versions 0x040700 and 0x040800"): > On Fri, Oct 04, 2019 at 04:17:02PM +0100, Ian Jackson wrote: > > It is surprising that no-one noticed this. I wonder if anyone is > > using our LIBXL_API_VERSION facility. If not maybe we

Re: [Xen-devel] [XEN PATCH for-4.13 3/6] libxl: libxl__domain_config_setdefault: New function

2019-10-04 Thread Ian Jackson
Anthony PERARD writes ("Re: [XEN PATCH for-4.13 3/6] libxl: libxl__domain_config_setdefault: New function"): > On Fri, Oct 04, 2019 at 04:17:04PM +0100, Ian Jackson wrote: > > +libxl__domain_config_setdefault(gc,d_config,domid); > > Shouldn't you check for error ? Blimey, yes! Thanks!

Re: [Xen-devel] [PATCH v8 1/4] libxl: fix cold plugged PCI device with stubdomain

2019-10-04 Thread Ian Jackson
Jürgen Groß writes ("Re: [PATCH v8 1/4] libxl: fix cold plugged PCI device with stubdomain"): > On 02.10.19 17:43, Ian Jackson wrote: > > Hi Juergen. This series > > > > https://lists.xenproject.org/archives/html/xen-devel/2019-09/msg03072.html > > needs your release review. > > Fir the

Re: [Xen-devel] [PATCH v8 2/4] libxl: do not attach xen-pciback to HVM domain, if stubdomain is in use

2019-10-04 Thread Ian Jackson
Marek Marczykowski-Górecki writes ("[PATCH v8 2/4] libxl: do not attach xen-pciback to HVM domain, if stubdomain is in use"): > HVM domains use IOMMU and device model assistance for communicating with > PCI devices, xen-pcifront/pciback isn't directly needed by HVM domain. > But pciback serve

Re: [Xen-devel] [PATCH 0/2] libxl fixes with pci passthrough

2019-10-04 Thread Ian Jackson
Jürgen Groß writes ("Re: [PATCH 0/2] libxl fixes with pci passthrough"): > On 02.10.19 17:45, Ian Jackson wrote: > > Hi Juergen. Here's another bugfix series > > > > https://lists.xenproject.org/archives/html/xen-devel/2019-09/msg03320.html > >

Re: [Xen-devel] [XEN PATCH for-4.13 3/6] libxl: libxl__domain_config_setdefault: New function

2019-10-04 Thread Anthony PERARD
On Fri, Oct 04, 2019 at 04:17:04PM +0100, Ian Jackson wrote: > Break out this into a new function. We are going to want to call it > from a new call site. > > Unfortunately not all of the defaults can be moved into the new > function without changing the order in which things are done. That >

[Xen-devel] [libvirt test] 142252: tolerable all pass - PUSHED

2019-10-04 Thread osstest service owner
flight 142252 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/142252/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 142080 test-armhf-armhf-libvirt-raw 13

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread Jürgen Groß
On 04.10.19 17:37, George Dunlap wrote: On 10/4/19 4:03 PM, Jürgen Groß wrote: On 04.10.19 16:56, George Dunlap wrote: On 10/4/19 3:43 PM, Jürgen Groß wrote: On 04.10.19 16:34, George Dunlap wrote: On 10/4/19 3:24 PM, Jürgen Groß wrote: On 04.10.19 16:08, George Dunlap wrote: On 10/4/19

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread George Dunlap
On 10/4/19 4:03 PM, Jürgen Groß wrote: > On 04.10.19 16:56, George Dunlap wrote: >> On 10/4/19 3:43 PM, Jürgen Groß wrote: >>> On 04.10.19 16:34, George Dunlap wrote: On 10/4/19 3:24 PM, Jürgen Groß wrote: > On 04.10.19 16:08, George Dunlap wrote: >> On 10/4/19 7:40 AM, Juergen Gross

Re: [Xen-devel] Errors with Loading Xen at a Certain Address

2019-10-04 Thread Brian Woods
On Fri, Oct 04, 2019 at 10:49:28AM +0100, Julien Grall wrote: > Hi Brian, > > On 04/10/2019 01:25, Brian Woods wrote: > > > >In the log, there's: > >(XEN) MODULE[0]: 0140 - 015328f1 Xen > >(XEN) MODULE[1]: 076d2000 - 076dc080 Device Tree > >(XEN) MODULE[2]:

Re: [Xen-devel] [XEN PATCH for-4.13 1/6] libxl: Offer API versions 0x040700 and 0x040800

2019-10-04 Thread Anthony PERARD
On Fri, Oct 04, 2019 at 04:17:02PM +0100, Ian Jackson wrote: > According to git log -G: > > 0x040700 was introduced in 304400459ef0 (aka 4.7.0-rc1~481) > "tools/libxl: rename remus device to checkpoint device" > > 0x040800 was introduced in 57f8b13c7240 (aka 4.8.0-rc1~437) > "libxl: memory

[Xen-devel] [XEN PATCH for-4.13 2/6] xl: Pass libxl_domain_config to freemem(), instead of b_info

2019-10-04 Thread Ian Jackson
We are going to change the libxl API in a moment and this change will make it simpler. Signed-off-by: Ian Jackson --- tools/xl/xl_vmcontrol.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c index b20582e15b..d33c6b38c9

[Xen-devel] [XEN PATCH for-4.13 4/6] libxl: libxl_domain_need_memory: Make it take a domain_config

2019-10-04 Thread Ian Jackson
This should calculate the extra memory needed for shadow and iommu, the defaults for which depend on values in c_info. So we need this to have the complete domain config available. And the defaults should actually be updated and stored. So make it non-const. We provide the usual kind of

[Xen-devel] [XEN PATCH for-4.13 3/6] libxl: libxl__domain_config_setdefault: New function

2019-10-04 Thread Ian Jackson
Break out this into a new function. We are going to want to call it from a new call site. Unfortunately not all of the defaults can be moved into the new function without changing the order in which things are done. That does not seem wise at this stage of the release. The effect is that

[Xen-devel] [XEN PATCH for-4.13 6/6] libxl: Remove/deprecate libxl_get_required_*_memory from the API

2019-10-04 Thread Ian Jackson
These are now redundant because shadow_memkb and iommu_memkb are now defaulted automatically by libxl_domain_need_memory and libxl_domain_create etc. Callers should not now call these; instead, they should just let libxl take care of it. libxl_get_required_shadow_memory was introduced in

[Xen-devel] [XEN PATCH for-4.13 0/6] Drop/deprecate libxl_get_required_*_memory

2019-10-04 Thread Ian Jackson
libxl_get_required_shadow_memory has always been anomalous. libxl ought to default these things itself. Recently, another analogous setting, iommu_memkb, was introduced, along with another function along the same lines. This API is not very good. Fixing it was not entirely trivial. (Thanks to

[Xen-devel] [XEN PATCH for-4.13 5/6] libxl: Move shadow_memkb and iommu_memkb defaulting into libxl

2019-10-04 Thread Ian Jackson
Defaulting is supposed to be done by libxl. So these calculations should be here in libxl. libxl__domain_config_setdefault has all the necessary information including the values of max_memkb and max_vcpus. The overall functional effect depends on the caller: For xl, no change. The code moves

[Xen-devel] [XEN PATCH for-4.13 1/6] libxl: Offer API versions 0x040700 and 0x040800

2019-10-04 Thread Ian Jackson
According to git log -G: 0x040700 was introduced in 304400459ef0 (aka 4.7.0-rc1~481) "tools/libxl: rename remus device to checkpoint device" 0x040800 was introduced in 57f8b13c7240 (aka 4.8.0-rc1~437) "libxl: memory size in kb requires 64 bit variable" It is surprising that no-one noticed

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread Jürgen Groß
On 04.10.19 16:56, George Dunlap wrote: On 10/4/19 3:43 PM, Jürgen Groß wrote: On 04.10.19 16:34, George Dunlap wrote: On 10/4/19 3:24 PM, Jürgen Groß wrote: On 04.10.19 16:08, George Dunlap wrote: On 10/4/19 7:40 AM, Juergen Gross wrote: sched_tick_suspend() and sched_tick_resume() should

[Xen-devel] [RESEND TRIVIAL 3/3] treewide: arch: Fix Kconfig indentation

2019-10-04 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- arch/Kconfig | 4 ++-- arch/alpha/Kconfig | 2 +-

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread George Dunlap
On 10/4/19 3:43 PM, Jürgen Groß wrote: > On 04.10.19 16:34, George Dunlap wrote: >> On 10/4/19 3:24 PM, Jürgen Groß wrote: >>> On 04.10.19 16:08, George Dunlap wrote: On 10/4/19 7:40 AM, Juergen Gross wrote: > sched_tick_suspend() and sched_tick_resume() should not call the >

[Xen-devel] [RESEND TRIVIAL 2/3] treewide: Fix Kconfig indentation

2019-10-04 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- certs/Kconfig | 14 ++--- init/Kconfig | 28 +-

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread Andrew Cooper
On 04/10/2019 15:29, Dario Faggioli wrote: > On Fri, 2019-10-04 at 08:50 +0100, Andrew Cooper wrote: >> On 04/10/2019 07:40, Juergen Gross wrote: >>> sched_tick_suspend() and sched_tick_resume() should not call the >>> scheduler specific timer handlers in case the cpu they are running >>> on >>>

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread Jürgen Groß
On 04.10.19 16:34, George Dunlap wrote: On 10/4/19 3:24 PM, Jürgen Groß wrote: On 04.10.19 16:08, George Dunlap wrote: On 10/4/19 7:40 AM, Juergen Gross wrote: sched_tick_suspend() and sched_tick_resume() should not call the scheduler specific timer handlers in case the cpu they are running

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread George Dunlap
On 10/4/19 3:24 PM, Jürgen Groß wrote: > On 04.10.19 16:08, George Dunlap wrote: >> On 10/4/19 7:40 AM, Juergen Gross wrote: >>> sched_tick_suspend() and sched_tick_resume() should not call the >>> scheduler specific timer handlers in case the cpu they are running on >>> is just being moved to or

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread Dario Faggioli
On Fri, 2019-10-04 at 08:50 +0100, Andrew Cooper wrote: > On 04/10/2019 07:40, Juergen Gross wrote: > > sched_tick_suspend() and sched_tick_resume() should not call the > > scheduler specific timer handlers in case the cpu they are running > > on > > is just being moved to or from a cpupool. > >

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread Jürgen Groß
On 04.10.19 16:08, George Dunlap wrote: On 10/4/19 7:40 AM, Juergen Gross wrote: sched_tick_suspend() and sched_tick_resume() should not call the scheduler specific timer handlers in case the cpu they are running on is just being moved to or from a cpupool. Use a new percpu lock for that

[Xen-devel] [ovmf test] 142250: all pass - PUSHED

2019-10-04 Thread osstest service owner
flight 142250 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/142250/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 61af5f249495b18f45ca164376c871081448c0e4 baseline version: ovmf

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread George Dunlap
On 10/4/19 7:40 AM, Juergen Gross wrote: > sched_tick_suspend() and sched_tick_resume() should not call the > scheduler specific timer handlers in case the cpu they are running on > is just being moved to or from a cpupool. > > Use a new percpu lock for that purpose. Is there a reason we can't

[Xen-devel] [xen-unstable-smoke test] 142268: tolerable all pass - PUSHED

2019-10-04 Thread osstest service owner
flight 142268 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/142268/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH v7 3/3] AMD/IOMMU: pre-fill all DTEs right after table allocation

2019-10-04 Thread Andrew Cooper
On 26/09/2019 15:29, Jan Beulich wrote: > Make sure we don't leave any DTEs unexpected requests through which > would be passed through untranslated. Set V and IV right away (with > all other fields left as zero), relying on the V and/or IV bits > getting cleared only by

Re: [Xen-devel] [PATCH v7 2/3] AMD/IOMMU: allow callers to request allocate_buffer() to skip its memset()

2019-10-04 Thread Jan Beulich
On 04.10.2019 15:26, Andrew Cooper wrote: > On 26/09/2019 15:29, Jan Beulich wrote: >> The command ring buffer doesn't need clearing up front in any event. >> Subsequently we'll also want to avoid clearing the device tables. >> >> While playing with functions signatures replace undue use of fixed

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-04 Thread Jan Beulich
On 04.10.2019 15:18, Andrew Cooper wrote: > On 26/09/2019 15:28, Jan Beulich wrote: >> @@ -1068,8 +1067,29 @@ static void * __init allocate_ppr_log(st >> IOMMU_PPR_LOG_DEFAULT_ENTRIES, "PPR Log"); >> } >> >> +/* >> + * Within ivrs_mappings[] we allocate an extra

Re: [Xen-devel] [PATCH v7 2/3] AMD/IOMMU: allow callers to request allocate_buffer() to skip its memset()

2019-10-04 Thread Andrew Cooper
On 26/09/2019 15:29, Jan Beulich wrote: > The command ring buffer doesn't need clearing up front in any event. > Subsequently we'll also want to avoid clearing the device tables. > > While playing with functions signatures replace undue use of fixed width > types at the same time, and extend this

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-04 Thread Andrew Cooper
On 26/09/2019 15:28, Jan Beulich wrote: > @@ -1068,8 +1067,29 @@ static void * __init allocate_ppr_log(st > IOMMU_PPR_LOG_DEFAULT_ENTRIES, "PPR Log"); > } > > +/* > + * Within ivrs_mappings[] we allocate an extra array element to store > + * - segment number, >

Re: [Xen-devel] [PATCH 2/2] efi/boot: make sure chosen mode is set even if firmware tell it is

2019-10-04 Thread Igor Druzhinin
On 04/10/2019 14:04, Jan Beulich wrote: > On 04.10.2019 13:33, Igor Druzhinin wrote: >> On 04/10/2019 11:40, Jan Beulich wrote: >>> On 03.10.2019 15:49, Igor Druzhinin wrote: If a bootloader is using native driver instead of EFI GOP it might reset graphics mode to be different from what

Re: [Xen-devel] [PATCH 2/2] efi/boot: make sure chosen mode is set even if firmware tell it is

2019-10-04 Thread Jan Beulich
On 04.10.2019 13:33, Igor Druzhinin wrote: > On 04/10/2019 11:40, Jan Beulich wrote: >> On 03.10.2019 15:49, Igor Druzhinin wrote: >>> If a bootloader is using native driver instead of EFI GOP it might >>> reset graphics mode to be different from what firmware thinks it >>> currently is. Set

Re: [Xen-devel] [PATCH 1/2] efi/boot: fix set_color function

2019-10-04 Thread Jan Beulich
On 04.10.2019 13:25, Igor Druzhinin wrote: > On 04/10/2019 12:14, Jan Beulich wrote: >> On 04.10.2019 12:54, Igor Druzhinin wrote: >>> On 04/10/2019 11:34, Jan Beulich wrote: On 03.10.2019 15:49, Igor Druzhinin wrote: > - 0 is a possible and allowed value for a color mask accroding to

Re: [Xen-devel] [PATCH 2/2] x86emul: adjust MOVSXD source operand handling

2019-10-04 Thread Andrew Cooper
On 02/10/2019 10:17, Jan Beulich wrote: > On 02.10.2019 10:51, Andrew Cooper wrote: >> On 02/10/2019 08:07, Jan Beulich wrote: >>> On 01.10.2019 21:44, Andrew Cooper wrote: In this example, hardware can the emulator can disagree by using a different access width. I've been

[Xen-devel] [qemu-mainline test] 142243: regressions - FAIL

2019-10-04 Thread osstest service owner
flight 142243 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/142243/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 140282

Re: [Xen-devel] [PATCH for-4.13 2/2] xen/nospec: Introduce CONFIG_SPECULATIVE_BRANCH_HARDEN and disable it

2019-10-04 Thread Wieczorkiewicz, Pawel
> On 2. Oct 2019, at 23:02, Andrew Cooper wrote: > > On 02/10/2019 10:50, Wieczorkiewicz, Pawel wrote: >> I've taken, as a simple example, >> p2m_mem_access_sanity_check(), and this looks to be the way gcc9 has >> generated >> code (in a non-debug build). Hence either I'm

Re: [Xen-devel] [PATCH 2/2] efi/boot: make sure chosen mode is set even if firmware tell it is

2019-10-04 Thread Igor Druzhinin
On 04/10/2019 11:40, Jan Beulich wrote: > On 03.10.2019 15:49, Igor Druzhinin wrote: >> If a bootloader is using native driver instead of EFI GOP it might >> reset graphics mode to be different from what firmware thinks it >> currently is. Set chosen mode unconditionally to fix this possible >>

Re: [Xen-devel] [PATCH 1/2] efi/boot: fix set_color function

2019-10-04 Thread Igor Druzhinin
On 04/10/2019 12:14, Jan Beulich wrote: > On 04.10.2019 12:54, Igor Druzhinin wrote: >> On 04/10/2019 11:34, Jan Beulich wrote: >>> On 03.10.2019 15:49, Igor Druzhinin wrote: - 0 is a possible and allowed value for a color mask accroding to UEFI Spec 2.6 (11.9) especially for reserved

Re: [Xen-devel] [PATCH 1/2] efi/boot: fix set_color function

2019-10-04 Thread Jan Beulich
On 04.10.2019 12:54, Igor Druzhinin wrote: > On 04/10/2019 11:34, Jan Beulich wrote: >> On 03.10.2019 15:49, Igor Druzhinin wrote: >>> - 0 is a possible and allowed value for a color mask accroding to >>> UEFI Spec 2.6 (11.9) especially for reserved mask >> >> Hmm, looking at 2.8 (where it's

Re: [Xen-devel] [PATCH 1/2] efi/boot: fix set_color function

2019-10-04 Thread Igor Druzhinin
On 04/10/2019 11:34, Jan Beulich wrote: > On 03.10.2019 15:49, Igor Druzhinin wrote: >> - 0 is a possible and allowed value for a color mask accroding to >> UEFI Spec 2.6 (11.9) especially for reserved mask > > Hmm, looking at 2.8 (where it's section 12.9, which in turn is why > section titles

Re: [Xen-devel] [PATCH 2/2] efi/boot: make sure chosen mode is set even if firmware tell it is

2019-10-04 Thread Jan Beulich
On 03.10.2019 15:49, Igor Druzhinin wrote: > If a bootloader is using native driver instead of EFI GOP it might > reset graphics mode to be different from what firmware thinks it > currently is. Set chosen mode unconditionally to fix this possible > misalignment. > > Observed with EFI GRUB2

Re: [Xen-devel] [PATCH 1/2] efi/boot: fix set_color function

2019-10-04 Thread Jan Beulich
On 03.10.2019 15:49, Igor Druzhinin wrote: > - 0 is a possible and allowed value for a color mask accroding to > UEFI Spec 2.6 (11.9) especially for reserved mask Hmm, looking at 2.8 (where it's section 12.9, which in turn is why section titles would be more helpful in such references) I can't

Re: [Xen-devel] [PATCH for-4.13] x86/spec-ctrl: Annotate remaining model names

2019-10-04 Thread Jan Beulich
On 03.10.2019 16:25, Andrew Cooper wrote: > The names in retpoline_safe() are copied from should_use_eager_fpu(). The > names in mds_calculations() come partly from Linux's intel-family.h, and > partly from conversations with Intel. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich

Re: [Xen-devel] Errors with Loading Xen at a Certain Address

2019-10-04 Thread Julien Grall
Hi Brian, On 04/10/2019 01:25, Brian Woods wrote: On Thu, Oct 03, 2019 at 10:20:36PM +0100, Julien Grall wrote: Hi Brian, On 10/3/19 9:24 PM, Brian Woods wrote: On Thu, Oct 03, 2019 at 07:23:23PM +, Julien Grall wrote: There's a WARN_ON() between the two debug printks calls I shared

[Xen-devel] [linux-4.4 test] 142222: regressions - FAIL

2019-10-04 Thread osstest service owner
flight 14 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/14/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail in 142019 REGR. vs. 139698 Tests

Re: [Xen-devel] [PATCH for-4.13] docs: update all URLs in man pages

2019-10-04 Thread Wei Liu
On Thu, Oct 03, 2019 at 04:12:30PM +, Lars Kurth wrote: > Specifically > * xen.org to xenproject.org > * http to https > * Replaced pages where page has moved > (including on xen pages as well as external pages) > * Removed some URLs (e.g. downloads for Linux PV drivers) > > Tested-by: Lars

Re: [Xen-devel] [PATCH for-4.13 2/2] xen/nospec: Introduce CONFIG_SPECULATIVE_BRANCH_HARDEN and disable it

2019-10-04 Thread Jan Beulich
On 02.10.2019 21:31, Andrew Cooper wrote: > On 02/10/2019 09:24, Jan Beulich wrote: >> On 01.10.2019 17:37, Andrew Cooper wrote: >>> On 01/10/2019 15:32, Jan Beulich wrote: On 01.10.2019 14:51, Andrew Cooper wrote: > On 01/10/2019 13:21, Jan Beulich wrote: >> On 30.09.2019 20:24,

Re: [Xen-devel] [PATCH for-4.13] docs: update all URLs in man pages

2019-10-04 Thread Wei Liu
On Thu, Oct 03, 2019 at 04:12:30PM +, Lars Kurth wrote: > Specifically > * xen.org to xenproject.org > * http to https > * Replaced pages where page has moved > (including on xen pages as well as external pages) > * Removed some URLs (e.g. downloads for Linux PV drivers) > > Tested-by: Lars

Re: [Xen-devel] [PATCH] x86/vvmx: Fix the use of RDTSCP when it is intercepted at L0

2019-10-04 Thread Wei Liu
On Thu, Oct 03, 2019 at 11:47:36AM +0100, Andrew Cooper wrote: > Linux has started using RDTSCP as of v5.1. This has highlighted a bug in Xen, > where virtual vmexit simply gives up. > > (XEN) d1v1 Unhandled nested vmexit: reason 51 > (XEN) domain_crash called from vvmx.c:2671 > (XEN)

Re: [Xen-devel] [PATCH for-4.13] docs: update all URLs in man pages

2019-10-04 Thread Andrew Cooper
On 03/10/2019 17:12, Lars Kurth wrote: > Specifically > * xen.org to xenproject.org > * http to https > * Replaced pages where page has moved > (including on xen pages as well as external pages) > * Removed some URLs (e.g. downloads for Linux PV drivers) > > Tested-by: Lars Kurth >

Re: [Xen-devel] [PATCH v9 8/8] xen/arm: add dom0-less device assignment info to docs

2019-10-04 Thread Julien Grall
Hi Stefano, On 04/10/2019 02:14, Stefano Stabellini wrote: + +Dom0-less Device Passthrough + + +The partial device tree for dom0-less guests should have the following +properties for each node corresponding to a physical device to assign to +the guest: + +- xen,reg +

Re: [Xen-devel] [PATCH v9 5/8] xen/arm: assign devices to boot domains

2019-10-04 Thread Julien Grall
Hi Stefano, On 04/10/2019 02:14, Stefano Stabellini wrote: Scan the user provided dtb fragment at boot. For each device node, map memory to guests, and route interrupts and setup the iommu. The memory region to remap is specified by the "xen,reg" property. The iommu is setup by passing the

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread Andrew Cooper
On 04/10/2019 07:40, Juergen Gross wrote: > sched_tick_suspend() and sched_tick_resume() should not call the > scheduler specific timer handlers in case the cpu they are running on > is just being moved to or from a cpupool. > > Use a new percpu lock for that purpose. > > Reported-by: Sergey

[Xen-devel] [linux-linus test] 142223: regressions - FAIL

2019-10-04 Thread osstest service owner
flight 142223 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/142223/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 133580

[Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-04 Thread Juergen Gross
sched_tick_suspend() and sched_tick_resume() should not call the scheduler specific timer handlers in case the cpu they are running on is just being moved to or from a cpupool. Use a new percpu lock for that purpose. Reported-by: Sergey Dyasli Signed-off-by: Juergen Gross --- To be applied on

[Xen-devel] [linux-4.19 test] 142224: tolerable FAIL - PUSHED

2019-10-04 Thread osstest service owner
flight 142224 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/142224/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 11 examine-serial/bootloaderfail like 141913 test-amd64-i386-qemut-rhel6hvm-amd 12