On Fri, Jul 2, 2021 at 12:22 AM Anthony PERARD
wrote:
>
> This allows to `make arch/riscv/riscv64/head.o`.
>
> Example of rune on a fresh copy of the repository:
> make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu-
> KBUILD_DEFCONFIG=tiny64_defconfig arch/riscv/riscv64/head.o
>
>
flight 163215 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/163215/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332
ext specific files
for 20210701
# good: [62fb9874f5da54fdb243003b386128037319b219] Linux 5.13
git bisect start 'HEAD' 'v5.13'
# bad: [f63c4fda987a19b1194cc45cb72fd5bf968d9d90] Merge remote-tracking branch
'rdma/for-next'
git bisect bad f63c4fda987a19b1194cc45cb72fd5bf968d9d90
# good: [46bb5dd1d2a63e906e374e
flight 163217 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/163217/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359
flight 163213 qemu-mainline real [real]
flight 163218 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/163213/
http://logs.test-lab.xenproject.org/osstest/logs/163218/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not
flight 163216 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/163216/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359
flight 163214 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/163214/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359
flight 163207 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/163207/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332
flight 163206 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/163206/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in
163190 pass in 163206
On 7/1/21 7:10 AM, Anthony PERARD wrote:
> This allows to `make arch/riscv/riscv64/head.o`.
>
> Example of rune on a fresh copy of the repository:
> make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu-
> KBUILD_DEFCONFIG=tiny64_defconfig arch/riscv/riscv64/head.o
>
> Signed-off-by:
On 7/1/21 7:10 AM, Anthony PERARD wrote:
> A subdirectory is now built by setting "$(obj)" instead of changing
> directory. "$(obj)" should always be set when using "Rules.mk" and
> thus a shortcut "$(build)" is introduced and should be used.
>
> A new variable "$(need-builtin)" is introduce. It
On Thu, 1 Jul 2021, Luca Fancellu wrote:
> Hi Stefano,
>
> > On 24 Jun 2021, at 00:34, Stefano Stabellini wrote:
> >
> > On Mon, 10 May 2021, Luca Fancellu wrote:
> >> Modification to include/public/grant_table.h:
> >>
> >> 1) Add doxygen tags to:
> >> - Create Grant tables section
> >> -
On Thu, 1 Jul 2021, Luca Fancellu wrote:
> > On 24 Jun 2021, at 00:33, Stefano Stabellini wrote:
> >
> > On Mon, 10 May 2021, Luca Fancellu wrote:
> >> Modify docs/Makefile to call doxygen and generate sphinx
> >> html documentation given the doxygen XML output.
> >>
> >> Modify docs/conf.py
On Thu, 1 Jul 2021, Luca Fancellu wrote:
> > On 23 Jun 2021, at 23:03, Stefano Stabellini wrote:
> >
> > On Mon, 10 May 2021, Luca Fancellu wrote:
> >> Add preprocessor called by doxygen before parsing headers,
> >> it will include in every header a doxygen_include.h file
> >> that provides
flight 163210 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/163210/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359
Hey Anthony,
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8a52a03969fe..03a5553116a8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> -F: xen/include/asm-arm/
> +F: xen/include/arch-arm/
... snip ...
> -F: xen/include/asm-x86/
> +F: xen/include/arch-x86/
It looks like riscv will
On Thu, 1 Jul 2021, Luca Fancellu wrote:
> > On 24 Jun 2021, at 00:34, Stefano Stabellini wrote:
> >
> > On Mon, 10 May 2021, Luca Fancellu wrote:
> >> Create a skeleton for the documentation about hypercalls
> >>
> >> Signed-off-by: Luca Fancellu
> >> ---
> >> v6 changes:
> >> - Now every
On 01/07/2021 15:09, Anthony PERARD wrote:
This avoid the need to create the symbolic link "include/asm".
Signed-off-by: Anthony PERARD
Acked-by: Paul Durrant
Am Thu, 1 Jul 2021 17:45:12 +0100
schrieb Anthony PERARD :
> But can't libxl_save_msgs_gen.pl been able to deal with
> thing like 'struct precopy_stats' ? It seems to be able to deal with
> 'unsigned long'.
Yes, this is apparently possible.
I have to check why I thought it was required to turn
On Thu, Jul 01, 2021 at 11:56:28AM +0200, Olaf Hering wrote:
> This will help libxl_save_msgs_gen.pl to copy the struct as a region of
> memory.
>
> No change in behavior intented.
>
> Signed-off-by: Olaf Hering
> ---
> tools/include/xensaverestore.h | 7 +++
>
Am Thu, 1 Jul 2021 17:28:25 +0100
schrieb Andrew Cooper :
> 0x801c
Dues this need to be tagged as unsigned with a trailing U?
Olaf
pgpUDLCgMImch.pgp
Description: Digitale Signatur von OpenPGP
On 01/07/2021 17:23, Olaf Hering wrote:
> Am Thu, 1 Jul 2021 16:25:10 +0100
> schrieb Andrew Cooper :
>
>> - p->extd.max_leaf = min(p->extd.max_leaf, 0x1cu);
>> + p->extd.max_leaf = 0x8000 | min(p->extd.max_leaf & 0x,
>> 0x1cu);
> Yes, this fixes it for me. Thanks.
Am Thu, 1 Jul 2021 16:25:10 +0100
schrieb Andrew Cooper :
> - p->extd.max_leaf = min(p->extd.max_leaf, 0x1cu);
> + p->extd.max_leaf = 0x8000 | min(p->extd.max_leaf & 0x,
> 0x1cu);
Yes, this fixes it for me. Thanks.
Olaf
pgpaVhBDW9H21.pgp
Description: Digitale Signatur
The LIBS section doesn't mention the headers associated with the
libraries, same for LIBXENLIGHT section.
They aren't any ':' in other section names, so remove it.
Fixes: 4664034cdc72 ("tools/libs: move official headers to common directory")
Fixes: f7079d7ef69f ("MAINTAINERS: add myself as
flight 163212 xtf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/163212/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
xtf cdef9568c1b1f8831f3b8f644073e635d47f0ec4
baseline version:
xtf
On 01/07/2021 16:18, Olaf Hering wrote:
> Am Thu, 1 Jul 2021 16:13:21 +0100
> schrieb Andrew Cooper :
>
>> That logic is definitely incorrect, but using a different constant isn't
>> right.
> Yeah, that occurred to me after sending this email.
> I think in the end the values should probably get
Am Thu, 1 Jul 2021 16:13:21 +0100
schrieb Andrew Cooper :
> That logic is definitely incorrect, but using a different constant isn't
> right.
Yeah, that occurred to me after sending this email.
I think in the end the values should probably get closer to 51, not smaller
than the current one.
On 01/07/2021 16:00, Olaf Hering wrote:
> Am Thu, 1 Jul 2021 12:19:24 +0100
> schrieb Andrew Cooper :
>
>> Where is the 51 leaves coming in?
> I suspect the bug is this line, and the magic "0x1c" value:
>
> p->extd.max_leaf = min(p->extd.max_leaf, 0x1cu);
>
> In my testing basic remains at 13,
Am Thu, 1 Jul 2021 15:49:08 +0100
schrieb Andrew Cooper :
> --debug makes no sense at all in a checkpointed stream.
This should probably have become "ctx->save.checkpointed == MIG_STREAM_NONE".
But this still leaves the question what value this code branch has when
verify_frames does not, and
Am Thu, 1 Jul 2021 12:19:24 +0100
schrieb Andrew Cooper :
> Where is the 51 leaves coming in?
I suspect the bug is this line, and the magic "0x1c" value:
p->extd.max_leaf = min(p->extd.max_leaf, 0x1cu);
In my testing basic remains at 13, while extd is truncated from 0x8008 to
28.
I think
On 01/07/2021 15:41, Olaf Hering wrote:
> Am Thu, 1 Jul 2021 16:40:55 +0200
> schrieb Olaf Hering :
>
>> could
> "code", sorry.
c/s 7449fb36c6c81d2ba10a40b59e61a9f420cd8450 was buggy and inverted the
condition while making the code transformation.
--debug makes no sense at all in a checkpointed
Am Thu, 1 Jul 2021 16:40:55 +0200
schrieb Olaf Hering :
> could
"code", sorry.
Olaf
pgplVbaHz40oE.pgp
Description: Digitale Signatur von OpenPGP
Am Thu, 1 Jul 2021 15:33:47 +0100
schrieb Andrew Cooper :
> Since when? It was absolutely critical to debugging issues during the
> development of migration v2.
Well, I can find out if needed.
What could would it enable today?
Last time I looked there was none.
Olaf
pgpDXPbP6IGpy.pgp
On 01/07/2021 10:55, Olaf Hering wrote:
> xl migrate --debug used to track every pfn in every batch of pages.
> But these times are gone. The code in xc_domain_save is the consumer
> of this knob, but it considers it only for the remus and colo case.
>
> Adjust the help text to tell what --debug
On Thu, Jul 01, 2021 at 11:55:58AM +0200, Olaf Hering wrote:
> xl migrate --debug used to track every pfn in every batch of pages.
> But these times are gone. The code in xc_domain_save is the consumer
> of this knob, but it considers it only for the remus and colo case.
>
> Adjust the help text
Avoid depending on Makefile but still allow to rebuild the banner when
$(XEN_FULLVERSION) changes.
Also add a dependency on tools/xen.flf, even if not expected to
change.
Signed-off-by: Anthony PERARD
---
xen/Makefile | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
We are going to need the variable XEN_BUILD_EFI earlier.
This early check is using "try-run" to allow to have a temporary
output file in case it is needed for $(CC) to build the *.c file.
The "efi/check.o" file is still needed in "arch/x86/Makefile" so the
check is currently duplicated.
This
In a future patch, when building a subdirectory, we will set
"obj=$subdir" rather than change directory.
Before that, we add "$(obj)" and "$(src)" in as many places as
possible where we will need to know which subdirectory is been built.
"$(obj)" is for files been generated during the build, and
This avoid the need to create the symbolic link "include/asm".
Signed-off-by: Anthony PERARD
---
Other possible locations that I could think of:
include/arch/*/asm
arch/*/include/asm
---
.gitignore| 5 ++-
MAINTAINERS | 36
Avoid different spelling for the location of "xen-syms", and simply
use the dependency variable. This avoid the assumption about $(TARGET)
value.
Signed-off-by: Anthony PERARD
---
xen/arch/x86/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/Makefile
This allows to `make arch/riscv/riscv64/head.o`.
Example of rune on a fresh copy of the repository:
make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu-
KBUILD_DEFCONFIG=tiny64_defconfig arch/riscv/riscv64/head.o
Signed-off-by: Anthony PERARD
---
xen/arch/riscv/riscv64/Makefile |
Those two dependencies already exist so make doesn't need to know
about them. The dependency will be generated by $(CC).
Signed-off-by: Anthony PERARD
---
xen/arch/x86/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index
This is to avoid arch/$arch/Makefile having to recurse into parents
directories.
This avoid duplication of the logic to build prelink.o between arches.
In order to do that, we cut the $(TARGET) target in the main Makefile in
two, there is a "prepare" phase/target runned before starting to build
This macro does compare command line like if_changed, but it also
rewrite the dependencies generated by $(CC) in order to depend on a
CONFIG_* as generated by kconfig instead of depending on autoconf.h.
This allow to make a change in kconfig options and only rebuild the
object that uses that
This rework the livepatch/Makefile to make it less repetitive and make
use of the facilities. All the targets to be built are now listed in
$(extra-y) which will allow Rules.mk to build them without the need of
a local target in a future patch.
There are some changes/fixes in this patch:
- when
A subdirectory is now built by setting "$(obj)" instead of changing
directory. "$(obj)" should always be set when using "Rules.mk" and
thus a shortcut "$(build)" is introduced and should be used.
A new variable "$(need-builtin)" is introduce. It is to be used
whenever a "built_in.o" is wanted
There is no need to try to guess a relative path to the "xen.efi" file,
we can simply use $@. Also, there's no need to use `notdir`, make
already do that work via $(@F).
Signed-off-by: Anthony PERARD
---
xen/arch/arm/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Anthony PERARD
---
xen/Makefile | 1 +
xen/scripts/Makefile.clean | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/xen/Makefile b/xen/Makefile
index fd002ecd52d0..6aac68750b4d 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -378,6 +378,7 @@
Hi Stefano,
> On 24 Jun 2021, at 00:34, Stefano Stabellini wrote:
>
> On Mon, 10 May 2021, Luca Fancellu wrote:
>> Modification to include/public/grant_table.h:
>>
>> 1) Add doxygen tags to:
>> - Create Grant tables section
>> - include variables in the generated documentation
>> - Used
This will allow to detect command line changes and allow to regenerate
the file in that case.
Signed-off-by: Anthony PERARD
---
xen/common/Makefile| 8 ++--
xen/xsm/flask/Makefile | 8 ++--
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/xen/common/Makefile
This will always try regenerate the content of compile.h, but if it
didn't change the file isn't updated.
Also, as it's currently the case, the file isn't regenerated during
`sudo make install` if it exist and does belong to a different user.
Thus, we can remove the target
This allows Makefile.clean to recurse into livepatch without help.
Signed-off-by: Anthony PERARD
---
xen/test/Makefile | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/xen/test/Makefile b/xen/test/Makefile
index aaa499664396..41e4d7bdb78b 100644
---
head.o is been built twice, once because it is in $(ALL_OBJS) and a
second time because it is in $(extra-y) and thus it is rebuilt when
building "arch/arm/built_in.o".
Fix this by adding a dependency of "head.o" on the directory
"arch/arm/".
Also, we should avoid building object that are in
And thus avoiding checking for those variable over and over again.
Signed-off-by: Anthony PERARD
---
xen/Makefile | 22 ++
xen/Rules.mk | 22 --
2 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/xen/Makefile b/xen/Makefile
index
The make variable $(subdir-y) isn't used yet but will be in a
following patch. Anything in $(subdir-y) doesn't to have a '/' as
suffix as we already now it's a directory.
Rework the rules so that it doesn't matter whether there is a '/' or
not. It also mimic more closely to the way Linux's Kbuild
Signed-off-by: Anthony PERARD
---
xen/arch/arm/Makefile | 8
xen/arch/arm/arch.mk | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 0edd9dee6f49..3d0af8ebc93c 100644
--- a/xen/arch/arm/Makefile
+++
Signed-off-by: Anthony PERARD
---
xen/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/Makefile b/xen/Makefile
index e4deceab2c9a..dae0247067ff 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -341,7 +341,7 @@ _clean: delete-unfresh-files
$(MAKE) $(clean)
Signed-off-by: Anthony PERARD
---
xen/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/Makefile b/xen/Makefile
index 360b4a1d1867..e4deceab2c9a 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -343,7 +343,7 @@ _clean: delete-unfresh-files
$(MAKE) $(clean)
No need to call $(MAKE) again.
Signed-off-by: Anthony PERARD
---
xen/tools/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/xen/tools/Makefile b/xen/tools/Makefile
index e940939d61f4..4e42163f981c 100644
--- a/xen/tools/Makefile
+++ b/xen/tools/Makefile
@@ -2,8
In Arm and X86 makefile, generating the linker script is the same, so
we can simply have both call the same macro.
We need to add *.lds files into extra-y so that Rules.mk can find the
.*.cmd dependency file and load it.
Change made to the command line:
- Use cpp_flags macro which simply filter
Use $(dot-target) to have the target name prefix with a dot.
Now, when the CC command has run, it is recorded in .*.cmd
file, then if_changed_rules will compare it on subsequent runs.
Signed-off-by: Anthony PERARD
Reviewed-by: Jan Beulich
---
xen/Rules.mk | 26 +-
1
Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
br.build-system-xen-v6
v6:
This new version of the series get's us very close to be able to do
out-of-tree build, but I've stop at been able to use Linux's `fixdep` and
getting
Replace a mix of shell script and python script by all python script.
Also remove dependency on Makefile as the file generation doesn't
depend on it anymore.
No change to the final generated headers.
Signed-off-by: Anthony PERARD
Acked-by: Wei Liu
---
Notes:
v6:
- removed handling of
In the case where $(obj-y) is empty, we also replace $(c_flags) by
$(XEN_CFLAGS) to avoid generating an .%.d dependency file. This avoid
make trying to include %.h file in the ld command if $(obj-y) isn't
empty anymore on a second run.
Signed-off-by: Anthony PERARD
Acked-by: Jan Beulich
---
Improvement are:
- give the path to xlat.lst as argument
- include `grep -v` in compat-build-source.py script, we don't need to
write this in several scripted language.
Also remove dependency on Makefile as the file generation doesn't
depend on it anymore.
No changes in final compat/%.h
This replace the use of a single .c file use for multiple .o file by
creating multiple .c file including the first one.
There's quite a few issues with trying to build more than one object
file from a single source file: there's is a duplication of the make
rules to generate those targets; there
Signed-off-by: Anthony PERARD
---
Notes:
v6:
- switch to a macro as suggested
which allows to be used with both a_flags and c_flags
v5:
- new patch
xen/Rules.mk| 7 +--
xen/arch/x86/mm/Makefile| 2 +-
xen/arch/x86/mm/hap/Makefile|
Fixes: e321576f4047 ("xen/build: start using if_changed")
Signed-off-by: Anthony PERARD
---
Notes:
v6:
- new patch
xen/Rules.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/Rules.mk b/xen/Rules.mk
index ceb3d204b84f..d65d6a48993b 100644
--- a/xen/Rules.mk
> On Jun 21, 2021, at 5:11 PM, Nick Rosbrook wrote:
>
> On Fri, Jun 18, 2021 at 11:00:26AM +, George Dunlap wrote:
>>
>>
>>> On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote:
>>>
>>> In gengotypes.py, the toC functions only set C string fields when
>>> the Go strings are non-empty.
> On 24 Jun 2021, at 00:34, Stefano Stabellini wrote:
>
> On Mon, 10 May 2021, Luca Fancellu wrote:
>> Create a skeleton for the documentation about hypercalls
>>
>> Signed-off-by: Luca Fancellu
>> ---
>> v6 changes:
>> - Now every platform has the same sections in .rst files
>> ---
>>
From: Julien Grall
When Live-Updating with some load, Xenstored may hit the assert
req->in == lu_status->in in do_lu_start().
This is happening because the request is stashed when Live-Update
begins. This happens in a different request (see call lu_begin()
when select the new binary) from the
flight 163204 qemu-mainline real [real]
flight 163211 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/163204/
http://logs.test-lab.xenproject.org/osstest/logs/163211/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not
> On 24 Jun 2021, at 00:33, Stefano Stabellini wrote:
>
> On Mon, 10 May 2021, Luca Fancellu wrote:
>> Modify docs/Makefile to call doxygen and generate sphinx
>> html documentation given the doxygen XML output.
>>
>> Modify docs/conf.py sphinx configuration file to setup
>> the breathe
Am Thu, 1 Jul 2021 13:35:20 +0100
schrieb Andrew Cooper :
> Can you grab xen-cpuid -p from this system please?
Two PowerEdge T320 with E5-2430L.
Xen reports there are maximum 119 leaves and 2 MSRs
Raw policy: 32 leaves, 2 MSRs
CPUID:
leaf subleaf -> eax ebx ecx edx
> On 23 Jun 2021, at 23:03, Stefano Stabellini wrote:
>
> On Mon, 10 May 2021, Luca Fancellu wrote:
>> Add preprocessor called by doxygen before parsing headers,
>> it will include in every header a doxygen_include.h file
>> that provides missing defines and includes that are
>> usually
On 01/07/2021 12:36, Olaf Hering wrote:
> Am Thu, 1 Jul 2021 12:19:24 +0100
> schrieb Andrew Cooper :
>
>> This *ought* to be "grab default, edit a few details, send back to
>> Xen". Where is the 51 leaves coming in? Do you have cpuid= lines in
>> the xl cfg file?
> No cpuid= or anything in
Hi Olaf,
On 01/07/2021 13:00, Olaf Hering wrote:
Am Thu, 1 Jul 2021 12:40:09 +0100
schrieb Julien Grall :
You would be the sole maintainer of the directory
Yes that is the point, it changes the count from zero to one.
The code you are moving is already maintained by the tools maintainers.
Am Thu, 1 Jul 2021 12:40:09 +0100
schrieb Julien Grall :
> You would be the sole maintainer of the directory
Yes that is the point, it changes the count from zero to one.
Olaf
pgp0gUf5kEV2D.pgp
Description: Digitale Signatur von OpenPGP
Hi Olaf,
On 01/07/2021 12:01, Olaf Hering wrote:
Am Thu, 1 Jul 2021 12:39:06 +0200
schrieb Jan Beulich :
I'm afraid this goes too far: This way you remove all prior
(direct) maintainers (see "The meaning of nesting" in
./MAINTAINERS). And I'm sure Andrew, who has written much of
this, ought
Am Thu, 1 Jul 2021 12:19:24 +0100
schrieb Andrew Cooper :
> This *ought* to be "grab default, edit a few details, send back to
> Xen". Where is the 51 leaves coming in? Do you have cpuid= lines in
> the xl cfg file?
No cpuid= or anything in domU.cfg or Xen cmdline.
If I understand
On 01/07/2021 11:56, Olaf Hering wrote:
> For some reason migration of HVM domUs from pre-4.14 to staging is broken.
>
> It seems xc_cpuid_apply_policy gets nr_leaves=119 from
> XEN_SYSCTL_get_cpu_policy.
> Later XEN_SYSCTL_cpu_policy_hvm_default truncates this value to 31.
119 is the maximum
Am Thu, 1 Jul 2021 12:39:06 +0200
schrieb Jan Beulich :
> I'm afraid this goes too far: This way you remove all prior
> (direct) maintainers (see "The meaning of nesting" in
> ./MAINTAINERS). And I'm sure Andrew, who has written much of
> this, ought to be considered to become the maintainer of
For some reason migration of HVM domUs from pre-4.14 to staging is broken.
It seems xc_cpuid_apply_policy gets nr_leaves=119 from
XEN_SYSCTL_get_cpu_policy.
Later XEN_SYSCTL_cpu_policy_hvm_default truncates this value to 31.
As a result x86_cpuid_copy_to_buffer returns -ENOBUFS. It would copy up
On 01.07.2021 11:56, Olaf Hering wrote:
> I touched it last.
For my taste, this is too little as a justification.
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -381,6 +381,12 @@ R: Juergen Gross
> S: Supported
> F: tools/libs/
>
> +LIBSAVERESTORE:
Nit: DYM LIBXENSAVERESTORE (and
On 01/07/2021 11:30, Olaf Hering wrote:
> Replace emualted with emulated.
>
> Signed-off-by: Olaf Hering
Acked-by: Andrew Cooper
Replace emualted with emulated.
Signed-off-by: Olaf Hering
---
tools/libs/light/libxl_cpuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c
index eb6feaa96d..b2c673841a 100644
---
On 01.07.2021 11:24, Julien Grall wrote:
> On 01/07/2021 09:26, Jan Beulich wrote:
>> On 30.06.2021 20:29, Julien Grall wrote:
>>> On 10/06/2021 10:49, Jan Beulich wrote:
On 07.06.2021 04:43, Penny Zheng wrote:
> Introduce new interface assign_pages_nr to deal with when page number is
handle_page_data must be able to read directly into mapped guest memory.
This will avoid unneccesary memcpy calls for data that can be consumed verbatim.
Split the various steps of record processing:
- move processing to handle_buffered_page_data
- adjust xenforeignmemory_map to set errno in case
Upcoming changes will pass more knobs down to xc_domain_save.
Adjust the libxl_domain_suspend API to allow easy adding of additional knobs.
No change in behavior intented.
Signed-off-by: Olaf Hering
Acked-by: Christian Lindig
---
tools/include/libxl.h| 26
Remove allocation from hotpath, move map_errs array into preallocated space.
Signed-off-by: Olaf Hering
Reviewed-by: Juergen Gross
---
tools/libs/saverestore/common.h | 1 +
tools/libs/saverestore/restore.c | 12 +---
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git
Remove allocation from hotpath, move iov array into preallocated space.
Signed-off-by: Olaf Hering
Reviewed-by: Juergen Gross
---
tools/libs/saverestore/common.h | 2 ++
tools/libs/saverestore/save.c | 7 ++-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git
Since the incoming migration stream lacks info about what the highest pfn
will be, some data structures can not be allocated upfront.
Add an API for expandable bitmaps, loosely based on pfn_set_populated.
Signed-off-by: Olaf Hering
---
tools/libs/saverestore/common.c | 39 +++
Remove allocation from hotpath, move populate_pfns' pfns array into
preallocated space.
Use some prefix to avoid conflict with an array used in handle_page_data.
Signed-off-by: Olaf Hering
Reviewed-by: Juergen Gross
---
tools/libs/saverestore/common.h | 1 +
tools/libs/saverestore/restore.c
Remove allocation from hotpath, move types array into preallocated space.
Signed-off-by: Olaf Hering
Reviewed-by: Juergen Gross
---
tools/libs/saverestore/common.h | 1 +
tools/libs/saverestore/restore.c | 12 +---
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git
handle_page_data must be able to read directly into mapped guest memory.
This will avoid unneccesary memcpy calls for data which can be consumed
verbatim.
Rearrange the code to allow decisions based on the incoming record.
This change is preparation for future changes in handle_page_data,
no
Remove allocation from hotpath, move mfns array into preallocated space.
Signed-off-by: Olaf Hering
Reviewed-by: Juergen Gross
---
tools/libs/saverestore/common.h | 2 ++
tools/libs/saverestore/save.c | 7 ++-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git
Move all save/restore related code from libxenguest.so into a separate
library libxensaverestore.so. The only consumer is libxl-save-helper.
There is no need to have the moved code mapped all the time in binaries
where libxenguest.so is used.
According to size(1) the change is:
textdata
This will help libxl_save_msgs_gen.pl to copy the struct as a region of memory.
No change in behavior intented.
Signed-off-by: Olaf Hering
---
tools/include/xensaverestore.h | 7 +++
tools/libs/saverestore/common.h | 2 +-
tools/libs/saverestore/save.c | 6 +++---
3 files changed, 7
Read incoming migration stream directly into the guest memory.
This avoids the memory allocation and copying, and the resulting
performance penalty.
Signed-off-by: Olaf Hering
---
tools/libs/saverestore/common.h | 1 +
tools/libs/saverestore/restore.c | 132 ++-
2
Remove allocation from hotpath, move rec_pfns array into preallocated space.
Signed-off-by: Olaf Hering
Reviewed-by: Juergen Gross
---
tools/libs/saverestore/common.h | 2 ++
tools/libs/saverestore/save.c | 11 +--
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git
1 - 100 of 138 matches
Mail list logo
