[xen-unstable test] 175408: regressions - trouble: broken/fail/pass

2022-12-19 Thread osstest service owner
flight 175408 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175408/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-pair broken test-amd64-i386-xl-pvshim

[ovmf test] 175416: regressions - FAIL

2022-12-19 Thread osstest service owner
flight 175416 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175416/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 175202

[linux-5.4 test] 175407: regressions - trouble: broken/fail/pass

2022-12-19 Thread osstest service owner
flight 175407 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175407/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel broken

[xen-unstable-smoke test] 175415: tolerable all pass - PUSHED

2022-12-19 Thread osstest service owner
flight 175415 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175415/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[PATCH v5 10/10] x86: Use Linux's PAT

2022-12-19 Thread Demi Marie Obenour
This is purely for testing, to see if it works around a bug in i915. It is not intended to be merged. NOT-signed-off-by: DO NOT MERGE --- xen/arch/x86/include/asm/page.h | 4 ++-- xen/arch/x86/include/asm/processor.h | 10 +- xen/arch/x86/mm.c| 8 3

[PATCH v5 07/10] x86: Derive XEN_MSR_PAT from its individual entries

2022-12-19 Thread Demi Marie Obenour
This avoids it being a magic constant that is difficult for humans to decode. Use BUILD_BUG_ON to check that the old and new values are identical. Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich --- Changes since v4: - Explain that changing XEN_MSR_PAT breaks guests that rely on the

[PATCH v5 09/10] x86/mm: Reject invalid cacheability in PV guests by default

2022-12-19 Thread Demi Marie Obenour
Setting cacheability flags that are not ones specified by Xen is a bug in the guest. By default, inject #GP into any guest that does this. allow_invalid_cacheability can be used on the Xen command line to disable this check. Suggested-by: Andrew Cooper Signed-off-by: Demi Marie Obenour ---

[PATCH v5 06/10] x86: Remove MEMORY_NUM_TYPES and NO_HARDCODE_MEM_TYPE

2022-12-19 Thread Demi Marie Obenour
No functional change intended. Signed-off-by: Demi Marie Obenour --- This patch is optional. Subsequent patches should not depend on it. Changes since v2: - Keep MTRR_NUM_TYPES and adjust commit message accordingly --- xen/arch/x86/hvm/mtrr.c | 18 +-

[PATCH v5 08/10] x86/mm: make code robust to future PAT changes

2022-12-19 Thread Demi Marie Obenour
It may be desirable to change Xen's PAT for various reasons. This requires changes to several _PAGE_* macros as well. Add static assertions to check that XEN_MSR_PAT is consistent with the _PAGE_* macros, and that _PAGE_WB is 0 as required by Linux. Signed-off-by: Demi Marie Obenour ---

[PATCH v5 03/10] x86: Replace PAT_* with X86_MT_*

2022-12-19 Thread Demi Marie Obenour
This allows eliminating the former. Suggested-by: Andrew Cooper Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich --- Changes since v2: Style adjustments --- xen/arch/x86/hvm/hvm.c | 12 xen/arch/x86/hvm/mtrr.c | 52 -

[PATCH v5 05/10] x86: Replace EPT_EMT_* constants with X86_MT_*

2022-12-19 Thread Demi Marie Obenour
This allows eliminating the former. No functional change intended. Suggested-by: Andrew Cooper Signed-off-by: Demi Marie Obenour --- xen/arch/x86/include/asm/hvm/vmx/vmx.h | 9 - xen/arch/x86/mm/hap/nested_ept.c | 4 ++-- 2 files changed, 2 insertions(+), 11 deletions(-) diff

[PATCH v5 04/10] x86: Replace MTRR_* constants with X86_MT_* constants

2022-12-19 Thread Demi Marie Obenour
This allows eliminating of the former, with the exception of MTRR_NUM_TYPES. MTRR_NUM_TYPES is kept, as due to a quirk of the x86 architecture X86_MT_UCM (7) is not valid in an MTRR. Suggested-by: Andrew Cooper Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich --- Changes since v2:

[PATCH v5 02/10] x86/mm: Avoid hard-coding PAT in get_page_from_l1e()

2022-12-19 Thread Demi Marie Obenour
get_page_from_l1e() relied on Xen's choice of PAT, which is brittle in the face of future PAT changes. Instead, compute the actual cacheability used by the CPU and switch on that, as this will work no matter what PAT Xen uses. No functional change intended. This code is itself questionable and

[PATCH v5 01/10] x86: Add memory type constants

2022-12-19 Thread Demi Marie Obenour
These are not currently used, so there is no functional change. Future patches will use these constants. Suggested-by: Andrew Cooper Signed-off-by: Demi Marie Obenour Acked-by: Jan Beulich --- Changes since v4: - Add Jan Beulich’s Acked-by Changes since v3: - Name the reserved values

[PATCH v5 00/10] Make PAT handling less brittle

2022-12-19 Thread Demi Marie Obenour
While working on Qubes OS Marek found out that there were some PAT hacks in the Linux i195 driver. I decided to make Xen use Linux’s PAT to see if it solved the graphics glitches that were observed; it did. This required a substantial amount of preliminary work that is useful even without using

[qemu-mainline test] 175405: regressions - trouble: broken/fail/pass

2022-12-19 Thread osstest service owner
flight 175405 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175405/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken

[ovmf test] 175410: regressions - FAIL

2022-12-19 Thread osstest service owner
flight 175410 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175410/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 175202

[xen-unstable-smoke test] 175413: trouble: broken/pass

2022-12-19 Thread osstest service owner
flight 175413 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175413/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt broken

[xen-4.16-testing test] 175403: trouble: broken/fail/pass

2022-12-19 Thread osstest service owner
flight 175403 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/175403/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm broken

Re: [PATCH 1/6] disas: add G_GNUC_PRINTF to gstring_printf

2022-12-19 Thread Stefan Weil
Am 19.12.22 um 14:02 schrieb Daniel P. Berrangé: Signed-off-by: Daniel P. Berrangé --- disas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/disas.c b/disas.c index 94d3b45042..31df8f5b89 100644 --- a/disas.c +++ b/disas.c @@ -239,6 +239,7 @@ void target_disas(FILE *out, CPUState *cpu,

[xen-unstable-smoke test] 175409: tolerable all pass - PUSHED

2022-12-19 Thread osstest service owner
flight 175409 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175409/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: Virtio-disk updates for latest Xen ?

2022-12-19 Thread Oleksandr Tyshchenko
On 15.12.22 06:22, Viresh Kumar wrote: Hello Viresh On 14-12-22, 17:01, Oleksandr Tyshchenko wrote: Today I had a chance to check virtio-disk on my H/W using new Xen branch which does include Juergen's series with commit 3a96013a3e17 ("tools/xenstore: reduce number of watch events").

[xen-4.13-testing test] 175402: regressions - trouble: broken/fail/pass

2022-12-19 Thread osstest service owner
flight 175402 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/175402/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 broken test-amd64-amd64-xl-pvshim

Re: [RFC 0/7] Proposal to make x86 IOMMU driver support configurable

2022-12-19 Thread Andrew Cooper
On 19/12/2022 6:34 am, Xenia Ragiadakou wrote: > This series aims to provide a means to render the iommu driver support for x86 > configurable. Currently, irrespectively of the target platform, both AMD and > Intel iommu drivers are built. This is the case because the existent Kconfig >

Re: [PATCH v2 3/3] x86/ucode: load microcode earlier on boot CPU

2022-12-19 Thread Julien Grall
On 19/12/2022 17:33, Andrew Cooper wrote: On 19/12/2022 4:57 pm, Julien Grall wrote: Hi Sergey, On 19/12/2022 14:45, Sergey Dyasli wrote: Call early_microcode_init() straight after multiboot modules become accessible. Modify it to load the ucode directly from the blob bypassing populating

[linux-linus test] 175401: regressions - trouble: broken/fail/pass

2022-12-19 Thread osstest service owner
flight 175401 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175401/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-shadow broken

Re: [PATCH v2 3/3] x86/ucode: load microcode earlier on boot CPU

2022-12-19 Thread Andrew Cooper
On 19/12/2022 4:57 pm, Julien Grall wrote: > Hi Sergey, > > On 19/12/2022 14:45, Sergey Dyasli wrote: >> Call early_microcode_init() straight after multiboot modules become >> accessible. Modify it to load the ucode directly from the blob bypassing >> populating microcode_cache because xmalloc is

Re: [PATCH v2 3/3] x86/ucode: load microcode earlier on boot CPU

2022-12-19 Thread Julien Grall
Hi Sergey, On 19/12/2022 14:45, Sergey Dyasli wrote: Call early_microcode_init() straight after multiboot modules become accessible. Modify it to load the ucode directly from the blob bypassing populating microcode_cache because xmalloc is still not available at that point during Xen boot.

[ovmf test] 175404: regressions - FAIL

2022-12-19 Thread osstest service owner
flight 175404 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175404/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 175202

Patch "xen-netback: move removal of "hotplug-status" to the right place" has been added to the 5.4-stable tree

2022-12-19 Thread gregkh
This is a note to let you know that I've just added the patch titled xen-netback: move removal of "hotplug-status" to the right place to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the

Re: [PATCH 5.4] xen-netback: move removal of "hotplug-status" to the right place

2022-12-19 Thread Greg Kroah-Hartman
On Mon, Dec 19, 2022 at 04:37:10PM +0100, Pratyush Yadav wrote: > The removal of "hotplug-status" has moved around a bit. First it was > moved from netback_remove() to hotplug_status_changed() in upstream > commit 1f2565780e9b ("xen-netback: remove 'hotplug-status' once it has > served its

[PATCH 5.4] xen-netback: move removal of "hotplug-status" to the right place

2022-12-19 Thread Pratyush Yadav
The removal of "hotplug-status" has moved around a bit. First it was moved from netback_remove() to hotplug_status_changed() in upstream commit 1f2565780e9b ("xen-netback: remove 'hotplug-status' once it has served its purpose"). Then the change was reverted in upstream commit 0f4558ae9187

[xen-unstable-smoke test] 175406: tolerable all pass - PUSHED

2022-12-19 Thread osstest service owner
flight 175406 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175406/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Using 9P between domains

2022-12-19 Thread tristan . israel
Good morning, I’m trying to configure 2 domains : « front » and « back ». The « back » contains a filesystem which I want to partially share with the « front ». The « front » and « back » are PV under Debian 11. I am using the following configuration in the front : p9 = [

Re: [PATCH RFC 10/10] common: convert vCPU info area registration

2022-12-19 Thread Jan Beulich
On 17.12.2022 16:53, Julien Grall wrote: > On 19/10/2022 08:45, Jan Beulich wrote: >> Switch to using map_guest_area(). Noteworthy differences from >> map_vcpu_info(): >> - remote vCPU-s are paused rather than checked for being down (which in >>principle can change right after the check), >> -

[PATCH v2 2/3] x86/ucode: allow cpu_request_microcode() to skip memory allocation

2022-12-19 Thread Sergey Dyasli
This is a preparatory step in order to do earlier microcode loading on the boot CPU when the domain heap has not been initialized yet and xmalloc still unavailable. Add make_copy argument which will allow to load microcode directly from the blob bypassing microcode_cache. Signed-off-by: Sergey

[PATCH v2 0/3] x86: load microcode earlier on boot CPU

2022-12-19 Thread Sergey Dyasli
The second version of patches. Changelog is available in each patch. Sergey Dyasli (3): xen/multiboot: add proper struct definitions to typedefs x86/ucode: allow cpu_request_microcode() to skip memory allocation x86/ucode: load microcode earlier on boot CPU

[PATCH v2 3/3] x86/ucode: load microcode earlier on boot CPU

2022-12-19 Thread Sergey Dyasli
Call early_microcode_init() straight after multiboot modules become accessible. Modify it to load the ucode directly from the blob bypassing populating microcode_cache because xmalloc is still not available at that point during Xen boot. Introduce early_microcode_init_cache() for populating

[PATCH v2 1/3] xen/multiboot: add proper struct definitions to typedefs

2022-12-19 Thread Sergey Dyasli
This allows to use them for forward declaration in other headers. Signed-off-by: Sergey Dyasli --- CC: George Dunlap CC: Julien Grall CC: Stefano Stabellini v1 --> v2: - New patch --- xen/include/xen/multiboot.h | 25 +++-- 1 file changed, 15 insertions(+), 10

Re: [PATCH 4/6] util/error: add G_GNUC_PRINTF for various functions

2022-12-19 Thread Philippe Mathieu-Daudé
On 19/12/22 14:02, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- util/error-report.c | 1 + util/error.c| 1 + 2 files changed, 2 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/6] hw/xen: use G_GNUC_PRINTF/SCANF for various functions

2022-12-19 Thread Anthony PERARD
On Mon, Dec 19, 2022 at 08:02:01AM -0500, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé Acked-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: MISRA C Rule 20.7 disambiguation

2022-12-19 Thread Roberto Bagnara
On 2022-12-09 23:46, Stefano Stabellini wrote: Eclair marks it as a violation too. Eclair thinks "nr" needs parenthesis. Roberto, we have already discussed how the comma operator "," being the lower precedence doesn't require extra parenthesis. Roberto, what's your take on the [] square brakets?

Re: [PATCH v4 03/11] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-12-19 Thread Edwin Torok
> On 19 Dec 2022, at 11:52, Anthony PERARD wrote: > > On Fri, Dec 16, 2022 at 06:25:12PM +, Edwin Török wrote: >> + git ls-files '*.c' '*.h' | xargs -n1 sed -ie 's/\t//g' > > Seen as there's a patch adding .clang-format, what the point of this > command? The diff to change tabs to

Re: [QEMU][PATCH v2 10/11] hw/arm: introduce xenpv machine

2022-12-19 Thread Alex Bennée
Julien Grall writes: > Hi, > > On 02/12/2022 22:36, Stefano Stabellini wrote: >>> Do you know what Xen version your build env has? >> I think Alex is just building against upstream Xen. GUEST_TPM_BASE >> is >> not defined there yet. I think we would need to introduce in >> xen_common.h

Re: [PATCH v4 06/11] tools/ocaml: add .clang-format

2022-12-19 Thread Edwin Torok
> On 19 Dec 2022, at 12:03, Anthony PERARD wrote: > > On Fri, Dec 16, 2022 at 06:25:15PM +, Edwin Török wrote: >> Add a .clang-format configuration that tries to match CODING_STYLE where >> possible. > > Is there going to be a patch applying this to "tools/ocaml", like you > did with

[PATCH 5/6] tests: add G_GNUC_PRINTF for various functions

2022-12-19 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- tests/qtest/ahci-test.c | 3 +++ tests/qtest/arm-cpu-features.c| 1 + tests/qtest/erst-test.c | 2 +- tests/qtest/ide-test.c| 3 ++- tests/qtest/ivshmem-test.c| 4 ++-- tests/qtest/libqmp.c | 2

[PATCH 3/6] tools/virtiofsd: add G_GNUC_PRINTF for logging functions

2022-12-19 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- tools/virtiofsd/fuse_log.c | 1 + tools/virtiofsd/fuse_log.h | 6 -- tools/virtiofsd/passthrough_ll.c | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/virtiofsd/fuse_log.c b/tools/virtiofsd/fuse_log.c index

[PATCH 6/6] enforce use of G_GNUC_PRINTF attributes

2022-12-19 Thread Daniel P . Berrangé
We've been very gradually adding G_GNUC_PRINTF annotations to functions over years. This has been useful in detecting certain malformed printf strings, or cases where we pass user data as the printf format which is a potential security flaw. Given the inherant memory corruption danger in use of

[PATCH 1/6] disas: add G_GNUC_PRINTF to gstring_printf

2022-12-19 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- disas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/disas.c b/disas.c index 94d3b45042..31df8f5b89 100644 --- a/disas.c +++ b/disas.c @@ -239,6 +239,7 @@ void target_disas(FILE *out, CPUState *cpu, target_ulong code, } } +G_GNUC_PRINTF(2, 3)

[PATCH 4/6] util/error: add G_GNUC_PRINTF for various functions

2022-12-19 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- util/error-report.c | 1 + util/error.c| 1 + 2 files changed, 2 insertions(+) diff --git a/util/error-report.c b/util/error-report.c index 5edb2e6040..6e44a55732 100644 --- a/util/error-report.c +++ b/util/error-report.c @@ -193,6 +193,7 @@

[PATCH 0/6] enforce use of G_GNUC_PRINTF annotations

2022-12-19 Thread Daniel P . Berrangé
We've been very gradually adding G_GNUC_PRINTF annotations to functions over years. This has been useful in detecting certain malformed printf strings, or cases where we pass user data as the printf format which is a potential security flaw. Given the inherant memory corruption danger in use of

[PATCH 2/6] hw/xen: use G_GNUC_PRINTF/SCANF for various functions

2022-12-19 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- hw/xen/xen-bus.c| 1 + hw/xen/xen_pvdev.c | 1 + include/hw/xen/xen-bus-helper.h | 6 -- include/hw/xen/xen-bus.h| 3 ++- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/xen/xen-bus.c

Re: [PATCH RFC 04/10] domain: update GADDR based runstate guest area

2022-12-19 Thread Jan Beulich
On 16.12.2022 13:26, Julien Grall wrote: > On 19/10/2022 08:41, Jan Beulich wrote: >> Before adding a new vCPU operation to register the runstate area by >> guest-physical address, add code to actually keep such areas up-to-date. >> >> Signed-off-by: Jan Beulich >> --- >> RFC: Pages aren't marked

Re: [PATCH v4 06/11] tools/ocaml: add .clang-format

2022-12-19 Thread Anthony PERARD
On Fri, Dec 16, 2022 at 06:25:15PM +, Edwin Török wrote: > Add a .clang-format configuration that tries to match CODING_STYLE where > possible. Is there going to be a patch applying this to "tools/ocaml", like you did with "make format"? > I was not able to express the special casing of

Re: [PATCH v4 03/11] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-12-19 Thread Anthony PERARD
On Fri, Dec 16, 2022 at 06:25:12PM +, Edwin Török wrote: > + git ls-files '*.c' '*.h' | xargs -n1 sed -ie 's/\t//g' Seen as there's a patch adding .clang-format, what the point of this command? "-ie" means to ask sed to change file in-place an keep a copy of the original file with

Re: [PATCH v4 00/11] OCaml fixes

2022-12-19 Thread Christian Lindig
> On 16 Dec 2022, at 18:25, Edwin Török wrote: > > From: Edwin Török > > Various OCaml fixes, some of which got Acked already. > > Edwin Török (11): > tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper > tools/ocaml/xenstored/Makefile: use ocamldep -sort for linking order >

Re: [PATCH v2] NUMA: replace phys_to_nid()

2022-12-19 Thread Julien Grall
On 19/12/2022 10:19, Jan Beulich wrote: All callers convert frame numbers (perhaps in turn derived from struct page_info pointers) to an address, just for the function to convert it back to a frame number (as the first step of paddr_to_pdx()). Replace the function by mfn_to_nid() plus a

[PATCH v2] NUMA: replace phys_to_nid()

2022-12-19 Thread Jan Beulich
All callers convert frame numbers (perhaps in turn derived from struct page_info pointers) to an address, just for the function to convert it back to a frame number (as the first step of paddr_to_pdx()). Replace the function by mfn_to_nid() plus a page_to_nid() wrapper macro. Replace call sites by

Re: [PATCH v4 10/11] tools/ocaml/xenstored: validate config file before live update

2022-12-19 Thread Edwin Torok
> On 19 Dec 2022, at 09:37, Christian Lindig > wrote: > > > >> On 16 Dec 2022, at 18:25, Edwin Török wrote: >> >> The configuration file can contain typos or various errors that could prevent >> live update from succeeding (e.g. a flag only valid on a different version). >> Unknown

Re: [PATCH v4 01/11] tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper

2022-12-19 Thread Edwin Torok
> On 16 Dec 2022, at 22:40, Andrew Cooper wrote: > > On 16/12/2022 6:25 pm, Edwin Török wrote: >> diff --git a/tools/ocaml/libs/mmap/mmap_stubs.h >> b/tools/ocaml/libs/mmap/mmap_stubs.h >> index 65e4239890..66f18d4406 100644 >> --- a/tools/ocaml/libs/mmap/mmap_stubs.h >> +++

Re: [PATCH v4 05/11] CODING-STYLE(tools/ocaml): add .editorconfig to clarify indentation uses spaces

2022-12-19 Thread Christian Lindig
> On 16 Dec 2022, at 18:25, Edwin Török wrote: > > Add an .editorconfig to make it easier to keep patches compatible with > Xen's coding style, and to reemphasize what Xen's coding style is. > > I thought that Xen demands tabs rather than spaces (which is more > difficult with OCaml because

Re: [PATCH v4 03/11] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-12-19 Thread Christian Lindig
> On 16 Dec 2022, at 18:25, Edwin Török wrote: > > See CODING_STYLE: Xen uses spaces, not tabs. > > * OCaml code: > > Using `ocp-indent` for now to just make minimal modifications in > tabs vs spaces and get the right indentation. > We can introduce `ocamlformat` later. > > * C stubs: > >

Re: [PATCH v4 10/11] tools/ocaml/xenstored: validate config file before live update

2022-12-19 Thread Christian Lindig
> On 16 Dec 2022, at 18:25, Edwin Török wrote: > > The configuration file can contain typos or various errors that could prevent > live update from succeeding (e.g. a flag only valid on a different version). > Unknown entries in the config file would be ignored on startup normally, > add a

[PATCH v2] xen/arm: Allow to set grant table related limits for dom0less domUs

2022-12-19 Thread Michal Orzel
At the moment, for dom0less domUs, we do not have a way to specify per domain grant table related limits (unlike when using xl), namely max version, max number of grant frames, max number of maptrack frames. This means that such domains always use the values specified by the Xen command line

Re: [PATCH v2] Bug fix - Integer overflow when cpu frequency > u32 max value.

2022-12-19 Thread Neowutran
On 2022-12-19 09:12, Jan Beulich wrote: > On 18.12.2022 22:47, Elliott Mitchell wrote: > > On Sun, Dec 18, 2022 at 01:14:07PM +0100, Neowutran wrote: > >> xen/x86: prevent overflow with high frequency TSCs > >> > >> Pr omote tsc_khz to a 64-bit type before multiplying by 1000 to avoid a > >>

[ovmf test] 175400: regressions - FAIL

2022-12-19 Thread osstest service owner
flight 175400 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175400/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 175202

[xen-unstable test] 175399: tolerable FAIL

2022-12-19 Thread osstest service owner
flight 175399 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175399/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 175383 test-amd64-i386-xl-qemuu-win7-amd64

Re: [PATCH v2] Bug fix - Integer overflow when cpu frequency > u32 max value.

2022-12-19 Thread Jan Beulich
On 18.12.2022 22:47, Elliott Mitchell wrote: > On Sun, Dec 18, 2022 at 01:14:07PM +0100, Neowutran wrote: >> xen/x86: prevent overflow with high frequency TSCs >> >> Promote tsc_khz to a 64-bit type before multiplying by 1000 to avoid a >> 'overflow before widen' bug. >> Otherwise just above