Re: [PATCH 1/4] Rip out simple_strtoll()

Hi Demi, kernel test robot noticed the following build errors: [auto build test ERROR on lee-mfd/for-mfd-next] [also build test ERROR on lee-leds/for-leds-next linus/master v6.4-rc5 next-20230609] [cannot apply to xen-tip/linux-next lee-mfd/for-mfd-fixes] [If your patch is applied to the wrong

Re: [PATCH 1/4] Rip out simple_strtoll()

Hi Demi, kernel test robot noticed the following build errors: [auto build test ERROR on lee-mfd/for-mfd-next] [also build test ERROR on lee-leds/for-leds-next linus/master v6.4-rc5 next-20230609] [cannot apply to xen-tip/linux-next lee-mfd/for-mfd-fixes] [If your patch is applied to the wrong

[linux-linus test] 181337: regressions - FAIL

flight 181337 linux-linus real [real] flight 181357 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181337/ http://logs.test-lab.xenproject.org/osstest/logs/181357/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH 4/4] Strict XenStore entry parsing

On Fri, Jun 09, 2023 at 10:57:59PM -0400, Demi Marie Obenour wrote: > This uses the newly-introduced strict version of sscanf(). I can see that. Why does it do that? Documentation/process/5.Posting.rst (in general, there is a lack of detail across all four of these patches justifying why any

[qemu-mainline test] 181345: regressions - FAIL

flight 181345 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181345/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 180691 build-arm64

[PATCH 3/4] Add strict version of vsscanf()

Signed-off-by: Demi Marie Obenour --- include/linux/kernel.h | 4 lib/vsprintf.c | 43 +++--- 2 files changed, 44 insertions(+), 3 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index

[PATCH 4/4] Strict XenStore entry parsing

This uses the newly-introduced strict version of sscanf(). Signed-off-by: Demi Marie Obenour --- drivers/xen/xenbus/xenbus_xs.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c index

[PATCH 1/4] Rip out simple_strtoll()

It is not used anywhere but its own unit tests. Signed-off-by: Demi Marie Obenour --- Documentation/dev-tools/checkpatch.rst | 9 - Documentation/process/deprecated.rst | 5 ++--- .../translations/it_IT/process/deprecated.rst | 9 -

[PATCH 2/4] vsscanf(): Return -ERANGE on integer overflow

Userspace sets errno to ERANGE, but the kernel can't do that. Signed-off-by: Demi Marie Obenour --- include/linux/limits.h | 1 + include/linux/mfd/wl1273-core.h | 3 -- include/vdso/limits.h | 3 ++ lib/vsprintf.c | 80 - 4

[linux-5.4 test] 181336: regressions - FAIL

flight 181336 linux-5.4 real [real] flight 181353 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181336/ http://logs.test-lab.xenproject.org/osstest/logs/181353/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run:

Re: Asking for help to debug xen efi on Kunpeng machine

Hello Julien, Thank you very much for your help! Best, Jiatong Shen On Fri, Jun 9, 2023 at 4:48 PM Julien Grall wrote: > Hello, > > On 09/06/2023 03:32, Jiatong Shen wrote: > > Thank you for your answer. Can you teach me how to verify if acpi is > > enabled? > > You usually look at the

[xen-unstable-smoke test] 181349: tolerable all pass - PUSHED

flight 181349 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181349/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[xen-unstable-smoke test] 181347: regressions - FAIL

flight 181347 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181347/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

Re: [PATCH v3 00/16] tools/xenstore: more cleanups

Hi Juergen, On 30/05/2023 09:54, Juergen Gross wrote: Some more cleanups of Xenstore. Based on top of the previous Xenstore series "tools/xenstore: rework internal accounting". Changes in V2: - rebase - one small modification of patch 10 - added patches 11-13 Changes in V3: - rebase -

Re: [PATCH v3 11/16] tools/libs/store: make libxenstore independent of utils.h

Hi Juergen, On 30/05/2023 09:54, Juergen Gross wrote: There is no real need for including tools/xenstore/utils.h from libxenstore, as only streq() and ARRAY_SIZE() are obtained via that header. streq() is just !strcmp(), and ARRAY_SIZE() is brought in via xen-tools/common-macros.h.

Re: [PATCH v3 10/16] tools/libs/store: use xen_list.h instead of xenstore/list.h

Hi Juergen, On 30/05/2023 09:54, Juergen Gross wrote: Replace the usage of the xenstore private list.h header with the common xen_list.h one. Signed-off-by: Juergen Gross --- V3: - new patch --- tools/libs/store/xs.c | 56 +-- 1 file changed, 28

Re: [PATCH v3 09/16] tools/xenstore: remove support of file backed data base

Hi Juergen, On 30/05/2023 09:54, Juergen Gross wrote: In order to prepare the replacement of TDB with direct accessible nodes in memory, remove the support for a file backed data base. This allows to remove xs_tdb_dump, too. Signed-off-by: Juergen Gross Acked-by: Julien Grall Cheers, --

Re: [PATCH v3 06/16] tools/xenstore: switch write limiting to use millisecond time base

Hi Juergen, On 30/05/2023 09:54, Juergen Gross wrote: There is no need to keep struct wrl_timestampt, as it serves the same purpose as the more simple time base provided by get_now(). Move some more stuff from xenstored_domain.h into xenstored_domain.c as it is being used nowhere else.

Re: [PATCH v3 05/16] tools/xenstore: make some write limit functions static

Hi Juergen, On 30/05/2023 09:54, Juergen Gross wrote: Some wrl_*() functions are only used in xenstored_domain.c, so make them static. In order to avoid the need of forward declarations, move the whole function block to the start of the file. Signed-off-by: Juergen Gross Acked-by: Julien

Re: [PATCH v3 04/16] tools/xenstore: rename hashtable_insert() and let it return 0 on success

Hi Juergen, On 30/05/2023 09:54, Juergen Gross wrote: Today hashtable_insert() returns 0 in case of an error. Change that to let it return an errno value in the error case and 0 in case of success. In order to avoid any missed return value checks or related future backport errors, rename

Re: [PATCH v3 03/16] tools/xenstore: modify interface of create_hashtable()

Hi Juergen, On 30/05/2023 09:54, Juergen Gross wrote: The minsize parameter of create_hashtable() doesn't have any real use case for Xenstore, so drop it. For better talloc_report_full() diagnostic output add a name parameter to create_hashtable(). Signed-off-by: Juergen Gross Reviewed-by:

[PATCH v2] docs/misra: new rules addition

From: Stefano Stabellini For Dir 1.1, a document describing all implementation-defined behaviour (i.e. gcc-specific behavior) will be added to docs/misra, also including implementation-specific (gcc-specific) appropriate types for bit-field relevant to Rule 6.1. Rule 21.21 is lacking an example

Re: [PATCH] docs/misra: new rules addition

On Fri, 9 Jun 2023, Jan Beulich wrote: > On 08.06.2023 13:02, Roberto Bagnara wrote: > > On 07/06/23 23:53, Stefano Stabellini wrote: > >> On Wed, 7 Jun 2023, Jan Beulich wrote: > + * - `Rule 5.6 > `_

Re: [PATCH] CI: Add Ocaml to the alpine containers

On Fri, 9 Jun 2023, Michal Orzel wrote: > On 09/06/2023 18:02, Andrew Cooper wrote: > > > > > > This gets more coverage of optional parts of the build, and makes it easier > > to > > trial Ocaml related changes in the smoke tests. > > > > Signed-off-by: Andrew Cooper > > --- > > CC: Roger Pau

[xen-unstable-smoke test] 181344: regressions - FAIL

flight 181344 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181344/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

On Fri, Jun 09, 2023 at 05:13:45PM +0200, Roger Pau Monné wrote: > On Thu, Jun 08, 2023 at 11:33:26AM -0400, Demi Marie Obenour wrote: > > On Thu, Jun 08, 2023 at 10:29:18AM +0200, Roger Pau Monné wrote: > > > On Wed, Jun 07, 2023 at 12:14:46PM -0400, Demi Marie Obenour wrote: > > > > On Wed, Jun

Re: [PATCH] CI: Add Ocaml to the alpine containers

On 09/06/2023 5:21 pm, Michal Orzel wrote: > On 09/06/2023 18:02, Andrew Cooper wrote: >> This gets more coverage of optional parts of the build, and makes it easier >> to >> trial Ocaml related changes in the smoke tests. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Roger Pau Monné >> CC:

Re: [PATCH] CI: Add Ocaml to the alpine containers

On 09/06/2023 18:02, Andrew Cooper wrote: > > > This gets more coverage of optional parts of the build, and makes it easier to > trial Ocaml related changes in the smoke tests. > > Signed-off-by: Andrew Cooper > --- > CC: Roger Pau Monné > CC: Stefano Stabellini > CC: Michal Orzel > CC:

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

On Fri Jun 9, 2023 at 11:07 AM CDT, Julien Grall wrote: > Thanks for the explanations. To clarify, are you saying that all the > files will be GPLv2+ or just some? My idea was to license any file where I expect there to derivations from existing code as GPLv2+, and fall back to GPLv2-only for

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

Hi Shawn, On 09/06/2023 16:01, Shawn Anastasio wrote: On Fri Jun 9, 2023 at 5:12 AM CDT, Julien Grall wrote: Strictly speaking we can refuse any code. That count for license as well. Anyway, I didn't request a change here. I merely pointed out that any use of GPLv2+ should be justified because

[PATCH] CI: Add Ocaml to the alpine containers

This gets more coverage of optional parts of the build, and makes it easier to trial Ocaml related changes in the smoke tests. Signed-off-by: Andrew Cooper --- CC: Roger Pau Monné CC: Stefano Stabellini CC: Michal Orzel CC: Anthony PERARD Hacked up manually to fix the Ocaml bindings for

[qemu-mainline test] 181335: regressions - FAIL

flight 181335 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181335/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 180691 build-arm64

Re: [PATCH 3/3] maintainers: Add PPC64 maintainer

On Fri Jun 9, 2023 at 4:04 AM CDT, Jan Beulich wrote: > On 07.06.2023 17:06, Shawn Anastasio wrote: > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -451,6 +451,9 @@ M: Wei Liu > > S: Supported > > T: git https://xenbits.xenproject.org/git-http/ovmf.git > > > > +PPC64 > > +M: Shawn

Re: [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling

On 07.06.23 15:12, Christoph Hellwig wrote: On Mon, May 22, 2023 at 10:37:09AM +0200, Juergen Gross wrote: In normal cases PCI passthrough in PV guests requires to start the guest with e820_host=1. So it should be rather easy to limit allocating the 64MB in PV guests to the cases where the

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

On Fri Jun 9, 2023 at 4:22 AM CDT, Jan Beulich wrote: > > xen/arch/ppc/Kconfig.debug | 5 + > > xen/arch/ppc/Makefile| 3 +- > > xen/arch/ppc/boot_of.c | 122 +++ > > xen/arch/ppc/configs/openpower_defconfig | 1 + > >

Re: [PATCH 1/3] xen: Add files needed for minimal Power build

On Fri Jun 9, 2023 at 4:15 AM CDT, Jan Beulich wrote: > > --- /dev/null > > +++ b/config/ppc64.mk > > @@ -0,0 +1,5 @@ > > +CONFIG_PPC64 := y > > +CONFIG_PPC64_64 := y > > +CONFIG_PPC64_$(XEN_OS) := y > > The first of the 64-s here are a little odd; looking at RISC-V's > counterpart, wouldn't this

[PATCH v2] tools/ocaml/xc: Fix xc_physinfo() bindings

The original change doesn't compile on ARM: xenctrl_stubs.c: In function 'stub_xc_physinfo': xenctrl_stubs.c:821:16: error: unused variable 'arch_cap_flags_tag' [-Werror=unused-variable] 821 | int r, arch_cap_flags_tag; |^~ cc1: all

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

On 6/9/23 08:22, Konrad Rzeszutek Wilk wrote: > Dave, are you OK with the change in where the reserve call is made? The move makes logical sense. I'm not 100% confident it won't regress anything, but the blast radius should be limited to iSCSI. But, yeah, I'm OK with it.

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

On 09.06.23 17:27, Konrad Rzeszutek Wilk wrote: Usually I put it in my tree (ibft) but since it is so simple and the user is Xen it would make more sense to do it via the Xen tree (Juergen). Works for me. Juergen Thx On Fri, Jun 9, 2023, 11:16 AM Dave Hansen

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

Usually I put it in my tree (ibft) but since it is so simple and the user is Xen it would make more sense to do it via the Xen tree (Juergen). Thx On Fri, Jun 9, 2023, 11:16 AM Dave Hansen wrote: > On 6/5/23 03:28, Ross Lagerwall wrote: > > The result of these changes is that it is possible to

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

Feel free to add my Acked-by. Dave, are you OK with the change in where the reserve call is made? Thx On Fri, Jun 9, 2023, 11:08 AM Juergen Gross wrote: > On 05.06.23 12:28, Ross Lagerwall wrote: > > To facilitate diskless iSCSI boot, the firmware can place a table of > > configuration

[xen-unstable-smoke test] 181342: regressions - FAIL

flight 181342 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181342/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

On 6/5/23 03:28, Ross Lagerwall wrote: > The result of these changes is that it is possible to boot a diskless > Xen + Dom0 running off an iSCSI disk whereas previously it would fail to > find the iBFT and consequently, the iSCSI root disk. Acked-by: Dave Hansen # for x86 The work in this patch

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

On Thu, Jun 08, 2023 at 11:33:26AM -0400, Demi Marie Obenour wrote: > On Thu, Jun 08, 2023 at 10:29:18AM +0200, Roger Pau Monné wrote: > > On Wed, Jun 07, 2023 at 12:14:46PM -0400, Demi Marie Obenour wrote: > > > On Wed, Jun 07, 2023 at 10:20:08AM +0200, Roger Pau Monné wrote: > > > > On Tue, Jun

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

On 05.06.23 12:28, Ross Lagerwall wrote: To facilitate diskless iSCSI boot, the firmware can place a table of configuration details in memory called the iBFT. The presence of this table is not specified, nor is the precise location (and it's not in the E820) so the kernel has to search for a

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

On Fri Jun 9, 2023 at 5:12 AM CDT, Julien Grall wrote: > Strictly speaking we can refuse any code. That count for license as > well. Anyway, I didn't request a change here. I merely pointed out that > any use of GPLv2+ should be justified because on Arm most of the people > don't pay attention

[libvirt test] 181328: tolerable all pass - PUSHED

flight 181328 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/181328/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 181293 test-armhf-armhf-libvirt-qcow2 15

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

> From: Xen-devel on behalf of Konrad > Rzeszutek Wilk > Sent: Thursday, June 8, 2023 5:38 PM > To: Ross Lagerwall > Cc: linux-ker...@vger.kernel.org ; > xen-devel@lists.xenproject.org ; Jan Beulich > ; Thomas Gleixner ; Ingo Molnar > ; Borislav Petkov ; Dave Hansen > ; x...@kernel.org ;

Re: Xen reliance on non-standard GCC features

Hi, > On 9 Jun 2023, at 15:19, Julien Grall wrote: > > Hi Jan, > > On 09/06/2023 09:54, Jan Beulich wrote: >> On 08.06.2023 14:18, Roberto Bagnara wrote: >>> On 07/06/23 09:39, Jan Beulich wrote: On 05.06.2023 15:26, Roberto Bagnara wrote: > On 05/06/23 11:28, Jan Beulich wrote:

Re: RHEL 8.8 and derivatives: suspend and live migration issue

On Fri, Jun 09, 2023 at 04:07:54PM +0200, David Morel wrote: > Hello, > > This mail is meant to be more of a summary plus a heads up, I don't think > there is any action needed on it. > > A user reported [1] a crash when live migrating a VM running Rocky Linux > 8.8. After investigation it

RHEL 8.8 and derivatives: suspend and live migration issue

Hello, This mail is meant to be more of a summary plus a heads up, I don't think there is any action needed on it. A user reported [1] a crash when live migrating a VM running Rocky Linux 8.8. After investigation it appears to be happening: - for RHEL derivatives when migrating from 8.7 to 8.8.

Re: Xen reliance on non-standard GCC features

Hi Jan, On 09/06/2023 09:54, Jan Beulich wrote: On 08.06.2023 14:18, Roberto Bagnara wrote: On 07/06/23 09:39, Jan Beulich wrote: On 05.06.2023 15:26, Roberto Bagnara wrote: On 05/06/23 11:28, Jan Beulich wrote: On 05.06.2023 07:28, Roberto Bagnara wrote: You are right: here are a few

[xen-unstable-smoke test] 181340: regressions - FAIL

flight 181340 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181340/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

[PATCH] xen/arm: rename guest_cpuinfo in domain_cpuinfo

Rename the guest_cpuinfo structure to domain_cpuinfo as it is not only used for guests but also for dom0 so domain is a more suitable name. While there also rename the create_guest_cpuinfo function to create_domain_cpuinfo to be coherent. Signed-off-by: Bertrand Marquis ---

Re: [PATCH] tools: Move MASK_INSR to common-macros.h

On Fri, Jun 9, 2023 at 6:11 AM Andrew Cooper wrote: > > MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. > > Drop the pair from x86-emulate.h which includes common-macros.h. > > Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for Arm") > Signed-off-by:

[xen-unstable test] 181325: trouble: broken/fail/pass

flight 181325 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181325/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-qcow2 broken Tests which are

Re: Xen reliance on non-standard GCC features

On 09.06.2023 12:12, Michal Orzel wrote: > > > On 09/06/2023 11:47, Jan Beulich wrote: >> >> >> On 09.06.2023 11:36, Michal Orzel wrote: >>> On 09/06/2023 10:54, Jan Beulich wrote: On 08.06.2023 14:18, Roberto Bagnara wrote: > On 07/06/23 09:39, Jan Beulich wrote: >> On 05.06.2023

[xen-unstable-smoke test] 181338: regressions - FAIL

flight 181338 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181338/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

Re: [PATCH] tools: Move MASK_INSR to common-macros.h

On Fri, Jun 09, 2023 at 11:11:05AM +0100, Andrew Cooper wrote: > MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. > > Drop the pair from x86-emulate.h which includes common-macros.h. > > Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for Arm") >

Re: [PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE

On Thu, Jun 08, 2023 at 03:43:32PM -0700, Stefano Stabellini wrote: > On Mon, 5 Jun 2023, Bernhard Beschow wrote: > > Am 22. Mai 2023 15:42:03 UTC schrieb Bernhard Beschow : > > > > > > > > >Am 15. Mai 2023 20:52:40 UTC schrieb Stefano Stabellini > > >: > > >>On Sat, 13 May 2023, Bernhard Beschow

Re: [PATCH v2] tools: Move MASK_INSR to common-macros.h

On 09/06/2023 11:22 am, Luca Fancellu wrote: > >> On 9 Jun 2023, at 11:11, Andrew Cooper wrote: >> >> MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. >> >> Drop the pair from x86-emulate.h which includes common-macros.h. >> >> Fixes: 56a7aaa16bfe ("tools: add physinfo

Re: [PATCH] tools: Move MASK_INSR to common-macros.h

> On 9 Jun 2023, at 11:11, Andrew Cooper wrote: > > MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. > > Drop the pair from x86-emulate.h which includes common-macros.h. > > Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for Arm") > Signed-off-by:

Re: [PATCH v2] tools: Move MASK_INSR to common-macros.h

Urgh, well I'm failing at email today.  This is v2.  Everything else in the patch is as intended. ~Andrew On 09/06/2023 11:11 am, Andrew Cooper wrote: > MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. > > Drop the pair from x86-emulate.h which includes common-macros.h. > >

Re: Xen reliance on non-standard GCC features

On 09/06/2023 11:47, Jan Beulich wrote: > > > On 09.06.2023 11:36, Michal Orzel wrote: >> On 09/06/2023 10:54, Jan Beulich wrote: >>> On 08.06.2023 14:18, Roberto Bagnara wrote: On 07/06/23 09:39, Jan Beulich wrote: > On 05.06.2023 15:26, Roberto Bagnara wrote: >> On 05/06/23

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

Hi Andrew, On 09/06/2023 10:54, Andrew Cooper wrote: On 09/06/2023 10:46 am, Julien Grall wrote: On 09/06/2023 10:43, Andrew Cooper wrote: On 09/06/2023 10:38 am, Jan Beulich wrote: On 09.06.2023 11:29, Andrew Cooper wrote: On 09/06/2023 10:22 am, Jan Beulich wrote: --- /dev/null +++

[PATCH] tools: Move MASK_INSR to common-macros.h

MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. Drop the pair from x86-emulate.h which includes common-macros.h. Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for Arm") Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Juergen Gross CC: Luca

Re: [PATCH] tools: Move MASK_INSR to common-macros.h

> On 9 Jun 2023, at 11:06, Andrew Cooper wrote: > > On 08/06/2023 8:37 pm, Luca Fancellu wrote: >>> On 8 Jun 2023, at 18:40, Andrew Cooper wrote: >>> >>> MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. >>> >>> Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities

Re: [PATCH] tools: Move MASK_INSR to common-macros.h

On 09/06/2023 10:33 am, Andrew Cooper wrote: > On 09/06/2023 10:31 am, Jan Beulich wrote: >> On 08.06.2023 19:40, Andrew Cooper wrote: >>> MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. >> Right, that's one thing which should have been done right away. >> The other is that

Re: [PATCH] tools: Move MASK_INSR to common-macros.h

On 08/06/2023 8:37 pm, Luca Fancellu wrote: >> On 8 Jun 2023, at 18:40, Andrew Cooper wrote: >> >> MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. >> >> Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for >> Arm") > I don’t think this patch is fixing a

Re: [PATCH] tools/ocaml/xc: Fix xc_physinfo() bindings

> On 9 Jun 2023, at 10:37, Andrew Cooper wrote: > > On 09/06/2023 9:17 am, Christian Lindig wrote: >>> On 8 Jun 2023, at 20:33, Andrew Cooper wrote: >>> >>> +type arm_physinfo_caps = >>> + { >>> +sve_vl: int; >>> + } >>> + >> >> Does the OCaml side need to know about the structure of

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

On 09/06/2023 10:46 am, Julien Grall wrote: > On 09/06/2023 10:43, Andrew Cooper wrote: >> On 09/06/2023 10:38 am, Jan Beulich wrote: >>> On 09.06.2023 11:29, Andrew Cooper wrote: On 09/06/2023 10:22 am, Jan Beulich wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/boot_of.c >> @@

Re: Xen reliance on non-standard GCC features

On 09.06.2023 11:36, Michal Orzel wrote: > On 09/06/2023 10:54, Jan Beulich wrote: >> On 08.06.2023 14:18, Roberto Bagnara wrote: >>> On 07/06/23 09:39, Jan Beulich wrote: On 05.06.2023 15:26, Roberto Bagnara wrote: > On 05/06/23 11:28, Jan Beulich wrote: >> On 05.06.2023 07:28,

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

Hi Andrew, On 09/06/2023 10:43, Andrew Cooper wrote: On 09/06/2023 10:38 am, Jan Beulich wrote: On 09.06.2023 11:29, Andrew Cooper wrote: On 09/06/2023 10:22 am, Jan Beulich wrote: --- /dev/null +++ b/xen/arch/ppc/boot_of.c @@ -0,0 +1,122 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

On 09/06/2023 10:38 am, Jan Beulich wrote: > On 09.06.2023 11:29, Andrew Cooper wrote: >> On 09/06/2023 10:22 am, Jan Beulich wrote: --- /dev/null +++ b/xen/arch/ppc/boot_of.c @@ -0,0 +1,122 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ >>> By default we mean to use ...

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

Hi, On 09/06/2023 10:38, Jan Beulich wrote: On 09.06.2023 11:29, Andrew Cooper wrote: On 09/06/2023 10:22 am, Jan Beulich wrote: --- /dev/null +++ b/xen/arch/ppc/boot_of.c @@ -0,0 +1,122 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ By default we mean to use ... --- /dev/null +++

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

On 09.06.2023 11:29, Andrew Cooper wrote: > On 09/06/2023 10:22 am, Jan Beulich wrote: >>> --- /dev/null >>> +++ b/xen/arch/ppc/boot_of.c >>> @@ -0,0 +1,122 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> By default we mean to use ... >> >>> --- /dev/null >>> +++

Re: [PATCH] tools/ocaml/xc: Fix xc_physinfo() bindings

On 09/06/2023 9:17 am, Christian Lindig wrote: >> On 8 Jun 2023, at 20:33, Andrew Cooper wrote: >> >> +type arm_physinfo_caps = >> + { >> +sve_vl: int; >> + } >> + > > Does the OCaml side need to know about the structure of this value or is it > enough to pass it around as an abstract

Re: [PATCH] tools: Move MASK_INSR to common-macros.h

> On 9 Jun 2023, at 10:31, Jan Beulich wrote: > > On 08.06.2023 19:40, Andrew Cooper wrote: >> MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. > > Right, that's one thing which should have been done right away. > The other is that both macros should have been purged from

Re: Xen reliance on non-standard GCC features

On 09/06/2023 10:54, Jan Beulich wrote: > > > On 08.06.2023 14:18, Roberto Bagnara wrote: >> On 07/06/23 09:39, Jan Beulich wrote: >>> On 05.06.2023 15:26, Roberto Bagnara wrote: On 05/06/23 11:28, Jan Beulich wrote: > On 05.06.2023 07:28, Roberto Bagnara wrote: You are right:

Re: [PATCH] tools: Move MASK_INSR to common-macros.h

On 09/06/2023 10:31 am, Jan Beulich wrote: > On 08.06.2023 19:40, Andrew Cooper wrote: >> MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. > Right, that's one thing which should have been done right away. > The other is that both macros should have been purged from >

Re: [PATCH] tools: Move MASK_INSR to common-macros.h

On 08.06.2023 19:40, Andrew Cooper wrote: > MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. Right, that's one thing which should have been done right away. The other is that both macros should have been purged from tools/tests/x86_emulator/x86-emulate.h (which includes

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

On 09/06/2023 10:22 am, Jan Beulich wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/boot_of.c >> @@ -0,0 +1,122 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ > By default we mean to use ... > >> --- /dev/null >> +++ b/xen/arch/ppc/early_printk.c >> @@ -0,0 +1,36 @@ >> +/*

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

On 07.06.2023 17:06, Shawn Anastasio wrote: > On typical Power VMs (e.g. QEMU's -M pseries), a variety of services > are provided by OpenFirmware, including an early serial console. > Implement the required interfaces to call into OpenFirmware and write > to the serial console. > > Since

[xen-unstable-smoke test] 181333: regressions - FAIL

flight 181333 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181333/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

Re: [PATCH 1/3] xen: Add files needed for minimal Power build

On 07.06.2023 17:06, Shawn Anastasio wrote: > Add the build system changes required to build for ppc64le (POWER8+). > Following in the footsteps of the initial riscv port, only building > the head.o target, which boots to an infinite loop, is supported: > > $ make XEN_TARGET_ARCH=ppc64 -C xen

[linux-linus test] 181320: regressions - FAIL

flight 181320 linux-linus real [real] flight 181332 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181320/ http://logs.test-lab.xenproject.org/osstest/logs/181332/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH 3/3] maintainers: Add PPC64 maintainer

On 07.06.2023 17:06, Shawn Anastasio wrote: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -451,6 +451,9 @@ M:Wei Liu > S: Supported > T: git https://xenbits.xenproject.org/git-http/ovmf.git > > +PPC64 > +M: Shawn Anastasio > + > POWER MANAGEMENT > M: Jan Beulich > S:

Re: Xen reliance on non-standard GCC features

On 08.06.2023 14:18, Roberto Bagnara wrote: > On 07/06/23 09:39, Jan Beulich wrote: >> On 05.06.2023 15:26, Roberto Bagnara wrote: >>> On 05/06/23 11:28, Jan Beulich wrote: On 05.06.2023 07:28, Roberto Bagnara wrote: >>> You are right: here are a few examples for U2: >>> >>>

Re: Asking for help to debug xen efi on Kunpeng machine

Hello, On 09/06/2023 03:32, Jiatong Shen wrote: Thank you for your answer. Can you teach me how to verify if acpi is enabled? You usually look at the .config. But I am not sure if this is provided by the Debian package. If not, then your best option would be to build your own Xen. To select

Re: [PATCH] docs/misra: new rules addition

On 08.06.2023 13:02, Roberto Bagnara wrote: > On 07/06/23 23:53, Stefano Stabellini wrote: >> On Wed, 7 Jun 2023, Jan Beulich wrote: + * - `Rule 5.6 `_ + - Required + - A typedef

Re: [PATCH] tools/ocaml/xc: Fix xc_physinfo() bindings

> On 8 Jun 2023, at 20:33, Andrew Cooper wrote: > > +type arm_physinfo_caps = > + { > +sve_vl: int; > + } > + Does the OCaml side need to know about the structure of this value or is it enough to pass it around as an abstract value because all logic is on the C side? I assume the

[qemu-mainline test] 181327: regressions - FAIL

flight 181327 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181327/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 180691 build-arm64

[xen-unstable-smoke test] 181330: regressions - FAIL

flight 181330 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181330/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf