[PATCH] x86/DMI: adjustments to comply with Misra C:2012 Rule 9.3

2023-11-29 Thread Jan Beulich
The rule demands that all array elements be initialized (or dedicated initializers be used). Introduce a small set of macros to allow doing so without unduly affecting use sites (in particular in terms of how many elements .matches[] actually has; right now there's no use of DMI_MATCH4(), so we

[ovmf test] 183945: all pass - PUSHED

2023-11-29 Thread osstest service owner
flight 183945 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183945/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 59b6b5059b90883abfcbd906c411e8f59ac1aa0d baseline version: ovmf

Re: [PATCH 6/6] Rename "QEMU global mutex" to "BQL" in comments and docs

2023-11-29 Thread Markus Armbruster
Stefan Hajnoczi writes: > The term "QEMU global mutex" is identical to the more widely used Big > QEMU Lock ("BQL"). Update the code comments and documentation to use > "BQL" instead of "QEMU global mutex". > > Signed-off-by: Stefan Hajnoczi For QAPI Acked-by: Markus Armbruster

Re: [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function

2023-11-29 Thread Chen, Jiqian
On 2023/11/30 11:46, Stefano Stabellini wrote: > On Fri, 24 Nov 2023, Jiqian Chen wrote: >> When device on dom0 side has been reset, the vpci on Xen side >> won't get notification, so that the cached state in vpci is >> all out of date with the real device state. >> To solve that problem, this

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-29 Thread Chen, Jiqian
On 2023/11/29 00:11, Roger Pau Monné wrote: > On Tue, Nov 28, 2023 at 03:42:31PM +0100, Juergen Gross wrote: >> On 28.11.23 15:25, Roger Pau Monné wrote: >>> On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: In PVH dom0, it uses the linux local interrupt mechanism, when it

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-29 Thread Chen, Jiqian
On 2023/11/28 22:25, Roger Pau Monné wrote: > On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: >> In PVH dom0, it uses the linux local interrupt mechanism, >> when it allocs irq for a gsi, it is dynamic, and follow >> the principle of applying first, distributing first. And >> if you

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-29 Thread Chen, Jiqian
On 2023/11/28 23:14, Jan Beulich wrote: > On 24.11.2023 11:41, Jiqian Chen wrote: >> --- a/xen/arch/x86/hvm/hypercall.c >> +++ b/xen/arch/x86/hvm/hypercall.c >> @@ -74,6 +74,8 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) >> arg) >> { >> case PHYSDEVOP_map_pirq: >>

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-29 Thread Chen, Jiqian
On 2023/11/28 22:17, Roger Pau Monné wrote: > On Fri, Nov 24, 2023 at 06:41:35PM +0800, Jiqian Chen wrote: >> If we run Xen with PVH dom0 and hvm domU, hvm will map a pirq for >> a passthrough device by using gsi, see xen_pt_realize->xc_physdev_map_pirq >> and

Re: [RFC XEN PATCH v2 1/3] xen/vpci: Clear all vpci status of device

2023-11-29 Thread Chen, Jiqian
Hi Roger and Daniel P. Smith, On 2023/11/28 22:08, Roger Pau Monné wrote: > On Fri, Nov 24, 2023 at 06:41:34PM +0800, Jiqian Chen wrote: >> When a device has been reset on dom0 side, the vpci on Xen >> side won't get notification, so the cached state in vpci is >> all out of date compare with the

RE: [PATCH v12 02/37] x86/opcode: Add the WRMSRNS instruction to the x86 opcode map

2023-11-29 Thread Li, Xin3
> Add the opcode used by WRMSRNS, which is the non-serializing version of > WRMSR and may replace it to improve performance, to the x86 opcode map. > > Tested-by: Shan Kang > Signed-off-by: Xin Li > Acked-by: Masami Hiramatsu (Google) Hi Masami, Boris prefers to merge the first 3 patches

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-29 Thread Stefano Stabellini
n Wed, 29 Nov 2023, Stefano Stabellini wrote: > On Tue, 28 Nov 2023, Roger Pau Monné wrote: > > On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: > > > In PVH dom0, it uses the linux local interrupt mechanism, > > > when it allocs irq for a gsi, it is dynamic, and follow > > > the

Re: [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0

2023-11-29 Thread Stefano Stabellini
On Fri, 24 Nov 2023, Jiqian Chen wrote: > This patch is to solve two problems we encountered when we try to > passthrough a device to hvm domU base on Xen PVH dom0. > > First, hvm guest will alloc a pirq and irq for a passthrough device > by using gsi, before that, the gsi must first has a

Re: [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function

2023-11-29 Thread Stefano Stabellini
On Fri, 24 Nov 2023, Jiqian Chen wrote: > When device on dom0 side has been reset, the vpci on Xen side > won't get notification, so that the cached state in vpci is > all out of date with the real device state. > To solve that problem, this patch add a function to clear all > vpci device state

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-29 Thread Stefano Stabellini
On Tue, 28 Nov 2023, Roger Pau Monné wrote: > On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: > > In PVH dom0, it uses the linux local interrupt mechanism, > > when it allocs irq for a gsi, it is dynamic, and follow > > the principle of applying first, distributing first. And > > if

Re: [PATCH v4 4/6] automation: switch to a wifi card on ADL system

2023-11-29 Thread Stefano Stabellini
On Fri, 24 Nov 2023, Marek Marczykowski-Górecki wrote: > Switch to a wifi card that has registers on a MSI-X page. This tests the > "x86/hvm: Allow writes to registers on the same page as MSI-X table" > feature. Switch it only for HVM test, because MSI-X adjacent write is > not supported on PV. >

Re: [PATCH v4 3/6] automation: prevent QEMU access to /dev/mem in PCI passthrough tests

2023-11-29 Thread Stefano Stabellini
On Fri, 24 Nov 2023, Marek Marczykowski-Górecki wrote: > /dev/mem access doesn't work in dom0 in lockdown and in stubdomain. > Simulate this environment with removing /dev/mem device node. Full test > for lockdown and stubdomain will come later, when all requirements will > be in place. > >

Re: [XEN PATCH v2] automation/eclair: improve scheduled analyses

2023-11-29 Thread Stefano Stabellini
On Thu, 23 Nov 2023, Simone Ballarin wrote: > The scheduled analyses are intended to maintain an overall vision > of the MISRA complaince of the entire project. For this reason, > the file exclusions in "out_of_scope.ecl" should not be applied. > > This patch amends ECLAIR settings to prevent

Re: [PATCH v2 5/5] automation: add x86-64 livepatching test

2023-11-29 Thread Stefano Stabellini
On Tue, 28 Nov 2023, Roger Pau Monne wrote: > Introduce a new gitlab tests for livepatching, using livepatch-build-tools, > which better reflects how downstreams build live patches rather than the > in-tree tests. > > The tests applies the dummy in-tree patch example, checks that the patch is >

Re: [PATCH v2 3/5] xen/x86: introduce self modifying code test

2023-11-29 Thread Stefano Stabellini
On Tue, 28 Nov 2023, Roger Pau Monne wrote: > Introduce a helper to perform checks related to self modifying code, and start > by creating a simple test to check that alternatives have been applied. > > Such test is hooked into the boot process and called just after alternatives > have been

Re: [PATCH v2 2/5] automation/alpine: add elfutils-dev

2023-11-29 Thread Stefano Stabellini
On Tue, 28 Nov 2023, Roger Pau Monne wrote: > In preparation for adding some livepatch-build-tools test update the Alpine > container to also install elfutils-dev. > > Signed-off-by: Roger Pau Monné Acked-by: Stefano Stabellini > --- > automation/build/alpine/3.18.dockerfile | 2 ++ > 1 file

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-11-29 Thread Stewart Hildebrand
On 11/14/23 04:13, Jan Beulich wrote: > On 13.11.2023 23:21, Stewart Hildebrand wrote: >> --- a/xen/arch/x86/include/asm/domain.h >> +++ b/xen/arch/x86/include/asm/domain.h >> @@ -503,6 +503,8 @@ struct arch_domain >> #define has_vpit(d)(!!((d)->arch.emulation_flags & X86_EMU_PIT)) >>

Re: [PATCH] automation: Switch u-boot boot command to bootz for arm32 tests

2023-11-29 Thread Stefano Stabellini
On Fri, 24 Nov 2023, Michal Orzel wrote: > Thanks to recent changes added to ImageBuilder to support the bootz > command, which allows obtaining the effective image size (including NOLOAD > sections) from the zImage header, switch the BOOT_CMD for arm32 tests to > bootz. Among other scenarios,

Linux 6.7-rc1+: WARNING at drivers/xen/evtchn.c:167 evtchn_interrupt

2023-11-29 Thread Marek Marczykowski-Górecki
Hi, While testing 6.7-rc3 on Qubes OS I found several warning like in the subject in dom0 log. I see them when running 6.7-rc1 too. I'm not sure what exactly triggers the issue, but my guess would be unbinding an event channel from userspace (closing vchan connection). Specific message: [

[linux-5.4 test] 183929: tolerable FAIL - PUSHED

2023-11-29 Thread osstest service owner
flight 183929 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/183929/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-raw 18 guest-start.2fail in 183907 pass in 183929 test-armhf-armhf-libvirt-qcow2 17

Re: [PATCH v10 13/17] vpci: add initial support for virtual PCI bus topology

2023-11-29 Thread Stefano Stabellini
On Wed, 29 Nov 2023, Roger Pau Monné wrote: > On Tue, Nov 28, 2023 at 11:45:34PM +, Volodymyr Babchuk wrote: > > Hi Roger, > > > > Roger Pau Monné writes: > > > > > On Wed, Nov 22, 2023 at 01:18:32PM -0800, Stefano Stabellini wrote: > > >> On Wed, 22 Nov 2023, Roger Pau Monné wrote: > > >>

Re: [PATCH v6 00/17] Device tree based NUMA support for Arm

2023-11-29 Thread Henry Wang
Hi Stefano, Thanks for the email! > On Nov 30, 2023, at 09:06, Stefano Stabellini wrote: > > Hi Henry, > > Thank you for all your work on this series and in general upstreaming > other patches too! It’s our pleasure. > How do we test it? Is there a way to test this series with QEMU and some

Re: [PATCH v6 00/17] Device tree based NUMA support for Arm

2023-11-29 Thread Stefano Stabellini
Hi Henry, Thank you for all your work on this series and in general upstreaming other patches too! How do we test it? Is there a way to test this series with QEMU and some special device tree? I am asking because during review it would make things easier if we could exercise the new code

[libvirt test] 183927: tolerable FAIL - PUSHED

2023-11-29 Thread osstest service owner
flight 183927 libvirt real [real] flight 183943 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183927/ http://logs.test-lab.xenproject.org/osstest/logs/183943/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

[ovmf test] 183942: all pass - PUSHED

2023-11-29 Thread osstest service owner
flight 183942 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183942/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4f99b5fb936a2a0239d5212948b7104d75d1558c baseline version: ovmf

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-29 Thread Stefano Stabellini
Hi Mario, I suggest to do one step at a time and first to get it fully working using "xl" to create the FreeBSD guest. And afterwords to try to get libvirt to work. Both xl and libvirt call the same library underneath (libxl) to create guests, but xl is tested a lot more with Xen on ARM. I am

xen | Successful pipeline for staging | f0dd0cd9

2023-11-29 Thread GitLab
Pipeline #1089709752 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: f0dd0cd9 ( https://gitlab.com/xen-project/xen/-/commit/f0dd0cd9598f22ee5509bb5d1466e4821834c4ba ) Commit Message: docs/misra:

[PATCH 1/6] system/cpus: rename qemu_mutex_lock_iothread() to qemu_bql_lock()

2023-11-29 Thread Stefan Hajnoczi
The Big QEMU Lock (BQL) has many names and they are confusing. The actual QemuMutex variable is called qemu_global_mutex but it's commonly referred to as the BQL in discussions and some code comments. The locking APIs, however, are called qemu_mutex_lock_iothread() and

[PATCH 6/6] Rename "QEMU global mutex" to "BQL" in comments and docs

2023-11-29 Thread Stefan Hajnoczi
The term "QEMU global mutex" is identical to the more widely used Big QEMU Lock ("BQL"). Update the code comments and documentation to use "BQL" instead of "QEMU global mutex". Signed-off-by: Stefan Hajnoczi --- docs/devel/multi-thread-tcg.rst | 7 +++ docs/devel/qapi-code-gen.rst |

[PATCH 3/6] qemu/main-loop: rename qemu_cond_wait_iothread() to qemu_cond_wait_bql()

2023-11-29 Thread Stefan Hajnoczi
The name "iothread" is overloaded. Use the term Big QEMU Lock (BQL) instead, it is already widely used and unambiguous. Signed-off-by: Stefan Hajnoczi --- include/qemu/main-loop.h | 8 accel/tcg/tcg-accel-ops-rr.c | 4 ++-- hw/display/virtio-gpu.c | 2 +-

[PATCH 0/6] Make Big QEMU Lock naming consistent

2023-11-29 Thread Stefan Hajnoczi
The Big QEMU Lock ("BQL") has two other names: "iothread lock" and "QEMU global mutex". The term "iothread lock" is easily confused with the unrelated --object iothread (iothread.c). This series updates the code and documentation to consistently use "BQL". This makes the code easier to

[PATCH 5/6] Replace "iothread lock" with "BQL" in comments

2023-11-29 Thread Stefan Hajnoczi
The term "iothread lock" is obsolete. The APIs use Big QEMU Lock (BQL) in their names. Update the code comments to use "BQL" instead of "iothread lock". Signed-off-by: Stefan Hajnoczi --- docs/devel/reset.rst | 2 +- hw/display/qxl.h | 2 +-

[PATCH 4/6] system/cpus: rename qemu_global_mutex to qemu_bql

2023-11-29 Thread Stefan Hajnoczi
The APIs using qemu_global_mutex now follow the Big QEMU Lock (BQL) nomenclature. It's a little strange that the actual QemuMutex variable that embodies the BQL is called qemu_global_mutex instead of qemu_bql. Rename it for consistency. Signed-off-by: Stefan Hajnoczi --- system/cpus.c | 20

[PATCH 2/6] qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to QEMU_BQL_LOCK_GUARD

2023-11-29 Thread Stefan Hajnoczi
The name "iothread" is overloaded. Use the term Big QEMU Lock (BQL) instead, it is already widely used and unambiguous. Signed-off-by: Stefan Hajnoczi --- include/qemu/main-loop.h | 20 ++-- hw/i386/kvm/xen_evtchn.c | 14 +++--- hw/i386/kvm/xen_gnttab.c | 2 +-

Re: [PATCH v6 2/5] xen/vpci: move xen_domctl_createdomain vPCI flag to common

2023-11-29 Thread Stewart Hildebrand
On 11/14/23 04:11, Jan Beulich wrote: > On 13.11.2023 23:21, Stewart Hildebrand wrote: >> @@ -709,10 +710,17 @@ int arch_sanitise_domain_config(struct >> xen_domctl_createdomain *config) >> return -EINVAL; >> } >> >> +if ( vpci && !hvm ) >> +{ >> +

Re: [RFC PATCH v2 17/19] heki: x86: Update permissions counters during text patching

2023-11-29 Thread Madhavan T. Venkataraman
On 11/27/23 14:08, Peter Zijlstra wrote: > On Mon, Nov 27, 2023 at 10:48:29AM -0600, Madhavan T. Venkataraman wrote: >> Apologies for the late reply. I was on vacation. Please see my response >> below: >> >> On 11/13/23 02:19, Peter Zijlstra wrote: >>> On Sun, Nov 12, 2023 at 09:23:24PM -0500,

[xen-unstable-smoke test] 183939: tolerable all pass - PUSHED

2023-11-29 Thread osstest service owner
flight 183939 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183939/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: xen 4.15.5: msr_relaxed required for MSR 0x1a2

2023-11-29 Thread James Dingwall
On Mon, Nov 20, 2023 at 10:24:05AM +0100, Roger Pau Monné wrote: > On Mon, Nov 20, 2023 at 08:27:36AM +, James Dingwall wrote: > > On Fri, Nov 17, 2023 at 10:56:30AM +0100, Jan Beulich wrote: > > > On 17.11.2023 10:18, James Dingwall wrote: > > > > On Thu, Nov 16, 2023 at 04:32:47PM +,

[PATCH 12/12] block: remove outdated AioContext locking comments

2023-11-29 Thread Stefan Hajnoczi
The AioContext lock no longer exists. There is one noteworthy change: - * More specifically, these functions use BDRV_POLL_WHILE(bs), which - * requires the caller to be either in the main thread and hold - * the BlockdriverState (bs) AioContext lock, or directly in the - * home thread

[PATCH 11/12] job: remove outdated AioContext locking comments

2023-11-29 Thread Stefan Hajnoczi
The AioContext lock no longer exists. Signed-off-by: Stefan Hajnoczi --- include/qemu/job.h | 20 1 file changed, 20 deletions(-) diff --git a/include/qemu/job.h b/include/qemu/job.h index e502787dd8..9ea98b5927 100644 --- a/include/qemu/job.h +++ b/include/qemu/job.h @@

Re: [PATCH v4 12/14] xen/asm-generic: introduce stub header softirq.h

2023-11-29 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common between Arm, PPC and RISC-V so it is > moved to asm-generic. > > Drop Arm and PPC's softirq.h and use asm-generic version instead. > Acked-by: Shawn Anastasio Thanks, Shawn

[PATCH 10/12] scsi: remove outdated AioContext lock comment

2023-11-29 Thread Stefan Hajnoczi
The SCSI subsystem no longer uses the AioContext lock. Request processing runs exclusively in the BlockBackend's AioContext since "scsi: only access SCSIDevice->requests from one thread" and hence the lock is unnecessary. Signed-off-by: Stefan Hajnoczi --- hw/scsi/scsi-disk.c | 1 - 1 file

[PATCH 06/12] scsi: remove AioContext locking

2023-11-29 Thread Stefan Hajnoczi
The AioContext lock no longer has any effect. Remove it. Signed-off-by: Stefan Hajnoczi --- include/hw/virtio/virtio-scsi.h | 14 -- hw/scsi/scsi-bus.c | 2 -- hw/scsi/scsi-disk.c | 28 hw/scsi/virtio-scsi.c | 18

[PATCH 07/12] aio-wait: draw equivalence between AIO_WAIT_WHILE() and AIO_WAIT_WHILE_UNLOCKED()

2023-11-29 Thread Stefan Hajnoczi
Now that the AioContext lock no longer exists, AIO_WAIT_WHILE() and AIO_WAIT_WHILE_UNLOCKED() are equivalent. A future patch will get rid of AIO_WAIT_WHILE_UNLOCKED(). Signed-off-by: Stefan Hajnoczi --- include/block/aio-wait.h | 16 1 file changed, 4 insertions(+), 12

[PATCH 04/12] graph-lock: remove AioContext locking

2023-11-29 Thread Stefan Hajnoczi
Stop acquiring/releasing the AioContext lock in bdrv_graph_wrlock()/bdrv_graph_unlock() since the lock no longer has any effect. The distinction between bdrv_graph_wrunlock() and bdrv_graph_wrunlock_ctx() becomes meaningless and they can be collapsed into one function. Signed-off-by: Stefan

[PATCH 09/12] docs: remove AioContext lock from IOThread docs

2023-11-29 Thread Stefan Hajnoczi
Encourage the use of locking primitives and stop mentioning the AioContext lock since it is being removed. Signed-off-by: Stefan Hajnoczi --- docs/devel/multiple-iothreads.txt | 45 +++ 1 file changed, 15 insertions(+), 30 deletions(-) diff --git

[PATCH 08/12] aio: remove aio_context_acquire()/aio_context_release() API

2023-11-29 Thread Stefan Hajnoczi
Delete these functions because nothing calls these functions anymore. I introduced these APIs in commit 98563fc3ec44 ("aio: add aio_context_acquire() and aio_context_release()") in 2014. It's with a sigh of relief that I delete these APIs almost 10 years later. Thanks to Paolo Bonzini's vision

[PATCH 00/12] aio: remove AioContext lock

2023-11-29 Thread Stefan Hajnoczi
This series removes the AioContext locking APIs from QEMU. aio_context_acquire() and aio_context_release() are currently only needed to support the locking discipline required by AIO_POLL_WHILE() (except for a stray user that I converted in Patch 1). AIO_POLL_WHILE() doesn't really need the

[PATCH 03/12] aio: make aio_context_acquire()/aio_context_release() a no-op

2023-11-29 Thread Stefan Hajnoczi
aio_context_acquire()/aio_context_release() has been replaced by fine-grained locking to protect state shared by multiple threads. The AioContext lock still plays the role of balancing locking in AIO_WAIT_WHILE() and many functions in QEMU either require that the AioContext lock is held or not

[PATCH 01/12] virtio-scsi: replace AioContext lock with tmf_bh_lock

2023-11-29 Thread Stefan Hajnoczi
Protect the Task Management Function BH state with a lock. The TMF BH runs in the main loop thread. An IOThread might process a TMF at the same time as the TMF BH is running. Therefore tmf_bh_list and tmf_bh must be protected by a lock. Run TMF request completion in the IOThread using

[PATCH 02/12] tests: remove aio_context_acquire() tests

2023-11-29 Thread Stefan Hajnoczi
The aio_context_acquire() API is being removed. Drop the test case that calls the API. Signed-off-by: Stefan Hajnoczi --- tests/unit/test-aio.c | 67 +-- 1 file changed, 1 insertion(+), 66 deletions(-) diff --git a/tests/unit/test-aio.c

Re: [PATCH v4 12/14] xen/asm-generic: introduce stub header softirq.h

2023-11-29 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common between Arm, PPC and RISC-V so it is > moved to asm-generic. > > Drop Arm and PPC's softirq.h and use asm-generic version instead. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 11/14] xen/asm-generic: introduce stub header numa.h

2023-11-29 Thread Shawn Anastasio
On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > diff --git a/xen/arch/arm/include/asm/numa.h b/xen/include/asm-generic/numa.h > similarity index 76% > rename from xen/arch/arm/include/asm/numa.h > rename to xen/include/asm-generic/numa.h > index e2bee2bd82..b00fca4978 100644 > ---

Re: [RFC PATCH v2 18/19] heki: x86: Protect guest kernel memory using the KVM hypervisor

2023-11-29 Thread Madhavan T. Venkataraman
On 11/27/23 14:03, Peter Zijlstra wrote: > On Mon, Nov 27, 2023 at 11:05:23AM -0600, Madhavan T. Venkataraman wrote: >> Apologies for the late reply. I was on vacation. Please see my response >> below: >> >> On 11/13/23 02:54, Peter Zijlstra wrote: >>> On Sun, Nov 12, 2023 at 09:23:25PM -0500,

Re: [PATCH v4 10/14] xen/asm-generic: introduce stub header monitor.h

2023-11-29 Thread Shawn Anastasio
On 11/29/23 6:39 AM, Oleksii wrote: > Hi Shawn, > > On Tue, 2023-11-28 at 16:21 -0600, Shawn Anastasio wrote: >> Hi Oleksii, >> >> On 11/27/23 8:13 AM, Oleksii Kurochko wrote: >>> diff --git a/xen/arch/ppc/include/asm/Makefile >>> b/xen/arch/ppc/include/asm/Makefile >>> index

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-29 Thread Shawn Anastasio
On 11/29/23 6:49 AM, Oleksii wrote: > On Tue, 2023-11-28 at 15:28 -0600, Shawn Anastasio wrote: >> Hi Oleksii, >> >> On 11/27/23 8:13 AM, Oleksii Kurochko wrote: >>> diff --git a/xen/arch/ppc/include/asm/irq.h >>> b/xen/arch/ppc/include/asm/irq.h >>> index 5c37d0cf25..49193fddff 100644 >>> ---

Re: [PATCH] xen/arm: Move static event channel feature to a separate module

2023-11-29 Thread Michal Orzel
On 29/11/2023 18:54, Julien Grall wrote: > > > Hi Michal, > > On 29/11/2023 18:41, Michal Orzel wrote: >> On 29/11/2023 18:17, Julien Grall wrote: >>> That said, I could settle on defining the two helpers in the *.c >>> directly because they are not meant to be used outside of a single *.c.

Re: [PATCH] .gitignore: generalize *.new

2023-11-29 Thread Julien Grall
Hi Jan, On 28/11/2023 13:51, Jan Beulich wrote: It's not only in xen/include/xen/ that we generate (intermediate) *.new files. Signed-off-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall

Re: [PATCH] xen/arm: Move static event channel feature to a separate module

2023-11-29 Thread Julien Grall
Hi Michal, On 29/11/2023 18:41, Michal Orzel wrote: On 29/11/2023 18:17, Julien Grall wrote: That said, I could settle on defining the two helpers in the *.c directly because they are not meant to be used outside of a single *.c. Simarly... diff --git

Re: [PATCH 5/5] xen/arm: address violations of MISRA C:2012 Rule 11.8

2023-11-29 Thread Julien Grall
Hi, On 24/11/2023 17:29, Simone Ballarin wrote: From: Maria Celeste Cesario Add or amend casts to comply with Rule 11.8. The violations are resolved either: - by adding a missing const qualifier in the cast - by removing a cast to non-const on a const-qualified object No functional change.

Re: [PATCH] xen/arm: Move static event channel feature to a separate module

2023-11-29 Thread Michal Orzel
Hi Julien, On 29/11/2023 18:17, Julien Grall wrote: > > > Hi Michal > > On 29/11/2023 16:34, Michal Orzel wrote: >> Move static event channel feature related code to a separate module >> (static-evtchn.{c,h}) in the spirit of fine granular configuration, so >> that the feature can be disabled

Re: [XEN PATCH v5 1/2] automation/eclair: make the docs for MISRA C:2012 Dir 4.1 visible to ECLAIR

2023-11-29 Thread Julien Grall
Hi, On 29/11/2023 04:16, Stefano Stabellini wrote: On Fri, 17 Nov 2023, Nicola Vetrini wrote: To be able to check for the existence of the necessary subsections in the documentation for MISRA C:2012 Dir 4.1, ECLAIR needs to have a source file that is built. This file is generated from

Re: [XEN PATCH v6] arm/bitops: encapsulate violation of MISRA C:2012 Rule 10.1

2023-11-29 Thread Julien Grall
Hi Nicola, On 29/11/2023 10:32, Nicola Vetrini wrote: The definitions of ffs{l}? violate Rule 10.1, by using the well-known pattern (x & -x); its usage is wrapped by the ISOLATE_LSB macro. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini This is now

Re: [PATCH] xen/arm: Move static event channel feature to a separate module

2023-11-29 Thread Julien Grall
Hi Michal On 29/11/2023 16:34, Michal Orzel wrote: Move static event channel feature related code to a separate module (static-evtchn.{c,h}) in the spirit of fine granular configuration, so that the feature can be disabled if not needed. Introduce Kconfig option CONFIG_STATIC_EVTCHN, enabled

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-29 Thread Elliott Mitchell
On Tue, Nov 28, 2023 at 03:04:50PM -0800, Elliott Mitchell wrote: > On Tue, Nov 28, 2023 at 04:10:50PM +0100, Roger Pau Monné wrote: > > On Tue, Nov 28, 2023 at 03:09:14PM +0100, Mario Marietto wrote: > > > For booting a FreeBSD kernel as a guest OS on XEN,should we install xen > > > 4.18 from

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-29 Thread Mario Marietto
Hello to everyone. I tried to use xen as a hypervisor instead of kvm + libvirt + virt-manager to boot FreeBSD on my ARM Chromebook where I have installed Devuan 5,since Stefano said : "That might work. libvirt + virt-manager with the xen accelerator might work on the ARM Chromebook. That's

[xen-unstable test] 183922: tolerable FAIL

2023-11-29 Thread osstest service owner
flight 183922 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183922/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail like 183860

[PATCH] tools/xg: Fix potential memory leak in cpu policy getters/setters

2023-11-29 Thread Alejandro Vallejo
They allocate two different hypercall buffers, but leak the first allocation if the second one failed due to an early return that bypasses cleanup. Remove the early exit and go through _post() instead. Invoking _post() is benign even if _pre() failed. Fixes: 6b85e427098c ('x86/sysctl: Implement

Re: [PATCH v8 2/2] xen/vpci: header: filter PCI capabilities

2023-11-29 Thread Stewart Hildebrand
On 11/29/23 09:05, Roger Pau Monné wrote: > On Tue, Nov 28, 2023 at 02:44:25PM -0500, Stewart Hildebrand wrote: >> Currently, Xen vPCI only supports virtualizing the MSI and MSI-X >> capabilities. >> Hide all other PCI capabilities (including extended capabilities) from domUs >> for >> now, even

Re: Important - Documentation Discussion

2023-11-29 Thread Kelly Choi
Hi all, After gathering different feedback from members of the community, please see below. *We will be moving ahead with Git + RST + Sphinx + Kroki as the new platforms for user documentation.* *Many of you have specified you don't necessarily have a preference for the platform, but instead a

[PATCH] xen/arm: Move static event channel feature to a separate module

2023-11-29 Thread Michal Orzel
Move static event channel feature related code to a separate module (static-evtchn.{c,h}) in the spirit of fine granular configuration, so that the feature can be disabled if not needed. Introduce Kconfig option CONFIG_STATIC_EVTCHN, enabled by default (to keep the current behavior) dependent on

[xen-unstable-smoke test] 183934: tolerable all pass - PUSHED

2023-11-29 Thread osstest service owner
flight 183934 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183934/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [XEN PATCH 0/7] address some violations of MISRA C Rule 8.4

2023-11-29 Thread Nicola Vetrini
On 2023-11-29 16:24, Nicola Vetrini wrote: Hi all, this series addresses some of the remaining violations of MISRA C:2012 Rule 8.4. Some of the modifications are done according to the feedback received in this thread [1] missing a reference: [1]

[XEN PATCH 7/7] xen/page_alloc: deviate first_valid_mfn for MISRA C Rule 8.4

2023-11-29 Thread Nicola Vetrini
No functional change. Signed-off-by: Nicola Vetrini --- The preferred way to deviate is to use asmlinkage, but this modification is only the consequence of NUMA on ARM (and possibly PPC) being a work in progress. As stated in the comment above the textual deviation, first_valid_mfn will likely

[XEN PATCH 2/7] x86/i8259: add missing header for init_IRQ declaration

2023-11-29 Thread Nicola Vetrini
No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/x86/i8259.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c index e0fa1f96b4f2..470d690c3594 100644 --- a/xen/arch/x86/i8259.c +++ b/xen/arch/x86/i8259.c @@ -19,6 +19,7 @@ #include

[XEN PATCH 3/7] xen/x86: add missing instances of asmlinkage attributes

2023-11-29 Thread Nicola Vetrini
No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/x86/desc.c | 2 +- xen/arch/x86/efi/efi-boot.h | 5 +++-- xen/arch/x86/mm.c | 2 +- xen/arch/x86/smpboot.c | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/desc.c

[XEN PATCH 1/7] xen/arm: mmu: add headers for missing declarations

2023-11-29 Thread Nicola Vetrini
The definitions needing the inclusion of asm/setup.h are boot_{first,second,third}(_id)?, whereas vmap.h is needed by arch_vmap_virt_end. No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/arm/mmu/setup.c | 1 + xen/arch/arm/mmu/smpboot.c | 2 ++ 2 files changed, 3

[XEN PATCH 6/7] xen/x86: remove stale comment

2023-11-29 Thread Nicola Vetrini
The comment referred to the declaration for do_mca, which now is part of hypercall-defs.h, therefore the comment is stale. No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/x86/cpu/mcheck/mce.c| 2 +- xen/arch/x86/include/asm/hypercall.h | 2 +- 2 files changed, 2

[XEN PATCH 5/7] docs/misra: add entry to exclude-list.json

2023-11-29 Thread Nicola Vetrini
x86/efi/check.c is not part of the final Xen binary, therefore it doesn't need to conform to MISRA guidelines at the moment. Signed-off-by: Nicola Vetrini --- docs/misra/exclude-list.json | 4 1 file changed, 4 insertions(+) diff --git a/docs/misra/exclude-list.json

[XEN PATCH 4/7] x86/viridian: make build_assertions static

2023-11-29 Thread Nicola Vetrini
This is consistent with other instances of the same function and also resolves a violation of MISRA C:2012 Rule 8.4. No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/x86/hvm/viridian/synic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[XEN PATCH 0/7] address some violations of MISRA C Rule 8.4

2023-11-29 Thread Nicola Vetrini
Hi all, this series addresses some of the remaining violations of MISRA C:2012 Rule 8.4. Some of the modifications are done according to the feedback received in this thread [1] Nicola Vetrini (7): xen/arm: mmu: add headers for missing declarations x86/i8259: add missing header for

Re: [PATCH v8 1/2] xen/vpci: header: status register handler

2023-11-29 Thread Stewart Hildebrand
On 11/29/23 06:03, Roger Pau Monné wrote: > On Tue, Nov 28, 2023 at 02:44:24PM -0500, Stewart Hildebrand wrote: >> Introduce a handler for the PCI status register, with ability to mask >> the capabilities bit. The status register contains RsvdZ bits, >> read-only bits, and write-1-to-clear bits.

xen | Successful pipeline for staging | 902377b6

2023-11-29 Thread GitLab
Pipeline #1089097255 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 902377b6 ( https://gitlab.com/xen-project/xen/-/commit/902377b690f42ddf44ae91c4b0751d597f1cd694 ) Commit Message:

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-11-29 Thread Juergen Gross
On 29.11.23 11:47, Julien Grall wrote: Hi, + Anthony for the tools + Juergen for Xenstored On 29/11/2023 11:34, Alexander Kanavin wrote: On 11/29/23 08:51, Jan Beulich wrote: On 28.11.2023 18:47, Alexander Kanavin wrote: Such constructs are fully allowed by C99:

Re: [PATCH] xen/livepatch: fix livepatch tests

2023-11-29 Thread Roger Pau Monné
On Wed, Nov 29, 2023 at 10:32:32AM +, Ross Lagerwall wrote: > On Tue, Nov 28, 2023 at 5:41 PM Roger Pau Monne wrote: > > > > The current set of in-tree livepatch tests in xen/test/livepatch started > > failing after the constify of the payload funcs array, and the movement of > > the > >

Re: [PATCH v8 2/2] xen/vpci: header: filter PCI capabilities

2023-11-29 Thread Roger Pau Monné
On Tue, Nov 28, 2023 at 02:44:25PM -0500, Stewart Hildebrand wrote: > Currently, Xen vPCI only supports virtualizing the MSI and MSI-X capabilities. > Hide all other PCI capabilities (including extended capabilities) from domUs > for > now, even though there may be certain devices/drivers that

[PATCH v5 2/5] x86/paravirt: move some functions and defines to alternative

2023-11-29 Thread Juergen Gross
As a preparation for replacing paravirt patching completely by alternative patching, move some backend functions and #defines to alternative code and header. Signed-off-by: Juergen Gross --- V4: - rename x86_nop() to nop_func() and x86_BUG() to BUG_func() (Boris Petkov) ---

[PATCH v5 0/5] 86/paravirt: Get rid of paravirt patching

2023-11-29 Thread Juergen Gross
This is a small series getting rid of paravirt patching by switching completely to alternative patching for the same functionality. The basic idea is to add the capability to switch from indirect to direct calls via a special alternative patching option. This removes _some_ of the paravirt macro

Re: [PATCH] xen/public: fix flexible array definitions

2023-11-29 Thread Andrew Cooper
On 25/07/2023 2:55 pm, Juergen Gross wrote: > Flexible arrays in public headers can be problematic with some > compilers. > > Replace them with arr[XEN_FLEX_ARRAY_DIM] in order to avoid compilation > errors. > > This includes arrays defined as "arr[1]", as seen with a recent Linux > kernel [1]. >

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-11-29 Thread Anthony PERARD
On Wed, Nov 29, 2023 at 11:47:24AM +0100, Julien Grall wrote: > Hi, > > + Anthony for the tools > + Juergen for Xenstored > > On 29/11/2023 11:34, Alexander Kanavin wrote: > > On 11/29/23 08:51, Jan Beulich wrote: > > > > > On 28.11.2023 18:47, Alexander Kanavin wrote: > > > > Such constructs

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-29 Thread Federico Serafini
On 29/11/23 12:09, Jan Beulich wrote: On 29.11.2023 10:35, Federico Serafini wrote: I take this opportunity to inform that we are really close to the end with Rule 8.3 for x86, this is the situation: - do_multicall(), Stefano sent a patch; - guest_walk_tables(), Andrew will take care of it; -

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-29 Thread Oleksii
On Tue, 2023-11-28 at 15:28 -0600, Shawn Anastasio wrote: > Hi Oleksii, > > On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > > diff --git a/xen/arch/ppc/include/asm/Makefile > > b/xen/arch/ppc/include/asm/Makefile > > index ece7fa66dd..df4c1ebb08 100644 > > --- a/xen/arch/ppc/include/asm/Makefile >

Re: [PATCH v4 10/14] xen/asm-generic: introduce stub header monitor.h

2023-11-29 Thread Oleksii
On Wed, 2023-11-29 at 09:21 +0100, Jan Beulich wrote: > On 29.11.2023 09:19, Jan Beulich wrote: > > On 28.11.2023 23:21, Shawn Anastasio wrote: > > > On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > > > > --- a/xen/arch/ppc/include/asm/monitor.h > > > > +++ /dev/null > > > > @@ -1,43 +0,0 @@ > > > >

Re: [PATCH v4 10/14] xen/asm-generic: introduce stub header monitor.h

2023-11-29 Thread Oleksii
Hi Shawn, On Tue, 2023-11-28 at 16:21 -0600, Shawn Anastasio wrote: > Hi Oleksii, > > On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > > The header is shared between several archs so it is > > moved to asm-generic. > > > > Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich . > > --- > >

Re: [PATCH v4 00/14] Introduce generic headers

2023-11-29 Thread Oleksii
On Wed, 2023-11-29 at 10:25 +0100, Jan Beulich wrote: > On 27.11.2023 15:13, Oleksii Kurochko wrote: > > Oleksii Kurochko (14): > >   xen/asm-generic: introduce stub header paging.h > >   xen/asm-generic: introduce generic device.h > >   xen/asm-generic: introduce generic hypercall.h > >  

[linux-linus test] 183917: tolerable FAIL - PUSHED

2023-11-29 Thread osstest service owner
flight 183917 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183917/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183884 test-amd64-amd64-xl-qemut-win7-amd64

  1   2   >