[PATCH] xen/common: Guard freeze/thaw_domains functions with CONFIG_SYSTEM_SUSPEND

2025-06-23 Thread Mykola Kvach
From: Mykola Kvach This patch adds CONFIG_SYSTEM_SUSPEND guards around freeze_domains and thaw_domains functions. This ensures they are only compiled into the hypervisor when the system suspend functionality is enabled, aligning their inclusion with their specific use case. Signed-off-by: Mykol

[PATCH] xen/efi: Show error message for EFI_INVALID_PARAMETER error

2025-06-23 Thread Frediano Ziglio
Show string message instead of code. This happened trying some different ways to boot Xen, specifically trying loading xen.efi using GRUB2 "linux" command. Signed-off-by: Frediano Ziglio --- xen/common/efi/boot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/common/efi/boot.c b/xen/

Re: [PATCH v6] automation/eclair: update configuration of D4.10

2025-06-23 Thread Jan Beulich
On 24.06.2025 03:19, Stefano Stabellini wrote: > MISRA C Directive 4.10 states that "Precautions shall be taken in order > to prevent the contents of a header file being included more than > once". > > Add a SAF tag and update the comment on top of cpufeatures.h. > Add a header inclusion guard to

Re: [PATCH v1 01/16] arm/vpl011: rename virtual PL011 Kconfig option

2025-06-23 Thread Orzel, Michal
On 24/06/2025 05:55, dm...@proton.me wrote: > From: Denis Mukhin > > Rename CONFIG_SBSA_VUART_CONSOLE to CONFIG_HAS_VUART_PL011. Why? We emulate SBSA UART and not PL011. Despite the similarities (the former is a subset of the latter) they are not the same. I find it confusing and drivers for

Re: [PATCH v10 1/3] xen/domain: unify domain ID allocation

2025-06-23 Thread Jan Beulich
On 23.06.2025 20:28, dm...@proton.me wrote: > @@ -2433,6 +2443,71 @@ void thaw_domains(void) > rcu_read_unlock(&domlist_read_lock); > } > > +domid_t domid_alloc(domid_t domid) > +{ > +static domid_t domid_last; > + > +spin_lock(&domid_lock); > + > +/* Exact match. */ > +if (

Re: [PATCH v1 13/16] drivers/vuart: move PL011 emulator code

2025-06-23 Thread Jan Beulich
On 24.06.2025 05:56, dm...@proton.me wrote: > From: Denis Mukhin > > Move PL011 emulator to the new location for UART emulators. > > No functional change intended. > > Signed-off-by: Denis Mukhin > --- > xen/arch/arm/Kconfig | 7 --- > xen/arch/arm/Makefile

[PATCH v1 02/16] arm/vpl011: move DT node parsing to PL011 emulator code

2025-06-23 Thread dmkhn
From: Denis Mukhin Move vpl011 DT node parsing from common Arm code to PL011 emulator code. While doing it pick the generic name vuart_add_fwnode() for DT parser function and place the declaration in the common header in include/xen/vuart.h. No functional change. Signed-off-by: Denis Mukhin

[PATCH v1 06/16] arm/vpl011: remove vpl011 header file

2025-06-23 Thread dmkhn
From: Denis Mukhin Make all PL011 emulator declarations private to emulator's code. No functional change. Signed-off-by: Denis Mukhin --- xen/arch/arm/include/asm/vpl011.h | 67 --- xen/arch/arm/vpl011.c | 39 -- 2 files changed, 35 ins

[PATCH v1 12/16] xen/domain: introduce domain-emu.h

2025-06-23 Thread dmkhn
From: Denis Mukhin Define an architecture-independent location for describing domain emulation flags. Signed-off-by: Denis Mukhin --- Original code: https://lore.kernel.org/xen-devel/20250103-vuart-ns8250-v3-v1-6-c5d36b31d...@ford.com/ --- xen/arch/x86/include/asm/domain.h | 23 -

[PATCH v1 16/16] drivers/vuart: hook simple MMIO-based UART to vUART framework

2025-06-23 Thread dmkhn
From: Denis Mukhin Add new emulation flag DOMAIN_EMU_UART_MMIO and add it to domain_has_vuart(). Add needed shims for vuart framework integration to MMIO-based UART emulator. Remove domain_vuart_{init,free}() and use generic vuart_{init,exit}() calls. No functional change intended. Signed-of

[PATCH v1 15/16] drivers/vuart: introduce framework for UART emulators

2025-06-23 Thread dmkhn
From: Denis Mukhin Introduce a driver framework to abstract UART emulators in the hypervisor. That allows for architecture-independent handling of virtual UARTs in the console driver and simplifies enabling new UART emulators. The framework is built under CONFIG_HAS_VUART, which is automatical

[PATCH v1 05/16] arm/vpl011: use void pointer in domain struct

2025-06-23 Thread dmkhn
From: Denis Mukhin Switch to using void pointer in domain struct to reduce compile-time dependencies for PL011 emulator. Signed-off-by: Denis Mukhin --- xen/arch/arm/include/asm/domain.h | 3 +- xen/arch/arm/vpl011.c | 139 +- 2 files changed, 79 inse

[PATCH v1 01/16] arm/vpl011: rename virtual PL011 Kconfig option

2025-06-23 Thread dmkhn
From: Denis Mukhin Rename CONFIG_SBSA_VUART_CONSOLE to CONFIG_HAS_VUART_PL011. No functional change. Signed-off-by: Denis Mukhin --- xen/arch/arm/Kconfig | 2 +- xen/arch/arm/Makefile | 2 +- xen/arch/arm/configs/tiny64_defconfig | 2 +- xen/arch/arm/dom0less

[PATCH v6] automation/eclair: update configuration of D4.10

2025-06-23 Thread Stefano Stabellini
MISRA C Directive 4.10 states that "Precautions shall be taken in order to prevent the contents of a header file being included more than once". Add a SAF tag and update the comment on top of cpufeatures.h. Add a header inclusion guard to compile.h. Generate header guards for hypercall-defs.h Upd

Re: [PATCH v5] automation/eclair: update configuration of D4.10

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Jan Beulich wrote: > On 22.06.2025 22:58, Stefano Stabellini wrote: > > On Sun, 22 Jun 2025, Nicola Vetrini wrote: > >> On 2025-06-21 04:19, Stefano Stabellini wrote: > >>> --- a/xen/arch/x86/include/asm/cpufeatures.h > >>> +++ b/xen/arch/x86/include/asm/cpufeatures.h > >>> @@

[PATCH 1/2] xen/arm: address violations of Rule 11.3

2025-06-23 Thread victorm.lira
From: Nicola Vetrini Use {get,put}_unaligned_t to ensure that reads and writes are safe to perform even on potentially misaligned pointers. Signed-off-by: Nicola Vetrini Signed-off-by: Victor Lira --- Cc: Andrew Cooper Cc: Anthony PERARD Cc: Michal Orzel Cc: Jan Beulich Cc: Julien Grall C

[PATCH 2/2] xen/x86: address violations of Rule 11.3

2025-06-23 Thread victorm.lira
From: Nicola Vetrini Use {get,put}_unaligned_t to ensure that reads and writes are safe to perform even on potentially misaligned pointers. Signed-off-by: Nicola Vetrini Signed-off-by: Victor Lira --- Cc: Andrew Cooper Cc: Anthony PERARD Cc: Michal Orzel Cc: Jan Beulich Cc: Julien Grall C

[PATCH] docs/misra/rules.rst: allow string literals with memcmp

2025-06-23 Thread Stefano Stabellini
Rule 21.16 is about the types of arguments allowed for memcpy. Add string literals to the allow-list under specific conditions. Suggested-by: Jan Beulich Signed-off-by: Stefano Stabellini diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index e1c26030e8..3e014a6298 100644 --- a/docs/mis

Re: hardware domain and control domain separation

2025-06-23 Thread Stefano Stabellini
I am replying out of order hopefully to make things easier to follow. On Mon, 23 Jun 2025, Demi Marie Obenour wrote: > On 6/23/25 11:44, Jan Beulich wrote: > > On 21.06.2025 02:41, Stefano Stabellini wrote: > >> Regarding hardware domain and control domain separation, Ayan sent to > >> xen-devel a

Re: [PATCH v6 3/7] x86: re-work memset()

2025-06-23 Thread Jason Andryuk
On 2025-06-16 09:00, Jan Beulich wrote: Move the function to its own assembly file. Having it in C just for the entire body to be an asm() isn't really helpful. Then have two flavors: A "basic" version using qword steps for the bulk of the operation, and an ERMS version for modern hardware, to be

Re: [PATCH v6 2/7] x86/alternatives: serialize after (self-)modifying code

2025-06-23 Thread Jason Andryuk
On 2025-06-16 08:59, Jan Beulich wrote: While supposedly safe via enforcing a control flow change when modifying already prefetched code, it may not really be. Afaik a request is pending to drop the first of the two options in the SDM's "Handling Self- and Cross-Modifying Code" section (still pre

Re: [PATCH v6 1/7] x86: suppress ERMS for internal use when MISC_ENABLE.FAST_STRING is clear

2025-06-23 Thread Jason Andryuk
On 2025-06-16 08:59, Jan Beulich wrote: Before we start actually adjusting behavior when ERMS is available, follow Linux commit 161ec53c702c ("x86, mem, intel: Initialize Enhanced REP MOVSB/STOSB") and zap the CPUID-derived feature flag when the MSR bit is clear. Don't extend the artificial clear

Re: [PATCH v1 1/6] CI: Switch x86 tests to 6.12.34 kernel

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Marek Marczykowski-Górecki wrote: > This is necessary for the upcoming Zen4 runner. > > Signed-off-by: Marek Marczykowski-Górecki Acked-by: Stefano Stabellini > --- > Previous version posted in > https://lore.kernel.org/xen-devel/cover.7da1777882774486a13e6f39ff4a2096f6b

Re: [RFC PATCH v4 6/8] xen/arm: scmi: introduce SCI SCMI SMC multi-agent driver

2025-06-23 Thread Julien Grall
Hi Stefano, On 23/06/2025 21:42, Stefano Stabellini wrote: I was trying to avoid introducing two functions that seemed unnecessary. If we go with Oleksii's approach, where do you think memcpy_toio() should be added? Oleksii added them to the scmi file, maybe we want to add them in a more generic

Re: [PATCH v1 6/6] [DO NOT MERGE] CI: example how to use ssh to extract logs

2025-06-23 Thread Demi Marie Obenour
On 6/23/25 09:47, Marek Marczykowski-Górecki wrote: > --- > automation/scripts/qubes-x86-64.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/automation/scripts/qubes-x86-64.sh > b/automation/scripts/qubes-x86-64.sh > index cf040a29856b..944d0c6d383f 100755 > --- a/automation/scripts

Re: [PATCH test-artifacts v1 5/5] Setup ssh access to test systems

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Marek Marczykowski-Górecki wrote: > On Mon, Jun 23, 2025 at 02:56:00PM +0100, Andrew Cooper wrote: > > On 23/06/2025 2:46 pm, Marek Marczykowski-Górecki wrote: > > > For this add also bridge package, so xenbr0 can be configured with > > > /etc/network/interfaces. > > > This all

Re: [PATCH v1 5/6] CI: use Alpine's network setup

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Marek Marczykowski-Górecki wrote: > This allows Alpine startup script to properly handle service > dependencies - necessary for starting dropbear ssh server. > For the latter, always take the IP address from DHCP, in addition to the > test-local one. > > Signed-off-by: Marek M

[PATCH v10 3/3] xen/domain: use get_initial_domain_id() instead of open-coded 0

2025-06-23 Thread dmkhn
From: Denis Mukhin Remove the open-coded domain ID 0 and replace it with a call to get_initial_domain_id(). Signed-off-by: Denis Mukhin --- Changes since v9: - new patch --- xen/arch/arm/domain_build.c | 4 ++-- xen/common/domain.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deleti

Re: [PATCH v1 4/6] CI: make test-artifacts branch/job customizable

2025-06-23 Thread Marek Marczykowski-Górecki
On Mon, Jun 23, 2025 at 02:04:36PM -0700, Stefano Stabellini wrote: > On Mon, 23 Jun 2025, Marek Marczykowski-Górecki wrote: > > Allow choosing which artifacts branch and job to use for Linux. This > > allows running the same tests for different Linux versions, without > > duplicating a lot of yaml

Re: [RFC PATCH v4 6/8] xen/arm: scmi: introduce SCI SCMI SMC multi-agent driver

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Julien Grall wrote: > Hi Stefano, > > On 23/06/2025 20:27, Stefano Stabellini wrote: > > On Mon, 23 Jun 2025, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 22/06/2025 23:15, Stefano Stabellini wrote: > > > > On Thu, 19 Jun 2025, Oleksii Moisieiev wrote: > > > > > On 18

Re: [PATCH test-artifacts v1 1/5] Add linux-6.12.34-x86_64

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Andrew Cooper wrote: > On 23/06/2025 2:46 pm, Marek Marczykowski-Górecki wrote: > > This is necessary for new Zen4 runner. > > Do not include Argo module in this build, as it isn't compatible with > > 6.12 yet. > > > > Signed-off-by: Marek Marczykowski-Górecki > > Acked-by: A

[PATCH v10 2/3] xen/domain: update create_dom0() messages

2025-06-23 Thread dmkhn
From: Denis Mukhin Use %pd for domain identification in error/panic messages in create_dom0(). No functional change. Signed-off-by: Denis Mukhin --- Changes since v9: - new patch --- xen/arch/arm/domain_build.c | 8 xen/arch/x86/setup.c| 4 ++-- 2 files changed, 6 insertions(

Re: [PATCH test-artifacts v1 2/5] Enable CONFIG_USB_RTL8152 in kernel for hw12 runner

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Andrew Cooper wrote: > On 23/06/2025 2:46 pm, Marek Marczykowski-Górecki wrote: > > It uses this USB network interface. > > > > Signed-off-by: Marek Marczykowski-Górecki > > Acked-by: Andrew Cooper Acked-by: Stefano Stabellini

Re: [PATCH v1 6/6] [DO NOT MERGE] CI: example how to use ssh to extract logs

2025-06-23 Thread Stefano Stabellini
Nice! On Mon, 23 Jun 2025, Marek Marczykowski-Górecki wrote: > --- > automation/scripts/qubes-x86-64.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/automation/scripts/qubes-x86-64.sh > b/automation/scripts/qubes-x86-64.sh > index cf040a29856b..944d0c6d383f 100755 > --- a/automati

Re: [PATCH v1 4/6] CI: make test-artifacts branch/job customizable

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Marek Marczykowski-Górecki wrote: > Allow choosing which artifacts branch and job to use for Linux. This > allows running the same tests for different Linux versions, without > duplicating a lot of yaml sections. I just sent this reply: https://lore.kernel.org/xen-devel/alpine

Re: [PATCH test-artifacts v1 4/5] Support building arbitrary Linux branch/tag/commit

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Marek Marczykowski-Górecki wrote: > If LINUX_URL is set, fetch LINUX_VERSION from there. Go with "git > init" + "git fetch" instead of "git clone" to support any of > branch/tag/commit. > > This also defines optional linux-git-* jobs which will build the thing > if LINUX_GIT_V

Re: [PATCH v1 3/6] CI: upload tests-junit.xml as a normal artifact too

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Marek Marczykowski-Górecki wrote: > This allows checking the file if gitlab can't parse it for some reason. > > Signed-off-by: Marek Marczykowski-Górecki Acked-by: Stefano Stabellini > --- > automation/gitlab-ci/test.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [PATCH test-artifacts v1 3/5] Include git in the ARM64 build container too

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Andrew Cooper wrote: > On 23/06/2025 2:46 pm, Marek Marczykowski-Górecki wrote: > > It will be used for fetching some Linux versions. > > > > Signed-off-by: Marek Marczykowski-Górecki > > Acked-by: Andrew Cooper Acked-by: Stefano Stabellini

Re: [RFC PATCH v4 6/8] xen/arm: scmi: introduce SCI SCMI SMC multi-agent driver

2025-06-23 Thread Stefano Stabellini
On Mon, 23 Jun 2025, Julien Grall wrote: > Hi Stefano, > > On 22/06/2025 23:15, Stefano Stabellini wrote: > > On Thu, 19 Jun 2025, Oleksii Moisieiev wrote: > > > On 18/06/2025 02:22, Stefano Stabellini wrote: > > > > On Thu, 12 Jun 2025, Oleksii Moisieiev wrote: > > > > > [1]:https://git.iliana.fy

Re: [RFC PATCH v4 6/8] xen/arm: scmi: introduce SCI SCMI SMC multi-agent driver

2025-06-23 Thread Julien Grall
Hi Stefano, On 23/06/2025 20:27, Stefano Stabellini wrote: On Mon, 23 Jun 2025, Julien Grall wrote: Hi Stefano, On 22/06/2025 23:15, Stefano Stabellini wrote: On Thu, 19 Jun 2025, Oleksii Moisieiev wrote: On 18/06/2025 02:22, Stefano Stabellini wrote: On Thu, 12 Jun 2025, Oleksii Moisieiev

[PATCH v4] xen/console: introduce domain_console struct

2025-06-23 Thread dmkhn
From: Denis Mukhin Introduce domain_console for grouping data structures used for integrating domain's diagnostic console with Xen's console driver. Group all pbuf-related data structures under domain_console. Rename the moved fields to plain .buf, .idx and .lock names, since all uses of the fie

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-23 Thread Andrew Cooper
On 16/06/2025 7:27 am, Jan Beulich wrote: > To expand on my earlier suggestion (ab)using the "efi" global: With > the linker script having this > > #ifdef EFI > .reloc ALIGN(4) : { > __base_relocs_start = .; > *(.reloc) > __base_relocs_end = .; > } > #elif defined(XEN_BUILD_EFI) >

Re: hardware domain and control domain separation

2025-06-23 Thread Demi Marie Obenour
On 6/23/25 11:44, Jan Beulich wrote: > On 21.06.2025 02:41, Stefano Stabellini wrote: >> Regarding hardware domain and control domain separation, Ayan sent to >> xen-devel an architecture specification (a design document) that I wrote >> previously about the topic. This is written as safety documen

Re: [PATCH v1 6/6] [DO NOT MERGE] CI: example how to use ssh to extract logs

2025-06-23 Thread Marek Marczykowski-Górecki
On Mon, Jun 23, 2025 at 02:28:47PM -0400, Demi Marie Obenour wrote: > On 6/23/25 09:47, Marek Marczykowski-Górecki wrote: > > --- > > automation/scripts/qubes-x86-64.sh | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/automation/scripts/qubes-x86-64.sh > > b/automation/scripts/qu

[PATCH v10 0/3] xen/domain: domain ID allocation

2025-06-23 Thread dmkhn
Patch 1 introduces new domid_{alloc,free} calls. Patch 2 adjusts create_dom0() messages (use %pd). Patch 3 replaces open-coded domain ID 0 with get_initial_domain_id() where possible. Link to v9: https://lore.kernel.org/all/20250528225030.2652166-2-dmuk...@ford.com/ Link to CI: https://gitlab.co

[PATCH v10 1/3] xen/domain: unify domain ID allocation

2025-06-23 Thread dmkhn
From: Denis Mukhin Currently, there are two different domain ID allocation implementations: 1) Sequential IDs allocation in dom0less Arm code based on max_init_domid; 2) Sequential IDs allocation in XEN_DOMCTL_createdomain; does not use max_init_domid (both Arm and x86). The domain ID

Re: [PATCH v3] xen/console: introduce domain_console struct

2025-06-23 Thread Jan Beulich
On 23.06.2025 03:34, dm...@proton.me wrote: > @@ -769,22 +770,23 @@ static long > guest_console_write(XEN_GUEST_HANDLE_PARAM(char) buffer, > } while ( --kcount > 0 ); > > *kout = '\0'; > -spin_lock(&cd->pbuf_lock); > +spin_lock(&cons->lock); >

Re: hardware domain and control domain separation

2025-06-23 Thread Jan Beulich
On 21.06.2025 02:41, Stefano Stabellini wrote: > Regarding hardware domain and control domain separation, Ayan sent to > xen-devel an architecture specification (a design document) that I wrote > previously about the topic. This is written as safety document so it is > using a language and structur

Re: [PATCH v4 10/12] xen: Rename CONFIG_HAS_DEVICE_TREE to CONFIG_HAS_DEVICE_TREE_DISCOVERY

2025-06-23 Thread Alejandro Vallejo
On Mon Jun 23, 2025 at 4:26 PM CEST, Jan Beulich wrote: > On 23.06.2025 16:19, Alejandro Vallejo wrote: >> On Mon Jun 23, 2025 at 3:44 PM CEST, Jan Beulich wrote: >>> On 23.06.2025 15:11, Alejandro Vallejo wrote: On Mon Jun 23, 2025 at 9:39 AM CEST, Jan Beulich wrote: > On 20.06.2025 20:28

Re: [PATCH v2 01/17] xen/riscv: implement sbi_remote_hfence_gvma()

2025-06-23 Thread Oleksii Kurochko
On 6/23/25 4:39 PM, Jan Beulich wrote: On 23.06.2025 16:31, Oleksii Kurochko wrote: On 6/18/25 5:15 PM, Jan Beulich wrote: On 10.06.2025 15:05, Oleksii Kurochko wrote: Instruct the remote harts to execute one or more HFENCE.GVMA instructions, covering the range of guest physical addresses bet

Re: [PATCH v2 01/17] xen/riscv: implement sbi_remote_hfence_gvma()

2025-06-23 Thread Jan Beulich
On 23.06.2025 16:31, Oleksii Kurochko wrote: > On 6/18/25 5:15 PM, Jan Beulich wrote: >> On 10.06.2025 15:05, Oleksii Kurochko wrote: >>> Instruct the remote harts to execute one or more HFENCE.GVMA instructions, >>> covering the range of guest physical addresses between start_addr and >>> start_ad

Re: [PATCH v2 02/17] xen/riscv: introduce sbi_remote_hfence_gvma_vmid()

2025-06-23 Thread Oleksii Kurochko
On 6/18/25 5:20 PM, Jan Beulich wrote: On 10.06.2025 15:05, Oleksii Kurochko wrote: It instructs the remote harts to execute one or more HFENCE.GVMA instructions by making an SBI call, covering the range of guest physical addresses between start_addr and start_addr + size only for the given VMI

Re: [PATCH v2 01/17] xen/riscv: implement sbi_remote_hfence_gvma()

2025-06-23 Thread Oleksii Kurochko
On 6/18/25 5:15 PM, Jan Beulich wrote: On 10.06.2025 15:05, Oleksii Kurochko wrote: Instruct the remote harts to execute one or more HFENCE.GVMA instructions, covering the range of guest physical addresses between start_addr and start_addr + size for all the guests. Here and in the code commen

Re: [PATCH v4 10/12] xen: Rename CONFIG_HAS_DEVICE_TREE to CONFIG_HAS_DEVICE_TREE_DISCOVERY

2025-06-23 Thread Jan Beulich
On 23.06.2025 16:19, Alejandro Vallejo wrote: > On Mon Jun 23, 2025 at 3:44 PM CEST, Jan Beulich wrote: >> On 23.06.2025 15:11, Alejandro Vallejo wrote: >>> On Mon Jun 23, 2025 at 9:39 AM CEST, Jan Beulich wrote: On 20.06.2025 20:28, Alejandro Vallejo wrote: > Moving forward the idea is fo

Re: [PATCH v4 10/12] xen: Rename CONFIG_HAS_DEVICE_TREE to CONFIG_HAS_DEVICE_TREE_DISCOVERY

2025-06-23 Thread Alejandro Vallejo
On Mon Jun 23, 2025 at 3:44 PM CEST, Jan Beulich wrote: > On 23.06.2025 15:11, Alejandro Vallejo wrote: >> On Mon Jun 23, 2025 at 9:39 AM CEST, Jan Beulich wrote: >>> On 20.06.2025 20:28, Alejandro Vallejo wrote: Moving forward the idea is for there to be: 1. Basic DT support: used by d

Re: [PATCH test-artifacts v1 5/5] Setup ssh access to test systems

2025-06-23 Thread Marek Marczykowski-Górecki
On Mon, Jun 23, 2025 at 02:56:00PM +0100, Andrew Cooper wrote: > On 23/06/2025 2:46 pm, Marek Marczykowski-Górecki wrote: > > For this add also bridge package, so xenbr0 can be configured with > > /etc/network/interfaces. > > This allows extracting more logs out of the test system. > > > > Signed-o

Re: [PATCH test-artifacts v1 3/5] Include git in the ARM64 build container too

2025-06-23 Thread Andrew Cooper
On 23/06/2025 2:46 pm, Marek Marczykowski-Górecki wrote: > It will be used for fetching some Linux versions. > > Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper

Re: [PATCH test-artifacts v1 2/5] Enable CONFIG_USB_RTL8152 in kernel for hw12 runner

2025-06-23 Thread Andrew Cooper
On 23/06/2025 2:46 pm, Marek Marczykowski-Górecki wrote: > It uses this USB network interface. > > Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper

Re: [PATCH test-artifacts v1 1/5] Add linux-6.12.34-x86_64

2025-06-23 Thread Andrew Cooper
On 23/06/2025 2:46 pm, Marek Marczykowski-Górecki wrote: > This is necessary for new Zen4 runner. > Do not include Argo module in this build, as it isn't compatible with > 6.12 yet. > > Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper

Re: [PATCH test-artifacts v1 5/5] Setup ssh access to test systems

2025-06-23 Thread Andrew Cooper
On 23/06/2025 2:46 pm, Marek Marczykowski-Górecki wrote: > For this add also bridge package, so xenbr0 can be configured with > /etc/network/interfaces. > This allows extracting more logs out of the test system. > > Signed-off-by: Marek Marczykowski-Górecki > --- > This enables passwordless root l

[PATCH v1 6/6] [DO NOT MERGE] CI: example how to use ssh to extract logs

2025-06-23 Thread Marek Marczykowski-Górecki
--- automation/scripts/qubes-x86-64.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/automation/scripts/qubes-x86-64.sh b/automation/scripts/qubes-x86-64.sh index cf040a29856b..944d0c6d383f 100755 --- a/automation/scripts/qubes-x86-64.sh +++ b/automation/scripts/qubes-x86-64.sh @@ -292,6

[PATCH v1 2/6] CI: add AMD Zen 4 HW runner

2025-06-23 Thread Marek Marczykowski-Górecki
This is AMD Ryzen 5 7640U in Framework Laptop AMD. It has several things different than the other runners. First of all, the console is using XHCI debug capability. And then, this system doesn't have normal wired ethernet. But is has one on USB, and this one is used for booting. For this, enable CO

[PATCH v1 3/6] CI: upload tests-junit.xml as a normal artifact too

2025-06-23 Thread Marek Marczykowski-Górecki
This allows checking the file if gitlab can't parse it for some reason. Signed-off-by: Marek Marczykowski-Górecki --- automation/gitlab-ci/test.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index a9d871cf72ad..dc08488e76f

[PATCH v1 4/6] CI: make test-artifacts branch/job customizable

2025-06-23 Thread Marek Marczykowski-Górecki
Allow choosing which artifacts branch and job to use for Linux. This allows running the same tests for different Linux versions, without duplicating a lot of yaml sections. Signed-off-by: Marek Marczykowski-Górecki --- I have considered common LINUX_JOB and then add architecture suffix, but even

[PATCH v1 1/6] CI: Switch x86 tests to 6.12.34 kernel

2025-06-23 Thread Marek Marczykowski-Górecki
This is necessary for the upcoming Zen4 runner. Signed-off-by: Marek Marczykowski-Górecki --- Previous version posted in https://lore.kernel.org/xen-devel/cover.7da1777882774486a13e6f39ff4a2096f6b7901e.1744028549.git-series.marma...@invisiblethingslab.com/T/#u (but actual patch didn't make it i

[PATCH v1 5/6] CI: use Alpine's network setup

2025-06-23 Thread Marek Marczykowski-Górecki
This allows Alpine startup script to properly handle service dependencies - necessary for starting dropbear ssh server. For the latter, always take the IP address from DHCP, in addition to the test-local one. Signed-off-by: Marek Marczykowski-Górecki --- automation/scripts/qubes-x86-64.sh | 20 +

[PATCH v1 0/6] Add infrastructure for testing arbitrary Linux branch, and one more runner

2025-06-23 Thread Marek Marczykowski-Górecki
This series implements testing arbitrary Linux branch, based on pipeline variables. The idea is to setup schedule running a pipeline for few selected branches (some of the Linux stable branches? linux-next? Linus's master branch?) The SELECTED_JOBS_ONLY variable can be used to exclude most of the b

[PATCH test-artifacts v1 1/5] Add linux-6.12.34-x86_64

2025-06-23 Thread Marek Marczykowski-Górecki
This is necessary for new Zen4 runner. Do not include Argo module in this build, as it isn't compatible with 6.12 yet. Signed-off-by: Marek Marczykowski-Górecki --- .gitlab-ci.yml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index c698612..ad44fb4 100

[PATCH test-artifacts v1 4/5] Support building arbitrary Linux branch/tag/commit

2025-06-23 Thread Marek Marczykowski-Górecki
If LINUX_URL is set, fetch LINUX_VERSION from there. Go with "git init" + "git fetch" instead of "git clone" to support any of branch/tag/commit. This also defines optional linux-git-* jobs which will build the thing if LINUX_GIT_VERSION and LINUX_GIT_URL variables are provided for the pipeline.

[PATCH test-artifacts v1 2/5] Enable CONFIG_USB_RTL8152 in kernel for hw12 runner

2025-06-23 Thread Marek Marczykowski-Górecki
It uses this USB network interface. Signed-off-by: Marek Marczykowski-Górecki --- This was posted before at https://lore.kernel.org/xen-devel/20250411203336.585215-1-marma...@invisiblethingslab.com/ --- scripts/build-linux.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/build-lin

[PATCH test-artifacts v1 5/5] Setup ssh access to test systems

2025-06-23 Thread Marek Marczykowski-Górecki
For this add also bridge package, so xenbr0 can be configured with /etc/network/interfaces. This allows extracting more logs out of the test system. Signed-off-by: Marek Marczykowski-Górecki --- This enables passwordless root login. It's okay for qubes runners, as they are isolated (even from eac

[PATCH test-artifacts v1 3/5] Include git in the ARM64 build container too

2025-06-23 Thread Marek Marczykowski-Górecki
It will be used for fetching some Linux versions. Signed-off-by: Marek Marczykowski-Górecki --- images/alpine/3.18-arm64-build.dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/images/alpine/3.18-arm64-build.dockerfile b/images/alpine/3.18-arm64-build.dockerfile index 25a8dbd..3846

[PATCH test-artifacts v1 0/5] Changes for building arbitrary Linux branch and for hw12 runner

2025-06-23 Thread Marek Marczykowski-Górecki
This series is necessary for the other one sent in a moment. Technically, the last patch isn't strictly required, but it eases debugging. Green pipeline: https://gitlab.com/xen-project/people/marmarek/test-artifacts/-/pipelines/1881057399 Marek Marczykowski-Górecki (5): Add linux-6.12.34-x86_

Re: [PATCH v4 11/12] xen/dt: ifdef out DEV_DT-related bits from device_tree.{c,h}

2025-06-23 Thread Jan Beulich
On 23.06.2025 15:18, Alejandro Vallejo wrote: > On Mon Jun 23, 2025 at 9:44 AM CEST, Jan Beulich wrote: >> On 20.06.2025 20:28, Alejandro Vallejo wrote: >>> device-tree.c stops requiring CONFIG_HAS_DEVICE_TREE_DISCOVERY and may >>> function with DOM0LESS_BOOT. >>> >>> Without this, there's a clash

Re: [PATCH v4 10/12] xen: Rename CONFIG_HAS_DEVICE_TREE to CONFIG_HAS_DEVICE_TREE_DISCOVERY

2025-06-23 Thread Jan Beulich
On 23.06.2025 15:11, Alejandro Vallejo wrote: > On Mon Jun 23, 2025 at 9:39 AM CEST, Jan Beulich wrote: >> On 20.06.2025 20:28, Alejandro Vallejo wrote: >>> Moving forward the idea is for there to be: >>> 1. Basic DT support: used by dom0less/hyperlaunch. >>> 2. Full DT support: used for device

Re: [RFC PATCH 2/4] xen/arm: Move make_hypervisor_node()

2025-06-23 Thread Orzel, Michal
On 21/06/2025 17:11, Koichiro Den wrote: > Even though make_hypervisor_node() does not rely on the /reserved-memory > instantiation when calling find_unused_regions() (the wrapper introduced > in the previous commit), the next but one commit will use it for PV time Unless for specific reasons, y

Re: [RFC PATCH 1/4] xen/arm: Add wrapper find_unused_regions

2025-06-23 Thread Orzel, Michal
On 21/06/2025 17:11, Koichiro Den wrote: > This is preparatory work for the upcoming commits that implement the > standard PV time interface (ARM DEN 0057A). I personally don't find such messages useful. If at all, reasoning should be given first and then this message could appear. > > No func

Re: [PATCH v4 11/12] xen/dt: ifdef out DEV_DT-related bits from device_tree.{c,h}

2025-06-23 Thread Alejandro Vallejo
On Mon Jun 23, 2025 at 9:44 AM CEST, Jan Beulich wrote: > On 20.06.2025 20:28, Alejandro Vallejo wrote: >> device-tree.c stops requiring CONFIG_HAS_DEVICE_TREE_DISCOVERY and may >> function with DOM0LESS_BOOT. >> >> Without this, there's a clash with x86's definition of device_t. Because >> x86 do

Re: [PATCH v4 10/12] xen: Rename CONFIG_HAS_DEVICE_TREE to CONFIG_HAS_DEVICE_TREE_DISCOVERY

2025-06-23 Thread Alejandro Vallejo
On Mon Jun 23, 2025 at 9:39 AM CEST, Jan Beulich wrote: > On 20.06.2025 20:28, Alejandro Vallejo wrote: >> Moving forward the idea is for there to be: >> 1. Basic DT support: used by dom0less/hyperlaunch. >> 2. Full DT support: used for device discovery and HW setup. >> >> Rename HAS_DEVICE_TR

Re: xen_pciback: error enabling MSI-X / MSI for guest -- WAS: Re: Kernel panic when passing through 2 identical PCI devices

2025-06-23 Thread Jan Beulich
On 23.06.2025 13:10, J. Roeleveld wrote: > On Monday, 23 June 2025 09:55:46 CEST Jan Beulich wrote: >> On 21.06.2025 16:39, J. Roeleveld wrote: >>> I managed to get past the kernel panic (sort of) by doing the following: >>> >>> 1) Ensure system is fully OFF before booting. A reset/reboot will caus

Re: [PATCH] x86/svm: Revert 1->true conversion in svm_asid_handle_vmrun()

2025-06-23 Thread Jan Beulich
On 23.06.2025 12:51, Andrew Cooper wrote: > This is literally ASID 1, not a boolean configuration. > > Fixes: 2f09f797ba43 ("x86/svm: Drop the suffix _guest from vmcb bit") > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

Re: [PATCH v2 23/26] tests/functional: Restrict nexted Aarch64 Xen test to TCG

2025-06-23 Thread Philippe Mathieu-Daudé
On 23/6/25 13:59, Philippe Mathieu-Daudé wrote: On 23/6/25 10:11, Thomas Huth wrote: On 20/06/2025 15.07, Philippe Mathieu-Daudé wrote: On macOS this test fails:    qemu-system-aarch64: mach-virt: HVF does not support providing Virtualization extensions to the guest CPU Signed-off-by: Phili

Re: [PATCH v4 10/12] xen: Rename CONFIG_HAS_DEVICE_TREE to CONFIG_HAS_DEVICE_TREE_DISCOVERY

2025-06-23 Thread Jan Beulich
On 20.06.2025 20:28, Alejandro Vallejo wrote: > Moving forward the idea is for there to be: > 1. Basic DT support: used by dom0less/hyperlaunch. > 2. Full DT support: used for device discovery and HW setup. > > Rename HAS_DEVICE_TREE to HAS_DEVICE_TREE_DISCOVERY to describe (2), while > DOM0LE

Re: [PATCH v2 23/26] tests/functional: Restrict nexted Aarch64 Xen test to TCG

2025-06-23 Thread Philippe Mathieu-Daudé
On 23/6/25 10:11, Thomas Huth wrote: On 20/06/2025 15.07, Philippe Mathieu-Daudé wrote: On macOS this test fails:    qemu-system-aarch64: mach-virt: HVF does not support providing Virtualization extensions to the guest CPU Signed-off-by: Philippe Mathieu-Daudé ---   tests/functional/test_aa

Re: [RFC PATCH 4/4] xen/arm: Implement standard PV time interface as per ARM DEN 0057A

2025-06-23 Thread Julien Grall
Hi Stefano, On 23/06/2025 00:26, Stefano Stabellini wrote: On Sun, 22 Jun 2025, Koichiro Den wrote: > If so, then we should have a check here and return "not supported" for 32-bit callers. We already have a generic check to confirm 32-bit domain are not using the 64-bit convention. See [1]

Re: [PATCH v5] automation/eclair: update configuration of D4.10

2025-06-23 Thread Jan Beulich
On 22.06.2025 22:58, Stefano Stabellini wrote: > On Sun, 22 Jun 2025, Nicola Vetrini wrote: >> On 2025-06-21 04:19, Stefano Stabellini wrote: >>> --- a/xen/arch/x86/include/asm/cpufeatures.h >>> +++ b/xen/arch/x86/include/asm/cpufeatures.h >>> @@ -1,6 +1,6 @@ >>> -/* >>> - * Explicitly intended for

Re: [PATCH v4 01/12] CODING_STYLE: Custom type names must be snake-cased by word.

2025-06-23 Thread Jan Beulich
On 20.06.2025 20:28, Alejandro Vallejo wrote: > There's the unwritten convention in x86 of splitting type names using > underscores. Add such convention to the CODINNG_STYLE to make it > common and less unwritten. Just curious: How does x86 come into play here? Xen inherited this un- written rule

Re: [PATCH v4 10/12] xen: Rename CONFIG_HAS_DEVICE_TREE to CONFIG_HAS_DEVICE_TREE_DISCOVERY

2025-06-23 Thread Jan Beulich
On 23.06.2025 09:39, Jan Beulich wrote: > On 20.06.2025 20:28, Alejandro Vallejo wrote: >> Moving forward the idea is for there to be: >> 1. Basic DT support: used by dom0less/hyperlaunch. >> 2. Full DT support: used for device discovery and HW setup. >> >> Rename HAS_DEVICE_TREE to HAS_DEVICE_

Re: [PATCH v1] xen/domain: fix memory leak in domain_create()

2025-06-23 Thread Jan Beulich
On 23.06.2025 03:16, dm...@proton.me wrote: > From: Denis Mukhin > > Fix potential memory leak in domain_create() in late hardware domain case. > > Fixes: b959f3b820f5 ("xen: introduce hardware domain create flag") > Signed-off-by: Denis Mukhin Reviewed-by: Jan Beulich It may be relevant to

Re: [PATCH v4 01/12] CODING_STYLE: Custom type names must be snake-cased by word.

2025-06-23 Thread Alejandro Vallejo
On Mon Jun 23, 2025 at 9:31 AM CEST, Jan Beulich wrote: > On 20.06.2025 20:28, Alejandro Vallejo wrote: >> There's the unwritten convention in x86 of splitting type names using >> underscores. Add such convention to the CODINNG_STYLE to make it >> common and less unwritten. > > Just curious: How do

Re: [XEN PATCH] xen: fix header guard generation for asm-generic headers

2025-06-23 Thread Nicola Vetrini
On 2025-06-23 10:20, Jan Beulich wrote: On 23.06.2025 09:51, Jan Beulich wrote: On 21.06.2025 11:58, Nicola Vetrini wrote: Dashes were wrongly not translated into underscores, thus generating an unexpected guard identifier. Fixes: ee79f378311b ("xen: add header guards to generated asm generic

Re: xen_pciback: error enabling MSI-X / MSI for guest -- WAS: Re: Kernel panic when passing through 2 identical PCI devices

2025-06-23 Thread J. Roeleveld
On Monday, 23 June 2025 09:55:46 CEST Jan Beulich wrote: > On 21.06.2025 16:39, J. Roeleveld wrote: > > I managed to get past the kernel panic (sort of) by doing the following: > > > > 1) Ensure system is fully OFF before booting. A reset/reboot will cause > > these errors. > > > > 2) Fix the BIO

[PATCH] x86/svm: Revert 1->true conversion in svm_asid_handle_vmrun()

2025-06-23 Thread Andrew Cooper
This is literally ASID 1, not a boolean configuration. Fixes: 2f09f797ba43 ("x86/svm: Drop the suffix _guest from vmcb bit") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné --- xen/arch/x86/hvm/svm/asid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [RFC PATCH 4/4] xen/arm: Implement standard PV time interface as per ARM DEN 0057A

2025-06-23 Thread Stefano Stabellini
On Sun, 22 Jun 2025, Koichiro Den wrote: > The VCPUOP_register_runstate_memory_area hypercall is still actively > used, e.g., in the Linux arm64 codebase. When KPTI is enabled, the area > was not registered from the beginning due to the VA not always being > valid. In such cases, Linux falls back t

Re: [PATCH v4] automation/eclair: update configuration of D4.10

2025-06-23 Thread Jan Beulich
On 21.06.2025 04:19, Stefano Stabellini wrote: > On Tue, 10 Jun 2025, Jan Beulich wrote: >> On 06.06.2025 23:04, Stefano Stabellini wrote: >>> --- a/xen/arch/x86/include/asm/cpufeatures.h >>> +++ b/xen/arch/x86/include/asm/cpufeatures.h >>> @@ -1,6 +1,6 @@ >>> -/* >>> - * Explicitly intended for mu

Re: [RFC PATCH v4 6/8] xen/arm: scmi: introduce SCI SCMI SMC multi-agent driver

2025-06-23 Thread Stefano Stabellini
On Thu, 19 Jun 2025, Oleksii Moisieiev wrote: > On 18/06/2025 10:22, Julien Grall wrote: > > Hi, > > > > On 18/06/2025 00:38, Stefano Stabellini wrote: > >> On Thu, 12 Jun 2025, Grygorii Strashko wrote: > >>> On 02.06.25 10:17, Bertrand Marquis wrote: > > On the other hand, if we also want to h

Re: [RFC PATCH v4 6/8] xen/arm: scmi: introduce SCI SCMI SMC multi-agent driver

2025-06-23 Thread Julien Grall
Hi Stefano, On 22/06/2025 23:15, Stefano Stabellini wrote: On Thu, 19 Jun 2025, Oleksii Moisieiev wrote: On 18/06/2025 02:22, Stefano Stabellini wrote: On Thu, 12 Jun 2025, Oleksii Moisieiev wrote: [1]:https://git.iliana.fyi/linux/patch/?id=d5141f37c42e0b833863f157ac4cee203b2ba3d2 Keep in mi

Re: [MINI-OS PATCH 0/6] hide struct start_info from PVH code

2025-06-23 Thread Jan Beulich
On 19.06.2025 13:37, Juergen Gross wrote: > While working on xenstore-stubdom live update support I came across > some really unpleasant code using struct start_info even when running > in PVH mode. > > Especially suspend/resume was doing some crazy stuff, including > overwriting the initial struc

Re: [PATCH v1] xen: fusa: arch_specs: Definition of the Virtual Machines' roles

2025-06-23 Thread Yann Sionneau
Hi Ayan, Stefano, This doc looks nice overall! However I do think that maybe the role part should be separate from all the explanations about virtio. I would say virtio deserves its own page. Also, I'm curious what "FFI" is. Thanks! Regards, Yann On 3/4/25 19:31, Ayan Kumar Halder wrote: >

Re: [XEN PATCH] xen: fix header guard generation for asm-generic headers

2025-06-23 Thread Jan Beulich
On 21.06.2025 11:58, Nicola Vetrini wrote: > Dashes were wrongly not translated into underscores, thus generating > an unexpected guard identifier. > > Fixes: ee79f378311b ("xen: add header guards to generated asm generic > headers") > Signed-off-by: Nicola Vetrini > --- > xen/scripts/Makefile.

  1   2   >