justification commit message]
Signed-off-by: Andrii Anisov
---
xen/arch/arm/arm64/entry.S | 11 +--
xen/arch/arm/traps.c | 6 ++
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
index 97b05f5..8f28789 100644
--- a
From: Andrii Anisov
Avoid excessive conversions between pending_irq and irq number/priority.
This simlifies functions interface and reduces under locks code size.
Signed-off-by: Andrii Anisov
---
xen/arch/arm/gic-vgic.c| 10 +++---
xen/arch/arm/vgic-v3-its.c | 2 +-
xen/arch/arm
From: Andrii Anisov
An IRQ assigned to guest always has an action. This removes
another odd check on guest IRQ path. Also getting an unknown
interrupt is very unlikely on a non-debug platform.
Signed-off-by: Andrii Anisov
---
xen/arch/arm/irq.c | 14 +++---
1 file changed, 7
From: Andrii Anisov
For GICV2 pending_irq allocation is not concurrent, so reduce
some code under lock.
Signed-off-by: Andrii Anisov
---
xen/arch/arm/vgic.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index a64633f
From: Andrii Anisov
This reduces the number of context switches in case we have an
interrupt storm. We will read out all of those interrupt in the
loop anyway.
Signed-off-by: Andrii Anisov
---
xen/arch/arm/gic.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/xen/arch/arm/gic.c b/xen
From: Andrii Anisov
This action is excessive because for an invalid LR there is no need
to write another invalid value to a register. So we can skip it here,
saving a peripheral register access.
Signed-off-by: Andrii Anisov
---
xen/arch/arm/gic-vgic.c | 1 -
1 file changed, 1 deletion
From: Andrii Anisov
This reduces some code and conditions in an IRQ processing path,
and opens way to further code reduction.
Also insert compilation errors into gicv3 code, because it would
not compile or work with following patches.
Signed-off-by: Andrii Anisov
---
xen/arch/arm/configs
What is longer than catching the IRQ2 right away with IRQ1 in XEN itself.
We come to this idea after observing a strange effect: dropping a bit of
code from IRQ processing path (i.e. several if's) led to the benchmark
shown us a bit smaller numbers.
--
. I'll read it carefully.
--
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
ng a struct pending_irq to a linked
list or so.
It is clear. As we discussed internally, even making IRQ path shorter,
we may experience the benchmark results drop due to the fact that we are
doing more context switches from guest instead of collecting those
interrupt
hypervisor (e.g. moving them from gic
to vgic for guests IRQs) has a higher priority over any guest execution.
--
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hello Julien,
On 20.11.18 20:47, Julien Grall wrote:
On 20/11/2018 18:10, Andrii Anisov wrote:
Hello Julien,
On 19.11.18 18:42, Julien Grall wrote:
There are no issue about processing IRQs before the syncs. It is the
same as if an IRQ was raised from ila different pCPUs.
So why do you
tches.
--
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hello Julien,
It is me again.
On 15.11.18 17:05, Julien Grall wrote:
On 11/15/18 1:19 PM, Andrii Anisov wrote:
So I would prefer to stick with _t which is quite common within the p2m
code base so far.
I've found a similar code only in one place - p2m_get_entry()
function. And it i
ny HW specifics or it is SoC independent?
I would like to get more evidences for optimizations of gic/vgic/gic-v2
code I did for our customer (its about old vgic, we are still on xen 4.10).
--
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-
Hello Andre,
I'm going to change "gic_raise_guest_irq()" function interface.
Could you please comment my understanding of vgic-v3-its.c code below?
So that I could fix it alongside the function interface change.
On 16.11.18 18:45, Andrii Anisov wrote:
diff --git a/xen/a
I do that on behalf of you?
On 09.11.18 16:42, Andrii Anisov wrote:
Hello Julien,
I just wonder, do you plan to upstream the patch below?
Andrii Anisov
commit 11e360b93be81a58a41832d714f33f797ad312a9
Author: Julien Grall
Date: Mon Oct 29 13:32:56 2018 +
xen/arm: Re-enable
ority in
`gic_raise_guest_irq`, he can freely extract it from a pending_irq
structure. It is still there.
--
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
W_VGIC` must be enough here.
Those two functions are not used by, nor defined by new-vgic.
--
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
From: Andrii Anisov
Avoid excessive conversions between pending_irq and irq number/priority.
This simlifies functions interface and reduces under locks code size.
Signed-off-by: Andrii Anisov
---
xen/arch/arm/gic-vgic.c| 10 +++---
xen/arch/arm/vgic-v3-its.c | 2 +-
xen/arch/arm
From: Andrii Anisov
Signed-off-by: Andrii Anisov
---
xen/arch/arm/irq.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
index d5ad277..d6a0273 100644
--- a/xen/arch/arm/irq.c
+++ b/xen/arch/arm/irq.c
@@ -61,7 +61,9
From: Andrii Anisov
Signed-off-by: Andrii Anisov
---
xen/arch/arm/irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
index 098281f..d5ad277 100644
--- a/xen/arch/arm/irq.c
+++ b/xen/arch/arm/irq.c
@@ -224,7 +224,7 @@ void do_IRQ
tor usage.
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
because this is a matter of taste.
I would not say it is a request. I'm just saying that I personally do
not like that code, it confuses me, so I can't pass RB for it. Sorry
for that :(
I really hope someone else can come up with RB for it.
Sincerely,
Andrii Anisov.
__
Reviewed-by: Andrii Anisov
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by: Andrii Anisov
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Sorry,
Not "comparingly complex", but "equally complex". ;)
Sincerely,
Andrii Anisov.
чт, 15 лист. 2018 о 15:31 Andrii Anisov пише:
>
> Hello Julien,
>
> вт, 6 лист. 2018 о 21:16 Julien Grall пише:
> >
> > In a follow-up patches, we will need to
both of those functions inline or non-inline)
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
y, but I can't pass my RB for `_t`.
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
nuse.type_info & PGT_writable_page ) ? p2m_ram_rw
: p2m_ram_ro;
.
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hello Julien,
I'm not sure why do you need this patch to be separated from "[PATCH
4/8] xen/arm: Add support for read-only foreign mappings".
But I would not argue for that.
Reviewed-by: Andrii Anisov
Sincerely,
Andrii Anisov.
__
he code harder to understand than simple checking `t` for nul
before assigning it a
value.
Sincerely,
Andrii Anisov.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
> What's wrong with including clean-up patch in a series adding a feature?
I do not mean it is wrong.
Just assuming that introducing a new feature and cleaning up a code
might be different processes with a different review period.
Sincerely,
Andri
Hello Julien,
I'm just wondering if this patch really belongs to xentrace series.
It rather looks like a separate cleanup patch.
Sincerely,
Andrii Anisov.
вт, 6 лист. 2018 о 21:16 Julien Grall пише:
> No functional change intended.
>
> Only reasonable clean-ups are done in t
Hello Julien,
I just wonder, do you plan to upstream the patch below?
Andrii Anisov
On 29/10/2018 10:06, Andrii Anisov wrote:
> Hello Julien,
Hi,
>
> Sorry for the previous email sent as html.
Don't worry. I didn't notice it :).
>
>
> On 27.10.18 15:14, An
Reviewed-by: Andrii Anisov
ANDRII ANISOV
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hello Julien,
Reviewed-by: Andrii Anisov
ps. please reach me by my gmail andrii.ani...@gmail.com further, rather than
epam's email.
Our infra enabled 2-factor auth, and I didn't manage to make thunderbird
functional any more. And outlook's web interface is nearly unusable.
the same way
> everywhere so less trouble to figure out problem.
Good point.
Actually I was confused by the reported behavior, because I overlooked
those msr's with different arguments in entry.S and assumed
enter_hypervisor_head() always runs with irqs disabled.
gs);
+local_irq_enable();
__do_trap_serror(regs, true);
}
--
Andrii Anisov
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
from hyp,
we do not massage gic in enter_hypervisor_head.
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hello Julien,
Sorry for the previous email sent as html.
On 27.10.18 15:14, Andrii Anisov wrote:
>>> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
>>> index f6f6de3..985192b 100644
>>> --- a/xen/arch/arm/traps.c
>>> +++ b/xen/arch/arm/traps.c
&
Hello Julien,
On 10/27/2018 12:55 AM, Julien Grall wrote:
The functions below does not exist in latest Xen. So are you sure this based on
mainline?
Yep, I've put a wrong diff into the email, it is for XEN 4.10.
Please find the patch for XEN 4.12-unstable on my github [1].
How many domain do you
Hello Julien
On 25.10.18 17:11, Andrii Anisov wrote:
> I guess I should make a dedicated patch applicable to mainline to reveal
> the issue. I hope I'll do this nearest days.
Please find below the diff applicable to the current xenbits/smoke which
exposes the issue.
With that dif
On 18.10.18 16:20, Julien Grall wrote:
> do_unexpected_traps() is moved to traps.h while init_traps() and
> hyp_traps_vectors() are moved to setup.h.
>
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
On 18.10.18 16:21, Julien Grall wrote:
> None of the platforms are using the p2m helpers.
>
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproje
On 18.10.18 16:21, Julien Grall wrote:
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 18.10.18 16:21, Julien Grall wrote:
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 18.10.18 16:21, Julien Grall wrote:
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 18.10.18 16:21, Julien Grall wrote:
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 18.10.18 16:21, Julien Grall wrote:
> Also, include smccc.h instead of psci.h.
>
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproje
On 18.10.18 16:21, Julien Grall wrote:
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
ing the interrupt handler.
>
> Based on Linux commit 39a06b67c2c1256bcf2361a1f67d2529f70ab206
> "irqchip/gic: Ensure we have an ISB between ack and ->handle_irq".
>
> Signed-off-by: Julien Grall
>
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
) and do_IRQ().
>
> This ensure the system registers are synchronized after you
> acknowledge an interrupt.
I see.
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 18.10.18 16:21, Julien Grall wrote:
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 18.10.18 16:21, Julien Grall wrote:
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 18.10.18 16:20, Julien Grall wrote:
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
>
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 18.10.18 16:20, Julien Grall wrote:
> The HSR defines are pretty much self-contained and not necessary to be
> included everywhere in Xen. So move them in a new header hsr.h.
>
> Signed-off-by: Julien Grall
Reviewed-by: Andrii Anisov
--
*A
On 18.10.18 16:21, Julien Grall wrote:
> Keep vgic_* helpers in a single place. At the same time remove gic.h
> from event.h since the helpers has now been moved to vgic.h (included by
> domain.h).
>
> Signed-off-by: Julien Grall
Reviewed-by: Andrii Anisov
--
On 18.10.18 16:20, Julien Grall wrote:
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 18.10.18 16:20, Julien Grall wrote:
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 18.10.18 16:20, Julien Grall wrote:
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 18.10.18 16:20, Julien Grall wrote:
> The macro VABORT_GEN_BY_GUEST is only used by the trap code. So move it
> to trap.h.
>
> While moving the code, convert is to a static inline to allow typecheck.
>
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anisov
On 18.10.18 16:20, Julien Grall wrote:
> At the moment, CPU Identification is spread accross cpu.c, cpufeature.c,
> processor.h, cpufeature.h. It would be better to keep everything
> together in a single place.
>
> Signed-off-by: Julien Grall
> ---
Reviewed-by: Andrii Anis
0644
>>> --- a/xen/arch/arm/gic.c
>>> +++ b/xen/arch/arm/gic.c
>>> @@ -388,12 +388,14 @@ void gic_interrupt(struct cpu_user_regs *regs,
>>> int is_fiq)
>>>if ( likely(irq >= 16 && irq < 1020) )
>>>{
>>>local_irq_ena
feel some oddness in that.
Anyway,
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
commit f86c4fbd930ff6fecf3d8a1c313182bd0f49f496
> "irqchip/gic: Ensure ordering between read of INTACK and shared data".
>
> Signed-off-by: Julien Grall
>
> ---
> This patch is candidate for backporting up to Xen 4.9.
> ---
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
l
> ---
> xen/arch/arm/arm32/traps.c | 1 +
> xen/include/asm-arm/bug.h | 4
> xen/include/asm-arm/time.h | 2 ++
> xen/include/asm-arm/traps.h | 2 ++
> 4 files changed, 5 insertions(+), 4 deletions(-)
Reviewed-
luded on some c
> files. Also, add __init where it was missing in declaration.
>
> Signed-off-by: Julien Grall
A file xen/include/asm-arm/iommu.h also has prototypes with `__init`,
but missed in your patch.
--
*Andrii Anisov*
___
Xen-deve
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
-
> 2 files changed, 8 insertions(+), 8 deletions(-)
The file xen/arch/arm/traps.c has a bunch of show functions except for
registers. For stack, trace, etc. So maybe constify their parameters
right away?
--
*Andrii Anisov*
___
Xen-deve
> -*/
> -dsb(sy);
> gic_hw_ops->send_SGI(sgi, SGI_TARGET_SELF, NULL);
> }
>
> @@ -331,12 +319,6 @@ void send_SGI_allbutself(enum gic_sgi sgi)
> {
> ASSERT(sgi < 16); /* There are only 16 SGIs */
>
> - /*
> -* Ensure th
I would say the comment was odd, not duplicated, at the place it is removed.
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
isb() there.
> do_IRQ(regs, irq, is_fiq);
> local_irq_disable();
> }
> else if ( is_lpi(irq) )
> {
> local_irq_enable();
> +isb();
> gic_hw_ops->do_LPI(irq);
> local_irq_disable();
> }
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hello Julien,
On 23.10.18 16:26, Julien Grall wrote:
> The common headers (e.g xen/) should be placed before architecture
> specific (asm/). They should then be ordered alphabetically among
> themselves.
Yep, I see the point.
--
*Andr
Hello Julien,
In case you are ordering those includes in the alphabetical order,
shouldn't be `asm/...` includes placed above `xen/...`?
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenprojec
n allows the user not to build other unnecessary platform code.
>
> Signed-off-by: Stefano Stabellini
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hello Stefano,
On 25.09.18 01:55, Stefano Stabellini wrote:
> Add a Kconfig option to select no specific platform support.
>
> Signed-off-by: Stefano Stabellini
Reviewed-by: Andrii Anisov
--
*Andrii Anisov*
___
Xen-devel mailing list
On 12.09.18 20:27, Dario Faggioli wrote:
On Wed, 2018-09-12 at 17:47 +0300, Andrii Anisov wrote:
From: Andrii Anisov
The structure member last_run_time is used by credit scheduler only.
So move it from a generic vcpu sctructure to the credit scheduler
private
vcpu definition.
Signed-off-by
et in us.
I do not think it worth to add more zeros to those parameters for
converting them to ns.
IMHO trimming timestamps from ns would not be accepted, as well.
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenpr
are very little about what its functionality ends up being.
Anyway, thank you for your review.
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hello Andrew,
On 11.09.18 18:38, Andrew Cooper wrote:
Acked-by: Andrew Cooper
Thank you.
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
From: Andrii Anisov
For different keyhandlers, replace a hex with delimiter representation
of time to PRI_stime which is decimal ns currently.
Signed-off-by: Andrii Anisov
---
Changes in v3:
- patch a missed dump_domains() keyhandler
Changes in v2:
- Time representation change
On 12.09.18 19:47, Dario Faggioli wrote:
Right. But am I missing something, or you forgot dump_domains() in
xen/common/keyhandler.c ?
You are OK. I've missed it :(
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenprojec
o recompile anything, via the formats file, which is
rather cool. :-)
+1
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
From: Andrii Anisov
For different keyhandlers, replace a hex with delimiter representation
of time to PRI_stime which is decimal ns currently.
Signed-off-by: Andrii Anisov
---
Changes in v2:
- Time representation change propagated to all keyhandlers as agreed here
[1]
- Title and
From: Andrii Anisov
The structure member last_run_time is used by credit scheduler only.
So move it from a generic vcpu sctructure to the credit scheduler private
vcpu definition.
Signed-off-by: Andrii Anisov
---
Changes in v2:
- last_run_time type changed to s_time_t
- scurr changed
Hello Dario,
On 12.09.18 11:14, Dario Faggioli wrote:
I think that, while we're doing this, we should take the chance to
convert the type to s_time_t too.
Good point, as well as renaming scurr.
--
*Andrii Anisov*
___
Xen-devel mailing lis
From: Andrii Anisov
Signed-off-by: Andrii Anisov
---
xen/arch/arm/traps.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 9ae64ae..7bfdda8 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
From: Andrii Anisov
Signed-off-by: Andrii Anisov
---
xen/common/domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 78c450e..aec10a7 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -155,7 +155,7 @@ struct
formula in
xentrace_format, but changing `%(tsc)d` to `%(tsc).9f` in formats.
BTW, I've just noticed, that reltsc is allways in cycles. And it seems
odd, as well.
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenpr
On 11.09.18 12:49, Andrii Anisov wrote:
On 11.09.18 12:30, Jan Beulich wrote:
Should we think about replacing PRI_stime?
Why not, but that would require adding another %p suffix or
introducing a construct splitting s_time_t values into two pieces
(to be used to hide the two printk() arguments req
Hello George,
On 11.09.18 13:48, George Dunlap wrote:
I like the idea; but what does 'LE' mean in this context?
Little endian. Most significant 32bit word is at a higher index in the
array.
--
*Andrii Anisov*
___
Xen-devel mailin
From: Andrii Anisov
Signed-off-by: Andrii Anisov
---
xen/common/domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 78c450e..aec10a7 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -155,7 +155,7 @@ struct
necessary. The scripts
add_maintainers.pl will make sure the xen-devel will be on the to.
I'll try it with the next nit.
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
ble();
- if (!softirq_pending(smp_processor_id())) {
+ if (!softirq_pending(smp_processor_id()))
Same here.
Yep.
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
uld be made on the xen-devel@lists.xenproject.org
L: xen-devel@lists.xenproject.org
L: xen-devel@lists.xenproject.org
L: xen-devel@lists.xenproject.org
L: xen-devel@lists.xenproject.org
--
*Andrii Anisov*
___
Xen-
27;s going on.
From other hand I'm quite confused about how useful timestamps in
seconds could be for traces. As per my understanding, tracer should be
useful for debugging some rapidly changing processes.
--
*Andrii Anisov*
___
Xen-devel m
On 11.09.18 12:33, Jan Beulich wrote:
Well, what should I say - I disagree. I would agree if it would be a
whole lot of work, but there's not that many key handlers to begin
with, and far not all of them print a time stamp in their headlines.
I'm quite ok with that.
--
*And
tting s_time_i is reasonable.
Introducing %pt for ns granularity and %pT for ms could be an option.
--
*Andrii Anisov*
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
401 - 500 of 565 matches
Mail list logo
