Re: [Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

On 03/13/2018 01:27 AM, Juergen Gross wrote: On 12/03/18 20:26, Sander Eikelenboom wrote: Hi Juergen, I don't know by which tree those patches should arrive at Linus, so i can't check if they fell through the cracks somewhere, but 4.16-rc5 hasn't got them yet. They are queued for 4.17 in:

Re: [Xen-devel] Regression with commit "x86/pv: Drop int80_bounce from struct pv_vcpu" f75b1a5247b3b311d3aa50de4c0e5f2d68085cb1

On 03/12/2018 03:05 PM, Andrew Cooper wrote: > On 10/03/18 16:27, Andrew Cooper wrote: >> On 10/03/2018 16:14, Sander Eikelenboom wrote: >>> Hi Andrew, >>> >>> It seems commit "x86/pv: Drop int80_bounce from struct pv_vcpu" >>> (f75b1a5247b3b311d3aa50de4c0e5f2d68085cb1) causes an issue on my

Re: [Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

, Jan 24, 2018 at 3:20 PM, Juergen Gross <jgr...@suse.com> wrote: >>>>>> On 24/01/18 16:07, George Dunlap wrote: >>>>>>> On Wed, Jan 24, 2018 at 2:10 PM, Boris Ostrovsky >>>>>>> <boris.ostrov...@oracle.com> wrote: >>>>>

Re: [Xen-devel] [RFC PATCH 0/5] x86: Multiple fixes to MSR_TSC_AUX and RDTSCP handling for guests

On 03/09/2018 01:41 PM, Andrew Cooper wrote: On 09/03/2018 18:05, Boris Ostrovsky wrote: On 02/26/2018 06:30 PM, Andrew Cooper wrote: On 26/02/2018 19:44, Boris Ostrovsky wrote: On 02/26/2018 02:12 PM, Andrew Cooper wrote: On 20/02/18 11:58, Andrew Cooper wrote: This rats nest

Re: [Xen-devel] [RFC PATCH 0/5] x86: Multiple fixes to MSR_TSC_AUX and RDTSCP handling for guests

On 02/26/2018 06:30 PM, Andrew Cooper wrote: On 26/02/2018 19:44, Boris Ostrovsky wrote: On 02/26/2018 02:12 PM, Andrew Cooper wrote: On 20/02/18 11:58, Andrew Cooper wrote: This rats nest was discovered when finding that MSR_TSC_AUX leaked into PV guests. It is RFC because I haven't done

Re: [Xen-devel] [PATCH v2] xen/acpi: upload _PSD info for non Dom0 CPUs too

On 03/08/2018 05:57 AM, Joao Martins wrote: @@ -372,6 +376,15 @@ read_acpi_id(acpi_handle handle, u32 lvl, void *context, void **rv) pr_debug("ACPI CPU%u w/ PBLK:0x%lx\n", acpi_id, (unsigned long)pblk); + /* It has P-state dependencies */ + if (!acpi_processor_get_psd(handle,

Re: [Xen-devel] [PATCH v1] xen: acpi: upload _PSD info for offline CPUs too

On 03/06/2018 03:12 PM, Joao Martins wrote: > All uploaded PM data from offline CPUs takes the info from vCPU 0 and "offline" may not be the right term here. Maybe "non-dom0"? > changing only the acpi_id. For processors which P-state coordination type > is HW_ALL (0xFD) it is OK to upload bogus

Re: [Xen-devel] [RFC PATCH v4 2/7] xen/pvh: Move PVH entry code out of Xen specific tree

On 03/01/2018 03:46 AM, Paolo Bonzini wrote: > On 01/03/2018 07:11, Juergen Gross wrote: >>> Probably a better place for these would be >>> arch/x86/platform/pvh/{enlighten.c,head.S}. (Just because there are no >>> .c or .S files in arch/x86). >> Right. >> >>> Maybe Xen ought to be moved under

Re: [Xen-devel] [RFC PATCH v4 4/7] xen/pvh: Move Xen specific PVH VM initialization out of common code

On 02/28/2018 01:28 PM, Maran Wilson wrote: > We need to refactor PVH entry code so that support for other hypervisors > like Qemu/KVM can be added more easily. > > This patch moves the small block of code used for initializing Xen PVH > virtual machines into the Xen specific file. This

Re: [Xen-devel] [RFC PATCH v4 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH

On 02/28/2018 01:27 PM, Maran Wilson wrote: > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index eb7f43f23521..fa7cd0305125 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -791,6 +791,14 @@ config KVM_GUEST > underlying device model, the host provides the guest with >

Re: [Xen-devel] [PATCH v2] pvcalls-front: 64-bit align flags

-bit aligned. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 8/9] drm/xen-front: Implement GEM operations

On 02/27/2018 01:52 AM, Oleksandr Andrushchenko wrote: > On 02/27/2018 01:47 AM, Boris Ostrovsky wrote: >> On 02/23/2018 10:35 AM, Oleksandr Andrushchenko wrote: >>> On 02/23/2018 05:26 PM, Boris Ostrovsky wrote: >>>> On 02/21/2018 03:03 AM, Oleksandr Andrushchenk

Re: [Xen-devel] [ATTN SVM maintainers] Re: [PATCH V6] x86/hvm: fix domain crash when CR3 has the noflush bit set

Beulich <jbeul...@suse.com> >> Reviewed-by: Kevin Tian <kevin.t...@intel.com> >> Acked-by: George Dunlap <george.dun...@citrix.com> > Boris / Suvaree, any opinions on the SVM changes? > Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen-netfront: Fix hang on device removal

> > Signed-off-by: Jason Andryuk <jandr...@gmail.com> > Cc: Eduardo Otubo <ot...@redhat.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/pirq: fix error path cleanup when binding MSIs

892c9b4ada9f9 ("xen: add support for MSI message groups") >> Reported-by: Hooman Mirhadi <mirha...@amazon.com> >> Signed-off-by: Roger Pau Monné <roger@citrix.com> >> --- >> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> >> Cc: Juergen

Re: [Xen-devel] [PATCH] pvcalls-front: 64-bit align flags

On 02/27/2018 04:32 PM, Stefano Stabellini wrote: > On Tue, 27 Feb 2018, Boris Ostrovsky wrote: >> On 02/27/2018 02:54 PM, Stefano Stabellini wrote: >>> We are using test_and_* operations on the status and flag fields of >>> struct sock_mapping. However, these fu

Re: [Xen-devel] [PATCH] pvcalls-front: 64-bit align flags

On 02/27/2018 02:54 PM, Stefano Stabellini wrote: > We are using test_and_* operations on the status and flag fields of > struct sock_mapping. However, these functions require the operand to be > 64-bit aligned on arm64. Currently, only status is 64-bit aligned. > > Make flags 64-bit aligned by

Re: [Xen-devel] [PATCH v2] x86/xen: add tty0 and hvc0 as preferred consoles for dom0

use.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/HVM: don't give the wrong impression of WRMSR succeeding

On 02/27/2018 03:39 AM, Jan Beulich wrote: On 23.02.18 at 08:55, wrote: > On 22.02.18 at 23:16, wrote: >>> On 02/22/2018 10:44 AM, Jan Beulich wrote: >>> On 22.02.18 at 15:53, wrote: > On 22/02/18 13:44,

Re: [Xen-devel] [PATCH 8/9] drm/xen-front: Implement GEM operations

On 02/23/2018 10:35 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 05:26 PM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> +static struct xen_gem_object *gem_create(struct drm_device *dev, >>> size_t size) >>> +{ &g

Re: [Xen-devel] [PATCH 1/2] xen: fix out-of-bounds irq unbind for MSI message groups

Reported-by: Hooman Mirhadi <mirha...@amazon.com> > CC: <sta...@vger.kernel.org> > CC: Roger Pau Monné <roger@citrix.com> > CC: David Vrabel <david.vra...@citrix.com> > CC: Boris Ostrovsky <boris.ostrov...@oracle.com> > CC: Eduardo Valentin <edu..

Re: [Xen-devel] [PATCH 2/5] x86/pv: Avoid leaking other guests' MSR_TSC_AUX values into PV context

t; > CC: Jun Nakajima <jun.nakaj...@intel.com> > CC: Kevin Tian <kevin.t...@intel.com> > CC: Boris Ostrovsky <boris.ostrov...@oracle.com> > CC: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Roger Pau

Re: [Xen-devel] [RFC PATCH 0/5] x86: Multiple fixes to MSR_TSC_AUX and RDTSCP handling for guests

On 02/26/2018 02:12 PM, Andrew Cooper wrote: > On 20/02/18 11:58, Andrew Cooper wrote: >> This rats nest was discovered when finding that MSR_TSC_AUX leaked into PV >> guests. It is RFC because I haven't done extensive testing on the result, >> and >> because there are some functional changes

Re: [Xen-devel] [PATCH 3/6] x86: Handle the Xen MSRs via the new guest_{rd, wr}msr() infrastructure

akajima <jun.nakaj...@intel.com> > CC: Paul Durrant <paul.durr...@citrix.com> > CC: Kevin Tian <kevin.t...@intel.com> > CC: Boris Ostrovsky <boris.ostrov...@oracle.com> > CC: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> > CC: Wei Liu &l

Re: [Xen-devel] [PATCH 2/6] x86/hvm: Handle viridian MSRs via the new guest_{rd, wr}msr() infrastructure

h <jbeul...@suse.com> > CC: Jun Nakajima <jun.nakaj...@intel.com> > CC: Paul Durrant <paul.durr...@citrix.com> > CC: Kevin Tian <kevin.t...@intel.com> > CC: Boris Ostrovsky <boris.ostrov...@oracle.com> > CC: Suravee Suthikulpanit <suravee.suthikulpa.

Re: [Xen-devel] [PATCH] xen: use hvc console for dom0

On 02/26/2018 06:08 AM, Juergen Gross wrote: > Today the hvc console is added as a preferred console for pv domUs > only. As this requires a boot parameter for getting dom0 messages per > default add it for dom0, too. > > Signed-off-by: Juergen Gross > --- >

Re: [Xen-devel] [PATCH 8/9] drm/xen-front: Implement GEM operations

On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > +static struct xen_gem_object *gem_create(struct drm_device *dev, size_t size) > +{ > + struct xen_drm_front_drm_info *drm_info = dev->dev_private; > + struct xen_gem_object *xen_obj; > + int ret; > + > + size =

Re: [Xen-devel] [PATCH 6/9] drm/xen-front: Introduce DRM/KMS virtual display driver

On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > + > +struct drm_driver xen_drm_driver = { > + .driver_features = DRIVER_GEM | DRIVER_MODESET | > + DRIVER_PRIME | DRIVER_ATOMIC, > + .lastclose = lastclose, > +

Re: [Xen-devel] [PATCH v3] hvm/svm: Implement CPUID events

gt; Changes since V2: > - Pass the inst_len to svm_vmexit_do_cpuid() > > Signed-off-by: Alexandru Isaila <aisa...@bitdefender.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> ___ Xen-devel mail

Re: [Xen-devel] [PATCH 4/9] drm/xen-front: Implement Xen event channel handling

On 02/23/2018 02:00 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 01:50 AM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> + >>> +static irqreturn_t evtchnl_interrupt_ctrl(int irq, void *dev_id) >>> +{ >>&g

Re: [Xen-devel] [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver

On 02/23/2018 01:37 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 12:23 AM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> +static struct xenbus_driver xen_driver = { >>> +.ids = xen_drv_ids, >>> +.pro

Re: [Xen-devel] [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

On 02/23/2018 02:53 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 02:25 AM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> static int __init xen_drv_init(void) >>> { >>> +/* At the moment we only support case

Re: [Xen-devel] [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > > static int __init xen_drv_init(void) > { > + /* At the moment we only support case with XEN_PAGE_SIZE == PAGE_SIZE */ > + BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE); Why BUILD_BUG_ON? This should simply not load if page sizes

Re: [Xen-devel] [PATCH 4/9] drm/xen-front: Implement Xen event channel handling

On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > + > +static irqreturn_t evtchnl_interrupt_ctrl(int irq, void *dev_id) > +{ > + struct xen_drm_front_evtchnl *evtchnl = dev_id; > + struct xen_drm_front_info *front_info = evtchnl->front_info; > + struct xendispl_resp *resp; > +

Re: [Xen-devel] [PATCH 3/9] drm/xen-front: Read driver configuration from Xen store

On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > + > +static int cfg_connector(struct xen_drm_front_info *front_info, > + struct xen_drm_front_cfg_connector *connector, > + const char *path, int index) > +{ > + char *connector_path; > + > + connector_path =

Re: [Xen-devel] [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver

On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > +static struct xenbus_driver xen_driver = { > + .ids = xen_drv_ids, > + .probe = xen_drv_probe, > + .remove = xen_drv_remove, > + .otherend_changed = backend_on_changed, What does "_on_" stand for? -boris

Re: [Xen-devel] [PATCH] x86/HVM: don't give the wrong impression of WRMSR succeeding

On 02/22/2018 10:44 AM, Jan Beulich wrote: On 22.02.18 at 15:53, wrote: >> On 22/02/18 13:44, Jan Beulich wrote: >>> ... for unknown MSRs: wrmsr_hypervisor_regs()'s comment clearly says >>> that the function returns 0 for unrecognized MSRs, so >>>

Re: [Xen-devel] [PATCH v2] hvm/svm: Implement CPUID events

On 02/21/2018 05:18 AM, Alexandru Isaila wrote: > At this moment the CPUID events for the AMD architecture are not > forwarded to the monitor layer. > > This patch adds the CPUID event to the common capabilities and then > forwards the event to the monitor layer. > > --- > Changes since V1: >

Re: [Xen-devel] [PATCH] x86/HVM: don't give the wrong impression of WRMSR succeeding

13e34f5a6 ("x86: handle paged gfn in > wrmsr_hypervisor_regs") was probably okay, since prior to that the > return value wasn't checked at all. But that's not how we want things > to be handled nowadays. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-b

Re: [Xen-devel] [PATCH 0/2] x86/svm: add pause filtering threshold for SVM

vm/svm.h | 5 - > xen/include/asm-x86/hvm/svm/vmcb.h | 3 ++- > 4 files changed, 10 insertions(+), 2 deletions(-) > IIRC previous count value (3000) was somewhat arbitrary so Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> ___

Re: [Xen-devel] [PATCH v4 16/16] xen: Convert page_to_mfn and mfn_to_page to use typesafe MFN

n that > most of the callers are now switched to _mfn(domain_page_to_mfn(...)). > > Signed-off-by: Julien Grall <julien.gr...@arm.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> ___ Xen-devel mailing list Xen-devel@

Re: [Xen-devel] [PATCH v3 1/2] x86/hvm: introduce cr{0, 4}_host_mask to store trapped bits of CR accesses

On 02/21/2018 03:27 AM, Roger Pau Monné wrote: > On Tue, Feb 20, 2018 at 07:23:44PM -0500, Boris Ostrovsky wrote: >> On 02/20/2018 03:56 AM, Roger Pau Monne wrote: >>> At the moment this is currently set at VMC{S/B} creation and not changed, >>> but further patches are g

Re: [Xen-devel] [PATCH v2 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD

On 02/20/2018 05:00 PM, Brian Woods wrote: > I've seen patch 1 and 3 are in but this one isn't. Any status on it? > That's possibly because you needed an SVM maintainer ACK. I think Jan was waiting for decision on how to present the ASSERT. From the 3 options I slightly more prefer

Re: [Xen-devel] [PATCH v4 0/4] hvm/svm: Enable vm events for SVM

On 02/15/2018 05:22 AM, Alexandru Isaila wrote: > Hi all, > > This series provides a skeleton for enabling vm_events on SVM. For the > first step, the MSR, CR, Breakpoint and GuestRequest have been tested > and added to the capabilities list. > Reviewed-by: Boris Ostro

Re: [Xen-devel] [PATCH v2 1/4] asm-x86/monitor: Enable svm monitor events

On 02/08/2018 10:25 AM, Alexandru Isaila wrote: This commit separates the svm caps from the vmx caps. Signed-off-by: Alexandru Isaila --- Changes since V1: - Removed the if ( cpu_has_svm ) --- xen/include/asm-x86/monitor.h | 34

Re: [Xen-devel] [PATCH v2 3/4] hvm/svm: Enable MSR events

On 02/08/2018 10:25 AM, Alexandru Isaila wrote: This commit enables MSR events for svm. Signed-off-by: Alexandru Isaila <aisa...@bitdefender.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH 2/2] xen: xenbus: WARN_ON XS_TRANSACTION_{START, END} misuse

On 02/10/2018 08:27 PM, Simon Gaiser wrote: Boris Ostrovsky: On 02/07/2018 05:22 PM, Simon Gaiser wrote: +users_old = xs_state_users; xs_state_users--; if ((req->type == XS_TRANSACTION_START && req->msg.type == XS_ERROR) || req->type == X

Re: [Xen-devel] [PATCH v2 3/4] hvm/svm: Enable MSR events

(Resending too. Something was wrong with my client) On 02/10/2018 11:33 AM, Boris Ostrovsky wrote: On 02/08/2018 10:25 AM, Alexandru Isaila wrote: This commit enables MSR events for svm. Signed-off-by: Alexandru Isaila <aisa...@bitdefender.com> Reviewed-by: Boris Ostrovsky <bor

Re: [Xen-devel] [PATCH 2/2] xen: xenbus: WARN_ON XS_TRANSACTION_{START, END} misuse

On 02/07/2018 05:22 PM, Simon Gaiser wrote: As the previous commit shows it's quite easy to confuse the transaction reference counting by ending a transaction twice. So at least try to detect and report it. Signed-off-by: Simon Gaiser ---

Re: [Xen-devel] [PATCH 1/2] xen: xenbus_dev_frontend: Fix XS_TRANSACTION_END handling

onsidering a transaction closed if we have sent XS_TRANSACTION_END once regardless of the return code. Cc: <sta...@vger.kernel.org> # 4.11 Fixes: fd8aa9095a95 ("xen: optimize xenbus driver for multiple concurrent xenstore accesses") Signed-off-by: Simon Gaiser <si...@invisiblethingsl

Re: [Xen-devel] [PATCH v2 2/4] hvm/svm: Enable Breakpoint events

On 02/08/2018 10:25 AM, Alexandru Isaila wrote: + + rc = hvm_monitor_debug(regs->rip, + HVM_MONITOR_SOFTWARE_BREAKPOINT, + X86_EVENTTYPE_SW_EXCEPTION, + inst_len); + if ( rc

Re: [Xen-devel] [PATCH] x86/xen: Calculate __max_logical_packages on PV domains

by: Prarit Bhargava <pra...@redhat.com> Tested-and-reported-by: Simon Gaiser <si...@invisiblethingslab.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: "H. Peter Anvin" <h...@zytor.com> Cc: x...@kernel.org Cc: Boris Ostrovsky &

Re: [Xen-devel] [PATCH] pvcalls-back: do not return error on inet_accept EAGAIN

On 02/02/2018 08:34 PM, Stefano Stabellini wrote: When the client sends a regular blocking accept request, the backend is expected to return only when the accept is completed, simulating a blocking behavior, or return an error. Specifically, on EAGAIN from inet_accept, the backend shouldn't

Re: [Xen-devel] [PATCH] xen: hypercall: fix out-of-bounds memcpy

On 02/04/2018 10:35 AM, Arnd Bergmann wrote: On Sat, Feb 3, 2018 at 6:08 PM, Boris Ostrovsky <boris.ostrov...@oracle.com> wrote: On 02/03/2018 10:12 AM, Arnd Bergmann wrote: On Sat, Feb 3, 2018 at 12:33 AM, Boris Ostrovsky <boris.ostrov...@oracle.com> wrote: On 02/02/2018 10

Re: [Xen-devel] [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks

On 02/03/2018 12:10 PM, Andrew Cooper wrote: On 03/02/18 17:03, Boris Ostrovsky wrote: On 01/31/2018 03:35 PM, Brian Woods wrote: Corrects some EFER.SVME checks in intercepts.  See AMD APM vol2 section 15.4 for more details.  VMMCALL isn't checked due to guests needing it to boot. Don't

Re: [Xen-devel] [PATCH] xen: hypercall: fix out-of-bounds memcpy

On 02/03/2018 10:12 AM, Arnd Bergmann wrote: On Sat, Feb 3, 2018 at 12:33 AM, Boris Ostrovsky <boris.ostrov...@oracle.com> wrote: On 02/02/2018 10:32 AM, Arnd Bergmann wrote: The legacy hypercall handlers were originally added with a comment explaining that "copying the argument

Re: [Xen-devel] [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks

On 01/31/2018 03:35 PM, Brian Woods wrote: Corrects some EFER.SVME checks in intercepts. See AMD APM vol2 section 15.4 for more details. VMMCALL isn't checked due to guests needing it to boot. Don't you need SVME be on for VMMCALL? -boris ___

Re: [Xen-devel] [PATCH 1/3] x86/svm: update VGIF support

Woods <brian.wo...@amd.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen: hypercall: fix out-of-bounds memcpy

On 02/02/2018 10:32 AM, Arnd Bergmann wrote: > The legacy hypercall handlers were originally added with > a comment explaining that "copying the argument structures in > HYPERVISOR_event_channel_op() and HYPERVISOR_physdev_op() into the local > variable is sufficiently safe" and only made sure to

Re: [Xen-devel] [PATCH] xen: fix frontend driver disconnected from xenbus on removal

On 02/01/2018 03:24 PM, Oleksandr Andrushchenko wrote: > > > On 02/01/2018 10:08 PM, Boris Ostrovsky wrote: >> On 02/01/2018 03:57 AM, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> >>> >>> C

[Xen-devel] [PATCH] flask: Remove reference to DOMCTL_getmemlist

Commit 94450e36bfbb ("xen: Drop DOMCTL_getmemlist and xc_get_pfn_list()") missed reference to DOMCTL_getmemlist in hooks.s Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> --- xen/xsm/flask/hooks.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/xen/xsm/flask/h

Re: [Xen-devel] [PATCH v2 2/2] xen: add acpi_arch_get_root_pointer() for pvh guests

to that change it was pure luck that the legacy method to locate the RSDP was working when running as PVH mode. Cc: <sta...@vger.kernel.org> # 4.11 Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Boris Ostrovsky <boris.ostro

Re: [Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

On 01/24/2018 11:15 AM, Juergen Gross wrote: > On 24/01/18 17:10, Boris Ostrovsky wrote: > >> >>>> So what is the problem here? >>>> >>>> - current Linux can't be booted as PVH guest with xen-unstable due to >>>> a bug in Linux, patches

Re: [Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

On 01/24/2018 10:26 AM, George Dunlap wrote: > On Wed, Jan 24, 2018 at 3:20 PM, Juergen Gross <jgr...@suse.com> wrote: >> On 24/01/18 16:07, George Dunlap wrote: >>> On Wed, Jan 24, 2018 at 2:10 PM, Boris Ostrovsky >>> <boris.ostrov...@oracle.com> wrote: >

Re: [Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

On 01/24/2018 09:25 AM, Juergen Gross wrote: > On 24/01/18 15:10, Boris Ostrovsky wrote: >> >> I suspect we can do as little as removing "#ifdef CONFIG_KEXEC" around >> acpi_rsdp in drivers/acpi/osl.c and then assigning it the value in >> pvh_st

Re: [Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

On 01/18/2018 05:33 AM, Wei Liu wrote: > On Thu, Jan 18, 2018 at 11:31:32AM +0100, Juergen Gross wrote: >> Wei, >> >> On 01/12/17 15:14, Juergen Gross wrote: >>> Instead of locating the RSDP table below 1MB put it just below 4GB >>> like the rest of the ACPI tables in case of PVH guests. This will

Re: [Xen-devel] [PATCH v9 06/11] x86/entry: Organise the use of MSR_SPEC_CTRL at each entry/exit point

On 01/22/2018 07:17 PM, Andrew Cooper wrote: On 22/01/2018 22:27, Boris Ostrovsky wrote: On 01/19/2018 08:36 AM, Andrew Cooper wrote: On 19/01/18 11:43, Jan Beulich wrote: @@ -99,6 +106,10 @@ UNLIKELY_END(realmode) .Lvmx_vmentry_fail: sti SAVE_ALL

Re: [Xen-devel] [PATCH v9 06/11] x86/entry: Organise the use of MSR_SPEC_CTRL at each entry/exit point

On 01/19/2018 08:36 AM, Andrew Cooper wrote: > On 19/01/18 11:43, Jan Beulich wrote: > >>> @@ -99,6 +106,10 @@ UNLIKELY_END(realmode) >>> .Lvmx_vmentry_fail: >>> sti >>> SAVE_ALL >>> + >>> +SPEC_CTRL_ENTRY_FROM_PV /* Req: %rsp=regs/cpuinfo Clob: acd */ >> I think the use

Re: [Xen-devel] [PATCH v9 05/11] x86/hvm: Permit guests direct access to MSR_{SPEC_CTRL, PRED_CMD}

ima <jun.nakaj...@intel.com> > CC: Kevin Tian <kevin.t...@intel.com> > CC: Boris Ostrovsky <boris.ostrov...@oracle.com> > CC: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> > > v7: > * Drop excess brackets > v9: > * Re-implement it light of

Re: [Xen-devel] [PATCH 2/2] xen-netfront: Fix race between device setup and open

ssibility that we fail to recreate the queues so check for this > in the open function. > > Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v8 13/17] x86/boot: Calculate the most appropriate BTI mitigation to use

On 01/16/2018 09:13 AM, Andrew Cooper wrote: > On 16/01/18 14:10, Boris Ostrovsky wrote: >> On 01/12/2018 01:01 PM, Andrew Cooper wrote: >>> >>> +if ( boot_cpu_has(X86_FEATURE_IBRSB) ) >>> +{ >>> +/* >>> + * Even i

Re: [Xen-devel] [PATCH v8 13/17] x86/boot: Calculate the most appropriate BTI mitigation to use

On 01/12/2018 01:01 PM, Andrew Cooper wrote: > > +if ( boot_cpu_has(X86_FEATURE_IBRSB) ) > +{ > +/* > + * Even if we've chosen to not have IBRS set in Xen context, we still > + * need the IBRS entry/exit logic to virtualise IBRS support for > + * guests. >

Re: [Xen-devel] [PATCH v8 10/17] x86/hvm: Permit guests direct access to MSR_{SPEC_CTRL, PRED_CMD}

ulich <jbeul...@suse.com> with one spelling fix (see below) As these are non-trivial changes to VMX and SVM code I think you should have Cc-ed the maintainers (now added, and leaving the full patch in context for them. Reviewed-by: Boris Ostrovsky <boris

Re: [Xen-devel] [PATCH 2/2] xen/gntdev: Fix partial gntdev_mmap() cleanup

: Bad page map in process" if Xen is in release mode. This is only needed when use_ptemod is true because gntdev_put_map() will unmap grant pages itself when use_ptemod is false. Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> Reviewed-by: Boris Ostrovsky <boris.o

Re: [Xen-devel] [PATCH 1/2] xen/gntdev: Fix off-by-one error when unmapping with holes

On 01/09/2018 07:10 AM, Ross Lagerwall wrote: If the requested range has a hole, the calculation of the number of pages to unmap is off by one. Fix it. Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@o

Re: [Xen-devel] Linux 4.15-rc6 + xen-unstable: BUG: unable to handle kernel NULL pointer dereference at (null), [ 0.000000] IP: zero_resv_unavail+0x8e/0xe1

On 01/09/2018 11:31 AM, Sander Eikelenboom wrote: > On 09/01/18 17:16, Pavel Tatashin wrote: >> Hi Juergen, >> >> Do you have this patch applied: >> >> https://github.com/torvalds/linux/commit/e8c24773d6b2cd9bc8b36bd6e60beff599be14be > Seems this hasn't made it to Linus yet ? > > I will give it a

Re: [Xen-devel] [PATCH v2] x86: xen: remove the use of VLAIS

On 01/08/2018 11:28 AM, Juergen Gross wrote: > On 08/01/18 17:20, Boris Ostrovsky wrote: >> On 01/08/2018 11:10 AM, Peter Zijlstra wrote: >>> On Sat, Jan 06, 2018 at 01:39:48PM -0800, Nick Desaulniers wrote: >>>> Variable Length Arrays In Structs (VLAIS) is not suppor

Re: [Xen-devel] [PATCH v2] x86: xen: remove the use of VLAIS

On 01/08/2018 11:10 AM, Peter Zijlstra wrote: > On Sat, Jan 06, 2018 at 01:39:48PM -0800, Nick Desaulniers wrote: >> Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and >> frowned upon by others. >> >> https://lkml.org/lkml/2013/9/23/500 >> >> Here, the VLAIS was used because

Re: [Xen-devel] [PATCH v2] x86: xen: remove the use of VLAIS

On 01/06/2018 04:39 PM, Nick Desaulniers wrote: > Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and > frowned upon by others. > > https://lkml.org/lkml/2013/9/23/500 > > Here, the VLAIS was used because the size of the bitmap returned from > xen_mc_entry() depended on

Re: [Xen-devel] [PATCH] xen-netfront: enable device after manual module load

ould communicate the netback to create its > device and establish the connection between them. > > Signed-off-by: Eduardo Otubo <ot...@redhat.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Should this go to stable trees as well? -boris > --- > drivers/net/

Re: [Xen-devel] [PATCH] x86/xen/time: fix section mismatch for xen_init_time_ops()

On 01/06/2018 03:35 PM, Nick Desaulniers wrote: > On Tue, Jan 2, 2018 at 7:00 AM, Boris Ostrovsky > <boris.ostrov...@oracle.com> wrote: >> On 01/02/2018 09:32 AM, Andrew Cooper wrote: >>> On 02/01/18 14:24, Juergen Gross wrote: >>>> On 02/01/18 15:18, Boris

Re: [Xen-devel] [PATCH 1/3] xen: remove tests for pvh mode in pure pv paths

On 01/08/2018 01:50 AM, Juergen Gross wrote: > On 06/01/18 06:55, HW42 wrote: >> >> Not sure if you prefer to change the grant-table code or to revert this >> part of the commit. The patch bellow works for me: > The patch looks fine. > >> From: Simon Gaiser >> Date:

Re: [Xen-devel] [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock

On 12/27/2017 10:46 PM, Wei Yongjun wrote: > A spin lock is taken here so we should use GFP_ATOMIC. > > Fixes: 9774c6cca266 ("xen/pvcalls: implement accept command") > Signed-off-by: Wei Yongjun Applied to for-linus-4.15 -boris

Re: [Xen-devel] [PATCH] x86/xen/time: fix section mismatch for xen_init_time_ops()

On 01/02/2018 09:32 AM, Andrew Cooper wrote: > On 02/01/18 14:24, Juergen Gross wrote: >> On 02/01/18 15:18, Boris Ostrovsky wrote: >>> On 12/23/2017 09:50 PM, Nick Desaulniers wrote: >>>> The header declares this function as __init but is defined in __ref >

Re: [Xen-devel] [PATCH] x86/xen/time: fix section mismatch for xen_init_time_ops()

On 12/23/2017 09:50 PM, Nick Desaulniers wrote: > The header declares this function as __init but is defined in __ref > section. > > Signed-off-by: Nick Desaulniers AFAIK section attributes in header files are ignored by compiler anyway so I'd remove all of them.

Re: [Xen-devel] OProfile with Xen-4.9

On 12/21/2017 11:06 AM, Сергей wrote: > Hello. > > I have installed Xen-4.9 from Ubuntu 17.10 package. And I would like to > profile it with OProfile (as far as I know this is the only option). > > With instruction from >

Re: [Xen-devel] [PATCH 1/2] x86/svm: Add SVME checking for SVM intercepts

On 12/21/2017 10:26 AM, Brian Woods wrote: > Checks the hvm EFER.SVME bit to make sure the EFER.SVME bit it high s/it/is > before allowing nested SVM intercepts to be handled successfully. On > SVME being low, it generates a #UD as per the AMD APM vol2 15.4. > > Reported-by: Andrew Cooper

Re: [Xen-devel] [PATCH 2/2] x86/svm: Add checks for nested HW features

rian.wo...@amd.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v3] xen/balloon: Mark unallocated host memory as UNUSABLE

hotplug. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> --- Changes in v3: * Use PFN_PHYS * Replace kzalloc with kmalloc * Declare arch_xen_balloon_init prototype in balloon.h * Rename resources (s/memory/RAM/) * Clarify (I think) comment when populating hostmem_resource *

Re: [Xen-devel] [PATCH v2] xen/balloon: Mark unallocated host memory as UNUSABLE

On 12/19/2017 09:40 AM, Jan Beulich wrote: On 19.12.17 at 15:25, wrote: >> On 12/19/2017 03:23 AM, Jan Beulich wrote: >> On 18.12.17 at 23:22, wrote: + if (!xen_e820_table) + return; >>> Not saying "out of

[Xen-devel] [PATCH v2] xen/balloon: Mark unallocated host memory as UNUSABLE

hotplug. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> --- Changes in v2: In enlighten.c: - Fix 32-bit build problem (include bootmem.h), make variables 32-bit safe - Add a test to avoid inserting a resource into hostmem which is beyond hostmem's end - Replace 'while' loop with 'for'

Re: [Xen-devel] [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute

On 12/18/2017 02:36 AM, Jan Beulich wrote: On 15.12.17 at 20:52, wrote: > +static int pcistub_device_reset(struct pci_dev *dev) > +{ > + struct xen_pcibk_dev_data *dev_data; > + bool slot = false, bus = false; > + struct pcistub_args arg = {};

Re: [Xen-devel] [PATCH] xen/balloon: Mark unallocated host memory as UNUSABLE

us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Boris-Ostrovsky/xen-balloon-Mark-unallocated-host-memory-as-UNUSABLE/20171215-231511 > base: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next > config: i386-rand

Re: [Xen-devel] [PATCH] xen/balloon: Mark unallocated host memory as UNUSABLE

On 12/15/2017 10:33 AM, Juergen Gross wrote: > On 15/12/17 15:58, Boris Ostrovsky wrote: >> On 12/15/2017 09:47 AM, Juergen Gross wrote: >>> On 15/12/17 15:24, Boris Ostrovsky wrote: >>>>>> + >>>>>> +hostmem_resource->start = max_

Re: [Xen-devel] [PATCH] xen: XEN_ACPI_PROCESSOR is Dom0-only

On 12/12/2017 05:18 AM, Jan Beulich wrote: > Add a respective dependency. > > Signed-off-by: Jan Beulich Committed to for-linus-4.15. -boris ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH] x86/PCI: limit the size of the 64bit BAR to 256GB

On 12/12/2017 01:38 PM, Christian König wrote: > Am 12.12.2017 um 19:12 schrieb Bjorn Helgaas: >> [+cc Boris, Juergen, xen-devel] >> >> On Mon, Dec 11, 2017 at 04:04:52PM +0100, Christian König wrote: >>> Xen hides a bit of system memory from the OS for its own purpose by >>> intercepting e820.

Re: [Xen-devel] [RFC PATCH v2 0/2] KVM: x86: Allow Qemu/KVM to use PVH entry point

On 12/07/2017 05:45 PM, Maran Wilson wrote: > > Juergen also had a suggestion to split the different hypervisor types > early and use a common set of service functions instead of special casing > xen_guest everywhere. > > There are certainly less special cases in this version of the patch, but >

Re: [Xen-devel] [PATCH 2/2] xen/pvcalls: Fix a check in pvcalls_front_remove()

On 12/05/2017 01:29 PM, Stefano Stabellini wrote: > On Tue, 5 Dec 2017, Dan Carpenter wrote: >> bedata->ref can't be less than zero because it's unsigned. This affects >> certain error paths in probe. We first set ->ref = -1 and then we set >> it to a valid value later. >> >> Fixes: 219681909913

Re: [Xen-devel] [RFC PATCH] KVM: x86: Allow Qemu/KVM to use PVH entry point

On 11/29/2017 09:18 AM, Roger Pau Monné wrote: > On Wed, Nov 29, 2017 at 03:11:12PM +0100, Juergen Gross wrote: >> On 29/11/17 15:03, Boris Ostrovsky wrote: >>> On 11/29/2017 03:50 AM, Roger Pau Monné wrote: >>>> On Wed, Nov 29, 2017 at 09:21:59AM +0100, Juergen Gro

Re: [Xen-devel] [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

On 11/28/2017 04:12 AM, Christian König wrote: > > > How about the attached patch? It limits the newly added MMIO space to > the upper 256GB of the address space. That should still be enough for > most devices, but we avoid both issues with Xen dom0 as most likely > problems with memory hotplug as

<    6   7   8   9   10   11   12   >