On 7/19/19 1:04 PM, George Dunlap wrote:
> On 7/19/19 11:24 AM, Nicolas Belouin wrote:
>>
>> On 7/19/19 12:09 PM, George Dunlap wrote:
>>> On 7/19/19 11:03 AM, Nicolas Belouin wrote:
>>>> On 7/19/19 10:50 AM, George Dunlap wrote:
>>>>>> On
On 7/19/19 12:01 PM, George Dunlap wrote:
> On 7/19/19 8:34 AM, Nicolas Belouin wrote:
>>
>> On 7/18/19 11:54 PM, George Dunlap wrote:
>>> The Go bindings for libxl miss functions from libxl_utils, let's start
>>> with the simple libxl_domid_to_name and its co
On 7/19/19 12:09 PM, George Dunlap wrote:
> On 7/19/19 11:03 AM, Nicolas Belouin wrote:
>>
>> On 7/19/19 10:50 AM, George Dunlap wrote:
>>>> On Jul 19, 2019, at 9:47 AM, George Dunlap
>>>> wrote:
>>>>
>>>>
>&g
On 7/19/19 10:50 AM, George Dunlap wrote:
>
>> On Jul 19, 2019, at 9:47 AM, George Dunlap wrote:
>>
>>
>>
>>> On Jul 19, 2019, at 8:34 AM, Nicolas Belouin
>>> wrote:
>>>
>>>
>>>
>>> On 7/18/19 11:54 PM, George Du
https://github.com/golang/go/issues/32734#issuecomment-506835432
>
> Signed-off-by: Nicolas Belouin
> Signed-off-by: George Dunlap
> ---
> v3:
> - Wire into build system
> - Add reference to C.GoString() handling NULL to commit message
>
> Nicolas, could you test to see
On 28/06 18:05, George Dunlap wrote:
> On 6/28/19 9:31 AM, Nicolas Belouin wrote:
> > Newer versions of Go have become stricter on enforcing the no implicit
> > conversions policy when using CGo.
> > Specifically, the following two conversions are no longer allowed:
> >
cast to C
void *
Fix this by adding explicit casts where necessary.
Signed-off-by: Nicolas Belouin
---
tools/golang/xenlight/xenlight.go | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/tools/golang/xenlight/xenlight.go
b/tools/golang/xenlight/xenlight.go
index
Go is doing more type check (even when using CGo), so these incorrect
use of `unsafe.Pointer` as well as the lack of `unsafe.Pointer` for
these calls no longer compile with recent Go versions.
This does *not* break compatibility with older Go version.
---
tools/golang/xenlight/xenlight.go | 8
The Go bindings for libxl miss functions from libxl_utils, lets start
with the simple libxl_domid_to_name and its counterpart
libxl_name_to_domid.
Signed-off-by: Nicolas Belouin
---
tools/golang/xenlight/xenlight_utils.go | 61 +
1 file changed, 61 insertions(+)
create
