Komarianskyi
Reviewed-by: Oleksandr Tyshchenko
Initially I was slightly worried about ...
---
Changes in V7:
- fixed the condition in the is_espi assert for non-eSPI builds: the
previous condition was mistakenly added with a wrong check and led to
triggering asserts for all non-eSPI INTIDs
appropriate config is disabled, or GIC HW doesn't
support eSPI, the existing functionality will remain the same.
Signed-off-by: Leonid Komarianskyi
Reviewed-by: Oleksandr Tyshchenko
---
Changes in V6:
- removed unnecessary parentheses in gic_is_valid_espi()
- updated gic_is_valid_line(): i
and ESPI_IDX2INTID
into appropriate inline functions introduced in the previous patch
- minor change: changed int to unsigned int for nr_espis
Reviewed-by: Oleksandr Tyshchenko
preferably with NIT below
Changes in V5:
- removed the has_espi field because it can be determined by checking
whet
On 04.09.25 08:52, Leonid Komarianskyi wrote:
Hi Julien, Volodymyr and Oleksandr,
Hello all
Thank you for your comments.
On 04.09.25 02:04, Julien Grall wrote:
Hi,
On 03/09/2025 22:37, Volodymyr Babchuk wrote:
Hi Oleksandr,
Oleksandr Tyshchenko writes:
[...]
+static inline
On 04.09.25 18:10, Leonid Komarianskyi wrote:
> Hello Oleksandr,
Hello Leonid
>
> Thank you for your comment.
>
> On 04.09.25 17:37, Oleksandr Tyshchenko wrote:
>>
>>
>> On 03.09.25 17:30, Leonid Komarianskyi wrote:
>>
>> Hello Leonid
>>
roper interrupt precedence
in the system.
The priority assignment now follows ARM GIC best practices:
- SGIs (0-15): GIC_PRI_IPI (higher priority)
- PPIs/SPIs (16+): GIC_PRI_IRQ (standard priority)
Signed-off-by: Mykola Kvach
Reviewed-by: Oleksandr Tyshchenko
---
xen/arch/arm/irq.
On 04.09.25 00:37, Volodymyr Babchuk wrote:
Hi Oleksandr,
Hello Volodymyr
Oleksandr Tyshchenko writes:
[...]
+static inline uint32_t vgic_get_reg_offset(uint32_t reg, uint32_t spi_base,
+ uint32_t espi_base)
+{
+if ( reg < espi_b
vgic_store_irouter to reflect parameter
changes
- minor change: changed the macros ESPI_INTID2IDX and ESPI_IDX2INTID
into appropriate inline functions introduced in the previous patch
Reviewed-by: Oleksandr Tyshchenko
preferably with the comments below
Changes in V5:
- since eSPI-specific defines
On 03.09.25 13:25, Mykola Kvach wrote:
Hi Oleksandr,
Hello Mykola
On Wed, Sep 3, 2025 at 1:01 PM Oleksandr Tyshchenko
wrote:
On 02.09.25 01:10, Mykola Kvach wrote:
Hello Mykola
From: Oleksandr Tyshchenko
Store and restore active context and micro-TLB registers.
Tested on R
On 02.09.25 01:10, Mykola Kvach wrote:
Hello Mykola
> From: Oleksandr Tyshchenko
>
> Store and restore active context and micro-TLB registers.
>
> Tested on R-Car H3 Starter Kit.
>
> Signed-off-by: Oleksandr Tyshchenko
> Signed-off-by: Mykola Kvach
> ---
&g
fioreq_gfn cannot be returned), please
refer to arch_ioreq_server_map_pages(). On Arm64, only the Acquire
Resource infrastructure is used to query and map the IOREQ Server pages.
Signed-off-by: Oleksandr Tyshchenko
---
xen/include/public/arch-arm.h | 1 -
1 file changed, 1 deletion(-)
diff -
On 29.08.25 19:06, Leonid Komarianskyi wrote:
Hello Leonid
Implemented support for GICv3.1 extended SPI registers for vGICv3,
allowing the emulation of eSPI-specific behavior for guest domains.
The implementation includes read and write emulation for eSPI-related
registers (e.g., GICD_ISENA
On 02.09.25 10:27, Orzel, Michal wrote:
Hello Michal
On 01/09/2025 14:58, Oleksandr Tyshchenko wrote:
The said sub-op is not supported on Arm64, since it:
- does not support the buffered emulation (so bufioreq_port/bufioreq_gfn
cannot be returned), please refer to
On 01.09.25 21:00, Leonid Komarianskyi wrote:
Hello Oleksandr,
Hello Leonid
Thank you for your review.
On 31.08.25 18:58, Oleksandr Tyshchenko wrote:
On 29.08.25 23:45, Volodymyr Babchuk wrote:
Hello Leonid, Volodymyr
Hi Leonid,
Leonid Komarianskyi writes:
This change
On 02.09.25 01:10, Mykola Kvach wrote:
Hello Mykola
From: Oleksandr Tyshchenko
This is done using generic iommu_suspend/resume functions that cause
IOMMU driver specific suspend/resume handlers to be called for enabled
IOMMU (if one has suspend/resume driver handlers implemented).
Signed
On 02.09.25 20:43, Mykola Kvach wrote:
Hi Oleksandr,
Hello Mykola
On Tue, Sep 2, 2025 at 7:49 PM Oleksandr Tyshchenko wrote:
On 02.09.25 01:10, Mykola Kvach wrote:
Hello Mykola
From: Mykola Kvach
On ARM, the first 32 interrupts (SGIs and PPIs) are banked per-CPU
and not
On 02.09.25 17:36, Julien Grall wrote:
> Hi Oleksandr,
Hello Julien
>
> On 02/09/2025 15:00, Oleksandr Tyshchenko wrote:
>>
>>
>> On 02.09.25 15:19, Julien Grall wrote:
>>
>> Hello Julien
>>
>>> On 02/09/2025 13:10, Orzel, Michal wrote:
gfn cannot be returned), please
refer to arch_ioreq_server_map_pages(). On Arm, only the Acquire
Resource infrastructure is used to query and map the IOREQ Server pages.
Signed-off-by: Oleksandr Tyshchenko
---
V2:
- s/Arm64/Arm
- drop from dm_op() in xen/arch/arm/dm.c
- upd
On 02.09.25 01:10, Mykola Kvach wrote:
Hello Mykola
From: Mykola Kvach
On ARM, the first 32 interrupts (SGIs and PPIs) are banked per-CPU
and not restored by gic_resume (for secondary cpus).
This patch introduces restore_local_irqs_on_resume, a function that
restores the state of local in
On 02.09.25 01:10, Mykola Kvach wrote:
Hello Mykola
From: Mykola Kvach
System suspend may lead to a state where GIC would be powered down.
Therefore, Xen should save/restore the context of GIC on suspend/resume.
Note that the context consists of states of registers which are
controlled b
On 02.09.25 15:19, Julien Grall wrote:
Hello Julien
> On 02/09/2025 13:10, Orzel, Michal wrote:
>>
>>
>> On 02/09/2025 13:54, Julien Grall wrote:
>>> Hi,
>>>
>>> On 02/09/2025 11:18, Orzel, Michal wrote:
>>>>
>>>>
>&g
by adding "select GICV3" to the RCAR4 Kconfig entry.
Fixes: 336fc7a19b49 ("xen/arm: platform: Add support for R-Car Gen4")
Signed-off-by: Oleksandr Tyshchenko
---
xen/arch/arm/platforms/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/arm/platforms/Kconfig b
On 29.08.25 23:45, Volodymyr Babchuk wrote:
Hello Leonid, Volodymyr
Hi Leonid,
Leonid Komarianskyi writes:
This change introduces resource management in the VGIC to handle
extended SPIs introduced in GICv3.1. The pending_irqs and
allocated_irqs arrays are resized to support the required
Is is the same as
for regular SPIs
- removed ifdefs for eSPI-specific offsets to reduce the number of
ifdefs and code duplication in further changes
- removed reviewed-by as moving offset from ifdefs requires additional
confirmation from reviewers
Reviewed-by: Oleksandr Tyshchenko
Ch
Kconfig option.
Signed-off-by: Leonid Komarianskyi
---
Changes in V5:
- no functional changes introduced by this version compared with V4, only
minor fixes and removal of ifdefs for macroses
- added TODO comment, suggested by Oleksandr Tyshchenko
- changed int to unsigned int for irqs
refactoring also simplifies the implementation of eSPI support in future
changes.
Signed-off-by: Leonid Komarianskyi
Reviewed-by: Volodymyr Babchuk
Acked-by: Julien Grall
Reviewed-by: Oleksandr Tyshchenko
with one NIT ...
---
Changes in V5:
- fixed a minor nit: changed %d to %u in the warning
On 28.08.25 19:40, Oleksii Moisieiev wrote:
Hello Oleksii
the patch lgtm, just some NITs
From: Grygorii Strashko
Add documentation section for Simple Arm SCMI over SMC calls forwarding
driver (EL3).
Signed-off-by: Grygorii Strashko
Signed-off-by: Oleksii Moisieiev
---
Changes in v6:
-
On 28.08.25 19:40, Oleksii Moisieiev wrote:
Hello Oleksii
the patch lgtm, just some comments
From: Grygorii Strashko
The commit 3e322bef8bc0 ("xen/arm: firmware: Add SCMI over SMC calls
handling layer") introduces simple driver which forwards SCMI over SMC
calls from hwdom/dom0 to EL3 fir
On 28.08.25 19:40, Oleksii Moisieiev wrote:
Hello Oleksii
the patch lgtm, just some comments
From: Grygorii Strashko
The introduced SCI (System Control Interface) subsystem provides unified
interface to integrate in Xen SCI drivers which adds support for ARM
firmware (EL3, SCP) based sof
On 28.08.25 19:40, Oleksii Moisieiev wrote:
Hello Oleksii
This patch adds the basic framework for ARM SCI mediator. SCI is System
Control Interface, which is designed to redirect requests from the Domains
to ARM specific Firmware (for example SCMI). This will allow the devices,
passed-throu
On 28.08.25 22:09, Leonid Komarianskyi wrote:
Hello Oleksandr,
Hello Leonid
Thank you for your comment and suggestions.
On 28.08.25 20:34, Oleksandr Tyshchenko wrote:
On 27.08.25 21:24, Leonid Komarianskyi wrote:
Hello Leonid
This change introduces resource management in the VGIC
On 29.08.25 00:36, Mykola Kvach wrote:
Hi Oleksandr,
Hello Mykola
Thank you for your review.
On Tue, Aug 26, 2025 at 6:51 PM Oleksandr Tyshchenko
wrote:
On 07.08.25 08:16, Mykola Kvach wrote:
Hello Mykola,
In general patch looks good to me, just one question below ...
From
Komarianskyi
Reviewed-by: Volodymyr Babchuk
---
Changes in V4:
- removed redundant line with 'default n' in Kconfig, as it is disabled
by default, without explicit specification
- added reviewed-by from Volodymyr Babchuk
only NITs below
Reviewed-by: Oleksandr Tyshchenko
Cha
supporting it), it will return the regular SPI
range, as it works currently. There are no functional changes compared
with the previous patch version
- removed VGIC_DEF_MAX_SPI macro, to reduce the number of ifdefs
very good, thanks, only NIT below
Reviewed-by: Oleksandr Tyshchenko
On 27.08.25 21:24, Leonid Komarianskyi wrote:
Hello Leonid
This change introduces resource management in the VGIC to handle
extended SPIs introduced in GICv3.1. The pending_irqs and
allocated_irqs arrays are resized to support the required
number of eSPIs, based on what is supported by the h
ded a log banner with eSPI information, similar to the one for
regular SPI
- added newline after ifdef and before gic_is_valid_line
- added reviewed-by from Volodymyr Babchuk
only NITs below
Reviewed-by: Oleksandr Tyshchenko
Changes in V3:
- add __init attribute to gicv3_dist_espi_common
- added vgic_is_valid_line implementation for new-vgic, because
vgic_is_valid_line is called from generic code. It is necessary to fix
the build for new-vgic.
The comments I provided are addressed (thanks), so you can add my:
Reviewed-by: Oleksandr Tyshchenko
[snip]
On 22.07.25 14:41, Oleksii Moisieiev wrote:
Hello Oleksii
[I will try to not repeat comments provided by Stefano in separate letter]
This patch introduces SCI driver to support for ARM EL3 Trusted Firmware-A
(TF-A) which provides SCMI interface with multi-agnet support, as shown
below.
On 27.08.25 16:38, Leonid Komarianskyi wrote:
Hello Oleksandr,
Hello Leonid
Thank you for your good question, I was thinking about that as well.
On 27.08.25 13:25, Oleksandr Tyshchenko wrote:
On 26.08.25 17:05, Leonid Komarianskyi wrote:
Hello Leonid,
In general patch looks good
On 27.08.25 14:13, Leonid Komarianskyi wrote:
Hello Oleksandr,
Hello Leonid
Thank you for your close review.
On 26.08.25 22:57, Oleksandr Tyshchenko wrote:
On 26.08.25 17:05, Leonid Komarianskyi wrote:
Hello Leonid
Implemented support for GICv3.1 extended SPI registers for vGICv3
On 27.08.25 13:25, Leonid Komarianskyi wrote:
Hello Leonid
Hello Volodymyr,
Thank you for your suggestion.
On 27.08.25 02:08, Volodymyr Babchuk wrote:
Hi Leonid,
Leonid Komarianskyi writes:
The Dom0 and DomUs logic for the dom0less configuration in create_dom0()
and arch_create_domUs(
On 26.08.25 17:05, Leonid Komarianskyi wrote:
Hello Leonid,
In general patch looks good to me, just one question below ...
Introduced appropriate register definitions, helper macros,
and initialization of required GICv3.1 distributor registers
to support eSPI. This type of interrupt is han
On 26.08.25 17:05, Leonid Komarianskyi wrote:
Hello Leonid
Currently, Xen does not support eSPI interrupts, leading
to a data abort when such interrupts are defined in the DTS.
This patch introduces a separate array to initialize up to
1024 interrupt descriptors in the eSPI range and adds
On 26.08.25 17:05, Leonid Komarianskyi wrote:
Hello Leonid
Implemented support for GICv3.1 extended SPI registers for vGICv3,
allowing the emulation of eSPI-specific behavior for guest domains.
The implementation includes read and write emulation for eSPI-related
registers (e.g., GICD_ISENA
state across system suspend/resume cycles.
Tested on Renesas R-Car H3 Starter Kit.
Signed-off-by: Volodymyr Babchuk
Signed-off-by: Oleksandr Andrushchenko
Signed-off-by: Mykola Kvach
---
In patch v5, there are no changes at all;
it was done just to trigger a review.
I think, you could ping on V4
On 26.08.25 16:42, Mykola Kvach wrote:
Hello Mykola, Volodymyr
Hi Volodymyr,
On Sat, Aug 23, 2025 at 8:55 PM Volodymyr Babchuk
wrote:
Hi,
Mykola Kvach writes:
From: Oleksandr Tyshchenko
This is done using generic iommu_suspend/resume functions that cause
IOMMU driver specific
On 07.08.25 15:33, Leonid Komarianskyi wrote:
Hello everyone!
Hello Leonid,
### Background
Unlike the Linux kernel, which has supported extended shared peripheral
interrupts (eSPIs) since 2019 [1], Xen currently lacks support for this
interrupt range. For SoCs with GICv3.1+, this feature
On 07.08.25 15:33, Leonid Komarianskyi wrote:
Hello Leonid
This change introduces resource management in the VGIC to handle
extended SPIs introduced in GICv3.1. The pending_irqs and
allocated_irqs arrays are resized to support the required
number of eSPIs, based on what is supported by the
On 07.08.25 15:33, Leonid Komarianskyi wrote:
Hello Leonid
Introduced appropriate register definitions, helper macros,
and initialization of required GICv3.1 distributor registers
to support eSPI. This type of interrupt is handled in the
same way as regular SPI interrupts, with the followin
On 07.08.25 15:33, Leonid Komarianskyi wrote:
Hello Leonid
The Dom0 configuration logic in create_dom0() has been updated
to account for extended SPIs when supported by the hardware and
enabled with CONFIG_GICV3_ESPI. These changes ensure the proper
calculation of the maximum number of SPIs
On 07.08.25 15:33, Leonid Komarianskyi wrote:
Hello Leonid
Introduced two new helper functions for vGIC: vgic_is_valid_irq and
vgic_is_shared_irq. The functions are similar to the newly introduced
gic_is_valid_irq and gic_is_shared_irq, but they verify whether a vIRQ
is available for a spec
On 07.08.25 15:33, Leonid Komarianskyi wrote:
Hello Leonid
Implemented support for GICv3.1 extended SPI registers for vGICv3,
allowing the emulation of eSPI-specific behavior for guest domains.
The implementation includes read and write emulation for eSPI-related
registers (e.g., GICD_ISENA
Fix the incorrect condition that causes hvm_alloc_legacy_ioreq_gfn()
to return INVALID_GFN even if the HVM param was installed properly by
the toolstack.
Fixes: 3486f398a3dd (' x86/hvm/ioreq: allow ioreq servers to use
HVM_PARAM_[BUF]IOREQ_PFN')
Signed-off-by: Oleksandr Tyshchenko
Properly emulate the full register")
Signed-off-by: Oleksandr Tyshchenko
---
xen/arch/arm/vgic-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index f20249f731..4369c55177 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arc
: c4d6bbdc12e5 ("xen/arm: vgic-v3: Support 32-bit access for 64-bit
registers")
Signed-off-by: Oleksandr Tyshchenko
Acked-by: Julien Grall
---
V2:
- s/data about/guest data abort in the description
- add A-b
- move goto to the next line
---
---
xen/arch/arm/vgic-v3.c | 3 ++-
1 fi
On 20.05.25 18:02, Julien Grall wrote:
> Hi Oleksandr,
Hello Julien
>
> On 20/05/2025 14:47, Oleksandr Tyshchenko wrote:
>> An attempt to write access the register (i.e. GICR_PROPBASER,
>> GICR_PENDBASER)
>> which should be ignored (i.e. no virtual ITS present
On 20.05.25 17:24, Andrew Cooper wrote:
Hello Andrew
> On 20/05/2025 2:47 pm, Oleksandr Tyshchenko wrote:
>> An attempt to write access the register (i.e. GICR_PROPBASER, GICR_PENDBASER)
>> which should be ignored (i.e. no virtual ITS present) causes the data about
>
> Do
2-bit access for 64-bit
registers")
Signed-off-by: Oleksandr Tyshchenko
---
xen/arch/arm/vgic-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 2eaa48fadb..b366b046a2 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm
On 27.03.25 00:39, Julien Grall wrote:
> Hi Oleksandr,
Hello Julien
>
> On 26/03/2025 11:45, Oleksandr Tyshchenko wrote:
>> Also it is not entirely clear what we should do with acpi_disabled=true
>> during declaration (what current patch does), even if we decided to
On 27.03.25 00:33, Julien Grall wrote:
Hello Julien
> Hi,
>
> On 26/03/2025 08:57, Orzel, Michal wrote:
>>
>>
>> On 25/03/2025 17:54, Oleksandr Tyshchenko wrote:
>>>
>>>
>>> On 25.03.25 18:09, Julien Grall wrote:
>>>
>>>
On 26.03.25 10:57, Orzel, Michal wrote:
Hello Michal, Julien
>
>
> On 25/03/2025 17:54, Oleksandr Tyshchenko wrote:
>>
>>
>> On 25.03.25 18:09, Julien Grall wrote:
>>
>>
>>> Hi Oleksandr,
>>
>> Hello Julien
>>
>>&g
On 19.03.25 14:37, Jan Beulich wrote:
Hello Jan, all.
On 19.03.2025 13:05, Mykyta Poturai wrote:
On 18.03.25 16:26, Jan Beulich wrote:
On 18.03.2025 14:31, Mykyta Poturai wrote:
On 18.03.25 12:11, Jan Beulich wrote:
On 18.03.2025 10:10, Mykyta Poturai wrote:
On 15.01.24 11:35, Jan Beul
en().
Signed-off-by: Oleksandr Tyshchenko
---
The RFC since I am not sure whether the description is precise
and the fix is correct.
Below the dump, w/o and w/ the fix applied. I also added prints
for the processed memory ranges with "OT:" for the visibility:
On 25.03.25 18:09, Julien Grall wrote:
> Hi Oleksandr,
Hello Julien
>
> On 25/03/2025 16:05, Oleksandr Tyshchenko wrote:
>>>>> Furthermore, what happen if we decide to use ACPI afterwards? Wouldn't
>>>>> this mean that the static regions w
On 25.03.25 17:47, Julien Grall wrote:
Hello Julien, Michal.
> Hi Michal,
>
> On 25/03/2025 15:35, Orzel, Michal wrote:
>>
>>
>> On 25/03/2025 16:23, Julien Grall wrote:
>>>
>>>
>>> Hi Oleksandr, Michal,
>>>
>>> On 25/
an issue and match to acpi_boot_table_init().
Suggested-by: Michal Orzel
Signed-off-by: Oleksandr Tyshchenko
---
V2:
- drop post-commit remark
- use the approach suggested by Michal
- update commit subject (WAS xen/device-tree: Switch back to
dt_unreserved_regions() in boot allocator
On 25.03.25 10:46, Orzel, Michal wrote:
Hello Michal
>
>
> On 24/03/2025 22:27, Oleksandr Tyshchenko wrote:
>>
>>
>> On the device-tree-based Arm64 system, if Xen is built with
>> CONFIG_ACPI=y, CONFIG_STATIC_MEMORY=y, and the static memory range
>> i
Hello all.
Please, ignore this second email, it was sent by mistake.
--
Regards,
Oleksandr Tyshchenko
en().
Signed-off-by: Oleksandr Tyshchenko
---
The RFC since I am not sure whether the description is precise
and the fix is correct.
Below the dump, w/o and w/ the fix applied. I also added prints
for the processed memory ranges with "OT:" for the visibility:
On 20.03.25 09:30, Jan Beulich wrote:
Hello Jan, Mykyta, all
On 19.03.2025 21:42, Oleksandr Tyshchenko wrote:
On 19.03.25 14:37, Jan Beulich wrote:
On 19.03.2025 13:05, Mykyta Poturai wrote:
On 18.03.25 16:26, Jan Beulich wrote:
On 18.03.2025 14:31, Mykyta Poturai wrote:
On 18.03.25
Hello, Roger!
On 04.03.25 10:17, Roger Pau Monné wrote:
On Mon, Mar 03, 2025 at 09:23:57PM +0200, Oleksandr Andrushchenko wrote:
Hello, Roger!
On 03.03.25 17:05, Roger Pau Monné wrote:
On Sat, Mar 01, 2025 at 01:42:39PM +0200, Oleksandr Andrushchenko wrote:
Disable coding style checks for
Hello, Roger!
On 03.03.25 17:05, Roger Pau Monné wrote:
On Sat, Mar 01, 2025 at 01:42:39PM +0200, Oleksandr Andrushchenko wrote:
Disable coding style checks for the project, but xen/ folder:
this is done by providing a global .clang-format at the top level which
disables clang-format and only
:
xen/drivers/char/ns16550.c
It is seen that only xen/ part of the patch was touched. The result can
still be manually adjusted before committing.
Signed-off-by: Oleksandr Andrushchenko
---
xen/drivers/char/ns16550.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a
This patch was produced by running clang-format on a file:
clang-format -i xen/drivers/pci/pci.c
Signed-off-by: Oleksandr Andrushchenko
---
xen/drivers/pci/pci.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/xen/drivers/pci/pci.c b/xen/drivers/pci/pci.c
index
are accepted all those
comments can be removed.
Stay safe,
Oleksandr Andrushchenko
[1] https://lists.xen.org/archives/html/xen-devel/2025-02/msg00800.html
Oleksandr Andrushchenko (4):
Add .clang-format files to enable manual coding style checks
[EXAMPLE] Provide an example of a malformed pa
This patch touches tools/xl and xen/. clang-format, if applied, will
only change xen/ part.
Signed-off-by: Oleksandr Andrushchenko
---
tools/xl/xl_info.c | 6 ++
xen/drivers/char/ns16550.c | 12 +---
2 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/tools/xl
-by: Oleksandr Andrushchenko
Signed-off-by: Luca Fancellu
---
.clang-format |5 +
xen/.clang-format | 1380 +
2 files changed, 1385 insertions(+)
create mode 100644 .clang-format
create mode 100644 xen/.clang-format
diff --git a/.clang-format b/.cl
Hello, Jan!
On 24.02.25 12:55, Jan Beulich wrote:
On 23.02.2025 08:42, Oleksandr Andrushchenko wrote:
On 20.02.25 03:34, Stefano Stabellini wrote:
On Wed, 19 Feb 2025, Oleksandr Andrushchenko wrote:
Yes, I do agree. But only if we talk about having an automated
code style check now (which is
Hello, Jan!
On 19.02.25 18:01, Jan Beulich wrote:
On 19.02.2025 16:40, Oleksandr Andrushchenko wrote:
On 19.02.25 16:05, Jan Beulich wrote:
On 19.02.2025 14:52, Oleksandr Andrushchenko wrote:
On 19.02.25 15:18, Jan Beulich wrote:
On 19.02.2025 13:39, Oleksandr Andrushchenko wrote:
On
Hello, Stefano!
On 20.02.25 03:34, Stefano Stabellini wrote:
On Wed, 19 Feb 2025, Oleksandr Andrushchenko wrote:
Yes, I do agree. But only if we talk about having an automated
code style check now (which is definitely the goal at some time).
Before that we could still use the tool to take all
On 19.02.25 16:05, Jan Beulich wrote:
On 19.02.2025 14:52, Oleksandr Andrushchenko wrote:
On 19.02.25 15:18, Jan Beulich wrote:
On 19.02.2025 13:39, Oleksandr Andrushchenko wrote:
On 17.02.25 12:20, Jan Beulich wrote:
On 16.02.2025 11:21, Oleksandr Andrushchenko wrote:
@@ -248,8 +249,9
Hello, Jan!
On 19.02.25 14:39, Oleksandr Andrushchenko wrote:
Hello, Jan!
On 17.02.25 12:20, Jan Beulich wrote:
On 16.02.2025 11:21, Oleksandr Andrushchenko wrote:
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -14,7 +14,7 @@
* abstracted.
*/
#if defined
Hello, Jan!
On 19.02.25 15:18, Jan Beulich wrote:
On 19.02.2025 13:39, Oleksandr Andrushchenko wrote:
On 17.02.25 12:20, Jan Beulich wrote:
On 16.02.2025 11:21, Oleksandr Andrushchenko wrote:
@@ -43,12 +43,12 @@
static struct ns16550 {
int baud, clock_hz, data_bits, parity
On 19.02.25 14:51, Oleksandr Andrushchenko wrote:
Hello, Andrew!
On 19.02.25 14:49, Andrew Cooper wrote:
On 16/02/2025 5:11 pm, Oleksandr Andrushchenko wrote:
Hello, Roger!
Please find the branch with all the conversions [1].
Unfortunately I cannot provide a branch as seen with
diff
Hello, Jan!
On 19.02.25 14:49, Jan Beulich wrote:
On 19.02.2025 13:43, Oleksandr Andrushchenko wrote:
Hello, Jan, Stefano!
On 18.02.25 13:34, Jan Beulich wrote:
On 18.02.2025 03:36, Stefano Stabellini wrote:
On Mon, 17 Feb 2025, Jan Beulich wrote:
On 16.02.2025 11:21, Oleksandr
Hello, Andrew!
On 19.02.25 14:49, Andrew Cooper wrote:
On 16/02/2025 5:11 pm, Oleksandr Andrushchenko wrote:
Hello, Roger!
Please find the branch with all the conversions [1].
Unfortunately I cannot provide a branch as seen with
diff --ignore-all-space as such a patch will not simply apply
Hello, Grygorii!
On 18.02.25 11:56, Grygorii Strashko wrote:
On 16.02.25 12:21, Oleksandr Andrushchenko wrote:
Hello, everybody!
As agreed before [1] I am sending a series to show two samples of the
formatting done with clang-format. The clang-format configuration can be
found at [2]. It
Hello, Jan, Stefano!
On 18.02.25 13:34, Jan Beulich wrote:
On 18.02.2025 03:36, Stefano Stabellini wrote:
On Mon, 17 Feb 2025, Jan Beulich wrote:
On 16.02.2025 11:21, Oleksandr Andrushchenko wrote:
1. Const string arrays reformatting
In case the length of items change we might need to
Hello, Jan!
On 17.02.25 12:20, Jan Beulich wrote:
On 16.02.2025 11:21, Oleksandr Andrushchenko wrote:
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -14,7 +14,7 @@
* abstracted.
*/
#if defined(CONFIG_HAS_PCI) && defined(CONFIG_X86)
-# define NS16550_PCI
From: Oleksandr Tyshchenko
This is actually what the caller acquire_resource() expects on any kind
of error (the comment on top of resource_max_frames() also suggests that).
Otherwise, the caller will treat -errno as a valid value and propagate incorrect
nr_frames to the VM. As a possible
On 17.02.25 23:09, Andrew Cooper wrote:
Hello.
On 17/02/2025 8:48 pm, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
The sign of the presence of a corresponding bugfix is an error
returned on querying the size of an unknown for Xen resource type.
Signed-off-by: Oleksandr
From: Oleksandr Tyshchenko
The sign of the presence of a corresponding bugfix is an error
returned on querying the size of an unknown for Xen resource type.
Signed-off-by: Oleksandr Tyshchenko
---
Refer https://patchew.org/Xen/20250217102741.4122367-1-olekst...@gmail.com/
Current patch should
On 17.02.25 15:52, Andrew Cooper wrote:
Hello
On 17/02/2025 1:11 pm, Oleksandr Tyshchenko wrote:
On 17.02.25 13:09, Andrew Cooper wrote:
Hello Andrew
On 17/02/2025 10:27 am, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
This is actually what the caller acquire_resource
On 17.02.25 13:09, Andrew Cooper wrote:
Hello Andrew
On 17/02/2025 10:27 am, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
This is actually what the caller acquire_resource() expects on any kind
of error (the comment on top of resource_max_frames() also suggests that
From: Oleksandr Tyshchenko
This is actually what the caller acquire_resource() expects on any kind
of error (the comment on top of resource_max_frames() also suggests that).
Otherwise, the caller will treat -errno as a valid value and propagate incorrect
nr_frames to the VM. As a possible
On 17.02.25 11:18, Jan Beulich wrote:
Hello Jan
On 16.02.2025 22:19, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
This is actually what the caller acquire_resource() expects on any kind
of error (the comment on top of resource_max_frames() also suggests that).
Otherwise, the
From: Oleksandr Tyshchenko
This is actually what the caller acquire_resource() expects on any kind
of error (the comment on top of resource_max_frames() also suggests that).
Otherwise, the caller will treat -errno as a valid value and propagate incorrect
nr_frames to the VM. As a possible
Hello, Roger!
Please find the branch with all the conversions [1].
Unfortunately I cannot provide a branch as seen with
diff --ignore-all-space as such a patch will not simply apply.
Stay safe,
Oleksandr Andrushchenko
On 16.02.25 13:58, Andrew Cooper wrote:
On 16/02/2025 10:21 am, Oleksandr
Use .clang-format to format ns16550 driver.
Signed-off-by: Oleksandr Andrushchenko
---
xen/drivers/char/ns16550.c | 761 ++---
1 file changed, 378 insertions(+), 383 deletions(-)
diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index
which cannot be handled by the tool now.
Stay safe,
Oleksandr Andrushchenko
1. Const string arrays reformatting
In case the length of items change we might need to introduce a bigger
change wrt new formatting of unaffected lines
==
1 - 100 of 2353 matches
Mail list logo
