Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Ian Jackson
Ian Jackson writes ("RE: [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling"): > I think our proposal is to drop the type change, continue to use > uint32_t everwhere for these values, and specify the "use default" > value to be all-bits-set. Following discussion

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Durrant, Paul
> -Original Message- > From: Ian Jackson > Sent: 29 November 2019 16:08 > To: Durrant, Paul > Cc: Wei Liu ; Anthony Perard ; xen- > de...@lists.xenproject.org; George Dunlap ; > Andrew Cooper ; Jan Beulich > ; Julien Grall ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; > Marek

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread George Dunlap
> On Nov 29, 2019, at 4:07 PM, Ian Jackson wrote: > > Durrant, Paul writes ("RE: [PATCH-for-4.13 v5] Rationalize max_grant_frames > and max_maptrack_frames handling"): >>> -Original Message- >>> From: Ian Jackson > ... >>> Is there some reason we wouldn't use ~0 to mean default ? >>>

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Ian Jackson
Durrant, Paul writes ("RE: [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling"): > > -Original Message- > > From: Ian Jackson ... > > Is there some reason we wouldn't use ~0 to mean default ? > > > > In the tools area we normally spell this as > >

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Durrant, Paul
> -Original Message- > From: Ian Jackson > Sent: 29 November 2019 15:47 > To: Wei Liu > Cc: Durrant, Paul ; Anthony Perard > ; xen-devel@lists.xenproject.org; George Dunlap > ; Andrew Cooper ; Jan > Beulich ; Julien Grall ; Konrad > Rzeszutek Wilk ; Stefano Stabellini > ; Marek

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling"): > What if we use 0x to denote default instead? That wouldn't > require changing the type here. Is there some reason we wouldn't use ~0 to mean default ? In the tools area we

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Durrant, Paul
> -Original Message- > From: Anthony PERARD > Sent: 29 November 2019 13:52 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; George Dunlap > ; Ian Jackson ; Wei > Liu ; Andrew Cooper ; George Dunlap > ; Jan Beulich ; Julien > Grall ; Konrad Rzeszutek Wilk ; > Stefano Stabellini ;

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Anthony PERARD
On Fri, Nov 29, 2019 at 12:51:47PM +, Durrant, Paul wrote: > > -Original Message- > > From: Anthony PERARD > > Sent: 29 November 2019 12:46 > > I'm not sure what was the intention with the new function > > xlu_cfg_get_bounded_long(), but I don't think libxlu is the right place > > for

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Durrant, Paul
> -Original Message- > From: Anthony PERARD > Sent: 29 November 2019 12:46 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; George Dunlap > ; Ian Jackson ; Wei > Liu ; Andrew Cooper ; George Dunlap > ; Jan Beulich ; Julien > Grall ; Konrad Rzeszutek Wilk ; > Stefano Stabellini ;

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Anthony PERARD
On Thu, Nov 28, 2019 at 04:52:24PM +, Paul Durrant wrote: > diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h > index 49b56fa1a3..a2a5d321c5 100644 > --- a/tools/libxl/libxl.h > +++ b/tools/libxl/libxl.h > @@ -364,8 +364,8 @@ > */ > #define LIBXL_HAVE_BUILDINFO_GRANT_LIMITS 1 > >

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Wei Liu
On Thu, Nov 28, 2019 at 04:52:24PM +, Paul Durrant wrote: > From: George Dunlap > > Xen used to have single, system-wide limits for the number of grant > frames and maptrack frames a guest was allowed to create. Increasing > or decreasing this single limit on the Xen command-line would

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Jürgen Groß
On 29.11.19 13:17, Jan Beulich wrote: On 29.11.2019 13:01, Jürgen Groß wrote: On 29.11.19 11:22, Jan Beulich wrote: On 28.11.2019 17:52, Paul Durrant wrote: --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -84,11 +84,40 @@ struct grant_table { struct grant_table_arch

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Jan Beulich
On 29.11.2019 13:01, Jürgen Groß wrote: > On 29.11.19 11:22, Jan Beulich wrote: >> On 28.11.2019 17:52, Paul Durrant wrote: >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -84,11 +84,40 @@ struct grant_table { >>> struct grant_table_arch arch; >>> }; >>> >>>

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Jürgen Groß
On 29.11.19 11:22, Jan Beulich wrote: On 28.11.2019 17:52, Paul Durrant wrote: --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -84,11 +84,40 @@ struct grant_table { struct grant_table_arch arch; }; +static int parse_gnttab_limit(const char *param, const char *arg, +

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 29 November 2019 10:46 > To: Durrant, Paul > Cc: Andrew Cooper ; Anthony PERARD > ; George Dunlap ; > Roger Pau Monné ; Volodymyr Babchuk > ; George Dunlap ; > Ian Jackson ; Marek Marczykowski-Górecki > ; Stefano Stabellini > ;

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Jan Beulich
On 29.11.2019 11:39, Durrant, Paul wrote: >> -Original Message- >> From: Jan Beulich >> Sent: 29 November 2019 10:29 >> To: Durrant, Paul >> Cc: Andrew Cooper ; Anthony PERARD >> ; George Dunlap ; >> Roger Pau Monné ; Volodymyr Babchuk >> ; George Dunlap ; >> Ian Jackson ; Marek

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 29 November 2019 10:29 > To: Durrant, Paul > Cc: Andrew Cooper ; Anthony PERARD > ; George Dunlap ; > Roger Pau Monné ; Volodymyr Babchuk > ; George Dunlap ; > Ian Jackson ; Marek Marczykowski-Górecki > ; Stefano Stabellini > ;

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Jan Beulich
On 29.11.2019 11:22, Jan Beulich wrote: > On 28.11.2019 17:52, Paul Durrant wrote: >> --- a/xen/common/grant_table.c >> +++ b/xen/common/grant_table.c >> @@ -84,11 +84,40 @@ struct grant_table { >> struct grant_table_arch arch; >> }; >> >> +static int parse_gnttab_limit(const char *param,

Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-29 Thread Jan Beulich
On 28.11.2019 17:52, Paul Durrant wrote: > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -84,11 +84,40 @@ struct grant_table { > struct grant_table_arch arch; > }; > > +static int parse_gnttab_limit(const char *param, const char *arg, > +

[Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Paul Durrant
From: George Dunlap Xen used to have single, system-wide limits for the number of grant frames and maptrack frames a guest was allowed to create. Increasing or decreasing this single limit on the Xen command-line would change the limit for all guests on the system. Later, per-domain limits for