Re: [Xen-devel] [PATCH 1/4] x86/hyperv: misc cleanup

2020-02-13 Thread Jan Beulich
On 13.02.2020 13:24, Wei Liu wrote: > On Thu, Feb 13, 2020 at 10:46:56AM +0100, Jan Beulich wrote: >> On 12.02.2020 17:09, Wei Liu wrote: >>> --- a/xen/arch/x86/guest/hyperv/private.h >>> +++ b/xen/arch/x86/guest/hyperv/private.h >>> @@ -26,6 +26,6 @@ >>> >>> DECLARE_PER_CPU(void *, hv_input_pag

Re: [Xen-devel] [PATCH 1/4] x86/hyperv: misc cleanup

2020-02-13 Thread Wei Liu
On Thu, Feb 13, 2020 at 10:46:56AM +0100, Jan Beulich wrote: > On 12.02.2020 17:09, Wei Liu wrote: > > --- a/xen/arch/x86/guest/hyperv/private.h > > +++ b/xen/arch/x86/guest/hyperv/private.h > > @@ -26,6 +26,6 @@ > > > > DECLARE_PER_CPU(void *, hv_input_page); > > DECLARE_PER_CPU(void *, hv_vp_

Re: [Xen-devel] [PATCH 1/4] x86/hyperv: misc cleanup

2020-02-13 Thread Wei Liu
On Wed, Feb 12, 2020 at 05:53:54PM +0100, Roger Pau Monné wrote: > On Wed, Feb 12, 2020 at 04:09:15PM +, Wei Liu wrote: > > Change hv_vp_index to use uint32_t because that is what is defined in TLFS. > > > > Add "_addr" suffix to hv_do_rep_hypercall's parameters. > > Being of type paddr_t I'm

Re: [Xen-devel] [PATCH 1/4] x86/hyperv: misc cleanup

2020-02-13 Thread Jan Beulich
On 12.02.2020 17:09, Wei Liu wrote: > --- a/xen/arch/x86/guest/hyperv/private.h > +++ b/xen/arch/x86/guest/hyperv/private.h > @@ -26,6 +26,6 @@ > > DECLARE_PER_CPU(void *, hv_input_page); > DECLARE_PER_CPU(void *, hv_vp_assist); > -DECLARE_PER_CPU(unsigned int, hv_vp_index); > +DECLARE_PER_CPU(

Re: [Xen-devel] [PATCH 1/4] x86/hyperv: misc cleanup

2020-02-13 Thread Durrant, Paul
> -Original Message- > From: Wei Liu On Behalf Of Wei Liu > Sent: 12 February 2020 17:09 > To: Xen Development List > Cc: Durrant, Paul ; Michael Kelley > ; Wei Liu ; Wei Liu > ; Jan Beulich ; Andrew Cooper > ; Roger Pau Monné > Subject: [PATCH 1/4] x86/hyperv: misc cleanup > > Change h

Re: [Xen-devel] [PATCH 1/4] x86/hyperv: misc cleanup

2020-02-12 Thread Roger Pau Monné
On Wed, Feb 12, 2020 at 04:09:15PM +, Wei Liu wrote: > Change hv_vp_index to use uint32_t because that is what is defined in TLFS. > > Add "_addr" suffix to hv_do_rep_hypercall's parameters. Being of type paddr_t I'm unsure the _addr suffix adds any value to the name. > > Signed-off-by: Wei

[Xen-devel] [PATCH 1/4] x86/hyperv: misc cleanup

2020-02-12 Thread Wei Liu
Change hv_vp_index to use uint32_t because that is what is defined in TLFS. Add "_addr" suffix to hv_do_rep_hypercall's parameters. Signed-off-by: Wei Liu --- xen/arch/x86/guest/hyperv/hyperv.c | 2 +- xen/arch/x86/guest/hyperv/private.h | 2 +- xen/include/asm-x86/guest/hyperv-hcall