Re: [Xen-devel] [PATCH v2 15/22] golang/xenlight: begin C to Go type marshaling

2019-12-05 Thread Nick Rosbrook
> So first of all, I noticed that the marshalling code for Union structs > does what I suggest. :-) Yeah I realized that. I must have figured out that my previous way wasn't necessary, but forgot to go back and change it. > I'm not super-strong on this, so I don't want to bike-shed. But I think

Re: [Xen-devel] [PATCH v2 15/22] golang/xenlight: begin C to Go type marshaling

2019-12-05 Thread George Dunlap
On 12/5/19 4:38 PM, Nick Rosbrook wrote: >> You should probably say here explicitly what kinds of elements you're >> supporting and not supporting in this patch; specifically: >> >> - You're converting built-ins (or is this any struct-like type?) > > Any struct-like type, since the fromC

Re: [Xen-devel] [PATCH v2 15/22] golang/xenlight: begin C to Go type marshaling

2019-12-05 Thread Nick Rosbrook
> You should probably say here explicitly what kinds of elements you're > supporting and not supporting in this patch; specifically: > > - You're converting built-ins (or is this any struct-like type?) Any struct-like type, since the fromC functions are all defined in this patch (excluding array

Re: [Xen-devel] [PATCH v2 15/22] golang/xenlight: begin C to Go type marshaling

2019-12-04 Thread George Dunlap
On 11/15/19 7:44 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Implement basic type conversion in fromC functions such as strings and > integer types. Also, remove existing toGo functions from xenlight.go in > favor of the new generated functions. You should probably say here explicitly