Re: [Xen-devel] [alsa-devel] [PATCH] ALSA: xen: ensure nul-terminated device name

[Oleksandr Andrushchenko]

On 05/28/2018 06:59 PM, Arnd Bergmann wrote:

gcc-8 warns that pcm_instance->name is not necessarily terminated correctly
if the input is more than 80 characters long or lacks a termination byte
itself:

In function 'strncpy',
 inlined from 'cfg_device' at sound/xen/xen_snd_front_cfg.c:399:3,
 inlined from 'xen_snd_front_cfg_card' at 
sound/xen/xen_snd_front_cfg.c:509:9:
include/linux/string.h:254:9: error: '__builtin_strncpy' specified bound 80 
equals destination size [-Werror=stringop-truncation]
   return __builtin_strncpy(p, q, size);

Using strlcpy() instead of strncpy() makes this a bit safer.

Fixes: fd3b36045c2c ("ALSA: xen-front: Read sound driver configuration from Xen 
store")
Signed-off-by: Arnd Bergmann 
---
  sound/xen/xen_snd_front_cfg.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/xen/xen_snd_front_cfg.c b/sound/xen/xen_snd_front_cfg.c
index 38c7e1eefbb9..684b5f1d51ac 100644
--- a/sound/xen/xen_snd_front_cfg.c
+++ b/sound/xen/xen_snd_front_cfg.c
@@ -396,7 +396,7 @@ static int cfg_device(struct xen_snd_front_info *front_info,
  
  	str = xenbus_read(XBT_NIL, device_path, XENSND_FIELD_DEVICE_NAME, NULL);

if (!IS_ERR(str)) {
-   strncpy(pcm_instance->name, str, sizeof(pcm_instance->name));
+   strlcpy(pcm_instance->name, str, sizeof(pcm_instance->name));
kfree(str);
}
  

Thank you for your patch,
Reviewed-by: Oleksandr Andrushchenko 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] XSM in osstest, grub config, outstanding patch

[Doug Goldstein]

On 5/17/18 10:09 AM, Ian Jackson wrote:
> Hi, I'm emailing you because I know you have an interest in XSM
> (and therefore in its testing in osstest).
> 
> osstest manages the booting of its test hosts using the
> distro-supplied bootloader arrangements for its dom0s.  For Debian
> that is update-grub.  Currently, osstest has a hacked-up local copy of
> the Xen bit of update-grub, /etc/grub.d/20_linux_xen.  This is in
> serious danger of diverging from upstream, which is quite bad.
> 
> I am intending to drop this file from osstest installs of Debian dom0s
> after stretch (ie, for Debian buster).  Currently all the deviations
> from upstream we have been carrying are fixed, except for one
> XSM-related change.
> 
> That change is in the one described in upstream bugtracker here:
>   https://savannah.gnu.org/bugs/?43420
> According to the osstest commit message for f12512e44919, this is not
> quite the same version as is being used by osstest.
> 
> This upstream bug is blocked because of unanswered questions about the
> naming and discovery of policy files.  According to Wei, we don't have
> a good story about how a user-supplied policy file ought to supplant
> the one which comes from the Xen build system.
> 
> Anyway, without this change, when osstest tries to set up XSM on
> Debian buster it will not find a bootloader entry with the right
> policy file.  It will then fail that test.
> 
> To avoid this in the most expedient way, it would be good to get a
> version of this fix into grub upstream before then.
> 
> Failing that, as I would be reluctant to continue to carry an
> ever-diverging piece of grub configuration, I think it would be
> necessary for there to at least be an upstream bug report with a ready
> (or nearly-ready) patch; in which case I could provide osstest with a
> copy of buster's 20_linux_xen file with that patch applied.
> 
> In any case, we will want something close to a ready-to-apply patch in
> the upstream bugtracker.
> 
> I am emailing you this now because I have just discovered it.  Happily
> this will give people plenty of time to debate the policy file naming
> issue.
> 
> Thanks,
> Ian.
> 

So I believe the path forward here was that we'd bake the "default" XSM
policy into Xen and the user could then override it by supplying one
with the current name. Ultimately the current Xen build system really
has no business installing this file. At Star Lab we had our policy in a
separate repo (in fact we had multiple policies as different packages
for different objectives). Last I looked OpenXT has their policy in an
external repo and packages it up separately from Xen. Marek can probably
answer as to how Qubes does it.

So the answer to me is no change has to happen to Grub but Xen should
change to just do the right thing and stop installing that file.

-- 
Doug Goldstein

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH RFC 1/3] automation: install texinfo in debian

[Doug Goldstein]

On 5/23/18 5:20 AM, Wei Liu wrote:
> Stubdom build requires that.
> 

CentOS & Ubuntu will need the change too. Though in a way I'd almost ask
why --enable-docs doesn't need it but stubdoms do? Seems like a weird
dep for stubdom...

-- 
Doug Goldstein

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH RFC 2/3] automation: build stubdom and rombios, and tools on 32 bit

[Doug Goldstein]

On 5/23/18 5:20 AM, Wei Liu wrote:

>  
>  # SeaBIOS cannot be built with clang
> @@ -20,12 +18,6 @@ if [[ "${CC}" == "clang" ]]; then
>  cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin")
>  fi
>  
> -if [[ "${XEN_TARGET_ARCH}" == "x86_64" ]]; then
> -cfgargs+=("--enable-tools")
> -else
> -cfgargs+=("--disable-tools") # we don't have the cross depends installed
> -fi
> -

This still horribly fails when targeting arm because we have to actually
execute a compiled binary on the host. The tools build system doesn't
seem to comprehend host != target.

A few people have stepped forward with ideas and said they'd take point
on the patches but I haven't seen anything land yet.

-- 
Doug Goldstein

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [distros-debian-sid test] 74754: tolerable FAIL

[Platform Team regression test user]

flight 74754 distros-debian-sid real [real]
http://osstest.xs.citrite.net/~osstest/testlogs/logs/74754/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-i386-sid-netboot-pvgrub 10 debian-di-install   fail like 74732
 test-armhf-armhf-armhf-sid-netboot-pygrub 10 debian-di-install fail like 74732
 test-amd64-amd64-i386-sid-netboot-pygrub 10 debian-di-install  fail like 74732
 test-amd64-i386-amd64-sid-netboot-pygrub 10 debian-di-install  fail like 74732
 test-amd64-amd64-amd64-sid-netboot-pvgrub 10 debian-di-install fail like 74732

baseline version:
 flight   74732

jobs:
 build-amd64  pass
 build-armhf  pass
 build-i386   pass
 build-amd64-pvopspass
 build-armhf-pvopspass
 build-i386-pvops pass
 test-amd64-amd64-amd64-sid-netboot-pvgrubfail
 test-amd64-i386-i386-sid-netboot-pvgrub  fail
 test-amd64-i386-amd64-sid-netboot-pygrub fail
 test-armhf-armhf-armhf-sid-netboot-pygrubfail
 test-amd64-amd64-i386-sid-netboot-pygrub fail



sg-report-flight on osstest.xs.citrite.net
logs: /home/osstest/logs
images: /home/osstest/images

Logs, config files, etc. are available at
http://osstest.xs.citrite.net/~osstest/testlogs/logs

Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary


Push not applicable.


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] Building xen-hypervisor 4.10 and xen-tools on Ubuntu 16.04 for PVH

[.. ..]

Hello,

I am doing a study on Virtual Machine Introspection on Intel SGX based
system using Xen based VMs.

I followed the article  -

https://wiki.xenproject.org/wiki/Linux_PVH


, in order to build xen-hypervisor 4.10 and xen-tools on Ubuntu 16.04 for
PVH.

However, after installing xen-tools and reboting, my machine, Ubuntu 16.4
is stuck in a login loop. I am able to log in but after a few seconds it
logs out and goes back to login screen.

Also, during the service enabling steps, all except xenstored.service were
enabled. So I am not sure if the login loop issue is due to that.

I tried updating the grub, using recovery mode, but still the issue
persists.
I would be truly thankful if you could suggest me some solution.

Thank You,
Good Day.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [xen-unstable-smoke test] 123328: regressions - FAIL

[osstest service owner]

flight 123328 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123328/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 123071

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass

version targeted for testing:
 xen  4712c0a231f010253a5471531e335a5a13dcec76
baseline version:
 xen  fc5805daef091240cd5fc06634a8bcdb2f3bb843

Last test of basis   123071  2018-05-22 15:00:29 Z6 days
Failing since123296  2018-05-28 10:01:06 Z0 days8 attempts
Testing same since   123306  2018-05-28 16:06:06 Z0 days5 attempts


People who touched revisions under test:
  Andrew Cooper 
  Jan Beulich 

jobs:
 build-arm64-xsm  pass
 build-amd64  pass
 build-armhf  pass
 build-amd64-libvirt  pass
 test-armhf-armhf-xl  pass
 test-arm64-arm64-xl-xsm  fail
 test-amd64-amd64-xl-qemuu-debianhvm-i386 pass
 test-amd64-amd64-libvirt pass



sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.


commit 4712c0a231f010253a5471531e335a5a13dcec76
Author: Andrew Cooper 
Date:   Thu May 24 15:06:16 2018 +0100

x86/traps: Dump the instruction stream even for double faults

This helps debug #DF's which occur in alternative patches

Reported-by: George Dunlap 
Signed-off-by: Andrew Cooper 
Reviewed-by: Jan Beulich 
Release-acked-by: Juergen Gross 

commit 6b9562dac1746014ab376bd2cf8ba400acf34c6d
Author: Jan Beulich 
Date:   Mon May 28 11:20:26 2018 +0200

x86/XPTI: fix S3 resume (and CPU offlining in general)

We should index an L1 table with an L1 index.

Reported-by: Simon Gaiser 
Signed-off-by: Jan Beulich 
Reviewed-by: Andrew Cooper 
Release-acked-by: Juergen Gross 
(qemu changes not included)

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [ovmf baseline-only test] 74755: all pass

[Platform Team regression test user]

This run is configured for baseline tests only.

flight 74755 ovmf real [real]
http://osstest.xs.citrite.net/~osstest/testlogs/logs/74755/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf 20274d2389eb012812f4561c8eb7cffc57a68850
baseline version:
 ovmf 03ac238b1fe40cfbb1424bf72e2ac8276345e03c

Last test of basis74752  2018-05-27 06:20:53 Z1 days
Testing same since74755  2018-05-28 18:52:10 Z0 days1 attempts


People who touched revisions under test:
  Jaben Carsey 
  Zurcher, Christopher J 

jobs:
 build-amd64-xsm  pass
 build-i386-xsm   pass
 build-amd64  pass
 build-i386   pass
 build-amd64-libvirt  pass
 build-i386-libvirt   pass
 build-amd64-pvopspass
 build-i386-pvops pass
 test-amd64-amd64-xl-qemuu-ovmf-amd64 pass
 test-amd64-i386-xl-qemuu-ovmf-amd64  pass



sg-report-flight on osstest.xs.citrite.net
logs: /home/osstest/logs
images: /home/osstest/images

Logs, config files, etc. are available at
http://osstest.xs.citrite.net/~osstest/testlogs/logs

Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary


Push not applicable.


commit 20274d2389eb012812f4561c8eb7cffc57a68850
Author: Zurcher, Christopher J 
Date:   Wed May 23 11:35:42 2018 +0800

BaseTools/GenFds: Remove redundant GetRealFileLine call

The EvaluateConditional function should not call GetRealFileLine
because this is already done in Warning init and only needs to be
calculated in the event of a parsing failure. This fix stops
InsertedLines from being subtracted twice during error handling.

Cc: Liming Gao 
Cc: Yonghong Zhu 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zurcher, Christopher J 
Reviewed-by: Yonghong Zhu 

commit e95a0dfb46339d459add8af848d5042ec6ff9a8d
Author: Jaben Carsey 
Date:   Thu May 24 22:17:53 2018 +0800

BaseTools: Add missing content to EOT tool.

Cc: Liming Gao 
Cc: Yonghong Zhu 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey 
Reviewed-by: Yonghong Zhu 

commit efa88d51da7163200f13dfc796a328847c45a058
Author: Jaben Carsey 
Date:   Thu May 10 23:14:40 2018 +0800

BaseTools: loop to retry remove when it fails.

There is a common race condition when the OS fails to release a file
fast enough.  this adds a retry loop.

v2 - Add a timeout.

Cc: Mike Kinney 
Cc: Liming Gao 
Cc: Yonghong Zhu 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey 
Reviewed-by: Yonghong Zhu 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [xen-unstable-smoke test] 123321: regressions - FAIL

[osstest service owner]

flight 123321 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123321/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 123071

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass

version targeted for testing:
 xen  4712c0a231f010253a5471531e335a5a13dcec76
baseline version:
 xen  fc5805daef091240cd5fc06634a8bcdb2f3bb843

Last test of basis   123071  2018-05-22 15:00:29 Z6 days
Failing since123296  2018-05-28 10:01:06 Z0 days7 attempts
Testing same since   123306  2018-05-28 16:06:06 Z0 days4 attempts


People who touched revisions under test:
  Andrew Cooper 
  Jan Beulich 

jobs:
 build-arm64-xsm  pass
 build-amd64  pass
 build-armhf  pass
 build-amd64-libvirt  pass
 test-armhf-armhf-xl  pass
 test-arm64-arm64-xl-xsm  fail
 test-amd64-amd64-xl-qemuu-debianhvm-i386 pass
 test-amd64-amd64-libvirt pass



sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.


commit 4712c0a231f010253a5471531e335a5a13dcec76
Author: Andrew Cooper 
Date:   Thu May 24 15:06:16 2018 +0100

x86/traps: Dump the instruction stream even for double faults

This helps debug #DF's which occur in alternative patches

Reported-by: George Dunlap 
Signed-off-by: Andrew Cooper 
Reviewed-by: Jan Beulich 
Release-acked-by: Juergen Gross 

commit 6b9562dac1746014ab376bd2cf8ba400acf34c6d
Author: Jan Beulich 
Date:   Mon May 28 11:20:26 2018 +0200

x86/XPTI: fix S3 resume (and CPU offlining in general)

We should index an L1 table with an L1 index.

Reported-by: Simon Gaiser 
Signed-off-by: Jan Beulich 
Reviewed-by: Andrew Cooper 
Release-acked-by: Juergen Gross 
(qemu changes not included)

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [linux-4.14 test] 123283: regressions - FAIL

[osstest service owner]

flight 123283 linux-4.14 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123283/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 123147
 test-arm64-arm64-libvirt-xsm  6 xen-install  fail REGR. vs. 123147

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-amd64-i386-xl-pvshim12 guest-start  fail   never pass
 test-amd64-i386-libvirt-xsm  13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl-credit2  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl-credit2  14 saverestore-support-checkfail   never pass
 test-arm64-arm64-xl  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl  14 saverestore-support-checkfail   never pass
 test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2  fail never pass
 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop  fail never pass
 test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-cubietruck 13 migrate-support-checkfail never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-cubietruck 14 saverestore-support-checkfail never pass
 test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail  never pass
 test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail  never pass
 test-armhf-armhf-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt 14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  14 saverestore-support-checkfail   never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass
 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass
 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop  fail never pass
 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass
 test-armhf-armhf-xl-vhd  12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-vhd  13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-arndale  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-arndale  14 saverestore-support-checkfail   never pass
 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop  fail never pass
 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass
 test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop  fail never pass
 test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail   never pass
 test-amd64-i386-xl-qemut-win10-i386 10 windows-install fail never pass
 test-amd64-amd64-xl-qemut-win10-i386 10 windows-installfail never pass
 test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail never pass
 test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass

version targeted for testing:
 linux102b97d6241d938ac153193504a5936fc0be27ed
baseline version:
 linux1dff08485b9e835d00bfb34a435bc6f07dadb6fd

Last test of basis   123147  2018-05-24 13:30:16 Z4 days
Testing same since   123201  2018-05-26 01:30:05 Z2 days3 attempts


People who touched revisions under test:
  Akinobu Mita 
  Al Viro 
  Alan Stern 
  Alexander Duyck 
  Alexander Potapenko 
  Alexandre Belloni 
  Amritha Nambiar 
  Andrew Morton 
  Andrew Vasquez 
  Andrzej Hajda 
  Antoine Tenart 
  Arnd Bergmann 
  Arvind Yadav 
  Asutosh Das 
  Baoquan He 
  Bart Van Assche 
  Ben Hutchings 
  Brad Love 
  Brian Norris 
  Bryan O'Donoghue 
  Chad Dupuis 
  Chanwoo Choi 
  Chris Dickens 

[Xen-devel] [xen-unstable test] 123280: tolerable FAIL

[osstest service owner]

flight 123280 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123280/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm  6 xen-install  fail  like 123238
 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 123238
 test-armhf-armhf-libvirt 14 saverestore-support-checkfail  like 123238
 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 123238
 test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail  like 123238
 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 123238
 test-arm64-arm64-xl-xsm   6 xen-install  fail  like 123238
 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 123238
 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 123238
 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail  like 123238
 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stopfail like 123238
 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stopfail like 123238
 test-amd64-i386-xl-pvshim12 guest-start  fail   never pass
 test-amd64-i386-libvirt-xsm  13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt  13 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl-credit2  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl-credit2  14 saverestore-support-checkfail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2  fail never pass
 test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-cubietruck 13 migrate-support-checkfail never pass
 test-armhf-armhf-xl-cubietruck 14 saverestore-support-checkfail never pass
 test-armhf-armhf-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 14 saverestore-support-checkfail   never pass
 test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail  never pass
 test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail  never pass
 test-armhf-armhf-xl-arndale  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-arndale  14 saverestore-support-checkfail   never pass
 test-arm64-arm64-xl  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-vhd  12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-vhd  13 saverestore-support-checkfail   never pass
 test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop  fail never pass
 test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass
 test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail never pass
 test-amd64-amd64-xl-qemut-win10-i386 10 windows-installfail never pass
 test-amd64-i386-xl-qemut-win10-i386 10 windows-install fail never pass

version targeted for testing:
 xen  fc5805daef091240cd5fc06634a8bcdb2f3bb843
baseline version:
 xen  fc5805daef091240cd5fc06634a8bcdb2f3bb843

Last test of basis   123280  2018-05-28 01:37:47 Z0 days
Testing same since  (not found) 0 attempts

jobs:
 build-amd64-xsm  pass
 build-arm64-xsm  pass
 build-armhf-xsm  pass
 build-i386-xsm   pass
 build-amd64-xtf  pass
 build-amd64  pass
 build-arm64  pass
 build-armhf  

[Xen-devel] [PATCH v4 14/21] hw: Do not include "sysemu/blockdev.h" if it is not necessary

[Philippe Mathieu-Daudé]

Remove those unneeded includes to speed up the compilation
process a little bit.

Code change produced with:

$ git grep '#include "sysemu/blockdev.h"' | \
  cut -d: -f-1 | \
  xargs egrep -L 
"(BlockInterfaceType|DriveInfo|drive_get|blk_legacy_dinfo|blockdev_mark_auto_del)"
 | \
  xargs sed -i.bak '/#include "sysemu\/blockdev.h"/d'

Signed-off-by: Philippe Mathieu-Daudé 
---
 hw/block/m25p80.c  | 1 -
 hw/block/onenand.c | 1 -
 hw/i386/xen/xen-mapcache.c | 1 -
 hw/s390x/virtio-ccw.c  | 1 -
 hw/scsi/scsi-generic.c | 1 -
 hw/sd/sdhci.c  | 1 -
 hw/usb/dev-storage.c   | 1 -
 monitor.c  | 1 -
 8 files changed, 8 deletions(-)

diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index b49c8e9caa..a5ccffb4aa 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -24,7 +24,6 @@
 #include "qemu/osdep.h"
 #include "hw/hw.h"
 #include "sysemu/block-backend.h"
-#include "sysemu/blockdev.h"
 #include "hw/ssi/ssi.h"
 #include "qemu/bitops.h"
 #include "qemu/log.h"
diff --git a/hw/block/onenand.c b/hw/block/onenand.c
index ab0c7ea1b3..0cb8d7fa13 100644
--- a/hw/block/onenand.c
+++ b/hw/block/onenand.c
@@ -25,7 +25,6 @@
 #include "hw/block/flash.h"
 #include "hw/irq.h"
 #include "sysemu/block-backend.h"
-#include "sysemu/blockdev.h"
 #include "exec/memory.h"
 #include "hw/sysbus.h"
 #include "qemu/error-report.h"
diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c
index efa35dc6e0..541b7693b3 100644
--- a/hw/i386/xen/xen-mapcache.c
+++ b/hw/i386/xen/xen-mapcache.c
@@ -14,7 +14,6 @@
 #include 
 
 #include "hw/xen/xen_backend.h"
-#include "sysemu/blockdev.h"
 #include "qemu/bitmap.h"
 
 #include 
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index b68798ac52..0a9bec484b 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -13,7 +13,6 @@
 #include "qemu/osdep.h"
 #include "qapi/error.h"
 #include "hw/hw.h"
-#include "sysemu/blockdev.h"
 #include "sysemu/sysemu.h"
 #include "sysemu/kvm.h"
 #include "net/net.h"
diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
index 381f04e339..03bce8ff39 100644
--- a/hw/scsi/scsi-generic.c
+++ b/hw/scsi/scsi-generic.c
@@ -17,7 +17,6 @@
 #include "qemu/error-report.h"
 #include "hw/scsi/scsi.h"
 #include "sysemu/block-backend.h"
-#include "sysemu/blockdev.h"
 
 #ifdef __linux__
 
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index b65403947b..3017e5a95a 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -26,7 +26,6 @@
 #include "qemu/error-report.h"
 #include "qapi/error.h"
 #include "hw/hw.h"
-#include "sysemu/blockdev.h"
 #include "sysemu/dma.h"
 #include "qemu/timer.h"
 #include "qemu/bitops.h"
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index b56c75a73a..d02acda945 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -20,7 +20,6 @@
 #include "monitor/monitor.h"
 #include "sysemu/sysemu.h"
 #include "sysemu/block-backend.h"
-#include "sysemu/blockdev.h"
 #include "qapi/visitor.h"
 #include "qemu/cutils.h"
 
diff --git a/monitor.c b/monitor.c
index 46814af533..d75cb20815 100644
--- a/monitor.c
+++ b/monitor.c
@@ -44,7 +44,6 @@
 #include "qemu/readline.h"
 #include "ui/console.h"
 #include "ui/input.h"
-#include "sysemu/blockdev.h"
 #include "sysemu/block-backend.h"
 #include "audio/audio.h"
 #include "disas/disas.h"
-- 
2.17.0


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v4 12/21] hw: Do not include "sysemu/block-backend.h" if it is not necessary

[Philippe Mathieu-Daudé]

Remove those unneeded includes to speed up the compilation
process a little bit. (Continue 7eceff5b5a1fa cleanup)

Signed-off-by: Philippe Mathieu-Daudé 
---
 hw/arm/collie.c  | 1 -
 hw/arm/gumstix.c | 1 -
 hw/arm/mainstone.c   | 1 -
 hw/arm/nseries.c | 1 -
 hw/arm/omap1.c   | 1 -
 hw/arm/omap2.c   | 1 -
 hw/arm/omap_sx1.c| 1 -
 hw/arm/pxa2xx.c  | 1 -
 hw/arm/spitz.c   | 1 -
 hw/arm/versatilepb.c | 1 -
 hw/arm/vexpress.c| 1 -
 hw/arm/virt.c| 1 -
 hw/arm/xilinx_zynq.c | 1 -
 hw/arm/z2.c  | 1 -
 hw/block/dataplane/virtio-blk.c  | 1 -
 hw/block/virtio-blk.c| 1 -
 hw/core/qdev-properties.c| 1 -
 hw/cris/axis_dev88.c | 1 -
 hw/display/tc6393xb.c| 1 -
 hw/ide/pci.c | 1 -
 hw/ide/via.c | 1 -
 hw/isa/isa-superio.c | 1 -
 hw/lm32/lm32_boards.c| 1 -
 hw/lm32/milkymist.c  | 1 -
 hw/microblaze/petalogix_ml605_mmu.c  | 1 -
 hw/microblaze/petalogix_s3adsp1800_mmu.c | 1 -
 hw/mips/mips_r4k.c   | 1 -
 hw/ppc/spapr.c   | 1 -
 hw/ppc/virtex_ml507.c| 2 --
 hw/s390x/virtio-ccw.c| 1 -
 hw/scsi/mptsas.c | 1 -
 hw/sd/pl181.c| 1 -
 hw/sd/sdhci.c| 1 -
 hw/sd/ssi-sd.c   | 1 -
 hw/sh4/r2d.c | 1 -
 hw/virtio/virtio-pci.c   | 1 -
 hw/xen/xen_devconfig.c   | 1 -
 hw/xtensa/xtfpga.c   | 1 -
 38 files changed, 39 deletions(-)

diff --git a/hw/arm/collie.c b/hw/arm/collie.c
index f8c566e2e5..48b732c176 100644
--- a/hw/arm/collie.c
+++ b/hw/arm/collie.c
@@ -16,7 +16,6 @@
 #include "strongarm.h"
 #include "hw/arm/arm.h"
 #include "hw/block/flash.h"
-#include "sysemu/block-backend.h"
 #include "exec/address-spaces.h"
 #include "cpu.h"
 
diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c
index ea2a3c532d..56cb763c4e 100644
--- a/hw/arm/gumstix.c
+++ b/hw/arm/gumstix.c
@@ -42,7 +42,6 @@
 #include "hw/block/flash.h"
 #include "hw/devices.h"
 #include "hw/boards.h"
-#include "sysemu/block-backend.h"
 #include "exec/address-spaces.h"
 #include "sysemu/qtest.h"
 #include "cpu.h"
diff --git a/hw/arm/mainstone.c b/hw/arm/mainstone.c
index 4215c025fc..0beb5c426b 100644
--- a/hw/arm/mainstone.c
+++ b/hw/arm/mainstone.c
@@ -21,7 +21,6 @@
 #include "hw/devices.h"
 #include "hw/boards.h"
 #include "hw/block/flash.h"
-#include "sysemu/block-backend.h"
 #include "hw/sysbus.h"
 #include "exec/address-spaces.h"
 #include "sysemu/qtest.h"
diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index 32687afced..906b7ca22d 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -35,7 +35,6 @@
 #include "hw/hw.h"
 #include "hw/bt.h"
 #include "hw/loader.h"
-#include "sysemu/block-backend.h"
 #include "hw/sysbus.h"
 #include "qemu/log.h"
 #include "exec/address-spaces.h"
diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c
index e54c1f8f99..854996c1ac 100644
--- a/hw/arm/omap1.c
+++ b/hw/arm/omap1.c
@@ -28,7 +28,6 @@
 #include "hw/arm/omap.h"
 #include "sysemu/sysemu.h"
 #include "hw/arm/soc_dma.h"
-#include "sysemu/block-backend.h"
 #include "sysemu/blockdev.h"
 #include "sysemu/qtest.h"
 #include "qemu/range.h"
diff --git a/hw/arm/omap2.c b/hw/arm/omap2.c
index b8d0910a1f..cc4250b7da 100644
--- a/hw/arm/omap2.c
+++ b/hw/arm/omap2.c
@@ -23,7 +23,6 @@
 #include "qapi/error.h"
 #include "qemu-common.h"
 #include "cpu.h"
-#include "sysemu/block-backend.h"
 #include "sysemu/blockdev.h"
 #include "sysemu/qtest.h"
 #include "hw/boards.h"
diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c
index eccc19c77b..84550f0236 100644
--- a/hw/arm/omap_sx1.c
+++ b/hw/arm/omap_sx1.c
@@ -33,7 +33,6 @@
 #include "hw/boards.h"
 #include "hw/arm/arm.h"
 #include "hw/block/flash.h"
-#include "sysemu/block-backend.h"
 #include "sysemu/qtest.h"
 #include "exec/address-spaces.h"
 #include "cpu.h"
diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c
index a2803fdee4..b67b0cefb6 100644
--- a/hw/arm/pxa2xx.c
+++ b/hw/arm/pxa2xx.c
@@ -19,7 +19,6 @@
 #include "hw/i2c/i2c.h"
 #include "hw/ssi/ssi.h"
 #include "chardev/char-fe.h"
-#include "sysemu/block-backend.h"
 #include "sysemu/blockdev.h"
 #include "sysemu/qtest.h"
 #include "qemu/cutils.h"
diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c
index e419e3c00e..3cc27a1e44 100644
--- a/hw/arm/spitz.c
+++ b/hw/arm/spitz.c
@@ -27,7 +27,6 @@
 #include "hw/audio/wm8750.h"
 #include "audio/audio.h"
 #include "hw/boards.h"
-#include "sysemu/block-backend.h"
 #include "hw/sysbus.h"
 

[Xen-devel] [xen-unstable-smoke test] 123319: regressions - FAIL

[osstest service owner]

flight 123319 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123319/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 123071

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass

version targeted for testing:
 xen  4712c0a231f010253a5471531e335a5a13dcec76
baseline version:
 xen  fc5805daef091240cd5fc06634a8bcdb2f3bb843

Last test of basis   123071  2018-05-22 15:00:29 Z6 days
Failing since123296  2018-05-28 10:01:06 Z0 days6 attempts
Testing same since   123306  2018-05-28 16:06:06 Z0 days3 attempts


People who touched revisions under test:
  Andrew Cooper 
  Jan Beulich 

jobs:
 build-arm64-xsm  pass
 build-amd64  pass
 build-armhf  pass
 build-amd64-libvirt  pass
 test-armhf-armhf-xl  pass
 test-arm64-arm64-xl-xsm  fail
 test-amd64-amd64-xl-qemuu-debianhvm-i386 pass
 test-amd64-amd64-libvirt pass



sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.


commit 4712c0a231f010253a5471531e335a5a13dcec76
Author: Andrew Cooper 
Date:   Thu May 24 15:06:16 2018 +0100

x86/traps: Dump the instruction stream even for double faults

This helps debug #DF's which occur in alternative patches

Reported-by: George Dunlap 
Signed-off-by: Andrew Cooper 
Reviewed-by: Jan Beulich 
Release-acked-by: Juergen Gross 

commit 6b9562dac1746014ab376bd2cf8ba400acf34c6d
Author: Jan Beulich 
Date:   Mon May 28 11:20:26 2018 +0200

x86/XPTI: fix S3 resume (and CPU offlining in general)

We should index an L1 table with an L1 index.

Reported-by: Simon Gaiser 
Signed-off-by: Jan Beulich 
Reviewed-by: Andrew Cooper 
Release-acked-by: Juergen Gross 
(qemu changes not included)

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] Question about patch "svm: fix incorrect TSC scaling"

[Dongli Zhang]

Hi Haozhong and AMD SVM maintainers,

I am writing to ask about below patch as I am not familiar with AMD tsc
scaling:

 commit 11eeca65126e51f03a883907751d5ccbe4f35aa3
 Author: Haozhong Zhang 
 Date:   Tue Dec 8 09:46:12 2015 +0100

 svm: fix incorrect TSC scaling
 
 SVM TSC ratio is incorrectly used in the current
 svm_get_tsc_offset(). This patch replaces the scaling logic in
 svm_get_tsc_offset() with a correct implementation.
 
 Signed-off-by: Haozhong Zhang 
 Reviewed-by: Boris Ostrovsky 


The below equation is used in the above patch:

-
host_tsc * ratio * 2^-32.
-


While the below incorrect equation (indeed code) was used before above patch:

---
offset = (((host_tsc >> 32U) * (ratio >> 32U)) << 32U) +
 (host_tsc & 0xULL) * (ratio & 0xULL);
return guest_tsc - offset;
---

Can I summarize the above code as:

tsc_h * mult * 2^32 + tsc_l * frag or

tsc_h * int * 2^32 + tsc_l * frag ?


Would you please help confirm why the equation is replaced? Or would you please
help and let me know the chapter/page of AMD reference manual showing the
correct equation?

Thank you very much!

Dongli Zhang

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [libvirt test] 123285: regressions - FAIL

[osstest service owner]

flight 123285 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123285/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-xsm  6 xen-install  fail REGR. vs. 123189

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail  like 123189
 test-armhf-armhf-libvirt 14 saverestore-support-checkfail  like 123189
 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail  like 123189
 test-amd64-i386-libvirt  13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt-xsm  13 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-arm64-arm64-libvirt 13 migrate-support-checkfail   never pass
 test-arm64-arm64-libvirt 14 saverestore-support-checkfail   never pass
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail   never pass
 test-arm64-arm64-libvirt-qcow2 12 migrate-support-checkfail never pass
 test-arm64-arm64-libvirt-qcow2 13 saverestore-support-checkfail never pass

version targeted for testing:
 libvirt  4804a4db33a37f828d033733bc47f6eff5d262c3
baseline version:
 libvirt  b9eb0145eb3879c63152227afc0be0a1f5b8514a

Last test of basis   123189  2018-05-25 07:51:05 Z3 days
Testing same since   123212  2018-05-26 09:44:19 Z2 days3 attempts


People who touched revisions under test:
  Jiri Denemark 
  John Ferlan 
  Michal Privoznik 
  Roland Schulz 

jobs:
 build-amd64-xsm  pass
 build-arm64-xsm  pass
 build-armhf-xsm  pass
 build-i386-xsm   pass
 build-amd64  pass
 build-arm64  pass
 build-armhf  pass
 build-i386   pass
 build-amd64-libvirt  pass
 build-arm64-libvirt  pass
 build-armhf-libvirt  pass
 build-i386-libvirt   pass
 build-amd64-pvopspass
 build-arm64-pvopspass
 build-armhf-pvopspass
 build-i386-pvops pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm   pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsmpass
 test-amd64-amd64-libvirt-xsm pass
 test-arm64-arm64-libvirt-xsm fail
 test-armhf-armhf-libvirt-xsm pass
 test-amd64-i386-libvirt-xsm  pass
 test-amd64-amd64-libvirt pass
 test-arm64-arm64-libvirt pass
 test-armhf-armhf-libvirt pass
 test-amd64-i386-libvirt  pass
 test-amd64-amd64-libvirt-pairpass
 test-amd64-i386-libvirt-pair pass
 test-arm64-arm64-libvirt-qcow2   pass
 test-armhf-armhf-libvirt-raw pass
 test-amd64-amd64-libvirt-vhd pass



sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

[Xen-devel] [PATCH v2] x86/xen: Combine PV features to be disabled in xen_nopv

[Joao Martins]

From: Konrad Rzeszutek Wilk 

Extend 'xen_nopv' parameter to disable individual features in
the following format:

xen_nopv={ [spin,][ipi] | all }

'spin' to disable PV spinlocks
'ipi' to disable PV IPI
'all' to disable all of the above and PV drivers

'all' ideally would be the set of features that can be disabled with
xen_nopv. Albeit it is disabling PV features and drivers because it has
been the behaviour of all past kernels. Thus users should not see a
difference when specifying no value. Also, deprecate 'xen_nopvspin' as
we are making it part of 'xen_nopv'.

Signed-off-by: Konrad Rzeszutek Wilk 
Signed-off-by: Joao Martins 
---
Changes since RFC:
 (https://lists.xenproject.org/archives/html/xen-devel/2015-10/msg00898.html
  Comments from Boris, and new changes)
 - Improve subject and commit message
 - Fix Documentation format and deprecate 'xen_nopvspin' instead of removing it
 - Make existing 'xen_nopvspin' command line use the same masking
 helpers as xen_nopv
 - Use xen_nopv_ipi() accordingly
 - Do not create unused irqs when disabling PV IPI
---
 Documentation/admin-guide/kernel-parameters.txt | 13 --
 arch/x86/xen/enlighten_hvm.c| 55 ++---
 arch/x86/xen/smp.c  | 21 ++
 arch/x86/xen/smp_hvm.c  | 14 +--
 arch/x86/xen/spinlock.c |  9 ++--
 arch/x86/xen/xen-ops.h  |  9 
 6 files changed, 96 insertions(+), 25 deletions(-)

diff --git a/Documentation/admin-guide/kernel-parameters.txt 
b/Documentation/admin-guide/kernel-parameters.txt
index f2040d46f095..3f29ee4741bb 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -4807,12 +4807,19 @@
never -- do not unplug even if version check succeeds
 
xen_nopvspin[X86,XEN]
+   [Deprecated - use xen_nopv=spin]
Disables the ticketlock slowpath using Xen PV
optimizations.
 
-   xen_nopv[X86]
-   Disables the PV optimizations forcing the HVM guest to
-   run as generic HVM guest with no PV drivers.
+   xen_nopv=   [X86,XEN]
+   Disables various (or all) PV optimizations forcing the
+   HVM (or PV) guest to run without them. No value
+   specified defaults to 'all'.
+   Format: { [spin,][ipi,] | all }
+   all -- every PV feature on HVM, including PV drivers.
+   spin -- Disables the ticketlock slowpath using Xen PV
+optimizations (PV and HVM).
+   ipi -- Disable PV IPIs (on HVM).
 
xirc2ps_cs= [NET,PCMCIA]
Format:
diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
index 19c1ff542387..c396671dadd5 100644
--- a/arch/x86/xen/enlighten_hvm.c
+++ b/arch/x86/xen/enlighten_hvm.c
@@ -208,17 +208,62 @@ static void __init xen_hvm_guest_init(void)
 #endif
 }
 
-static bool xen_nopv;
+static unsigned int xen_nopv_feat;
+
+static bool xen_nopv(void)
+{
+   return xen_nopv_feat == XEN_NOPV_ALL;
+}
+
+bool xen_nopv_ipi(void)
+{
+   return xen_nopv_feat & XEN_NOPV_IPI;
+}
+
+bool xen_nopv_spin(void)
+{
+   return xen_nopv_feat & XEN_NOPV_SPIN;
+}
+
+void xen_set_nopv(unsigned int mask)
+{
+   xen_nopv_feat |= mask;
+}
+
 static __init int xen_parse_nopv(char *arg)
 {
-   xen_nopv = true;
-   return 0;
+   char *p, *q;
+   int l;
+
+   xen_nopv_feat = arg ? 0 : XEN_NOPV_ALL;
+
+   for (p = arg; p; p = q) {
+   q = strchr(p, ',');
+   if (q) {
+   l = q - p;
+   q++;
+   } else {
+   l = strlen(p);
+   }
+   if (!strncmp(p, "spin", l))
+   xen_nopv_feat |= XEN_NOPV_SPIN;
+   else if (!strncmp(p, "ipi", l))
+   xen_nopv_feat |= XEN_NOPV_IPI;
+   else if (!strncmp(p, "all", l))
+   xen_nopv_feat = XEN_NOPV_ALL;
+   else
+   pr_warn("unrecognised option '%s' for 'xen_nopv'\n", p);
+   }
+
+   pr_debug("xen_nopv_feat = 0x%x\n", xen_nopv_feat);
+
+   return 0;
 }
 early_param("xen_nopv", xen_parse_nopv);
 
 bool xen_hvm_need_lapic(void)
 {
-   if (xen_nopv)
+   if (xen_nopv())
return false;
if (xen_pv_domain())
return false;
@@ -232,7 +277,7 @@ EXPORT_SYMBOL_GPL(xen_hvm_need_lapic);
 
 static uint32_t __init xen_platform_hvm(void)
 {
-   if (xen_pv_domain() || xen_nopv)
+   if (xen_pv_domain() || xen_nopv())
return 0;
 
return xen_cpuid_base();
diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
index 

[Xen-devel] [xen-unstable-smoke test] 123313: regressions - FAIL

[osstest service owner]

flight 123313 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123313/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 123071

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass

version targeted for testing:
 xen  4712c0a231f010253a5471531e335a5a13dcec76
baseline version:
 xen  fc5805daef091240cd5fc06634a8bcdb2f3bb843

Last test of basis   123071  2018-05-22 15:00:29 Z6 days
Failing since123296  2018-05-28 10:01:06 Z0 days5 attempts
Testing same since   123306  2018-05-28 16:06:06 Z0 days2 attempts


People who touched revisions under test:
  Andrew Cooper 
  Jan Beulich 

jobs:
 build-arm64-xsm  pass
 build-amd64  pass
 build-armhf  pass
 build-amd64-libvirt  pass
 test-armhf-armhf-xl  pass
 test-arm64-arm64-xl-xsm  fail
 test-amd64-amd64-xl-qemuu-debianhvm-i386 pass
 test-amd64-amd64-libvirt pass



sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.


commit 4712c0a231f010253a5471531e335a5a13dcec76
Author: Andrew Cooper 
Date:   Thu May 24 15:06:16 2018 +0100

x86/traps: Dump the instruction stream even for double faults

This helps debug #DF's which occur in alternative patches

Reported-by: George Dunlap 
Signed-off-by: Andrew Cooper 
Reviewed-by: Jan Beulich 
Release-acked-by: Juergen Gross 

commit 6b9562dac1746014ab376bd2cf8ba400acf34c6d
Author: Jan Beulich 
Date:   Mon May 28 11:20:26 2018 +0200

x86/XPTI: fix S3 resume (and CPU offlining in general)

We should index an L1 table with an L1 index.

Reported-by: Simon Gaiser 
Signed-off-by: Jan Beulich 
Reviewed-by: Andrew Cooper 
Release-acked-by: Juergen Gross 
(qemu changes not included)

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [linux-3.18 test] 123274: tolerable FAIL - PUSHED

[osstest service owner]

flight 123274 linux-3.18 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123274/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-multivcpu  6 xen-install fail in 123222 pass in 123274
 test-armhf-armhf-xl-arndale   6 xen-installfail pass in 123222
 test-amd64-amd64-rumprun-amd64 17 rumprun-demo-xenstorels/xenstorels.repeat 
fail pass in 123222

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine  1 build-check(1)   blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)   blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)   blocked  n/a
 test-arm64-arm64-xl-xsm   1 build-check(1)   blocked  n/a
 test-arm64-arm64-xl   1 build-check(1)   blocked  n/a
 test-armhf-armhf-xl-arndale 13 migrate-support-check fail in 123222 never pass
 test-armhf-armhf-xl-arndale 14 saverestore-support-check fail in 123222 never 
pass
 test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail  like 123035
 test-armhf-armhf-libvirt 14 saverestore-support-checkfail  like 123035
 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 123035
 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 123035
 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 123035
 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail  like 123035
 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 123035
 build-arm64-pvops 6 kernel-build fail   never pass
 test-amd64-amd64-xl-pvhv2-intel 12 guest-start fail never pass
 test-amd64-amd64-xl-pvhv2-amd 12 guest-start  fail  never pass
 test-amd64-i386-xl-pvshim12 guest-start  fail   never pass
 test-amd64-i386-libvirt  13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt-xsm  13 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2  fail never pass
 test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-cubietruck 13 migrate-support-checkfail never pass
 test-armhf-armhf-xl-cubietruck 14 saverestore-support-checkfail never pass
 test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt 13 migrate-support-checkfail   never pass
 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass
 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass
 test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail   never pass
 test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop  fail never pass
 test-armhf-armhf-xl-vhd  12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-vhd  13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail  never pass
 test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail  never pass
 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop  fail never pass
 test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass
 test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail never pass
 test-amd64-amd64-xl-qemut-win10-i386 10 windows-installfail never pass
 test-amd64-i386-xl-qemut-win10-i386 10 windows-install fail never pass

version targeted for testing:
 linuxb87af3ab9dae0dc53b201701725ed6e2af4f2f74
baseline version:
 linux7eac0d47b74e08e7060e293527524986554b

Last test of basis   123035  2018-05-21 13:52:01 Z7 days
Testing same since   123190  2018-05-25 09:11:20 Z3 days3 attempts


People who touched revisions under test:
  

[Xen-devel] [xen-unstable-smoke test] 123306: regressions - FAIL

[osstest service owner]

flight 123306 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123306/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 123071

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass

version targeted for testing:
 xen  4712c0a231f010253a5471531e335a5a13dcec76
baseline version:
 xen  fc5805daef091240cd5fc06634a8bcdb2f3bb843

Last test of basis   123071  2018-05-22 15:00:29 Z6 days
Failing since123296  2018-05-28 10:01:06 Z0 days4 attempts
Testing same since   123306  2018-05-28 16:06:06 Z0 days1 attempts


People who touched revisions under test:
  Andrew Cooper 
  Jan Beulich 

jobs:
 build-arm64-xsm  pass
 build-amd64  pass
 build-armhf  pass
 build-amd64-libvirt  pass
 test-armhf-armhf-xl  pass
 test-arm64-arm64-xl-xsm  fail
 test-amd64-amd64-xl-qemuu-debianhvm-i386 pass
 test-amd64-amd64-libvirt pass



sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.


commit 4712c0a231f010253a5471531e335a5a13dcec76
Author: Andrew Cooper 
Date:   Thu May 24 15:06:16 2018 +0100

x86/traps: Dump the instruction stream even for double faults

This helps debug #DF's which occur in alternative patches

Reported-by: George Dunlap 
Signed-off-by: Andrew Cooper 
Reviewed-by: Jan Beulich 
Release-acked-by: Juergen Gross 

commit 6b9562dac1746014ab376bd2cf8ba400acf34c6d
Author: Jan Beulich 
Date:   Mon May 28 11:20:26 2018 +0200

x86/XPTI: fix S3 resume (and CPU offlining in general)

We should index an L1 table with an L1 index.

Reported-by: Simon Gaiser 
Signed-off-by: Jan Beulich 
Reviewed-by: Andrew Cooper 
Release-acked-by: Juergen Gross 
(qemu changes not included)

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [ovmf test] 123281: all pass - PUSHED

[osstest service owner]

flight 123281 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123281/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf 20274d2389eb012812f4561c8eb7cffc57a68850
baseline version:
 ovmf 03ac238b1fe40cfbb1424bf72e2ac8276345e03c

Last test of basis   123204  2018-05-26 04:38:15 Z2 days
Testing same since   123281  2018-05-28 01:40:43 Z0 days1 attempts


People who touched revisions under test:
  Jaben Carsey 
  Zurcher, Christopher J 

jobs:
 build-amd64-xsm  pass
 build-i386-xsm   pass
 build-amd64  pass
 build-i386   pass
 build-amd64-libvirt  pass
 build-i386-libvirt   pass
 build-amd64-pvopspass
 build-i386-pvops pass
 test-amd64-amd64-xl-qemuu-ovmf-amd64 pass
 test-amd64-i386-xl-qemuu-ovmf-amd64  pass



sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   03ac238b1f..20274d2389  20274d2389eb012812f4561c8eb7cffc57a68850 -> 
xen-tested-master

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [linux-linus test] 123271: regressions - FAIL

[osstest service owner]

flight 123271 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123271/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 123188
 test-arm64-arm64-libvirt-xsm  6 xen-install  fail REGR. vs. 123188
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 13 guest-saverestore 
fail REGR. vs. 123188
 test-amd64-amd64-xl-qemut-debianhvm-amd64 16 guest-localmigrate/x10 fail REGR. 
vs. 123188

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail  like 123188
 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 123188
 test-armhf-armhf-libvirt 14 saverestore-support-checkfail  like 123188
 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 123188
 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 123188
 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 123188
 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail  like 123188
 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stopfail like 123188
 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stopfail like 123188
 test-amd64-i386-xl-pvshim12 guest-start  fail   never pass
 test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt-xsm  13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt  13 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl-credit2  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl-credit2  14 saverestore-support-checkfail   never pass
 test-arm64-arm64-xl  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl  14 saverestore-support-checkfail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-armhf-armhf-xl-arndale  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-arndale  14 saverestore-support-checkfail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2  fail never pass
 test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail  never pass
 test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail  never pass
 test-armhf-armhf-xl-xsm  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-cubietruck 13 migrate-support-checkfail never pass
 test-armhf-armhf-xl-credit2  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-cubietruck 14 saverestore-support-checkfail never pass
 test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-vhd  12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-vhd  13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 14 saverestore-support-checkfail   never pass
 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop  fail never pass
 test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop  fail never pass
 test-amd64-amd64-xl-qemut-win10-i386 10 windows-installfail never pass
 test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail never pass
 test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass
 test-amd64-i386-xl-qemut-win10-i386 10 windows-install fail never pass

version targeted for testing:
 linuxb04e217704b7f879c6b91222b066983a44a7a09f
baseline version:
 linuxb50694381cfc22dce3a60a291cdae294a5e5777c

Last test of basis   123188  2018-05-24 22:54:06 Z3 days
Failing since123218  2018-05-26 12:19:54 Z2 days2 attempts
Testing same since   123271  2018-05-27 21:07:59 Z0 days1 attempts


People who touched revisions under test:
  Adi Nissim 
  Alex Deucher 
  Alexei Starovoitov 
  Alexey Kardashevskiy 
  Alexey Kodanev 
  Anders Roxell 
  Andrew 

[Xen-devel] [qemu-mainline test] 123268: regressions - FAIL

[osstest service owner]

flight 123268 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123268/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 122357
 test-arm64-arm64-libvirt-xsm  6 xen-install  fail REGR. vs. 122357
 test-amd64-i386-freebsd10-i386 14 guest-saverestore  fail REGR. vs. 122357
 test-amd64-i386-freebsd10-amd64 14 guest-saverestore fail REGR. vs. 122357
 test-amd64-i386-xl-qemuu-ovmf-amd64 13 guest-saverestore fail REGR. vs. 122357
 test-amd64-amd64-xl-qemuu-ovmf-amd64 13 guest-saverestore fail REGR. vs. 122357
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 guest-saverestore fail 
REGR. vs. 122357
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 13 guest-saverestore fail 
REGR. vs. 122357
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 13 guest-saverestore fail 
REGR. vs. 122357
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 13 guest-saverestore fail REGR. 
vs. 122357
 test-amd64-amd64-xl-qemuu-win7-amd64 13 guest-saverestore fail REGR. vs. 122357
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 13 guest-saverestore fail REGR. vs. 
122357
 test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 13 guest-saverestore fail REGR. 
vs. 122357
 test-amd64-i386-xl-qemuu-win7-amd64 13 guest-saverestore fail REGR. vs. 122357
 test-amd64-i386-xl-qemuu-debianhvm-amd64 13 guest-saverestore fail REGR. vs. 
122357
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 guest-saverestore fail 
REGR. vs. 122357
 test-amd64-i386-xl-qemuu-ws16-amd64 13 guest-saverestore fail REGR. vs. 122357
 test-amd64-amd64-xl-qemuu-ws16-amd64 13 guest-saverestore fail REGR. vs. 122357

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt 14 saverestore-support-checkfail  like 122357
 test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail  like 122357
 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail  like 122357
 test-amd64-amd64-xl-pvhv2-intel 12 guest-start fail never pass
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-amd64-amd64-xl-pvhv2-amd 12 guest-start  fail  never pass
 test-amd64-i386-xl-pvshim12 guest-start  fail   never pass
 test-amd64-i386-libvirt-xsm  13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl-credit2  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl  14 saverestore-support-checkfail   never pass
 test-arm64-arm64-xl-credit2  14 saverestore-support-checkfail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-arndale  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-arndale  14 saverestore-support-checkfail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-armhf-armhf-libvirt 13 migrate-support-checkfail   never pass
 test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2  fail never pass
 test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-cubietruck 13 migrate-support-checkfail never pass
 test-armhf-armhf-xl-cubietruck 14 saverestore-support-checkfail never pass
 test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail  never pass
 test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail  never pass
 test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-vhd  12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-vhd  13 saverestore-support-checkfail   never pass
 test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail never pass
 test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass

version targeted for testing:
 qemuu

Re: [Xen-devel] [External] Re: [RFC PATCH v2 00/12] get rid of GFP_ZONE_TABLE/BAD

[Michal Hocko]

On Fri 25-05-18 09:43:09, Huaisheng HS1 Ye wrote:
> From: Michal Hocko [mailto:mho...@kernel.org]
> Sent: Thursday, May 24, 2018 8:19 PM> 
> > > Let me try to reply your questions.
> > > Exactly, GFP_ZONE_TABLE is too complicated. I think there are two 
> > > advantages
> > > from the series of patches.
> > >
> > > 1. XOR operation is simple and efficient, GFP_ZONE_TABLE/BAD need to do 
> > > twice
> > > shift operations, the first is for getting a zone_type and the second is 
> > > for
> > > checking the to be returned type is a correct or not. But with these 
> > > patch XOR
> > > operation just needs to use once. Because the bottom 3 bits of GFP 
> > > bitmask have
> > > been used to represent the encoded zone number, we can say there is no 
> > > bad zone
> > > number if all callers could use it without buggy way. Of course, the 
> > > returned
> > > zone type in gfp_zone needs to be no more than ZONE_MOVABLE.
> > 
> > But you are losing the ability to check for wrong usage. And it seems
> > that the sad reality is that the existing code do screw up.
> 
> In my opinion, originally there shouldn't be such many wrong
> combinations of these bottom 3 bits. For any user, whether or
> driver and fs, they should make a decision that which zone is they
> preferred. Matthew's idea is great, because with it the user must
> offer an unambiguous flag to gfp zone bits.

Well, I would argue that those shouldn't really care about any zones at
all. All they should carea bout is whether they really need a low mem
zone (aka directly accessible to the kernel), highmem or they are the
allocation is generally movable. Mixing zones into the picture just
makes the whole thing more complicated and error prone.
[...]
> > That being said. I am not saying that I am in love with GFP_ZONE_TABLE.
> > It always makes my head explode when I look there but it seems to work
> > with the current code and it is optimized for it. If you want to change
> > this then you should make sure you describe reasons _why_ this is an
> > improvement. And I would argue that "we can have more zones" is a
> > relevant one.
> 
> Yes, GFP_ZONE_TABLE is too complicated. The patches have 4 advantages as 
> below.
> 
> * The address zone modifiers have new operation method, that is, user should 
> decide which zone is preferred at first, then give the encoded zone number to 
> bottom 3 bits in GFP mask. That is much direct and clear than before.
> 
> * No bad zone combination, because user should choose just one address zone 
> modifier always.
> * Better performance and efficiency, current gfp_zone has to take shifting 
> operation twice for GFP_ZONE_TABLE and GFP_ZONE_BAD. With these patches, 
> gfp_zone() just needs one XOR.
> * Up to 8 zones can be used. At least it isn't a disadvantage, right?

This should be a part of the changelog. Please note that you should
provide some number if you claim performance benefits. The complexity
will always be subjective.
-- 
Michal Hocko
SUSE Labs

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH][next] ALSA: xen-front: remove redundant error check on ret

[Takashi Iwai]

On Mon, 28 May 2018 00:42:12 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On May 28 2018 06:23, Colin King wrote:
> > From: Colin Ian King 
> >
> > The error for a -ve value in ret is redundant as all previous
> > assignments to ret have an associated -ve check and hence it
> > is impossible for ret to be less that zero at the point of the
> > check.  Remove this redundant error check.
> >
> > Detected by CoveritScan, CID#1469407 ("Logically Dead code")
> >
> > Signed-off-by: Colin Ian King 
> > ---
> >   sound/xen/xen_snd_front_evtchnl.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/sound/xen/xen_snd_front_evtchnl.c 
> > b/sound/xen/xen_snd_front_evtchnl.c
> > index d70a62e7f910..102d6e096cc8 100644
> > --- a/sound/xen/xen_snd_front_evtchnl.c
> > +++ b/sound/xen/xen_snd_front_evtchnl.c
> > @@ -351,8 +351,6 @@ int xen_snd_front_evtchnl_create_all(struct 
> > xen_snd_front_info *front_info,
> > }
> > }
> > }
> > -   if (ret < 0)
> > -   goto fail;
> > front_info->num_evt_pairs = num_streams;
> > return 0;
> 
> Yep. All branches for error path on the nested for loop have goto
> statement, thus no need to check error outer the loop.
> 
> Reviewed-by: Takashi Sakamoto 

Applied, thanks.


Takashi

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH] ALSA: xen: ensure nul-terminated device name

[Arnd Bergmann]

gcc-8 warns that pcm_instance->name is not necessarily terminated correctly
if the input is more than 80 characters long or lacks a termination byte
itself:

In function 'strncpy',
inlined from 'cfg_device' at sound/xen/xen_snd_front_cfg.c:399:3,
inlined from 'xen_snd_front_cfg_card' at 
sound/xen/xen_snd_front_cfg.c:509:9:
include/linux/string.h:254:9: error: '__builtin_strncpy' specified bound 80 
equals destination size [-Werror=stringop-truncation]
  return __builtin_strncpy(p, q, size);

Using strlcpy() instead of strncpy() makes this a bit safer.

Fixes: fd3b36045c2c ("ALSA: xen-front: Read sound driver configuration from Xen 
store")
Signed-off-by: Arnd Bergmann 
---
 sound/xen/xen_snd_front_cfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/xen/xen_snd_front_cfg.c b/sound/xen/xen_snd_front_cfg.c
index 38c7e1eefbb9..684b5f1d51ac 100644
--- a/sound/xen/xen_snd_front_cfg.c
+++ b/sound/xen/xen_snd_front_cfg.c
@@ -396,7 +396,7 @@ static int cfg_device(struct xen_snd_front_info *front_info,
 
str = xenbus_read(XBT_NIL, device_path, XENSND_FIELD_DEVICE_NAME, NULL);
if (!IS_ERR(str)) {
-   strncpy(pcm_instance->name, str, sizeof(pcm_instance->name));
+   strlcpy(pcm_instance->name, str, sizeof(pcm_instance->name));
kfree(str);
}
 
-- 
2.9.0


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [xen-unstable-smoke test] 123303: regressions - FAIL

[osstest service owner]

flight 123303 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123303/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 123071

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass

version targeted for testing:
 xen  6b9562dac1746014ab376bd2cf8ba400acf34c6d
baseline version:
 xen  fc5805daef091240cd5fc06634a8bcdb2f3bb843

Last test of basis   123071  2018-05-22 15:00:29 Z6 days
Testing same since   123296  2018-05-28 10:01:06 Z0 days3 attempts


People who touched revisions under test:
  Jan Beulich 

jobs:
 build-arm64-xsm  pass
 build-amd64  pass
 build-armhf  pass
 build-amd64-libvirt  pass
 test-armhf-armhf-xl  pass
 test-arm64-arm64-xl-xsm  fail
 test-amd64-amd64-xl-qemuu-debianhvm-i386 pass
 test-amd64-amd64-libvirt pass



sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.


commit 6b9562dac1746014ab376bd2cf8ba400acf34c6d
Author: Jan Beulich 
Date:   Mon May 28 11:20:26 2018 +0200

x86/XPTI: fix S3 resume (and CPU offlining in general)

We should index an L1 table with an L1 index.

Reported-by: Simon Gaiser 
Signed-off-by: Jan Beulich 
Reviewed-by: Andrew Cooper 
Release-acked-by: Juergen Gross 
(qemu changes not included)

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [RFC PATCH v2 00/12] get rid of GFP_ZONE_TABLE/BAD

[Michal Hocko]

On Fri 25-05-18 05:00:44, Matthew Wilcox wrote:
> On Thu, May 24, 2018 at 05:29:43PM +0200, Michal Hocko wrote:
> > > ie if we had more,
> > > could we solve our pain by making them more generic?
> > 
> > Well, if you have more you will consume more bits in the struct pages,
> > right?
> 
> Not necessarily ... the zone number is stored in the struct page
> currently, so either two or three bits are used right now.  In my
> proposal, one can infer the zone of a page from its PFN, except for
> ZONE_MOVABLE.  So we could trim down to just one bit per struct page
> for 32-bit machines while using 3 bits on 64-bit machines, where there
> is plenty of space.

Just be warned that page_zone is called from many hot paths. I am not
sure adding something more complex there is going to fly.

> > > it more-or-less sucks that the devices with 28-bit DMA limits are forced
> > > to allocate from the low 16MB when they're perfectly capable of using the
> > > low 256MB.
> > 
> > Do we actually care all that much about those? If yes then we should
> > probably follow the ZONE_DMA (x86) path and use a CMA region for them.
> > I mean most devices should be good with very limited addressability or
> > below 4G, no?
> 
> Sure.  One other thing I meant to mention was the media devices
> (TV capture cards and so on) which want a vmalloc_32() allocation.
> On 32-bit machines right now, we allocate from LOWMEM, when we really
> should be allocating from the 1GB-4GB region.  32-bit machines generally
> don't have a ZONE_DMA32 today.

Well, _I_ think that vmalloc on 32b is just lost case...

-- 
Michal Hocko
SUSE Labs

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/XPTI: fix S3 resume (and CPU offlining in general)

[Juergen Gross]

On 24/05/18 15:41, Jan Beulich wrote:
> In commit d1d6fc97d6 ("x86/xpti: really hide almost all of Xen image")
> I've failed to remember the fact that multiple CPUs share a stub
> mapping page. Therefore it is wrong to unconditionally zap the mapping
> when bringing down a CPU; it may only be unmapped when no other online
> CPU uses that same page.
> 
> Reported-by: Simon Gaiser 
> Signed-off-by: Jan Beulich 

Release-acked-by: Juergen Gross 


Juergen

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2] x86/XPTI: fix S3 resume (and CPU offlining in general)

[Juergen Gross]

On 25/05/18 08:02, Jan Beulich wrote:
> We should index an L1 table with an L1 index.
> 
> Reported-by: Simon Gaiser 
> Signed-off-by: Jan Beulich 

Release-acked-by: Juergen Gross 


Juergen


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] Commit moratorium is lifted

[Juergen Gross]

Committers,

With OSSTEST doing a push the commit moratorium is lifted, please commit
patches that are already Release-acked.

Juergen Gross

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] Commit moratorium is lifted

[Juergen Gross]

Committers,

With OSSTEST doing a push the commit moratorium is lifted, please commit
patches that are already Release-acked.

Juergen Gross

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format

[Takashi Iwai]

On Mon, 28 May 2018 00:49:03 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On May 28 2018 06:32, Colin King wrote:
> > From: Colin Ian King 
> >
> > The negative error return from the call to to_sndif_format is being
> > assigned to an unsigned 8 bit integer and hence the check for a negative
> > value is always going to be false.  Fix this by using ret as the error
> > return and hence the negative error can be detected and assign
> > the u8 sndif_format to ret if there is no error.
> >
> > Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")
> >
> > Signed-off-by: Colin Ian King 
> > ---
> >   sound/xen/xen_snd_front_alsa.c | 7 ---
> >   1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> > index 5041f83e98d2..5a2bd70a2fa1 100644
> > --- a/sound/xen/xen_snd_front_alsa.c
> > +++ b/sound/xen/xen_snd_front_alsa.c
> > @@ -466,13 +466,14 @@ static int alsa_prepare(struct snd_pcm_substream 
> > *substream)
> > u8 sndif_format;
> > int ret;
> >   - sndif_format = to_sndif_format(runtime->format);
> > -   if (sndif_format < 0) {
> > +   ret = to_sndif_format(runtime->format);
> > +   if (ret < 0) {
> > dev_err(>front_info->xb_dev->dev,
> > "Unsupported sample format: %d\n",
> > runtime->format);
> > -   return sndif_format;
> > +   return ret;
> > }
> > +   sndif_format = ret;
> > ret =
> > xen_snd_front_stream_prepare(>evt_pair->req,
> >>sh_buf,
> 
> Indeed. A typical assignment mistake. Instead, we could change the
> type of 'sndif_format' to signed int, however in this case it's not
> the same as the third argument of xen_snd_front_stream_prepare()
> because it is 'u8'. This patch looks good to me.
> 
> Reviewed-by: Takashi Sakamoto 

Applied, thanks.


Takashi

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 5/9] x86/vmx: Fix handing of MSR_DEBUGCTL on VMExit

[Andrew Cooper]

On 27/05/18 04:56, Tian, Kevin wrote:
>> From: Andrew Cooper [mailto:andrew.coop...@citrix.com]
>> Sent: Tuesday, May 22, 2018 7:21 PM
>>
>> Currently, whenever the guest writes a nonzero value to MSR_DEBUGCTL,
>> Xen
>> updates a host MSR load list entry with the current hardware value of
>> MSR_DEBUGCTL.  This is wrong.
>>
>> On VMExit, hardware automatically resets MSR_DEBUGCTL to 0.  The only
>> case
>> where different behaviour is needed is if Xen is debugging itself, and this
>> needs setting up unconditionally for the lifetime of the VM.
>>
>> The `ler` command line boolean is the only way to configure any use of
>> MSR_DEBUGCTL for Xen, so tie the host load list entry to this setting in
>> construct_vmcs().  Any runtime update of Xen's MSR_DEBUGCTL setting
>> requires
>> more complicated synchronisation across all the running VMs.
>>
>> In the exceedingly common case, this avoids the unnecessary overhead of
>> having
>> a host load entry performing the same zeroing operation that hardware
>> has
>> already performed as part of the VMExit.
> I didn't get "unnecessary overhead" part. if "ler' is disabled, as you
> said earlier it's a bug to save/restore thus overhead doesn't matter.

The current behaviour (bug or otherwise), means that when ler is
disabled, we end up with a host load list entry zeroing MSR_DEBUGCTL as
soon as the guest first writes to the MSR.

This causes unnecessary overhead because host load/save lists are slow.

Irrespective, I've reworked this patch differently, to fully disentangle
it from the EFER series.  See patch 1 of my "x86/vmx: Misc fixes and
improvements" series.

~Andrew

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] Debug guest state (VMI)

[Mathieu Tarral]

Hi !

I'm playing with the VMI APIs using LibVMI, and i need to track down
a bug that i reported here:
https://github.com/libvmi/libvmi/issues/621

Basically the domain is still paused even thought i called the right API
to resume it and the event buffer is supposed to be empty.

Now there are 2 possibilities
- either there is an event in the buffer waiting to be processed
- or the resume_vm function failed

Is there a way to track the state of the guest VMI event buffer ?
(what events are registered)

Is there a way to see the pause/resume operations in a guest log file ?

I found some documentation on:
https://wiki.xenproject.org/wiki/Reporting_Bugs_against_Xen_Project

using XENCONSOLED_TRACE=guest
to put in /etc/default/xencommons

However, i don't have a service named xenconsoled.service
running on my environment ??

-> Is there a general page on the Wiki which explains where are the log
file and how to debug the guests and dom0 ?

I'm using Xen 4.9.2 on Ubuntu Bionic.

Thanks for your help !

​--

Mathieu Tarral
Sent with ProtonMail Secure Email.​

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 4/9] x86/vmx: Support remote access to the MSR lists

[Andrew Cooper]

On 27/05/18 04:47, Tian, Kevin wrote:
>> From: Andrew Cooper [mailto:andrew.coop...@citrix.com]
>> Sent: Tuesday, May 22, 2018 7:21 PM
>>
>> At the moment, all modifications of the MSR lists are in current context.
>> However, future changes may need to put MSR_EFER into the lists from
>> domctl
>> hypercall context.
>>
>> Plumb a struct vcpu parameter down through the infrastructure, and use
>> vmx_vmcs_{enter,exit}() for safe access to the VMCS in vmx_add_msr().
>> Use
>> assertions to ensure that access is either in current context, or while the
>> vcpu is paused.
>>
>> For now it is safe to require that remote accesses are under the domctl lock.
>> This will remain safe if/when the global domctl lock becomes per-domain.
>>
>> Note these expectations beside the fields in arch_vmx_struct, and reorder
>> the
>> fields to avoid unnecessary padding.
>>
>> Signed-off-by: Andrew Cooper 
>> ---
>> CC: Jan Beulich 
>> CC: Jun Nakajima 
>> CC: Kevin Tian 
>> CC: Wei Liu 
>> CC: Roger Pau Monné 
>>
>> To preempt any questions about spinlocks, the use of the MSR lists in the
>> return-to-guest path causes checklock failures for plain spinlocks (despite 
>> it
>> technically being safe to live here), and the call to alloc_xenheap_page()
>> makes it impossible to use irqsave/restore variants, due to the nested
>> acquisition of the heap lock.
> I don't understand above words. How does it relate to the patch here?

It explains why I haven't/can't introduce a spinlock to protect access,
in case someone reviewing the code asks "why not introduce a spinlock".

>> @@ -1333,12 +1335,14 @@ struct vmx_msr_entry
>> *vmx_find_msr(uint32_t msr, enum vmx_msr_list_type type)
>>  return ((ent < end) && (ent->index == msr)) ? ent : NULL;
>>  }
>>
>> -int vmx_add_msr(uint32_t msr, enum vmx_msr_list_type type)
>> +int vmx_add_msr(struct vcpu *v, uint32_t msr, enum vmx_msr_list_type
>> type)
>>  {
>> -struct vcpu *curr = current;
>> -struct arch_vmx_struct *arch_vmx = >arch.hvm_vmx;
>> +struct arch_vmx_struct *arch_vmx = >arch.hvm_vmx;
>>  struct vmx_msr_entry **ptr, *start = NULL, *ent, *end;
>>  unsigned int total;
>> +int rc;
>> +
>> +ASSERT(v == current || !vcpu_runnable(v));
>>
>>  switch ( type )
>>  {
>> @@ -1357,13 +1361,18 @@ int vmx_add_msr(uint32_t msr, enum
>> vmx_msr_list_type type)
>>  return -EINVAL;
>>  }
>>
>> +vmx_vmcs_enter(v);
>> +
> why entering vmcs so early even before possible page allocation?

Because the next thing the allocation path does is write to the MSR
load/save list fields.

The alternative would be to have an else on this if(), and a second
vmcs_enter() after the memory allocation, but as these are two one-time
allocations in uncontended paths, I didn't consider the added complexity
worth it.

~Andrew

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 2/6] x86: Improvements to ler debugging

[Andrew Cooper]

 * Command line documentation for what the option does.
 * Implement a canonicalise_addr() helper and replace the opencoded use in
   sign_extend_msr()
 * Canonicalise the ler pointers and print symbol information.

Signed-off-by: Andrew Cooper 
---
CC: Jan Beulich 
CC: Jun Nakajima 
CC: Kevin Tian 
CC: Wei Liu 
CC: Roger Pau Monné 
---
 docs/misc/xen-command-line.markdown | 6 ++
 xen/arch/x86/hvm/vmx/vmx.c  | 7 +--
 xen/arch/x86/x86_64/traps.c | 7 ++-
 xen/include/asm-x86/x86_64/page.h   | 8 
 4 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/docs/misc/xen-command-line.markdown 
b/docs/misc/xen-command-line.markdown
index 8712a83..1212ebd 100644
--- a/docs/misc/xen-command-line.markdown
+++ b/docs/misc/xen-command-line.markdown
@@ -1245,6 +1245,12 @@ if left disabled by the BIOS.
 ### ler (x86)
 > `= `
 
+> Default: 0
+
+This option is intended for debugging purposes only.  Enable MSR_DEBUGCTL.LBR
+in hypervisor context to be able to dump the Last Interrupt/Exception To/From
+record with other registers.
+
 ### loglvl
 > `= [/]` where level is `none | error | warning | 
 > info | debug | all`
 
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 33d39f6..8049264 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -4183,12 +4183,7 @@ static void sign_extend_msr(u32 msr, int type)
 struct vmx_msr_entry *entry;
 
 if ( (entry = vmx_find_msr(msr, type)) != NULL )
-{
-if ( entry->data & VADDR_TOP_BIT )
-entry->data |= CANONICAL_MASK;
-else
-entry->data &= ~CANONICAL_MASK;
-}
+entry->data = canonicalise_addr(entry->data);
 }
 
 static void bdw_erratum_bdf14_fixup(void)
diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c
index b040185..ed02b78 100644
--- a/xen/arch/x86/x86_64/traps.c
+++ b/xen/arch/x86/x86_64/traps.c
@@ -150,7 +150,12 @@ void show_registers(const struct cpu_user_regs *regs)
 
 rdmsrl(ler_msr, from);
 rdmsrl(ler_msr + 1, to);
-printk("ler: %016lx -> %016lx\n", from, to);
+
+/* Upper bits may store metadata.  Re-canonicalise for printing. */
+printk("ler: from %016"PRIx64" [%ps]\n",
+   from, _p(canonicalise_addr(from)));
+printk("   to %016"PRIx64" [%ps]\n",
+   to, _p(canonicalise_addr(to)));
 }
 }
 
diff --git a/xen/include/asm-x86/x86_64/page.h 
b/xen/include/asm-x86/x86_64/page.h
index 05a0334..4fe0205 100644
--- a/xen/include/asm-x86/x86_64/page.h
+++ b/xen/include/asm-x86/x86_64/page.h
@@ -34,6 +34,14 @@
 
 #ifndef __ASSEMBLY__
 
+static inline unsigned long canonicalise_addr(unsigned long addr)
+{
+if ( addr & VADDR_TOP_BIT )
+return addr | CANONICAL_MASK;
+else
+return addr & ~CANONICAL_MASK;
+}
+
 #include 
 
 #include 
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 4/6] x86/vmx: Simplify PAT handling during vcpu construction

[Andrew Cooper]

The host PAT value is a compile time constant, and doesn't need to be read out
of hardware.  Merge this if block into the previous block, which has an
identical condition.

Signed-off-by: Andrew Cooper 
---
CC: Jan Beulich 
CC: Jun Nakajima 
CC: Kevin Tian 
CC: Wei Liu 
CC: Roger Pau Monné 
---
 xen/arch/x86/hvm/vmx/vmcs.c | 12 ++--
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 70c2fb7..be02be1 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -1246,17 +1246,9 @@ static int construct_vmcs(struct vcpu *v)
 
 ept->mfn = pagetable_get_pfn(p2m_get_pagetable(p2m));
 __vmwrite(EPT_POINTER, ept->eptp);
-}
-
-if ( paging_mode_hap(d) )
-{
-u64 host_pat, guest_pat;
-
-rdmsrl(MSR_IA32_CR_PAT, host_pat);
-guest_pat = MSR_IA32_CR_PAT_RESET;
 
-__vmwrite(HOST_PAT, host_pat);
-__vmwrite(GUEST_PAT, guest_pat);
+__vmwrite(HOST_PAT, XEN_MSR_PAT);
+__vmwrite(GUEST_PAT, MSR_IA32_CR_PAT_RESET);
 }
 if ( cpu_has_vmx_mpx )
 __vmwrite(GUEST_BNDCFGS, 0);
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 1/6] x86/vmx: Fix handing of MSR_DEBUGCTL on VMExit

[Andrew Cooper]

Currently, whenever the guest writes a nonzero value to MSR_DEBUGCTL, Xen
updates a host MSR load list entry with the current hardware value of
MSR_DEBUGCTL.  This is wrong.

On VMExit, hardware automatically resets MSR_DEBUGCTL to 0.  The only case
where different behaviour is needed is if Xen is debugging itself, and this
needs setting up unconditionally for the lifetime of the VM, rather than based
on guest actions.

This could be fixed by using a host MSR load list entry set up during
construct_vmcs().  However, a more efficient option is to use an alternative
block in the VMExit path, keyed on whether hypervisor debugging has been
enabled.

In order to set this up, drop the per cpu ler_msr variable (as there is no
point having it per cpu when it will be the same everywhere), and use a single
read_mostly variable instead.  Split calc_ler_msr() out of percpu_traps_init()
for clarity, and only perform the calculation on the first call.

Finally, clean up do_debug().  Rearrange it to have a common tail, and call
out the LBR behaviour specifically.

Signed-off-by: Andrew Cooper 
---
CC: Jan Beulich 
CC: Jun Nakajima 
CC: Kevin Tian 
CC: Wei Liu 
CC: Roger Pau Monné 

Initially, I tried to have a common xen_msr_debugctl variable, but
rip-relative addresses don't resolve correctly in alternative blocks.
LBR-only has been fine for ages, and I don't see that changing any time soon.
---
 xen/arch/x86/hvm/vmx/entry.S  |  9 ++
 xen/arch/x86/hvm/vmx/vmx.c|  3 +-
 xen/arch/x86/traps.c  | 58 +++
 xen/arch/x86/x86_64/traps.c   |  7 +++--
 xen/include/asm-x86/cpufeature.h  |  1 +
 xen/include/asm-x86/cpufeatures.h |  1 +
 xen/include/asm-x86/msr.h |  2 +-
 7 files changed, 45 insertions(+), 36 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/entry.S b/xen/arch/x86/hvm/vmx/entry.S
index aa2f103..afd552f 100644
--- a/xen/arch/x86/hvm/vmx/entry.S
+++ b/xen/arch/x86/hvm/vmx/entry.S
@@ -41,6 +41,15 @@ ENTRY(vmx_asm_vmexit_handler)
 SPEC_CTRL_ENTRY_FROM_HVM/* Req: b=curr %rsp=regs/cpuinfo, Clob: 
acd */
 /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */
 
+/* Hardware clears MSR_DEBUGCTL on VMExit.  Reinstate it if debugging 
Xen. */
+.macro restore_lbr
+mov $IA32_DEBUGCTLMSR_LBR, %eax
+mov $MSR_IA32_DEBUGCTLMSR, %ecx
+xor %edx, %edx
+wrmsr
+.endm
+ALTERNATIVE "", restore_lbr, X86_FEATURE_XEN_LBR
+
 mov  %rsp,%rdi
 call vmx_vmexit_handler
 
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 9707514..33d39f6 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3120,8 +3120,7 @@ static int vmx_msr_write_intercept(unsigned int msr, 
uint64_t msr_content)
 }
 }
 
-if ( (rc < 0) ||
- (msr_content && (vmx_add_host_load_msr(msr) < 0)) )
+if ( rc < 0 )
 hvm_inject_hw_exception(TRAP_machine_check, X86_EVENT_NO_EC);
 else
 __vmwrite(GUEST_IA32_DEBUGCTL, msr_content);
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 8a99174..74784a2 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -96,8 +96,6 @@ string_param("nmi", opt_nmi);
 DEFINE_PER_CPU(uint64_t, efer);
 static DEFINE_PER_CPU(unsigned long, last_extable_addr);
 
-DEFINE_PER_CPU_READ_MOSTLY(u32, ler_msr);
-
 DEFINE_PER_CPU_READ_MOSTLY(struct desc_struct *, gdt_table);
 DEFINE_PER_CPU_READ_MOSTLY(struct desc_struct *, compat_gdt_table);
 
@@ -117,6 +115,9 @@ integer_param("debug_stack_lines", debug_stack_lines);
 static bool opt_ler;
 boolean_param("ler", opt_ler);
 
+/* LastExceptionFromIP on this hardware.  Zero if LER is not in use. */
+uint32_t __read_mostly ler_msr;
+
 #define stack_words_per_line 4
 #define ESP_BEFORE_EXCEPTION(regs) ((unsigned long *)regs->rsp)
 
@@ -1764,17 +1765,6 @@ void do_device_not_available(struct cpu_user_regs *regs)
 return;
 }
 
-static void ler_enable(void)
-{
-u64 debugctl;
-
-if ( !this_cpu(ler_msr) )
-return;
-
-rdmsrl(MSR_IA32_DEBUGCTLMSR, debugctl);
-wrmsrl(MSR_IA32_DEBUGCTLMSR, debugctl | IA32_DEBUGCTLMSR_LBR);
-}
-
 void do_debug(struct cpu_user_regs *regs)
 {
 unsigned long dr6;
@@ -1870,13 +1860,13 @@ void do_debug(struct cpu_user_regs *regs)
 v->arch.debugreg[6] |= (dr6 & ~X86_DR6_DEFAULT);
 v->arch.debugreg[6] &= (dr6 | ~X86_DR6_DEFAULT);
 
-ler_enable();
 pv_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC);
-return;
 
  out:
-ler_enable();
-return;
+
+/* #DB automatically disabled LBR.  Reinstate it if debugging Xen. */
+if ( cpu_has_xen_lbr )
+wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR);
 }
 
 static void __init noinline __set_intr_gate(unsigned int n,

[Xen-devel] [PATCH 0/6] x86/vmx: Misc fixes and improvements

[Andrew Cooper]

Patch 1 might want to be considered for 4.11.  All others are 4.12 material at
this point.

Andrew Cooper (6):
  x86/vmx: Fix handing of MSR_DEBUGCTL on VMExit
  x86: Improvements to ler debugging
  x86/pat: Simplify host PAT handling
  x86/vmx: Simplify PAT handling during vcpu construction
  x86/vmx: Defer vmx_vmcs_exit() as long as possible in construct_vmcs()
  x86/vmx: Drop VMX signal for full real-mode

 docs/misc/xen-command-line.markdown |  6 
 xen/arch/x86/acpi/suspend.c |  3 +-
 xen/arch/x86/cpu/common.c   |  9 +-
 xen/arch/x86/hvm/mtrr.c |  2 +-
 xen/arch/x86/hvm/vmx/entry.S|  9 ++
 xen/arch/x86/hvm/vmx/vmcs.c | 22 +-
 xen/arch/x86/hvm/vmx/vmx.c  | 14 ++---
 xen/arch/x86/traps.c| 58 ++---
 xen/arch/x86/x86_64/traps.c | 14 ++---
 xen/include/asm-x86/cpufeature.h|  2 +-
 xen/include/asm-x86/cpufeatures.h   |  1 +
 xen/include/asm-x86/msr.h   |  2 +-
 xen/include/asm-x86/processor.h |  7 -
 xen/include/asm-x86/x86_64/page.h   |  8 +
 14 files changed, 83 insertions(+), 74 deletions(-)

-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 5/6] x86/vmx: Defer vmx_vmcs_exit() as long as possible in construct_vmcs()

[Andrew Cooper]

paging_update_paging_modes() and vmx_vlapic_msr_changed() both operate on the
VMCS being constructed.  Avoid dropping and re-acquiring the reference
multiple times.

Signed-off-by: Andrew Cooper 
---
CC: Jan Beulich 
CC: Jun Nakajima 
CC: Kevin Tian 
CC: Wei Liu 
CC: Roger Pau Monné 
---
 xen/arch/x86/hvm/vmx/vmcs.c | 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index be02be1..ce78f19 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -996,6 +996,7 @@ static int construct_vmcs(struct vcpu *v)
 struct domain *d = v->domain;
 u32 vmexit_ctl = vmx_vmexit_control;
 u32 vmentry_ctl = vmx_vmentry_control;
+int rc;
 
 vmx_vmcs_enter(v);
 
@@ -1083,8 +1084,8 @@ static int construct_vmcs(struct vcpu *v)
 
 if ( msr_bitmap == NULL )
 {
-vmx_vmcs_exit(v);
-return -ENOMEM;
+rc = -ENOMEM;
+goto out;
 }
 
 memset(msr_bitmap, ~0, PAGE_SIZE);
@@ -1258,13 +1259,14 @@ static int construct_vmcs(struct vcpu *v)
 if ( cpu_has_vmx_tsc_scaling )
 __vmwrite(TSC_MULTIPLIER, d->arch.hvm_domain.tsc_scaling_ratio);
 
-vmx_vmcs_exit(v);
-
 /* will update HOST & GUEST_CR3 as reqd */
 paging_update_paging_modes(v);
 
 vmx_vlapic_msr_changed(v);
 
+ out:
+vmx_vmcs_exit(v);
+
 return 0;
 }
 
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 3/6] x86/pat: Simplify host PAT handling

[Andrew Cooper]

With the removal of the 32bit hypervisor build, host_pat is a constant value.
Drop the variable and the redundant cpu_has_pat predicate, and use a define
instead.

Signed-off-by: Andrew Cooper 
---
CC: Jan Beulich 
CC: Wei Liu 
CC: Roger Pau Monné 
---
 xen/arch/x86/acpi/suspend.c  | 3 +--
 xen/arch/x86/cpu/common.c| 9 +
 xen/arch/x86/hvm/mtrr.c  | 2 +-
 xen/include/asm-x86/cpufeature.h | 1 -
 xen/include/asm-x86/processor.h  | 7 ++-
 5 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/xen/arch/x86/acpi/suspend.c b/xen/arch/x86/acpi/suspend.c
index 044bd81..eecf357 100644
--- a/xen/arch/x86/acpi/suspend.c
+++ b/xen/arch/x86/acpi/suspend.c
@@ -95,8 +95,7 @@ void restore_rest_processor_state(void)
 /* Reload FPU state on next FPU use. */
 stts();
 
-if (cpu_has_pat)
-wrmsrl(MSR_IA32_CR_PAT, host_pat);
+wrmsrl(MSR_IA32_CR_PAT, XEN_MSR_PAT);
 
 mtrr_bp_restore();
 }
diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
index 528aff1..3548b12 100644
--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -47,12 +47,6 @@ unsigned int paddr_bits __read_mostly = 36;
 unsigned int hap_paddr_bits __read_mostly = 36;
 unsigned int vaddr_bits __read_mostly = VADDR_BITS;
 
-/*
- * Default host IA32_CR_PAT value to cover all memory types.
- * BIOS usually sets it to 0x07040600070406.
- */
-u64 host_pat = 0x050100070406;
-
 static unsigned int cleared_caps[NCAPINTS];
 static unsigned int forced_caps[NCAPINTS];
 
@@ -814,8 +808,7 @@ void cpu_init(void)
if (opt_cpu_info)
printk("Initializing CPU#%d\n", cpu);
 
-   if (cpu_has_pat)
-   wrmsrl(MSR_IA32_CR_PAT, host_pat);
+   wrmsrl(MSR_IA32_CR_PAT, XEN_MSR_PAT);
 
/* Install correct page table. */
write_ptbase(current);
diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c
index a61cc1e..c78e5c1 100644
--- a/xen/arch/x86/hvm/mtrr.c
+++ b/xen/arch/x86/hvm/mtrr.c
@@ -125,7 +125,7 @@ static int __init hvm_mtrr_pat_init(void)
 {
 for ( j = 0; j < PAT_TYPE_NUMS; j++ )
 {
-if ( pat_cr_2_paf(host_pat, j) == i )
+if ( pat_cr_2_paf(XEN_MSR_PAT, j) == i )
 {
 pat_entry_tbl[i] = j;
 break;
diff --git a/xen/include/asm-x86/cpufeature.h b/xen/include/asm-x86/cpufeature.h
index b237da1..4bc6c91 100644
--- a/xen/include/asm-x86/cpufeature.h
+++ b/xen/include/asm-x86/cpufeature.h
@@ -37,7 +37,6 @@
 #define cpu_has_sep boot_cpu_has(X86_FEATURE_SEP)
 #define cpu_has_mtrr1
 #define cpu_has_pge 1
-#define cpu_has_pat 1
 #define cpu_has_pse36   boot_cpu_has(X86_FEATURE_PSE36)
 #define cpu_has_clflush boot_cpu_has(X86_FEATURE_CLFLUSH)
 #define cpu_has_mmx 1
diff --git a/xen/include/asm-x86/processor.h b/xen/include/asm-x86/processor.h
index 9924cdf..ac1577c 100644
--- a/xen/include/asm-x86/processor.h
+++ b/xen/include/asm-x86/processor.h
@@ -97,6 +97,12 @@
   X86_EFLAGS_NT|X86_EFLAGS_DF|X86_EFLAGS_IF|\
   X86_EFLAGS_TF)
 
+/*
+ * Host IA32_CR_PAT value to cover all memory types.  This is not the default
+ * MSR_PAT value, and is an ABI with PV guests.
+ */
+#define XEN_MSR_PAT 0x050100070406ul
+
 #ifndef __ASSEMBLY__
 
 struct domain;
@@ -145,7 +151,6 @@ extern bool probe_cpuid_faulting(void);
 extern void ctxt_switch_levelling(const struct vcpu *next);
 extern void (*ctxt_switch_masking)(const struct vcpu *next);
 
-extern u64 host_pat;
 extern bool_t opt_cpu_info;
 extern u32 cpuid_ext_features;
 extern u64 trampoline_misc_enable_off;
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 6/6] x86/vmx: Drop VMX signal for full real-mode

[Andrew Cooper]

The hvmloader code which used this signal was deleted 10 years ago (c/s
50b12df83 "x86 vmx: Remove vmxassist").  Furthermore, the value gets discarded
anyway because the HVM domain builder unconditionally sets %rax to 0 in the
same action it uses to set %rip to the appropriate entrypoint.

Signed-off-by: Andrew Cooper 
---
CC: Jan Beulich 
CC: Jun Nakajima 
CC: Kevin Tian 
CC: Roger Pau Monné 
CC: Wei Liu 
---
 xen/arch/x86/hvm/vmx/vmx.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 8049264..4318b15 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -462,10 +462,6 @@ static int vmx_vcpu_initialise(struct vcpu *v)
 
 vmx_install_vlapic_mapping(v);
 
-/* %eax == 1 signals full real-mode support to the guest loader. */
-if ( v->vcpu_id == 0 )
-v->arch.user_regs.rax = 1;
-
 return 0;
 }
 
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2] x86/CPUID: don't override tool stack decision to hide STIBP

[Andrew Cooper]

On 28/05/18 08:08, Jan Beulich wrote:
> Other than in the feature sets, where we indeed want to offer the
> feature even if not enumerated on hardware, we shouldn't dictate the
> feature being available if tool stack or host admin have decided to not
> expose it (for whatever [questionable?] reason). That feature set side
> override is sufficient to achieve the intended guest side safety
> property (in offering - by default - STIBP independent of actual
> availability in hardware).
>
> Signed-off-by: Jan Beulich 

Reviewed-by: Andrew Cooper 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [ovmf baseline-only test] 74752: all pass

[Platform Team regression test user]

This run is configured for baseline tests only.

flight 74752 ovmf real [real]
http://osstest.xs.citrite.net/~osstest/testlogs/logs/74752/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf 03ac238b1fe40cfbb1424bf72e2ac8276345e03c
baseline version:
 ovmf 7dc7c7435e9030ad07ad7bc7d136a3997bd0b182

Last test of basis74748  2018-05-26 04:52:45 Z2 days
Testing same since74752  2018-05-27 06:20:53 Z1 days1 attempts


People who touched revisions under test:
  Ruiyu Ni 

jobs:
 build-amd64-xsm  pass
 build-i386-xsm   pass
 build-amd64  pass
 build-i386   pass
 build-amd64-libvirt  pass
 build-i386-libvirt   pass
 build-amd64-pvopspass
 build-i386-pvops pass
 test-amd64-amd64-xl-qemuu-ovmf-amd64 pass
 test-amd64-i386-xl-qemuu-ovmf-amd64  pass



sg-report-flight on osstest.xs.citrite.net
logs: /home/osstest/logs
images: /home/osstest/images

Logs, config files, etc. are available at
http://osstest.xs.citrite.net/~osstest/testlogs/logs

Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary


Push not applicable.


commit 03ac238b1fe40cfbb1424bf72e2ac8276345e03c
Author: Ruiyu Ni 
Date:   Wed May 23 11:28:46 2018 +0800

MdeModulePkg/PciBus: Use actual max bus # for subordinary bus #

Current code assumes the max bus(0xFF) is under this P2P bridge and
temporarily set it as subordinate bus.
It may cause silicon hangs during PCI enumeration in some specific
case.

Instead, it should get the max bus number from the bus number
resources returned from
PCI_HOST_BRIDGE_RESOURCE_ALLOCATION.StartBusEnumeration() and set it
as subordinate bus.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni 
Reviewed-by: Star Zeng 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [xen-unstable-smoke test] 123300: regressions - FAIL

[osstest service owner]

flight 123300 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123300/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 123071

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass

version targeted for testing:
 xen  6b9562dac1746014ab376bd2cf8ba400acf34c6d
baseline version:
 xen  fc5805daef091240cd5fc06634a8bcdb2f3bb843

Last test of basis   123071  2018-05-22 15:00:29 Z5 days
Testing same since   123296  2018-05-28 10:01:06 Z0 days2 attempts


People who touched revisions under test:
  Jan Beulich 

jobs:
 build-arm64-xsm  pass
 build-amd64  pass
 build-armhf  pass
 build-amd64-libvirt  pass
 test-armhf-armhf-xl  pass
 test-arm64-arm64-xl-xsm  fail
 test-amd64-amd64-xl-qemuu-debianhvm-i386 pass
 test-amd64-amd64-libvirt pass



sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.


commit 6b9562dac1746014ab376bd2cf8ba400acf34c6d
Author: Jan Beulich 
Date:   Mon May 28 11:20:26 2018 +0200

x86/XPTI: fix S3 resume (and CPU offlining in general)

We should index an L1 table with an L1 index.

Reported-by: Simon Gaiser 
Signed-off-by: Jan Beulich 
Reviewed-by: Andrew Cooper 
Release-acked-by: Juergen Gross 
(qemu changes not included)

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [xen-unstable baseline-only test] 74751: tolerable FAIL

[Platform Team regression test user]

This run is configured for baseline tests only.

flight 74751 xen-unstable real [real]
http://osstest.xs.citrite.net/~osstest/testlogs/logs/74751/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-xsm 12 guest-start  fail blocked in 74727
 test-armhf-armhf-xl-xsm  12 guest-start  fail blocked in 74727
 test-amd64-amd64-xl-qemut-win10-i386 10 windows-installfail like 74727
 test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail like 74727
 test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail like 74727
 test-armhf-armhf-libvirt 12 guest-start  fail   like 74727
 test-armhf-armhf-xl-multivcpu 12 guest-start  fail  like 74727
 test-armhf-armhf-xl-credit2  12 guest-start  fail   like 74727
 test-armhf-armhf-xl-midway   12 guest-start  fail   like 74727
 test-armhf-armhf-xl-rtds 12 guest-start  fail   like 74727
 test-armhf-armhf-xl  12 guest-start  fail   like 74727
 test-amd64-amd64-xl-qemuu-ws16-amd64 10 windows-installfail like 74727
 test-amd64-amd64-qemuu-nested-intel 14 xen-boot/l1 fail like 74727
 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 74727
 test-armhf-armhf-xl-vhd  10 debian-di-installfail   like 74727
 test-armhf-armhf-libvirt-raw 10 debian-di-installfail   like 74727
 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop  fail like 74727
 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop  fail like 74727
 test-amd64-i386-xl-pvshim12 guest-start  fail   never pass
 test-amd64-amd64-xl-pvhv2-intel 12 guest-start fail never pass
 test-amd64-i386-libvirt-xsm  13 migrate-support-checkfail   never pass
 test-amd64-amd64-xl-pvhv2-amd 12 guest-start  fail  never pass
 test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt  13 migrate-support-checkfail   never pass
 test-amd64-i386-xl-qemut-ws16-amd64 10 windows-install fail never pass
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2  fail never pass
 test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail   never pass
 test-amd64-i386-xl-qemut-win10-i386 17 guest-stop  fail never pass
 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass
 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop  fail never pass
 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass

version targeted for testing:
 xen  fc5805daef091240cd5fc06634a8bcdb2f3bb843
baseline version:
 xen  858dbaaeda33b05c1ac80aea0ba9a03924e09005

Last test of basis74727  2018-05-18 13:16:02 Z9 days
Testing same since74751  2018-05-27 02:20:20 Z1 days1 attempts


People who touched revisions under test:
  Andrew Cooper 
  Anthony PERARD 
  Christian Lindig 
  George Dunlap 
  Ian Jackson 
  Jan Beulich 
  John Thomson 
  Juergen Gross 
  Konrad Rzeszutek Wilk 
  Lars Kurth 
  Olaf Hering 
  Oleksandr Andrushchenko 
  Paul Durrant 
  Roger Pau Monné 
  Wei Liu 

jobs:
 build-amd64-xsm  pass
 build-armhf-xsm  pass
 build-i386-xsm   pass
 build-amd64-xtf  pass
 build-amd64  pass
 build-armhf  pass
 build-i386   pass
 build-amd64-libvirt  pass
 build-armhf-libvirt  pass
 build-i386-libvirt   pass
 build-amd64-prev pass
 build-i386-prev  pass
 build-amd64-pvopspass
 build-armhf-pvops   

[Xen-devel] [xen-unstable-smoke test] 123296: regressions - FAIL

[osstest service owner]

flight 123296 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123296/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 123071

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass

version targeted for testing:
 xen  6b9562dac1746014ab376bd2cf8ba400acf34c6d
baseline version:
 xen  fc5805daef091240cd5fc06634a8bcdb2f3bb843

Last test of basis   123071  2018-05-22 15:00:29 Z5 days
Testing same since   123296  2018-05-28 10:01:06 Z0 days1 attempts


People who touched revisions under test:
  Jan Beulich 

jobs:
 build-arm64-xsm  pass
 build-amd64  pass
 build-armhf  pass
 build-amd64-libvirt  pass
 test-armhf-armhf-xl  pass
 test-arm64-arm64-xl-xsm  fail
 test-amd64-amd64-xl-qemuu-debianhvm-i386 pass
 test-amd64-amd64-libvirt pass



sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.


commit 6b9562dac1746014ab376bd2cf8ba400acf34c6d
Author: Jan Beulich 
Date:   Mon May 28 11:20:26 2018 +0200

x86/XPTI: fix S3 resume (and CPU offlining in general)

We should index an L1 table with an L1 index.

Reported-by: Simon Gaiser 
Signed-off-by: Jan Beulich 
Reviewed-by: Andrew Cooper 
Release-acked-by: Juergen Gross 
(qemu changes not included)

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [linux-4.9 test] 123257: regressions - FAIL

[osstest service owner]

flight 123257 linux-4.9 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/123257/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-xsm  6 xen-install  fail REGR. vs. 122969
 test-arm64-arm64-xl-xsm   6 xen-install  fail REGR. vs. 122969
 test-amd64-amd64-xl-qcow2 7 xen-boot fail REGR. vs. 122969
 test-amd64-amd64-qemuu-nested-amd  7 xen-bootfail REGR. vs. 122969
 test-amd64-amd64-xl-pvhv2-amd  7 xen-bootfail REGR. vs. 122969
 test-amd64-amd64-pygrub   7 xen-boot fail REGR. vs. 122969
 test-amd64-amd64-xl-xsm   7 xen-boot fail REGR. vs. 122969
 test-amd64-amd64-pair10 xen-boot/src_hostfail REGR. vs. 122969
 test-amd64-amd64-pair11 xen-boot/dst_hostfail REGR. vs. 122969
 test-amd64-amd64-xl   7 xen-boot fail REGR. vs. 122969
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 122969
 test-amd64-amd64-xl-multivcpu  7 xen-bootfail REGR. vs. 122969
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 
122969

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-arndale   7 xen-boot fail in 123209 pass in 123257
 test-amd64-amd64-examine  8 reboot fail pass in 123209

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds  7 xen-boot fail REGR. vs. 122969

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 122969
 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 122969
 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 122969
 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 122969
 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stopfail like 122969
 test-amd64-amd64-xl-pvhv2-intel 12 guest-start fail never pass
 test-amd64-amd64-libvirt 13 migrate-support-checkfail   never pass
 test-amd64-i386-xl-pvshim12 guest-start  fail   never pass
 test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt-xsm  13 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl-credit2  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl-credit2  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-arndale  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-arndale  14 saverestore-support-checkfail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-cubietruck 13 migrate-support-checkfail never pass
 test-armhf-armhf-xl-cubietruck 14 saverestore-support-checkfail never pass
 test-armhf-armhf-xl-rtds 13 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 14 saverestore-support-checkfail   never pass
 test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail  never pass
 test-armhf-armhf-libvirt 13 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt 14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail  never pass
 test-armhf-armhf-xl-xsm  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  13 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  14 saverestore-support-checkfail   never pass
 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass
 test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop  fail never pass
 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop  fail never pass
 test-arm64-arm64-xl  13 migrate-support-checkfail   never pass
 test-arm64-arm64-xl  14 saverestore-support-checkfail   never pass
 test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-vhd  12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-vhd  13 

Re: [Xen-devel] [PATCH v4 00/10] xen/arm64: Suspend preconditions and CPU hotplug fixes

[Mirela Simonovic]

Hi,

Could you please provide feedback for the remaining patches?

Thanks,
Mirela

On Tue, May 15, 2018 at 1:44 PM, Mirela Simonovic <
mirela.simono...@aggios.com> wrote:

> This patch set contains fixes that are required as precondition for
> suspend to
> RAM support, including the CPU hotplug which is required to suspend
> non-boot
> CPUs.
> The first two patches in this series:
> 1) xen/arm64: Added handling of the trapped access to OSLSR register
> 2) xen/arm: Ignore write to GICD_ISACTIVERn registers (vgic-v2)
> are required to avoid Dom0 crashes when Dom0 performs its own suspend. This
> patch set does not include the implementation of virtual PSCI system
> suspend
> call that would allow guests to finalize their suspend procedures. This
> will
> be submitted in the following series.
>
> Remaining of the patches are related to enabling CPU hotplug for non-boot
> CPUs is resume scenario. CPU hotplug of non-boot CPUs will be used for
> suspend
> to RAM support for ARM. In suspend procedure, the hot-unplug of non-boot
> CPUs
> will be triggered with disable_nonboot_cpus(), while the hotplug is
> triggered
> with enable_nonboot_cpus(). Using these calls, the physical non-boot CPUs
> could
> be powered down/up on suspend/resume, respectively, if the underlying
> firmware
> allows so. Calls to enable/disable_nonboot_cpus() functions currently do
> not
> exist in Xen ARM code. This will be added with the suspend to RAM support
> for
> ARM.
>
> When non-boot pCPUs are hot-unplugged their interrupts are migrated to the
> boot
> pCPU. This series also includes a fix that would restore the interrupts
> affinity
> once non-boot pCPUs are hotplugged. Here only SPIs used by guests are
> covered.
> Migration of Xen internal SPIs is not covered. According to my
> understanding
> Xen internal SPIs are routed to the boot CPU which initializes the
> respective
> devices. Therefore, there is no need to migrate Xen internal SPIs.
>
> The code is tested on Xilinx Zynq UltraScale+ MPSoC/ZCU102 board (includes
> physical power down/up of non-boot CPUs). The testing requires additional
> patches for issuing system suspend. These patches and instructions for
> testing
> will be submitted later, when we get closer to the final version of the
> series.
>
> ---
> Changes in v2:
> -Rename cover-letter title and emphasize that 2 patches from this series
> are not
> specific to CPU hotplug (my initial fault, splitting it now could be
> confusing)
> -Fix cover-letter explanations
> -Address all the issues and comments as discussed on mailing list for v1
> -Add 3 patches to ensure that suspend/resume does not cause any memory
> leaks.
> All the memory allocated when a CPU was hotplugged is now freed when the
> CPU is
> hot-unplugged.
> -Remove from the v1 series the patch which incorrectly dealt with an issue:
> [PATCH 4/7] xen/arm: When CPU dies, free percpu area immediatelly
> One solution to the issue addressed by the patch above is to add
> rcu_barrier()
> prior to calling enable_nonboot_cpus() during the suspend. This is how it
> is
> done in x86 suspend implementation. Until the discussion here
> https://lists.xenproject.org/archives/html/xen-devel/2018-04/msg01199.html
> doesn't conclude differently, I need to assume that adding rcu_barrier()
> prior
> to calling enable_nonboot_cpus() as it is done for x86 is the right way to
> go.
> Therefore, the fix to the issue will be part of the suspend to RAM series.
>
> Changes in v3:
> -Add acked-by where needed
> -Fix CPU_OFF PSCI implementation (physical interface)
> -Use notifiers to implement freeing memory and releasing interrupts on CPU
> hotplug
> -Use notifier to trigger setup of virtual paging for non-boot CPUs on CPU
> hotplug
> -Add enabling errata workarounds on CPU hotplug, also based on a notifier
> -Remove patch:
> [PATCH v2 10/10] xen/arm: Call check_local_cpu_errata for secondary CPU
> only on boot
>
> Changes in v4:
> -Add acked-by/reviewed-by where needed
> -Cleanup: use smp_processor_id() instead of get_processor_id(), fixed
>  indentation, add includes alphabetically, add newline before return, etc.
> -Disable timers prior to releasing timer interrupts
> -Initialize cpu_smpboot notifier at presmp_init rather than init phase
> -In the last patch of the series errata notifier now returns an error
>
> ---
> CC: Stefano Stabellini 
> CC: Julien Grall 
> CC: George Dunlap 
> CC: Dario Faggioli 
> ---
>
> Mirela Simonovic (10):
>   xen/arm64: Added handling of the trapped access to OSLSR register
>   xen/arm: Ignore write to GICD_ISACTIVERn registers (vgic-v2)
>   xen/arm: Implement CPU_OFF PSCI call (physical interface)
>   xen/arm: Remove __initdata and __init to enable CPU hotplug
>   xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume
>   xen/common: Restore IRQ affinity when hotplugging a pCPU
>   xen/arm: Release maintenance interrupt when CPU is 

[Xen-devel] [PATCH v2] x86/CPUID: don't override tool stack decision to hide STIBP

[Jan Beulich]

Other than in the feature sets, where we indeed want to offer the
feature even if not enumerated on hardware, we shouldn't dictate the
feature being available if tool stack or host admin have decided to not
expose it (for whatever [questionable?] reason). That feature set side
override is sufficient to achieve the intended guest side safety
property (in offering - by default - STIBP independent of actual
availability in hardware).

Signed-off-by: Jan Beulich 
---
v2: Drop ! from STIBP feature declaration.
---
This is effectively accompanying the discussion rooted at the 4.8/4.7
patch at
https://lists.xenproject.org/archives/html/xen-devel/2018-05/msg01028.html 
dealing with a feature leveling issue.

--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -642,14 +642,6 @@ void recalculate_cpuid_policy(struct dom
 recalculate_xstate(p);
 recalculate_misc(p);
 
-/*
- * Override STIBP to match IBRS.  Guests can safely use STIBP
- * functionality on non-HT hardware, but can't necesserily protect
- * themselves from SP2/Spectre/Branch Target Injection if STIBP is hidden
- * on HT-capable hardware.
- */
-p->feat.stibp = p->feat.ibrsb;
-
 for ( i = 0; i < ARRAY_SIZE(p->cache.raw); ++i )
 {
 if ( p->cache.subleaf[i].type >= 1 &&
--- a/xen/include/public/arch-x86/cpufeatureset.h
+++ b/xen/include/public/arch-x86/cpufeatureset.h
@@ -243,7 +243,7 @@ XEN_CPUFEATURE(IBPB,  8*32+12) /
 XEN_CPUFEATURE(AVX512_4VNNIW, 9*32+ 2) /*A  AVX512 Neural Network Instructions 
*/
 XEN_CPUFEATURE(AVX512_4FMAPS, 9*32+ 3) /*A  AVX512 Multiply Accumulation 
Single Precision */
 XEN_CPUFEATURE(IBRSB, 9*32+26) /*A  IBRS and IBPB support (used by 
Intel) */
-XEN_CPUFEATURE(STIBP, 9*32+27) /*A! STIBP */
+XEN_CPUFEATURE(STIBP, 9*32+27) /*A  STIBP */
 XEN_CPUFEATURE(ARCH_CAPS, 9*32+29) /*   IA32_ARCH_CAPABILITIES MSR */
 XEN_CPUFEATURE(SSBD,  9*32+31) /*A  MSR_SPEC_CTRL.SSBD available */
 





___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.11] tools: set DEBUG_DIR from configure

[Olaf Hering]

On Fri, May 25, Ian Jackson wrote:

> Can you please provide that information ?  That should really have
> been in your commit message, as the git commit id.  TBH, most of what
> is in that email could profitably have been in your commit message...

Perhaps 641f9ce2fa should have been more verbose.

Do you want me to provide a verbose backport, or would that be against
the rules of how backporting from master is supposed to be done?

Olaf


signature.asc
Description: PGP signature
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel