Re: [Xen-devel] tools/fuzz fails due build, osstest did not notice

2018-09-04 Thread Olaf Hering
Am Mon, 03 Sep 2018 06:35:42 -0600 schrieb "Jan Beulich" : > what is the actual problem? The mere > listing of compiler flags passed does not make clear to me where the clash > is, or how it would surface. As I noticed just now, it fails to build only in Tumbleweed. So in this specific case osst

Re: [Xen-devel] [PATCH RFC] x86/HVM: also stuff RSB upon exit to guest

2018-09-04 Thread Jan Beulich
>>> On 03.09.18 at 18:20, wrote: > On 27/07/18 15:20, Jan Beulich wrote: >> In order to mostly eliminate abuse of what Xen leaves in the RSB by >> guest level attackers, fill the RSB with almost-NULL pointers right >> before entering guest context. > > How do you envisage an attacker using what X

Re: [Xen-devel] [PATCH v2 2/2] xen: fill topology info for all present cpus

2018-09-04 Thread Juergen Gross
On 03/09/18 15:41, Jan Beulich wrote: On 31.08.18 at 17:22, wrote: >> The topology information obtainable via XEN_SYSCTL_cputopoinfo is >> filled rather weird: the size of the array is derived from the highest >> online cpu number, so in case there are trailing offline cpus they >> will not b

Re: [Xen-devel] [PATCH v2 2/2] x86/HVM: split page straddling emulated accesses in more cases

2018-09-04 Thread Jan Beulich
>>> On 03.09.18 at 18:15, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 03 September 2018 16:45 >>[...] >> The extra call to known_glfn() from hvmemul_write() is just to preserve >> original behavior; we should consider dropping this (also to make sure >> the intended effect of 8

Re: [Xen-devel] [PATCH v2 1/6] x86emul: fix FMA scalar operand sizes

2018-09-04 Thread Jan Beulich
>>> On 03.09.18 at 18:43, wrote: > On 29/08/18 15:23, Jan Beulich wrote: >> FMA insns, other than the earlier AVX additions, don't use the low >> opcode bit to distinguish between single and double vector elements. > > I think I've worked out why "other than the" is so weird to read as a > native

[Xen-devel] [xen-unstable-smoke test] 127247: regressions - FAIL

2018-09-04 Thread osstest service owner
flight 127247 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/127247/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 127212 Tests

Re: [Xen-devel] [PATCH v2 3/6] x86emul: support AVX512 opmask insns

2018-09-04 Thread Jan Beulich
>>> On 03.09.18 at 19:57, wrote: > On 29/08/18 15:24, Jan Beulich wrote: >> These are all VEX encoded, so the EVEX decoding logic continues to >> remain unused at this point. >> >> The new testcase is deliberately coded in assembly, as a C one would >> have become almost unreadable due to the over

Re: [Xen-devel] [PATCH v2 2/2] x86/HVM: split page straddling emulated accesses in more cases

2018-09-04 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 04 September 2018 08:44 > To: Paul Durrant > Cc: Olaf Hering ; Andrew Cooper > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH v2 2/2] x86/HVM: split page straddling emulated > accesses in more cases

[Xen-devel] [PATCH] hvmloader: set entry point in linker script

2018-09-04 Thread Roger Pau Monne
Or else it defaults to using 0x10 as the entry point, which might or might not point to _start. This is a fix for 09b3907f93. Reported-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu Cc: Ian Jackson --- tools/firmware/hvmloader/hvmloade

Re: [Xen-devel] [PATCH v6 01/14] iommu: introduce the concept of BFN...

2018-09-04 Thread Jan Beulich
>>> On 04.09.18 at 08:48, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Monday, September 3, 2018 7:47 PM >> >> >>> On 03.09.18 at 10:23, wrote: >> >> From: Jan Beulich [mailto:jbeul...@suse.com] >> >> Sent: 30 August 2018 17:00 >> >> >> >> >>> On 23.08.18 at 11:46, wrote: >>

Re: [Xen-devel] [PATCH v6 01/14] iommu: introduce the concept of BFN...

2018-09-04 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Tuesday, September 4, 2018 4:33 PM > > > > bus address is commonly used along with physical/virtual address, to > > represent different views between devices and CPU. From that angle > > I think BFN is a clear term in this context. btw it is no

[Xen-devel] [libvirt test] 127243: regressions - FAIL

2018-09-04 Thread osstest service owner
flight 127243 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/127243/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 123814 build-i386-libvirt

Re: [Xen-devel] [PATCH] hvmloader: set entry point in linker script

2018-09-04 Thread Wei Liu
On Tue, Sep 04, 2018 at 10:28:43AM +0200, Roger Pau Monne wrote: > Or else it defaults to using 0x10 as the entry point, which might > or might not point to _start. This is a fix for 09b3907f93. > > Reported-by: Andrew Cooper > Signed-off-by: Roger Pau Monné Ooops, missed that. Reviewed-by

Re: [Xen-devel] [xen-unstable-smoke test] 127247: regressions - FAIL

2018-09-04 Thread Wei Liu
On Tue, Sep 04, 2018 at 07:55:04AM +, osstest service owner wrote: > flight 127247 xen-unstable-smoke real [real] > http://logs.test-lab.xenproject.org/osstest/logs/127247/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-

Re: [Xen-devel] [PATCH v2 2/2] x86/HVM: split page straddling emulated accesses in more cases

2018-09-04 Thread Jan Beulich
>>> On 04.09.18 at 10:15, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 04 September 2018 08:44 >> >> >>> On 03.09.18 at 18:15, wrote: >> >> From: Jan Beulich [mailto:jbeul...@suse.com] >> >> Sent: 03 September 2018 16:45 >> >>[...] >> >> The extra call to known_glfn() from hvm

Re: [Xen-devel] [xen-unstable-smoke test] 127247: regressions - FAIL

2018-09-04 Thread Wei Liu
On Tue, Sep 04, 2018 at 09:45:53AM +0100, Wei Liu wrote: > On Tue, Sep 04, 2018 at 07:55:04AM +, osstest service owner wrote: > > flight 127247 xen-unstable-smoke real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/127247/ > > > > Regressions :-( > > > > Tests which did not succe

Re: [Xen-devel] [PATCH v6 01/14] iommu: introduce the concept of BFN...

2018-09-04 Thread Jan Beulich
>>> On 04.09.18 at 10:37, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, September 4, 2018 4:33 PM >> > >> > bus address is commonly used along with physical/virtual address, to >> > represent different views between devices and CPU. From that angle >> > I think BFN is a

Re: [Xen-devel] [PATCH v2 2/2] xen: fill topology info for all present cpus

2018-09-04 Thread Jan Beulich
>>> On 04.09.18 at 09:38, wrote: > On 03/09/18 15:41, Jan Beulich wrote: > On 31.08.18 at 17:22, wrote: >>> The topology information obtainable via XEN_SYSCTL_cputopoinfo is >>> filled rather weird: the size of the array is derived from the highest >>> online cpu number, so in case there are

Re: [Xen-devel] [xen-unstable-smoke test] 127247: regressions - FAIL

2018-09-04 Thread Andrew Cooper
On 04/09/18 09:45, Wei Liu wrote: > On Tue, Sep 04, 2018 at 07:55:04AM +, osstest service owner wrote: >> flight 127247 xen-unstable-smoke real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/127247/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> includi

Re: [Xen-devel] [PATCH v6 01/14] iommu: introduce the concept of BFN...

2018-09-04 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 04 September 2018 09:47 > To: Kevin Tian > Cc: Suravee Suthikulpanit ; Julien Grall > ; Paul Durrant ; Stefano > Stabellini ; xen-devel de...@lists.xenproject.org> > Subject: Re: [Xen-devel] [PATCH v6 01/14] iommu

Re: [Xen-devel] [xen-unstable-smoke test] 127247: regressions - FAIL

2018-09-04 Thread Wei Liu
On Tue, Sep 04, 2018 at 09:49:11AM +0100, Andrew Cooper wrote: > On 04/09/18 09:45, Wei Liu wrote: > > On Tue, Sep 04, 2018 at 07:55:04AM +, osstest service owner wrote: > >> flight 127247 xen-unstable-smoke real [real] > >> http://logs.test-lab.xenproject.org/osstest/logs/127247/ > >> > >> Reg

Re: [Xen-devel] [xen-unstable-smoke test] 127247: regressions - FAIL

2018-09-04 Thread Andrew Cooper
On 04/09/18 09:53, Wei Liu wrote: > On Tue, Sep 04, 2018 at 09:49:11AM +0100, Andrew Cooper wrote: >> On 04/09/18 09:45, Wei Liu wrote: >>> On Tue, Sep 04, 2018 at 07:55:04AM +, osstest service owner wrote: flight 127247 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.o

Re: [Xen-devel] tools/fuzz fails due build, osstest did not notice

2018-09-04 Thread Jan Beulich
>>> On 04.09.18 at 09:32, wrote: > Am Mon, 03 Sep 2018 06:35:42 -0600 > schrieb "Jan Beulich" : > >> what is the actual problem? The mere >> listing of compiler flags passed does not make clear to me where the clash >> is, or how it would surface. > > As I noticed just now, it fails to build onl

Re: [Xen-devel] [PATCH v6 01/14] iommu: introduce the concept of BFN...

2018-09-04 Thread Jan Beulich
>>> On 04.09.18 at 10:49, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 04 September 2018 09:47 >> To: Kevin Tian >> Cc: Suravee Suthikulpanit ; Julien Grall >> ; Paul Durrant ; Stefano >> Stabellini ; xen-devel > de...@lists.xenproject.org> >> Sub

[Xen-devel] [linux-linus test] 127221: regressions - FAIL

2018-09-04 Thread osstest service owner
flight 127221 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/127221/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 125898

Re: [Xen-devel] [PATCH v2 2/2] xen: fill topology info for all present cpus

2018-09-04 Thread Julien Grall
Hi, On 09/04/2018 09:49 AM, Jan Beulich wrote: On 04.09.18 at 09:38, wrote: On 03/09/18 15:41, Jan Beulich wrote: On 31.08.18 at 17:22, wrote: The topology information obtainable via XEN_SYSCTL_cputopoinfo is filled rather weird: the size of the array is derived from the highest online cpu

[Xen-devel] [PATCH] x86emul: fix test harness dependencies

2018-09-04 Thread Jan Beulich
The generated header files are what needs to spell out dependencies on other (real) headers in the main Makefile here, not the intermediate (helper) .o files produced through testcase.mk. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/Makefile +++ b/tools/tests/x86_emulator/Makefile @

Re: [Xen-devel] [PATCH v2 1/2] x86/HVM: drop hvm_fetch_from_guest_linear()

2018-09-04 Thread Jan Beulich
>>> On 03.09.18 at 17:43, wrote: > It can easily be expressed through hvm_copy_from_guest_linear(), and in > two cases this even simplifies callers. > > Suggested-by: Paul Durrant > Signed-off-by: Jan Beulich > Reviewed-by: Andrew Cooper > --- > v2: Make sure this compiles standalone. Slightly

Re: [Xen-devel] [PATCH] x86emul: fix test harness dependencies

2018-09-04 Thread Andrew Cooper
On 04/09/18 10:58, Jan Beulich wrote: > The generated header files are what needs to spell out dependencies on > other (real) headers in the main Makefile here, not the intermediate > (helper) .o files produced through testcase.mk. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper

Re: [Xen-devel] [PATCH v4] x86/hvm: remove default ioreq server (again)

2018-09-04 Thread Jan Beulich
>>> On 03.09.18 at 18:46, wrote: > My recent patch [1] to qemu-xen-traditional removes the last use of the > 'default' ioreq server in Xen. (This is a catch-all ioreq server that is > used if no explicitly registered I/O range is targetted). > > This patch can be applied once that patch is commit

Re: [Xen-devel] [PATCH v6 02/14] iommu: make use of type-safe BFN and MFN in exported functions

2018-09-04 Thread Jan Beulich
>>> On 23.08.18 at 11:46, wrote: > This patch modifies the declaration of the entry points to the IOMMU > sub-system to use bfn_t and mfn_t in place of unsigned long. A subsequent > patch will similarly modify the methods in the iommu_ops structure. > > Signed-off-by: Paul Durrant > Reviewed-by:

Re: [Xen-devel] [PATCH v6 03/14] iommu: push use of type-safe BFN and MFN into iommu_ops

2018-09-04 Thread Jan Beulich
>>> On 23.08.18 at 11:47, wrote: > This patch modifies the methods in struct iommu_ops to use type-safe BFN > and MFN. This follows on from the prior patch that modified the functions > exported in xen/iommu.h. > > Signed-off-by: Paul Durrant > Reviewed-by: Wei Liu > Reviewed-by: Kevin Tian A

Re: [Xen-devel] [PATCH v6 04/14] iommu: don't domain_crash() inside iommu_map/unmap_page()

2018-09-04 Thread Jan Beulich
>>> On 23.08.18 at 11:47, wrote: > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -1154,6 +1154,7 @@ map_grant_ref( > } > if ( err ) > { > +domu_crash(ld); > double_gt_unlock(lgt, rgt); You crash the domain with both locks

Re: [Xen-devel] [PATCH v6 04/14] iommu: don't domain_crash() inside iommu_map/unmap_page()

2018-09-04 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 04 September 2018 11:38 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; Wei Liu ; George > Dunlap ; Ian Jackson ; > Jun Nakajima ; Kevin Tian > ; Stefano Stabellini ; xen- > devel ; Konrad Rzeszutek Wilk

[Xen-devel] [xen-unstable-smoke test] 127252: regressions - FAIL

2018-09-04 Thread osstest service owner
flight 127252 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/127252/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 127212 Tests

Re: [Xen-devel] [PATCH v2 5/6] x86emul: correct EVEX decoding

2018-09-04 Thread Andrew Cooper
On 29/08/18 15:25, Jan Beulich wrote: > Fix an inverted pair of checks, drop an incorrect instance of #UD > raising for non-64-bit mode, and add further generic checks. > > Note: Other than SDM Vol 2 rev 067 states, EVEX.V' is _not_ ignored > outside of 64-bit mode when the field does not enc

Re: [Xen-devel] [PATCH v2 6/6] x86emul: generalize vector length handling for AVX512/EVEX

2018-09-04 Thread Andrew Cooper
On 29/08/18 15:25, Jan Beulich wrote: > @@ -2818,6 +2818,9 @@ x86_decode( > > opcode |= b | MASK_INSR(vex.pfx, X86EMUL_OPC_PFX_MASK); > > +if ( !evex.mbs ) This use of mbs is very confusing to read.  How about: #define evex_encoded evex.mbs which at least giv

Re: [Xen-devel] Xen Dom0 boot failure on platform that supports ARM GICv4

2018-09-04 Thread Julien Grall
On 09/03/2018 07:37 PM, Shameerali Kolothum Thodi wrote: > > >> -Original Message- >> From: Julien Grall [mailto:julien.gr...@arm.com] >> Sent: 03 September 2018 18:14 >> To: Shameerali Kolothum Thodi ; >> xen-de...@lists.xen.org >> Cc: sstabell...@kernel.org; Linuxarm ; Andre >> Przywa

[Xen-devel] [PATCH] libxl: create control/sysrq xenstore node

2018-09-04 Thread Vitaly Kuznetsov
'xl sysrq' command doesn't work with modern Linux guests with the following message in guest's log: xen:manage: sysrq_handler: Error -13 writing sysrq in control/sysrq xenstore trace confirms: IN 0x24bd9a0 20180904 04:36:32 WRITE (control/sysrq ) OUT 0x24bd9a0 20180904 04

Re: [Xen-devel] [PATCH v6 05/14] public / x86: introduce __HYPERCALL_iommu_op

2018-09-04 Thread Jan Beulich
>>> On 23.08.18 at 11:47, wrote: > --- /dev/null > +++ b/xen/common/iommu_op.c > @@ -0,0 +1,184 @@ > +/** > + * x86/iommu_op.c Oops? > +int do_one_iommu_op(xen_iommu_op_buf_t *buf) > +{ > +xen_iommu_op_t op; > +i

Re: [Xen-devel] [PATCH 1/5] xen/domain: Prepare data for is_{pv, hvm}_domain() as early as possible

2018-09-04 Thread Andrew Cooper
On 03/09/18 17:03, Jan Beulich wrote: >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c >> @@ -272,8 +272,12 @@ struct domain *domain_create(domid_t domid, >> if ( (d = alloc_domain_struct()) == NULL ) >> return ERR_PTR(-ENOMEM); >> >> +/* Sort out our idea of is_system_

Re: [Xen-devel] [PATCH v6 05/14] public / x86: introduce __HYPERCALL_iommu_op

2018-09-04 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 04 September 2018 12:50 > To: Paul Durrant > Cc: Andrew Cooper ; Wei Liu > ; George Dunlap ; Ian > Jackson ; Stefano Stabellini > ; xen-devel ; > Konrad Rzeszutek Wilk ; Tim (Xen.org) > > Subject: Re: [PATCH v6 05

Re: [Xen-devel] [PATCH v2 5/6] x86emul: correct EVEX decoding

2018-09-04 Thread Jan Beulich
>>> On 04.09.18 at 12:48, wrote: > On 29/08/18 15:25, Jan Beulich wrote: >> --- a/xen/arch/x86/x86_emulate/x86_emulate.c >> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c >> @@ -650,7 +650,7 @@ union evex { >> uint8_t w:1; >> uint8_t opmsk:3; >> uint8_t RX:1; >> -u

Re: [Xen-devel] [PATCH v2 6/6] x86emul: generalize vector length handling for AVX512/EVEX

2018-09-04 Thread Jan Beulich
>>> On 04.09.18 at 13:02, wrote: > On 29/08/18 15:25, Jan Beulich wrote: >> @@ -2818,6 +2818,9 @@ x86_decode( >> >> opcode |= b | MASK_INSR(vex.pfx, X86EMUL_OPC_PFX_MASK); >> >> +if ( !evex.mbs ) > > This use of mbs is very confusing to read. How about: > >

Re: [Xen-devel] [PATCH 1/5] xen/domain: Prepare data for is_{pv, hvm}_domain() as early as possible

2018-09-04 Thread Jan Beulich
>>> On 04.09.18 at 14:17, wrote: > On 03/09/18 17:03, Jan Beulich wrote: >>> --- a/xen/common/domain.c >>> +++ b/xen/common/domain.c >>> @@ -272,8 +272,12 @@ struct domain *domain_create(domid_t domid, >>> if ( (d = alloc_domain_struct()) == NULL ) >>> return ERR_PTR(-ENOMEM); >>>

Re: [Xen-devel] [Bug 198497] handle_mm_fault / xen_pmd_val / radix_tree_lookup_slot Null pointer

2018-09-04 Thread Jason Andryuk
On Mon, Apr 23, 2018 at 4:17 AM Juergen Gross wrote: > On 20/04/18 17:20, Jason Andryuk wrote: > > Adding xen-devel and the Linux Xen maintainers. > > > > Summary: Some Xen users (and maybe others) are hitting a BUG in > > __radix_tree_lookup() under do_swap_page() - example backtrace is > > provi

Re: [Xen-devel] [PATCH v6 05/14] public / x86: introduce __HYPERCALL_iommu_op

2018-09-04 Thread Jan Beulich
>>> On 04.09.18 at 14:23, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 04 September 2018 12:50 >> >> >>> On 23.08.18 at 11:47, wrote: >> > +int compat_one_iommu_op(compat_iommu_op_buf_t *buf) >> > +{ >> > +compat_iommu_op_t cmp; >> > +xen_iommu_op_t nat; >> > +int

[Xen-devel] [xen-unstable-smoke test] 127260: tolerable all pass - PUSHED

2018-09-04 Thread osstest service owner
flight 127260 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/127260/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [seabios baseline-only test] 75162: tolerable FAIL

2018-09-04 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75162 seabios real [real] http://osstest.xensource.com/osstest/logs/75162/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail like 75114 t

Re: [Xen-devel] [PATCH v6 05/14] public / x86: introduce __HYPERCALL_iommu_op

2018-09-04 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 04 September 2018 13:55 > To: Paul Durrant > Cc: Andrew Cooper ; George Dunlap > ; Ian Jackson ; Wei Liu > ; Stefano Stabellini ; xen- > devel ; Konrad Rzeszutek Wilk > ; Tim (Xen.org) > Subject: RE: [PATCH v6 05/

Re: [Xen-devel] [PATCH v2 01/23] x86: change name of parameter for various invlpg functions

2018-09-04 Thread Boris Ostrovsky
On 09/03/2018 09:46 AM, Wei Liu wrote: On Sun, Aug 26, 2018 at 01:19:34PM +0100, Wei Liu wrote: They all incorrectly named a parameter virtual address while it should have been linear address. Requested-by: Andrew Cooper Signed-off-by: Wei Liu Is there more comment on this? These being ra

[Xen-devel] [xen-unstable test] 127232: tolerable FAIL - PUSHED

2018-09-04 Thread osstest service owner
flight 127232 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/127232/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 126854 test-armhf-armhf-libvirt 14 save

[Xen-devel] [ovmf baseline-only test] 75163: tolerable FAIL

2018-09-04 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75163 ovmf real [real] http://osstest.xensource.com/osstest/logs/75163/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail like 75160 test

[Xen-devel] [xen-unstable-smoke test] 127265: tolerable all pass - PUSHED

2018-09-04 Thread osstest service owner
flight 127265 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/127265/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [RFC PATCH tip] x86/xen: xen_reservation_lock can be static

2018-09-04 Thread kbuild test robot
Fixes: f030aade9165 ("x86/xen: Move pv specific parts of arch/x86/xen/mmu.c to mmu_pv.c") Signed-off-by: kbuild test robot --- mmu_pv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index bf30fa0..7ada9e4 100644 --- a/arch/x

[Xen-devel] [tip:x86/paravirt 2/15] arch/x86/xen/mmu_pv.c:105:1: sparse: symbol 'xen_reservation_lock' was not declared. Should it be static?

2018-09-04 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/paravirt head: 495310e4f2dd857c4d5a62806a04cb8ba53855c1 commit: f030aade9165080f3539fb86fc2ce9ffc391813c [2/15] x86/xen: Move pv specific parts of arch/x86/xen/mmu.c to mmu_pv.c reproduce: # apt-get install sparse

[Xen-devel] [distros-debian-snapshot test] 75164: regressions - FAIL

2018-09-04 Thread Platform Team regression test user
flight 75164 distros-debian-snapshot real [real] http://osstest.xensource.com/osstest/logs/75164/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-i386-daily-netboot-pygrub 11 guest-start fail REGR. vs. 75133 Tests which did

Re: [Xen-devel] Xen Dom0 boot failure on platform that supports ARM GICv4

2018-09-04 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: 04 September 2018 12:22 > To: Shameerali Kolothum Thodi ; > xen-de...@lists.xen.org > Cc: sstabell...@kernel.org; Linuxarm ; Andre > Przywara > Subject: Re: Xen Dom0 boot failure on platform that supports ARM

Re: [Xen-devel] [PATCH 0/2] MMIO emulation fixes

2018-09-04 Thread Juergen Gross
On 16/08/18 13:27, Jan Beulich wrote: On 16.08.18 at 12:56, wrote: >> On 16/08/18 11:29, Jan Beulich wrote: >>> Following some further discussion with Andrew, he looks to be >>> convinced that the issue is to be fixed in the balloon driver, >>> which so far (intentionally afaict) does not rem

[Xen-devel] [PATCH v3 05/16] x86: PIT emulation is common to both PV and HVM

2018-09-04 Thread Wei Liu
Move the file to x86 common code and change its name to emul-i8254.c. Put HVM only code under CONFIG_HVM or is_hvm_domain. Signed-off-by: Wei Liu --- v3: remove some CONFIG_HVMs, rely on DCE v2: move the whole file. --- xen/arch/x86/Makefile | 1 + xen/arch/x86/{hvm/i8254.

[Xen-devel] [PATCH v3 07/16] x86/p2m/pod: make it build with !CONFIG_HVM

2018-09-04 Thread Wei Liu
Populate-on-demand is HVM only. Provide a bunch of stubs for common p2m code and guard one invocation of guest_physmap_mark_populate_on_demand with is_hvm_domain. Put relevant fields in p2m_domain and code which touches those fields under CONFIG_HVM. Signed-off-by: Wei Liu --- v3: Put pod relat

[Xen-devel] [PATCH v3 04/16] x86: monitor.o is currently HVM only

2018-09-04 Thread Wei Liu
There has been plan to make PV work, but it is not yet there. Provide stubs to make it build with !CONFIG_HVM. Signed-off-by: Wei Liu --- v3: 1. return EOPNOUTSUPP instead of 0 2. fix style issue --- xen/arch/x86/Makefile | 2 +- xen/include/asm-x86/monitor.h | 13 + 2 file

[Xen-devel] [PATCH v3 02/16] x86: introduce and use a set of internal emulation flags

2018-09-04 Thread Wei Liu
Use these flags in has_* tests and emulation_flags_ok. Not using raw flags directly enabling DCE to kick in for has_* tests while at the same time making sure emulation_flags_ok won't go out of sync. Signed-off-by: Wei Liu --- v3: new --- xen/arch/x86/domain.c| 13 ++ xen/includ

[Xen-devel] [PATCH v3 08/16] x86/hvm: rearrange content of hvm.h

2018-09-04 Thread Wei Liu
Move enum and function declarations to first half of the file. Static inline functions and macros, which reference HVM specific fields directly are grouped together in second half of the file. The movement is needed because in a later patch the second half is going to be enclosed in CONFIG_HVM.

[Xen-devel] [PATCH v3 01/16] x86: change name of parameter for various invlpg functions

2018-09-04 Thread Wei Liu
They all incorrectly named a parameter virtual address while it should have been linear address. Requested-by: Andrew Cooper Signed-off-by: Wei Liu Acked-by: Jan Beulich Reviewed-by: Kevin Tian Acked-by: Boris Ostrovsky --- xen/arch/x86/hvm/svm/svm.c | 14 +++--- xen/arch/x86

[Xen-devel] [PATCH v3 09/16] x86: provide stubs, declarations and macros in hvm.h

2018-09-04 Thread Wei Liu
Make sure hvm_enabled evaluate to false then provide necessary things to make xen build when !CONFIG_HVM. Signed-off-by: Wei Liu --- v3: rewritten --- xen/include/asm-x86/hvm/hvm.h | 97 +++ 1 file changed, 97 insertions(+) diff --git a/xen/include/asm-x8

[Xen-devel] [PATCH v3 00/16] Make CONFIG_HVM work

2018-09-04 Thread Wei Liu
This series goes through x86 code to make CONFIG_HVM work. With this series, it is possible to build Xen with PV support only. Running `xl info` on a host with PV only Xen: root@lcy2-dt108:~# xl info host : lcy2-dt108 release: 4.17.0-0.bpo.1-amd64 version

[Xen-devel] [PATCH v3 06/16] libxl: don't set PoD target for PV guests

2018-09-04 Thread Wei Liu
Previously PoD target was unconditionally set for both PV and HVM guests, but in fact PoD has always been an HVM (now PVH as well) only feature. Signed-off-by: Wei Liu --- tools/libxl/libxl_mem.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/tools/l

[Xen-devel] [PATCH v3 03/16] x86: XENMEM_resource_ioreq_server is HVM only

2018-09-04 Thread Wei Liu
Put the entire case branch under CONFIG_HVM. Nonetheless check HVM before trying to get ioreq server. Signed-off-by: Wei Liu --- v3: 1. put an assert in hvm_get_ioreq_server_frame 2. remove redundant assignment of rc v2: put entire case branch under CONFIG_HVM --- xen/arch/x86/hvm/ioreq.c | 5

Re: [Xen-devel] [PATCH v3 03/16] x86: XENMEM_resource_ioreq_server is HVM only

2018-09-04 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 04 September 2018 17:15 > To: xen-devel@lists.xenproject.org > Cc: Wei Liu ; Paul Durrant ; > Jan Beulich ; Andrew Cooper > > Subject: [PATCH v3 03/16] x86: XENMEM_resource_ioreq_server is HVM > only > > Put the ent

Re: [Xen-devel] [PATCH 0/2] MMIO emulation fixes

2018-09-04 Thread Andrew Cooper
On 04/09/18 17:11, Juergen Gross wrote: > On 16/08/18 13:27, Jan Beulich wrote: > On 16.08.18 at 12:56, wrote: >>> On 16/08/18 11:29, Jan Beulich wrote: Following some further discussion with Andrew, he looks to be convinced that the issue is to be fixed in the balloon driver, w

[Xen-devel] [PATCH v3 12/16] x86/mm: put paging_update_nestedmode under CONFIG_HVM

2018-09-04 Thread Wei Liu
Nested HVM is not enabled when !CONFIG_HVM. Signed-off-by: Wei Liu --- xen/arch/x86/mm/paging.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c index dcee496eb0..7f460bd321 100644 --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/pagin

[Xen-devel] [PATCH v3 13/16] xen: connect guest creation with CONFIG_{HVM, PV}

2018-09-04 Thread Wei Liu
Signed-off-by: Wei Liu Acked-by: Jan Beulich --- xen/common/domain.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/xen/common/domain.c b/xen/common/domain.c index 78c450e4b4..1f95bd169c 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -318,9 +318,24 @@ struct

[Xen-devel] [PATCH v3 14/16] x86: expose CONFIG_HVM

2018-09-04 Thread Wei Liu
Signed-off-by: Wei Liu --- v3: longer text v2: use tab to indent Haven't added a dependency on PV_SHIM_EXCLUSIVE because agreement is not yet reached. --- xen/arch/x86/Kconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index ae1b7

[Xen-devel] [PATCH v3 15/16] x86/pvshim: disable HVM for PV shim

2018-09-04 Thread Wei Liu
Signed-off-by: Wei Liu Reviewed-by: Roger Pau Monné --- tools/firmware/xen-dir/shim.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/firmware/xen-dir/shim.config b/tools/firmware/xen-dir/shim.config index 21d7075bb4..de53dfe376 100644 --- a/tools/firmware/xen-dir

[Xen-devel] [PATCH v3 16/16] xen: decouple HVM and IOMMU capabilities

2018-09-04 Thread Wei Liu
HVM and IOMMU are two distinct hardware features, yet they were bundled together in sysctl and xl's output. Decouple them on sysctl level. On toolstack level we still need to maintain a sensible semantics for `xl info`. Massage the information according to the following table: pv hvm iom

[Xen-devel] [PATCH v3 10/16] x86/mm: put nested p2m code under CONFIG_HVM

2018-09-04 Thread Wei Liu
These functions are only useful for nested hvm, which isn't enabled when CONFIG_HVM is false. Enclose relevant code and fields in CONFIG_HVM. Guard np2m_schedule with nestedhvm_enabled. Signed-off-by: Wei Liu --- xen/arch/x86/domain.c| 6 -- xen/arch/x86/mm/p2m.c| 18 ++

[Xen-devel] [PATCH v3 11/16] x86/mm: put HVM only code under CONFIG_HVM

2018-09-04 Thread Wei Liu
Going through the code, HAP, EPT, PoD and ALTP2M depend on HVM code. Put these components under CONFIG_HVM. This further requires putting one of the vm event under CONFIG_HVM. Altp2m requires a bit more attention because its code is embedded in generic x86 p2m code. Also make hap_enabled evaluate

Re: [Xen-devel] [PATCH v3 04/16] x86: monitor.o is currently HVM only

2018-09-04 Thread Razvan Cojocaru
On 9/4/18 7:15 PM, Wei Liu wrote: > There has been plan to make PV work, but it is not yet there. Provide > stubs to make it build with !CONFIG_HVM. > > Signed-off-by: Wei Liu Acked-by: Razvan Cojocaru Thanks, Razvan ___ Xen-devel mailing list Xen

Re: [Xen-devel] [PATCH v3 03/16] x86: XENMEM_resource_ioreq_server is HVM only

2018-09-04 Thread Wei Liu
On Tue, Sep 04, 2018 at 05:15:20PM +0100, Wei Liu wrote: > Put the entire case branch under CONFIG_HVM. > > Nonetheless check HVM before trying to get ioreq server. The wording here is confusing. It should have been written as: Lift the check from hvm_get_ioreq_server_frame into its caller. Wei

Re: [Xen-devel] [PATCH] libxl: create control/sysrq xenstore node

2018-09-04 Thread Wei Liu
ore trace confirms: > > IN 0x24bd9a0 20180904 04:36:32 WRITE (control/sysrq ) > OUT 0x24bd9a0 20180904 04:36:32 ERROR (EACCES ) > > The problem seems to be in the fact that we don't pre-create control/sysrq > xenstore node and libxl_send_sysrq() doing libxl__xs_printf() c

Re: [Xen-devel] incompatible changes in staging break qemu

2018-09-04 Thread Anthony PERARD
On Wed, Aug 29, 2018 at 02:22:05PM +0200, Olaf Hering wrote: > On Mon, Aug 27, Olaf Hering wrote: > > > Since about two weeks, no released qemu can be built against > > xen.git#staging. The error looks like that: > > qemu-20180825T130857.235c82acca/include/hw/xen/xen_common.h:677:5: error: > > t

Re: [Xen-devel] [PATCH v3 07/16] x86/p2m/pod: make it build with !CONFIG_HVM

2018-09-04 Thread Razvan Cojocaru
On 9/4/18 7:15 PM, Wei Liu wrote: > Populate-on-demand is HVM only. > > Provide a bunch of stubs for common p2m code and guard one invocation > of guest_physmap_mark_populate_on_demand with is_hvm_domain. > > Put relevant fields in p2m_domain and code which touches those fields > under CONFIG_HVM

Re: [Xen-devel] [PATCH v3 07/16] x86/p2m/pod: make it build with !CONFIG_HVM

2018-09-04 Thread Razvan Cojocaru
On 9/4/18 8:08 PM, Razvan Cojocaru wrote: > On 9/4/18 7:15 PM, Wei Liu wrote: >> Populate-on-demand is HVM only. >> >> Provide a bunch of stubs for common p2m code and guard one invocation >> of guest_physmap_mark_populate_on_demand with is_hvm_domain. >> >> Put relevant fields in p2m_domain and co

Re: [Xen-devel] [PATCH v3 11/16] x86/mm: put HVM only code under CONFIG_HVM

2018-09-04 Thread Razvan Cojocaru
On 9/4/18 7:15 PM, Wei Liu wrote: > Going through the code, HAP, EPT, PoD and ALTP2M depend on HVM code. > Put these components under CONFIG_HVM. This further requires putting > one of the vm event under CONFIG_HVM. > > Altp2m requires a bit more attention because its code is embedded in > generic

Re: [Xen-devel] incompatible changes in staging break qemu

2018-09-04 Thread Andrew Cooper
On 04/09/18 18:01, Anthony PERARD wrote: > On Wed, Aug 29, 2018 at 02:22:05PM +0200, Olaf Hering wrote: >> On Mon, Aug 27, Olaf Hering wrote: >> >>> Since about two weeks, no released qemu can be built against >>> xen.git#staging. The error looks like that: >>> qemu-20180825T130857.235c82acca/incl

Re: [Xen-devel] [PATCH v3 07/16] x86/p2m/pod: make it build with !CONFIG_HVM

2018-09-04 Thread Julien Grall
Hi Wei, On 09/04/2018 05:15 PM, Wei Liu wrote: Populate-on-demand is HVM only. Provide a bunch of stubs for common p2m code and guard one invocation of guest_physmap_mark_populate_on_demand with is_hvm_domain. Put relevant fields in p2m_domain and code which touches those fields under CONFIG_H

[Xen-devel] [PATCH v2] xen:arm: Populate arm64 image header

2018-09-04 Thread Amit Singh Tomar
This patch adds image size and flags to XEN image header. It uses those fields according to the updated Linux kernel image definition. With this patch bootloader can now place XEN image anywhere in system RAM at 2MB aligned address without to worry about relocation. For instance, it fixes the XEN

Re: [Xen-devel] [PATCH] libxl: create control/sysrq xenstore node

2018-09-04 Thread Vitaly Kuznetsov
in control/sysrq >> >> xenstore trace confirms: >> >> IN 0x24bd9a0 20180904 04:36:32 WRITE (control/sysrq ) >> OUT 0x24bd9a0 20180904 04:36:32 ERROR (EACCES ) >> >> The problem seems to be in the fact that we don't pre-create control/sysrq >

[Xen-devel] [PATCH] xen-swiotlb: use actually allocated size on check physical contiguous

2018-09-04 Thread Joe Jin
xen_swiotlb_{alloc,free}_coherent() actually allocate/free size by order but used the required size to check if address is physical contiguous, if first pages are physical contiguous also passed range_straddles_page_boundary() check, but others were not it will lead kernel panic. Signed-off-by: Jo

[Xen-devel] [xtf test] 127269: all pass - PUSHED

2018-09-04 Thread osstest service owner
flight 127269 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127269/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf 089f9be25f4bb445f68241ba05ab4e17786e21a7 baseline version: xtf f3702a5d29e94814991988

[Xen-devel] Rats nest with domain pirq initialisation

2018-09-04 Thread Andrew Cooper
On 13/08/18 11:01, Andrew Cooper wrote: > This is in preparation to set up d->max_cpus and d->vcpu[] in domain_create(), > and allow later parts of domain construction to have access to the values. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Stefano Stabellini > CC: Julien Gra

Re: [Xen-devel] [PATCH] xen-swiotlb: use actually allocated size on check physical contiguous

2018-09-04 Thread Greg KH
On Tue, Sep 04, 2018 at 11:16:58AM -0700, Joe Jin wrote: > xen_swiotlb_{alloc,free}_coherent() actually allocate/free size by order > but used the required size to check if address is physical contiguous, > if first pages are physical contiguous also passed > range_straddles_page_boundary() check,

[Xen-devel] [PATCH 03/13] xen: provide a prototype for xen_biovec_phys_mergeable in xen.h

2018-09-04 Thread Christoph Hellwig
Having multiple externs in arch headers is not a good way to provide a common interface. Signed-off-by: Christoph Hellwig --- arch/arm/include/asm/io.h | 3 --- arch/arm64/include/asm/io.h | 3 --- arch/x86/include/asm/io.h | 5 - include/xen/xen.h | 4 4 files changed, 4

[Xen-devel] [PATCH 06/13] block: move req_gap_back_merge to blk.h

2018-09-04 Thread Christoph Hellwig
No need to expose these helpers outside the block layer. Signed-off-by: Christoph Hellwig --- block/blk.h| 19 +++ include/linux/blkdev.h | 19 --- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/block/blk.h b/block/blk.h index 441c2de

[Xen-devel] [PATCH 11/13] block: don't include io.h from bio.h

2018-09-04 Thread Christoph Hellwig
Now that we don't need an override for BIOVEC_PHYS_MERGEABLE there is no need to drag this header in. Signed-off-by: Christoph Hellwig --- include/linux/bio.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/bio.h b/include/linux/bio.h index fcb5f5618ed4..3af2fea686a9 100644 -

[Xen-devel] [PATCH 13/13] xen: don't include from and

2018-09-04 Thread Christoph Hellwig
Nothing Xen specific in these headers, which get included from a lot of code in the kernel. So prune the includes and move them to the Xen-specific files that actually use them instead. Signed-off-by: Christoph Hellwig --- arch/arm/include/asm/io.h | 1 - arch/arm64/include/asm/io.h

[Xen-devel] [PATCH 07/13] block: simplify BIOVEC_PHYS_MERGEABLE

2018-09-04 Thread Christoph Hellwig
Turn the macro into an inline, move it to blk.h and take the Xen check into the core code instead of delegating it to architectures. Also rename the function to biovec_phys_mergeable as there is no need to shout. Signed-off-by: Christoph Hellwig --- arch/arm/include/asm/io.h | 4 arch/a

[Xen-devel] [PATCH 12/13] block: don't include bug.h from bio.h

2018-09-04 Thread Christoph Hellwig
No need to pull in the BUG() defintion. Signed-off-by: Christoph Hellwig --- include/linux/bio.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/bio.h b/include/linux/bio.h index 3af2fea686a9..85f2e56ecdb8 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -21,7 +21,6

[Xen-devel] [PATCH 05/13] block: move req_gap_{back, front}_merge to blk-merge.c

2018-09-04 Thread Christoph Hellwig
Keep it close to the actual users instead of exposing the function to all drivers. Signed-off-by: Christoph Hellwig --- block/blk-merge.c | 65 +++ include/linux/blkdev.h | 69 -- 2 files changed, 65 insertions(+),

  1   2   >