Re: [Xen-devel] [PATCH v6 11/11] xen: introduce ERRP_AUTO_PROPAGATE

2020-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2020 11:57, Paul Durrant wrote: > On Fri, 10 Jan 2020 at 19:42, Vladimir Sementsov-Ogievskiy > wrote: >> >> If we want to add some info to errp (by error_prepend() or >> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. >> Otherwise, this info will not be added when errp ==

Re: [Xen-devel] [PATCH v6 02/11] error: auto propagated local_err

2020-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2020 11:50, Paul Durrant wrote: > On Fri, 10 Jan 2020 at 19:42, Vladimir Sementsov-Ogievskiy > wrote: > [snip] >> +/* >> + * ERRP_AUTO_PROPAGATE >> + * >> + * This macro is created to be the first line of a function which use >> + * Error **errp parameter to report error. It's needed only

Re: [Xen-devel] [PATCH v13 0/5] xenbus/backend: Add memory pressure handler callback

2020-01-13 Thread SeongJae Park
Every patch of this patchset got at least one 'Reviewed-by' or 'Acked-by' from appropriate maintainers by last Wednesday, and after that, got no comment yet. May I ask some more comments? Thanks, SeongJae Park On Wed, 18 Dec 2019 19:37:13 +0100 SeongJae Park wrote: > Granting pages consumes

[Xen-devel] live migration from 4.12 to 4.13 fails due to qemu-xen bug

2020-01-13 Thread Olaf Hering
I did not find anything in the Xen 4.13 release notes, so I'm asking here: This HVM domU fails to live migrate from staging-4.12 to staging-4.13: name='hvm' serial='pty' vcpus='4' memory='888' disk=[ 'vdev=xvda, format=raw, access=rw, target=/netshare/disk0.raw' ] vif=[

Re: [Xen-devel] [PATCH v6 02/11] error: auto propagated local_err

2020-01-13 Thread Paul Durrant
On Fri, 10 Jan 2020 at 19:42, Vladimir Sementsov-Ogievskiy wrote: [snip] > +/* > + * ERRP_AUTO_PROPAGATE > + * > + * This macro is created to be the first line of a function which use > + * Error **errp parameter to report error. It's needed only in cases where we > + * want to use error_prepend,

Re: [Xen-devel] [PATCH v13 0/5] xenbus/backend: Add memory pressure handler callback

2020-01-13 Thread Roger Pau Monné
On Mon, Jan 13, 2020 at 10:49:52AM +0100, SeongJae Park wrote: > Every patch of this patchset got at least one 'Reviewed-by' or 'Acked-by' from > appropriate maintainers by last Wednesday, and after that, got no comment yet. > May I ask some more comments? I'm not sure why more comments are

Re: [Xen-devel] [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation

2020-01-13 Thread Singh, Balbir
On Mon, 2020-01-13 at 11:16 +0100, Peter Zijlstra wrote: > On Fri, Jan 10, 2020 at 07:35:20AM -0800, Eduardo Valentin wrote: > > Hey Peter, > > > > On Wed, Jan 08, 2020 at 11:50:11AM +0100, Peter Zijlstra wrote: > > > On Tue, Jan 07, 2020 at 11:45:26PM +, Anchal Agarwal wrote: > > > > From:

Re: [Xen-devel] [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation

2020-01-13 Thread Rafael J. Wysocki
On Mon, Jan 13, 2020 at 12:43 PM Singh, Balbir wrote: > > On Mon, 2020-01-13 at 11:16 +0100, Peter Zijlstra wrote: > > On Fri, Jan 10, 2020 at 07:35:20AM -0800, Eduardo Valentin wrote: > > > Hey Peter, > > > > > > On Wed, Jan 08, 2020 at 11:50:11AM +0100, Peter Zijlstra wrote: > > > > On Tue, Jan

Re: [Xen-devel] [PATCH 4/6] x86/boot: Clean up l?_bootmap[] construction

2020-01-13 Thread Andrew Cooper
On 07/01/2020 16:30, Jan Beulich wrote: > On 07.01.2020 17:16, Jan Beulich wrote: >> On 06.01.2020 16:54, Andrew Cooper wrote: >>> --- a/xen/arch/x86/efi/efi-boot.h >>> +++ b/xen/arch/x86/efi/efi-boot.h >>> @@ -584,21 +584,24 @@ static void __init efi_arch_memory_setup(void) >>> if (

[Xen-devel] [qemu-mainline test] 146042: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146042 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146042/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [PATCH v13 0/5] xenbus/backend: Add memory pressure handler callback

2020-01-13 Thread SeongJae Park
On Mon, 13 Jan 2020 10:55:07 +0100 "Roger Pau Monné" wrote: > On Mon, Jan 13, 2020 at 10:49:52AM +0100, SeongJae Park wrote: > > Every patch of this patchset got at least one 'Reviewed-by' or 'Acked-by' > > from > > appropriate maintainers by last Wednesday, and after that, got no comment > >

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-13 Thread Sergey Dyasli
On 10/01/2020 11:02, Andrew Cooper wrote: > On 10/01/2020 10:37, Sergey Dyasli wrote: >> Hide the following information that can help identify the running Xen >> binary version: XENVER_extraversion, XENVER_compile_info, XENVER_changeset. >> Add explicit cases for XENVER_commandline and

[Xen-devel] [ovmf test] 146041: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146041 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/146041/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 145767

[Xen-devel] [PATCH v2 2/4] drm/ast: Set struct drm_crtc_state.no_vblank in atomic_check()

2020-01-13 Thread Thomas Zimmermann
CRTC state properties should be computed in atomic_check(). Do so for the no_vblank field. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c

[Xen-devel] [PATCH v2 1/4] drm: Document struct drm_crtc_state.no_vblank for faking VBLANK events

2020-01-13 Thread Thomas Zimmermann
Drivers for CRTC hardware without support for VBLANK interrupts can set struct drm_crtc_state.no_vblank and let DRM's atomic commit helpers generate the VBLANK events automatically. Document this in order to make it official. Signed-off-by: Thomas Zimmermann ---

[Xen-devel] [qemu-mainline test] 146043: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146043 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146043/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [PATCH V7 2/4] x86/altp2m: Add hypercall to set a range of sve bits

2020-01-13 Thread Alexandru Stefan ISAILA
On 10.01.2020 18:20, Jan Beulich wrote: > On 08.01.2020 15:08, Alexandru Stefan ISAILA wrote: >> By default the sve bits are not set. >> This patch adds a new hypercall, xc_altp2m_set_supress_ve_multi(), >> to set a range of sve bits. >> The core function, p2m_set_suppress_ve_multi(), does not

Re: [Xen-devel] [RFC PATCH 0/3] Live update boot memory management

2020-01-13 Thread David Woodhouse
On Wed, 2020-01-08 at 17:24 +, David Woodhouse wrote: > When doing a live update, Xen needs to be very careful not to scribble > on pages which contain guest memory or state information for the > domains which are being preserved. > > The information about which pages are in use is contained

Re: [Xen-devel] [PATCH v6 11/11] xen: introduce ERRP_AUTO_PROPAGATE

2020-01-13 Thread Paul Durrant
On Fri, 10 Jan 2020 at 19:42, Vladimir Sementsov-Ogievskiy wrote: > > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == _fatal > (the program will exit prior to the

Re: [Xen-devel] [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation

2020-01-13 Thread Peter Zijlstra
On Fri, Jan 10, 2020 at 07:35:20AM -0800, Eduardo Valentin wrote: > Hey Peter, > > On Wed, Jan 08, 2020 at 11:50:11AM +0100, Peter Zijlstra wrote: > > On Tue, Jan 07, 2020 at 11:45:26PM +, Anchal Agarwal wrote: > > > From: Eduardo Valentin > > > > > > System instability are seen during

[Xen-devel] [PATCH v2 3/4] drm/cirrus: Let DRM core send VBLANK events

2020-01-13 Thread Thomas Zimmermann
In drm_atomic_helper_fake_vblank(), the DRM core sends out VBLANK events if struct drm_crtc_state.no_vblank is enabled. Replace cirrus' VBLANK events with the DRM core's functionality. v2: * set struct_drm_crtc_state.no_vblank in cirrus_pipe_check() Signed-off-by: Thomas Zimmermann ---

[Xen-devel] [PATCH v2 4/4] drm/simple-kms: Let DRM core send VBLANK events by default

2020-01-13 Thread Thomas Zimmermann
In drm_atomic_helper_fake_vblank() the DRM core sends out VBLANK events if struct drm_crtc_state.no_vblank is enabled in the check() callbacks. For drivers that have neither an enable_vblank() callback nor a check() callback, the simple-KMS helpers enable VBLANK generation by default. This

[Xen-devel] [PATCH v2 0/4] Use no_vblank property for drivers without VBLANK

2020-01-13 Thread Thomas Zimmermann
Instead of faking VBLANK events by themselves, drivers without VBLANK support can enable drm_crtc_vblank.no_vblank and let DRM do the rest. The patchset makes this official and converts over several drivers. Ast already uses the functionality and just needs a cleanup. Cirrus can be converted

[Xen-devel] [xen-unstable test] 146039: tolerable FAIL

2020-01-13 Thread osstest service owner
flight 146039 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/146039/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail like 146030

Re: [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

2020-01-13 Thread Jason Andryuk
On Fri, Mar 22, 2019 at 3:43 PM Jason Andryuk wrote: > > On Thu, Mar 21, 2019 at 11:09 PM Roger Pau Monné wrote: > > > > On Wed, Mar 20, 2019 at 01:28:47PM -0400, Jason Andryuk wrote: > > > On Fri, Mar 15, 2019 at 12:28 PM Andrew Cooper > > > wrote: > > > > > > > > On 15/03/2019 09:17, Paul

Re: [Xen-devel] [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation

2020-01-13 Thread Peter Zijlstra
On Mon, Jan 13, 2020 at 11:43:18AM +, Singh, Balbir wrote: > For your original comment, just wanted to clarify the following: > > 1. After hibernation, the machine can be resumed on a different but compatible > host (these are VM images hibernated) > 2. This means the clock between host1 and

Re: [Xen-devel] [PATCH V7 2/4] x86/altp2m: Add hypercall to set a range of sve bits

2020-01-13 Thread Jan Beulich
On 13.01.2020 11:32, Alexandru Stefan ISAILA wrote: > On 10.01.2020 18:20, Jan Beulich wrote: >> On 08.01.2020 15:08, Alexandru Stefan ISAILA wrote: >>> +if ( !(rc = p2m_set_suppress_ve_multi(d, )) && sve.first_error ) >>> +rc = sve.first_error; >> >> Why the right side of the && ? >

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-13 Thread Andrew Cooper
On 13/01/2020 13:39, Julien Grall wrote: > Hi George, > > Thank you for summarising the possibility. One question below. > > On 13/01/2020 12:51, George Dunlap wrote: >> 2. Block XENVER_extraversion at the hypervisor level.  Leave xen_deny() >> as returning "", but replace "" with "" in hvmloader

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-13 Thread Ian Jackson
Doug Goldstein writes ("Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests"): > I'd be happy if we had a Kconfig option behind what the string is. Give > me a blank as an option but default it to whatever string like > "" that you'd like. Every shipping Xen

[Xen-devel] [PATCH v4] MAINTAINERS: Add explicit check-in policy section

2020-01-13 Thread George Dunlap
The "nesting" section in the MAINTAINERS file was not initially intended to describe the check-in policy for patches, but only how nesting worked; but since there was no check-in policy, it has been acting as a de-facto policy. One problem with this is that the policy is not complete: It doesn't

Re: [Xen-devel] [PATCH v4] MAINTAINERS: Add explicit check-in policy section

2020-01-13 Thread Jan Beulich
On 13.01.2020 16:04, George Dunlap wrote: > The "nesting" section in the MAINTAINERS file was not initially > intended to describe the check-in policy for patches, but only how > nesting worked; but since there was no check-in policy, it has been > acting as a de-facto policy. > > One problem

Re: [Xen-devel] EFI development issues

2020-01-13 Thread Jan Beulich
On 13.01.2020 17:02, Andrew Cooper wrote: > My recent boot pagetable changes have caused me to work with the EFI > build of Xen rather more than previously. > > First, there is a dependency tracking bug in the build system.  Edits to > xen/arch/x86/efi/efi-boot.h don't cause xen.efi to be

Re: [Xen-devel] [PATCH v2 4/6] libxl: allow creation of domains with a specified or random domid

2020-01-13 Thread Jason Andryuk
On Mon, Jan 13, 2020 at 11:55 AM Durrant, Paul wrote: > > > -Original Message- > > From: jandr...@gmail.com > > Sent: 13 January 2020 16:16 > > To: Durrant, Paul > > Cc: xen-devel ; Anthony PERARD > > ; Ian Jackson ; Wei > > Liu > > Subject: Re: [Xen-devel] [PATCH v2 4/6] libxl: allow

[Xen-devel] [qemu-mainline test] 146052: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146052 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146052/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] live migration from 4.12 to 4.13 fails due to qemu-xen bug

2020-01-13 Thread Olaf Hering
Am Mon, 13 Jan 2020 11:36:27 +0100 schrieb Olaf Hering : > qemu-system-i386: Unknown savevm section type 111 Looks like hw/i386/pc_piix.c:xenfv_machine_options must set m->smbus_no_migration_support to true. Not sure why this remained unnoticed for so long. Olaf pgpffQqWBqgtH.pgp

[Xen-devel] [PATCH v2 10/10] libxl: event: Move poller pipe emptying to the end of afterpoll

2020-01-13 Thread Ian Jackson
If a timer event callback causes this poller to be woken (not very unlikely) we would go round the poll loop twice rather than once. Do the poller pipe emptying at the end; this is slightly more efficient because it can't cause any callbacks, so it happens after all the callbacks have been run.

[Xen-devel] [PATCH v2 00/10] libxl: event: Fix hang for some applications

2020-01-13 Thread Ian Jackson
The meat here, including a description of the bug, is in: libxl: event: Fix hang when mixing blocking and eventy calls Re v1 I wrote: I suggest we try to convince ourselves of its correctness via a second round of code review. I put this into practice by writing an informal proof of

[Xen-devel] [PATCH v2 01/10] libxl: event: Rename poller.fds_changed to .fds_deregistered

2020-01-13 Thread Ian Jackson
This is only for deregistration. We are going to add another variable for new events, with different semantics, and this overly-general name will become confusing. Signed-off-by: Ian Jackson --- tools/libxl/libxl_event.c| 8 tools/libxl/libxl_internal.h | 6 +++--- 2 files

[Xen-devel] [PATCH 4/4] x86/boot: Size the boot/directmap mappings dynamically

2020-01-13 Thread Andrew Cooper
... rather than presuming that 16M will do. With this fixed, Xen is now capable of booting even when its compiled size is larger than 16M. On the EFI side, use l2e_add_flags() to reduce the code-generation overhead of using l2e_from_paddr() twice. Signed-off-by: Andrew Cooper --- CC: Jan

[Xen-devel] [PATCH 2/4] x86/page: Remove bifrucated PAGE_HYPERVISOR constant

2020-01-13 Thread Andrew Cooper
Despite being vaguely aware, the difference between PAGE_HYPERVISOR in ASM and C code has nevertheless caused several bugs I should have known better about, and contributed to review confusion. There are exactly 4 uses of these constants in asm code (and one is shortly going to disappear).

[Xen-devel] [PATCH 1/4] x86/boot: Rename l?_identmap to l?_directmap

2020-01-13 Thread Andrew Cooper
Since c/s faa85d4fb3 "x86/boot: Don't map 0 during boot", l1_identmap no longer has an alias mapped at 0, meaning that none of the l?_identmap[] pagetables are actually an identity map. Rename them to l?_directmap, which avoids any kind of implication that they might be mapped at 0.

[Xen-devel] [PATCH 3/4] x86/boot: Create the l2_xenmap[] mappings dynamically

2020-01-13 Thread Andrew Cooper
The build-time construction of l2_xenmap[] imposes an arbitrary limit of 16M total, which is a limit looking to be lifted. Move l2_xenmap[] into the bss, and adjust both the BIOS and EFI paths to fill it in dynamically, based on the final linked size of Xen. For current builds, this reduces the

[Xen-devel] [PATCH 2/4] x86/page: Remove bifurcated PAGE_HYPERVISOR constant

2020-01-13 Thread Andrew Cooper
Despite being vaguely aware, the difference between PAGE_HYPERVISOR in ASM and C code has nevertheless caused several bugs I should have known better about, and contributed to review confusion. There are exactly 4 uses of these constants in asm code (and one is shortly going to disappear).

[Xen-devel] [qemu-mainline test] 146049: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146049 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146049/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [PATCH v3] xen-pciback: optionally allow interrupt enable flag writes

2020-01-13 Thread Nick Desaulniers
Hi Marek, Below is a report from 0day bot build w/ Clang. The warning looks legit, can you please take a look? Apologies if this has already been reported. On Sat, Jan 11, 2020 at 7:48 AM kbuild test robot wrote: > > CC: kbuild-...@lists.01.org > In-Reply-To:

Re: [Xen-devel] [PATCH v2 4/6] libxl: allow creation of domains with a specified or random domid

2020-01-13 Thread Durrant, Paul
> -Original Message- > From: jandr...@gmail.com > Sent: 13 January 2020 16:16 > To: Durrant, Paul > Cc: xen-devel ; Anthony PERARD > ; Ian Jackson ; Wei > Liu > Subject: Re: [Xen-devel] [PATCH v2 4/6] libxl: allow creation of domains > with a specified or random domid > > On Thu, Jan

[Xen-devel] [PATCH v2 09/10] libxl: event: Fix possible hang with libxl_osevent_beforepoll

2020-01-13 Thread Ian Jackson
If the application uses libxl_osevent_beforepoll, a similar hang is possible to the one described and fixed in libxl: event: Fix hang when mixing blocking and eventy calls Application behaviour would have to be fairly unusual, but it doesn't seem sensible to just leave this latent bug. We fix

[Xen-devel] [PATCH v2 04/10] libxl: event: Make LIBXL__EVENT_DISASTER take a gc, not an egc

2020-01-13 Thread Ian Jackson
We are going to want to change libxl__poller_wakeup to take a gc. In theory there is a risk here that it would be called inappropriately in a future patch but this seems unlikely. Signed-off-by: Ian Jackson --- v2: New patch --- tools/libxl/libxl_aoutils.c | 2 +- tools/libxl/libxl_disk.c

[Xen-devel] [PATCH v2 03/10] libxl: event: Introduce CTX_UNLOCK_EGC_FREE

2020-01-13 Thread Ian Jackson
This is a very common exit pattern. We are going to want to change this pattern. So we should make it into a macro of its own. No functional change. Signed-off-by: Ian Jackson --- tools/libxl/libxl_event.c| 18 ++ tools/libxl/libxl_fork.c | 6 ++

[Xen-devel] [PATCH v2 07/10] libxl: event: poller pipe optimisation

2020-01-13 Thread Ian Jackson
Track in userland whether the poller pipe is nonempty. This saves us writing many many bytes to the pipe if nothing ever reads them. This is going to be relevant in a moment, where we are going to create a situation where this will happen quite a lot. Signed-off-by: Ian Jackson squash! libxl:

[Xen-devel] [PATCH v2 05/10] libxl: event: Make libxl__poller_wakeup take a gc, not an egc

2020-01-13 Thread Ian Jackson
We are going to want to call this in the following situation: * We have just set up an ao, which is to call back - so a non-synchronous one. It ought not to call the application back right away, so no egc. * There is a libxl thread blocking somewhere but it is using using an out of

[Xen-devel] [PATCH v2 06/10] libxl: event: Fix hang when mixing blocking and eventy calls

2020-01-13 Thread Ian Jackson
If the application calls libxl with ao_how==0 and also makes calls like _occurred, libxl will sometimes get stuck. The bug happens as follows (for example): Thread A libxl_do_thing(,ao_how==0) libxl_do_thing starts, sets up some callbacks libxl_do_thing exit path calls

[Xen-devel] [PATCH v2 08/10] libxl: event: Break out baton_wake

2020-01-13 Thread Ian Jackson
No functional change. Signed-off-by: Ian Jackson --- v2: Now it takes a gc, not an egc. --- tools/libxl/libxl_event.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/tools/libxl/libxl_event.c b/tools/libxl/libxl_event.c index 3e76fa5af5..45cc67942d

[Xen-devel] [PATCH v2 02/10] libxl: event: Rename ctx.pollers_fd_changed to .pollers_active

2020-01-13 Thread Ian Jackson
We are going to use this a bit more widely. Make the name more general. Signed-off-by: Ian Jackson --- tools/libxl/libxl.c | 4 ++-- tools/libxl/libxl_event.c| 8 tools/libxl/libxl_internal.h | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git

[Xen-devel] [PATCH 0/4] x86: Remove 16M total-size restriction

2020-01-13 Thread Andrew Cooper
It turns out that the note in c/s a8d27a54cc9cc Finally, leave a linker assert covering the fact that plenty of code blindly assumes that Xen is less that 16M. This wants fixing in due course. was easier to address than I had originally anticipated. This series does so. The end result can

[Xen-devel] [qemu-mainline test] 146045: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146045 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146045/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation

2020-01-13 Thread Andrew Cooper
On 13/01/2020 11:43, Singh, Balbir wrote: > On Mon, 2020-01-13 at 11:16 +0100, Peter Zijlstra wrote: >> On Fri, Jan 10, 2020 at 07:35:20AM -0800, Eduardo Valentin wrote: >>> Hey Peter, >>> >>> On Wed, Jan 08, 2020 at 11:50:11AM +0100, Peter Zijlstra wrote: On Tue, Jan 07, 2020 at 11:45:26PM

Re: [Xen-devel] [PATCH v2 4/6] libxl: allow creation of domains with a specified or random domid

2020-01-13 Thread Jason Andryuk
On Thu, Jan 9, 2020 at 6:50 AM Paul Durrant wrote: > > This patch adds a 'domid' field to libxl_domain_create_info and then > modifies do_domain_create() to use that value if it is valid. Any valid > domid will be checked against the retired domid list before being passed > to

Re: [Xen-devel] [PATCH V7 2/4] x86/altp2m: Add hypercall to set a range of sve bits

2020-01-13 Thread Alexandru Stefan ISAILA
On 13.01.2020 14:53, Jan Beulich wrote: > On 13.01.2020 11:32, Alexandru Stefan ISAILA wrote: >> On 10.01.2020 18:20, Jan Beulich wrote: >>> On 08.01.2020 15:08, Alexandru Stefan ISAILA wrote: +if ( !(rc = p2m_set_suppress_ve_multi(d, )) && sve.first_error ) +rc =

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-13 Thread Andrew Cooper
On 13/01/2020 12:51, George Dunlap wrote: > On 1/12/20 6:26 PM, Doug Goldstein wrote: >> On 1/11/20 3:02 AM, George Dunlap wrote: >>> On Jan 11, 2020, at 4:02 AM, Doug Goldstein wrote: On 1/10/20 4:37 AM, Sergey Dyasli wrote: > Hide the following information that can

[Xen-devel] EFI development issues

2020-01-13 Thread Andrew Cooper
Hello, My recent boot pagetable changes have caused me to work with the EFI build of Xen rather more than previously. First, there is a dependency tracking bug in the build system.  Edits to xen/arch/x86/efi/efi-boot.h don't cause xen.efi to be regenerated.  From what I can tell, the file

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-13 Thread Julien Grall
Hi, On 13/01/2020 12:51, George Dunlap wrote: On 1/12/20 6:26 PM, Doug Goldstein wrote: On 1/11/20 3:02 AM, George Dunlap wrote: 1. Block XENVER_extraversion at the hypervisor level. Change the xen_deny() string to "". (This is v1 of sergey's patch.) 2. Block XENVER_extraversion at the

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-13 Thread George Dunlap
On 1/12/20 6:26 PM, Doug Goldstein wrote: > On 1/11/20 3:02 AM, George Dunlap wrote: >> >> >>> On Jan 11, 2020, at 4:02 AM, Doug Goldstein wrote: >>> >>> >>> >>> On 1/10/20 4:37 AM, Sergey Dyasli wrote: Hide the following information that can help identify the running Xen binary

[Xen-devel] [ovmf test] 146044: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146044 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/146044/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 145767

Re: [Xen-devel] [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation

2020-01-13 Thread David Woodhouse
On Mon, 2020-01-13 at 13:01 +, Andrew Cooper wrote: > On 13/01/2020 11:43, Singh, Balbir wrote: > > On Mon, 2020-01-13 at 11:16 +0100, Peter Zijlstra wrote: > > > On Fri, Jan 10, 2020 at 07:35:20AM -0800, Eduardo Valentin wrote: > > > > Hey Peter, > > > > > > > > On Wed, Jan 08, 2020 at

Re: [Xen-devel] [PATCH v2 2/2] libxl: Add new "notify-only" childproc mode

2020-01-13 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH v2 2/2] libxl: Add new "notify-only" childproc mode"): > FAOD, with the fixes in your other series, I consider this patch to now > be moot. Right. FTOAD, I don't think there was a problem with this patch principle; it's just not needed now. If someone comes up

[Xen-devel] [ovmf test] 146047: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146047 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/146047/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 145767

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-13 Thread George Dunlap
On 1/13/20 2:01 PM, Andrew Cooper wrote: > On 13/01/2020 13:39, Julien Grall wrote: >> Hi George, >> >> Thank you for summarising the possibility. One question below. >> >> On 13/01/2020 12:51, George Dunlap wrote: >>> 2. Block XENVER_extraversion at the hypervisor level.  Leave xen_deny() >>> as

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-13 Thread Julien Grall
On 13/01/2020 14:07, George Dunlap wrote: On 1/13/20 2:01 PM, Andrew Cooper wrote: On 13/01/2020 13:39, Julien Grall wrote: Hi George, Thank you for summarising the possibility. One question below. On 13/01/2020 12:51, George Dunlap wrote: 2. Block XENVER_extraversion at the hypervisor

Re: [Xen-devel] [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation

2020-01-13 Thread Singh, Balbir
On Mon, 2020-01-13 at 13:01 +, Andrew Cooper wrote: > On 13/01/2020 11:43, Singh, Balbir wrote: > > On Mon, 2020-01-13 at 11:16 +0100, Peter Zijlstra wrote: > > > On Fri, Jan 10, 2020 at 07:35:20AM -0800, Eduardo Valentin wrote: > > > > Hey Peter, > > > > > > > > On Wed, Jan 08, 2020 at

[Xen-devel] [PATCH v2] Introduce CHANGELOG.md

2020-01-13 Thread Paul Durrant
As agreed during the 2020-01 community call [1] this patch introduces a changelog, based on the principles explained at keepachangelog.com [2]. A new MAINTAINERS entry is also added, with myself as (currently sole) maintainer. [1] See C.2 at

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-13 Thread Julien Grall
Hi George, Thank you for summarising the possibility. One question below. On 13/01/2020 12:51, George Dunlap wrote: 2. Block XENVER_extraversion at the hypervisor level. Leave xen_deny() as returning "", but replace "" with "" in hvmloader so it doesn't show up in the System Info and scare

[Xen-devel] [qemu-mainline test] 146046: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146046 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146046/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [PATCH] MAINTAINERS: Add explicit check-in policy section

2020-01-13 Thread George Dunlap
On 1/7/20 4:44 PM, Jan Beulich wrote: > On 07.01.2020 17:17, George Dunlap wrote: >> On 1/7/20 1:05 PM, Jan Beulich wrote: >> 2. It must have either a an Acked-by from a maintainer, or a >>Reviewed-by. This must come from someone other than the submitter. > > Better, but leaving ambiguous

[Xen-devel] [xen-unstable-smoke test] 146048: tolerable all pass - PUSHED

2020-01-13 Thread osstest service owner
flight 146048 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/146048/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH v3] xen-pciback: optionally allow interrupt enable flag writes

2020-01-13 Thread Boris Ostrovsky
On 1/10/20 10:43 PM, Marek Marczykowski-Górecki wrote: @@ -117,6 +117,24 @@ static int command_write(struct pci_dev *dev, int offset, u16 value, void *data) pci_clear_mwi(dev); } + if (dev_data && dev_data->allow_interrupt_control) { + if ((cmd->val ^

[Xen-devel] [PATCH 2/4] xen/char: ehci: Directly include xen/timer.h rather rely on dependency

2020-01-13 Thread Julien Grall
From: Julien Grall The ehci char driver is using timers but relying on the header xen/timer.h to be included via asm-x86/hvm/irq.h which is not even directly included! Future rework will reduce the number of places where asm-x86/hvm/irq.h will be included. Include xen/timer.h directly to avoid

[Xen-devel] [PATCH 3/4] xen/domain: Remove #ifndef surrounding alloc_pirq_struct()

2020-01-13 Thread Julien Grall
From: Julien Grall None of the supported architecture override alloc_pirq_struct() with a macro. So remove the #ifdef surrounding the prototype. Signed-off-by: Julien Grall --- xen/include/xen/domain.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/include/xen/domain.h

[Xen-devel] [PATCH 4/4] xen/x86: Rework inclusion between struct pirq and struct hvm_pirq_dpci

2020-01-13 Thread Julien Grall
From: Julien Grall At the moment, alloc_pirq_struct() relies on the field 'arch' to be the last member of the structure. As this is used for computing the size of the structure, the value will be miscomputed if a new field is added afterwards. Such quirkiness makes quite difficult to

[Xen-devel] [PATCH 1/4] xen/x86: Remove unused forward declaration in asm-x86/irq.h

2020-01-13 Thread Julien Grall
From: Julien Grall None of the prototypes within the header asm-x86/irq.h actually requires the forward declaration of "struct pirq". So remove it. No functional changes intended. Signed-off-by: Julien Grall --- xen/include/asm-x86/irq.h | 1 - 1 file changed, 1 deletion(-) diff --git

[Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash

2020-01-13 Thread Julien Grall
pandoc is currently failing to generate the pdf with the following error: ! Undefined control sequence. l.1048 metadata string format is: key=value\0 In this case, we want to print \0 so we need to backslash-escape the first character. Interestingly pandoc will not complain when creating html

[Xen-devel] [qemu-mainline test] 146053: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146053 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146053/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [PATCH v2 4/6] libxl: allow creation of domains with a specified or random domid

2020-01-13 Thread Julien Grall
Hi Paul, On 13/01/2020 16:54, Durrant, Paul wrote: -Original Message- From: jandr...@gmail.com Sent: 13 January 2020 16:16 To: Durrant, Paul Cc: xen-devel ; Anthony PERARD ; Ian Jackson ; Wei Liu Subject: Re: [Xen-devel] [PATCH v2 4/6] libxl: allow creation of domains with a

[Xen-devel] [PATCH 0/4] xen/x86: Rework inclusion between struct pirq and

2020-01-13 Thread Julien Grall
Hi all, The main goal of this series is to make easier to understand and use struct pirq. Patch #1 and #3 are cleanups. Cheers, Julien Grall (4): xen/x86: Remove unused forward declaration in asm-x86/irq.h xen/char: ehci: Directly include xen/timer.h rather rely on dependency xen/domain:

[Xen-devel] [PATCH] docs/misc: pvcalls: Verbatim block should be indented with 4 spaces

2020-01-13 Thread Julien Grall
At the moment, the diagram is only indented with 2 spaces. So pandoc will try to badly interpret it and not display it correctly. Fix it by indenting all the block by 4 spaces (i.e an extra 2 spaces). Fixes: d661611d08 ("docs/markdown: Switch to using pandoc, and fix underscore escaping")

Re: [Xen-devel] [PATCH v3] xen-pciback: optionally allow interrupt enable flag writes

2020-01-13 Thread Marek Marczykowski-Górecki
On Mon, Jan 13, 2020 at 04:25:02PM -0500, Boris Ostrovsky wrote: > > > On 1/10/20 10:43 PM, Marek Marczykowski-Górecki wrote: > > @@ -117,6 +117,24 @@ static int command_write(struct pci_dev *dev, int > > offset, u16 value, void *data) > > pci_clear_mwi(dev); > > } > > + if

Re: [Xen-devel] [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation

2020-01-13 Thread Rafael J. Wysocki
On Mon, Jan 13, 2020 at 1:43 PM Peter Zijlstra wrote: > > On Mon, Jan 13, 2020 at 11:43:18AM +, Singh, Balbir wrote: > > For your original comment, just wanted to clarify the following: > > > > 1. After hibernation, the machine can be resumed on a different but > > compatible > > host (these

[Xen-devel] [qemu-mainline test] 146054: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146054 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146054/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [PATCH v4 6/7] Add guide on Communication Best Practice

2020-01-13 Thread George Dunlap
> On Dec 30, 2019, at 7:32 PM, Lars Kurth wrote: > > From: Lars Kurth > > This guide covers the bulk on Best Practice related to code review > It primarily focusses on code review interactions > It also covers how to deal with Misunderstandings and Cultural > Differences > > +### Avoid

Re: [Xen-devel] [PATCH] docs/misc: pvcalls: Verbatim block should be indented with 4 spaces

2020-01-13 Thread Andrew Cooper
On 13/01/2020 21:57, Julien Grall wrote: > At the moment, the diagram is only indented with 2 spaces. So pandoc > will try to badly interpret it and not display it correctly. > > Fix it by indenting all the block by 4 spaces (i.e an extra 2 spaces). > > Fixes: d661611d08 ("docs/markdown: Switch to

Re: [Xen-devel] Ping: [PATCH] x86/HVM: use single (atomic) MOV for aligned emulated writes

2020-01-13 Thread Jason Andryuk
On Fri, Dec 27, 2019 at 11:09 AM Andrew Cooper wrote: > > On 20/12/2019 16:23, Jan Beulich wrote: > > On 16.09.2019 11:40, Jan Beulich wrote: > >> Using memcpy() may result in multiple individual byte accesses > >> (dependening how memcpy() is implemented and how the resulting insns, > >> e.g.

Re: [Xen-devel] [PATCH v4 6/7] Add guide on Communication Best Practice

2020-01-13 Thread Lars Kurth
On 13/01/2020, 19:54, "George Dunlap" wrote: > On Dec 30, 2019, at 7:32 PM, Lars Kurth wrote: > > From: Lars Kurth > > This guide covers the bulk on Best Practice related to code review > It primarily focusses on code review interactions > It also covers

[Xen-devel] [ovmf test] 146051: regressions - trouble: broken/fail/pass

2020-01-13 Thread osstest service owner
flight 146051 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/146051/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 broken test-amd64-i386-xl-qemuu-ovmf-amd64 10

[Xen-devel] [ovmf test] 146056: regressions - trouble: broken/fail/pass

2020-01-13 Thread osstest service owner
flight 146056 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/146056/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 broken test-amd64-amd64-xl-qemuu-ovmf-amd64 4

[Xen-devel] [qemu-mainline test] 146057: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146057 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146057/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation

2020-01-13 Thread Rafael J. Wysocki
On Mon, Jan 13, 2020 at 10:50 PM Rafael J. Wysocki wrote: > > On Mon, Jan 13, 2020 at 1:43 PM Peter Zijlstra wrote: > > > > On Mon, Jan 13, 2020 at 11:43:18AM +, Singh, Balbir wrote: > > > For your original comment, just wanted to clarify the following: > > > > > > 1. After hibernation, the

[Xen-devel] [qemu-mainline test] 146055: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146055 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146055/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [PATCH] docs/misc: pvcalls: Verbatim block should be indented with 4 spaces

2020-01-13 Thread Stefano Stabellini
On Mon, 13 Jan 2020, Julien Grall wrote: > At the moment, the diagram is only indented with 2 spaces. So pandoc > will try to badly interpret it and not display it correctly. > > Fix it by indenting all the block by 4 spaces (i.e an extra 2 spaces). > > Fixes: d661611d08 ("docs/markdown: Switch

[Xen-devel] [xen-unstable test] 146050: tolerable FAIL - PUSHED

2020-01-13 Thread osstest service owner
flight 146050 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/146050/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 16 guest-start/debian.repeatfail like 146006 test-amd64-amd64-xl-rtds 16

[Xen-devel] [qemu-mainline test] 146060: regressions - FAIL

2020-01-13 Thread osstest service owner
flight 146060 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146060/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

  1   2   >