[libvirt test] 154374: regressions - FAIL

2020-09-16 Thread osstest service owner
flight 154374 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/154374/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

Re: [PATCH V1 11/16] xen/ioreq: Introduce hvm_domain_has_ioreq_server()

2020-09-16 Thread Julien Grall
On 16/09/2020 09:13, Paul Durrant wrote: -Original Message- From: Jan Beulich Sent: 16 September 2020 09:05 To: Oleksandr Tyshchenko ; Paul Durrant Cc: xen-devel@lists.xenproject.org; Oleksandr Tyshchenko ; Stefano Stabellini ; Julien Grall ; Volodymyr Babchuk ; Andrew Cooper ;

Re: [PATCH V1 10/16] xen/mm: Handle properly reference in set_foreign_p2m_entry() on Arm

2020-09-16 Thread Jan Beulich
On 10.09.2020 22:22, Oleksandr Tyshchenko wrote: > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -1155,6 +1155,7 @@ static int acquire_resource( > xen_pfn_t gfn_list[ARRAY_SIZE(mfn_list)]; > unsigned int i; > > +#ifndef CONFIG_ARM > /* > * FIXME:

[PATCH] mm: adjust get_page()'s types

2020-09-16 Thread Jan Beulich
The passed in domain doesn't get altered and hence can be const. While modifying its prototype anyway, also switch to bool. Signed-off-by: Jan Beulich --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1560,17 +1560,17 @@ void put_page(struct page_info *page) } } -int get_page(struct

[ovmf test] 154376: all pass - PUSHED

2020-09-16 Thread osstest service owner
flight 154376 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/154376/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7bcb021a6d54c5775c0fa1a3ea003b61f5c966ed baseline version: ovmf

Re: [PATCH V1 09/16] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2020-09-16 Thread Jan Beulich
On 10.09.2020 22:22, Oleksandr Tyshchenko wrote: > @@ -2277,8 +2299,10 @@ void leave_hypervisor_to_guest(void) > { > local_irq_disable(); > > -check_for_vcpu_work(); > -check_for_pcpu_work(); > +do > +{ > +check_for_pcpu_work(); > +} while (

Re: [PATCH V1 11/16] xen/ioreq: Introduce hvm_domain_has_ioreq_server()

2020-09-16 Thread Jan Beulich
On 10.09.2020 22:22, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch introduces a helper the main purpose of which is to check > if a domain is using IOREQ server(s). > > On Arm the benefit is to avoid calling handle_hvm_io_completion() > (which implies iterating over

Re: [PATCH V1 10/16] xen/mm: Handle properly reference in set_foreign_p2m_entry() on Arm

2020-09-16 Thread Jan Beulich
On 10.09.2020 22:22, Oleksandr Tyshchenko wrote: > --- a/xen/include/asm-x86/p2m.h > +++ b/xen/include/asm-x86/p2m.h > @@ -635,7 +635,8 @@ int p2m_is_logdirty_range(struct p2m_domain *, unsigned > long start, >unsigned long end); > > /* Set foreign entry in the p2m

RE: [PATCH V1 11/16] xen/ioreq: Introduce hvm_domain_has_ioreq_server()

2020-09-16 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 16 September 2020 09:05 > To: Oleksandr Tyshchenko ; Paul Durrant > Cc: xen-devel@lists.xenproject.org; Oleksandr Tyshchenko > ; Stefano > Stabellini ; Julien Grall ; Volodymyr > Babchuk > ; Andrew Cooper ; Wei > Liu ; Roger > Pau Monné

Re: [PATCH v4 3/4] efi: Enable booting unified hypervisor/kernel/initrd images

2020-09-16 Thread Trammell Hudson
On Wednesday, September 16, 2020 3:32 AM, Roger Pau Monné wrote: > On Mon, Sep 14, 2020 at 07:50:12AM -0400, Trammell Hudson wrote: > > - s2w(_string); > > Don't you need to check that s2w succeed, so that name_string.w is not > a random pointer from stack garbage? Maybe? I don't see anywhere

[PATCH] kernel/resource: make iomem_resource implicit in release_mem_region_adjustable()

2020-09-16 Thread David Hildenbrand
"mem" in the name already indicates the root, similar to release_mem_region() and devm_request_mem_region(). Make it implicit. The only single caller always passes iomem_resource, other parents are not applicable. Suggested-by: Wei Yang Cc: Andrew Morton Cc: Michal Hocko Cc: Dan Williams Cc:

Re: [PATCH] mm: adjust get_page()'s types

2020-09-16 Thread Julien Grall
Hi Jan, On 16/09/2020 08:28, Jan Beulich wrote: The passed in domain doesn't get altered and hence can be const. While modifying its prototype anyway, also switch to bool. Reviewed-by: Julien Grall Cheers, Signed-off-by: Jan Beulich --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@

Re: [PATCH v9 5/8] remove remaining uses of iommu_legacy_map/unmap

2020-09-16 Thread Julien Grall
Hi Paul, On 15/09/2020 09:29, Paul Durrant wrote: From: Paul Durrant The 'legacy' functions do implicit flushing so amend the callers to do the appropriate flushing. Unfortunately, because of the structure of the P2M code, we cannot remove the per-CPU 'iommu_dont_flush_iotlb' global and the

Re: [PATCH v9 6/8] common/grant_table: batch flush I/O TLB

2020-09-16 Thread Julien Grall
Hi Paul, On 15/09/2020 09:29, Paul Durrant wrote: From: Paul Durrant This patch avoids calling iommu_iotlb_flush() for each individual GNTTABOP and instead calls iommu_iotlb_flush_all() at the end of a batch. This should mean non-singleton map/unmap operations perform better. NOTE: A batch

Re: [PATCH] x86/mm: Simplify expression in set_gpfn_from_mfn()

2020-09-16 Thread Jan Beulich
On 15.09.2020 19:53, Andrew Cooper wrote: > Coverity points out that the "d &&" is redundant. How can it know that ... > --- a/xen/arch/x86/x86_64/mm.c > +++ b/xen/arch/x86/x86_64/mm.c > @@ -1336,7 +1336,7 @@ void set_gpfn_from_mfn(unsigned long mfn, unsigned long > pfn) > { >

Re: [PATCH v4 4/4] efi: Do not use command line if secure boot is enabled.

2020-09-16 Thread Jan Beulich
On 16.09.2020 10:50, Trammell Hudson wrote: > On Wednesday, September 16, 2020 3:45 AM, Roger Pau Monné > wrote: >> On Mon, Sep 14, 2020 at 07:50:13AM -0400, Trammell Hudson wrote: >>> If secure boot is enabled, the Xen command line arguments are ignored. >>> If a unified Xen image is used, then

Re: [PATCH] kernel/resource: make iomem_resource implicit in release_mem_region_adjustable()

2020-09-16 Thread Wei Yang
On Wed, Sep 16, 2020 at 09:30:41AM +0200, David Hildenbrand wrote: >"mem" in the name already indicates the root, similar to >release_mem_region() and devm_request_mem_region(). Make it implicit. >The only single caller always passes iomem_resource, other parents are >not applicable. > Looks good

Re: [PATCH v2 04/21] drm/exynos: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:41PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in exynos. The only exception is gem_prime_mmap, > which is

Re: [PATCH] kernel/resource: make iomem_resource implicit in release_mem_region_adjustable()

2020-09-16 Thread David Hildenbrand
On 16.09.20 12:02, Wei Yang wrote: > On Wed, Sep 16, 2020 at 09:30:41AM +0200, David Hildenbrand wrote: >> "mem" in the name already indicates the root, similar to >> release_mem_region() and devm_request_mem_region(). Make it implicit. >> The only single caller always passes iomem_resource, other

[xen-unstable-coverity test] 154380: all pass - PUSHED

2020-09-16 Thread osstest service owner
flight 154380 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/154380/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 51526576219f122ec7ccfd55dea95afbca70d330 baseline version: xen

Re: [PATCH v2 04/21] drm/exynos: Introduce GEM object functions

2020-09-16 Thread Thomas Zimmermann
Hi Am 16.09.20 um 12:03 schrieb Daniel Vetter: > On Tue, Sep 15, 2020 at 04:59:41PM +0200, Thomas Zimmermann wrote: >> GEM object functions deprecate several similar callback interfaces in >> struct drm_driver. This patch replaces the per-driver callbacks with >> per-instance callbacks in exynos.

Re: [PATCH V1 10/16] xen/mm: Handle properly reference in set_foreign_p2m_entry() on Arm

2020-09-16 Thread Julien Grall
Hi, On 16/09/2020 08:17, Jan Beulich wrote: On 10.09.2020 22:22, Oleksandr Tyshchenko wrote: --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1155,6 +1155,7 @@ static int acquire_resource( xen_pfn_t gfn_list[ARRAY_SIZE(mfn_list)]; unsigned int i; +#ifndef

Re: [PATCH V1 10/16] xen/mm: Handle properly reference in set_foreign_p2m_entry() on Arm

2020-09-16 Thread Jan Beulich
On 16.09.2020 10:50, Julien Grall wrote: > On 16/09/2020 08:17, Jan Beulich wrote: >> On 10.09.2020 22:22, Oleksandr Tyshchenko wrote: >>> for ( i = 0; !rc && i < xmar.nr_frames; i++ ) >>> { >>> -rc = set_foreign_p2m_entry(currd, gfn_list[i], >>> +rc =

Re: [PATCH V1 14/16] xen/ioreq: Use guest_cmpxchg64() instead of cmpxchg()

2020-09-16 Thread Julien Grall
On 16/09/2020 10:09, Paul Durrant wrote: -Original Message- From: Julien Grall Sent: 16 September 2020 10:07 To: Jan Beulich ; Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org; Oleksandr Tyshchenko ; Paul Durrant ; Stefano Stabellini ; Julien Grall Subject: Re: [PATCH V1

[ovmf test] 154378: all pass - PUSHED

2020-09-16 Thread osstest service owner
flight 154378 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/154378/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8028b2907e20b21cd7d69639a36ac82a77c81dc1 baseline version: ovmf

Re: [PATCH v4 3/4] efi: Enable booting unified hypervisor/kernel/initrd images

2020-09-16 Thread Jan Beulich
On 16.09.2020 10:37, Trammell Hudson wrote: > On Wednesday, September 16, 2020 3:32 AM, Roger Pau Monné > wrote: >> On Mon, Sep 14, 2020 at 07:50:12AM -0400, Trammell Hudson wrote: >>> - s2w(_string); >> >> Don't you need to check that s2w succeed, so that name_string.w is not >> a random

RE: [PATCH V1 11/16] xen/ioreq: Introduce hvm_domain_has_ioreq_server()

2020-09-16 Thread Paul Durrant
> -Original Message- > From: Julien Grall > Sent: 16 September 2020 09:39 > To: p...@xen.org; 'Jan Beulich' ; 'Oleksandr Tyshchenko' > > Cc: xen-devel@lists.xenproject.org; 'Oleksandr Tyshchenko' > ; 'Stefano > Stabellini' ; 'Volodymyr Babchuk' > ; 'Andrew > Cooper' ; 'Wei Liu' ;

Re: [PATCH V1 13/16] xen/ioreq: Make x86's invalidate qemu mapcache handling common

2020-09-16 Thread Jan Beulich
On 10.09.2020 22:22, Oleksandr Tyshchenko wrote: > --- a/xen/arch/arm/traps.c > +++ b/xen/arch/arm/traps.c > @@ -1490,6 +1490,12 @@ static void do_trap_hypercall(struct cpu_user_regs > *regs, register_t *nr, > /* Ensure the hypercall trap instruction is re-executed. */ > if (

Re: [PATCH v4 4/4] efi: Do not use command line if secure boot is enabled.

2020-09-16 Thread Trammell Hudson
On Wednesday, September 16, 2020 3:45 AM, Roger Pau Monné wrote: > On Mon, Sep 14, 2020 at 07:50:13AM -0400, Trammell Hudson wrote: > > If secure boot is enabled, the Xen command line arguments are ignored. > > If a unified Xen image is used, then the bundled configuration, dom0 > > kernel, and

Re: [PATCH V1 10/16] xen/mm: Handle properly reference in set_foreign_p2m_entry() on Arm

2020-09-16 Thread Julien Grall
On 16/09/2020 09:52, Jan Beulich wrote: On 16.09.2020 10:50, Julien Grall wrote: On 16/09/2020 08:17, Jan Beulich wrote: On 10.09.2020 22:22, Oleksandr Tyshchenko wrote: for ( i = 0; !rc && i < xmar.nr_frames; i++ ) { -rc = set_foreign_p2m_entry(currd,

Re: [PATCH V1 14/16] xen/ioreq: Use guest_cmpxchg64() instead of cmpxchg()

2020-09-16 Thread Jan Beulich
On 10.09.2020 22:22, Oleksandr Tyshchenko wrote: > @@ -1325,7 +1327,7 @@ static int hvm_send_buffered_ioreq(struct > hvm_ioreq_server *s, ioreq_t *p) > > new.read_pointer = old.read_pointer - n * IOREQ_BUFFER_SLOT_NUM; > new.write_pointer = old.write_pointer - n *

RE: [PATCH V1 14/16] xen/ioreq: Use guest_cmpxchg64() instead of cmpxchg()

2020-09-16 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 16 September 2020 10:04 > To: Oleksandr Tyshchenko > Cc: xen-devel@lists.xenproject.org; Oleksandr Tyshchenko > ; Paul Durrant > ; Julien Grall ; Stefano Stabellini > ; Julien > Grall > Subject: Re: [PATCH V1 14/16] xen/ioreq: Use

Re: [PATCH V1 14/16] xen/ioreq: Use guest_cmpxchg64() instead of cmpxchg()

2020-09-16 Thread Julien Grall
On 16/09/2020 10:04, Jan Beulich wrote: On 10.09.2020 22:22, Oleksandr Tyshchenko wrote: @@ -1325,7 +1327,7 @@ static int hvm_send_buffered_ioreq(struct hvm_ioreq_server *s, ioreq_t *p) new.read_pointer = old.read_pointer - n * IOREQ_BUFFER_SLOT_NUM;

RE: [PATCH V1 14/16] xen/ioreq: Use guest_cmpxchg64() instead of cmpxchg()

2020-09-16 Thread Paul Durrant
> -Original Message- > From: Julien Grall > Sent: 16 September 2020 10:07 > To: Jan Beulich ; Oleksandr Tyshchenko > > Cc: xen-devel@lists.xenproject.org; Oleksandr Tyshchenko > ; Paul Durrant > ; Stefano Stabellini ; Julien Grall > > Subject: Re: [PATCH V1 14/16] xen/ioreq: Use

[PATCH 0/5] Multicore support for ARINC653 scheduler

2020-09-16 Thread Jeff Kubascik
This patch set adds multicore capability to the ARINC653 scheduler, based on the guidance presented in the CAST-32A position paper. This approach only allows for a single domain to run at any given time, but that domain is now able to use multiple vCPUs running across the available pCPUs. There

[PATCH 3/5] sched/arinc653: Clean up function definitions

2020-09-16 Thread Jeff Kubascik
Function definitions in the arinc653 module did not follow the Xen coding style. Furthermore, a few function names used a different prefix. This change cleans up the definitions to be consistent with the Xen coding style, and has no functional changes. Signed-off-by: Jeff Kubascik ---

Re: [PATCH v4 1/4] efi/boot.c: add file.need_to_free

2020-09-16 Thread Roger Pau Monné
On Mon, Sep 14, 2020 at 07:50:10AM -0400, Trammell Hudson wrote: > The config file, kernel, initrd, etc should only be freed if they > are allocated with the UEFI allocator. > > Signed-off-by: Trammell Hudson Reviewed-by: Roger Pau Monné > --- > xen/common/efi/boot.c | 10 ++ > 1

[linux-linus test] 154371: regressions - FAIL

2020-09-16 Thread osstest service owner
flight 154371 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/154371/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332

Re: [PATCH v4 2/4] efi/boot.c: add handle_file_info()

2020-09-16 Thread Roger Pau Monné
On Mon, Sep 14, 2020 at 07:50:11AM -0400, Trammell Hudson wrote: > Add a separate function to display the address ranges used by > the files and call `efi_arch_handle_module()` on the modules. > > Signed-off-by: Trammell Hudson Reviewed-by: Roger Pau Monné Thanks!

Re: [PATCH v2 03/21] drm/etnaviv: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:40PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in etnaviv. The only exception is gem_prime_mmap, > which is

Re: [PATCH v2 04/21] drm/exynos: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Wed, Sep 16, 2020 at 12:36:28PM +0200, Thomas Zimmermann wrote: > Hi > > Am 16.09.20 um 12:03 schrieb Daniel Vetter: > > On Tue, Sep 15, 2020 at 04:59:41PM +0200, Thomas Zimmermann wrote: > >> GEM object functions deprecate several similar callback interfaces in > >> struct drm_driver. This

Re: [PATCH v2 05/21] drm/gma500: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:42PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in gma500. > > Signed-off-by: Thomas Zimmermann Reviewed-by:

Re: [PATCH v4 3/4] efi: Enable booting unified hypervisor/kernel/initrd images

2020-09-16 Thread Roger Pau Monné
On Mon, Sep 14, 2020 at 07:50:12AM -0400, Trammell Hudson wrote: > This patch adds support for bundling the xen.efi hypervisor, the xen.cfg > configuration file, the Linux kernel and initrd, as well as the XSM, > and architectural specific files into a single "unified" EFI executable. > This

Re: [PATCH v2 07/21] drm/mediatek: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:44PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in mediatek. The only exception is gem_prime_mmap, > which is

Re: [PATCH v4 4/4] efi: Do not use command line if secure boot is enabled.

2020-09-16 Thread Roger Pau Monné
On Mon, Sep 14, 2020 at 07:50:13AM -0400, Trammell Hudson wrote: > If secure boot is enabled, the Xen command line arguments are ignored. > If a unified Xen image is used, then the bundled configuration, dom0 > kernel, and initrd are prefered over the ones listed in the config file. I understand

Re: [PATCH v2 08/21] drm/msm: Introduce GEM object funcs

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:45PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in msm. The only exception is gem_prime_mmap, > which is

Re: [PATCH v4 5/8] mm/memory_hotplug: MEMHP_MERGE_RESOURCE to specify merging of System RAM resources

2020-09-16 Thread Wei Yang
On Fri, Sep 11, 2020 at 12:34:56PM +0200, David Hildenbrand wrote: >Some add_memory*() users add memory in small, contiguous memory blocks. >Examples include virtio-mem, hyper-v balloon, and the XEN balloon. > >This can quickly result in a lot of memory resources, whereby the actual >resource

Re: [PATCH v4 3/4] efi: Enable booting unified hypervisor/kernel/initrd images

2020-09-16 Thread Roger Pau Monné
On Wed, Sep 16, 2020 at 08:37:44AM +, Trammell Hudson wrote: > On Wednesday, September 16, 2020 3:32 AM, Roger Pau Monné > wrote: > > On Mon, Sep 14, 2020 at 07:50:12AM -0400, Trammell Hudson wrote: > > > - s2w(_string); > > > > Don't you need to check that s2w succeed, so that

[PATCH v4] EFI: free unused boot mem in at least some cases

2020-09-16 Thread Jan Beulich
Address at least the primary reason why 52bba67f8b87 ("efi/boot: Don't free ebmalloc area at all") was put in place: Make xen_in_range() aware of the freed range. This is in particular relevant for EFI-enabled builds not actually running on EFI, as the entire range will be unused in this case.

Re: [PATCH] kernel/resource: make iomem_resource implicit in release_mem_region_adjustable()

2020-09-16 Thread Wei Yang
On Wed, Sep 16, 2020 at 02:16:25PM +0200, David Hildenbrand wrote: >On 16.09.20 14:10, Wei Yang wrote: >> On Wed, Sep 16, 2020 at 12:03:20PM +0200, David Hildenbrand wrote: >>> On 16.09.20 12:02, Wei Yang wrote: On Wed, Sep 16, 2020 at 09:30:41AM +0200, David Hildenbrand wrote: > "mem" in

Re: [PATCH] x86/svm: ignore accesses to EX_CFG

2020-09-16 Thread Jan Beulich
On 16.09.2020 15:04, Roger Pau Monné wrote: > On Wed, Sep 16, 2020 at 02:55:52PM +0200, Jan Beulich wrote: >> On 16.09.2020 12:54, Roger Pau Monne wrote: >>> Windows 10 will try to unconditionally read EX_CFG on AMD hadrware, >>> and injecting a #GP fault will result in a panic: >>> >>>

Re: [PATCH] mm: adjust get_page()'s types

2020-09-16 Thread Roger Pau Monné
On Wed, Sep 16, 2020 at 09:28:47AM +0200, Jan Beulich wrote: > The passed in domain doesn't get altered and hence can be const. While > modifying its prototype anyway, also switch to bool. > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH] kernel/resource: make iomem_resource implicit in release_mem_region_adjustable()

2020-09-16 Thread Wei Yang
On Wed, Sep 16, 2020 at 12:03:20PM +0200, David Hildenbrand wrote: >On 16.09.20 12:02, Wei Yang wrote: >> On Wed, Sep 16, 2020 at 09:30:41AM +0200, David Hildenbrand wrote: >>> "mem" in the name already indicates the root, similar to >>> release_mem_region() and devm_request_mem_region(). Make it

[PATCH v2 0/4] x86: shim building adjustments (plus shadow follow-on)

2020-09-16 Thread Jan Beulich
The first change is simply addressing a build issue noticed by Andrew. The build breakage goes beyond this specific combination though - PV_SHIM_EXCLUSIVE plus HVM is similarly an issue. This is what the last patch tries to take care of, in a shape already on irc noticed to be controversial. I'm

Re: [PATCH v2 09/21] drm/nouveau: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:46PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in nouveau. > > Signed-off-by: Thomas Zimmermann Hm ttm and

Re: [PATCH] x86/svm: ignore accesses to EX_CFG

2020-09-16 Thread Jan Beulich
On 16.09.2020 12:54, Roger Pau Monne wrote: > Windows 10 will try to unconditionally read EX_CFG on AMD hadrware, > and injecting a #GP fault will result in a panic: > > svm.c:1964:d5v0 RDMSR 0xc001102c unimplemented > d5v0 VIRIDIAN CRASH: 7e c096 f8054cbe5ffe fa0837a066e8 >

Re: [PATCH v2 21/21] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:58PM +0200, Thomas Zimmermann wrote: > Several GEM and PRIME callbacks have been deprecated in favor of > per-instance GEM object functions. Remove the callbacks as they are > now unused. The only exception is .gem_prime_mmap, which is still > in use by several

Re: Compiling Xen from source

2020-09-16 Thread David I
Hello, thanks for your infos. it appears the compilation process is not really straightforward. I had to patch some header files. then some of the firmwares were bugged. So I disabled some various checks in the firmwares Makefiles. I ended up with a: "no target for make all": configure passed

Re: [PATCH v2 17/21] drm/virtgpu: Set PRIME export function in struct drm_gem_object_funcs

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:54PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces virtgpu's per-driver PRIME export > function with a per-object function. > > Signed-off-by: Thomas Zimmermann

[xen-unstable-smoke test] 154381: tolerable all pass - PUSHED

2020-09-16 Thread osstest service owner
flight 154381 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/154381/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v4 7/8] xen/balloon: try to merge system ram resources

2020-09-16 Thread Wei Yang
On Fri, Sep 11, 2020 at 12:34:58PM +0200, David Hildenbrand wrote: >Let's try to merge system ram resources we add, to minimize the number >of resources in /proc/iomem. We don't care about the boundaries of >individual chunks we added. > >Reviewed-by: Juergen Gross >Cc: Andrew Morton >Cc: Michal

Re: [PATCH v4 8/8] hv_balloon: try to merge system ram resources

2020-09-16 Thread Wei Yang
On Fri, Sep 11, 2020 at 12:34:59PM +0200, David Hildenbrand wrote: >Let's try to merge system ram resources we add, to minimize the number >of resources in /proc/iomem. We don't care about the boundaries of >individual chunks we added. > >Reviewed-by: Wei Liu >Cc: Andrew Morton >Cc: Michal Hocko

Re: [PATCH v4 6/8] virtio-mem: try to merge system ram resources

2020-09-16 Thread Wei Yang
On Fri, Sep 11, 2020 at 12:34:57PM +0200, David Hildenbrand wrote: >virtio-mem adds memory in memory block granularity, to be able to >remove it in the same granularity again later, and to grow slowly on >demand. This, however, results in quite a lot of resources when >adding a lot of memory.

Re: Compiling Xen from source

2020-09-16 Thread David I
Examples of compile bugs for xen-stable-4.11 for make dist-tools: "include/ipxe/uri.h:178:12: error: taking address of packed member of ‘struct uri’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 178 | ref_get ( >refcnt );" -> fixed by adding the Cflag

[PATCH] x86/svm: ignore accesses to EX_CFG

2020-09-16 Thread Roger Pau Monne
Windows 10 will try to unconditionally read EX_CFG on AMD hadrware, and injecting a #GP fault will result in a panic: svm.c:1964:d5v0 RDMSR 0xc001102c unimplemented d5v0 VIRIDIAN CRASH: 7e c096 f8054cbe5ffe fa0837a066e8 fa0837a05f30 Return 0 when trying to read the MSR

Re: [PATCH] kernel/resource: make iomem_resource implicit in release_mem_region_adjustable()

2020-09-16 Thread David Hildenbrand
On 16.09.20 14:10, Wei Yang wrote: > On Wed, Sep 16, 2020 at 12:03:20PM +0200, David Hildenbrand wrote: >> On 16.09.20 12:02, Wei Yang wrote: >>> On Wed, Sep 16, 2020 at 09:30:41AM +0200, David Hildenbrand wrote: "mem" in the name already indicates the root, similar to

RE: [PATCH v8 1/8] x86/iommu: convert VT-d code to use new page table allocator

2020-09-16 Thread Durrant, Paul
Kevin, ping? This patch hasn't changed since v2. Paul > -Original Message- > From: Paul Durrant > Sent: 11 September 2020 09:20 > To: xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Jan Beulich ; > Kevin Tian > > Subject: [PATCH v8 1/8] x86/iommu: convert VT-d code to use new

[PATCH v2 2/4] x86/shim: adjust Kconfig defaults

2020-09-16 Thread Jan Beulich
Just like HVM, defaulting SHADOW_PAGING and TBOOT to Yes in shim- exclusive mode makes no sense, as the respective code is dead there. Also adjust the shim default config file: It needs to specifiy values only for settings where a non-default value is wanted. Signed-off-by: Jan Beulich

[PATCH v2 3/4] x86/shim: don't permit HVM and PV_SHIM_EXCLUSIVE at the same time

2020-09-16 Thread Jan Beulich
This combination doesn't really make sense (and there likely are more); in particular even if the code built with both options set, HVM guests wouldn't work (and I think one wouldn't be able to create one in the first place). The alternative here would be some presumably intrusive #ifdef-ary to

[PATCH v2 1/4] x86/shim: fix build with PV_SHIM_EXCLUSIVE and SHADOW_PAGING

2020-09-16 Thread Jan Beulich
While there's little point in enabling both, the combination ought to at least build correctly. Drop the direct PV_SHIM_EXCLUSIVE conditionals and instead zap PG_log_dirty to zero under the right conditions, and key other #ifdef-s off of that. While there also expand on ded576ce07e9 ("x86/shadow:

[PATCH v2 4/4] x86/shadow: refactor shadow_vram_{get,put}_l1e()

2020-09-16 Thread Jan Beulich
By passing the functions an MFN and flags, only a single instance of each is needed; they were pretty large for being inline functions anyway. While moving the code, also adjust coding style and add const where sensible / possible. Signed-off-by: Jan Beulich --- v2: New. ---

Re: [PATCH] tools: Delete XEN_DOMCTL_disable_migrate

2020-09-16 Thread Ian Jackson
Andrew Cooper writes ("[PATCH] tools: Delete XEN_DOMCTL_disable_migrate"): > It is conceptually wrong for this information to exist in the hypervisor in > the first place. Only the toolstack is capable of correctly reasoning about > the non-migrateability of guests. > > This hypercall has only

Re: [PATCH v2 13/21] drm/rockchip: Convert to drm_gem_object_funcs

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:50PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in rockchip. The only exception is gem_prime_mmap, > which is

Re: [PATCH v8 6/8] common/domain: add a domain context record for shared_info...

2020-09-16 Thread Jan Beulich
On 15.09.2020 18:17, Paul Durrant wrote: > +static int load_shared_info(struct domain *d, struct domain_context *c) > +{ > +struct domain_shared_info_context ctxt; > +size_t hdr_size = offsetof(typeof(ctxt), buffer); > +unsigned int i; > +int rc; > + > +rc =

[PATCH RFC 3/4] mm/page_alloc: always move pages to the tail of the freelist in unset_migratetype_isolate()

2020-09-16 Thread David Hildenbrand
Page isolation doesn't actually touch the pages, it simply isolates pageblocks and moves all free pages to the MIGRATE_ISOLATE freelist. We already place pages to the tail of the freelists when undoing isolation via __putback_isolated_page(), let's do it in any case (e.g., if order ==

[PATCH RFC 2/4] mm/page_alloc: place pages to tail in __putback_isolated_page()

2020-09-16 Thread David Hildenbrand
__putback_isolated_page() already documents that pages will be placed to the tail of the freelist - this is, however, not the case for "order >= MAX_ORDER - 2" (see buddy_merge_likely()) - which should be the case for all existing users. This change affects two users: - free page reporting - page

[PATCH RFC 4/4] mm/page_alloc: place pages to tail in __free_pages_core()

2020-09-16 Thread David Hildenbrand
__free_pages_core() is used when exposing fresh memory to the buddy during system boot and when onlining memory in generic_online_page(). generic_online_page() is used in two cases: 1. Direct memory onlining in online_pages(). 2. Deferred memory onlining in memory-ballooning-like mechanisms

[PATCH RFC 0/4] mm: place pages to the freelist tail when onling and undoing isolation

2020-09-16 Thread David Hildenbrand
When adding separate memory blocks via add_memory*() and onlining them immediately, the metadata (especially the memmap) of the next block will be placed onto one of the just added+onlined block. This creates a chain of unmovable allocations: If the last memory block cannot get offlined+removed()

[PATCH RFC 1/4] mm/page_alloc: convert "report" flag of __free_one_page() to a proper flag

2020-09-16 Thread David Hildenbrand
Let's prepare for additional flags and avoid long parameter lists of bools. Follow-up patches will also make use of the flags in __free_pages_ok(), however, I wasn't able to come up with a better name for the type - should be good enough for internal purposes. Cc: Andrew Morton Cc: Alexander

Re: [PATCH RFC 0/4] mm: place pages to the freelist tail when onling and undoing isolation

2020-09-16 Thread osalvador
On 2020-09-16 20:34, David Hildenbrand wrote: When adding separate memory blocks via add_memory*() and onlining them immediately, the metadata (especially the memmap) of the next block will be placed onto one of the just added+onlined block. This creates a chain of unmovable allocations: If

[linux-linus test] 154386: regressions - FAIL

2020-09-16 Thread osstest service owner
flight 154386 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/154386/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332

Re: [PATCH] x86/svm: ignore accesses to EX_CFG

2020-09-16 Thread Roger Pau Monné
On Wed, Sep 16, 2020 at 03:28:28PM +0200, Jan Beulich wrote: > On 16.09.2020 15:04, Roger Pau Monné wrote: > > On Wed, Sep 16, 2020 at 02:55:52PM +0200, Jan Beulich wrote: > >> On 16.09.2020 12:54, Roger Pau Monne wrote: > >>> Windows 10 will try to unconditionally read EX_CFG on AMD hadrware, >

Re: Compiling Xen from source

2020-09-16 Thread Olaf Hering
On Wed, Sep 16, David I wrote: > So, how did the debian package was compiled ? is this the same source code > with > different options ? Xen 4.11 is from 2018. Use also a compiler from that year. Using this years compiler will lead to errors... Olaf signature.asc Description: PGP signature

Re: [PATCH v2 21/21] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver

2020-09-16 Thread Thomas Zimmermann
Am 15.09.20 um 16:59 schrieb Thomas Zimmermann: > Several GEM and PRIME callbacks have been deprecated in favor of > per-instance GEM object functions. Remove the callbacks as they are > now unused. The only exception is .gem_prime_mmap, which is still > in use by several drivers. > > What is

Re: [PATCH-for-5.2] hw/i386/q35: Remove unreachable Xen code on Q35 machine

2020-09-16 Thread Paolo Bonzini
On 22/07/20 10:25, Philippe Mathieu-Daudé wrote: > Xen accelerator requires specific changes to a machine to be able > to use it. See for example the 'Xen PC' machine configure its PCI > bus calling pc_xen_hvm_init_pci(). There is no 'Xen Q35' machine > declared. This code was probably added while

Re: [PATCH] x86/svm: ignore accesses to EX_CFG

2020-09-16 Thread Roger Pau Monné
On Wed, Sep 16, 2020 at 02:55:52PM +0200, Jan Beulich wrote: > On 16.09.2020 12:54, Roger Pau Monne wrote: > > Windows 10 will try to unconditionally read EX_CFG on AMD hadrware, > > and injecting a #GP fault will result in a panic: > > > > svm.c:1964:d5v0 RDMSR 0xc001102c unimplemented > > d5v0

DT with memory bank of size 0 (WAS: Re: AW: AW: Colibri imx8qxp: Missing kernel boot module)

2020-09-16 Thread Julien Grall
On 14/09/2020 15:26, Daniel Wagner2 wrote: Hi Julien, Hi Daniel, I am moving the thread to xen-devel and adding a couple of more folks. this is the full version of the fdt that threw the error: https://pastebin.com/63TZ9z3k The problematic memory node appears in line 126 Thanks! The

[xen-unstable bisection] complete test-armhf-armhf-libvirt-raw

2020-09-16 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-armhf-armhf-libvirt-raw testid guest-start Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware

Re: [PATCH] SUPPORT.md: Mark Renesas IPMMU-VMSA (Arm) as supported

2020-09-16 Thread Julien Grall
Hi Oleksandr, On 14/09/2020 20:37, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko And remove dependencies on CONFIG_EXPERT. In order to help to make the decision, can you provide the following information: - Is it functionally complete? - Can it work on all known platforms

[PATCH 4/5] [automated] Use OBJECT_DECLARE_TYPE when possible

2020-09-16 Thread Eduardo Habkost
This converts existing DECLARE_OBJ_CHECKERS usage to OBJECT_DECLARE_TYPE when possible. $ ./scripts/codeconverter/converter.py -i \ --pattern=AddObjectDeclareType $(git grep -l '' -- '*.[ch]') Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: Andrzej Zaborowski Cc: Alistair Francis

[PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros

2020-09-16 Thread Eduardo Habkost
One of the goals of having less boilerplate on QOM declarations is to avoid human error. Requiring an extra argument that is never used is an opportunity for mistakes. Remove the unused argument from OBJECT_DECLARE_TYPE and OBJECT_DECLARE_SIMPLE_TYPE. Coccinelle patch used to convert all users

Re: [PATCH RFC 0/4] mm: place pages to the freelist tail when onling and undoing isolation

2020-09-16 Thread David Hildenbrand
> Am 16.09.2020 um 20:50 schrieb osalva...@suse.de: > > On 2020-09-16 20:34, David Hildenbrand wrote: >> When adding separate memory blocks via add_memory*() and onlining them >> immediately, the metadata (especially the memmap) of the next block will be >> placed onto one of the just

Re: [PATCH RFC 1/4] mm/page_alloc: convert "report" flag of __free_one_page() to a proper flag

2020-09-16 Thread Alexander Duyck
On Wed, Sep 16, 2020 at 11:34 AM David Hildenbrand wrote: > > Let's prepare for additional flags and avoid long parameter lists of bools. > Follow-up patches will also make use of the flags in __free_pages_ok(), > however, I wasn't able to come up with a better name for the type - should > be

Re: DT with memory bank of size 0 (WAS: Re: AW: AW: Colibri imx8qxp: Missing kernel boot module)

2020-09-16 Thread Stefano Stabellini
On Wed, 16 Sep 2020, Julien Grall wrote: > On 14/09/2020 15:26, Daniel Wagner2 wrote: > > Hi Julien, > > Hi Daniel, > > I am moving the thread to xen-devel and adding a couple of more folks. > > > > > > > > > > > > this is the full version of the fdt that threw the error: > > > >

Re: Compiling Xen from source

2020-09-16 Thread Hans van Kranenburg
On 9/16/20 6:12 PM, Olaf Hering wrote: > On Wed, Sep 16, David I wrote: > >> So, how did the debian package was compiled ? is this the same source code >> with >> different options ? > > Xen 4.11 is from 2018. Use also a compiler from that year. > Using this years compiler will lead to

Re: [PATCH] SUPPORT.md: Mark Renesas IPMMU-VMSA (Arm) as supported

2020-09-16 Thread Stefano Stabellini
On Thu, 17 Sep 2020, Oleksandr Tyshchenko wrote: > On Wed, Sep 16, 2020 at 8:02 PM Julien Grall wrote: > Hi Oleksandr, > > > Hi Julien > > [sorry for the possible format issues] >   > > On 14/09/2020 20:37, Oleksandr Tyshchenko wrote: > > From: Oleksandr Tyshchenko >

Re: [PATCH] SUPPORT.md: Mark Renesas IPMMU-VMSA (Arm) as supported

2020-09-16 Thread Stefano Stabellini
On Wed, 16 Sep 2020, Julien Grall wrote: > Hi Oleksandr, > > On 14/09/2020 20:37, Oleksandr Tyshchenko wrote: > > From: Oleksandr Tyshchenko > > > > And remove dependencies on CONFIG_EXPERT. > > In order to help to make the decision, can you provide the following > information: >- Is it

Re: [PATCH] SUPPORT.md: Mark Renesas IPMMU-VMSA (Arm) as supported

2020-09-16 Thread Oleksandr Tyshchenko
On Wed, Sep 16, 2020 at 8:02 PM Julien Grall wrote: > Hi Oleksandr, > Hi Julien [sorry for the possible format issues] > > On 14/09/2020 20:37, Oleksandr Tyshchenko wrote: > > From: Oleksandr Tyshchenko > > > > And remove dependencies on CONFIG_EXPERT. > > In order to help to make the

Re: [PATCH RFC 2/4] mm/page_alloc: place pages to tail in __putback_isolated_page()

2020-09-16 Thread Alexander Duyck
On Wed, Sep 16, 2020 at 11:34 AM David Hildenbrand wrote: > > __putback_isolated_page() already documents that pages will be placed to > the tail of the freelist - this is, however, not the case for > "order >= MAX_ORDER - 2" (see buddy_merge_likely()) - which should be > the case for all

[linux-linus test] 154399: regressions - FAIL

2020-09-16 Thread osstest service owner
flight 154399 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/154399/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332

  1   2   >