Re: [PATCH v4 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

On Fri, Apr 29, 2022 at 05:49:42PM +0200, Roger Pau Monné wrote: > On Fri, Apr 29, 2022 at 12:59:58PM +0200, Jan Beulich wrote: > > On 27.04.2022 12:47, Roger Pau Monne wrote:> Changes since v3:> - Align > > ssbd per-core struct to a cache line.> - Open code a simple spinlock to > > avoid

Re: [xen-unstable-smoke test] 169781: regressions - FAIL

On 29/04/2022 17:15, Stefano Stabellini wrote: Which seems to be the right sequence to me. There must be an early boot phase where interrupts are disabled on a CPU but memory allocations are possible. If this was x86 with the tlbflush limitation, I would suggest to have per-cpu memory mapping

[ovmf test] 169873: regressions - FAIL

flight 169873 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169873/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[xen-unstable bisection] complete test-arm64-arm64-libvirt-raw

branch xen-unstable xenbranch xen-unstable job test-arm64-arm64-libvirt-raw testid xen-boot Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware

Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list

On 29/04/2022 14:30, Michael Kelley (LINUX) wrote: > From: Guilherme G. Piccoli Sent: Wednesday, April 27, > 2022 3:49 PM >> [...] >> >> @@ -2843,7 +2843,7 @@ static void __exit vmbus_exit(void) >> if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE) { >>

Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

On Wed, Apr 27, 2022 at 3:55 PM Guilherme G. Piccoli wrote: > > This patch renames the panic_notifier_list to panic_pre_reboot_list; > the idea is that a subsequent patch will refactor the panic path > in order to better split the notifiers, running some of them very > early, some of them not so

Re: [PATCH 24/30] panic: Refactor the panic path

On 27/04/2022 21:28, Randy Dunlap wrote: > > > On 4/27/22 15:49, Guilherme G. Piccoli wrote: >> +crash_kexec_post_notifiers >> +This was DEPRECATED - users should always prefer the > > This is DEPRECATED - users should always prefer the > >> +

RE: [PATCH 16/30] drivers/hv/vmbus, video/hyperv_fb: Untangle and refactor Hyper-V panic notifiers

From: Guilherme G. Piccoli Sent: Wednesday, April 27, 2022 3:49 PM > > Currently Hyper-V guests are among the most relevant users of the panic > infrastructure, like panic notifiers, kmsg dumpers, etc. The reasons rely > both in cleaning-up procedures (closing a hypervisor <-> guest connection,

[ovmf test] 169874: regressions - FAIL

flight 169874 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169874/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

RE: [PATCH 24/30] panic: Refactor the panic path

From: Guilherme G. Piccoli Sent: Wednesday, April 27, 2022 3:49 PM > > The panic() function is somewhat convoluted - a lot of changes were > made over the years, adding comments that might be misleading/outdated > now, it has a code structure that is a bit complex to follow, with > lots of

Re: [PATCH v2 18/19] xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring()

On 28.04.22 11:27, Juergen Gross wrote: Hello Juergen, all Simplify sndfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross I am not familiar with SOUND bits of this driver, but a little bit familiar with Xen bits this patch

Re: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs shutdown path

On Fri, 29 Apr 2022 22:45:14 +0100, "Russell King (Oracle)" wrote: > > On Fri, Apr 29, 2022 at 06:38:19PM -0300, Guilherme G. Piccoli wrote: > > Thanks Marc and Michael for the review/discussion. > > > > On 29/04/2022 15:20, Marc Zyngier wrote: > > > [...] > > > > > My expectations would be

Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm

On Fri, 29 Apr 2022, Boris Ostrovsky wrote: > On 4/28/22 6:49 PM, Stefano Stabellini wrote: > > On Thu, 28 Apr 2022, Boris Ostrovsky wrote: > > > On 4/28/22 5:49 PM, Stefano Stabellini wrote: > > > > On Thu, 28 Apr 2022, Christoph Hellwig wrote: > > > > > On Tue, Apr 26, 2022 at 04:07:45PM -0700,

Re: [PATCH 1/2] tools/xl: Sort create command options

On Fri, Apr 29, 2022 at 10:39:27AM +0100, Anthony PERARD wrote: > On Tue, Apr 19, 2022 at 06:56:03PM -0700, Elliott Mitchell wrote: > > Hopefully simplify future changes by sorting options lists for > > `xl create`. > > I'm not sure that sorting options make changes easier, as it would mean > one

[ovmf test] 169885: regressions - FAIL

flight 169885 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169885/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs shutdown path

Thanks Marc and Michael for the review/discussion. On 29/04/2022 15:20, Marc Zyngier wrote: > [...] > My expectations would be that, since we're getting here using an IPI, > interrupts are already masked. So what reenabled them the first place? > > Thanks, > > M. > Marc, I did some

Re: [PATCH v2 0/4] xen/pv-scsi: update header and harden frontend

On 4/28/22 3:53 AM, Juergen Gross wrote: Update the Xen PV-scsi interface from the Xen tree and adapt the related drivers to use the new definitions. Harden the frontend driver to be no longer vulnerable to a malicious backend. Juergen Gross (4): xen: update vscsiif.h xen/scsiback: use

Re: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs shutdown path

On 29/04/2022 18:45, Russell King (Oracle) wrote: > [...] >> Marc, I did some investigation in the code (and tried/failed in the ARM >> documentation as well heh), but this is still not 100% clear for me. >> >> You're saying IPI calls disable IRQs/FIQs by default in the the target >> CPUs? Where

Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm

On 4/28/22 6:49 PM, Stefano Stabellini wrote: On Thu, 28 Apr 2022, Boris Ostrovsky wrote: On 4/28/22 5:49 PM, Stefano Stabellini wrote: On Thu, 28 Apr 2022, Christoph Hellwig wrote: On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote: Reported-by: Rahul Singh Signed-off-by:

[ovmf test] 169889: regressions - FAIL

flight 169889 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169889/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [LINUX PATCH v3] xen: add support for initializing xenstore later as HVM domain

On 4/29/22 5:10 PM, Stefano Stabellini wrote: From: Luca Miccio When running as dom0less guest (HVM domain on ARM) the xenstore event channel is available at domain creation but the shared xenstore interface page only becomes available later on. In that case, wait for a notification on the

[ovmf test] 169883: regressions - FAIL

flight 169883 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169883/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[LINUX PATCH v3] xen: add support for initializing xenstore later as HVM domain

From: Luca Miccio When running as dom0less guest (HVM domain on ARM) the xenstore event channel is available at domain creation but the shared xenstore interface page only becomes available later on. In that case, wait for a notification on the xenstore event channel, then complete the xenstore

[linux-linus test] 169862: tolerable FAIL - PUSHED

flight 169862 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/169862/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 169836 test-armhf-armhf-libvirt 16

[xen-unstable test] 169859: regressions - FAIL

flight 169859 xen-unstable real [real] flight 169876 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169859/ http://logs.test-lab.xenproject.org/osstest/logs/169876/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH 16/30] drivers/hv/vmbus, video/hyperv_fb: Untangle and refactor Hyper-V panic notifiers

Hi Michael, first of all thanks for the great review, much appreciated. Some comments inline below: On 29/04/2022 14:16, Michael Kelley (LINUX) wrote: > [...] >> hypervisor I/O completion), so we postpone that to run late. But more >> relevant: this *same* vmbus unloading happens in the

Re: [PATCH 2/2] tools/xl: Allow specifying JSON for domain configuration file format

On Fri, Apr 29, 2022 at 01:34:40PM +0100, Anthony PERARD wrote: > On Tue, Apr 19, 2022 at 06:23:41PM -0700, Elliott Mitchell wrote: > > JSON is currently used when saving domains to mass storage. Being able > > to use JSON as the normal input to `xl create` has potential to be > > valuable. Add

[PATCH v2 0/3] Allow use of JSON in domain configuration files

While the traditional domain configuration file format works acceptably, I can see uses for having full JSON support. As such add "-j" and "-J" to `xl create` to specify format. The traditional format is the current default. While attempting this, it came up that options for `xl create` aren't

Re: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs shutdown path

On Fri, Apr 29, 2022 at 06:38:19PM -0300, Guilherme G. Piccoli wrote: > Thanks Marc and Michael for the review/discussion. > > On 29/04/2022 15:20, Marc Zyngier wrote: > > [...] > > > My expectations would be that, since we're getting here using an IPI, > > interrupts are already masked. So what

[ovmf test] 169892: regressions - FAIL

flight 169892 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169892/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[PATCH v2 2/3] tools/xl: Use sparse init for dom_info, remove duplicate vars

Rather than having shadow variables for every element of dom_info, it is better to properly initialize dom_info at the start. This also removes the misleading memset() in the middle of main_create(). Remove the dryrun element of domain_create as that has been displaced by the global

[PATCH v2 3/3] tools/xl: Allow specifying JSON for domain configuration file format

JSON is currently used when saving domains to mass storage. Being able to use JSON as the normal input to `xl create` has potential to be valuable. Add the functionality. Move the memset() earlier so to allow use of the structure sooner. Signed-off-by: Elliott Mitchell --- v2: Removing the

[PATCH v2 1/3] tools/xl: Sort create command options

Hopefully simplify future changes by sorting options lists for `xl create`. While at it, declare the options list constant. Signed-off-by: Elliott Mitchell --- v2: Adding mention of making the list constant. Fix the getopt list sorting --- tools/xl/xl_cmdtable.c | 12 ++--

Re: [PATCH 13/30] s390/consoles: Improve panic notifiers reliability

On 29/04/2022 15:46, Heiko Carstens wrote: > [...] > > Code looks good, and everything still seems to work. I applied this > internally for the time being, and if it passes testing, I'll schedule > it for the next merge window. > > Thanks! Perfect Heiko, thanks a bunch for your review and

Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

On 29/04/2022 13:04, Max Filippov wrote: > [...] >> arch/xtensa/platforms/iss/setup.c | 4 ++--For xtensa: > > For xtensa: > Acked-by: Max Filippov > Perfect, thanks Max! Cheers, Guilherme

Re: [PATCH 18/30] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set

On 27/04/2022 22:01, Xiaoming Ni wrote: > [...] > Duplicate Code. > > Is it better to use __func__ and %pS? > > pr_info("%s: %pS\n", __func__, n->notifier_call); > > This is a great suggestion Xiaoming, much appreciated! I feel like reinventing the wheel here - with your idea, code was super

[ovmf test] 169880: regressions - FAIL

flight 169880 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169880/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH 24/30] panic: Refactor the panic path

On 29/04/2022 14:53, Michael Kelley (LINUX) wrote: > From: Guilherme G. Piccoli Sent: Wednesday, April 27, > 2022 3:49 PM >> [...] >> +panic_notifiers_level= >> +[KNL] Set the panic notifiers execution order. >> +Format: >> +We

[PATCH v5 0/7] dom0less PV drivers

Hi all, Currently dom0less guests cannot use PV drivers because they don't have access to xenstore. Also, the hypervisor node in device tree is missing so they don't detect that they are running on Xen (thus, they don't try to enable PV interfaces.) This patch series enables dom0less guests (on

[PATCH v5 1/7] xen/dt: of_property_read_string return -ENODATA when !length

From: Stefano Stabellini When the length of the string is zero of_property_read_string should return -ENODATA according to the description of the function. However, of_property_read_string doesn't check prop->length. If prop->length is zero, return -ENODATA. Without this patch the following

[PATCH v5 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot

From: Luca Miccio Export evtchn_alloc_unbound and make it __must_check. If "xen,enhanced" is enabled, then add to dom0less domains: - the hypervisor node in device tree - the xenstore event channel The xenstore event channel is also used for the first notification to let the guest know that

[PATCH v5 3/7] xen: introduce xen,enhanced dom0less property

From: Stefano Stabellini Introduce a new "xen,enhanced" dom0less property to enable/disable PV driver interfaces for dom0less guests. Currently only "enabled" and "disabled" are supported property values (and empty). Leave the option open to implement further possible values in the future (e.g.

[PATCH v5 6/7] tools: add example application to initialize dom0less PV drivers

From: Luca Miccio Add an example application that can be run in dom0 to complete the dom0less domains initialization so that they can get access to xenstore and use PV drivers. The application sets XS_CONNECTION_STATE_RECONNECTING on the xenstore page before calling xs_introduce_domain to

[PATCH v5 2/7] xen/arm: implement domU extended regions

From: Stefano Stabellini Implement extended regions for dom0less domUs. The implementation is based on the libxl implementation. Signed-off-by: Stefano Stabellini --- Changes in v5: - print the domain - coding style - simplify the code in find_domU_holes - return error if no regions allocated

[PATCH v5 5/7] xenstored: send an evtchn notification on introduce_domain

From: Luca Miccio When xs_introduce_domain is called, send out a notification on the xenstore event channel so that any (dom0less) domain waiting for the xenstore interface to be ready can continue with the initialization. Before sending the notification, clear XS_CONNECTION_STATE_RECONNECTING.

[PATCH v5 7/7] docs: document dom0less + PV drivers

From: Stefano Stabellini Document how to use the feature and how the implementation works. Signed-off-by: Stefano Stabellini --- docs/features/dom0less.pandoc | 43 --- 1 file changed, 40 insertions(+), 3 deletions(-) diff --git a/docs/features/dom0less.pandoc

[ovmf test] 169882: regressions - FAIL

flight 169882 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169882/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[ovmf test] 169858: regressions - FAIL

flight 169858 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169858/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: x86/PV: (lack of) MTRR exposure

On Fri, Apr 29, 2022 at 11:50:39AM +0200, Jan Beulich wrote: > On 28.04.2022 23:30, Boris Ostrovsky wrote: > > > > On 4/28/22 11:53 AM, Jan Beulich wrote: > >> Hello, > >> > >> in the course of analyzing the i915 driver causing boot to fail in > >> Linux 5.18 I found that Linux, for all the

Re: [xen-unstable test] 169819: regressions - FAIL

On 29.04.2022 12:30, Roger Pau Monné wrote: > On Fri, Apr 29, 2022 at 07:46:47AM +, osstest service owner wrote: >> flight 169819 xen-unstable real [real] >> flight 169843 xen-unstable real-retest [real] >> http://logs.test-lab.xenproject.org/osstest/logs/169819/ >>

Re: [PATCH v4 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

On 27.04.2022 12:47, Roger Pau Monne wrote:> Changes since v3:> - Align ssbd per-core struct to a cache line.> - Open code a simple spinlock to avoid playing tricks with the lock>detector.> - s/ssbd_core/ssbd_ls_cfg/.> - Fix log message wording.> - Fix define name and remove comment.>

Re: [PATCH] x86/cet: Support cet= on the command line

On 29.04.2022 12:13, Andrew Cooper wrote: > On 28/04/2022 11:13, Jan Beulich wrote: >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> @@ -117,7 +117,20 @@ static int __init cf_check parse_cet(const char *s) >>> if ( !ss ) >>> ss = strchr(s, '\0'); >>> >>> -

Re: [PATCH 2/2] tools/xl: Allow specifying JSON for domain configuration file format

On Tue, Apr 19, 2022 at 06:23:41PM -0700, Elliott Mitchell wrote: > JSON is currently used when saving domains to mass storage. Being able > to use JSON as the normal input to `xl create` has potential to be > valuable. Add the functionality. "potential", right, but it isn't hasn't been really

Re: [PATCH 1/2] tools/xl: Sort create command options

On Tue, Apr 19, 2022 at 06:56:03PM -0700, Elliott Mitchell wrote: > Hopefully simplify future changes by sorting options lists for > `xl create`. I'm not sure that sorting options make changes easier, as it would mean one has to make sure the new option is sorted as well ;-). But sorting the

[linux-linus test] 169836: tolerable FAIL - PUSHED

flight 169836 linux-linus real [real] flight 169861 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169836/ http://logs.test-lab.xenproject.org/osstest/logs/169861/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH] x86: make "dom0_nodes=" work with credit2

On 29.04.2022 12:52, Dario Faggioli wrote: > On Wed, 2022-04-13 at 12:00 +0200, Jan Beulich wrote: >> I also have a more general question here: sched.h says "Bitmask of >> CPUs >> on which this VCPU may run" for hard affinity and "Bitmask of CPUs on >> which this VCPU prefers to run" for soft

[ovmf test] 169866: regressions - FAIL

flight 169866 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169866/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH] x86/cet: Support cet= on the command line

On 28/04/2022 10:19, Roger Pau Monné wrote: > On Thu, Apr 28, 2022 at 09:52:09AM +0100, Andrew Cooper wrote: >> ... as a shorthand for setting both suboptions at once. >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Roger Pau Monné Thanks. > > From the implementation below we would support

[PATCH 2/2] linker/lld: do not generate quoted section names

LLVM LD doesn't strip the quotes from the section names, and so the resulting binary ends up with section names like: [ 1] ".text" PROGBITS 82d04020 8000 0018cbc1 AX 0 0 4096 This confuses some tools (like gdb) and

[PATCH 1/2] kconfig: detect LD implementation

Detect GNU and LLVM ld implementations. This is required for further patches that will introduce diverging behaviour depending on the linker implementation in use. Note that LLVM ld returns "compatible with GNU linkers" as part of the version string, so be on the safe side and use '^' to only

[PATCH 0/2] linker: fix build with LLVM LD

Hello, LLVM LD doesn't remove quotes from sections names, and thus the resulting binary cannot be parsed by some tools due to the quoted sections names. First patch has already been posted independently and got not enough Acks/RB, second patch depends on the first one and is the actual fix for

Re: [PATCH 2/2] linker/lld: do not generate quoted section names

On 29.04.2022 11:36, Roger Pau Monne wrote: > LLVM LD doesn't strip the quotes from the section names, and so the > resulting binary ends up with section names like: > > [ 1] ".text" PROGBITS 82d04020 8000 >0018cbc1 AX 0

[libvirt test] 169850: regressions - FAIL

flight 169850 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/169850/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

Re: x86/PV: (lack of) MTRR exposure

On 28.04.2022 23:30, Boris Ostrovsky wrote: > > On 4/28/22 11:53 AM, Jan Beulich wrote: >> Hello, >> >> in the course of analyzing the i915 driver causing boot to fail in >> Linux 5.18 I found that Linux, for all the years, has been running >> in PV mode as if PAT was (mostly) disabled. This is a

Re: [PATCH] x86/cet: Support cet= on the command line

On 28/04/2022 11:13, Jan Beulich wrote: > On 28.04.2022 10:52, Andrew Cooper wrote: >> @@ -283,6 +283,8 @@ CET is incompatible with 32bit PV guests. If any CET >> sub-options are active, >> they will override the `pv=32` boolean to `false`. Backwards compatibility >> can be maintained with

Re: [PATCH] x86: make "dom0_nodes=" work with credit2

On Wed, 2022-04-13 at 12:00 +0200, Jan Beulich wrote: > On 12.04.2022 18:11, Dario Faggioli wrote: > > --- a/xen/common/sched/core.c > > +++ b/xen/common/sched/core.c > > @@ -572,11 +572,41 @@ int sched_init_vcpu(struct vcpu *v) > > } > >   > > /* > > - * Initialize affinity

Re: [xen-unstable test] 169819: regressions - FAIL

On Fri, Apr 29, 2022 at 12:37:13PM +0200, Jan Beulich wrote: > On 29.04.2022 12:30, Roger Pau Monné wrote: > > On Fri, Apr 29, 2022 at 07:46:47AM +, osstest service owner wrote: > >> flight 169819 xen-unstable real [real] > >> flight 169843 xen-unstable real-retest [real] > >>

Re: Virtio on Xen with Rust

On 29.04.22 06:59, Viresh Kumar wrote: Hello Viresh On 29-04-22, 09:18, Viresh Kumar wrote: Now, it was just yesterday that I started looking into MMIO modern stuff as the GPIO device needs it and you sent me working code to look how to do it as well. You saved at least 1-2 days of my

[ovmf test] 169865: regressions - FAIL

flight 169865 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169865/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: x86/PV: (lack of) MTRR exposure

On 29.04.2022 10:00, Roger Pau Monné wrote: > On Thu, Apr 28, 2022 at 05:53:17PM +0200, Jan Beulich wrote: >> Hello, >> >> in the course of analyzing the i915 driver causing boot to fail in >> Linux 5.18 I found that Linux, for all the years, has been running >> in PV mode as if PAT was (mostly)

Re: [PATCH 1/2] kconfig: detect LD implementation

Hi Roger, On 29/04/2022 10:36, Roger Pau Monne wrote: Detect GNU and LLVM ld implementations. This is required for further patches that will introduce diverging behaviour depending on the linker implementation in use. Note that LLVM ld returns "compatible with GNU linkers" as part of the

Re: [PATCH] x86/cet: Support cet= on the command line

On 28/04/2022 11:13, Jan Beulich wrote: >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -117,7 +117,20 @@ static int __init cf_check parse_cet(const char *s) >> if ( !ss ) >> ss = strchr(s, '\0'); >> >> -if ( (val = parse_boolean("shstk", s, ss))

Re: [xen-unstable test] 169819: regressions - FAIL

On Fri, Apr 29, 2022 at 07:46:47AM +, osstest service owner wrote: > flight 169819 xen-unstable real [real] > flight 169843 xen-unstable real-retest [real] > http://logs.test-lab.xenproject.org/osstest/logs/169819/ > http://logs.test-lab.xenproject.org/osstest/logs/169843/ > > Regressions :-(

Re: [PATCH v4 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests

On 27.04.2022 12:47, Roger Pau Monne wrote: > --- a/xen/arch/x86/cpuid.c > +++ b/xen/arch/x86/cpuid.c > @@ -541,6 +541,10 @@ static void __init calculate_hvm_max_policy(void) > raw_cpuid_policy.basic.sep ) > __set_bit(X86_FEATURE_SEP, hvm_featureset); > > +if (

Re: Virtio on Xen with Rust

On 29.04.22 06:48, Viresh Kumar wrote: Hello Viresh On 28-04-22, 16:52, Oleksandr Tyshchenko wrote: Great work! Thanks Oleksandr. I skimmed through your toolstack patches, awesome, you created a completely new virtual device "I2C". I have also created GPIO now :) Awesome! What

Re: x86/PV: (lack of) MTRR exposure

On Fri, Apr 29, 2022 at 12:00:21PM +0200, Jan Beulich wrote: > On 29.04.2022 10:00, Roger Pau Monné wrote: > > On Thu, Apr 28, 2022 at 05:53:17PM +0200, Jan Beulich wrote: > >> Hello, > >> > >> in the course of analyzing the i915 driver causing boot to fail in > >> Linux 5.18 I found that Linux,

Re: [PATCH] x86/mm: slightly relax TLB-flush-local check again

On 29/04/2022 14:20, Jan Beulich wrote: > system_state changes to SYS_STATE_smp_boot before alternative_branches() > is invoked, yet that function, with CET-SS enabled, needs to invoke > modify_xen_mappings(). Convert to check for the number of online CPUs, > just like was done also in

Re: [PATCH 17/30] tracing: Improve panic/die notifiers

On 29/04/2022 10:23, Steven Rostedt wrote: > On Fri, 29 Apr 2022 12:22:44 +0300 > Sergei Shtylyov wrote: > >>> + switch (ev) { >>> + case DIE_OOPS: >>> + do_dump = 1; >>> + break; >>> + case PANIC_NOTIFIER: >>> + do_dump = 1; >>> + break; >> >>

Re: [PATCH 09/30] coresight: cpu-debug: Replace mutex with mutex_trylock on panic notifier

On 28/04/2022 05:11, Suzuki K Poulose wrote: > Hi Guilherme, > [...] > How would you like to proceed with queuing this ? I am happy > either way. In case you plan to push this as part of this > series (I don't see any potential conflicts) : > > Reviewed-by: Suzuki K Poulose Thanks for your

Re: [PATCH 17/30] tracing: Improve panic/die notifiers

On 29/04/2022 10:56, Steven Rostedt wrote: > [...] > No. The fallthrough keyword is only needed when there's code between case > labels. As it is very common to list multiple cases for the same code path. > That is: > > case DIE_OOPS: > case PANIC_NOTIFIER: > do_dump =

Re: [PATCH v2] tools/libs/light: update xenstore entry when setting max domain memory

On Wed, Apr 20, 2022 at 10:04:26AM +0200, Juergen Gross wrote: > libxl_domain_setmaxmem() called during "xl mem-max" should update the > domain's memory/static-max Xenstore node, as otherwise "xl mem-set" > won't be able to set the memory size to the new maximum. Setting domain's memory higher

Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

On 28/04/2022 13:26, Corey Minyard wrote: > [...] > > For the IPMI portion: > > Acked-by: Corey Minyard Thanks Alex and Corey for the ACKs! > > Note that the IPMI panic_event() should always return, but it may take > some time, especially if the IPMI controller is no longer functional. > So

[PATCH] x86/mm: slightly relax TLB-flush-local check again

system_state changes to SYS_STATE_smp_boot before alternative_branches() is invoked, yet that function, with CET-SS enabled, needs to invoke modify_xen_mappings(). Convert to check for the number of online CPUs, just like was done also in 88a037e2cfe1 / fa6dc0879ffd ("page_alloc: assert IRQs are

Re: [PATCH v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

On Wed, Apr 13, 2022 at 12:21:10PM +0100, Jane Malalane wrote: > Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and > XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and > x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization > can subsequently be enabled on a

Re: [PATCH v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC

On Wed, Apr 13, 2022 at 12:21:11PM +0100, Jane Malalane wrote: > Introduce a new per-domain creation x86 specific flag to > select whether hardware assisted virtualization should be used for > x{2}APIC. > > A per-domain option is added to xl in order to select the usage of > x{2}APIC hardware

Re: [PATCH] x86: make "dom0_nodes=" work with credit2

On Fri, 2022-04-29 at 14:16 +0200, Jan Beulich wrote: > On 29.04.2022 12:52, Dario Faggioli wrote: > > > Is that mainly > > > to have a way to record preferences even when all preferred CPUs > > > are > > > offline, to be able to go back to the preferences once CPUs come > > > back > > > online? >

[qemu-mainline test] 169849: tolerable FAIL - PUSHED

flight 169849 qemu-mainline real [real] flight 169869 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169849/ http://logs.test-lab.xenproject.org/osstest/logs/169869/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

[xen-unstable-smoke test] 169864: tolerable all pass - PUSHED

flight 169864 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/169864/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH 20/30] panic: Add the panic informational notifier list

Thanks Paul and Suzuki for the ACKs. Cheers, Guilherme

Re: [PATCH v2 19/19] xen/xenbus: eliminate xenbus_grant_ring()

On 28.04.22 11:27, Juergen Gross wrote: Hello Juergen There is no external user of xenbus_grant_ring() left, so merge it into the only caller xenbus_setup_ring(). Signed-off-by: Juergen Gross --- V2: - make error message more precise (Andrew Cooper) ---

Re: [PATCH v2 08/19] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF

Hello Juergen On 28.04.22 21:03, Oleksandr Tyshchenko wrote: On Thu, Apr 28, 2022 at 11:28 AM Juergen Gross > wrote: Hello Juergen [sorry for the possible format issue] Instead of using a private macro for an invalid grant reference use the common one.

Re: [PATCH 17/30] tracing: Improve panic/die notifiers

On Fri, 29 Apr 2022 12:22:44 +0300 Sergei Shtylyov wrote: > > + switch (ev) { > > + case DIE_OOPS: > > + do_dump = 1; > > + break; > > + case PANIC_NOTIFIER: > > + do_dump = 1; > > + break; > >Why not: > > case DIE_OOPS: > case

Re: [PATCH 12/30] parisc: Replace regular spinlock with spin_trylock on panic path

On 28/04/2022 13:55, Helge Deller wrote: > [...] > You may add: > Acked-by: Helge Deller # parisc > > Helge Thanks Helge, added! Cheers, Guilherme > > >> --- >> arch/parisc/include/asm/pdc.h | 1 + >> arch/parisc/kernel/firmware.c | 27 +++ >>

[PATCH] PCI: don't allow "pci-phantom=" to mark real devices as phantom functions

IOMMU code mapping / unmapping devices and interrupts will misbehave if a wrong command line option declared a function "phantom" when there's a real device at that position. Warn about this and adjust the specified stride (in the worst case ignoring the option altogether). Requested-by: Andrew

Re: [PATCH] x86/mm: slightly relax TLB-flush-local check again

On 29.04.2022 15:32, Andrew Cooper wrote: > On 29/04/2022 14:20, Jan Beulich wrote: >> system_state changes to SYS_STATE_smp_boot before alternative_branches() >> is invoked, yet that function, with CET-SS enabled, needs to invoke >> modify_xen_mappings(). Convert to check for the number of online

Re: [PATCH v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC

On 13 Apr 2022, at 12:21, Jane Malalane mailto:jane.malal...@citrix.com>> wrote: Introduce a new per-domain creation x86 specific flag to select whether hardware assisted virtualization should be used for x{2}APIC. tools/ocaml/libs/xc/xenctrl.ml| 2 ++ tools/ocaml/libs/xc/xenctrl.mli

Re: [PATCH 17/30] tracing: Improve panic/die notifiers

On Fri, 29 Apr 2022 10:46:35 -0300 "Guilherme G. Piccoli" wrote: > Thanks Sergei and Steven, good idea! I thought about the switch change > you propose, but I confess I got a bit confused by the "fallthrough" > keyword - do I need to use it? No. The fallthrough keyword is only needed when

Re: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a device

Hi Julien, > On 27 Apr 2022, at 6:42 pm, Julien Grall wrote: > > Hi, > > On 27/04/2022 17:15, Rahul Singh wrote: >> When a device is deassigned from the domain it is required to remove the >> iommu group. > > This read wrong to me. We should not need to re-create the IOMMU group (and > call

[ovmf test] 169868: regressions - FAIL

flight 169868 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169868/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH v4 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

On Fri, Apr 29, 2022 at 12:59:58PM +0200, Jan Beulich wrote: > On 27.04.2022 12:47, Roger Pau Monne wrote:> Changes since v3:> - Align ssbd > per-core struct to a cache line.> - Open code a simple spinlock to avoid > playing tricks with the lock>detector.> - s/ssbd_core/ssbd_ls_cfg/.> -

  1   2   >