[PATCH 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD

2022-10-26 Thread Chuck Zmudzinski
From: Chuck Zmudzinski This is a series of two patches: The first fixes FTBFS when --enable-xen and --disable-xen-pci-passthrough configure options are set with when building for the linux target os. The second fixes a regression that was introduced many years ago with the upgrade from the

[PATCH 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2022-10-26 Thread Chuck Zmudzinski
From: Chuck Zmudzinski Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device

[PATCH 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-10-26 Thread Chuck Zmudzinski
From: Chuck Zmudzinski When Qemu is built with --enable-xen and --disable-xen-pci-passthrough and the target os is linux, the build fails with: meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. Fixes: 582ea95f5f93 ("meson: convert hw/xen") Signed-off-by: Chuck Zmudzinski ---

Re: [v2] Proposal for deviations in static analyser findings

2022-10-26 Thread Luca Fancellu
> On 26 Oct 2022, at 00:24, Stefano Stabellini wrote: > > On Tue, 25 Oct 2022, Luca Fancellu wrote: >> Hi all, >> >> This is the V2 of the proposal for deviations tagging in the Xen codebase, >> this includes >> all the feedbacks from the FuSa session held at the Xen Summit 2022 and all >>

Re: [PATCH for-4.14-to-4.16 0/2] Backports for XSA-409 fixes

2022-10-26 Thread Jan Beulich
On 25.10.2022 22:06, Julien Grall wrote: > On 25/10/2022 10:21, Henry Wang wrote: >> This series is a backported series for XSA-409 fixes from master for >> 4.14 to 4.16, which cherry-picking commits: >> 3783e583319f arm/p2m: Rework p2m_init() >> c7cff1188802 xen/arm: p2m: Populate pages for GICv2

Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable

2022-10-26 Thread Tamas K Lengyel
On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper wrote: > On 24/10/2022 17:58, Tamas K Lengyel wrote: > > Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a > handful > > of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs by an > > external privileged tool is

[PATCH v2 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD

2022-10-26 Thread Chuck Zmudzinski
This is a series of two patches: The first fixes FTBFS when --enable-xen and --disable-xen-pci-passthrough configure options are set with when building for the linux target os. The second fixes a regression that was introduced many years ago with the upgrade from the Qemu traditional device

[PATCH v2 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2022-10-26 Thread Chuck Zmudzinski
Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI

[PATCH v2 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-10-26 Thread Chuck Zmudzinski
When Qemu is built with --enable-xen and --disable-xen-pci-passthrough and the target os is linux, the build fails with: meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. Fixes: 582ea95f5f93 ("meson: convert hw/xen") Signed-off-by: Chuck Zmudzinski --- v2: Remove From: tag at top

Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable

2022-10-26 Thread Roger Pau Monné
On Tue, Oct 25, 2022 at 01:48:36PM -0400, Tamas K Lengyel wrote: > On Tue, Oct 25, 2022 at 4:13 AM Roger Pau Monné > wrote: > > > > On Mon, Oct 24, 2022 at 12:58:54PM -0400, Tamas K Lengyel wrote: > > > Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a > handful > > > of

[PATCH 4/4] xen/arm: Correct the p2m pool size calculations

2022-10-26 Thread Andrew Cooper
Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_p2m_mempool_size varies with time as the guest shuffles its physmap, and

[PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls

2022-10-26 Thread Andrew Cooper
This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_p2m_pool_size()

Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable

2022-10-26 Thread Jan Beulich
On 26.10.2022 13:34, Tamas K Lengyel wrote: > On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper > wrote: > >> On 24/10/2022 17:58, Tamas K Lengyel wrote: >>> Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a >> handful >>> of predetermined vcpu MSRs. In our use-case gathering the

[qemu-mainline test] 174369: regressions - FAIL

2022-10-26 Thread osstest service owner
flight 174369 qemu-mainline real [real] flight 174440 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174369/ http://logs.test-lab.xenproject.org/osstest/logs/174440/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not

Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable

2022-10-26 Thread Andrew Cooper
On 24/10/2022 17:58, Tamas K Lengyel wrote: > Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a handful > of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs by an > external privileged tool is necessary, thus we extend the domctl to allow for > querying for any

[xen-4.16-testing test] 174383: regressions - FAIL

2022-10-26 Thread osstest service owner
flight 174383 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174383/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle 14 guest-start fail REGR. vs. 172623

Re: [v2] Proposal for deviations in static analyser findings

2022-10-26 Thread Jan Beulich
On 25.10.2022 12:13, Luca Fancellu wrote: > Here is an example to add a new justification in safe.json:: > > |{ > |"version": "1.0", > |"content": [ > |{ > |"id":"SAF-0-safe", > |"analyser": { > |"cppcheck": "misra-c2012-20.7", > |

Re: [v2] Proposal for deviations in static analyser findings

2022-10-26 Thread Julien Grall
On 25/10/2022 11:13, Luca Fancellu wrote: Hi all, Hi Luca, Some comments below if we plan to merge the doc in the tree. This is the V2 of the proposal for deviations tagging in the Xen codebase, this includes all the feedbacks from the FuSa session held at the Xen Summit 2022 and all

[PATCH for-4.17 0/4] XSA-409 fixes

2022-10-26 Thread Andrew Cooper
For 4.17, and backport to all stable releases. Patch 2 doesn't technically need backporting, but it's safe and I'm dis-enclined to forgo testing in older releases. Andrew Cooper (4): xen: Introduce non-broken hypercalls for the p2m pool size tools/tests: Unit test for p2m pool size

[PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool size

2022-10-26 Thread Andrew Cooper
The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of of 1M. This was tolerable when the size of the pool could only be

Re: [v2] Proposal for deviations in static analyser findings

2022-10-26 Thread Luca Fancellu
> On 26 Oct 2022, at 10:36, Julien Grall wrote: > > > > On 25/10/2022 11:13, Luca Fancellu wrote: >> Hi all, > > Hi Luca, > > Some comments below if we plan to merge the doc in the tree. > >> This is the V2 of the proposal for deviations tagging in the Xen codebase, >> this includes >>

[PATCH 2/4] tools/tests: Unit test for p2m pool size

2022-10-26 Thread Andrew Cooper
Exercise some basic functionality of the new xc_{get,set}_p2m_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper --- CC: Xen Security Team CC: Jan Beulich

Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable

2022-10-26 Thread Tamas K Lengyel
On Wed, Oct 26, 2022, 7:48 AM Jan Beulich wrote: > On 26.10.2022 13:34, Tamas K Lengyel wrote: > > On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper > > wrote: > > > >> On 24/10/2022 17:58, Tamas K Lengyel wrote: > >>> Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a > >> handful

Re: [v2] Proposal for deviations in static analyser findings

2022-10-26 Thread Luca Fancellu
> On 26 Oct 2022, at 13:06, Jan Beulich wrote: > > On 25.10.2022 12:13, Luca Fancellu wrote: >> Here is an example to add a new justification in safe.json:: >> >> |{ >> |"version": "1.0", >> |"content": [ >> |{ >> |"id":"SAF-0-safe", >> |"analyser": {

Re: Deadcode discussion based on Arm NS phys timer

2022-10-26 Thread Michal Orzel
Hi all, On 25/10/2022 10:20, Bertrand Marquis wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Hi Michal, > >> On 25 Oct 2022, at 09:07, Michal Orzel wrote: >> >> Hi Bertrand, >> >> On

Re: [PATCH for-4.17 v2 4/5] pci: do not disable memory decoding for devices

2022-10-26 Thread Jan Beulich
On 25.10.2022 16:44, Roger Pau Monne wrote: > --- a/xen/drivers/vpci/header.c > +++ b/xen/drivers/vpci/header.c > @@ -121,7 +121,9 @@ static void modify_decoding(const struct pci_dev *pdev, > uint16_t cmd, > } > > if ( !rom_only && > - (bar->type != VPCI_BAR_ROM ||

Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices

2022-10-26 Thread Rahul Singh
Hi Julien, > On 26 Oct 2022, at 2:36 pm, Julien Grall wrote: > > > > On 26/10/2022 14:17, Rahul Singh wrote: >> Hi All, > > Hi Rahul, > >> At Arm, we started to implement the POC to support 2 levels of page >> tables/nested translation in SMMUv3. >> To support nested translation for guest

Re: Deadcode discussion based on Arm NS phys timer

2022-10-26 Thread Bertrand Marquis
Hi Michal, > On 26 Oct 2022, at 12:29, Michal Orzel wrote: > > Hi all, > > On 25/10/2022 10:20, Bertrand Marquis wrote: >> Caution: This message originated from an External Source. Use proper caution >> when opening attachments, clicking links, or responding. >> >> >> Hi Michal, >> >>> On

Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices

2022-10-26 Thread Rahul Singh
Hi All, At Arm, we started to implement the POC to support 2 levels of page tables/nested translation in SMMUv3. To support nested translation for guest OS Xen needs to expose the virtual IOMMU. If we passthrough the device to the guest that is behind an IOMMU and virtual IOMMU is enabled for

Re: [PATCH 2/4] tools/tests: Unit test for p2m pool size

2022-10-26 Thread Andrew Cooper
On 26/10/2022 15:24, Jan Beulich wrote: > On 26.10.2022 12:20, Andrew Cooper wrote: >> --- /dev/null >> +++ b/tools/tests/p2m-pool/Makefile >> @@ -0,0 +1,42 @@ >> +XEN_ROOT = $(CURDIR)/../../.. >> +include $(XEN_ROOT)/tools/Rules.mk >> + >> +TARGET := test-p2m-pool >> + >> +.PHONY: all >> +all:

Re: [PATCH for-4.17 v2 4/5] pci: do not disable memory decoding for devices

2022-10-26 Thread Roger Pau Monné
On Wed, Oct 26, 2022 at 02:35:44PM +0200, Jan Beulich wrote: > On 25.10.2022 16:44, Roger Pau Monne wrote: > > --- a/xen/drivers/vpci/header.c > > +++ b/xen/drivers/vpci/header.c > > @@ -121,7 +121,9 @@ static void modify_decoding(const struct pci_dev *pdev, > > uint16_t cmd, > > } > >

RE: [PATCH] CI: Drop more TravisCI remnants

2022-10-26 Thread Henry Wang
Hi > Subject: Re: [PATCH] CI: Drop more TravisCI remnants > > On 26.10.2022 14:39, Andrew Cooper wrote: > > This was missed from previous attempts to remove Travis. > > > > Fixes: e0dc9b095e7c ("CI: Drop TravisCI") > > Signed-off-by: Andrew Cooper > > Acked-by: Jan Beulich Release-acked-by:

Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls

2022-10-26 Thread Andrew Cooper
On 26/10/2022 14:22, Jason Andryuk wrote: > On Wed, Oct 26, 2022 at 6:21 AM Andrew Cooper > wrote: >> This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and >> bits >> of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. >> >> First of all, with ARM borrowing x86's implementation,

Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices

2022-10-26 Thread Julien Grall
On 26/10/2022 14:17, Rahul Singh wrote: Hi All, Hi Rahul, At Arm, we started to implement the POC to support 2 levels of page tables/nested translation in SMMUv3. To support nested translation for guest OS Xen needs to expose the virtual IOMMU. If we passthrough the device to the guest

[XEN v3] xen/arm: vGICv3: Emulate properly 32-bit access on GICR_PENDBASER

2022-10-26 Thread Ayan Kumar Halder
If a guest is running in 32 bit mode and it tries to access "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract() will return the value stored "v->arch.vgic.rdist_pendbase + 4". This will be stored in a 64bit cpu register. So now we have the top 32 bits of GICR_PENDBASER

Re: [XEN v3] xen/arm: vGICv3: Emulate properly 32-bit access on GICR_PENDBASER

2022-10-26 Thread Julien Grall
Hi Ayan, On 26/10/2022 14:35, Ayan Kumar Halder wrote: If a guest is running in 32 bit mode and it tries to access "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract() will return the value stored "v->arch.vgic.rdist_pendbase + 4". This will be stored in a 64bit cpu

Re: [PATCH for-4.17 v2 5/5] vpci: refuse BAR writes only if the BAR is mapped

2022-10-26 Thread Roger Pau Monné
On Wed, Oct 26, 2022 at 02:47:43PM +0200, Jan Beulich wrote: > On 25.10.2022 16:44, Roger Pau Monne wrote: > > Writes to the BARs are ignored if memory decoding is enabled for the > > device, and the same happen with ROM BARs if the write is an attempt > > to change the position of the BAR without

Re: [PATCH for-4.17 v2 5/5] vpci: refuse BAR writes only if the BAR is mapped

2022-10-26 Thread Jan Beulich
On 26.10.2022 15:58, Roger Pau Monné wrote: > On Wed, Oct 26, 2022 at 02:47:43PM +0200, Jan Beulich wrote: >> On 25.10.2022 16:44, Roger Pau Monne wrote: >>> @@ -388,12 +391,12 @@ static void cf_check bar_write( >>> else >>> val &= PCI_BASE_ADDRESS_MEM_MASK; >>> >>> -if (

Re: [PATCH 2/4] tools/tests: Unit test for p2m pool size

2022-10-26 Thread Jan Beulich
On 26.10.2022 12:20, Andrew Cooper wrote: > --- /dev/null > +++ b/tools/tests/p2m-pool/Makefile > @@ -0,0 +1,42 @@ > +XEN_ROOT = $(CURDIR)/../../.. > +include $(XEN_ROOT)/tools/Rules.mk > + > +TARGET := test-p2m-pool > + > +.PHONY: all > +all: $(TARGET) > + > +.PHONY: clean > +clean: > + $(RM)

Re: Deadcode discussion based on Arm NS phys timer

2022-10-26 Thread Stefano Stabellini
On Wed, 26 Oct 2022, Bertrand Marquis wrote: > > On 26 Oct 2022, at 12:29, Michal Orzel wrote: > > > > Hi all, > > > > On 25/10/2022 10:20, Bertrand Marquis wrote: > >> Caution: This message originated from an External Source. Use proper > >> caution when opening attachments, clicking links,

[PATCH] CI: Drop more TravisCI remnants

2022-10-26 Thread Andrew Cooper
This was missed from previous attempts to remove Travis. Fixes: e0dc9b095e7c ("CI: Drop TravisCI") Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall CC: Henry Wang Preforably for 4.17. Not a bugfix, but this does reduce

Re: [PATCH for-4.17 v2 5/5] vpci: refuse BAR writes only if the BAR is mapped

2022-10-26 Thread Jan Beulich
On 25.10.2022 16:44, Roger Pau Monne wrote: > Writes to the BARs are ignored if memory decoding is enabled for the > device, and the same happen with ROM BARs if the write is an attempt > to change the position of the BAR without disabling it first. > > The reason of ignoring such writes is a

Re: [PATCH] CI: Drop more TravisCI remnants

2022-10-26 Thread Jan Beulich
On 26.10.2022 14:39, Andrew Cooper wrote: > This was missed from previous attempts to remove Travis. > > Fixes: e0dc9b095e7c ("CI: Drop TravisCI") > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich

Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool size

2022-10-26 Thread Jan Beulich
On 26.10.2022 12:20, Andrew Cooper wrote: > The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: > > * All set_allocation() flavours have an overflow-before-widen bug when >calculating "sc->mb << (20 - PAGE_SHIFT)". > * All flavours have a granularity of of 1M. This was

Re: [XEN v3] xen/arm: vGICv3: Emulate properly 32-bit access on GICR_PENDBASER

2022-10-26 Thread Ayan Kumar Halder
On 26/10/2022 14:41, Julien Grall wrote: Hi Ayan, Hi Julien, On 26/10/2022 14:35, Ayan Kumar Halder wrote: If a guest is running in 32 bit mode and it tries to access "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract() will return the value stored

Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable

2022-10-26 Thread Jan Beulich
On 26.10.2022 13:58, Tamas K Lengyel wrote: > On Wed, Oct 26, 2022, 7:48 AM Jan Beulich wrote: > >> On 26.10.2022 13:34, Tamas K Lengyel wrote: >>> On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper >>> wrote: >>> On 24/10/2022 17:58, Tamas K Lengyel wrote: > Currently the

Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls

2022-10-26 Thread Jason Andryuk
On Wed, Oct 26, 2022 at 6:21 AM Andrew Cooper wrote: > > This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits > of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. > > First of all, with ARM borrowing x86's implementation, the logic to set the > pool size should have been

[linux-linus test] 174395: regressions - FAIL

2022-10-26 Thread osstest service owner
flight 174395 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174395/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462

Re: [PATCH] CI: Drop more TravisCI remnants

2022-10-26 Thread Stefano Stabellini
On Wed, 26 Oct 2022, Andrew Cooper wrote: > This was missed from previous attempts to remove Travis. > > Fixes: e0dc9b095e7c ("CI: Drop TravisCI") > Signed-off-by: Andrew Cooper Acked-by: Stefano Stabellini > --- > CC: George Dunlap > CC: Jan Beulich > CC: Stefano Stabellini > CC: Wei Liu

Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices

2022-10-26 Thread Julien Grall
On 26/10/2022 15:33, Rahul Singh wrote: Hi Julien, Hi Rahul, On 26 Oct 2022, at 2:36 pm, Julien Grall wrote: On 26/10/2022 14:17, Rahul Singh wrote: Hi All, Hi Rahul, At Arm, we started to implement the POC to support 2 levels of page tables/nested translation in SMMUv3. To

[xen-4.13-testing test] 174411: regressions - FAIL

2022-10-26 Thread osstest service owner
flight 174411 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174411/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 172549

Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool size

2022-10-26 Thread Julien Grall
Hi Andrew, On 26/10/2022 20:22, Andrew Cooper wrote: --- a/xen/arch/x86/mm/hap/hap.c +++ b/xen/arch/x86/mm/hap/hap.c @@ -345,6 +345,16 @@ unsigned int hap_get_allocation(struct domain *d) + ((pg & ((1 << (20 - PAGE_SHIFT)) - 1)) ? 1 : 0)); } +int

Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool size

2022-10-26 Thread Andrew Cooper
On 26/10/2022 14:42, Jan Beulich wrote: > On 26.10.2022 12:20, Andrew Cooper wrote: >> The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: >> >> * All set_allocation() flavours have an overflow-before-widen bug when >>calculating "sc->mb << (20 - PAGE_SHIFT)". >> * All

Re: [PATCH v11 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-26 Thread Michael S. Tsirkin
On Tue, Oct 11, 2022 at 10:05:22PM +0200, Laurent Vivier wrote: > "-netdev socket" only supports inet sockets. > > It's not a complex task to add support for unix sockets, but > the socket netdev parameters are not defined to manage well unix > socket parameters. Acked-by: Michael S. Tsirkin

[libvirt test] 174434: tolerable all pass - PUSHED

2022-10-26 Thread osstest service owner
flight 174434 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174434/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 174380 test-armhf-armhf-libvirt-qcow2 15

Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable

2022-10-26 Thread Tamas K Lengyel
On Wed, Oct 26, 2022 at 8:22 AM Jan Beulich wrote: > > On 26.10.2022 13:58, Tamas K Lengyel wrote: > > On Wed, Oct 26, 2022, 7:48 AM Jan Beulich wrote: > > > >> On 26.10.2022 13:34, Tamas K Lengyel wrote: > >>> On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper > >>> wrote: > >>> > On 24/10/2022

Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices

2022-10-26 Thread Michal Orzel
Hi Rahul, On 26/10/2022 16:33, Rahul Singh wrote: > > > Hi Julien, > >> On 26 Oct 2022, at 2:36 pm, Julien Grall wrote: >> >> >> >> On 26/10/2022 14:17, Rahul Singh wrote: >>> Hi All, >> >> Hi Rahul, >> >>> At Arm, we started to implement the POC to support 2 levels of page >>> tables/nested

Re: [XEN v3] xen/arm: vGICv3: Emulate properly 32-bit access on GICR_PENDBASER

2022-10-26 Thread Ayan Kumar Halder
Hi Julien, On 26/10/2022 17:45, Julien Grall wrote: On 26/10/2022 16:06, Ayan Kumar Halder wrote: ... you also need to ensure that the writers are atomically setting rdist_pendbase. Please correct if I am wrong, but the callers are not using write_atomic(). So how does that work? I

[xen-4.14-testing test] 174406: regressions - FAIL

2022-10-26 Thread osstest service owner
flight 174406 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174406/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 broken in 173725 test-arm64-arm64-xl-xsm

Re: [PATCH v1 01/12] hw/xen: Correct build config for xen_pt_stub

2022-10-26 Thread Alex Bennée
Vikram Garhwal writes: > Build fails when have_xen_pci_passthrough is disabled. This is because of > incorrect build configuration for xen_pt_stub.c. > > Signed-off-by: Stefano Stabellini > Signed-off-by: Vikram Garhwal Reviewed-by: Alex Bennée -- Alex Bennée

[xen-unstable-smoke test] 174455: tolerable all pass - PUSHED

2022-10-26 Thread osstest service owner
flight 174455 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174455/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[PATCH v3 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2022-10-26 Thread Chuck Zmudzinski
Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI

Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices

2022-10-26 Thread Oleksandr Tyshchenko
On Wed, Oct 26, 2022 at 8:18 PM Michal Orzel wrote: > Hi Rahul, > Hello all [sorry for the possible format issues] > > On 26/10/2022 16:33, Rahul Singh wrote: > > > > > > Hi Julien, > > > >> On 26 Oct 2022, at 2:36 pm, Julien Grall wrote: > >> > >> > >> > >> On 26/10/2022 14:17, Rahul

Re: [XEN v3] xen/arm: vGICv3: Emulate properly 32-bit access on GICR_PENDBASER

2022-10-26 Thread Julien Grall
On 26/10/2022 16:06, Ayan Kumar Halder wrote: ... you also need to ensure that the writers are atomically setting rdist_pendbase. Please correct if I am wrong, but the callers are not using write_atomic(). So how does that work? I think read_atomic()/write_atomic() may not be the correct

[XEN v4] xen/arm: vGICv3: Emulate properly 32-bit access on GICR_PENDBASER

2022-10-26 Thread Ayan Kumar Halder
If a guest is running in 32 bit mode and it tries to access "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract() will return the value stored "v->arch.vgic.rdist_pendbase + 4". This will be stored in a 64bit cpu register. So now we have the top 32 bits of GICR_PENDBASER

Re: Deadcode discussion based on Arm NS phys timer

2022-10-26 Thread Michal Orzel
Hi, On 26/10/2022 17:30, Stefano Stabellini wrote: > > > On Wed, 26 Oct 2022, Bertrand Marquis wrote: >>> On 26 Oct 2022, at 12:29, Michal Orzel wrote: >>> >>> Hi all, >>> >>> On 25/10/2022 10:20, Bertrand Marquis wrote: Caution: This message originated from an External Source. Use proper

Re: [PATCH for-4.17 v2 5/5] vpci: refuse BAR writes only if the BAR is mapped

2022-10-26 Thread Roger Pau Monné
On Wed, Oct 26, 2022 at 04:06:40PM +0200, Jan Beulich wrote: > On 26.10.2022 15:58, Roger Pau Monné wrote: > > On Wed, Oct 26, 2022 at 02:47:43PM +0200, Jan Beulich wrote: > >> On 25.10.2022 16:44, Roger Pau Monne wrote: > >>> @@ -388,12 +391,12 @@ static void cf_check bar_write( > >>> else >

[PATCH v3 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD

2022-10-26 Thread Chuck Zmudzinski
This is a series of two patches: The first fixes FTBFS when --enable-xen and --disable-xen-pci-passthrough configure options are set with when building for the linux target os. The second fixes a regression that was introduced many years ago with the upgrade from the Qemu traditional device

[PATCH v3 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-10-26 Thread Chuck Zmudzinski
When Qemu is built with --enable-xen and --disable-xen-pci-passthrough and the target os is linux, the build fails with: meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. Fixes: 582ea95f5f93 ("meson: convert hw/xen") Signed-off-by: Chuck Zmudzinski --- v2: Remove From: tag at top

[ovmf test] 174478: all pass - PUSHED

2022-10-26 Thread osstest service owner
flight 174478 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174478/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 115cebbe4d7541c795b4f9baefc38f9a1733b7f6 baseline version: ovmf

[ovmf test] 174468: all pass - PUSHED

2022-10-26 Thread osstest service owner
flight 174468 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174468/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b6efc505e4d6eb2055a39afd0a1ee67846a1e5f9 baseline version: ovmf

[xen-unstable-smoke test] 174474: tolerable all pass - PUSHED

2022-10-26 Thread osstest service owner
flight 174474 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174474/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[xen-4.15-testing test] 174415: tolerable FAIL - PUSHED

2022-10-26 Thread osstest service owner
flight 174415 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174415/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 172547