Re: [Xen-devel] [PATCH RFC 2/3] automation: build stubdom and rombios, and tools on 32 bit

2018-05-28 Thread Doug Goldstein
d binary on the host. The tools build system doesn't seem to comprehend host != target. A few people have stepped forward with ideas and said they'd take point on the patches but I haven't seen anything land yet. -- Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH RFC 1/3] automation: install texinfo in debian

2018-05-28 Thread Doug Goldstein
On 5/23/18 5:20 AM, Wei Liu wrote: > Stubdom build requires that. > CentOS & Ubuntu will need the change too. Though in a way I'd almost ask why --enable-docs doesn't need it but stubdoms do? Seems like a weird dep for stubdom... -- Doug

Re: [Xen-devel] XSM in osstest, grub config, outstanding patch

2018-05-28 Thread Doug Goldstein
ast I looked OpenXT has their policy in an external repo and packages it up separately from Xen. Marek can probably answer as to how Qubes does it. So the answer to me is no change has to happen to Grub but Xen should change to just do the right thing and stop installing that file. -- Doug Goldstein

Re: [Xen-devel] XSM in osstest, grub config, outstanding patch

2018-06-01 Thread Doug Goldstein
On 5/29/18 5:28 AM, Ian Jackson wrote: > Doug Goldstein writes ("Re: [Xen-devel] XSM in osstest, grub config, > outstanding patch"): >> So I believe the path forward here was that we'd bake the "default" XSM >> policy into Xen and the user c

Re: [Xen-devel] [PATCH v4 0/10] arm: more kconfig configurability and small default configs

2018-06-01 Thread Doug Goldstein
e we sync a number of drivers over from the Linux kernel tree. It just felt natural to move them out of being hard coded values in the Makefiles and into Kconfig proper so they could be used as Linux uses them. -- Doug Goldstein ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH 0/2] xen/xsm: Cleanup in preparation for XSM SILO mode

2018-06-27 Thread Doug Goldstein
On Tue, Jun 26, 2018 at 07:16:08AM -0600, Jan Beulich wrote: > >>> On 26.06.18 at 14:42, wrote: > > On 26/06/18 13:04, Jan Beulich wrote: > > On 26.06.18 at 13:09, wrote: > >>> Future changes will introduce a new SILO mode, which is intended to be > >>> useful > >>> for cloud and enterprise

Re: [Xen-devel] [PATCH 1/2] xen/xsm: Rename CONFIG_FLASK_* to CONFIG_XSM_FLASK_*

2018-06-27 Thread Doug Goldstein
On Tue, Jun 26, 2018 at 12:09:07PM +0100, Andrew Cooper wrote: > Flask is one single XSM module, and another is about to be introduced. > Properly namespace the symbols for clarity. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-

Re: [Xen-devel] [PATCH 2/2] xen/xsm: Rename CONFIG_XSM_POLICY to CONFIG_XSM_FLASK_POLICY

2018-06-27 Thread Doug Goldstein
On Tue, Jun 26, 2018 at 12:09:08PM +0100, Andrew Cooper wrote: > The embedded policy is specific flask, so update the infrastructure to reflect > this. > > Signed-off-by: Andrew Cooper The subject has a typo 'CONIFIG' -> 'CONFIG', with that fixed: Reviewed-by: Doug Goldstein

Re: [Xen-devel] [PATCH] console: avoid printing no or null time stamps

2018-07-02 Thread Doug Goldstein
On Mon, Jul 02, 2018 at 02:47:42PM +0100, Julien Grall wrote: > On 06/26/2018 10:03 AM, Jan Beulich wrote: > > > > > On 26.06.18 at 10:43, wrote: > > > On 26/06/18 08:24, Jan Beulich wrote: > > > > @@ -698,26 +701,30 @@ static void printk_start_of_line(const c > > > >case TSM_DATE_MS: > >

Re: [Xen-devel] Xen Security Advisory 254 - Information leak via side effects of speculative execution

2018-01-05 Thread Doug Goldstein
d this" and "resolution" as "what updates can I apply". As a result they are misunderstanding here what the net result is. Some clarifications could be that the PVH shim is the resolution for the SP3 issue. However its not a fix for PV itself but instead changes the very nat

Re: [Xen-devel] [PATCH] x86/efi: fix build with linkers that support both coff-x86-64 and pe-x86-64

2018-01-05 Thread Doug Goldstein
ve this by specifying the buildid.o format to pe-x86-64. > > Signed-off-by: Roger Pau Monné <roger@citrix.com> Yes. Please let's do this. Reviewed-by: Doug Goldstein <car...@cardoe.com> Tested-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signatu

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-09 Thread Doug Goldstein
of "this should work" in this thread and other threads but no actual confirmation. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-09 Thread Doug Goldstein
ml [2] https://lists.xenproject.org/archives/html/xen-devel/2018-01/msg00778.html [3] https://lists.xenproject.org/archives/html/xen-devel/2018-01/msg00751.html [4] https://lists.xenproject.org/archives/html/xen-devel/2018-01/msg00736.html -- Doug Goldstein signature.asc Description: OpenPGP digit

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-09 Thread Doug Goldstein
done here? >> >> I'm happy to redirect effort to PVH shim if that's what the solution >> is going to be. >> >> I obviously prefer the HVM approach as it works on a broad range of Xen >> versions >> without modification but I'm keen to get something done qui

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-09 Thread Doug Goldstein
was not the default for 4.0.0. Its certainly possible that's true for Xen 3.4 however. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] sidecar (hvm shim) creation script

2018-01-10 Thread Doug Goldstein
proach if: > > - You want to deploy a fix immediately > - You can't, or would like to avoid, updating to Xen 4.8 or newer > - You can: > - Run a script to modify each domain config > - Afford an extra 80MiB per guest > - Tolerate having an extra QEMU around > - You don't

Re: [Xen-devel] sidecar (hvm shim) creation script

2018-01-10 Thread Doug Goldstein
n version? The system I'm currently dealing with needs to import this code as a Python module so I figured I'd slap a main() and some argparse on it and it should be good. -- Doug Goldstein signature.asc Description: OpenPGP digital signature _

[Xen-devel] [PATCH v2] docs: note default for timer_mode in xl.cfg man

2018-01-15 Thread Doug Goldstein
There was no default documented but the header at xen/include/public/hvm/params.h stated which the default was, so add it to the docs. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Wei Liu <wei.l...@citrix.com> CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Roge

[Xen-devel] [PATCH] xen: append EXTRA_CFLAGS to CFLAGS for expert builds

2018-01-18 Thread Doug Goldstein
Allow a user to supply extra CFLAGS via the EXTRA_CFLAGS environment variable. This is not a configuration that is supported but is only aimed to help support testing and troubleshooting when you need to make changes. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Andrew

Re: [Xen-devel] [PATCH v2] x86/efi: fix build with linkers that support both coff-x86-64 and pe-x86-64

2018-01-18 Thread Doug Goldstein
by specifying the efi/buildid.o format to pe-x86-64. > > Signed-off-by: Roger Pau Monné <roger@citrix.com> > --- Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Description: OpenPGP digital signature __

Re: [Xen-devel] [PATCH v2] docs: note default for timer_mode in xl.cfg man

2018-01-15 Thread Doug Goldstein
On 1/15/18 9:59 AM, Roger Pau Monné wrote: > On Mon, Jan 15, 2018 at 08:45:51AM -0600, Doug Goldstein wrote: >> There was no default documented but the header at >> xen/include/public/hvm/params.h stated which the default was, so add it >> to the docs. > > While looki

[Xen-devel] [PATCH v3 1/2] public/hvm/params.h: fix comment for timer_mode default

2018-01-15 Thread Doug Goldstein
In libxl__domain_build_info_setdefault() in tools/libxl/libxl_create.c the default for timer_mode for HVM and PVH is LIBXL_TIMER_MODE_NO_DELAY_FOR_MISSED_TICKS so adjust the comments in the header to reflect this. --- CC: Wei Liu CC: Ian Jackson

Re: [Xen-devel] Rudolph: merging Vixen and Comet

2018-01-16 Thread Doug Goldstein
fixes people have proposed into the Vixen branch? There are a number of virtualization providers that have rolled forward with Vixen. They are clearly contributing patches on the ML and having one place to work together would be nice. We can always host a fork on GitHub and merge patches there as well if that's

[Xen-devel] [PATCH] docs: note default for timer_mode in xl.cfg man

2018-01-14 Thread Doug Goldstein
There was no default documented but the header at xen/include/public/hvm/params.h stated which the default was, so add it to the docs. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Wei Liu <wei.l...@citrix.com> CC: Ian Jackson <ian.jack...@eu.citrix.com> # George f

Re: [Xen-devel] [PATCH 1/5] x86/idt: Factor out enabling and disabling of ISTs

2018-01-12 Thread Doug Goldstein
coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 2/5] x86/pv: Rename invalidate_shadow_ldt() to pv_destroy_ldt()

2018-01-12 Thread Doug Goldstein
On 1/12/18 12:37 PM, Andrew Cooper wrote: > and move it into pv/descriptor-tables.c beside its GDT counterpart. Reduce > the !in_irq() check from a BUG_ON() to ASSERT(). > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@

Re: [Xen-devel] [PATCH 3/5] x86/pv: Break handle_ldt_mapping_fault() out of handle_gdt_ldt_mapping_fault()

2018-01-12 Thread Doug Goldstein
citrix.com> Obviously a behavior change here but the rationale behind it seems clear to me and well worth doing for the net positive result: Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Description: OpenPGP digital signature

Re: [Xen-devel] [PATCH 4/5] x86/pv: Drop support for paging out the LDT

2018-01-12 Thread Doug Goldstein
> the same time as the GDT frames. > > Finally, leave some asserts around to confirm the expected behaviour of all > the functions playing with PGT_seg_desc_page references. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Makes sense to me and the code looks go

Re: [Xen-devel] Xen Project Spectre/Meltdown FAQ

2018-01-11 Thread Doug Goldstein
by anyone might only apply >> to the context in which the analysis was done. >> >> But the question keeps coming up, so making this clearer is maybe >> sensible. >> >> Best Regards >> Lars Thanks for the improvements Lars. -- Doug Goldstein signature.asc D

[Xen-devel] [PATCH v2] xen: append EXTRA_CFLAGS_XEN_CORE to CFLAGS

2018-02-21 Thread Doug Goldstein
Allow a user to supply extra CFLAGS via the EXTRA_CFLAGS_XEN_CORE environment variable for hypervisor builds. This is not a configuration that is supported but is only aimed to help support testing and troubleshooting when you need to make changes. Signed-off-by: Doug Goldstein <car...@cardoe.

[Xen-devel] [PATCH] xen/tools: support Python 2 and Python 3

2018-02-21 Thread Doug Goldstein
These changes should make it possible to support modern Pythons as well as the oldest Python 2 still supported. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Andrew Cooper <andrew.coop...@citrix.com> CC: George Dunlap <george.dun...@eu.citrix.com> CC: Ian

Re: [Xen-devel] [PATCH] xen/tools: support Python 2 and Python 3

2018-02-22 Thread Doug Goldstein
On 2/22/18 6:54 AM, Andrew Cooper wrote: > On 22/02/18 05:52, Doug Goldstein wrote: >> These changes should make it possible to support modern Pythons as well >> as the oldest Python 2 still supported. >> >> Signed-off-by: Doug Goldstein <car...@cardoe.c

[Xen-devel] [PATCH] README: require Python 2.6 or newer

2018-02-22 Thread Doug Goldstein
Increase the minimum required Python to 2.6 or newer. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Andrew Cooper <andrew.coop...@citrix.com> CC: George Dunlap <george.dun...@eu.citrix.com> CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Jan Beulich <jb

Re: [Xen-devel] [PATCH RFC 00/10] x86 passthrough code cleanup

2018-02-23 Thread Doug Goldstein
y. I can see the real question being why HVM? That I would say lies with the direction of discretionary access controls in Xen vs mandatory access controls. To solve for the lack of functionality we've grown things like "dmops" and I could certainly see a product like Qubes running only P

Re: [Xen-devel] [PATCH v3] tools: detect appropriate debug optimization level

2018-02-23 Thread Doug Goldstein
On 4/28/16 12:40 PM, Wei Liu wrote: > On Tue, Apr 26, 2016 at 09:38:45AM -0500, Doug Goldstein wrote: >> When building debug use -Og as the optimization level if its available, >> otherwise retain the use of -O0. -Og has been added by GCC to enable all >> optimizations that to

Re: [Xen-devel] [PATCH] README: require Python 2.6 or newer

2018-02-23 Thread Doug Goldstein
On 2/23/18 2:55 AM, Jan Beulich wrote: >>>> On 22.02.18 at 20:34, <car...@cardoe.com> wrote: >> Increase the minimum required Python to 2.6 or newer. >> >> Signed-off-by: Doug Goldstein <car...@cardoe.com> > > That's the easy half. Tool stack config

Re: [Xen-devel] [PATCH v6.5 15/26] x86/feature: Definitions for Indirect Branch Controls

2018-01-03 Thread Doug Goldstein
rate bit. s/IPBP/IBPB/ no? Still getting caught up here so I could certainly be wrong. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mail

[Xen-devel] [RFC] expose additional data via sysfs

2018-06-21 Thread Doug Goldstein
From: Doug Goldstein This patch is to start a discussion around exposing additional information via sysfs to the guest to steer us away from xenfs (/proc/xen) which is advertised as deprecated. Currently the initscripts that Xen has check /proc/xen/capabilities for "cont

[Xen-devel] [PATCH v2 3/4] automation: remove dead code from containerize

2018-08-03 Thread Doug Goldstein
This is more dead code. Signed-off-by: Doug Goldstein Reviewed-by: Wei Liu --- automation/scripts/containerize | 5 - 1 file changed, 5 deletions(-) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 7f0eb0a..7bdfc21 100755 --- a/automation/scripts

[Xen-devel] [PATCH v2 0/4] This series improves the containerize script to hopefully make it more

2018-08-03 Thread Doug Goldstein
friendly for folks to use to locally do build tests under different distros. change from v1: - first patch switch to -z as it makes more sense Doug Goldstein (4): automation: standardize containerize env names automation: drop container name from containerize automation: remove dead code

[Xen-devel] [PATCH v2 2/4] automation: drop container name from containerize

2018-08-03 Thread Doug Goldstein
. Signed-off-by: Doug Goldstein Reviewed-by: Wei Liu --- automation/build/README.md | 5 - automation/scripts/containerize | 7 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/automation/build/README.md b/automation/build/README.md index 987533a..bf11317 100644

[Xen-devel] [PATCH v2 1/4] automation: standardize containerize env names

2018-08-03 Thread Doug Goldstein
Standardized all the environment variable names that the containerize script uses to start with CONTAINER_ Signed-off-by: Doug Goldstein --- automation/build/README.md | 10 +- automation/scripts/containerize | 10 -- 2 files changed, 9 insertions(+), 11 deletions(-) diff

[Xen-devel] [PATCH v2 4/4] automation: ensure created are not owned as root

2018-08-03 Thread Doug Goldstein
outside of the container so files are not owned by root. Signed-off-by: Doug Goldstein Reviewed-by: Wei Liu --- automation/scripts/containerize | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 7bdfc21..bf9af58 100755

[Xen-devel] [PATCH 0/2] automation: CentOS 7.x container

2018-07-30 Thread Doug Goldstein
Add a CentOS 7.x container that tracks the latest CentOS 7 release along with the GitLab CI changes to build with it. A test run is available here: https://gitlab.com/cardoe/xen/pipelines/26695770 Doug Goldstein (2): automation: add CentOS 7.x image ci: enable builds with CentOS 7.x .gitlab

[Xen-devel] [PATCH 0/4] This series improves the containerize script to hopefully make it more

2018-07-30 Thread Doug Goldstein
friendly for folks to use to locally do build tests under different distros. Doug Goldstein (4): automation: standardize containerize env names automation: drop container name from containerize automation: remove dead code from containerize automation: ensure created are not owned as root

[Xen-devel] [PATCH 4/4] automation: ensure created are not owned as root

2018-07-28 Thread Doug Goldstein
outside of the container so files are not owned by root. Signed-off-by: Doug Goldstein --- automation/scripts/containerize | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index d17f5ff..7d297d7 100755 --- a/automation/scripts

[Xen-devel] [PATCH 3/4] automation: remove dead code from containerize

2018-07-28 Thread Doug Goldstein
This is more dead code. Signed-off-by: Doug Goldstein --- automation/scripts/containerize | 5 - 1 file changed, 5 deletions(-) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 2cb8021..d17f5ff 100755 --- a/automation/scripts/containerize +++ b

[Xen-devel] [PATCH 2/4] automation: drop container name from containerize

2018-07-28 Thread Doug Goldstein
. Signed-off-by: Doug Goldstein --- automation/build/README.md | 5 - automation/scripts/containerize | 7 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/automation/build/README.md b/automation/build/README.md index 987533a..bf11317 100644 --- a/automation/build/README.md

[Xen-devel] [PATCH 1/4] automation: standardize containerize env names

2018-07-28 Thread Doug Goldstein
Standardized all the environment variable names that the containerize script uses to start with CONTAINER_ Signed-off-by: Doug Goldstein --- automation/build/README.md | 10 +- automation/scripts/containerize | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff

[Xen-devel] [PATCH 2/2] ci: enable builds with CentOS 7.x

2018-07-29 Thread Doug Goldstein
Add the CentOS 7.x images to be used for build testing. Signed-off-by: Doug Goldstein --- .gitlab-ci.yml | 16 1 file changed, 16 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 1b9877b..6328da9 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -39,6 +39,22

[Xen-devel] [PATCH 1/2] automation: add CentOS 7.x image

2018-07-29 Thread Doug Goldstein
This image will always track the latest CentOS 7.x release. Add this container to containerize for easy access. Signed-off-by: Doug Goldstein --- automation/build/centos/7.dockerfile | 49 +- automation/scripts/containerize | 1 +- 2 files changed, 50

[Xen-devel] [PATCH] build: remove tboot make targets

2018-08-18 Thread Doug Goldstein
The tboot targets are woefully out of date. These should really be retired because setting up tboot is more complex than the build process for it. Signed-off-by: Doug Goldstein --- Everyone knows my feeling about the Xen build system being a meta-distro builder. This just removes something

Re: [Xen-devel] [PATCH] tools: fix uninstall: tests/x86_emulator, Linux hotplug

2018-08-20 Thread Doug Goldstein
ug uninstall returns success but doesn't actually remove what > it installed. The Makefile variables are obfuscating incorrect logic, so > strip them out and match existing code for xen-watchdog which does work. > > Signed-off-by: Christopher Clark Reviewed-by: Doug Goldstein ___

Re: [Xen-devel] [PATCH v2] automation: enable building rombios with clang

2018-08-24 Thread Doug Goldstein
On Fri, Aug 24, 2018 at 04:22:47PM +0100, Wei Liu wrote: > Previously it is disabled because the embedded ipxe can't be built > with clang. Now that ipxe is split out we can use --with-system-ipxe > to work around the issue. > > Signed-off-by: Wei Liu > --- > +# iPXE cannot be built with

Re: [Xen-devel] [PATCH] rombios: work around clang's -Waddress-of-packed-member

2018-08-24 Thread Doug Goldstein
f-packed-member] > ®s->u.r32.edx); >^~~ > > Work around that by using an intermediate variable. > > Signed-off-by: Wei Liu Reviewed-by: Doug Goldstein _

Re: [Xen-devel] [PATCH v2] automation: enable building rombios with clang

2018-08-25 Thread Doug Goldstein
On Fri, Aug 24, 2018 at 04:34:35PM +0100, Wei Liu wrote: > On Fri, Aug 24, 2018 at 10:32:24AM -0500, Doug Goldstein wrote: > > On Fri, Aug 24, 2018 at 04:22:47PM +0100, Wei Liu wrote: > > > Previously it is disabled because the embedded ipxe can't be built > > > with cl

Re: [Xen-devel] [PATCH] build: remove tboot make targets

2018-08-27 Thread Doug Goldstein
On Mon, Aug 20, 2018 at 02:33:10AM -0600, Jan Beulich wrote: > >>> On 19.08.18 at 04:22, wrote: > > The tboot targets are woefully out of date. These should really be > > retired because setting up tboot is more complex than the build process > > for it. > >

Re: [Xen-devel] [PATCH] automation: enable building rombios with clang

2018-07-17 Thread Doug Goldstein
On Tue, Jul 17, 2018 at 09:39:35AM +0100, Wei Liu wrote: > Previously it is disabled because the embedded ipxe can't be built > with clang. Now that ipxe is split out we can use --with-system-ipxe > to work around the issue. > > Signed-off-by: Wei Liu > --- > Depends on the ipxe series just

Re: [Xen-devel] [PATCH] x86: report use of PCID together with reporting XPTI status

2018-07-17 Thread Doug Goldstein
t;with: %s" and do xpti_pcid_enabled ? "PCID" : "" if you do. If not then this seems like a good addition to me and is definitely welcome to folks wanting to know if they're using PCID. Reviewed-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] automation: add SLES 11 SP4 dockerfile

2018-07-17 Thread Doug Goldstein
On Tue, Jul 17, 2018 at 09:03:05PM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Awesome work Wei. Thanks for taking the time and effort to get this done. I'll defer to Jan to confirm that this will hopefully be an effective stand in but you've got my Reviewed-by: Doug Goldst

Re: [Xen-devel] [PATCH] automation: introduce a script for build test

2018-07-24 Thread Doug Goldstein
On Tue, Jul 24, 2018 at 05:56:51PM +0100, Wei Liu wrote: > Signed-off-by: Ian Jackson > Signed-off-by: Wei Liu > --- > This is a script I wrote previously for build test. Goal here is to bisect a series to find the build failure? We could allow git bisect to do the work and just build and

Re: [Xen-devel] [PATCH] xen: correct DEFCONFIG_LIST Kconfig item

2018-07-25 Thread Doug Goldstein
FCONFIG item, not the string "$ARCH_DEFCONFIG". > > > > Makse sense and matches Linux, but I'd still prefer to have Doug's > > consent here. > > Ping? > Apologies. I've checked and the patch is correct. Reviewed-by: Doug Goldstein _

Re: [Xen-devel] [PATCH v6] automation: introduce a script for build test

2018-07-25 Thread Doug Goldstein
ake -j4 maybe some comment in the code like "hey someone reading me this is the default command" Overall I think this is a good addition to the tree. If people feel different than I do about the default command then feel free to commit with my: Reviewed-by: Doug Goldstein -- Doug _

Re: [Xen-devel] [PATCH] automation: build with 32 bit stretch

2018-07-25 Thread Doug Goldstein
On Mon, Jul 23, 2018 at 09:04:46AM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/2] automation: add debian unstable images

2018-07-25 Thread Doug Goldstein
On Mon, Jul 23, 2018 at 05:57:34PM +0100, Wei Liu wrote: > This will get us the latest toolchain available in Debian. > > Signed-off-by: Wei Liu Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.

Re: [Xen-devel] [PATCH 2/2] automation: build with debian unstable

2018-07-25 Thread Doug Goldstein
On Mon, Jul 23, 2018 at 05:57:35PM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu While this is good and provisionally I would say: Acked-by: Doug Goldstein I'd like us to hold off on committing this until other changes land to fix the build issues that are currently happening on Deb

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Doug Goldstein
On Tue, Jul 24, 2018 at 04:04:05AM -0600, Jan Beulich wrote: > >>> On 24.07.18 at 11:43, wrote: > > On Tue, Jul 24, 2018 at 03:34:51AM -0600, Jan Beulich wrote: > >> >>> On 24.07.18 at 11:24, wrote: > >> > On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: > >> >> >>> On 23.07.18 at

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Doug Goldstein
On Tue, Jul 24, 2018 at 03:32:09PM +0100, George Dunlap wrote: > On 07/24/2018 10:34 AM, Jan Beulich wrote: > On 24.07.18 at 11:24, wrote: > >> On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: > >> On 23.07.18 at 18:40, wrote: > # How does this impact me? > The

Re: [Xen-devel] [PATCH] automation: specify -j$(nproc) in build script

2018-09-06 Thread Doug Goldstein
73..c463b060d4 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -30,4 +30,4 @@ fi > > ./configure "${cfgargs[@]}" > > -make dist > +make -j$(nproc) dist > -- > 2.11.0 > Acked-by: Doug Goldstein _

Re: [Xen-devel] [Notes for xen summit 2018 design session] Process changes: is the 6 monthly release Cadence too short, Security Process, ...

2018-07-05 Thread Doug Goldstein
On Mon, Jul 02, 2018 at 06:03:39PM +, Lars Kurth wrote: > ### Security Process > *Batches and timing:* Everyone present, felt that informal batching is good > (exception Doug G), fwiw, I don't dislike the batching. I just complained when there's a lot of items in the batch. We attempt to

Re: [Xen-devel] [Notes for xen summit 2018 design session] Process changes: is the 6 monthly release Cadence too short, Security Process, ...

2018-07-05 Thread Doug Goldstein
On Thu, Jul 05, 2018 at 12:16:09PM +0100, Ian Jackson wrote: > Juergen Gross writes ("Re: [Xen-devel] [Notes for xen summit 2018 design > session] Process changes: is the 6 monthly release Cadence too short, > Security Process, ..."): > > We didn't look at the sporadic failing tests thoroughly

Re: [Xen-devel] [Notes for xen summit 2018 design session] Process changes: is the 6 monthly release Cadence too short, Security Process, ...

2018-07-05 Thread Doug Goldstein
On Tue, Jul 03, 2018 at 12:47:14PM +0200, Juergen Gross wrote: > On 03/07/18 12:23, Lars Kurth wrote: > > Combined reply to Jan and Roger > > Lars > > > > On 03/07/2018, 11:07, "Roger Pau Monne" wrote: > > > > On Mon, Jul 02, 2018 at 06:03:39PM +, Lars Kurth wrote: > > > We then

Re: [Xen-devel] [Notes for xen summit 2018 design session] Process changes: is the 6 monthly release Cadence too short, Security Process, ...

2018-07-05 Thread Doug Goldstein
On Thu, Jul 05, 2018 at 11:39:51AM +, George Dunlap wrote: > > > > On Jul 5, 2018, at 12:16 PM, Ian Jackson wrote: > > > > Juergen Gross writes ("Re: [Xen-devel] [Notes for xen summit 2018 design > > session] Process changes: is the 6 monthly release Cadence too short, > > Security

Re: [Xen-devel] [Notes for xen summit 2018 design session] Process changes: is the 6 monthly release Cadence too short, Security Process, ...

2018-07-05 Thread Doug Goldstein
On Thu, Jul 05, 2018 at 06:51:16PM +, George Dunlap wrote: > > > >> Again, there was a sense that some of the issues we are seeing could be > >> solved if we had better > >> CI capability: in other words, some of the issues we were seeing could be > >> resolved by > >> * Better CI

Re: [Xen-devel] [PATCH RFC 07/15] xen/arm: increase MAX_MODULES

2018-07-05 Thread Doug Goldstein
off-by: Stefano Stabellini Reviewed-by: Doug Goldstein Didn't see any comment on this so far so I figured I'd comment. This is probably the least controversial patch and could just go in today. ___ Xen-devel mailing list Xen-devel@lists.xenpr

Re: [Xen-devel] [PATCH 01/13] libx86: Introduce libx86/cpuid.h

2018-07-05 Thread Doug Goldstein
On Wed, Jul 04, 2018 at 07:57:30AM -0600, Jan Beulich wrote: > >>> On 04.07.18 at 14:03, wrote: > > On 04/07/18 09:21, Jan Beulich wrote: > > On 03.07.18 at 22:55, wrote: > >>> --- a/tools/include/Makefile > >>> +++ b/tools/include/Makefile > >>> @@ -21,6 +21,9 @@ xen/.dir: > >>> ln -sf

Re: [Xen-devel] [Notes for xen summit 2018 design session] Process changes: is the 6 monthly release Cadence too short, Security Process, ...

2018-07-05 Thread Doug Goldstein
On Thu, Jul 05, 2018 at 02:02:33PM -0500, Doug Goldstein wrote: > On Thu, Jul 05, 2018 at 06:51:16PM +, George Dunlap wrote: > > > > > >> Again, there was a sense that some of the issues we are seeing could be > > >> solved if we had better > &

Re: [Xen-devel] [PATCH] automation: fix builds with clang

2018-07-10 Thread Doug Goldstein
On Tue, Jul 10, 2018 at 05:58:58PM -0500, Doug Goldstein wrote: Without this patch: https://gitlab.com/xen-project/xen/pipelines/25489605 With this patch: https://gitlab.com/cardoe/xen/pipelines/25512404 ___ Xen-devel mailing list Xen-devel

[Xen-devel] [PATCH] automation: fix builds with clang

2018-07-10 Thread Doug Goldstein
the build of the stubdoms depends on the build of newlib which does not support being built with clang. Signed-off-by: Doug Goldstein --- automation/scripts/build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/automation/scripts/build b/automation/scripts/build index b9e4c1e329

Re: [Xen-devel] [PATCH RFC 2/3] automation: build stubdom and rombios, and tools on 32 bit

2018-07-06 Thread Doug Goldstein
On Wed, May 30, 2018 at 12:28:24AM +0100, Wei Liu wrote: > On Tue, May 29, 2018 at 12:18:40AM -0500, Doug Goldstein wrote: > > On 5/23/18 5:20 AM, Wei Liu wrote: > > > > > > > > # SeaBIOS cannot be built with clang > > > @@ -20,12 +18,6 @@ if [[ &quo

Re: [Xen-devel] [Notes for xen summit 2018 design session] Process changes: is the 6 monthly release Cadence too short, Security Process, ...

2018-07-06 Thread Doug Goldstein
On Fri, Jul 06, 2018 at 02:32:16AM -0600, Jan Beulich wrote: > >>> On 05.07.18 at 20:13, wrote: > > On Thu, Jul 05, 2018 at 12:16:09PM +0100, Ian Jackson wrote: > >> Juergen Gross writes ("Re: [Xen-devel] [Notes for xen summit 2018 design > > session] Process changes: is the 6 monthly release

Re: [Xen-devel] [PATCH] automation/build: update stretck-i386 dockerfile

2018-07-12 Thread Doug Goldstein
is up to > date > *** Launching container ... > /usr/bin/git: /usr/bin/git: cannot execute binary file > > While at it, use shorthand "linux32". > > Signed-off-by: Wei Liu > --- Acked-by: Doug Goldstein ___ Xen-devel maili

Re: [Xen-devel] [PATCH] automation/build: update stretck-i386 dockerfile

2018-07-12 Thread Doug Goldstein
On Thu, Jul 12, 2018 at 02:33:42PM -0500, Doug Goldstein wrote: > On Thu, Jul 12, 2018 at 05:31:27PM +0100, Wei Liu wrote: > > We don't need to specify /bin/bash in the entry point rune, otherwise > > non-interactive invocation of the container would fail with something > &g

Re: [Xen-devel] [PATCH] automation/build: build ovmf

2018-07-12 Thread Doug Goldstein
On Wed, Jul 11, 2018 at 02:16:16PM +0100, Wei Liu wrote: > Install nasm and build ovmf with gcc on x86. > > Signed-off-by: Wei Liu > --- Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xe

[Xen-devel] [PATCH] scripts: add helper script to use Docker containers

2018-07-12 Thread Doug Goldstein
within a Debian Stretch container at the top level of the source tree. Signed-off-by: Doug Goldstein --- A few folks have asked about this so I'm CCing folks directly. I'm completely game for changing anything that makes this easier for folks to use. This is primarily geared as a developer/maintainer

[Xen-devel] [PATCH] stubdom: disable newlib's need for texinfo

2018-07-09 Thread Doug Goldstein
of something that's thrown away. Instead of adding it as a requirement this patches out the code path in newlib that uses it so that the files are never generated. Signed-off-by: Doug Goldstein --- stubdom/Makefile | 1 + stubdom/newlib-disable-texinfo.patch | 13 + 2

Re: [Xen-devel] [PATCH v2 1/4] automation: install texinfo

2018-07-09 Thread Doug Goldstein
On Mon, Jul 09, 2018 at 04:32:13PM +0100, Wei Liu wrote: > Stubdom's dependency newlib needs it. > > Signed-off-by: Wei Liu Could we consider <20180709170546.4102-1-car...@cardoe.com> instead? https://lists.xenproject.org/archives/html/xen-devel/2018-07/msg00810.html

Re: [Xen-devel] [PATCH v2 3/4] automation: introduce stretch-i386.dockerfile

2018-07-09 Thread Doug Goldstein
; +++ b/automation/build/debian/stretch-i386.dockerfile > +texinfo \ If https://lists.xenproject.org/archives/html/xen-devel/2018-07/msg00810.html gets accepted then we need to drop this. Otherwise looks good. Reviewed-by: Doug Goldstein ___

Re: [Xen-devel] [PATCH v2 2/4] automation: install some packages for CentOS from EPEL

2018-07-09 Thread Doug Goldstein
COPY CentOS-7.2.repo /etc/yum.repos.d/CentOS-Base.repo > > +# install EPEL for dev86, xz-devel and possibly other packages > +RUN yum -y install > https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm "&& yum clean all" to keep the layer size down With th

Re: [Xen-devel] [PATCH v2 4/4] automation: build more stuff on x86 with docker

2018-07-09 Thread Doug Goldstein
On Mon, Jul 09, 2018 at 04:32:16PM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > Untested > --- Reviewed-by: Doug Goldstein I'll test this once we hammer out if we're pulling in texinfo or not. ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH v2 1/2] README: require Python 2.4 or newer

2018-02-28 Thread Doug Goldstein
On 2/28/18 1:18 PM, Doug Goldstein wrote: > change from v1: > - changed from Python 2.6 to Python 2.4 based on Not sure what happened to my mind here based on feedback on the list of folks still having environments where Python 2.4 is in use. -- Doug Goldstein signature.asc Descr

[Xen-devel] [PATCH v2 2/2] xen/tools: support Python 2 and Python 3

2018-02-28 Thread Doug Goldstein
These changes should make it possible to support modern Pythons as well as the oldest Python 2 still supported. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Andrew Cooper <andrew.coop...@citrix.com> CC: George Dunlap <george.dun...@eu.citrix.com> CC: Ian

[Xen-devel] [PATCH v2 1/2] README: require Python 2.4 or newer

2018-02-28 Thread Doug Goldstein
Increase the minimum required Python to 2.4 or newer. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Andrew Cooper <andrew.coop...@citrix.com> CC: George Dunlap <george.dun...@eu.citrix.com> CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Jan Beulich <jb

[Xen-devel] [PATCH v4] tools: detect appropriate debug optimization level

2018-03-12 Thread Doug Goldstein
When building debug use -Og as the optimization level if its available, otherwise retain the use of -O0. -Og has been added by GCC to enable all optimizations that to not affect debugging while retaining full debugability. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- tools/Rules.

[Xen-devel] [RFC PATCH 1/6] ci: add Dockerfile for CentOS 7.2

2018-03-12 Thread Doug Goldstein
Added a Dockerfile which captures all the necessary dependencies to build Xen on a CentOS 7.2 system. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- extras/testing/centos/CentOS-7.2.repo | 35 - extras/testing/centos/Dockerfile.7.2

[Xen-devel] [RFC PATCH 2/6] ci: add Dockerfile for Ubuntu 14.04

2018-03-12 Thread Doug Goldstein
Added a Dockerfile which captures all the necessary dependencies to build Xen on a Ubuntu 14.04 system. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- extras/testing/ubuntu/Dockerfile.trusty | 21 + 1 file changed, 21 insertions(+) create mode 100644 extras/t

[Xen-devel] [RFC PATCH 4/6] ci: add Dockerfile for Debian jessie

2018-03-12 Thread Doug Goldstein
Added a Dockerfile which captures all the necessary dependencies to build Xen on a Debian jessie system. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- extras/testing/debian/Dockerfile.jessie | 21 + 1 file changed, 21 insertions(+) create mode 100644 extras/t

[Xen-devel] [RFC PATCH 6/6] ci: add a README about the containers

2018-03-12 Thread Doug Goldstein
Add a basic README explaining the containers and how people can use them to locally test with if they see an error in CI and want to reproduce it locally. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- extras/testing/README.md | 29 + 1 file chang

[Xen-devel] [RFC PATCH 5/6] ci: add cfg to use GitLab CI to build

2018-03-12 Thread Doug Goldstein
Added a GitLab CI config which has a lot more flexibility to allow us to test a lot more distro configurations than Travis can and even build test on FreeBSD. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- .gitlab-ci.yml | 34 ++ 1 file chang

[Xen-devel] [RFC PATCH 3/6] ci: add Dockerfile for Ubuntu 16.04

2018-03-12 Thread Doug Goldstein
Added a Dockerfile which captures all the necessary dependencies to build Xen on a Ubuntu 16.04 system. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- extras/testing/ubuntu/Dockerfile.xenial | 21 + 1 file changed, 21 insertions(+) create mode 100644 extras/t

  1   2   3   >