It claimed to have a default db name, but it didn't. Rework the
option parsing to make the usage message true. (That saves me typing
sa-init-db standalone
and getting bizarre errors as sqlite tries to treat the shell script
`standalone' as if it were a database file.)
Signed-off-by: Ian
Andra Paraschiv writes ("[PATCH RESEND qemu-xen-traditional] xen/pt: allow QEMU
to request MSI unmasking at bind time"):
> When a MSI interrupt is bound to a guest using
> xc_domain_update_msi_irq (XEN_DOMCTL_bind_pt_irq) the interrupt is
> left masked by default.
Applied, and pushed the
esource, );
> +if (r < 0) {
> +LOGE(ERROR, "Setting rlimit %d to %lld failed\n",
> + rlimits[i].resource,
> + (unsigned long long)rlimits[i].limit);
I think you mean %llu not %lld. With that la
George Dunlap writes ("Re: [PATCH 5/5] RFC: test/depriv: Add a tool to check
process-level depriv"):
> FYI I do agree with all of those suggestions (both `set -e` and having
> functions to handle failure in a consistent way); but I didn't want to
> fix everything up in bash only to have to write
George Dunlap writes ("[PATCH 1/5] docs/qemu-deprivilege: Revise and update
with status and future plans"):
> docs/qemu-deprivilege.txt had some basic instructions for using
> dm_restrict, but it was incomplete, misleading, and stale.
Thanks for the updates to the unshare stuff.
> +### Device
George Dunlap writes ("[PATCH 5/5] RFC: test/depriv: Add a tool to check
process-level depriv"):
> Add a tool to check whether the various process-level deprivileging
> operations have actually taken place on the process.
...
> NB that a number of other requested changes (such as using `set -e`,
George Dunlap writes ("Re: [PATCH 5/5] RFC: test/depriv: Add a tool to check
process-level depriv"):
> Oh, actually, 65534 is "nogroup", which is the default when you don't
> add a specific group.
>
> Should we recommend creating a separate group for the Xen qemus in our
> feature doc? Or
Julien Grall writes ("Re: [PATCH v8 3/8] libxl: support mapping static shared
memory areas during domain creation"):
> On 10/30/18 3:36 PM, Ian Jackson wrote:
> > This cache policy stuff is odd. I couldn't see it being used by the
> > hypervisor. Why is it eve
Julien Grall writes ("Re: [PATCH v8 7/8] xen/arm: export shared memory regions
as reserved-memory on device tree"):
> On 10/30/18 3:58 PM, Ian Jackson wrote:
> > But it's not documented.
>
> Device-Tree bindings are documented in
> linux/Document/device-tree/bindings
to ftp.uk.debian.org (and rely for caching on the squid cache
which we have for non-apt stuff already). That works well enough for
stable suites, at least.
Signed-off-by: Ian Jackson
---
production-config-cambridge | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git
Christian Lindig writes ("[PATCH 1/1] tools/ocaml: Re-introduce
Xenctrl.with_intf wrapper"):
> Commit 81946a73dc975a7dafe9017a8e61d1e64fdbedbf removed
> Xenctrl.with_intf based on its undesirable behaviour of opening and
> closing a Xenctrl connection with every invocation. This commit
>
I'm going to reply to this email twice. This email is about what seem
to be the noncontentious issues: everything *except* the requirement
in my document that the board is supported by Debian -backports
kernels, at least.
Julien Grall writes ("Re: [OSSTEST PATCH] README.hardware-acquisition"):
I'm going to reply to this email twice. This email is about the
requirement in my document that the board is supported by Debian
-backports kernels, at least.
I'm replying to two mail@: first Julien's; then Stefano's.
Julien Grall writes ("Re: [OSSTEST PATCH] README.hardware-acquisition"):
>
Christian Lindig writes ("Re: [PATCH v2 1/1] tools/ocaml: Re-introduce
Xenctrl.with_intf wrapper [and 1 more messages]"):
> On 31/10/18 15:41, Ian Jackson wrote:
> > this needs a stronger warning against anyone ever calling it, or a
> > clearer explanation of the consque
Christian Lindig writes ("Re: [PATCH v2 1/1] tools/ocaml: Re-introduce
Xenctrl.with_intf wrapper [and 1 more messages]"):
> On 31/10/18 16:01, Ian Jackson wrote:
> > IMO the bug is that spong calls close_handle which has a distant
> > destructive action, without being abl
otivation of re-introducing with_intf is that otherwise
> clients will have to implement this functionality individually.
Thanks.
Reviewed-by: Ian Jackson
I will apply this patch and your other one.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.
Stefano Stabellini writes ("Re: [OSSTEST PATCH] README.hardware-acquisition
[and 1 more messages]"):
> I am suggesting to use Debian for the installer and rootfs, but to use a
> different kernel for it.
osstest already knows how to do that in principle, because it knows
how to insert a Debian
Marek Marczykowski-Górecki writes ("Re: [RFC PATCH v2 00/17] Add support for
qemu-xen runnning in a Linux-based stubdomain."):
> All the xenconsoled stuff is unchanged (and unlikely to change), so it
> should be safe to review it. Patches 06 and 07 also shouldn't change.
Sorry, I missed this
(CCing Stefano's new address.)
Marek Marczykowski-Górecki writes ("[RFC PATCH v2 06/17] libxl: create vkb
device only for guests with graphics output"):
> The forced vkb device is meant for better performance of qemu access
> (at least according to ebbd2561b4cefb299f0f68a88b2788504223de18
Andrew Cooper writes ("Re: [OSSTEST PATCH 2/2] mfi-common: Enable livepatch
tests in 4.10 and 4.11 as intended (!)"):
> On 01/11/18 15:53, Ian Jackson wrote:
> > The pattern xen-4.1* matches xen-4.10-testing, xen-4.11-testing, etc.
> > The right approach is to state
New document-cum-checklist, for helping with hardware procurement.
Signed-off-by: Ian Jackson
CC: in...@xenproject.org
CC: George Dunlap
CC: Stefano Stabellini
CC: Julien Grall https://lists.xenproject.org/mailman/listinfo/xen-devel
Marek Marczykowski-Górecki writes ("[RFC PATCH v2 07/17] libxl: add
save/restore support for qemu-xen in stubdomain"):
> Rely on a wrapper script in stubdomain to attach FD 3/4 of qemu to
> relevant consoles.
...
> if (state->saved_state) {
> -/* This file descriptor is meant to be
):
runvar removed: enable_livepatch=true
in jobs:build-amd64-prev build-i386-prev
in branches:xen-4.8-testing xen-4.9-testing xen-unstable
Signed-off-by: Ian Jackson
CC: Konrad Rzeszutek Wilk
CC: Andrew Cooper
---
mfi-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion
: enable_livepatch=true in build-ARCH, build-ARCH-xsm
* all of the above in branches: xen-4.10-testing xen-4.11-testing
Signed-off-by: Ian Jackson
CC: Konrad Rzeszutek Wilk
CC: Andrew Cooper
---
mfi-common | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/mfi-common b/mfi
Julien Grall writes ("Re: [PATCH v8 6/8] docs: documentation about static
shared memory regions"):
> On 10/30/18 6:58 PM, Stefano Stabellini wrote:
> > I completely agree with you here, and getting rid of the master/slave
> > terminology would be nice, in retrospect, it was not a good choice. But
Rather than running `rm -rf` on the directory before creating it
> (since there is no library function to do this), simply rmdir the
> directory, relying on the fact that the previous QEMU instance, if
> properly restricted, shouldn't have been able to write anyt
htly prefer
+if (r) {
unshare is supposed to return -1 or 0 so this should make no
difference. If it does something else we should not carry on. It's
unlikely enough that I don't mind it printing a garbage errno value in
that case.
Anyway,
Acked-by: Ian Jackson
ass
Stefano Stabellini writes ("[PATCH v8 6/8] docs: documentation about static
shared memory regions"):
> Author: Zhongze Liu
>
> Add docs to document the motivation, usage, use cases and other
> relevant information about the static shared memory feature.
>
> This is for the proposal "Allow
Stefano Stabellini writes ("[PATCH v8 2/8] libxl: introduce a new structure to
represent static shared memory regions"):
> From: Zhongze Liu
>
> Author: Zhongze Liu
>
> Add a new structure to the IDL family to represent static shared memory
> regions
> as proposed in the proposal "Allow
Stefano Stabellini writes ("[PATCH v8 4/8] libxl: support unmapping static
shared memory areas during domain destruction"):
> Add libxl__sshm_del to unmap static shared memory areas mapped by
> libxl__sshm_add during domain creation. The unmapping process is:
This whole part should be in a
Stefano Stabellini writes ("[PATCH v8 3/8] libxl: support mapping static shared
memory areas during domain creation"):
> +_hidden
> +bool libxl__arch_domain_support_sshm(const libxl_domain_build_info *b_info);
> +
> +_hidden
> +int libxl__arch_domain_sshm_cachepolicy_setdefault(libxl_static_shm
Christian Lindig writes ("Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce
Xenctrl.with_intf wrapper"):
> You are right - close_handle should set the handle to None in addition.
>
> > For that matter, why is close_handle needed at all ?
>
> I mostly added it for symmetry and it is needed
Christian Lindig writes ("[Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce
Xenctrl.with_intf wrapper"):
> Commit 81946a73dc975a7dafe9017a8e61d1e64fdbedbf removed
> Xenctrl.with_intf based on its undesirable behaviour of opening and
> closing a Xenctrl connection with every invocation. This
Wei Liu writes ("Re: [PATCH] libxl: libxl__ev_fd_callback: Document
perhaps-no-retry semantics"):
> On Mon, Oct 15, 2018 at 03:01:07PM +0100, Ian Jackson wrote:
> > Signed-off-by: Ian Jackson
> > CC: Anthony PERARD
>
> I think you understand the event machine
New document-cum-checklist, for helping with hardware procurement.
Signed-off-by: Ian Jackson
CC: in...@xenproject.org
---
README.hardware-acquisition | 310
1 file changed, 310 insertions(+)
create mode 100644 README.hardware-acquisition
diff
Stefano Stabellini writes ("[PATCH v8 7/8] xen/arm: export shared memory
regions as reserved-memory on device tree"):
> Shared memory regions need to be advertised to the guest. Fortunately, a
> device tree binding for special memory regions already exist:
> reserved-memory.
Oh! Here is the
Christian Lindig writes ("[Xen-devel] [PATCH 1/1] tools/ocaml: make type of
Xsraw.sync more precise"):
> The type of Xsraw.sync is made more precise:
>
> from val sync : (Xenbus.Xb.t -> 'a) -> con -> string
> to val sync : (Xenbus.Xb.t -> unit) -> con -> string
>
> The first argument is
Signed-off-by: Ian Jackson
---
cr-for-branches | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cr-for-branches b/cr-for-branches
index f7e4caea..2e9717e0 100755
--- a/cr-for-branches
+++ b/cr-for-branches
@@ -31,7 +31,7 @@ scriptoptions="$1"; shift
LOGF
Christian Lindig writes ("Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of
Xsraw.sync more precise"):
> > On 30 Oct 2018, at 16:50, Ian Jackson wrote:
> > I'm not much of an ocaml programmer but this seems like it has no
> > overall functional change ?
&g
Christian Lindig writes ("Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce
Xenctrl.with_intf wrapper"):
> I agree that it would not harm but conceptually I believe you
> should manage this explicitly using interface_{open/close} or implicitly
> using with_intf. I would use an exit handler
Anthony PERARD writes ("Re: [PATCH v5 03/15] libxl_qmp: Implement fd callback
and read data [and 1 more messages]"):
> On Mon, Oct 29, 2018 at 05:31:59PM +, Ian Jackson wrote:
> > To be honest this condition is a bit fiddly. Why not do this after
> > subtracting b
Stefano Stabellini writes ("Re: [OSSTEST PATCH] README.hardware-acquisition
[and 1 more messages] [and 2 more messages] [and 2 more messages]"):
> Basically, you are saying that even if had a well maintained deb
> repository of kernel packages for OSSTest to use, doesn't matter how we
> achieve
Julien Grall writes ("Re: [OSSTEST PATCH] README.hardware-acquisition [and 1
more messages] [and 2 more messages] [and 2 more messages]"):
> AFAICT, Ian's main concern was adding yet another dependency on external
> entity.
We could put the .deb repository on xenbits.
There remains the question
Wei Liu writes ("[PATCH v2] libxl/arm: fix guest type conversion"):
> Commit 359970fd8b ("tools/libxl: Switch Arm guest type to PVH") missed
> changing the type field in c_info. This issue didn't surface until
> ef72c93df9 which made creating PV guest on Arm unusable.
...
> +#if defined(__arm__)
Stefano Stabellini writes ("Re: [Xen-devel] [OSSTEST PATCH]
README.hardware-acquisition"):
> FYI I have been talking with Ian about sending Xilinx MPSoC boards to
> the COLO for OSSTests usage for a while now. Ian wrote that he would
> send "a checklist for OSSTests hardware". When I saw this
on Arm unusable.
>
> Create libxl__arch_domain_create_info_setdefault and switch the type
> there.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
K. That's perhaps less work overall at our end anyway. Let me know
if you think any aspect of this is getting stuck somehow; I have
contacts in Debian which I could use to enquire or whatever.
> On Thu, 1 Nov 2018, Ian Jackson wrote:
> > The prerequisite is obviously an appropriate cross
Marek Marczykowski-Górecki writes ("Re: [RFC PATCH v2 13/17] xenconsoled: add
support for up to 3 secondary consoles"):
> On Thu, Nov 01, 2018 at 05:31:18PM +, Ian Jackson wrote:
> > I'm confused. I thought we already had support for multiple PV
> > consoles. Is the
Julien Grall writes ("Re: [OSSTEST PATCH] README.hardware-acquisition [and 1
more messages] [and 2 more messages] [and 2 more messages]"):
> On 02/11/2018 15:05, Ian Jackson wrote:
> > I guess that's probably tolerable. We'd have to think about whether
> > we should
George Dunlap writes ("Re: [PATCH v8 6/8] docs: documentation about static
shared memory regions"):
> > On Oct 31, 2018, at 3:35 PM, Stefano Stabellini
> > wrote:
> > On Wed, 31 Oct 2018, Ian Jackson wrote:
> >> But we need to know what the
This is an integer type, not a pointer.
Signed-off-by: Ian Jackson
---
tools/libvchan/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libvchan/init.c b/tools/libvchan/init.c
index ba5a6eb29e..180833dc2f 100644
--- a/tools/libvchan/init.c
+++ b/tools/libvchan
* Promise that we will set errno to ENOENT if the server is not
yet set up.
* Arrange that all ENOENT returns other than from the read of ring-ref
are turned into EIO, logging when we do so.
Signed-off-by: Ian Jackson
---
tools/libvchan/init.c| 11 ++-
tools/libvchan
Signed-off-by: Ian Jackson
---
tools/xenstore/include/xenstore.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xenstore/include/xenstore.h
b/tools/xenstore/include/xenstore.h
index 064b62c455..889dc23863 100644
--- a/tools/xenstore/include/xenstore.h
+++ b/tools
We are going to add a call to xtl_log.
Signed-off-by: Ian Jackson
---
tools/libvchan/Makefile | 6 +++---
tools/libvchan/xenvchan.pc.in | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/libvchan/Makefile b/tools/libvchan/Makefile
index de9b44978f..c236a0f9e6
* Abolish fail_xs_open which is now exactly the same as fail.
* Change all gotos to refer to fail instead.
No functional change.
Signed-off-by: Ian Jackson
---
tools/libvchan/init.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tools/libvchan/init.c b/tools
No functional change.
Signed-off-by: Ian Jackson
---
tools/libvchan/init.c | 50 ++
1 file changed, 26 insertions(+), 24 deletions(-)
diff --git a/tools/libvchan/init.c b/tools/libvchan/init.c
index f099765a38..d987acd338 100644
--- a/tools
Thse functiosn do in fact leave errno set. We are going to want to
use this.
Signed-off-by: Ian Jackson
---
tools/libvchan/libxenvchan.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/libvchan/libxenvchan.h b/tools/libvchan/libxenvchan.h
index d6010b145d
Mostly internal tidying, but also an API promise about what ENOENT
means from libxenvchan_client_init.
Ian Jackson (8):
tools/libvchan: Initialise xs_transaction_t to XBT_NULL, not NULL
tools/xenstore: Document that xs_close(0) is OK.
tools/libvchan: init_xs_srv: Simplify error handling (1
Julien Grall writes ("Re: [PATCH v3] devicetree,xen: add xen,shared-memory
binding"):
> On 11/1/18 8:40 PM, Stefano Stabellini wrote:
> > From the DT binding point of view, it would be fine. Conceptually it
> > would also be fine. However, I doubt that the current libxl
> > implementation would
Julien Grall writes ("Re: [OSSTEST PATCH] README.hardware-acquisition [and 1
more messages] [and 2 more messages] [and 2 more messages]"):
> On 02/11/2018 15:44, Ian Jackson wrote:
> > We have more x86 capacity and are deploying some dedicated build
> > hosts. But
Marek Marczykowski-Górecki writes ("Re: [RFC PATCH v2 00/17] Add support for
qemu-xen runnning in a Linux-based stubdomain."):
> Doing it in this order would be susceptible to a race condition -
> server appearing after libxenvchan_client_init check, but before libxl
> register the watch.
I see
.
No overall functional change: xs_close is the same as xs_daemon_close;
and it and free are now sometimes called on NULL, but those are no-ops.
Signed-off-by: Ian Jackson
---
tools/libvchan/init.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/libvchan/init.c b/tools
Marek Marczykowski-Górecki writes ("[RFC PATCH v2 11/17] xenconsoled: add
support for consoles using 'state' xenstore entry"):
> Add support for standard xenbus initialization protocol using 'state'
> xenstore entry. It will be necessary for secondary consoles.
> For consoles supporting it, read
Marek Marczykowski-Górecki writes ("[RFC PATCH v2 15/17] xenconsoled: add
support for non-pty output"):
> Handle 'output' xenstore entry, as qemu does. Right now support only few
> simple options:
> - "pty" (unchanged)
> - "file:path" (overwrite file)
> - "pipe:path" (read-write file/pipe)
>
Marek Marczykowski-Górecki writes ("[RFC PATCH v2 16/17] libxl: access QMP
socket via console for qemu-in-stubdomain"):
> Add support for talking with qemu in stubdomain via QMP connected to a
> console. Since a console doesn't have out of band connect/disconnect
> signaling, use (new) qmp_reset
Marek Marczykowski-Górecki writes ("[RFC PATCH v2 12/17] xenconsoled: make
console_type->use_gnttab less confusing"):
> Before this commit 'use_gnttab' means xenconsoled should first try
> special GNTTAB_RESERVED_CONSOLE entry, and only then fallback to
> ring-ref xenstore entry (being gfn of
Marek Marczykowski-Górecki writes ("[RFC PATCH v2 14/17] xenconsoled:
deduplicate error handling"):
> Signed-off-by: Marek Marczykowski-Górecki
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproj
Marek Marczykowski-Górecki writes ("[RFC PATCH v2 13/17] xenconsoled: add
support for up to 3 secondary consoles"):
> Based on previous few commits, this adds basic support for multiple
> consoles in xenconsoled. A static number of them - up to 3 (+ one
> primary).
I'm confused. I thought we
Marek Marczykowski-Górecki writes ("Re: [RFC PATCH v2 00/17] Add support for
qemu-xen runnning in a Linux-based stubdomain."):
> libxenvchan_server_init is asynchronous.
I went to look and I think what you mean is that it is fast. Ie, it
does not need to wait for anything.
>
Anthony PERARD writes ("Re: [PATCH v5 03/15] libxl_qmp: Implement fd callback
and read data [and 1 more messages]"):
> On Mon, Oct 15, 2018 at 05:35:36PM +0100, Ian Jackson wrote:
> > What are LIBXL__QMP_ERROR_CLASSes and why are they even different from
> > ERROR_* va
Juergen Gross writes ("Re: [PATCH] Release: add release note link to
SUPPORT.md"):
> Ian, do you want this to be part of release-technician-checklist.txt:
>
> * change SUPPORT.md heading version number; -unstable or -rc tag
> + and put version number in release note link
I'm happy to have it
xen.git/tools/firmware/etherboot/Makefile tries to get a tarball from
xen-extfiles first and if that fails, tries cloning from ipxe.org.
ipxe.org is sometimes down (or half-down) and when that happens
without a tarball the build breaks and is hard to fix.
We would like, therefore, to ensure that
it is just unfriendly.
Signed-off-by: Ian Jackson
CC: Paul Durrant
CC: Wei Liu
---
config/Tools.mk.in| 2 +-
config/Toplevel.mk.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/config/Tools.mk.in b/config/Tools.mk.in
index 1e5cc20bf7..d5985c0d09 100644
--- a/config/T
This shell fragment lacked set -e. So, eg if the download failed a
broken ipxe.tar.gz would be left behind.
Signed-off-by: Ian Jackson
CC: Paul Durrant
CC: Wei Liu
---
tools/firmware/etherboot/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/firmware
In "build: add autoconf to replace custom checks in tools/check"
--enable-githttp was introduced. But we missed this comment where it
was advertised.
Signed-off-by: Ian Jackson
CC: Paul Durrant
CC: Wei Liu
---
config/Tools.mk.in | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Andrew Cooper writes ("[Xen-devel] MSR load lists on Harpertown"):
> I realise this is an old CPU, but I've I've encountered a weird failure
> on it.
...
> However, given this behaviour, I can't think of any way to context
> switch NX properly, and leave 64bit guests in a working state.
>
> Do
Anthony PERARD writes ("[PATCH v6.1 05/11] libxl_qmp: Implementation of
libxl__ev_qmp_*"):
...
I think this was intended to satisfy my request for comments about
legal states:
> +/* helpers */
> +
> +static void qmp_ev_ensure_reading_writing(libxl__gc *gc, libxl__ev_qmp *ev)
> +{
> +bool
Anthony PERARD writes ("Re: [PATCH v6 02/11] libxl_qmp: Separate QMP message
generation from qmp_send_prepare"):
> On Mon, Nov 12, 2018 at 05:20:53PM +, Ian Jackson wrote:
> > Previously this function returned memory allocated from malloc, and
> > this was not docum
Anthony PERARD writes ("[PATCH v6 05/11] libxl_qmp: Implementation of
libxl__ev_qmp_*"):
> Signed-off-by: Anthony PERARD
I started reviewing this in detail but I got bogged down in the main
implementation details because none of the internal functions like
qmp_ev_connect have doc comments
Marek Marczykowski-Górecki writes ("Re: [Xen-devel] [PATCH v2 11/11]
tools/libvchan: libxenvchan_client_init: use ENOENT for no server"):
> Since xtl_log now accepts NULL, it should be fine. Thanks!
> Reviewed-by: Marek Marczykowski-Górecki
Thanks.
I am reluctant to commit this series without
George Dunlap writes ("[PATCH] libxl/depriv: Remove RLIMIT_NPROC restriction"):
> This also prevents QEMU from creating ptreads, which it requires for
> certain devices to function.
Acked-by: Ian Jackson
To unblock staging.
We should consider whether we can impose a smaller
Anthony PERARD writes ("Re: [PATCH v6.1 05/11] libxl_qmp: Implementation of
libxl__ev_qmp_*"):
> On Tue, Nov 13, 2018 at 01:14:30PM +, Ian Jackson wrote:
> > This one is probably an asisstant for transitioning between states so
> > the pre- and post-conditions m
Anthony PERARD writes ("Re: [PATCH v5 11/15] libxl_dm: Pre-open QMP socket for
QEMU"):
> On Tue, Oct 16, 2018 at 03:11:03PM +0100, Ian Jackson wrote:
> > Anthony PERARD writes ("[PATCH v5 11/15] libxl_dm: Pre-open QMP socket for
> > QEMU"):
> > >
Anthony PERARD writes ("Re: [PATCH v5 11/15] libxl_dm: Pre-open QMP socket for
QEMU"):
> On Mon, Nov 12, 2018 at 03:14:30PM +, Ian Jackson wrote:
> > Yes, it would have to be initialised along with the other members of
> > libxl__domain_build_state.
>
> I
Anthony PERARD writes ("Re: [PATCH v5 12/15] libxl: QEMU startup sync based on
QMP"):
> On Tue, Oct 16, 2018 at 03:23:26PM +0100, Ian Jackson wrote:
> > It's rather odd that neither this patch, nor anything that follows,
> > does not stop libxl from also watching th
Wei Liu writes ("[PATCH v2] xen: report PV capability in sysctl and use it in
toolstack"):
> 0e2c886ef ("xen: decouple HVM and IOMMU capabilities") provided a
> truth table for what `xl info` would report. In order to make the
> table work xen will need to report its
Anthony PERARD writes ("[PATCH v6.2 05/11] libxl_qmp: Implementation of
libxl__ev_qmp_*"):
> Signed-off-by: Anthony PERARD
Thanks for the additional comments. I got thoroughly stuck in.
Overall the structure looks broadly right and my comments are
generally about details. As might be
Thanks for this patch. I have a feeling that I have already commented
(perhaps informally) on a few aspects of it but the message was not
marked `replied' in my MUA so I thought I would formally review it.
Apologies if my comments are, effectively, duplicates.
Anthony PERARD writes ("[PATCH v6
Anthony PERARD writes ("[PATCH v6 08/11] libxl: QEMU startup sync based on
QMP"):
> This is only activated when dm_restrict=1, as explained in the previous
> patch "libxl_dm: Pre-open QMP socket for QEMU"
...
> Signed-off-by: Anthony PERARD
> Reviewed-by: Roger Pau Monné
Thanks. I think I
Anthony PERARD writes ("[PATCH v6 09/11] libxl_qmp: Store advertised QEMU
version in libxl__ev_qmp"):
> This will be used in a later patch.
Thanks. I have one comment about defensive programming in the macro,
and a couple of formatting nits.
> +/*
> + * Store advertised QEMU
Wei Liu writes ("Re: [PATCH 8/8] tools/libvchan: libxenvchan_client_init: use
ENOENT for no server"):
> On Fri, Nov 02, 2018 at 05:01:13PM +, Ian Jackson wrote:
> > * Promise that we will set errno to ENOENT if the server is not
> > yet set up.
> > * Arrang
.
> Suggested-by: Ross Lagerwall
> Signed-off-by: George Dunlap
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Wei Liu writes ("Re: [PATCH 4/8] tools/libvchan: init_xs_srv: Simplify error
handling (2)"):
> On Fri, Nov 02, 2018 at 05:01:09PM +, Ian Jackson wrote:
> > * Abolish fail_xs_open which is now exactly the same as fail.
> > * Change all gotos to refer to fail instead.
George Dunlap writes ("[PATCH v4 2/6] SUPPORT.md: Add qemu-depriv section"):
> Signed-off-by: George Dunlap
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
George Dunlap writes ("[PATCH v4 1/6] docs/qemu-deprivilege: Revise and update
with status and future plans"):
> docs/qemu-deprivilege.txt had some basic instructions for using
> dm_restrict, but it was incomplete, misleading, and stale.
Acked-by: Ian Jackson
(Assuming yo
(I finally remembered to drop the message-id from the CC header...)
Anthony PERARD writes ("Re: [PATCH v6.1 05/11] libxl_qmp: Implementation of
libxl__ev_qmp_*"):
> Here is a simpler comment that is true:
> !disconnected -> same state
>
> Even if in this function ev_fd is modified, it needs
Ian Jackson writes ("Re: [PATCH v6.1 05/11] libxl_qmp: Implementation of
libxl__ev_qmp_*"):
> It is probably easier to introduce the new public Broken state.
If you do this you should think about what should happen if your next
layer up attempts to reuse a Broken libxl__ev_qmp for
Andrew Cooper writes ("Re: [Xen-devel] [PATCH v2 01/11] tools/libs/toollog:
Provide a default logger"):
> Although actually, you can't capture stderr in a variable like this at
> all. freopen() at a later point will close the current FILE object and
> create a new one, after which this logger
Previously xtl_log, xtl_logv and xtl_progress would all crash if
passed logger=NULL. Have the use the default logger instead.
This is more convenient.
Signed-off-by: Ian Jackson
CC: Wei Liu
---
v2: New in this version of the series
---
tools/libs/toollog/include/xentoollog.h | 9
* Abolish fail_xs_open which is now exactly the same as fail.
* Change all gotos to refer to fail instead.
No functional change.
Signed-off-by: Ian Jackson
Acked-by: Wei Liu
CC: Marek Marczykowski-Górecki
---
tools/libvchan/init.c | 13 ++---
1 file changed, 6 insertions(+), 7
801 - 900 of 3634 matches
Mail list logo
