Re: [Xen-devel] [PATCH v3 19/47] xen: add sched_unit_pause_nosync() and sched_unit_unpause()

2019-09-25 Thread Jürgen Groß
On 25.09.19 17:20, Dario Faggioli wrote: On Sat, 2019-09-14 at 10:52 +0200, Juergen Gross wrote: The credit scheduler calls vcpu_pause_nosync() and vcpu_unpause() today. It does. And, FWIW, I hate it with all my heart because of that (among other things! :-D). Add sched_unit_pause_nosync()

Re: [Xen-devel] [PATCH v3 26/47] xen/sched: Change vcpu_migrate_*() to operate on schedule unit

2019-09-25 Thread Jürgen Groß
On 25.09.19 18:37, Dario Faggioli wrote: On Wed, 2019-09-25 at 14:04 +0200, Jürgen Groß wrote: On 25.09.19 00:33, Dario Faggioli wrote: As it is needed anyway call vcpu_sync_execstate() for each vcpu of the unit when changing processors. Again, what do you mean with "As it is needed a

Re: [Xen-devel] [PATCH] xen/efi: Set nonblocking callbacks

2019-10-01 Thread Jürgen Groß
On 27.09.19 17:49, Ross Lagerwall wrote: Other parts of the kernel expect these nonblocking EFI callbacks to exist and crash when running under Xen. Since the implementations of xen_efi_set_variable() and xen_efi_query_variable_info() do not take any locks, use them for the nonblocking callbacks

Re: [Xen-devel] [PATCH-for-4.13] x86/mm: don't needlessly veto migration

2019-10-01 Thread Jürgen Groß
On 01.10.19 10:28, Paul Durrant wrote: Now that xl.cfg has an option to explicitly enable IOMMU mappings for a domain, migration may be needlessly vetoed due to the check of is_iommu_enabled() in paging_log_dirty_enable(). There is actually no need to prevent logdirty from being enabled unless

Re: [Xen-devel] [PATCH-for-4.13] libxl: choose an appropriate default for passthrough...

2019-10-01 Thread Jürgen Groß
On 01.10.19 11:12, Paul Durrant wrote: ...if there is no IOMMU or it is globally disabled. Without this patch, the following assertion may be hit: xl: libxl_create.c:589: libxl__domain_make: Assertion `info->passthrough != LIBXL_PASSTHROUGH_ENABLED' failed. This is because

Re: [Xen-devel] [PATCH for-4.13 2/2] xen/arm: domain_build: Indent correctly parameters of alloc_bank_memory()

2019-10-01 Thread Jürgen Groß
On 01.10.19 11:02, Julien Grall wrote: +Juergen On 01/10/2019 02:05, Stefano Stabellini wrote: On Sun, 29 Sep 2019, Julien Grall wrote: Signed-off-by: Julien Grall Acked-by: Stefano Stabellini Release-acked-by: Juergen Gross Juergen ___

Re: [Xen-devel] [PATCH for-4.13] xen/arm32: head: Fix build when using GAS 2.25.0

2019-09-30 Thread Jürgen Groß
On 01.10.19 02:57, Stefano Stabellini wrote: On Mon, 30 Sep 2019, Andrew Cooper wrote: On 30/09/2019 19:44, Julien Grall wrote: GAS 2.25.0 throws multiple errors when building arm32/head.S: arm32/head.S: Assembler messages: arm32/head.S:452: Error: invalid constant (f7f) after fixup

Re: [Xen-devel] [PATCH] xen/typesafe: Force helpers to be always_inline

2019-10-01 Thread Jürgen Groß
On 30.09.19 21:16, Andrew Cooper wrote: Clang in particular has a habit of out-of-lining these and creating multiple local copies of _mfn() and mfn_x(), etc. Override this behaviour. Adjust bool_t to bool for the *_eq() helpers. Signed-off-by: Andrew Cooper Release-acked-by: Juergen Gross

Re: [Xen-devel] [PATCH for-4.13 0/2] xen/nospec: Add Kconfig options for speculative hardening

2019-10-01 Thread Jürgen Groß
On 30.09.19 20:24, Andrew Cooper wrote: The main purpose is patch 2. The "l1tf-barrier" work currently causes a perf hit and gains no safety, and is therefore unfit for inclusion into Xen 4.13 at this time. Andrew Cooper (2): xen/nospec: Introduce CONFIG_SPECULATIVE_ARRAY_HARDEN

Re: [Xen-devel] [PATCH v2 1/1] xen-netfront: do not use ~0U as error return value for xennet_fill_frags()

2019-10-01 Thread Jürgen Groß
On 01.10.19 15:56, Dongli Zhang wrote: xennet_fill_frags() uses ~0U as return value when the sk_buff is not able to cache extra fragments. This is incorrect because the return type of xennet_fill_frags() is RING_IDX and 0x is an expected value for ring buffer index. In the situation

Re: [Xen-devel] [PATCH-for-4.13 v2 0/2] libxl: fix assertion failure

2019-10-01 Thread Jürgen Groß
On 01.10.19 16:57, Paul Durrant wrote: This was originally a single patch, which is now patch #2 of this series. Paul Durrant (2): libxl: replace 'enabled' with 'unknown' in libxl_passthrough enumeration libxl: choose an appropriate default for passthrough...

Re: [Xen-devel] [PATCH v3 30/47] xen/sched: add support for multiple vcpus per sched unit where missing

2019-09-26 Thread Jürgen Groß
On 26.09.19 15:53, Dario Faggioli wrote: On Wed, 2019-09-25 at 15:07 +0200, Jan Beulich wrote: On 25.09.2019 14:40, Jürgen Groß wrote: On 24.09.19 17:22, Jan Beulich wrote: On 24.09.2019 17:09, Jürgen Groß wrote: On 24.09.19 17:00, Jan Beulich wrote: On 24.09.2019 16:41, Jürgen Groß wrote

Re: [Xen-devel] [PATCH] x86/shim: fix ballooning down the guest

2019-09-26 Thread Jürgen Groß
On 26.09.19 15:51, Roger Pau Monné wrote: On Thu, Sep 26, 2019 at 02:36:18PM +0100, Sergey Dyasli wrote: Currently ballooning down a pvshim guest causes the following errors inside the shim: d3v0 failed to reserve 512 extents of order 512 for offlining And the ballooned-out pages stay

Re: [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU

2019-09-26 Thread Jürgen Groß
On 25.09.19 17:27, Jan Beulich wrote: There's nothing to restore here if there's no FPU in the first place. Signed-off-by: Jan Beulich Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH v2] xen/sched: don't let XEN_RUNSTATE_UPDATE leak into vcpu_runstate_get()

2019-09-26 Thread Jürgen Groß
On 26.09.19 16:27, Julien Grall wrote: Hi, On 9/25/19 5:29 AM, Juergen Gross wrote: vcpu_runstate_get() should never return a state entry time with XEN_RUNSTATE_UPDATE set. To avoid this let update_runstate_area() operate on a local runstate copy. This problem was introduced with commit

Re: [Xen-devel] [PATCH v3 47/47] xen/sched: add scheduling granularity enum

2019-09-26 Thread Jürgen Groß
On 26.09.19 11:46, Dario Faggioli wrote: On Sat, 2019-09-14 at 10:52 +0200, Juergen Gross wrote: Add a scheduling granularity enum ("cpu", "core", "socket") for specification of the scheduling granularity. Initially it is set to "cpu", this can be modified by the new boot parameter (x86 only)

Re: [Xen-devel] [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support

2019-09-27 Thread Jürgen Groß
On 27.09.19 15:37, Ian Jackson wrote: Jürgen Groß writes ("Re: [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support"): On 27.09.19 12:37, Ian Jackson wrote: I guess that keys will be chosen from some limited safe character set ? What about values ? Might

Re: [Xen-devel] [PATCH] x86: correct bogus error indicator of cpu_add()

2019-09-27 Thread Jürgen Groß
On 27.09.19 16:43, Jan Beulich wrote: Commit 54ce2db8b8 ("x86/numa: adjust datatypes for node and pxm") changed this from the -1 (i.e. -EPERM, which was already bogus) that comes back from setup_node() to NUMA_NO_NODE (0xff). Use a proper error indicator instead. Signed-off-by: Jan Beulich

Re: [Xen-devel] [PATCH 1/2] xen/sched: fix locking in a653sched_free_vdata()

2019-09-27 Thread Jürgen Groß
On 27.09.19 10:20, Jan Beulich wrote: On 27.09.2019 09:23, Jürgen Groß wrote: On 25.09.19 12:59, Dario Faggioli wrote: On Wed, 2019-09-25 at 09:05 +0200, Juergen Gross wrote: The arinc653 scheduler's free_vdata() function is missing proper locking: as it is modifying the scheduler's private

Re: [Xen-devel] [PATCH 1/2] xen/sched: fix locking in a653sched_free_vdata()

2019-09-27 Thread Jürgen Groß
On 25.09.19 12:59, Dario Faggioli wrote: On Wed, 2019-09-25 at 09:05 +0200, Juergen Gross wrote: The arinc653 scheduler's free_vdata() function is missing proper locking: as it is modifying the scheduler's private vcpu list it needs to take the scheduler lock during that operation.

Re: [Xen-devel] [PATCH v3 35/47] xen/sched: make vcpu_wake() and vcpu_sleep() core scheduling aware

2019-09-27 Thread Jürgen Groß
On 27.09.19 09:32, Dario Faggioli wrote: On Fri, 2019-09-27 at 06:42 +0200, Jürgen Groß wrote: On 25.09.19 15:07, Jürgen Groß wrote: On 24.09.19 13:55, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: @@ -765,16 +774,22 @@ void vcpu_wake(struct vcpu *v) { unsigned long

Re: [Xen-devel] [PATCH v4 10/46] xen/sched: add scheduler helpers hiding vcpu

2019-09-27 Thread Jürgen Groß
On 27.09.19 10:52, Dario Faggioli wrote: On Fri, 2019-09-27 at 09:00 +0200, Juergen Gross wrote: Add the following helpers using a sched_unit as input instead of a vcpu: - is_idle_unit() similar to is_idle_vcpu() - is_unit_online() similar to is_vcpu_online() (returns true when any of its

Re: [Xen-devel] [PATCH v3 35/47] xen/sched: make vcpu_wake() and vcpu_sleep() core scheduling aware

2019-09-26 Thread Jürgen Groß
On 25.09.19 15:07, Jürgen Groß wrote: On 24.09.19 13:55, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: @@ -765,16 +774,22 @@ void vcpu_wake(struct vcpu *v)   {   unsigned long flags;   spinlock_t *lock; +    struct sched_unit *unit = v->sched_unit;   TRACE

Re: [Xen-devel] [PATCH RFC for-4.13 00/10] xen/arm: XSA-201 and XSA-263 fixes

2019-09-26 Thread Jürgen Groß
On 26.09.19 20:37, Julien Grall wrote: Hi all, This patch series aims to fix two bugs in the entry path from the guest: 1) Make sure that SSBD workaround is enabled before executing any hypervisor code 2) Avoid guest state corruption when an virtual SError is received The full

Re: [Xen-devel] Moving next week's community call to Thu 10th

2019-09-24 Thread Jürgen Groß
On 24.09.19 10:36, Lars Kurth wrote: Hi all, because many of us will be at the Platform Security Summit next week, I propose to move the community call to Thu 10^th at the usual time +1 ... especially as there is a public holiday in Germany on Oct 3rd. Juergen

Re: [Xen-devel] [PATCH] xen/sched: don't let XEN_RUNSTATE_UPDATE leak into vcpu_runstate_get()

2019-09-24 Thread Jürgen Groß
On 24.09.19 10:39, Jan Beulich wrote: On 24.09.2019 09:42, Juergen Gross wrote: vcpu_runstate_get() should never return a state entry time with XEN_RUNSTATE_UPDATE set. To avoid this let update_runstate_area() operate on a local runstate copy. This problem was introduced with commit

Re: [Xen-devel] [PATCH v3 32/47] xen/sched: support allocating multiple vcpus into one sched unit

2019-09-24 Thread Jürgen Groß
On 24.09.19 11:46, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: @@ -366,18 +380,38 @@ static void sched_free_unit(struct sched_unit *unit) xfree(unit); } +static void sched_unit_add_vcpu(struct sched_unit *unit, struct vcpu *v) +{ +v->sched_unit = unit; +if (

Re: [Xen-devel] Regression with vcpu runstate info and XEN_RUNSTATE_UPDATE

2019-09-23 Thread Jürgen Groß
On 23.09.19 12:12, Jan Beulich wrote: On 23.09.2019 11:56, Jürgen Groß wrote: On 23.09.19 11:51, Jan Beulich wrote: On 23.09.2019 11:42, Jürgen Groß wrote: On 16.09.19 17:44, Jan Beulich wrote: On 16.09.2019 16:50, Andrew Cooper wrote: After a complicated investigation, it turns out that c

Re: [Xen-devel] [PATCH v3 29/47] xen/sched: introduce unit_runnable_state()

2019-09-24 Thread Jürgen Groß
On 23.09.19 17:24, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: Today the vcpu runstate of a new scheduled vcpu is always set to "running" even if at that time vcpu_runnable() is already returning false due to a race (e.g. with pausing the vcpu). I can see this part, ...

Re: [Xen-devel] [PATCH v3 30/47] xen/sched: add support for multiple vcpus per sched unit where missing

2019-09-24 Thread Jürgen Groß
On 23.09.19 17:41, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: @@ -266,15 +267,16 @@ static inline void vcpu_runstate_change( static inline void sched_unit_runstate_change(struct sched_unit *unit, bool running, s_time_t new_entry_time) { -struct vcpu *v =

Re: [Xen-devel] [PATCH v3 31/47] xen/sched: modify cpupool_domain_cpumask() to be an unit mask

2019-09-24 Thread Jürgen Groß
On 23.09.19 17:44, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: cpupool_domain_cpumask() is used by scheduling to select cpus or to iterate over cpus. In order to support scheduling units spanning multiple cpus let cpupool_domain_cpumask() return a cpumask with only one bit set

Re: [Xen-devel] [PATCH v3 29/47] xen/sched: introduce unit_runnable_state()

2019-09-24 Thread Jürgen Groß
On 24.09.19 16:45, Jan Beulich wrote: On 24.09.2019 16:25, Jürgen Groß wrote: On 23.09.19 17:24, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: Today the vcpu runstate of a new scheduled vcpu is always set to "running" even if at that time vcpu_runnable() is already

Re: [Xen-devel] [PATCH v3 24/47] xen: switch from for_each_vcpu() to for_each_sched_unit()

2019-09-24 Thread Jürgen Groß
On 24.09.19 14:31, Jan Beulich wrote: On 24.09.2019 14:13, Jürgen Groß wrote: On 20.09.19 17:05, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: @@ -896,18 +929,22 @@ void restore_vcpu_affinity(struct domain *d) cpupool_domain_cpumask(d

Re: [Xen-devel] [PATCH v3 30/47] xen/sched: add support for multiple vcpus per sched unit where missing

2019-09-24 Thread Jürgen Groß
On 24.09.19 17:00, Jan Beulich wrote: On 24.09.2019 16:41, Jürgen Groß wrote: On 23.09.19 17:41, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: @@ -1851,7 +1852,7 @@ void sched_context_switched(struct vcpu *vprev, struct vcpu *vnext) while ( atomic_read

Re: [Xen-devel] [PATCH v3 32/47] xen/sched: support allocating multiple vcpus into one sched unit

2019-09-24 Thread Jürgen Groß
On 24.09.19 12:13, Jan Beulich wrote: On 24.09.2019 12:06, Jürgen Groß wrote: On 24.09.19 11:46, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: @@ -366,18 +380,38 @@ static void sched_free_unit(struct sched_unit *unit) xfree(unit); } +static void

Re: [Xen-devel] [PATCH v3 23/47] xen/sched: switch sched_move_irqs() to take sched_unit as parameter

2019-09-24 Thread Jürgen Groß
On 20.09.19 16:34, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: --- a/xen/common/schedule.c +++ b/xen/common/schedule.c @@ -474,12 +474,20 @@ int sched_init_vcpu(struct vcpu *v) return 0; } -static void sched_move_irqs(struct vcpu *v) +static void

Re: [Xen-devel] [PATCH for-4.13 v2 0/2] Errata implementation and doc update

2019-09-24 Thread Jürgen Groß
On 24.09.19 16:35, Julien Grall wrote: Hi all, The two patches are not related but the second one dependends on the first one. So I decided to merge them together. Cheers, Julien Grall (2): xen/arm: Implement workaround for Cortex A-57 and Cortex A72 AT speculate docs: Replace all

Re: [Xen-devel] [PATCH v3 31/47] xen/sched: modify cpupool_domain_cpumask() to be an unit mask

2019-09-24 Thread Jürgen Groß
On 23.09.19 17:50, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: --- a/xen/common/cpupool.c +++ b/xen/common/cpupool.c @@ -36,26 +36,35 @@ static DEFINE_SPINLOCK(cpupool_lock); DEFINE_PER_CPU(struct cpupool *, cpupool); +static void free_cpupool_struct(struct cpupool *c)

Re: [Xen-devel] [PATCH v3 07/47] xen/sched: move per cpu scheduler private data into struct sched_resource

2019-09-24 Thread Jürgen Groß
On 24.09.19 14:08, Jan Beulich wrote: On 24.09.2019 13:41, Jürgen Groß wrote: Regarding to rename "sd" to "sr": I agree this would be a sensible change. OTOH I'd like to be consistent, so I'd like to defer that to the planned scheduling cleanup series. Seeing another

Re: [Xen-devel] [PATCH] xen/sched: don't let XEN_RUNSTATE_UPDATE leak into vcpu_runstate_get()

2019-09-24 Thread Jürgen Groß
On 24.09.19 17:16, Jan Beulich wrote: On 24.09.2019 09:42, Juergen Gross wrote: vcpu_runstate_get() should never return a state entry time with XEN_RUNSTATE_UPDATE set. To avoid this let update_runstate_area() operate on a local runstate copy. This problem was introduced with commit

Re: [Xen-devel] [PATCH v3 28/47] xen/sched: add code to sync scheduling of all vcpus of a sched unit

2019-09-24 Thread Jürgen Groß
On 20.09.19 18:08, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: --- a/xen/common/schedule.c +++ b/xen/common/schedule.c @@ -55,6 +55,9 @@ boolean_param("sched_smt_power_savings", sched_smt_power_savings); int sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;

Re: [Xen-devel] [PATCH v3 33/47] xen/sched: add a percpu resource index

2019-09-24 Thread Jürgen Groß
On 24.09.19 12:05, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: --- a/xen/common/schedule.c +++ b/xen/common/schedule.c @@ -71,6 +71,7 @@ static void poll_timer_fn(void *data); /* This is global for now so that private implementations can reach it */ DEFINE_PER_CPU(struct

Re: [Xen-devel] [PATCH v3 13/47] xen/sched: add is_running indicator to struct sched_unit

2019-09-24 Thread Jürgen Groß
On 19.09.19 17:53, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: @@ -1673,8 +1676,10 @@ static void schedule(void) * switch, else lost_records resume will not work properly. */ -ASSERT(!next->is_running); +ASSERT(!next->sched_unit->is_running);

Re: [Xen-devel] [PATCH v3 24/47] xen: switch from for_each_vcpu() to for_each_sched_unit()

2019-09-24 Thread Jürgen Groß
On 20.09.19 17:05, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: @@ -508,25 +515,27 @@ int sched_move_domain(struct domain *d, struct cpupool *c) if ( IS_ERR(domdata) ) return PTR_ERR(domdata); -vcpu_priv = xzalloc_array(void *, d->max_vcpus); -if (

Re: [Xen-devel] [PATCH v3 25/47] xen/sched: add runstate counters to struct sched_unit

2019-09-24 Thread Jürgen Groß
On 20.09.19 17:27, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: @@ -368,7 +372,7 @@ static struct sched_unit *sched_alloc_unit(struct vcpu *v) unit->vcpu_list = v; unit->unit_id = v->vcpu_id; unit->domain = d; -v->sched_unit = unit; +

Re: [Xen-devel] [PATCH v3 00/47] xen: add core scheduling support

2019-09-24 Thread Jürgen Groß
On 24.09.19 13:15, Sergey Dyasli wrote: Hi Juergen, After an extensive testing of your jgross1/sched-v3 branch in XenRT, I'm happy to say that we've found no functional regressions so far when running in the default (thread/cpu) mode. Hopefully this gives some level of confidence to this

Re: [Xen-devel] [PATCH v3 09/47] xen/sched: move some per-vcpu items to struct sched_unit

2019-09-24 Thread Jürgen Groß
On 19.09.19 17:38, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: Affinities are scheduler specific attributes, they should be per scheduling unit. So move all affinity related fields in struct vcpu to struct sched_unit. While at it switch affinity related functions in sched-if.h

Re: [Xen-devel] [PATCH v3 10/47] xen/sched: add scheduler helpers hiding vcpu

2019-09-24 Thread Jürgen Groß
On 19.09.19 17:45, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: Add the following helpers using a sched_unit as input instead of a vcpu: - is_idle_unit() similar to is_idle_vcpu() - is_unit_online() similar to is_vcpu_online() (returns true when any of its vcpus is online) -

Re: [Xen-devel] [PATCH v3 07/47] xen/sched: move per cpu scheduler private data into struct sched_resource

2019-09-24 Thread Jürgen Groß
On 19.09.19 17:27, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: This prepares support of larger scheduling granularities, e.g. core scheduling. While at it move sched_has_urgent_vcpu() from include/asm-x86/cpuidle.h into sched.h removing the need for including sched-if.h in

Re: [Xen-devel] [PATCH v3 13/47] xen/sched: add is_running indicator to struct sched_unit

2019-09-24 Thread Jürgen Groß
On 24.09.19 14:00, Jan Beulich wrote: On 24.09.2019 13:47, Jürgen Groß wrote: On 19.09.19 17:53, Jan Beulich wrote: On 14.09.2019 10:52, Juergen Gross wrote: @@ -1673,8 +1676,10 @@ static void schedule(void) * switch, else lost_records resume will not work properly

Re: [Xen-devel] [PATCH] xen/arm: p2m: Free the p2m entry after flushing the IOMMU TLBs

2019-10-01 Thread Jürgen Groß
On 02.10.19 04:07, Stefano Stabellini wrote: + Juergen On Mon, 12 Aug 2019, Julien Grall wrote: When freeing a p2m entry, all the sub-tree behind it will also be freed. This may include intermediate page-tables or any l3 entry requiring to drop a reference (e.g for foreign pages). As soon as

Re: [Xen-devel] [PATCH] x86/xen: Return from panic notifier

2019-10-01 Thread Jürgen Groß
On 01.10.19 17:16, Boris Ostrovsky wrote: Currently execution of panic() continues until Xen's panic notifier (xen_panic_event()) is called at which point we make a hypercall that never returns. This means that any notifier that is supposed to be called later as well as significant part of

Re: [Xen-devel] [PATCH for-4.13] x86/crash: force unlock console before printing on kexec crash

2019-10-02 Thread Jürgen Groß
On 02.10.19 12:25, Jan Beulich wrote: On 01.10.2019 21:15, Igor Druzhinin wrote: There is a small window where shootdown NMI might come to a CPU (e.g. in serial interrupt handler) where console lock is taken. In order not to leave following console prints waiting infinitely for shot down CPUs

Re: [Xen-devel] [PATCH v2] libxl: wait for the ack when issuing power control requests

2019-10-02 Thread Jürgen Groß
On 02.10.19 12:08, Roger Pau Monné wrote: Adding Juergen for a release-ack. On Tue, Oct 01, 2019 at 05:44:07PM +0100, Anthony PERARD wrote: On Tue, Oct 01, 2019 at 05:22:33PM +0200, Roger Pau Monne wrote: Currently only suspend power control requests wait for an ack from the domain, while

Re: [Xen-devel] [PATCH] x86/Kconfig: Invert the defaults for CONFIG_{PVH_GUEST, PV_SHIM}

2019-10-02 Thread Jürgen Groß
On 01.10.19 18:32, Andrew Cooper wrote: This is a minor UI change, but users which have elected to enable XEN_GUEST (which still defaults to no) will definitely need one of these options, and will typically want both. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau

Re: [Xen-devel] [PATCH 0/2] tools/xen-cpuid: two small adjustments

2019-10-02 Thread Jürgen Groß
On 02.10.19 09:27, Jan Beulich wrote: 1: MAINTAINERS: add tools/misc/xen-cpuid to "X86 ARCHITECTURE" 2: tools/xen-cpuid: avoid producing bogus output They're not overly important to have for 4.13, but they're also rather low risk, so I think they're worthwhile considering at this point in time.

Re: [Xen-devel] [PATCH v1 1/3] xen/balloon: Drop __balloon_append()

2019-10-02 Thread Jürgen Groß
On 02.10.19 09:47, David Hildenbrand wrote: On 01.10.19 19:45, Boris Ostrovsky wrote: On 10/1/19 5:01 AM, David Hildenbrand wrote: Let's simply use balloon_append() directly. Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Signed-off-by: David Hildenbrand For the series

Re: [Xen-devel] [PATCH] IOMMU: add missing HVM check

2019-10-02 Thread Jürgen Groß
On 02.10.19 12:19, Jan Beulich wrote: On 02.10.2019 12:14, Roger Pau Monné wrote: On Wed, Oct 02, 2019 at 12:10:06PM +0200, Jan Beulich wrote: Fix an unguarded d->arch.hvm access in assign_device(). Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Thanks. I'm also adding

Re: [Xen-devel] [PATCH] docs: remove tmem references from man pages

2019-10-02 Thread Jürgen Groß
On 02.10.19 15:44, Wei Liu wrote: On Wed, Oct 02, 2019 at 03:41:56PM +0200, Juergen Gross wrote: The "TO BE DOCUMENTED" section of the xl man page still references tmem. So does the xl.conf man page. Remove the references. Signed-off-by: Juergen Gross Nice catch. Thanks. Acked-by: Wei Liu

Re: [Xen-devel] [PATCH v6 01/20] xen/sched: add code to sync scheduling of all vcpus of a sched unit

2019-10-02 Thread Jürgen Groß
On 02.10.19 09:27, Juergen Gross wrote: When switching sched units synchronize all vcpus of the new unit to be scheduled at the same time. A variable sched_granularity is added which holds the number of vcpus per schedule unit. As tasklets require to schedule the idle unit it is required to

Re: [Xen-devel] [PATCH v8 1/4] libxl: fix cold plugged PCI device with stubdomain

2019-10-02 Thread Jürgen Groß
On 02.10.19 17:43, Ian Jackson wrote: Hi Juergen. This series https://lists.xenproject.org/archives/html/xen-devel/2019-09/msg03072.html needs your release review. Fir the series: Release-acked-by: Juergen Gross even if I don't see why it is necessary: the series was posted first way

Re: [Xen-devel] [PATCH 0/2] libxl fixes with pci passthrough

2019-10-02 Thread Jürgen Groß
On 02.10.19 17:45, Ian Jackson wrote: Hi Juergen. Here's another bugfix series https://lists.xenproject.org/archives/html/xen-devel/2019-09/msg03320.html https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git #br.fixes-for-pci-pt-libxl-v1 needing your release review. For

Re: [Xen-devel] [PATCH] x86/iommu: improve logging message

2019-09-27 Thread Jürgen Groß
On 27.09.19 12:48, Roger Pau Monne wrote: Switch to using pd and also print the pfn that failed. No functional change intended. Signed-off-by: Roger Pau Monné Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH v4 24/46] xen: switch from for_each_vcpu() to for_each_sched_unit()

2019-09-27 Thread Jürgen Groß
On 27.09.19 11:32, Dario Faggioli wrote: On Fri, 2019-09-27 at 09:00 +0200, Juergen Gross wrote: Where appropriate switch from for_each_vcpu() to for_each_sched_unit() in order to prepare core scheduling. As it is beneficial once here and for sure in future add a unit_scheduler() helper and

Re: [Xen-devel] [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support

2019-09-27 Thread Jürgen Groß
On 27.09.19 12:37, Ian Jackson wrote: Juergen Gross writes ("[PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support"): On the 2019 Xen developer summit there was agreement that the Xen hypervisor should gain support for a hierarchical name-value store similar to the

Re: [Xen-devel] [PATCH v1 3/6] libs: add libxenhypfs

2019-09-27 Thread Jürgen Groß
On 27.09.19 12:40, Ian Jackson wrote: Juergen Gross writes ("[PATCH v1 3/6] libs: add libxenhypfs"): Add the new library libxenhypfs for access to the hypervisor filesystem. This code looks as expected to me. Acked-by: Ian Jackson It does make me thing you have had to write rather a lot of

Re: [Xen-devel] [PATCH v1 4/6] tools: add xenfs tool

2019-09-27 Thread Jürgen Groß
On 27.09.19 12:42, Ian Jackson wrote: Juergen Gross writes ("[PATCH v1 4/6] tools: add xenfs tool"): Add the xenfs tool for accessing the hypervisor filesystem. Thanks for taking care about exit status. Can you document the exit statuses somewhere ? Yes. Might be a good reason to add a

Re: [Xen-devel] [PATCH] iommu: fix PVH dom0 settings

2019-09-27 Thread Jürgen Groß
On 27.09.19 14:02, Jan Beulich wrote: On 27.09.2019 13:45, Paul Durrant wrote: PVH dom0 must operate with the iommu settings in 'strict' mode i.e. only the domain's own pages will be mapped in the IOMMU. The check_hwdom_reqs() is supposed to ensure this. Unfortunately the test for a PVH dom0 is

Re: [Xen-devel] [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support

2019-09-30 Thread Jürgen Groß
On 27.09.19 17:19, Ian Jackson wrote: Jürgen Groß writes ("Re: [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support"): On 27.09.19 15:37, Ian Jackson wrote: I think this is ASCII printing characters with the exception of ! " ` $ % ^ & * = + {

Re: [Xen-devel] [PATCH] x86/iommu: fix hwdom iommu requirements check

2019-09-30 Thread Jürgen Groß
On 28.09.19 10:26, Roger Pau Monne wrote: Both a shadow and a HAP hwdom require an iommu and must be run in strict mode. Change the HAP check into a hvm domain check. Signed-off-by: Roger Pau Monné Release-acked-by: Juergen Gross Juergen ___

Re: [Xen-devel] [xen-unstable test] 141990: regressions - FAIL

2019-09-30 Thread Jürgen Groß
On 30.09.19 08:01, Jürgen Groß wrote: On 30.09.19 06:23, osstest service owner wrote: flight 141990 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/141990/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run:   test

Re: [Xen-devel] [PATCH for-4.13] xen/arm: p2m: Fix typo in the comment on top of P2M_ROOT_LEVEL

2019-09-30 Thread Jürgen Groß
On 29.09.19 18:35, Julien Grall wrote: Signed-off-by: Julien Grall Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [xen-unstable test] 141990: regressions - FAIL

2019-09-30 Thread Jürgen Groß
On 30.09.19 06:23, osstest service owner wrote: flight 141990 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/141990/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 7

Re: [Xen-devel] [PATCH for-4.13 1/2] xen/arm: domain_build: Avoid implicit conversion from ULL to UL

2019-09-30 Thread Jürgen Groß
On 29.09.19 17:56, Julien Grall wrote: Clang 8.0 will fail to build domain_build.c on Arm32 because of the following error: domain_build.c:448:21: error: implicit conversion from 'unsigned long long' to 'unsigned long' changes value from 1090921693184 to 0 [-Werror,-Wconstant-conversion]

Re: [Xen-devel] [PATCH] xen/efi: Set nonblocking callbacks

2019-09-30 Thread Jürgen Groß
On 27.09.19 17:49, Ross Lagerwall wrote: Other parts of the kernel expect these nonblocking EFI callbacks to exist and crash when running under Xen. Since the implementations of xen_efi_set_variable() and xen_efi_query_variable_info() do not take any locks, use them for the nonblocking callbacks

Re: [Xen-devel] [PATCH 1/1] xen-netfront: do not use ~0U as error return value for xennet_fill_frags()

2019-09-30 Thread Jürgen Groß
On 30.09.19 09:44, Dongli Zhang wrote: xennet_fill_frags() uses ~0U as return value when the sk_buff is not able to cache extra fragments. This is incorrect because the return type of xennet_fill_frags() is RING_IDX and 0x is an expected value for ring buffer index. In the situation

Re: [Xen-devel] [PATCH v5 01/19] xen/sched: add code to sync scheduling of all vcpus of a sched unit

2019-09-30 Thread Jürgen Groß
On 30.09.19 12:39, Jan Beulich wrote: On 30.09.2019 12:38, Andrew Cooper wrote: On 30/09/2019 11:36, Jan Beulich wrote: On 30.09.2019 07:21, Juergen Gross wrote: When switching sched units synchronize all vcpus of the new unit to be scheduled at the same time. A variable sched_granularity is

Re: [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely

2019-09-30 Thread Jürgen Groß
On 30.09.19 12:34, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The Arm realization should have been removed in the following commit as redundant: f89f555 remove late (on-demand) construction of IOMMU page tables So, remove unused function completely. Signed-off-by: Oleksandr

Re: [Xen-devel] [PATCH v5 20/19] docs: add "sched-gran" boot parameter documentation

2019-09-30 Thread Jürgen Groß
On 30.09.19 12:25, Jan Beulich wrote: On 30.09.2019 12:09, Juergen Gross wrote: Add documentation for the new "sched-gran" hypervisor boot parameter. Signed-off-by: Juergen Gross --- docs/misc/xen-command-line.pandoc | 21 + 1 file changed, 21 insertions(+) diff --git

Re: [Xen-devel] [PATCH] SUPPORT.md: Add PV display/sound, update keyboard

2019-09-30 Thread Jürgen Groß
On 30.09.19 12:33, George Dunlap wrote: On 9/30/19 11:29 AM, George Dunlap wrote: On 9/30/19 9:56 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Signed-off-by: Oleksandr Andrushchenko --- SUPPORT.md | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-)

Re: [Xen-devel] [PATCH v5 20/19] docs: add "sched-gran" boot parameter documentation

2019-09-30 Thread Jürgen Groß
On 30.09.19 13:02, Jan Beulich wrote: On 30.09.2019 12:51, Jürgen Groß wrote: On 30.09.19 12:25, Jan Beulich wrote: On 30.09.2019 12:09, Juergen Gross wrote: Add documentation for the new "sched-gran" hypervisor boot parameter. Signed-off-by: Juergen Gross --- docs/misc/x

Re: [Xen-devel] [PATCH v5 20/19] docs: add "sched-gran" boot parameter documentation

2019-09-30 Thread Jürgen Groß
On 30.09.19 13:20, Jan Beulich wrote: On 30.09.2019 13:13, Jürgen Groß wrote: On 30.09.19 13:02, Jan Beulich wrote: On 30.09.2019 12:51, Jürgen Groß wrote: On 30.09.19 12:25, Jan Beulich wrote: On 30.09.2019 12:09, Juergen Gross wrote: Add documentation for the new "sched-gran"

Re: [Xen-devel] [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support

2019-09-30 Thread Jürgen Groß
On 30.09.19 12:07, Ian Jackson wrote: Jürgen Groß writes ("Re: [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support"): On 30.09.19 10:57, Jan Beulich wrote: On 30.09.2019 10:17, Jürgen Groß wrote: .config can contain user supplied strings. While not m

Re: [Xen-devel] [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support

2019-09-30 Thread Jürgen Groß
On 30.09.19 10:57, Jan Beulich wrote: On 30.09.2019 10:17, Jürgen Groß wrote: On 27.09.19 17:19, Ian Jackson wrote: Jürgen Groß writes ("Re: [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support"): On 27.09.19 15:37, Ian Jackson wrote: I think thi

Re: [Xen-devel] [xen-unstable test] 141990: regressions - FAIL

2019-09-30 Thread Jürgen Groß
On 30.09.19 11:17, Paul Durrant wrote: -Original Message- From: Jan Beulich Sent: 30 September 2019 10:07 To: Paul Durrant Cc: xen-devel@lists.xenproject.org; Juergen Gross ; osstest service owner Subject: Re: [Xen-devel] [xen-unstable test] 141990: regressions - FAIL On 30.09.2019

Re: [Xen-devel] [PATCH] xen/events: remove event handling recursion detection

2019-11-04 Thread Jürgen Groß
On 04.11.19 16:19, Jan Beulich wrote: On 04.11.2019 16:09, Jürgen Groß wrote: On 04.11.19 15:35, Jan Beulich wrote: On 04.11.2019 14:58, Juergen Gross wrote: __xen_evtchn_do_upcall() contains guards against being called recursively. This mechanism was introduced in the early pvops times

Re: [Xen-devel] [PATCH] xen/events: remove event handling recursion detection

2019-11-04 Thread Jürgen Groß
On 04.11.19 15:35, Jan Beulich wrote: On 04.11.2019 14:58, Juergen Gross wrote: __xen_evtchn_do_upcall() contains guards against being called recursively. This mechanism was introduced in the early pvops times (kernel 2.6.26) when there were still Xen versions around not honoring disabled

[Xen-devel] Commit moratorium for getting a push

2019-11-04 Thread Jürgen Groß
Committers, Please don't push any new patch to staging because we want to have a push to master for 4.13-RC2. Another email will be sent once the moratorium is lifted. Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH for-4.13 v2 0/2] x86/ioapic: fix clear_IO_APIC_pin when using interrupt remapping

2019-11-11 Thread Jürgen Groß
On 10.11.19 10:25, Roger Pau Monne wrote: Hello, Current code in clear_IO_APIC_pin doesn't properly deal with IO-APIC entries already configured to point to entries in the iommu interrupt remapping table, fix this. Roger Pau Monne (2): x86/ioapic: remove usage of TRUE and FALSE in

Re: [Xen-devel] [PATCH][next] xen/gntdev: remove redundant non-zero check on ret

2019-11-11 Thread Jürgen Groß
On 11.11.19 13:20, Colin King wrote: From: Colin Ian King The non-zero check on ret is always going to be false because ret was initialized as zero and the only place it is set to non-zero contains a return path before the non-zero check. Hence the check is redundant and can be removed.

Re: [Xen-devel] [PATCH][next] xen/gntdev: remove redundant non-zero check on ret

2019-11-11 Thread Jürgen Groß
On 11.11.19 13:31, Colin Ian King wrote: On 11/11/2019 12:25, Jürgen Groß wrote: On 11.11.19 13:20, Colin King wrote: From: Colin Ian King The non-zero check on ret is always going to be false because ret was initialized as zero and the only place it is set to non-zero contains a return path

Re: [Xen-devel] Urgent for 4.13, Was dom0less + sched=null => broken in staging (fwd)

2019-11-06 Thread Jürgen Groß
On 06.11.19 13:11, George Dunlap wrote: On Tue, Nov 5, 2019 at 11:58 PM Stefano Stabellini wrote: Hi Dario, I just checked and the patch is not in staging yet. Can we please make sure the patch goes in as soon as possible, given the looming release? I think either a fix or a revert of the

[Xen-devel] OSStest priorities

2019-11-07 Thread Jürgen Groß
Hi Ian, in the Xen community call we agreed to try to speed up OSStest for xen-unstable in order to make better progress with the 4.13 release. Could you please suspend testing for Xen 4.10 and older (Jan agreed on that), and disable the Linux kernel tests which are currently failing (including

Re: [Xen-devel] [OSSTEST PATCH] make-flight: Drop all win10 tests in all flights

2019-11-07 Thread Jürgen Groß
). CC: Sander Eikelenboom CC: Jürgen Groß Signed-off-by: Ian Jackson Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-11-07 Thread Jürgen Groß
On 28.10.19 21:10, Jason Gunthorpe wrote: From: Jason Gunthorpe DMA_SHARED_BUFFER can not be enabled by the user (it represents a library set in the kernel). The kconfig convention is to use select for such symbols so they are turned on implicitly when the user enables a kconfig that needs

Re: [Xen-devel] [XEN PATCH for-4.13] tools/configure: Honour XEN_COMPILE_ARCH and _TARGET_ for shim

2019-11-07 Thread Jürgen Groß
source fix to configure.ac. Signed-off-by: Ian Jackson CC: Jürgen Groß Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH for-4.13 v2 0/6] Fix: libxl workaround, multiple connection to single QMP socket

2019-11-07 Thread Jürgen Groß
On 30.10.19 19:06, Anthony PERARD wrote: Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.fix-ev_qmp-multi-connect-v2 Hi, QEMU's QMP socket doesn't allow multiple concurrent connection. Also, it listen() on the socket with a

Re: [Xen-devel] [XEN PATCH for-4.13] libxl: Fix setting vncpasswd to empty string

2019-11-07 Thread Jürgen Groß
On 04.11.19 16:30, Anthony PERARD wrote: Before 93dcc22, error from setting the vnc password to an empty string, when QEMU wasn't expected a password, never prevented the creation of a guest, and only logged an error message. Reported-by: Roger Pau Monné Fixes:

Re: [Xen-devel] [BUGFIX PATCH for-4.13] sched: fix dom0less boot with the null scheduler

2019-11-07 Thread Jürgen Groß
On 06.11.19 16:58, Dario Faggioli wrote: In a dom0less configuration, if the null scheduler is used, the system may fail to boot, because the loop in null_unit_wake() never exits. Bisection showed that this behavior occurs since commit d545f1d6 ("xen: sched: deal with vCPUs being or becoming

Re: [Xen-devel] [PATCH for-4.13] tools: Fix local variable block

2019-11-07 Thread Jürgen Groß
On 01.11.19 20:13, Andrew Cooper wrote: c-indent-level isn't considered a safe variable, and "solaris" isn't a recognised C style. Both cause prompts when opening the files. Fix all blocks up per CODING_STYLE Signed-off-by: Andrew Cooper Release-acked-by: Juergen Gross Juergen

  1   2   3   4   5   6   7   8   9   10   >